Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-22 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review139054 --- Ship it! Ship It! - Andrew Onischuk On June 22, 2016, 11:21

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-22 Thread Victor Galgo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review139053 --- Ship it! Ship It! - Victor Galgo On June 22, 2016, 11:21 a.m

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-22 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/ --- (Updated June 22, 2016, 1:21 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-22 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/ --- (Updated June 22, 2016, 1:10 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-21 Thread Andrew Onischuk
> On June 21, 2016, 3:25 p.m., Andrew Onischuk wrote: > > We have some logs which are triggered with every heartbeat. This would > > flood logs badly if done every second. Could we fix this. (possibly in a > > separate jira) I think handling these on agent would be enough: INFO 2016-06-21 15:

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-21 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review138851 --- We have some logs which are triggered with every heartbeat. This w

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-21 Thread Sebastian Toader
> On June 20, 2016, 4:46 p.m., Andrew Onischuk wrote: > > Also we could miss some other thing like this (state/status), which bring > > slowdown. Would be nice to deploy fullstack with and without your patch. > > And see if it brings speedup, and not actually slowdown. The component status rep

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/ --- (Updated June 21, 2016, 5:19 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review138605 --- Also we could miss some other thing like this (state/status), whic

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review138597 --- Sebastian can you also make sure that status commands doesn't run

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/ --- (Updated June 20, 2016, 3:08 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review138587 --- Ship it! Ship It! - Laszlo Puskas On June 16, 2016, 4:43 p.m

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review138586 --- ambari-server/src/main/java/org/apache/ambari/server/agent/HeartB

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review138584 --- Ship it! Ship It! - Sandor Magyari On June 16, 2016, 4:43 p.

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review138582 --- Ship it! Ship It! - Andrew Onischuk On June 16, 2016, 4:43 p

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Victor Galgo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review138580 --- Ship it! Nice! - Victor Galgo On June 16, 2016, 4:43 p.m., S

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-16 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/ --- (Updated June 16, 2016, 6:43 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137827 --- Ship it! Ship It! - Alejandro Fernandez On June 15, 2016, 2:

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sumit Mohanty
> On June 15, 2016, 3:54 p.m., Andrew Onischuk wrote: > > ambari-agent/src/main/python/ambari_agent/Controller.py, line 281 > > > > > > Do we really want to do this only if there are tasks pending. > > > >

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sebastian Toader
> On June 15, 2016, 5:57 p.m., Andrew Onischuk wrote: > > Also is there any benchmarks if this really increases the deploy time for > > BP scenario? Yes currently if you have a host where commands are organized into 5 stages than this can lead to 40 seconds delay due to the 10 sec delay betwee

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sebastian Toader
> On June 15, 2016, 5:54 p.m., Andrew Onischuk wrote: > > ambari-agent/src/main/python/ambari_agent/Controller.py, line 281 > > > > > > Do we really want to do this only if there are tasks pending. > > > >

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137752 --- Also is there any benchmarks if this really increases the deploy t

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137750 --- ambari-agent/src/main/python/ambari_agent/Controller.py (line 281

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137751 --- Ship it! Ship It! - Sandor Magyari On June 15, 2016, 2:55 p.

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/ --- (Updated June 15, 2016, 4:55 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review137717 --- Ship it! Ship It! - Robert Levas On June 15, 2016, 5:46 a.m.

Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/ --- Review request for Ambari, Andrew Onischuk, Laszlo Puskas, Robert Levas, Sandor