Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Jonathan Hurley
> On July 28, 2016, 3:38 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/HostUtils.java, > > lines 44-46 > > > > > > Could you instead use Guava's `InternetDomainName.isVal

Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Robert Levas
> On July 28, 2016, 3:38 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/HostUtils.java, > > lines 44-46 > > > > > > Could you instead use Guava's `InternetDomainName.isVal

Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50577/#review143988 --- Ship it! Ship It! - Nate Cole On July 28, 2016, 2:09 p.m., R

Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50577/#review143980 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50577/#review143979 --- Ship it! Ship It! - Robert Nettleton On July 28, 2016, 6:09

Review Request 50577: Ensure the supplied hostname is a valid hostname when signing agent-side host certs

2016-07-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50577/ --- Review request for Ambari, Dmytro Sen, Jonathan Hurley, Myroslav Papirkovskyy, N