Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-09 Thread Hemanth Yamijala
> On Aug. 9, 2016, 1:21 p.m., Oliver Szabo wrote: > > commited to trunk: 6dcf638192e8abff967c405cc9ef01b4dfc3b764 > > thanks for the contribution, > > you can close that and repoen it with a patch for 2.5 (if the branch-2.5 is > > created) Thanks, Oliver! - Hemanth

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50884/#review145213 --- commited to trunk: 6dcf638192e8abff967c405cc9ef01b4dfc3b764

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Oliver Szabo
> On Aug. 8, 2016, 10:10 a.m., Hayat Behlim wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java, > > line 47 > > > > > > I wanted S3Util as a singleton

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Oliver Szabo
> On Aug. 8, 2016, 10:10 a.m., Hayat Behlim wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java, > > line 47 > > > > > > I wanted S3Util as a singleton

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Hayat Behlim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50884/#review145084 --- Ship it! Ship It! - Hayat Behlim On Aug. 8, 2016, 5:07

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Hayat Behlim
> On Aug. 8, 2016, 10:10 a.m., Hayat Behlim wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java, > > line 47 > > > > > > I wanted S3Util as a singleton

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Hemanth Yamijala
> On Aug. 8, 2016, 10:10 a.m., Hayat Behlim wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java, > > line 47 > > > > > > I wanted S3Util as a singleton