Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/#review145421 --- Ship it! Ship It! - Swapan Shridhar On Aug. 10, 2016, 10:44

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/ --- (Updated Aug. 10, 2016, 10:44 p.m.) Review request for Ambari, Dmytro

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/#review145379 --- Ship it! Ship It! - Nate Cole On Aug. 10, 2016, 2:25 p.m.,

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

> On Aug. 10, 2016, 8:28 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java, > > lines 42-51 > > > > > > Shouldn't need a new enum when TRUE/FALSE/NULL would

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

> On Aug. 10, 2016, 8:28 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java, > > lines 42-51 > > > > > > Shouldn't need a new enum when TRUE/FALSE/NULL would

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

> On Aug. 10, 2016, 5:55 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java, > > line 49 > > > > > > If null works then why do we need "inherit"? null should

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

> On Aug. 10, 2016, 5:55 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java, > > line 49 > > > > > > If null works then why do we need "inherit"? null should

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

> On Aug. 10, 2016, 12:28 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java, > > lines 42-51 > > > > > > Shouldn't need a new enum when TRUE/FALSE/NULL would

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/#review145308 ---

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/ --- (Updated Aug. 10, 2016, 1:22 a.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

> On Aug. 9, 2016, 5:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java, > > lines 92-98 > > > > > > I agree with the other comments that this would

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

> On Aug. 9, 2016, 12:33 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java, > > lines 92-96 > > > > > > Doesn't seem like this would be difficult to tell in

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

> On Aug. 9, 2016, 9:58 a.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java, > > line 97 > > > > > > What if there are few dependencies in hierarhy? >

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/#review145224 ---

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

> On Aug. 9, 2016, 8:33 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java, > > lines 92-96 > > > > > > Doesn't seem like this would be difficult to tell in

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/#review145173 ---

Re: Review Request 50911: Calculation of versionAdvertised in is incorrect in metainfo.xml when parent is false and current ComponentInfo is true

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50911/#review145155 --- Ship it! Agree we should switch to three possibilities but