Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/#review148785 --- Ship it! Ship It! - Jonathan Hurley On Sept. 13, 2016, 4:44

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Jonathan Hurley
> On Sept. 13, 2016, 8:24 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2586 > > > > > > Although I understand the motivation, I

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Jonathan Hurley
> On Sept. 13, 2016, 8:24 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > lines 5292-5294 > > > > > > Why not just return here which

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/ --- (Updated Sept. 13, 2016, 4:44 p.m.) Review request for Ambari, Alejandro

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
> On Sept. 13, 2016, 8:29 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > lines 1334-1336 > > > > > > Is this specifically for SPNEGO, or any

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
> On Sept. 13, 2016, 8:24 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 2586 > > > > > > Although I understand the motivation, I

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
> On Sept. 13, 2016, 8:24 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > lines 5292-5294 > > > > > > Why not just return here which

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/#review148701 --- Ship it! LGTM, just confirming that if these are properties

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/#review148699 ---

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/ --- (Updated Sept. 13, 2016, 5 a.m.) Review request for Ambari, Alejandro

Re: Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/ --- (Updated Sept. 13, 2016, 4:59 a.m.) Review request for Ambari, Alejandro

Review Request 51822: Add Ambari configuration options to support Kerberos token authentication

2016-09-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51822/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.