Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-16 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/#review161689 --- Ship it! Ship It! - Dmytro Grinenko On Jan. 12, 2017, 2:09 p

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-15 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/#review161688 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-12 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/ --- (Updated Jan. 12, 2017, 2:09 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-12 Thread Dmytro Grinenko
> On Jan. 11, 2017, 2:30 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java, > > lines 241-242 > > > > > > If backupEntity is

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-12 Thread Dmytro Grinenko
> On Jan. 11, 2017, 1:48 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java, > > lines 246-248 > > > > > > I'm worried abou

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-12 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/#review161375 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-11 Thread Robert Levas
> On Jan. 11, 2017, 8:48 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java, > > lines 246-248 > > > > > > I'm worried abou

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-11 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/#review161238 --- Fix it, then Ship it! Ship It! ambari-server/src/main/java/or

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/#review161228 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-11 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/ --- Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Robert Levas.