Re: Review Request 62744: Alerts for OneFS mpack

2017-10-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/#review187778 --- Ship it! Ship It! - Jonathan Hurley On Oct. 12, 2017, 7:39

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/#review187773 --- Ship it! Ship It! - Sebastian Toader On Oct. 12, 2017, 1:39

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-12 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/ --- (Updated Oct. 12, 2017, 11:39 a.m.) Review request for Ambari, Jonathan

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-04 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/#review187100 --- As part of this review, I think we need to change how the

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-04 Thread Attila Magyar
> On Oct. 3, 2017, 5:34 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java > > Lines 20-21 (patched) > > > > > > This is a funny looking import. Use

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-04 Thread Attila Magyar
> On Oct. 3, 2017, 11:48 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java > > Lines 83 (patched) > > > > > > It's interesting to use the

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-04 Thread Attila Magyar
> On Oct. 3, 2017, 5:34 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java > > Lines 20-21 (patched) > > > > > > This is a funny looking import. Use

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-04 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/ --- (Updated Oct. 4, 2017, 8:16 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-03 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/#review187025 ---

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-03 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/#review186980 --- Fix it, then Ship it!

Review Request 62744: Alerts for OneFS mpack

2017-10-03 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, and Sebastian Toader.