Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/#review187189 --- Ship it! Ship It! - Jonathan Hurley On Oct. 5, 2017, 10:17 a

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-05 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/ --- (Updated Oct. 5, 2017, 4:17 p.m.) Review request for Ambari, Andrew Onischuk, D

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/#review187170 --- Ship it! Ship It! - Nate Cole On Oct. 4, 2017, 10:32 a.m., A

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Attila Doroszlai
> On Oct. 4, 2017, 5:18 p.m., Nate Cole wrote: > > ambari-common/src/main/python/resource_management/core/providers/package/__init__.py > > Lines 42-43 (original), 42-43 (patched) > > > > > > This type of change from

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/#review187101 --- ambari-common/src/main/python/resource_management/core/providers/

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/#review187097 --- As part of this review, I think we need to change how the AmbariS

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Jonathan Hurley
> On Oct. 4, 2017, 11:06 a.m., Jonathan Hurley wrote: > > As part of this review, I think we need to change how the > > AmbariServerAlertService creates its threadpool for the AlertRunnables: > > > > ``` > > /** > >* The executor to use to run all {@link Runnable} alert classes. > >*/

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/ --- (Updated Oct. 4, 2017, 4:32 p.m.) Review request for Ambari, Andrew Onischuk, D

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/#review187078 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 4, 2017, 1:02

Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan Hurley,