Re: Review Request 46263: AMBARI-15906 Make Ranger TagSync to be installed as a slave and optional

2016-04-16 Thread Mugdha Varadkar 


> On April 15, 2016, 7:53 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml,
> >  line 27
> > 
> >
> > Does this value need to be changed during RU/EU from HDP 2.4 to 2.5?

Tagsync support is available only from HDP 2.5, changing default value to false.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46263/#review129181
---


On April 15, 2016, 6:51 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46263/
> ---
> 
> (Updated April 15, 2016, 6:51 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan 
> Hurley, Jayush Luniya, Mahadev Konar, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15906
> https://issues.apache.org/jira/browse/AMBARI-15906
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In order to support blueprints to setup cluster without TagSync, make stack 
> level changes to allow Ranger TagSync to be installed as a optional slave 
> component.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  4466671 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
>  cfcab3b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 
> 9f96308 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 7407da3 
> 
> Diff: https://reviews.apache.org/r/46263/diff/
> 
> 
> Testing
> ---
> 
> Tested on Centos 6 with and without RANGER_TAGSYNC.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 46263: AMBARI-15906 Make Ranger TagSync to be installed as a slave and optional

2016-04-16 Thread Mugdha Varadkar 


> On April 15, 2016, 4:46 p.m., Jonathan Hurley wrote:
> > Have you validated that TagSync installations in existing clusters still 
> > work after upgrading to this version of Ambari where it changes from a 
> > master to a slave?

Tagsync support is available only from HDP 2.5
In the previous Review Request(https://reviews.apache.org/r/46016/) made 
Tagsync component as master now changing it to slave, to support previous 
version of blueprints.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46263/#review129146
---


On April 15, 2016, 6:51 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46263/
> ---
> 
> (Updated April 15, 2016, 6:51 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan 
> Hurley, Jayush Luniya, Mahadev Konar, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15906
> https://issues.apache.org/jira/browse/AMBARI-15906
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In order to support blueprints to setup cluster without TagSync, make stack 
> level changes to allow Ranger TagSync to be installed as a optional slave 
> component.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  4466671 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
>  cfcab3b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 
> 9f96308 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 7407da3 
> 
> Diff: https://reviews.apache.org/r/46263/diff/
> 
> 
> Testing
> ---
> 
> Tested on Centos 6 with and without RANGER_TAGSYNC.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 46297: Views work for Hue to Views Migration Tool.

2016-04-16 Thread Pradarttana Panda 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46297/
---

Review request for Ambari, Gaurav Nagar and Rohit Choudhary.


Bugs: AMBARI-15933
https://issues.apache.org/jira/browse/AMBARI-15933


Repository: ambari


Description
---

Views work for Hue to Views Migration Tool.
Issue : https://issues.apache.org/jira/browse/AMBARI-15933


Diffs
-

  contrib/views/hueambarimigration/pom.xml PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/controller/configurationcheck/ConfigurationCheck.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/controller/configurationcheck/ProgressBarStatus.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/controller/hive/HiveHistoryMigration.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/controller/hive/HiveSavedQueryMigration.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/controller/pig/PigJobMigration.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/controller/pig/PigScriptMigration.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/controller/revertchange/RevertChange.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/datasource/ConnectionPool.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/datasource/DataSourceAmbariDatabase.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/datasource/DataSourceHueDatabase.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/model/PojoHive.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/model/PojoPig.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/service/configurationcheck/ConfFileReader.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/service/hive/HiveHistoryQueryImpl.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/service/hive/HiveSavedQueryImpl.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/service/pig/PigJobImpl.java
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/java/org/apache/ambari/view/huetoambarimigration/service/pig/PigScriptImpl.java
 PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/WEB-INF/web.xml 
PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/checkconfiguration.jsp 
PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/css/back.css PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/resources/css/bootstrap-datetimepicker.min.css
 PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/css/bootstrap.css 
PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/css/bootstrap.css.map 
PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/css/bootstrap.min.css 
PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/css/bootstrap.min.css.map 
PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/css/jquery.timepicker.css 
PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/resources/fonts/glyphicons-halflings-regular.eot
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/resources/fonts/glyphicons-halflings-regular.svg
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/resources/fonts/glyphicons-halflings-regular.ttf
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/resources/fonts/glyphicons-halflings-regular.woff
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/resources/fonts/glyphicons-halflings-regular.woff2
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/resources/hivehistoryquerymigration.jsp
 PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/resources/hivesavedquerymigration.jsp 
PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/homepage.jsp PRE-CREATION 
  
contrib/views/hueambarimigration/src/main/resources/image/ProgressBar_indeterminate.gif
 PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/image/bar1.gif 
PRE-CREATION 
  contrib/views/hueambarimigration/src/main/resources/image/file.gif 
PRE-CREATION

Review Request 46301: Fix Ubuntu/Debian builds for Logsearch

2016-04-16 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46301/
---

Review request for Ambari, Andrew Onischuk and Sumit Mohanty.


Bugs: AMBARI-15934
https://issues.apache.org/jira/browse/AMBARI-15934


Repository: ambari


Description
---

deb.dependency.list could not be parsed from the packages file.

"Problem parsing dependency Depends"
"The package lists or status file could not be parsed or opened"
If added dependency.list to appender and logfeeder too. (to avoid that to use 
default packages: "default-jre | java6-runtime" )


Diffs
-

  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/control
 9d07541 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/control
 9d07541 
  ambari-logsearch/pom.xml 3d4edcd 

Diff: https://reviews.apache.org/r/46301/diff/


Testing
---

testing done. Manually tried to install deb packages.


Thanks,

Oliver Szabo

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-16 Thread Masahiro Tanaka 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/
---

(Updated April 16, 2016, 7:02 p.m.)


Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.


Changes
---

Update a patch


Repository: ambari


Description
---

In templetonSmoke.sh, there are
1) unnecessary `exit 0`
2) lack of redirect `>` command
3) unassigned variable

we should correct them all to check the HIVE service properly.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 dd00e02 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
 9965bfa9 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
6c4dc00 

Diff: https://reviews.apache.org/r/45998/diff/


Testing
---

mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0


Thanks,

Masahiro Tanaka

Re: Review Request 46301: Fix Ubuntu/Debian builds for Logsearch

2016-04-16 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46301/#review129248
---


Ship it!




Ship It!

- Sumit Mohanty


On April 16, 2016, 2:29 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46301/
> ---
> 
> (Updated April 16, 2016, 2:29 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15934
> https://issues.apache.org/jira/browse/AMBARI-15934
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> deb.dependency.list could not be parsed from the packages file.
> 
> "Problem parsing dependency Depends"
> "The package lists or status file could not be parsed or opened"
> If added dependency.list to appender and logfeeder too. (to avoid that to use 
> default packages: "default-jre | java6-runtime" )
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/control
>  9d07541 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/control
>  9d07541 
>   ambari-logsearch/pom.xml 3d4edcd 
> 
> Diff: https://reviews.apache.org/r/46301/diff/
> 
> 
> Testing
> ---
> 
> testing done. Manually tried to install deb packages.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>