Re: Review Request 47300: Included few more steps in "Take a tour" feature and few more enhancements

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47300/#review133071
---


Ship it!




Ship It!

- Oliver Szabo


On May 12, 2016, 11:06 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47300/
> ---
> 
> (Updated May 12, 2016, 11:06 a.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Jaimin Jetly, Oliver Szabo, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16632
> https://issues.apache.org/jira/browse/AMBARI-16632
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains
> 1) Added few steps more in "Take a tour" option.
> 2) When url contains "host_name" and "component_name" params than separate 
> tab should be open for that component.
> 3) Comparison tab clean-up, default pageSize changed to 25 and css changes.
> 4) In histogram graph, time gap is shown above the graph.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Intro.js
>  6abccf6 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/Utils.js
>  5d55689 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js
>  ba21b65 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/DatePickerLayout.js
>  0849820 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/MainLayoutView.js
>  09bbacc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/graphs/GraphLayoutView.js
>  805b507 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/ComparisonView.js
>  8ad0c4b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/HierarchyTabLayoutView.js
>  cb4228c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/tabs/LogFileView.js
>  2d19d78 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/troubleshoot/TroubleShootLayoutView.js
>  e1bc90a 
>   ambari-logsearch/ambari-logsearch-portal/src/main/webapp/styles/style.css 
> 05fd491 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/audit/AuditTabLayoutView_tmpl.html
>  2f0a596 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/graphs/GraphLayoutView_tmpl.html
>  fb4ee3c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/tabs/HierarchyTabLayoutView_tmpl.html
>  4564562 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/templates/troubleshoot/TroubleShootLayoutView_tmpl.html
>  b3eeaf5 
> 
> Diff: https://reviews.apache.org/r/47300/diff/
> 
> 
> Testing
> ---
> 
> Tested in local Ambari environment.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 47074: AMBARI-16290 : Handle repository creation for Hive in Ranger for kerberised environments

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47074/#review133070
---


Ship it!




Ship It!

- Robert Levas


On May 9, 2016, 5:56 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47074/
> ---
> 
> (Updated May 9, 2016, 5:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16290
> https://issues.apache.org/jira/browse/AMBARI-16290
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Problem Statement :**
> 1) Hive Restart fails to create repository in Ranger and goes for retries due 
> to missing principal after enabling hive plugin in in kerberized environment.
> 
> 2) Yarn Restart fails to create repository in Ranger in simple environment.
> 
> ** Proposed Solution : **
> 1) Fixing principal required for hive server, adding new parameters required 
> for Ranger service creation.
> 2) Fixing call for repository creation in simple environemnt.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  4f319ea 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  4a071ca 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  d3fc173 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  864d937 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  f42185e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  72eb3ad 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  ec43fea 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  92eaaab 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
>  12ccef6 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  1dd25ce 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  c5f8940 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d715a25 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
>  ba4c777 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  cf01965 
> 
> Diff: https://reviews.apache.org/r/47074/diff/
> 
> 
> Testing
> ---
> 
> 1) Verified Enable Hive Plugin and Ranger service creation after enabling 
> plugin in kerberos / simple  environment.
> 
> 2) Verified Enable Yarn Plugin and Ranger service creation after enabling 
> plugin in simple  environment.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 47331: AMBARI-16649 : RegionServer and Nimbus start failed on secure cluster due to Ranger stack changes

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47331/#review133073
---


Ship it!




Ship It!

- Andrew Onischuk


On May 13, 2016, 9:46 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47331/
> ---
> 
> (Updated May 13, 2016, 9:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin 
> Jetly, Mahadev Konar, Nate Cole, Robert Levas, Sumit Mohanty, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16649
> https://issues.apache.org/jira/browse/AMBARI-16649
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart of Hbase and Storm fails on Kerberos env due to missing principals 
> for older stacks.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  d3fc173 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d715a25 
> 
> Diff: https://reviews.apache.org/r/47331/diff/
> 
> 
> Testing
> ---
> 
> Verified Hbase and Storm enable / disable plugin for Ranger in Kerberos env.
> 
> Verified normal Install / Restarts of Hbase and Storm as well (in Kerberos 
> env).
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Review Request 47343: DevDeploy: Cannot connect to the server using SSLv3

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47343/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-16658
https://issues.apache.org/jira/browse/AMBARI-16658


Repository: ambari


Description
---

os-s11-3-irzlbs-devdeployerie-5:~ # curl --sslv3 --insecure -u admin:admin 
https://172.22.106.251:8443/api/v1/clusters/cl1/hosts
curl: (35) Unknown SSL protocol error in connection to 172.22.106.251:8443 

os-s11-3-irzlbs-devdeployerie-5:~ # curl --tlsv1 --insecure -u admin:admin 
https://172.22.106.251:8443/api/v1/clusters/cl1/hosts
{
  "href" : "http://172.22.106.251:8443/api/v1/clusters/cl1/hosts;,
...


There are no security.server.disabled.protocols or
security.server.disabled.ciphers in ambari.properties.

An error from QE scripts (it's caused because "requests" lib is using sslv3 by
default):



2016-05-12 08:50:55,683 INFO requests.packages.urllib3.connectionpool : 
Starting new HTTPS connection (1): 
os-s11-3-aijuzs-devdeployerie-5.openstacklocal
Traceback (most recent call last):
  File "WireEncryption.py", line 205, in 
main()
  File "WireEncryption.py", line 201, in main
we.TestWireEncryption()
  File "WireEncryption.py", line 36, in TestWireEncryption
hosts = self.weu.apicl.get_all_hosts()
  File "/ambari_deploy/wireencryption/APICoreLib.py", line 89, in 
get_all_hosts
result = self.http_get_request(uri)
  File "/ambari_deploy/wireencryption/APICoreLib.py", line 51, in 
http_get_request
response = requests.get(url=url, auth=basic_auth, verify=False)
  File "/usr/lib64/python2.6/site-packages/requests/api.py", line 68, in get
return request('get', url, **kwargs)
  File "/usr/lib64/python2.6/site-packages/requests/api.py", line 50, in 
request
response = session.request(method=method, url=url, **kwargs)
  File "/usr/lib64/python2.6/site-packages/requests/sessions.py", line 464, 
in request
resp = self.send(prep, **send_kwargs)
  File "/usr/lib64/python2.6/site-packages/requests/sessions.py", line 576, 
in send
r = adapter.send(request, **kwargs)
  File "/usr/lib64/python2.6/site-packages/requests/adapters.py", line 428, 
in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: [Errno 8] _ssl.c:491: EOF occurred in 
violation of protocol


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 a071c9b 

Diff: https://reviews.apache.org/r/47343/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 47345: yarn.timeline-service.enabled is set to false in secure cluster

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47345/
---

Review request for Ambari, Oliver Szabo, Sandor Magyari, and Swapan Shridhar.


Bugs: AMBARI-16654
https://issues.apache.org/jira/browse/AMBARI-16654


Repository: ambari


Description
---

yarn.timeline-service.enabled property is set to false when Kerberos is 
enabled. It should set set to true.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
123ff7c 

Diff: https://reviews.apache.org/r/47345/diff/


Testing
---

# Local test results:
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:12:48.354s
[INFO] Finished at: Fri May 13 07:43:07 EDT 2016
[INFO] Final Memory: 62M/1853M
[INFO] 

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 47331: AMBARI-16649 : RegionServer and Nimbus start failed on secure cluster due to Ranger stack changes

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47331/#review133077
---


Ship it!




Ship It!

- Nate Cole


On May 13, 2016, 5:46 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47331/
> ---
> 
> (Updated May 13, 2016, 5:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin 
> Jetly, Mahadev Konar, Nate Cole, Robert Levas, Sumit Mohanty, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16649
> https://issues.apache.org/jira/browse/AMBARI-16649
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart of Hbase and Storm fails on Kerberos env due to missing principals 
> for older stacks.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  d3fc173 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d715a25 
> 
> Diff: https://reviews.apache.org/r/47331/diff/
> 
> 
> Testing
> ---
> 
> Verified Hbase and Storm enable / disable plugin for Ranger in Kerberos env.
> 
> Verified normal Install / Restarts of Hbase and Storm as well (in Kerberos 
> env).
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 47343: DevDeploy: Cannot connect to the server using SSLv3

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47343/#review133078
---


Ship it!




Ship It!

- Robert Levas


On May 13, 2016, 7:55 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47343/
> ---
> 
> (Updated May 13, 2016, 7:55 a.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-16658
> https://issues.apache.org/jira/browse/AMBARI-16658
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> os-s11-3-irzlbs-devdeployerie-5:~ # curl --sslv3 --insecure -u admin:admin 
> https://172.22.106.251:8443/api/v1/clusters/cl1/hosts
> curl: (35) Unknown SSL protocol error in connection to 
> 172.22.106.251:8443 
> 
> os-s11-3-irzlbs-devdeployerie-5:~ # curl --tlsv1 --insecure -u 
> admin:admin https://172.22.106.251:8443/api/v1/clusters/cl1/hosts
> {
>   "href" : "http://172.22.106.251:8443/api/v1/clusters/cl1/hosts;,
> ...
> 
> 
> There are no security.server.disabled.protocols or
> security.server.disabled.ciphers in ambari.properties.
> 
> An error from QE scripts (it's caused because "requests" lib is using sslv3 by
> default):
> 
> 
> 
> 2016-05-12 08:50:55,683 INFO requests.packages.urllib3.connectionpool : 
> Starting new HTTPS connection (1): 
> os-s11-3-aijuzs-devdeployerie-5.openstacklocal
> Traceback (most recent call last):
>   File "WireEncryption.py", line 205, in 
> main()
>   File "WireEncryption.py", line 201, in main
> we.TestWireEncryption()
>   File "WireEncryption.py", line 36, in TestWireEncryption
> hosts = self.weu.apicl.get_all_hosts()
>   File "/ambari_deploy/wireencryption/APICoreLib.py", line 89, in 
> get_all_hosts
> result = self.http_get_request(uri)
>   File "/ambari_deploy/wireencryption/APICoreLib.py", line 51, in 
> http_get_request
> response = requests.get(url=url, auth=basic_auth, verify=False)
>   File "/usr/lib64/python2.6/site-packages/requests/api.py", line 68, in 
> get
> return request('get', url, **kwargs)
>   File "/usr/lib64/python2.6/site-packages/requests/api.py", line 50, in 
> request
> response = session.request(method=method, url=url, **kwargs)
>   File "/usr/lib64/python2.6/site-packages/requests/sessions.py", line 
> 464, in request
> resp = self.send(prep, **send_kwargs)
>   File "/usr/lib64/python2.6/site-packages/requests/sessions.py", line 
> 576, in send
> r = adapter.send(request, **kwargs)
>   File "/usr/lib64/python2.6/site-packages/requests/adapters.py", line 
> 428, in send
> raise SSLError(e, request=request)
> requests.exceptions.SSLError: [Errno 8] _ssl.c:491: EOF occurred in 
> violation of protocol
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  a071c9b 
> 
> Diff: https://reviews.apache.org/r/47343/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47345: yarn.timeline-service.enabled is set to false in secure cluster

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47345/#review133080
---


Ship it!




Ship It!

- Sandor Magyari


On May 13, 2016, 12:38 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47345/
> ---
> 
> (Updated May 13, 2016, 12:38 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Sandor Magyari, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-16654
> https://issues.apache.org/jira/browse/AMBARI-16654
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> yarn.timeline-service.enabled property is set to false when Kerberos is 
> enabled. It should set set to true.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> 123ff7c 
> 
> Diff: https://reviews.apache.org/r/47345/diff/
> 
> 
> Testing
> ---
> 
> # Local test results:
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:12:48.354s
> [INFO] Finished at: Fri May 13 07:43:07 EDT 2016
> [INFO] Final Memory: 62M/1853M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 47344: Log count text on Log level select boxes in Service Logs Tab not getting updated while checking and unchecking

[Dharmesh Makwana]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47344/
---

Review request for Ambari, Don Bosco Durai, Jaimin Jetly, Oliver Szabo, and 
Sumit Mohanty.


Bugs: AMBARI-16657
https://issues.apache.org/jira/browse/AMBARI-16657


Repository: ambari


Description
---

Patch contains fix for log level count not getting updated while checking and 
unchecking


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/LogLevelBoxView.js
 2d5096a 

Diff: https://reviews.apache.org/r/47344/diff/


Testing
---

Tested in local Ambari environment.


Thanks,

Dharmesh Makwana

Re: Review Request 47344: Log count text on Log level select boxes in Service Logs Tab not getting updated while checking and unchecking

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47344/#review133082
---


Ship it!




Ship It!

- Oliver Szabo


On May 13, 2016, 12:01 p.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47344/
> ---
> 
> (Updated May 13, 2016, 12:01 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Jaimin Jetly, Oliver Szabo, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16657
> https://issues.apache.org/jira/browse/AMBARI-16657
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains fix for log level count not getting updated while checking and 
> unchecking
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/dashboard/LogLevelBoxView.js
>  2d5096a 
> 
> Diff: https://reviews.apache.org/r/47344/diff/
> 
> 
> Testing
> ---
> 
> Tested in local Ambari environment.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

[Dharmesh Makwana]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47296/
---

(Updated May 13, 2016, 6:48 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

Reverted the resultSize property and review comments changes made.


Bugs: AMBARI-16629
https://issues.apache.org/jira/browse/AMBARI-16629


Repository: ambari


Description
---

Patch contains
1) Authentication : change the API as per suggestion and support for roles in 
authentication process.
2) resultSize property removed from collection class.
3) "Preview" issue fixed.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
 0442cf9 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
 a60402e 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
 cc61127 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
 8535039 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
 79a414c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
 315d736 

Diff: https://reviews.apache.org/r/47296/diff/


Testing
---

Tested in my local Ambari environment.


Thanks,

Dharmesh Makwana

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

[Dharmesh Makwana]

> On May 12, 2016, 1:35 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java,
> >  line 56
> > 
> >
> > Wouldn't it be simpler to just override the toString() methods for this 
> > enumerated type?

Sure, made the change.


- Dharmesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47296/#review132892
---


On May 13, 2016, 6:48 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47296/
> ---
> 
> (Updated May 13, 2016, 6:48 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16629
> https://issues.apache.org/jira/browse/AMBARI-16629
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains
> 1) Authentication : change the API as per suggestion and support for roles in 
> authentication process.
> 2) resultSize property removed from collection class.
> 3) "Preview" issue fixed.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  0442cf9 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  a60402e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
>  cc61127 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
>  8535039 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  79a414c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
>  315d736 
> 
> Diff: https://reviews.apache.org/r/47296/diff/
> 
> 
> Testing
> ---
> 
> Tested in my local Ambari environment.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

[Dharmesh Makwana]

> On May 12, 2016, 3:37 p.m., Sumit Mohanty wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java,
> >  line 147
> > 
> >
> > Any reason this is being removed?

We were not using that property anymore, for now keeping that property as it is.


- Dharmesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47296/#review132928
---


On May 13, 2016, 6:48 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47296/
> ---
> 
> (Updated May 13, 2016, 6:48 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16629
> https://issues.apache.org/jira/browse/AMBARI-16629
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains
> 1) Authentication : change the API as per suggestion and support for roles in 
> authentication process.
> 2) resultSize property removed from collection class.
> 3) "Preview" issue fixed.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  0442cf9 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  a60402e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
>  cc61127 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
>  8535039 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  79a414c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
>  315d736 
> 
> Diff: https://reviews.apache.org/r/47296/diff/
> 
> 
> Testing
> ---
> 
> Tested in my local Ambari environment.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/
---

(Updated May 13, 2016, 7:09 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Changes
---

Added Update for tez view property change


Bugs: AMBARI-16138
https://issues.apache.org/jira/browse/AMBARI-16138


Repository: ambari


Description
---

If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
hive auth based on the hive and hdfs service config.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 3547ad3 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
 f36e640 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
05b55d2 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
 1442748 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
 f5e9bcf 
  contrib/views/hive/src/main/resources/view.xml 8f8a470 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java 
25db721 
  contrib/views/pig/src/main/resources/view.xml 9df91f8 
  contrib/views/tez/readme.md fdb9459 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 
440ac65 
  contrib/views/tez/src/main/resources/view.xml d8105f1 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 1bace94 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
 4911455 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 8b45cd6 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
 c7c0990 

Diff: https://reviews.apache.org/r/46738/diff/


Testing
---

Manually Tested on local Vm.
Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.


Thanks,

Gaurav Nagar

Re: Review Request 47322: AMBARI-16640. jdeb does not preserve permissions for Solr deb package

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47322/
---

(Updated May 13, 2016, 1:18 p.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-16640
https://issues.apache.org/jira/browse/AMBARI-16640


Repository: ambari


Description
---

In case ambari creates deb package from a directory (not from tar.gz), then 
permissions not preserved.


Diffs
-

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 90504e6 

Diff: https://reviews.apache.org/r/47322/diff/


Testing
---

FT: created deb package in debian7.6, mapped permissions looking good.


Thanks,

Oliver Szabo

Re: Review Request 47342: Error while loading slider view: Unable to initialize Slider view

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47342/#review133090
---


Ship it!




Ship It!

- Nitiraj Rathore


On May 13, 2016, 11:57 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47342/
> ---
> 
> (Updated May 13, 2016, 11:57 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16656
> https://issues.apache.org/jira/browse/AMBARI-16656
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added URLStreamProviderBasicAuth for connecting to ambari.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java
>  3d4a08d 
>   
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/URLStreamProviderBasicAuth.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47342/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47338: Ambari admin test fails with Error : Unexpected request: GET /api/v1/remoteclusters

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47338/#review133085
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 13, 2016, 8:43 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47338/
> ---
> 
> (Updated May 13, 2016, 8:43 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16652
> https://issues.apache.org/jira/browse/AMBARI-16652
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added mocked http call to /api/v1/remoteclusters.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js
>  35ddc16 
> 
> Diff: https://reviews.apache.org/r/47338/diff/
> 
> 
> Testing
> ---
> 
> npm test on ambari/ambari-admin/src/main/resources/ui/admin-web
> 
> INFO [karma]: Karma v0.12.16 server started at http://localhost:9876/
> INFO [launcher]: Starting browser PhantomJS
> INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket GHd8JD3JSyDqZ8OcRrCV 
> with id 40363888
> LOG: null
> PhantomJS 1.9.7 (Mac OS X): Executed 64 of 64 SUCCESS (0.154 secs / 0.364 
> secs)
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47331: AMBARI-16649 : RegionServer and Nimbus start failed on secure cluster due to Ranger stack changes

[Srimanth Gunturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47331/#review133105
---


Ship it!




Ship It!

- Srimanth Gunturi


On May 13, 2016, 9:46 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47331/
> ---
> 
> (Updated May 13, 2016, 9:46 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin 
> Jetly, Mahadev Konar, Nate Cole, Robert Levas, Sumit Mohanty, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16649
> https://issues.apache.org/jira/browse/AMBARI-16649
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart of Hbase and Storm fails on Kerberos env due to missing principals 
> for older stacks.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  d3fc173 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  d715a25 
> 
> Diff: https://reviews.apache.org/r/47331/diff/
> 
> 
> Testing
> ---
> 
> Verified Hbase and Storm enable / disable plugin for Ranger in Kerberos env.
> 
> Verified normal Install / Restarts of Hbase and Storm as well (in Kerberos 
> env).
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

[Robert Nettleton]

> On May 12, 2016, 1:35 p.m., Robert Nettleton wrote:
> > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/view/VList.java,
> >  line 46
> > 
> >
> > This change is problematic, since the Ambari Integration API already 
> > relies on the return results from the LogSearch Server.
> > 
> > At this point in the dev cycle, we can't be changing the API at all 
> > from LogSearch, or the Ambari Integration will be broken.
> > 
> > Because this is one of the types serialized in responses to the REST 
> > API, this is a part of the API, and at this point in the dev cycle should 
> > be frozen.  
> > 
> > I'd request that this part of the patch be reverted. 
> > 
> > Thanks.
> 
> Dharmesh Makwana wrote:
> I have reverted the resultProperty changes, thanks.

Great.  Thanks for fixing this.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47296/#review132892
---


On May 13, 2016, 6:48 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47296/
> ---
> 
> (Updated May 13, 2016, 6:48 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16629
> https://issues.apache.org/jira/browse/AMBARI-16629
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains
> 1) Authentication : change the API as per suggestion and support for roles in 
> authentication process.
> 2) resultSize property removed from collection class.
> 3) "Preview" issue fixed.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  0442cf9 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  a60402e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
>  cc61127 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
>  8535039 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  79a414c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
>  315d736 
> 
> Diff: https://reviews.apache.org/r/47296/diff/
> 
> 
> Testing
> ---
> 
> Tested in my local Ambari environment.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47296/#review133099
---


Ship it!




Ship It!

- Robert Nettleton


On May 13, 2016, 6:48 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47296/
> ---
> 
> (Updated May 13, 2016, 6:48 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16629
> https://issues.apache.org/jira/browse/AMBARI-16629
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Patch contains
> 1) Authentication : change the API as per suggestion and support for roles in 
> authentication process.
> 2) resultSize property removed from collection class.
> 3) "Preview" issue fixed.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/LogsMgr.java
>  0442cf9 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  a60402e 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/query/QueryGenerationBase.java
>  cc61127 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
>  8535039 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  79a414c 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties
>  315d736 
> 
> Diff: https://reviews.apache.org/r/47296/diff/
> 
> 
> Testing
> ---
> 
> Tested in my local Ambari environment.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 47347: Zeppelin View has issues in opening iFrame, when zeppelin view is installed on non-gateway node

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47347/#review133108
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 13, 2016, 2:22 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47347/
> ---
> 
> (Updated May 13, 2016, 2:22 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16659
> https://issues.apache.org/jira/browse/AMBARI-16659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed looping for getting Zeppelin host.
> 
> 
> Diffs
> -
> 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp 5c57343 
> 
> Diff: https://reviews.apache.org/r/47347/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47342: Error while loading slider view: Unable to initialize Slider view

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47342/#review133089
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 13, 2016, 11:57 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47342/
> ---
> 
> (Updated May 13, 2016, 11:57 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16656
> https://issues.apache.org/jira/browse/AMBARI-16656
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added URLStreamProviderBasicAuth for connecting to ambari.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/BaseHttpClient.java
>  3d4a08d 
>   
> contrib/views/slider/src/main/java/org/apache/ambari/view/slider/rest/client/URLStreamProviderBasicAuth.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47342/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/
---

(Updated May 13, 2016, 1:46 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Changes
---

Added javadoc for UpgradePack changes


Bugs: AMBARI-15388
https://issues.apache.org/jira/browse/AMBARI-15388


Repository: ambari


Description
---

Currently the upgrade is defined as a series of xml files specific to the 
current stack version and the target stack version. Each upgrade xml defines 
the overall sequence of the upgrade and what needs to be done for each service. 
It would both easier to maintain and easier to add new services, if the 
services themselves could specify what should be done during their upgrade.

There are two ways to make these changes, the alternate approach would be to 
only make the java changes and not split the upgrade xml files.  This would 
still allow new services to add themselves into the upgrade.  The benefit of 
this is that for the stack services you only have one upgrade xml file.  The 
problem with that is it is easier for a particular service to have 
unintentional changes between upgrade xml files.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
 7f7a49e 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
 8a7b42b 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
f781574 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 
13d5047 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
6129ec0 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 88f6e19 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
43cefb9 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
 b860731 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 67d7fdb 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
 5cda422 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
6b74af0 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
9fb2bba 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
1cd2ffa 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
e3bc7a3 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
9c6a02d 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
1745de8 

Diff: https://reviews.apache.org/r/45169/diff/


Testing
---

Manual testing so far.  I have the code read the upgrade xml and all of its 
service specific xml files, built the upgrade pack and then write the full 
upgrade xml to disk and then compare the results to the original upgrade xml.

This review is mostly for the design doc which is attached to the JIRA.  Not 
sure how to create a review board with a design doc instead of a patch file.


Thanks,

Tim Thorpe

Re: Review Request 47347: Zeppelin View has issues in opening iFrame, when zeppelin view is installed on non-gateway node

[Rohit Choudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47347/#review133107
---


Ship it!




Ship It!

- Rohit Choudhary


On May 13, 2016, 2:22 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47347/
> ---
> 
> (Updated May 13, 2016, 2:22 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16659
> https://issues.apache.org/jira/browse/AMBARI-16659
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changed looping for getting Zeppelin host.
> 
> 
> Diffs
> -
> 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp 5c57343 
> 
> Diff: https://reviews.apache.org/r/47347/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47338: Ambari admin test fails with Error : Unexpected request: GET /api/v1/remoteclusters

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47338/#review133087
---


Ship it!




Ship It!

- Nitiraj Rathore


On May 13, 2016, 8:43 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47338/
> ---
> 
> (Updated May 13, 2016, 8:43 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16652
> https://issues.apache.org/jira/browse/AMBARI-16652
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added mocked http call to /api/v1/remoteclusters.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js
>  35ddc16 
> 
> Diff: https://reviews.apache.org/r/47338/diff/
> 
> 
> Testing
> ---
> 
> npm test on ambari/ambari-admin/src/main/resources/ui/admin-web
> 
> INFO [karma]: Karma v0.12.16 server started at http://localhost:9876/
> INFO [launcher]: Starting browser PhantomJS
> INFO [PhantomJS 1.9.7 (Mac OS X)]: Connected on socket GHd8JD3JSyDqZ8OcRrCV 
> with id 40363888
> LOG: null
> PhantomJS 1.9.7 (Mac OS X): Executed 64 of 64 SUCCESS (0.154 secs / 0.364 
> secs)
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47237/
---

(Updated May 13, 2016, 11:04 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Richard Zang.


Changes
---

Changed "Ambari Admin" to "Ambari Administrator" for consistency in the role 
names as suggested by the reviewers.


Bugs: AMBARI-16449
https://issues.apache.org/jira/browse/AMBARI-16449


Repository: ambari


Description
---

Change permission_label for role AMBARI.ADMINISTRATOR from "Administrator" to 
"Ambari Admin"


Diffs (updated)
-

  ambari-server/docs/api/v1/permission-get.md d949344 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
 2389d0d 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql d77a0b3 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f6ee1e7 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6000d24 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 67bd38a 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
ea7ab7a 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1c3393e 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 2245f77 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
 67a94ea 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java
 f03d240 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java
 bcfae8d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java
 4e0ba24 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
 6cf520d 

Diff: https://reviews.apache.org/r/47237/diff/


Testing
---

Manually tested upgrade and new instance creation.

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 47332: Upgrade pack changes to work with Storm 1.0

[Sriharsha Chintalapani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47332/
---

(Updated May 13, 2016, 3:56 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Mohanty.


Bugs: AMBARI-16648
https://issues.apache.org/jira/browse/AMBARI-16648


Repository: ambari


Description
---

Upgrade pack changes to work with Storm 1.0


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
a7dbba3 

Diff: https://reviews.apache.org/r/47332/diff/


Testing
---


Thanks,

Sriharsha Chintalapani

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

[Robert Levas]

> On May 12, 2016, 11:34 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java,
> >  lines 387-388
> > 
> >
> > Should this be changed to "Cluster Admin" for consistency?

I am dropping this because we went the other way and changed Ambari Admin to 
Ambari Administrator.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47237/#review132925
---


On May 13, 2016, 11:04 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47237/
> ---
> 
> (Updated May 13, 2016, 11:04 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Richard Zang.
> 
> 
> Bugs: AMBARI-16449
> https://issues.apache.org/jira/browse/AMBARI-16449
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change permission_label for role AMBARI.ADMINISTRATOR from "Administrator" to 
> "Ambari Admin"
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/v1/permission-get.md d949344 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
>  2389d0d 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql d77a0b3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f6ee1e7 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6000d24 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 67bd38a 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> ea7ab7a 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1c3393e 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 2245f77 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
>  67a94ea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java
>  f03d240 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java
>  bcfae8d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java
>  4e0ba24 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
>  6cf520d 
> 
> Diff: https://reviews.apache.org/r/47237/diff/
> 
> 
> Testing
> ---
> 
> Manually tested upgrade and new instance creation.
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/
---

(Updated May 13, 2016, 11:25 a.m.)


Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
Sumit Mohanty, and Srimanth Gunturi.


Changes
---

Uploading new patch to account for merge changes... nothing was altered in the 
pathed code.


Bugs: AMBARI-16072
https://issues.apache.org/jira/browse/AMBARI-16072


Repository: ambari


Description
---

When adding a service to a Kerberized cluster and click install nothing happens 
on the UI and i see the following error in the ambari server logs

```
20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 
- Adding identity for JOURNALNODE to auth to local mapping
20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] KerberosHelperImpl:735 
- Adding identity for METRICS_COLLECTOR to auth to local mapping
20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 - 
Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
command=recommend-configurations
20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 - 
Stack-advisor 
output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 - 
Stack advisor output files
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 - 
advisor script stdout: StackAdvisor implementation for stack HDP, version 
2.0.6 was loaded
StackAdvisor implementation for stack HDP, version 2.1 was loaded
StackAdvisor implementation for stack HDP, version 2.2 was loaded
StackAdvisor implementation for stack HDP, version 2.3 was loaded
StackAdvisor implementation for stack HDP, version 2.4 was loaded
Returning HDP24StackAdvisor implementation
Error occured in stack advisor.
Error details: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 - 
advisor script stderr: Traceback (most recent call last):
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
in 
main(sys.argv)
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
in main
result = stackAdvisor.recommendConfigurations(services, hosts)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
line 570, in recommendConfigurations
calculation(configurations, clusterSummary, services, hosts)
  File 
"/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
 line 627, in recommendAmsConfigurations
if set(amsCollectorHosts).intersection(dn_hosts):
TypeError: 'NoneType' object is not iterable
20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
AbstractResourceProvider:802 - Caught an exception while updating host 
components, retrying : org.apache.ambari.server.AmbariException: Stack Advisor 
reported an error: TypeError: 'NoneType' object is not iterable
StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out

StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
```

# Solution
Pass to the stack advisor information about all installed services where each 
component is installed (component host map)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 fe466d5 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
9c0052f 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 13eea58 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 e03ed86 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 7dc8bf8 

Diff: https://reviews.apache.org/r/46583/diff/


Testing
---

Manually tested using the UI and BP.

# Local test results: 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 59:18.081s
[INFO] Finished at: Sat Apr 23 18:37:45 EDT 2016
[INFO] Final Memory: 70M/1720M
[INFO] 

# Jenkins test results: 

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:48 h
[INFO] Finished at: 2016-04-24T03:13:41+00:00
[INFO] Final Memory: 144M/469M
[INFO] 

Re: Review Request 46583: Stack Advisor issue when adding service to Kerberized cluster

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46583/#review133132
---


Ship it!




Ship It!

- Sumit Mohanty


On May 13, 2016, 3:25 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46583/
> ---
> 
> (Updated May 13, 2016, 3:25 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, Oliver Szabo, 
> Sumit Mohanty, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16072
> https://issues.apache.org/jira/browse/AMBARI-16072
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When adding a service to a Kerberized cluster and click install nothing 
> happens on the UI and i see the following error in the ambari server logs
> 
> ```
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for JOURNALNODE to auth to local 
> mapping
> 20 Apr 2016 16:03:56,818  INFO [qtp-ambari-client-2764] 
> KerberosHelperImpl:735 - Adding identity for METRICS_COLLECTOR to auth to 
> local mapping
> 20 Apr 2016 16:03:56,857  INFO [qtp-ambari-client-2764] StackAdvisorRunner:47 
> - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, 
> actionDirectory=/var/run/ambari-server/stack-recommendations/323, 
> command=recommend-configurations
> 20 Apr 2016 16:03:56,860  INFO [qtp-ambari-client-2764] StackAdvisorRunner:61 
> - Stack-advisor 
> output=/var/run/ambari-server/stack-recommendations/323/stackadvisor.out, 
> error=/var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:69 
> - Stack advisor output files
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:70 
> - advisor script stdout: StackAdvisor implementation for stack HDP, 
> version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> StackAdvisor implementation for stack HDP, version 2.2 was loaded
> StackAdvisor implementation for stack HDP, version 2.3 was loaded
> StackAdvisor implementation for stack HDP, version 2.4 was loaded
> Returning HDP24StackAdvisor implementation
> Error occured in stack advisor.
> Error details: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,917  INFO [qtp-ambari-client-2764] StackAdvisorRunner:71 
> - advisor script stderr: Traceback (most recent call last):
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, 
> in 
> main(sys.argv)
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, 
> in main
> result = stackAdvisor.recommendConfigurations(services, hosts)
>   File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", 
> line 570, in recommendConfigurations
> calculation(configurations, clusterSummary, services, hosts)
>   File 
> "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py",
>  line 627, in recommendAmsConfigurations
> if set(amsCollectorHosts).intersection(dn_hosts):
> TypeError: 'NoneType' object is not iterable
> 20 Apr 2016 16:03:56,918  INFO [qtp-ambari-client-2764] 
> AbstractResourceProvider:802 - Caught an exception while updating host 
> components, retrying : org.apache.ambari.server.AmbariException: Stack 
> Advisor reported an error: TypeError: 'NoneType' object is not iterable
> StdOut file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.out
> 
> StdErr file: /var/run/ambari-server/stack-recommendations/323/stackadvisor.err
> ```
> 
> # Solution
> Pass to the stack advisor information about all installed services where each 
> component is installed (component host map)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  fe466d5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 9c0052f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  13eea58 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  e03ed86 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
>  7dc8bf8 
> 
> Diff: https://reviews.apache.org/r/46583/diff/
> 
> 
> Testing
> ---
> 
> Manually tested using the UI and BP.
> 
> # Local test results: 
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 59:18.081s
> [INFO] Finished at: Sat Apr 23 18:37:45 EDT 2016
> [INFO] Final Memory: 70M/1720M
> [INFO] 
> 

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Administrator"

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47237/
---

(Updated May 13, 2016, 11:09 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Richard Zang.


Summary (updated)
-

RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari 
Administrator"


Bugs: AMBARI-16449
https://issues.apache.org/jira/browse/AMBARI-16449


Repository: ambari


Description
---

Change permission_label for role AMBARI.ADMINISTRATOR from "Administrator" to 
"Ambari Admin"


Diffs
-

  ambari-server/docs/api/v1/permission-get.md d949344 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
 2389d0d 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql d77a0b3 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f6ee1e7 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6000d24 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 67bd38a 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
ea7ab7a 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1c3393e 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 2245f77 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
 67a94ea 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java
 f03d240 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java
 bcfae8d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java
 4e0ba24 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
 6cf520d 

Diff: https://reviews.apache.org/r/47237/diff/


Testing
---

Manually tested upgrade and new instance creation.

Running org.apache.ambari.server.upgrade.UpgradeCatalog230Test
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.697 sec - in 
org.apache.ambari.server.upgrade.UpgradeCatalog230Test

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 47321: Ambari to download repo file besides creating it.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47321/#review133112
---



Can you add documentation to all new methods.

Also, I'm curious why we're still using metainfo - we need to move away from 
this and start relying on repo_version


ambari-common/src/main/python/resource_management/core/base.py (line 61)


An interesting way to provide a set of values in Python 2 ... Can we 
document this?



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (lines 878 - 880)


Should we do this before calling getRepository?



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (line 882)


Null check for the ri ?



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (line 888)


StringUtils.isBlank(newBaseUrl)



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (line 898)


Why are we still using MetaInfo here? It seems like we need to stop using 
this table for repos and just use repo_version instead.



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (line 951)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (line 3908)


default ?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 (line 191)


StringUtils.isBlank() to protect against an accidental ""



ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RepositoryHelper.java
 (lines 34 - 35)


Hard coded values for this could lead to a deployment loss of service.


- Jonathan Hurley


On May 12, 2016, 12:13 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47321/
> ---
> 
> (Updated May 12, 2016, 12:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-16639
> https://issues.apache.org/jira/browse/AMBARI-16639
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently Ambari only takes a base url and creates a HDP file.
> 
> In addition to this, if ambari can take a repo url and download it, we will
> have the flexibility of combining 2 or more repos and downloading artifacts
> from multiple repositories.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 
> a69b57b 
>   ambari-common/src/main/python/resource_management/core/base.py 1500e1f 
>   
> ambari-common/src/main/python/resource_management/libraries/providers/repository.py
>  f476e29 
>   
> ambari-common/src/main/python/resource_management/libraries/resources/repository.py
>  2484d67 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  77f2ede 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  bb58670 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  5e51f5f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  7884d02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
>  84929bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  30bd0db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  3b5b0a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
>  57fb115 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RepositoryHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  49d53a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 
> da7f021 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
> 8a352bd 
>   

Re: Review Request 47237: RBAC: Change permission_label for role AMBARI.ADMINISTRATOR to "Ambari Admin"

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47237/
---

(Updated May 13, 2016, 11:07 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, and Richard Zang.


Bugs: AMBARI-16449
https://issues.apache.org/jira/browse/AMBARI-16449


Repository: ambari


Description
---

Change permission_label for role AMBARI.ADMINISTRATOR from "Administrator" to 
"Ambari Admin"


Diffs
-

  ambari-server/docs/api/v1/permission-get.md d949344 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java
 2389d0d 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql d77a0b3 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f6ee1e7 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6000d24 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 67bd38a 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
ea7ab7a 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1c3393e 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 2245f77 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
 67a94ea 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java
 f03d240 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java
 bcfae8d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java
 4e0ba24 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog230Test.java
 6cf520d 

Diff: https://reviews.apache.org/r/47237/diff/


Testing (updated)
---

Manually tested upgrade and new instance creation.

Running org.apache.ambari.server.upgrade.UpgradeCatalog230Test
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.697 sec - in 
org.apache.ambari.server.upgrade.UpgradeCatalog230Test

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46944/
---

(Updated May 13, 2016, 3:14 p.m.)


Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Myroslav 
Papirkovskyy, Sumit Mohanty, and Sebastian Toader.


Changes
---

- fix tests and add branch-2.4


Bugs: AMBARI-16230
https://issues.apache.org/jira/browse/AMBARI-16230


Repository: ambari


Description
---

2 different type of errors can occur during adding any new service to Ambari:

org.apache.ambari.server.AmbariException: Unable to create a default alert 
group for unknown service  in cluster

org.apache.ambari.server.ServiceNotFoundException: Service not found, 
clusterName=c1, serviceName=

The reason is that: ServiceInstalledEvent can be handled quicker than 
ServiceImpl.persist() can finish


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 47342f3 
  ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
303b043 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
487489b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
 108732f 
  ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 
a3d05a9 
  ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 
19146fd 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
 d1b27a9 
  
ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
 1875ba6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
 e7cbd99 

Diff: https://reviews.apache.org/r/46944/diff/


Testing
---

Unit Testing is in progress..
FT: deploy cluster, add service, restart ambari with deployed cluster.


Thanks,

Oliver Szabo

Re: Review Request 47252: PXF Agents Live Widget on Dashboard needs custom widget to display only single threshold i.e., Green/Red only

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47252/#review133160
---


Ship it!




Ship It!

- Matt


On May 12, 2016, 2:26 p.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47252/
> ---
> 
> (Updated May 12, 2016, 2:26 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16461
> https://issues.apache.org/jira/browse/AMBARI-16461
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF Agents Live Widget on Dashboard needs custom widget to display only 
> single threshold i.e., Green/Red only
> 
> 
> Diffs
> -
> 
>   ambari-web/app/assets/test/tests.js eb2edf1 
>   ambari-web/app/messages.js 910bed7 
>   ambari-web/app/mixins.js cf8cef6 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> PRE-CREATION 
>   ambari-web/app/styles/modal_popups.less 5e89dbc 
>   
> ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs
>  PRE-CREATION 
>   ambari-web/app/views.js 127a996 
>   ambari-web/app/views/main/dashboard/widgets.js 38181c0 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 
>   ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 
> PRE-CREATION 
>   ambari-web/test/aliases/computed/gtProperties.js f3f1def 
>   
> ambari-web/test/views/main/dashboard/widgets/text_widget_single_threshold_test.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47252/diff/
> 
> 
> Testing
> ---
> 
> Yes, All tests passed. Test was already in place.
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>

Re: Review Request 47350: use schematool from hive2

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47350/#review133152
---


Ship it!




Ship It!

- Dmytro Sen


On Май 13, 2016, 4:56 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47350/
> ---
> 
> (Updated Май 13, 2016, 4:56 п.п.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16662
> https://issues.apache.org/jira/browse/AMBARI-16662
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> hive2 has some changes to the metastore schema, but it is compatible with 
> hive1. 
> We should run the schematool from hive2 instead of hive1 so that the schema 
> is compatible for both versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  7b16474 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  169f7ea 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  4f8aa49 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47350/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47328/#review133146
---




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 166)


fancy, but this is a constant that we don;t have to calculate every time, 
why not just say

MEM_THRESHOLD = 33554432 # 32GB in KB



ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py (line 
2041)


should HAWQ/PXF tests be now moved to separate service advisor tests files, 
perhaps as a separate effort ?


- Alexander Denissov


On May 13, 2016, 12:58 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47328/
> ---
> 
> (Updated May 13, 2016, 12:58 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16646
> https://issues.apache.org/jira/browse/AMBARI-16646
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Consider all HAWQ host machines. 
> If the lowest memory among all systems is >= 32 GB set vm.overcommit_memory 
> as 2, else use 1
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  a26a398 
>   ambari-server/src/main/resources/stacks/service_advisor.py 86682c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> be0f3e4 
> 
> Diff: https://reviews.apache.org/r/47328/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
> ```
> bash-3.2$ cd ambari-server/src/test/python/stacks/2.3/common/
> bash-3.2$ python -m discover -v
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation 
> for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> 

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

[Keta Patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/
---

(Updated May 13, 2016, 5:29 p.m.)


Review request for Ambari, Di Li and Richard Zang.


Bugs: AMBARI-15552
https://issues.apache.org/jira/browse/AMBARI-15552


Repository: ambari


Description
---

Reproduction Steps:
1. Go to Admin->Manage Ambari
2. Create a group with a few users belonging to it. 
(I have created "mygroup" with "user1", "user2", "user3") 
(attachments "user1.tiff", "mygroup.tiff" shows samples)
3. Go to Clusters->Roles on the left navigation menu.
4. The default view is the "Block" view for the roles. Assign "mygroup" a role, 
say "Cluster User". 
(attachment "block_view_original.tiff")
5. Click on "List" view, it will show Users by default. It correctly shows the 
role "Cluster User" for each user in "mygroup". 
(attachment "list_view_users.tiff")
6. Now, try adding a new Role, say "Service Operator", to one of the users, say 
"user3". 
(attachments "list_view_add_role_to_user_step1.tiff", 
"list_view_add_role_to_user_step2.tiff")
7. After making this change, the role gets added for that user (in our case 
"user3"), but the roles from other users in its group gets removed. Also, the 
previous role for the user ("user3") is replaced by the new Role.
(attachment "list_view_add_role_to_user_step3.tiff")
8. You can confirm this from the the "Block" view. 
(attachment "block_view_after_step3.tiff")

So, the problem here lies with the List view where it is not able to process 
the changes in the Roles correctly. A change in the Role of a user causes the 
following:

CASE-1: The displayed role (effective privilege) comes from an explicitly 
assigned role to the user.
1.1) The new selected role correctly replaces the existing privilege that was 
explicitly assigned to the user.
1.2) But if the user was assigned multiple roles explicilty (before the fix for 
AMBARI-16102 got pushed in), then all the other roles, which are of lower 
privilege than the role that got replaced, are still displayed in the Block 
view (because those roles are still in the database). So, if the new selected 
role happened to be of a lower privilege than and existing role of the user, 
then even though the user sees a success Alert message, the effective privileg 
he sees is different. For the Ambari user, this behavior is not easily 
understandable.

CASE-2: The displayed role (effective privilege) comes from a group the user 
belongs to.
2.1) If the new selected privilege is higher than the effective privilege 
coming from the user's group(s), then the newly selected role replaces this 
"group" privilege in the database, insetad of creating a new entry.
2.2) As a result of losing the group privilege, all the group members also lose 
their privileges and they show "None" as their effective privilege.
2.3) If the newly selected privilege is lower than effective group privilege, 
the Alert message shows a success of role change but the effective privilge is 
still not the one that the Ambari user selected.


Expected results:
1. Updating a Role of a user must replace any/all of the explicit roles it has 
been assigned through the Block View. (this addresses 1.2)
Note: Even though AMBARI-16102 has attempted to fix the Block view by allowing 
only a user to have just one role assigned to it, there could be cases where 
the earlier version of Block view has already allowed users to have multiple 
roles. So, taking this into consideration, the fix must address removing any or 
all of the roles the user was assigned explicitly.
2. Adding a Role to a user must not affect the Roles of other users in its 
group. (addressing 2.1 and 2.2)
3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to 
None". This  may not reflect the correct privilege status as the user might 
have some effective privilege coming from its group(s). In the fix, the Alert 
must show the relevant message.
4. Alert messages must show more informative messages of what is happening with 
the user's privileges and why. (addressing 1.2 and 2.3)


Diffs (updated)
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
 11a73f6 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
2321f5e 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js 
ff388cd 
  
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/clusters/UserAccessListCtrl_test.js
 edf16be 

Diff: https://reviews.apache.org/r/46808/diff/


Testing
---

The testing done mainly checks the logic used to update the privileges of the 
user/group which is done after a REST call to retrieve the privileges.

The test cases have mocks setup for server calls. The response from the server 
calls are also mocked to work with 

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

[Keta Patel]

> On May 12, 2016, 9:33 p.m., Richard Zang wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js,
> >  line 189
> > 
> >
> > Please move hard-coded texts like this to i18n.config.js

Hello Richard,
I have separated the text to i18n.config.js file for 2 of the Alerts used in 
save() and addPrivilege().
Please find all the changes in the new patch "AMBARI-15552-May-13.patch".

Thank you!


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132985
---


On May 13, 2016, 5:29 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
> 
> (Updated May 13, 2016, 5:29 p.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it. 
> (I have created "mygroup" with "user1", "user2", "user3") 
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a 
> role, say "Cluster User". 
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows 
> the role "Cluster User" for each user in "mygroup". 
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users, 
> say "user3". 
> (attachments "list_view_add_role_to_user_step1.tiff", 
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case 
> "user3"), but the roles from other users in its group gets removed. Also, the 
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view. 
> (attachment "block_view_after_step3.tiff")
> 
> So, the problem here lies with the List view where it is not able to process 
> the changes in the Roles correctly. A change in the Role of a user causes the 
> following:
> 
> CASE-1: The displayed role (effective privilege) comes from an explicitly 
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was 
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix 
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower 
> privilege than the role that got replaced, are still displayed in the Block 
> view (because those roles are still in the database). So, if the new selected 
> role happened to be of a lower privilege than and existing role of the user, 
> then even though the user sees a success Alert message, the effective 
> privileg he sees is different. For the Ambari user, this behavior is not 
> easily understandable.
> 
> CASE-2: The displayed role (effective privilege) comes from a group the user 
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege 
> coming from the user's group(s), then the newly selected role replaces this 
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also 
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege, 
> the Alert message shows a success of role change but the effective privilge 
> is still not the one that the Ambari user selected.
> 
> 
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it 
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by 
> allowing only a user to have just one role assigned to it, there could be 
> cases where the earlier version of Block view has already allowed users to 
> have multiple roles. So, taking this into consideration, the fix must address 
> removing any or all of the roles the user was assigned explicitly.
> 2. Adding a Role to a user must not affect the Roles of other users in its 
> group. (addressing 2.1 and 2.2)
> 3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to 
> None". This  may not reflect the correct privilege status as the user might 
> have some 

Review Request 47350: use schematool from hive2

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47350/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-16662
https://issues.apache.org/jira/browse/AMBARI-16662


Repository: ambari


Description
---

hive2 has some changes to the metastore schema, but it is compatible with 
hive1. 
We should run the schematool from hive2 instead of hive1 so that the schema is 
compatible for both versions.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 7b16474 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 169f7ea 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 4f8aa49 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-site.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/47350/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47328/#review133154
---


Ship it!




Ship It!

- Alexander Denissov


On May 13, 2016, 12:58 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47328/
> ---
> 
> (Updated May 13, 2016, 12:58 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16646
> https://issues.apache.org/jira/browse/AMBARI-16646
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Consider all HAWQ host machines. 
> If the lowest memory among all systems is >= 32 GB set vm.overcommit_memory 
> as 2, else use 1
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  a26a398 
>   ambari-server/src/main/resources/stacks/service_advisor.py 86682c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> be0f3e4 
> 
> Diff: https://reviews.apache.org/r/47328/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
> ```
> bash-3.2$ cd ambari-server/src/test/python/stacks/2.3/common/
> bash-3.2$ python -m discover -v
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation 
> for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ServiceAdvisor implementation for service PXF 
> was loaded
> ServiceAdvisor implementation for service PXF was loaded
> ServiceAdvisor implementation for service 

Re: Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

[Matt]

> On May 13, 2016, 10:08 a.m., Alexander Denissov wrote:
> > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py, line 
> > 2041
> > 
> >
> > should HAWQ/PXF tests be now moved to separate service advisor tests 
> > files, perhaps as a separate effort ?

Refer https://issues.apache.org/jira/browse/AMBARI-16647


> On May 13, 2016, 10:08 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> >  line 166
> > 
> >
> > fancy, but this is a constant that we don;t have to calculate every 
> > time, why not just say
> > 
> > MEM_THRESHOLD = 33554432 # 32GB in KB

Will update


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47328/#review133146
---


On May 12, 2016, 5:58 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47328/
> ---
> 
> (Updated May 12, 2016, 5:58 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16646
> https://issues.apache.org/jira/browse/AMBARI-16646
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Consider all HAWQ host machines. 
> If the lowest memory among all systems is >= 32 GB set vm.overcommit_memory 
> as 2, else use 1
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  a26a398 
>   ambari-server/src/main/resources/stacks/service_advisor.py 86682c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> be0f3e4 
> 
> Diff: https://reviews.apache.org/r/47328/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
> ```
> bash-3.2$ cd ambari-server/src/test/python/stacks/2.3/common/
> bash-3.2$ python -m discover -v
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation 
> for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ServiceAdvisor 
> 

Re: Review Request 47060: AMBARI-16285 Ranger Tagsync stack changes to sync tags from Atlas

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47060/#review133167
---


Ship it!




Ship It!

- Jayush Luniya


On May 13, 2016, 10:50 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47060/
> ---
> 
> (Updated May 13, 2016, 10:50 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16285
> https://issues.apache.org/jira/browse/AMBARI-16285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes include:
> 1) Renaming properties in ranger-tagsync-site.xml introduced in stack -2.5 
> followed by theme change.
> 2) Removed tagsync user password introduced in previous patch
> 3) Add default password in jceks for rangertagsync and rangerusersync
> 4) Derive tag source as ATLAS, if ATLAS is installed
> 5) Added new properties under ranger-ugsync-site.xml related to Policy 
> manager user's credentials in Ranger usersync service
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/alerts/alert_ranger_admin_passwd_check.py
>  a0a9162 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  59190fe 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py
>  1b56044 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py
>  d013371 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ec0eea1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  aabc37d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/alerts.json 
> f1f76e8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
>  08f6235 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-ugsync-site.xml
>  10ef1a8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-application-properties.xml
>  d369098 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/themes/theme_version_3.json
>  19411d4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 3d689d7 
>   ambari-web/app/styles/widgets.less f385449 
> 
> Diff: https://reviews.apache.org/r/47060/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger Tagsync on centos 6.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 47384: Cluster deployment fails when using base stack version

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47384/
---

Review request for Ambari, Nate Cole, Richard Zang, and Srimanth Gunturi.


Bugs: AMBARI-16674
https://issues.apache.org/jira/browse/AMBARI-16674


Repository: ambari


Description
---

#STR:#
1) During install wizard, choose a base stack version For example: HDP-2.3
2) Proceed with this and on review page, click on deploy button

This results in an API call failure and cluster deployment does not happen.

The reason for this issue is that UI instead of using VersionDefinition ID 
generated by the ambari-server, creates and uses its own ID which is incorrect 
in case of base stack version


#Apart from addressing the bug, patch does following:#
1) Asks for VersionDefinition/stack_default attribute from the API
2) Changes the mock data to include the latest response given by he API


Diffs
-

  ambari-web/app/assets/data/wizard/stack/HDP_version_definitions.json fde11e2 
  ambari-web/app/mappers/stack_mapper.js f9400c4 
  ambari-web/app/utils/ajax/ajax.js 866c454 
  ambari-web/test/mappers/stack_mapper_test.js 37138ee 

Diff: https://reviews.apache.org/r/47384/diff/


Testing
---

Verified that the patch resolves the issue manually on a cluster
Verified that all ambari-web tests passes successfully with the patch:

  27802 tests complete (29 seconds)
  154 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 47377: Fix for parsing multiple lines in output while looking for created 'llap package' name.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47377/#review133235
---



You can add the test later but can you add the JIRA ID to the review request?

- Sumit Mohanty


On May 14, 2016, 12:13 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47377/
> ---
> 
> (Updated May 14, 2016, 12:13 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LLAP start/restart, after creating LLAP package relies on output that is 
> being generated in order to figure out the package name created. Typically 
> looks for line :
> 
> --
> Prepared llap-slider/run.sh for running LLAP on Slider
> --
> --
> 
> However, it doesn't handle parsing multi-line outputs (example):
> 
> --
> #   # ### 
> ###  ##    # ### ## ### 
> Prepared llap-slider2016-05-13_23-13-07/run.sh for running LLAP on Slider
> --
> --
> 
> **Resolution** : Fixed the code for parsing lines while looking for output 
> line.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  e94b22e 
> 
> Diff: https://reviews.apache.org/r/47377/diff/
> 
> 
> Testing
> ---
> 
> Yes. 
> 
> Pythn UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 47379: PXF operations considers the agent status

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47379/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Bugs: AMBARI-16670
https://issues.apache.org/jira/browse/AMBARI-16670


Repository: ambari


Description
---

PXF operations considers the agent status


Diffs
-

  ambari-web/app/controllers/main/service/item.js 9250bfc 
  ambari-web/app/models/host_component.js 569879f 
  ambari-web/test/controllers/main/service/item_test.js 383aa2f 

Diff: https://reviews.apache.org/r/47379/diff/


Testing
---

Yes.

User should be able to do the following ops on PXF:
Start PXF slaves if one or more slaves are down
Stop PXF slaves if one or more slaves are up
Start disabled if all agents are up
Stop disabled if all agents are down
Service Check disabled if one or more slaves are down
Service Check enabled if all agents are up


Thanks,

Goutam Tadi

Re: Review Request 47377: Fix for parsing multiple lines in output while looking for created 'llap package' name.

[Swapan Shridhar]

> On May 14, 2016, 12:20 a.m., Sumit Mohanty wrote:
> > You can add the test later but can you add the JIRA ID to the review 
> > request?
> 
> Sumit Mohanty wrote:
> +1. Did not realize that JIRA is inaccessible. Once you have a JIRA 
> update the review and commit it.

Updated JIRA.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47377/#review133235
---


On May 14, 2016, 12:13 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47377/
> ---
> 
> (Updated May 14, 2016, 12:13 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LLAP start/restart, after creating LLAP package relies on output that is 
> being generated in order to figure out the package name created. Typically 
> looks for line :
> 
> --
> Prepared llap-slider/run.sh for running LLAP on Slider
> --
> --
> 
> However, it doesn't handle parsing multi-line outputs (example):
> 
> --
> #   # ### 
> ###  ##    # ### ## ### 
> Prepared llap-slider2016-05-13_23-13-07/run.sh for running LLAP on Slider
> --
> --
> 
> **Resolution** : Fixed the code for parsing lines while looking for output 
> line.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  e94b22e 
> 
> Diff: https://reviews.apache.org/r/47377/diff/
> 
> 
> Testing
> ---
> 
> Yes. 
> 
> Pythn UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 47377: Fix for parsing multiple lines in output while looking for created 'llap package' name.

[Swapan Shridhar]

> On May 14, 2016, 12:19 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py,
> >  line 240
> > 
> >
> > We should add an explicit unit test that tests this path with multiple 
> > output lines. Modifying test_start_default in test_hive_server_int to 
> > return multiple lines in mock may just do it.

Added.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47377/#review133234
---


On May 14, 2016, 12:13 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47377/
> ---
> 
> (Updated May 14, 2016, 12:13 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LLAP start/restart, after creating LLAP package relies on output that is 
> being generated in order to figure out the package name created. Typically 
> looks for line :
> 
> --
> Prepared llap-slider/run.sh for running LLAP on Slider
> --
> --
> 
> However, it doesn't handle parsing multi-line outputs (example):
> 
> --
> #   # ### 
> ###  ##    # ### ## ### 
> Prepared llap-slider2016-05-13_23-13-07/run.sh for running LLAP on Slider
> --
> --
> 
> **Resolution** : Fixed the code for parsing lines while looking for output 
> line.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  e94b22e 
> 
> Diff: https://reviews.apache.org/r/47377/diff/
> 
> 
> Testing
> ---
> 
> Yes. 
> 
> Pythn UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 47377: AMBARI-16673. Fix for parsing multiple lines in output while looking for created 'llap package' name.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47377/
---

(Updated May 14, 2016, 1:55 a.m.)


Review request for Ambari, Jaimin Jetly and Sumit Mohanty.


Changes
---

Updated Test cases.


Summary (updated)
-

AMBARI-16673. Fix for parsing multiple lines in output while looking for 
created 'llap package' name.


Bugs: AMBARI-16673
https://issues.apache.org/jira/browse/AMBARI-16673


Repository: ambari


Description
---

LLAP start/restart, after creating LLAP package relies on output that is being 
generated in order to figure out the package name created. Typically looks for 
line :

--
Prepared llap-slider/run.sh for running LLAP on Slider
--
--

However, it doesn't handle parsing multi-line outputs (example):

--
#   # ### 
###  ##    # ### ## ### 
Prepared llap-slider2016-05-13_23-13-07/run.sh for running LLAP on Slider
--
--

**Resolution** : Fixed the code for parsing lines while looking for output line.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 e94b22e 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py dc02f9f 

Diff: https://reviews.apache.org/r/47377/diff/


Testing
---

Yes. 

Pythn UT passes.


Thanks,

Swapan Shridhar

Re: Review Request 47377: Fix for parsing multiple lines in output while looking for created 'llap package' name.

[Sumit Mohanty]

> On May 14, 2016, 12:20 a.m., Sumit Mohanty wrote:
> > You can add the test later but can you add the JIRA ID to the review 
> > request?

+1. Did not realize that JIRA is inaccessible. Once you have a JIRA update the 
review and commit it.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47377/#review133235
---


On May 14, 2016, 12:13 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47377/
> ---
> 
> (Updated May 14, 2016, 12:13 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> LLAP start/restart, after creating LLAP package relies on output that is 
> being generated in order to figure out the package name created. Typically 
> looks for line :
> 
> --
> Prepared llap-slider/run.sh for running LLAP on Slider
> --
> --
> 
> However, it doesn't handle parsing multi-line outputs (example):
> 
> --
> #   # ### 
> ###  ##    # ### ## ### 
> Prepared llap-slider2016-05-13_23-13-07/run.sh for running LLAP on Slider
> --
> --
> 
> **Resolution** : Fixed the code for parsing lines while looking for output 
> line.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  e94b22e 
> 
> Diff: https://reviews.apache.org/r/47377/diff/
> 
> 
> Testing
> ---
> 
> Yes. 
> 
> Pythn UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/
---

(Updated May 14, 2016, 12:56 a.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Changes
---

rebase patch


Bugs: AMBARI-15612
https://issues.apache.org/jira/browse/AMBARI-15612


Repository: ambari


Description
---

Add Livy to HDP 2.5 as slave component of Spark.

Move the spark stack definiation to commoon-services and then


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 2e18443 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9e9cadc 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 c5f3eb6 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
 86e7f7d 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 3ec5d05 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
6e506a0 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
f7e15aa 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-defaults.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
d1129cd 

Diff: https://reviews.apache.org/r/46727/diff/


Testing
---

Manully verify it. Livy is installed correctly in non-secure and secure cluster.


Thanks,

Jeff Zhang

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

[Keta Patel]

> On May 13, 2016, 10:24 p.m., Richard Zang wrote:
> > Ship It!

Thank you Richard!
Could you please help me push in the changes.


- Keta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review133219
---


On May 13, 2016, 5:29 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
> 
> (Updated May 13, 2016, 5:29 p.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it. 
> (I have created "mygroup" with "user1", "user2", "user3") 
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a 
> role, say "Cluster User". 
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows 
> the role "Cluster User" for each user in "mygroup". 
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users, 
> say "user3". 
> (attachments "list_view_add_role_to_user_step1.tiff", 
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case 
> "user3"), but the roles from other users in its group gets removed. Also, the 
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view. 
> (attachment "block_view_after_step3.tiff")
> 
> So, the problem here lies with the List view where it is not able to process 
> the changes in the Roles correctly. A change in the Role of a user causes the 
> following:
> 
> CASE-1: The displayed role (effective privilege) comes from an explicitly 
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was 
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix 
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower 
> privilege than the role that got replaced, are still displayed in the Block 
> view (because those roles are still in the database). So, if the new selected 
> role happened to be of a lower privilege than and existing role of the user, 
> then even though the user sees a success Alert message, the effective 
> privileg he sees is different. For the Ambari user, this behavior is not 
> easily understandable.
> 
> CASE-2: The displayed role (effective privilege) comes from a group the user 
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege 
> coming from the user's group(s), then the newly selected role replaces this 
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also 
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege, 
> the Alert message shows a success of role change but the effective privilge 
> is still not the one that the Ambari user selected.
> 
> 
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it 
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by 
> allowing only a user to have just one role assigned to it, there could be 
> cases where the earlier version of Block view has already allowed users to 
> have multiple roles. So, taking this into consideration, the fix must address 
> removing any or all of the roles the user was assigned explicitly.
> 2. Adding a Role to a user must not affect the Roles of other users in its 
> group. (addressing 2.1 and 2.2)
> 3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to 
> None". This  may not reflect the correct privilege status as the user might 
> have some effective privilege coming from its group(s). In the fix, the Alert 
> must show the relevant message.
> 4. Alert messages must show more informative messages of what is happening 
> with the user's privileges and why. (addressing 1.2 and 2.3)
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
>  11a73f6 
>   

Re: Review Request 46270: AMBARI-15917 : Add ability to specify a custom trust store for ranger admin via ambari config

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46270/#review133192
---


Ship it!




Ship It!

- Nate Cole


On May 4, 2016, 3:12 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46270/
> ---
> 
> (Updated May 4, 2016, 3:12 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15917
> https://issues.apache.org/jira/browse/AMBARI-15917
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Expose custom trust store related configs for Ranger on Ambari UI.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-admin-site.xml
>  d533dbc 
> 
> Diff: https://reviews.apache.org/r/46270/diff/
> 
> 
> Testing
> ---
> 
> Verified addition of : ranger.truststore.file and ranger.truststore.password 
> in ranger-admin-site.xml.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Review Request 47369: AMBARI-16666 : AMS Service check fails because collector takes too long to start up.

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47369/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

Problem
If etc/hosts is not properly configured, AMS embedded mode startup takes too 
long because of connection timeout to localhost zk quorum.

Fix
Change embedded mode zk quorum to hostname from localhost.


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
 32b8fdb 

Diff: https://reviews.apache.org/r/47369/diff/


Testing
---

Manaully tested embedded mode on secure and unsecure cluster. 
Python unit tests pass.


Thanks,

Aravindan Vijayan

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review133219
---


Ship it!




Ship It!

- Richard Zang


On May 13, 2016, 5:29 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
> 
> (Updated May 13, 2016, 5:29 p.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it. 
> (I have created "mygroup" with "user1", "user2", "user3") 
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a 
> role, say "Cluster User". 
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows 
> the role "Cluster User" for each user in "mygroup". 
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users, 
> say "user3". 
> (attachments "list_view_add_role_to_user_step1.tiff", 
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case 
> "user3"), but the roles from other users in its group gets removed. Also, the 
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view. 
> (attachment "block_view_after_step3.tiff")
> 
> So, the problem here lies with the List view where it is not able to process 
> the changes in the Roles correctly. A change in the Role of a user causes the 
> following:
> 
> CASE-1: The displayed role (effective privilege) comes from an explicitly 
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was 
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix 
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower 
> privilege than the role that got replaced, are still displayed in the Block 
> view (because those roles are still in the database). So, if the new selected 
> role happened to be of a lower privilege than and existing role of the user, 
> then even though the user sees a success Alert message, the effective 
> privileg he sees is different. For the Ambari user, this behavior is not 
> easily understandable.
> 
> CASE-2: The displayed role (effective privilege) comes from a group the user 
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege 
> coming from the user's group(s), then the newly selected role replaces this 
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also 
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege, 
> the Alert message shows a success of role change but the effective privilge 
> is still not the one that the Ambari user selected.
> 
> 
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it 
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by 
> allowing only a user to have just one role assigned to it, there could be 
> cases where the earlier version of Block view has already allowed users to 
> have multiple roles. So, taking this into consideration, the fix must address 
> removing any or all of the roles the user was assigned explicitly.
> 2. Adding a Role to a user must not affect the Roles of other users in its 
> group. (addressing 2.1 and 2.2)
> 3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to 
> None". This  may not reflect the correct privilege status as the user might 
> have some effective privilege coming from its group(s). In the fix, the Alert 
> must show the relevant message.
> 4. Alert messages must show more informative messages of what is happening 
> with the user's privileges and why. (addressing 1.2 and 2.3)
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
>  11a73f6 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> 2321f5e 
>   
> 

Re: Review Request 47328: Set vm.overcommit_memory dynamically for HAWQ

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47328/#review133178
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On May 13, 2016, 6:59 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47328/
> ---
> 
> (Updated May 13, 2016, 6:59 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16646
> https://issues.apache.org/jira/browse/AMBARI-16646
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Consider all HAWQ host machines. 
> If the lowest memory among all systems is >= 32 GB set vm.overcommit_memory 
> as 2, else use 1
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  a26a398 
>   ambari-server/src/main/resources/stacks/service_advisor.py 86682c5 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> be0f3e4 
> 
> Diff: https://reviews.apache.org/r/47328/diff/
> 
> 
> Testing
> ---
> 
> Added unit tests.
> 
> ```
> bash-3.2$ cd ambari-server/src/test/python/stacks/2.3/common/
> bash-3.2$ python -m discover -v
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation 
> for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ServiceAdvisor implementation for service PXF 
> was loaded
> ServiceAdvisor implementation for service PXF was loaded
> ServiceAdvisor implementation for service 

Review Request 47355: Unable to Deploy Cluster on redhat7 Family OSs

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47355/
---

Review request for Ambari, Jayush Luniya and Nate Cole.


Bugs: AMBARI-16664
https://issues.apache.org/jira/browse/AMBARI-16664


Repository: ambari


Description
---

Caused by AMBARI-14430.
When installing clusters on redhat7 family OSs, depending on the topology the 
installation could fail.

```
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py",
 line 67, in 
MapReduce2Client().execute()
...
raise Fail("Applying %s failed, parent directory %s doesn't exist" % 
(self.resource, dirname))
resource_management.core.exceptions.Fail: Applying 
File['/usr/hdp/current/hadoop-yarn-client/bin/container-executor'] failed, 
parent directory /usr/hdp/current/hadoop-yarn-client/bin doesn't exist
```

This is because the specific package, in this case hadoop_2_5_0_0_453-mapreduce 
is not installed because it's not sent down to the agents as part of the 
packages structure.
This only affects some topologies since the affected components are installed 
by other components which have the correct OS families specified in their 
metainfo.xml files:

```
[root@os-r7-fsqzxu-devdeployerie-3 data]# rpm -q --whatrequires 
hadoop_2_5_0_0_453-mapreduce
hadoop_2_5_0_0_453-client-2.7.1.2.5.0.0-453.el6.x86_64
tez_2_5_0_0_453-0.7.0.2.5.0.0-453.el6.noarch
tez_hive2_2_5_0_0_453-0.8.4.2.5.0.0-453.el6.noarch
```

So, as long as Tez or Hadoop Client were installed on this box, then MapReduce 
would be there too.

Another example is ZooKeeper; since it's installed last, if any other packages 
are installed before it, the bits will be there:

```
[root@os-r7-fsqzxu-devdeployerie-3 data]# rpm -q --whatrequires 
zookeeper_2_5_0_0_453
hadoop_2_5_0_0_453-2.7.1.2.5.0.0-453.el6.x86_64
storm_2_5_0_0_453-1.0.1.2.5.0.0-453.el6.x86_64
hbase_2_5_0_0_453-1.1.2.2.5.0.0-453.el6.noarch
hive_2_5_0_0_453-1.2.1000.2.5.0.0-453.el6.noarch
hive2_2_5_0_0_453-2.1.0.2.5.0.0-453.el6.noarch
kafka_2_5_0_0_453-0.10.0.2.5.0.0-453.el6.noarch
```


Diffs
-

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
07080b4 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/metainfo.xml 
cb08a9c 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.6/metainfo.xml 
090e35d 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml 
7c4b232 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
dacc1fb 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml 
faf4c31 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/metainfo.xml 
629fe5f 

Diff: https://reviews.apache.org/r/47355/diff/


Testing
---

Deployed ZK and MapR to CentOS7 on isolated hosts.


Thanks,

Jonathan Hurley

Re: Review Request 47138: stackadvisor uses getHostsForSlaveComponent with wrong parameter name

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47138/#review133185
---


Ship it!




Ship It!

- Jayush Luniya


On May 9, 2016, 11:43 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47138/
> ---
> 
> (Updated May 9, 2016, 11:43 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, Matt, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-16378
> https://issues.apache.org/jira/browse/AMBARI-16378
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> def getHostsForSlaveComponent(self, services, hosts, component, hostsList, 
> hostsComponentsMap, freeHosts):
> componentName = component["StackServiceComponents"]["component_name"]
> 
> if component["StackServiceComponents"]["cardinality"] == "ALL":
>   return hostsList
> 
> componentIsPopulated = self.isComponentHostsPopulated(component)
> if componentIsPopulated:
>   return component["StackServiceComponents"]["hostnames"]
> 
> hostsForComponent = []
> 
> if self.isSlaveComponent(component):
>   cardinality = str(component["StackServiceComponents"]["cardinality"])
>   if self.isComponentUsingCardinalityForLayout(component) and cardinality:
> # cardinality types: 1+, 1-2, 1
> ```
> 
> The correct parameter name is comonentName (instead of component)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 00b9d79 
> 
> Diff: https://reviews.apache.org/r/47138/diff/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Lav Jain
> 
>

Re: Review Request 47355: Unable to Deploy Cluster on redhat7 Family OSs

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47355/#review133186
---


Ship it!




Ship It!

- Jayush Luniya


On May 13, 2016, 7:53 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47355/
> ---
> 
> (Updated May 13, 2016, 7:53 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Nate Cole.
> 
> 
> Bugs: AMBARI-16664
> https://issues.apache.org/jira/browse/AMBARI-16664
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by AMBARI-14430.
> When installing clusters on redhat7 family OSs, depending on the topology the 
> installation could fail.
> 
> ```
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py",
>  line 67, in 
> MapReduce2Client().execute()
> ...
> raise Fail("Applying %s failed, parent directory %s doesn't exist" % 
> (self.resource, dirname))
> resource_management.core.exceptions.Fail: Applying 
> File['/usr/hdp/current/hadoop-yarn-client/bin/container-executor'] failed, 
> parent directory /usr/hdp/current/hadoop-yarn-client/bin doesn't exist
> ```
> 
> This is because the specific package, in this case 
> hadoop_2_5_0_0_453-mapreduce is not installed because it's not sent down to 
> the agents as part of the packages structure.
> This only affects some topologies since the affected components are installed 
> by other components which have the correct OS families specified in their 
> metainfo.xml files:
> 
> ```
> [root@os-r7-fsqzxu-devdeployerie-3 data]# rpm -q --whatrequires 
> hadoop_2_5_0_0_453-mapreduce
> hadoop_2_5_0_0_453-client-2.7.1.2.5.0.0-453.el6.x86_64
> tez_2_5_0_0_453-0.7.0.2.5.0.0-453.el6.noarch
> tez_hive2_2_5_0_0_453-0.8.4.2.5.0.0-453.el6.noarch
> ```
> 
> So, as long as Tez or Hadoop Client were installed on this box, then 
> MapReduce would be there too.
> 
> Another example is ZooKeeper; since it's installed last, if any other 
> packages are installed before it, the bits will be there:
> 
> ```
> [root@os-r7-fsqzxu-devdeployerie-3 data]# rpm -q --whatrequires 
> zookeeper_2_5_0_0_453
> hadoop_2_5_0_0_453-2.7.1.2.5.0.0-453.el6.x86_64
> storm_2_5_0_0_453-1.0.1.2.5.0.0-453.el6.x86_64
> hbase_2_5_0_0_453-1.1.2.2.5.0.0-453.el6.noarch
> hive_2_5_0_0_453-1.2.1000.2.5.0.0-453.el6.noarch
> hive2_2_5_0_0_453-2.1.0.2.5.0.0-453.el6.noarch
> kafka_2_5_0_0_453-0.10.0.2.5.0.0-453.el6.noarch
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 07080b4 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/metainfo.xml 
> cb08a9c 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.6/metainfo.xml 
> 090e35d 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml 
> 7c4b232 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
> dacc1fb 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml 
> faf4c31 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/metainfo.xml 
> 629fe5f 
> 
> Diff: https://reviews.apache.org/r/47355/diff/
> 
> 
> Testing
> ---
> 
> Deployed ZK and MapR to CentOS7 on isolated hosts.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 47355: Unable to Deploy Cluster on redhat7 Family OSs

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47355/#review133190
---


Ship it!




Ship It!

- Nate Cole


On May 13, 2016, 3:53 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47355/
> ---
> 
> (Updated May 13, 2016, 3:53 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Nate Cole.
> 
> 
> Bugs: AMBARI-16664
> https://issues.apache.org/jira/browse/AMBARI-16664
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by AMBARI-14430.
> When installing clusters on redhat7 family OSs, depending on the topology the 
> installation could fail.
> 
> ```
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py",
>  line 67, in 
> MapReduce2Client().execute()
> ...
> raise Fail("Applying %s failed, parent directory %s doesn't exist" % 
> (self.resource, dirname))
> resource_management.core.exceptions.Fail: Applying 
> File['/usr/hdp/current/hadoop-yarn-client/bin/container-executor'] failed, 
> parent directory /usr/hdp/current/hadoop-yarn-client/bin doesn't exist
> ```
> 
> This is because the specific package, in this case 
> hadoop_2_5_0_0_453-mapreduce is not installed because it's not sent down to 
> the agents as part of the packages structure.
> This only affects some topologies since the affected components are installed 
> by other components which have the correct OS families specified in their 
> metainfo.xml files:
> 
> ```
> [root@os-r7-fsqzxu-devdeployerie-3 data]# rpm -q --whatrequires 
> hadoop_2_5_0_0_453-mapreduce
> hadoop_2_5_0_0_453-client-2.7.1.2.5.0.0-453.el6.x86_64
> tez_2_5_0_0_453-0.7.0.2.5.0.0-453.el6.noarch
> tez_hive2_2_5_0_0_453-0.8.4.2.5.0.0-453.el6.noarch
> ```
> 
> So, as long as Tez or Hadoop Client were installed on this box, then 
> MapReduce would be there too.
> 
> Another example is ZooKeeper; since it's installed last, if any other 
> packages are installed before it, the bits will be there:
> 
> ```
> [root@os-r7-fsqzxu-devdeployerie-3 data]# rpm -q --whatrequires 
> zookeeper_2_5_0_0_453
> hadoop_2_5_0_0_453-2.7.1.2.5.0.0-453.el6.x86_64
> storm_2_5_0_0_453-1.0.1.2.5.0.0-453.el6.x86_64
> hbase_2_5_0_0_453-1.1.2.2.5.0.0-453.el6.noarch
> hive_2_5_0_0_453-1.2.1000.2.5.0.0-453.el6.noarch
> hive2_2_5_0_0_453-2.1.0.2.5.0.0-453.el6.noarch
> kafka_2_5_0_0_453-0.10.0.2.5.0.0-453.el6.noarch
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 07080b4 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/metainfo.xml 
> cb08a9c 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.6/metainfo.xml 
> 090e35d 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/metainfo.xml 
> 7c4b232 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 
> dacc1fb 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml 
> faf4c31 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/metainfo.xml 
> 629fe5f 
> 
> Diff: https://reviews.apache.org/r/47355/diff/
> 
> 
> Testing
> ---
> 
> Deployed ZK and MapR to CentOS7 on isolated hosts.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 47175: Hive View : Upload table : show UI validation errors while creating table.

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47175/
---

(Updated May 14, 2016, 5:59 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
and Ashwin Rajeev.


Changes
---

fixed all the review comments


Bugs: AMBARI-16422
https://issues.apache.org/jira/browse/AMBARI-16422


Repository: ambari


Description
---

Earliar : UI should show validation error cue to the user for fields like 
column names and table name if illegal names are present.

In this Patch : added new component for UI validation of text fields through 
regex. It will show red border around invalid values.


Diffs (updated)
-

  contrib/views/hive/src/main/resources/ui/hive-web/app/adapters/file-upload.js 
1bd8eee 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/adapters/upload-table.js 
ef4df43 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/components/validated-text-field.js
 PRE-CREATION 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 d883743 
  contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
b3630c1 
  contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss ec4f201 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs
 PRE-CREATION 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 b7d9011 

Diff: https://reviews.apache.org/r/47175/diff/


Testing
---

Manual testing done.


Thanks,

Nitiraj Rathore