Re: Review Request 49455: Optimized classpath scannig for upgrade check impelementations

> On June 30, 2016, 11:47 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java, > > line 648 > > > > > > Can we use reflection to look up the

Re: Review Request 49455: Optimized classpath scannig for upgrade check impelementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49455/ --- (Updated July 1, 2016, 12:12 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49504: StackAdvisor fix for Oracle 12C and Add message if user forgot to set jdbc

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49504/#review140332 --- Ship it! Ship It! - Dmytro Grinenko On July 1, 2016, 10:51

Re: Review Request 49505: AMBARI-17521: If Solr is configured to use implicit routing, then replicationFactor is ignored

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49505/#review140334 --- Ship it! Ship It! - Oliver Szabo On July 1, 2016, 11:20

Re: Review Request 49455: Optimized classpath scannig for upgrade check impelemtations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49455/ --- (Updated July 1, 2016, 9:31 a.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49449: AMBARI-17415 Ambari configuration for ranger-tagsync needs to support property for atlas keystore filename

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49449/#review140327 --- Ship it! Ship It! - Gautam Borad On July 1, 2016, 5:56

Review Request 49505: AMBARI-17521: If Solr is configured to use implicit routing, then replicationFactor is ignored

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49505/ --- Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Oliver Szabo, and

Review Request 49486: AMBARI-17519. Use Host based principal for Hive Server interactive's LLAP config 'hive.llap.zk.sm.principal' instead of headless ones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49486/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 49450: Port changes of AMBARI-17421 to hive-jdbc view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49450/#review140310 --- Ship it! Ship It! - Pallav Kulshreshtha On June 30, 2016,

Review Request 49495: Upload Table - picks different datatype for same file, for different hive view version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49495/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 49468: Fix logfeeder hsdfs user references in patterns

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49468/#review140316 --- Ship it! Ship It! - Miklos Gergely On June 30, 2016, 8:14

Re: Review Request 49505: AMBARI-17521: If Solr is configured to use implicit routing, then replicationFactor is ignored

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49505/#review140344 --- Ship it! Ship It! - Robert Nettleton On July 1, 2016, 11:20

Re: Review Request 49507: AMBARI-17520: Update the policy_user property to use storm user principal specified in Storms config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49507/#review140346 --- Was this tested with the Storm Kerberos identity set to something

Re: Review Request 49511: Falcon start fails rarely

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49511/#review140352 --- Ship it! Ship It! - Dmitro Lisnichenko On July 1, 2016,

Re: Review Request 49510: Zeppelin: remove Livy component dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49510/#review140356 ---

Re: Review Request 49510: Zeppelin: remove Livy component dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49510/ --- (Updated July 1, 2016, 2:23 p.m.) Review request for Ambari, Alejandro

Re: Review Request 49510: Zeppelin: remove Livy component dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49510/#review140357 ---

Review Request 49507: AMBARI-17520: Update the policy_user property to use storm user principal specified in Storms config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49507/ --- Review request for Ambari, Alejandro Fernandez, Mugdha Varadkar, Robert Levas,

Review Request 49510: Zeppelin: remove Livy component dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49510/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar,

Re: Review Request 49510: Zeppelin: remove Livy component dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49510/#review140350 ---

Re: Review Request 48852: Ambari displays a warning about config values not being at optimal values right after a clean install with no customization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48852/#review140347 --- Ship it! Ship It! - Dmytro Sen On Июнь 17, 2016, 2:54 п.п.,

Re: Review Request 49508: AMBARI-17522 Handle Ranger Kms upgrade in kerberos env

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49508/ --- (Updated July 1, 2016, 1:48 p.m.) Review request for Ambari, Alejandro

Re: Review Request 49505: AMBARI-17521: If Solr is configured to use implicit routing, then replicationFactor is ignored

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49505/#review140348 --- Ship it! Ship It! - Miklos Gergely On July 1, 2016, 11:20

Re: Review Request 49486: AMBARI-17519. Use Host based principal for Hive Server interactive's LLAP config 'hive.llap.zk.sm.principal' instead of headless ones.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49486/#review140355 --- Ship it! Ship It! - Sumit Mohanty On July 1, 2016, 10:15

Re: Review Request 49508: AMBARI-17522 Handle Ranger Kms upgrade in kerberos env

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49508/#review140354 --- Ship it! Ship It! - Robert Levas On July 1, 2016, 9:48

Re: Review Request 49474: Ambari LogSearch Integration should request logging metadata on a separate thread

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49474/#review140353 ---

Re: Review Request 49513: Ambari API for api/v1/clusters/?fields=hosts/* does not return the metrics information

> On Июль 1, 2016, 3:21 п.п., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java, > > line 463 > > > > > > Consider rename to

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

> On June 30, 2016, 8:23 a.m., Alexandr Antonenko wrote: > > ambari-web/app/views/main/host/details/host_component_view.js, line 196 > > > > > > this will not work out, as there is no hive-env, only "hive-site". You

Review Request 49521: Move service advisor tests for HAWQ and PXF

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49521/ --- Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

> On Июль 1, 2016, 3:54 п.п., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-storm-sink/pom.xml, line 35 > > > > > > Since this isn't apache version, checking this in will break apache > > builds ? Yes it will.

Re: Review Request 49513: Ambari API for api/v1/clusters/?fields=hosts/* does not return the metrics information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49513/#review140366 --- Don't we need change in AMSReportPropertyProvider, I thought some

Re: Review Request 49513: Ambari API for api/v1/clusters/?fields=hosts/* does not return the metrics information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49513/#review140369 --- Ship it! Ship It! - Sid Wagle On July 1, 2016, 3:26 p.m.,

Re: Review Request 49510: Zeppelin: remove Livy component dependency

> On July 1, 2016, 2:29 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py, > > line 204 > > > > > > Is this tested in non-root scenarios? >

Review Request 49513: Ambari API for api/v1/clusters/?fields=hosts/* does not return the metrics information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49513/ --- Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid

Re: Review Request 49513: Ambari API for api/v1/clusters/?fields=hosts/* does not return the metrics information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49513/ --- (Updated Июль 1, 2016, 3:26 п.п.) Review request for Ambari, Aravindan

Re: Review Request 49510: Zeppelin: remove Livy component dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49510/#review140372 --- Ship it! Ship It! - Prabhjyot Singh On July 1, 2016, 2:23

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49514/#review140370 ---

Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49514/ --- Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.

Review Request 49515: Setup logging to find memory leak rootcause

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49515/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-17527

Re: Review Request 49510: Zeppelin: remove Livy component dependency

> On July 1, 2016, 2:27 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml, > > line 42 > > > > > > I understand that this is not honored by UI and only

Re: Review Request 49474: Ambari LogSearch Integration should request logging metadata on a separate thread

On July 1, 2016, 10:31 a.m., Robert Nettleton wrote: > > I'm a bit confused by the changes made here, namely that > > `sendLogLevelQueryRequest` was replaced with `sendGetLogFileNamesRequest`. > > Is `sendLogLevelQueryRequest` no longer used? If so, it can be removed, > > right? > > Robert

Re: Review Request 49474: Ambari LogSearch Integration should request logging metadata on a separate thread

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49474/#review140379 --- Ship it! Ship It! - Jonathan Hurley On July 1, 2016, 12:25

Re: Review Request 49474: Ambari LogSearch Integration should request logging metadata on a separate thread

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49474/#review140381 --- Ship it! Ship It! - Oliver Szabo On July 1, 2016, 4:25

Review Request 49519: Fix Logfeeder visibilities

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49519/ --- Review request for Ambari, Hayat Behlim, Oliver Szabo, Robert Nettleton, and

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

> On July 1, 2016, 2:58 p.m., Alexandr Antonenko wrote: > > Ship It! > > Anita Jebaraj wrote: > can you please help in pushing the code. done - Alexandr --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49385: Hive and Oozie db displayed incorrectly on the installer review page

> On June 30, 2016, 10:52 a.m., Andrii Tkach wrote: > > ambari-web/test/controllers/wizard/step8_test.js, line 898 > > > > > > Remove unnecessary logs I have removed this in the new patch. > On June 30, 2016,

Re: Review Request 49507: AMBARI-17520: Update the policy_user property to use storm user principal specified in Storms config

> On July 1, 2016, 1:45 p.m., Robert Levas wrote: > > Was this tested with the Storm Kerberos identity set to something like > > `storm1234@${realm}`? Looks like it is working fine. I also applied the patch and tried enabling storm plugin. Noticed Ranger policies were created with permissions

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49287/#review140362 --- Ship it! Ship It! - Alexandr Antonenko On June 27, 2016,

Re: Review Request 49515: Setup logging to find memory leak rootcause

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49515/#review140368 --- Ship it! Ship It! - Dmitro Lisnichenko On July 1, 2016,

Re: Review Request 49510: Zeppelin: remove Livy component dependency

> On July 1, 2016, 2:29 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py, > > line 204 > > > > > > Is this tested in non-root scenarios? >

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

> On July 1, 2016, 5:09 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml, > > line 40 > > > > > > Does the parallelism = 1, mean 1 bolt

Re: Review Request 49470: Provide an option not to log ambari-agent command output for user custom script action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49470/#review140470 --- Ship it! Ship It! - Nahappan Somasundaram On July 1, 2016,

Re: Review Request 49455: Optimized classpath scannig for upgrade check impelementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49455/#review140389 --- Ship it! Ship It! - Sebastian Toader On July 1, 2016, 2:12

Re: Review Request 49455: Optimized classpath scannig for upgrade check impelementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49455/#review140390 --- Ship it! Ship It! - Alejandro Fernandez On July 1, 2016,

Re: Review Request 49510: Zeppelin: remove Livy component dependency

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49510/#review140392 --- Ship it! Ship It! - Alejandro Fernandez On July 1, 2016,

Re: Review Request 49511: Falcon start fails rarely

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49511/#review140429 --- Ship it! Ship It! - Alejandro Fernandez On July 1, 2016,

Re: Review Request 49535: Ambari Agent memory Leak fix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49535/#review140439 --- Ship it! Ship It! - Victor Galgo On July 1, 2016, 9:48

Review Request 49537: Spark history server stopped after deploy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49537/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17537

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

> On July 1, 2016, 5:09 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml, > > line 40 > > > > > > Does the parallelism = 1, mean 1 bolt

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

> On July 1, 2016, 3:54 p.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java, > > line 194 > > > > > > Good

Review Request 49539: AMBARI-17541: LogSearch should also show audit logs from Apache Ranger Solr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49539/ --- Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Oliver Szabo,

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49514/#review140459 ---

Review Request 49470: Provide an option not to log ambari-agent command output for user custom script action

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49470/ --- Review request for Ambari, Alejandro Fernandez and Nahappan Somasundaram.

Review Request 49538: AMBARI-17540. Add a validation check for HiveServer Interactive if total remaining capacity in cluster is less than 512 MB. Also following fixes : (1). Visibility to FALSE for 'L

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49538/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 49287: After switching to external database in hive, user should be allowed to delete mysql server

> On July 1, 2016, 2:58 p.m., Alexandr Antonenko wrote: > > Ship It! can you please help in pushing the code. - Anita --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49287/#review140362

Re: Review Request 49474: Ambari LogSearch Integration should request logging metadata on a separate thread

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49474/ --- (Updated July 1, 2016, 4:25 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 49474: Ambari LogSearch Integration should request logging metadata on a separate thread

> On July 1, 2016, 2:31 p.m., Jonathan Hurley wrote: > > Thanks for the review! I'll be uploading an updated patch shortly with the fixes for these issues. > On July 1, 2016, 2:31 p.m., Jonathan Hurley wrote: > >

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49514/#review140384 --- Fix it, then Ship it!

Re: Review Request 49521: Move service advisor tests for HAWQ and PXF

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49521/ --- (Updated July 1, 2016, 8:21 p.m.) Review request for Ambari, Alexander

Re: Review Request 49538: AMBARI-17540. Add a validation check for HiveServer Interactive if total remaining capacity in cluster is less than 512 MB. Also following fixes : (1). Visibility to FALSE fo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49538/#review140477 --- Ship it! Ship It! - Sumit Mohanty On July 2, 2016, 1:33