date:20160703

Review Request 49573: [Change Log Directory] Storm service is going down after modifying the storm_log_dir variable

2016-07-03 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49573/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-17544
https://issues.apache.org/jira/browse/AMBARI-17544


Repository: ambari


Description
---

What i did

Through ambari ui modified the variable storm_log_dir from



 /var/log/storm 

to



 /tmp/log/storm 

Clicked on Services -> restart all required

The Background Service Windows showed the operation as successful. But the
service was not started.

Observed that log files were getting created under /var/log/storm and the file
supervisor.out contained




JMXetricAgent instrumented JVM, see https://github.com/ganglia/jmxetric
Jun 29, 2016 7:55:22 AM info.ganglia.gmetric4j.GMonitor start
INFO: Setting up 1 samplers
2016-06-29 07:59:00,654 FATAL Ignoring log event after log4j was shut down


Diffs
-

  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
 2d50767 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_base.py dc1beef 
  ambari-server/src/test/python/stacks/2.3/STORM/test_storm_base.py d23c006 

Diff: https://reviews.apache.org/r/49573/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 49573: [Change Log Directory] Storm service is going down after modifying the storm_log_dir variable

2016-07-03 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49573/#review140558
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Липень 3, 2016, 3:03 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49573/
> ---
> 
> (Updated Липень 3, 2016, 3:03 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17544
> https://issues.apache.org/jira/browse/AMBARI-17544
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> What i did
> 
> Through ambari ui modified the variable storm_log_dir from
> 
> 
> 
>  /var/log/storm 
> 
> to
> 
> 
> 
>  /tmp/log/storm 
> 
> Clicked on Services -> restart all required
> 
> The Background Service Windows showed the operation as successful. But the
> service was not started.
> 
> Observed that log files were getting created under /var/log/storm and the file
> supervisor.out contained
> 
> 
> 
> 
> JMXetricAgent instrumented JVM, see https://github.com/ganglia/jmxetric
> Jun 29, 2016 7:55:22 AM info.ganglia.gmetric4j.GMonitor start
> INFO: Setting up 1 samplers
> 2016-06-29 07:59:00,654 FATAL Ignoring log event after log4j was shut down
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_base.py dc1beef 
>   ambari-server/src/test/python/stacks/2.3/STORM/test_storm_base.py d23c006 
> 
> Diff: https://reviews.apache.org/r/49573/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-03 Thread Dmytro Sen



> On Июль 1, 2016, 11:10 п.п., Aravindan Vijayan wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml,
> >  line 58
> > 
> >
> > Just trying to understand this. 
> > 
> > Does this mean that on a new HDP 2.5 cluster or on a cluster that has 
> > been upgraded to HDP 2.5, upgrading Ambari 2.4.0 to a higher version will 
> > delete this config?

Yes


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140459
---


On Июль 1, 2016, 3:32 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated Июль 1, 2016, 3:32 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 5e2d819 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 1591d39 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  ab5f1e4 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  6ab12e1 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  e582a95 
>   ambari-metrics/pom.xml 7221ab5 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  073bb1c 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  9acf173 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-03 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/
---

(Updated Июль 3, 2016, 1:23 п.п.)


Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.


Bugs: AMBARI-17080
https://issues.apache.org/jira/browse/AMBARI-17080


Repository: ambari


Description
---

Support 2 storm sinks.


Diffs (updated)
-

  ambari-metrics/ambari-metrics-assembly/pom.xml 941c3aa 
  ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
e82d2d4 
  ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
  ambari-metrics/ambari-metrics-common/pom.xml 3e11e7f 
  ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
  ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 PRE-CREATION 
  ambari-metrics/ambari-metrics-storm-sink/pom.xml ee4d2c3 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
 4553224 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
 8f98563 
  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 0ef09d6 
  
ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 4ea7396 
  ambari-metrics/pom.xml 726a823 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
 0d029e8 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 fac6331 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
 2d50767 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
 6551067 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
 ea8b1d0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
 f3bbce8 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 2fcb7e2 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 
f7a2686 

Diff: https://reviews.apache.org/r/49514/diff/


Testing
---

Unit testst passed


Thanks,

Dmytro Sen

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-03 Thread Jungtaek Lim



> On 7 4, 2016, 2:09 오전, Jungtaek Lim wrote:
> > Ship It!

Looks good to me overall. I assumed 'ambari-metrics-storm-legacy' is just a 
copy of previous 'ambari-metrics-storm'.


- Jungtaek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140599
---


On 7 3, 2016, 1:23 오후, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated 7 3, 2016, 1:23 오후)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 941c3aa 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-common/pom.xml 3e11e7f 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml ee4d2c3 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  8f98563 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  0ef09d6 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  4ea7396 
>   ambari-metrics/pom.xml 726a823 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  fac6331 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  ea8b1d0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 2fcb7e2 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 
> f7a2686 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49521: Move service advisor tests for HAWQ and PXF

2016-07-03 Thread Lav Jain


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49521/
---

(Updated July 4, 2016, 12:33 a.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
Luniya, Matt, and Tim Thorpe.


Bugs: AMBARI-16647
https://issues.apache.org/jira/browse/AMBARI-16647


Repository: ambari


Description
---

Currently the service advisor tests for HAWQ and PXF are under 
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py
Move the tests to the service specific service_advisor files:
ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py
ambari-server/src/test/python/common-services/PXF/test_service_advisor.py


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
e254094 
  ambari-server/src/main/resources/stacks/stack_advisor.py d8685c3 
  ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
PRE-CREATION 
  ambari-server/src/test/python/common-services/PXF/test_service_advisor.py 
PRE-CREATION 
  ambari-server/src/test/python/common-services/configs/hawq_default.json 
PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/services-hawq-3-hosts.json
 PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/services-hawq-pxf-hdfs.json
 PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/services-master_ambari_colo-3-hosts.json
 PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/services-master_standby_colo-3-hosts.json
 PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/services-nohawq-3-hosts.json
 PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/services-normal-hawq-3-hosts.json
 PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/services-normal-nohawq-3-hosts.json
 PRE-CREATION 
  
ambari-server/src/test/python/common-services/configs/services-standby_ambari_colo-3-hosts.json
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_component_status.py  
  
ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_segment_registration_status.py
 6bb5930 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_sync_status.py 
fd4f474 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py 88fb008 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 8639ca5 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py b406723 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 8d97baa 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_utils.py  
  ambari-server/src/test/python/stacks/2.3/PXF/test_alerts_api_status.py  
  ambari-server/src/test/python/stacks/2.3/PXF/test_pxf.py 1147a7e 
  ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 4ea3bfb 
  ambari-server/src/test/python/stacks/2.3/common/hosts-1-host.json  
  ambari-server/src/test/python/stacks/2.3/common/hosts-3-hosts.json  
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-1-host.json 
515ba7d 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-3-hosts.json 
515ba7d 
  ambari-server/src/test/python/stacks/2.3/common/services-hawq-pxf-hdfs.json 
0bf459d 
  
ambari-server/src/test/python/stacks/2.3/common/services-master_ambari_colo-3-hosts.json
 1657ccf 
  
ambari-server/src/test/python/stacks/2.3/common/services-master_standby_colo-3-hosts.json
 cd5d02c 
  ambari-server/src/test/python/stacks/2.3/common/services-nohawq-3-hosts.json 
beeb62d 
  
ambari-server/src/test/python/stacks/2.3/common/services-normal-hawq-3-hosts.json
 5495d77 
  
ambari-server/src/test/python/stacks/2.3/common/services-normal-nohawq-3-hosts.json
 2149317 
  
ambari-server/src/test/python/stacks/2.3/common/services-standby_ambari_colo-3-hosts.json
 92a8e58 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 2944f6f 
  ambari-server/src/test/python/stacks/2.3/configs/hawq_default.json ebff461 
  ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json  

Diff: https://reviews.apache.org/r/49521/diff/


Testing
---

Total run:1005
Total errors:0
Total failures:0
OK


Thanks,

Lav Jain

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

2016-07-03 Thread Jungtaek Lim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49514/#review140599
---


Ship it!




Ship It!

- Jungtaek Lim


On 7 3, 2016, 1:23 오후, Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49514/
> ---
> 
> (Updated 7 3, 2016, 1:23 오후)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jungtaek Lim, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17080
> https://issues.apache.org/jira/browse/AMBARI-17080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Support 2 storm sinks.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml 941c3aa 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink-windows.xml 
> e82d2d4 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 4a3b7c5 
>   ambari-metrics/ambari-metrics-common/pom.xml 3e11e7f 
>   ambari-metrics/ambari-metrics-storm-sink-legacy/pom.xml PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/assemblies/empty.xml 
> PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink-legacy/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  PRE-CREATION 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml ee4d2c3 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/conf/storm-metrics2.properties.j2
>  4553224 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/NumberUtil.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsReporter.java
>  8f98563 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
>  0ef09d6 
>   
> ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
>  4ea7396 
>   ambari-metrics/pom.xml 726a823 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/storm-site.xml
>  0d029e8 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
>  fac6331 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm.py
>  2d50767 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/ui_server.py
>  6551067 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm-metrics2.properties.j2
>  ea8b1d0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/storm-site.xml
>  f3bbce8 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 2fcb7e2 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 
> f7a2686 
> 
> Diff: https://reviews.apache.org/r/49514/diff/
> 
> 
> Testing
> ---
> 
> Unit testst passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 49584: Remove spark.driver.extraJavaOptions and spark.yarn.am.extraJavaOptions property in upgrading to HDP 2.5

2016-07-03 Thread Saisai Shao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49584/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-17545
https://issues.apache.org/jira/browse/AMBARI-17545


Repository: ambari


Description
---

Remove spark.driver.extraJavaOptions and spark.yarn.am.extraJavaOptions 
property in upgrading


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
bfdb3d3 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 a7383a2 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
85ffb8c 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
bd1bef2 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 00dbaa7 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
68e8fc2 

Diff: https://reviews.apache.org/r/49584/diff/


Testing
---

N/A


Thanks,

Saisai Shao

Re: Review Request 49519: Fix Logfeeder visibilities

2016-07-03 Thread Hayat Behlim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49519/#review140605
---


Ship it!




Ship It!

- Hayat Behlim


On July 1, 2016, 4:46 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49519/
> ---
> 
> (Updated July 1, 2016, 4:46 p.m.)
> 
> 
> Review request for Ambari, Hayat Behlim, Oliver Szabo, Robert Nettleton, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17528
> https://issues.apache.org/jira/browse/AMBARI-17528
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Many variables/functions have a broader visibility than needed.
> 
> Also remvoed some more unused code.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/AliasUtil.java
>  c3b36df 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/ConfigBlock.java
>  088472e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/InputMgr.java
>  d83642e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  c5d4fd5 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
>  1b9171b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
>  78d0499 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/MetricsMgr.java
>  4a8f7d0 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/OutputMgr.java
>  f6d3481 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java
>  d34eed6 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java
>  31e1cd1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  7b1e5e0 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java
>  2e38255 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputFile.java
>  3538ba0 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputS3File.java
>  9d5f970 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/reader/GZIPReader.java
>  7c455f6 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
>  4833d3f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/ApplyLogFilter.java
>  c71d4b9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/filter/DefaultDataFilter.java
>  e67512b 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/Mapper.java
>  b87ce50 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperDate.java
>  f293ede 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldName.java
>  afbb126 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldValue.java
>  00a69df 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/Output.java
>  0624c59 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java
>  19dd404 
> 
> Diff: https://reviews.apache.org/r/49519/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> Tests run: 36, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 49573: [Change Log Directory] Storm service is going down after modifying the storm_log_dir variable

Re: Review Request 49573: [Change Log Directory] Storm service is going down after modifying the storm_log_dir variable

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

Re: Review Request 49521: Move service advisor tests for HAWQ and PXF

Re: Review Request 49514: Support Storm 1.0 in Ambari Metrics for Storm

Review Request 49584: Remove spark.driver.extraJavaOptions and spark.yarn.am.extraJavaOptions property in upgrading to HDP 2.5

Re: Review Request 49519: Fix Logfeeder visibilities

9 matches

Site Navigation

Mail list logo

Footer information