Review Request 51364: Set the default 1.8 JDK to 18.0_77 for Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51364/ --- Review request for Ambari, Balázs Bence Sári, Miklos Gergely, and Oliver Szabo. Bugs: AMBARI-18249 https://issues.apache.org/jira/browse/AMBARI-18249 Repository: ambari Description --- Set 1.8.0_77 as the default JDK version when java 1.8 is selected for Ambari during setup. Diffs - ambari-server/conf/unix/ambari.properties b8e41b7 ambari-server/src/main/python/ambari_server/serverSetup.py d80c25a Diff: https://reviews.apache.org/r/51364/diff/ Testing --- 1. Manual testing with Centos6/RHEL6. 2. Unit tests: Three tests failed but those are unrelated to this change. Thanks, Sebastian Toader
Re: Review Request 51364: Set the default 1.8 JDK to 18.0_77 for Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51364/#review146643 --- Ship it! Ship It! - Miklos Gergely On Aug. 24, 2016, 11:34 a.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51364/ > --- > > (Updated Aug. 24, 2016, 11:34 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Miklos Gergely, and Oliver > Szabo. > > > Bugs: AMBARI-18249 > https://issues.apache.org/jira/browse/AMBARI-18249 > > > Repository: ambari > > > Description > --- > > Set 1.8.0_77 as the default JDK version when java 1.8 is selected for Ambari > during setup. > > > Diffs > - > > ambari-server/conf/unix/ambari.properties b8e41b7 > ambari-server/src/main/python/ambari_server/serverSetup.py d80c25a > > Diff: https://reviews.apache.org/r/51364/diff/ > > > Testing > --- > > 1. Manual testing with Centos6/RHEL6. > > > 2. Unit tests: > > Three tests failed but those are unrelated to this change. > > > Thanks, > > Sebastian Toader > >
Re: Review Request 51364: Set the default 1.8 JDK to 18.0_77 for Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51364/#review146644 --- Ship it! Ship It! - Balázs Bence Sári On Aug. 24, 2016, 11:34 a.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51364/ > --- > > (Updated Aug. 24, 2016, 11:34 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Miklos Gergely, and Oliver > Szabo. > > > Bugs: AMBARI-18249 > https://issues.apache.org/jira/browse/AMBARI-18249 > > > Repository: ambari > > > Description > --- > > Set 1.8.0_77 as the default JDK version when java 1.8 is selected for Ambari > during setup. > > > Diffs > - > > ambari-server/conf/unix/ambari.properties b8e41b7 > ambari-server/src/main/python/ambari_server/serverSetup.py d80c25a > > Diff: https://reviews.apache.org/r/51364/diff/ > > > Testing > --- > > 1. Manual testing with Centos6/RHEL6. > > > 2. Unit tests: > > Three tests failed but those are unrelated to this change. > > > Thanks, > > Sebastian Toader > >
Review Request 51370: DB consistency check should tolerate services with no configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51370/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sebastian Toader. Repository: ambari Description --- Services with no configs triggered an error in DB consistency checker during Ambari server start. Since the Microsoft R mpack has no configs at all, installing the Microsoft R mpack would result in error during server start. This patch lowers the check to warning level. Diffs - ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 36a2d99 ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java a7c77e1 Diff: https://reviews.apache.org/r/51370/diff/ Testing --- 1. Tested manually 2. Wrote a new unit tests 3. All unit tests in ambari-servers passed. Thanks, Balázs Bence Sári
Re: Review Request 51370: DB consistency check should tolerate services with no configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51370/#review146670 --- Ship it! Ship It! - Jonathan Hurley On Aug. 24, 2016, 11:34 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51370/ > --- > > (Updated Aug. 24, 2016, 11:34 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and > Sebastian Toader. > > > Repository: ambari > > > Description > --- > > Services with no configs triggered an error in DB consistency checker during > Ambari server start. Since the Microsoft R mpack has no configs at all, > installing the Microsoft R mpack would result in error during server start. > This patch lowers the check to warning level. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 36a2d99 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > a7c77e1 > > Diff: https://reviews.apache.org/r/51370/diff/ > > > Testing > --- > > 1. Tested manually > 2. Wrote a new unit tests > 3. All unit tests in ambari-servers passed. > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 51370: DB consistency check should tolerate services with no configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51370/#review146684 --- Ship it! Ship It! - Nate Cole On Aug. 24, 2016, 11:34 a.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51370/ > --- > > (Updated Aug. 24, 2016, 11:34 a.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and > Sebastian Toader. > > > Repository: ambari > > > Description > --- > > Services with no configs triggered an error in DB consistency checker during > Ambari server start. Since the Microsoft R mpack has no configs at all, > installing the Microsoft R mpack would result in error during server start. > This patch lowers the check to warning level. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 36a2d99 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > a7c77e1 > > Diff: https://reviews.apache.org/r/51370/diff/ > > > Testing > --- > > 1. Tested manually > 2. Wrote a new unit tests > 3. All unit tests in ambari-servers passed. > > > Thanks, > > Balázs Bence Sári > >
Review Request 51383: Atlas on HDP 2.5 Has An Incorrect versionAdvertised Field
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51383/
---
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-18256
https://issues.apache.org/jira/browse/AMBARI-18256
Repository: ambari
Description
---
AMBARI-18165 introduced a regression where {{ATLAS_SERVER}} has a
{{versionAdvertised}} of {{false}} on HDP 2.5 installations. This causes the
{{version}} field in the {{hostcomponentnstate}} table to be listed as
{{UNKNOWN}}.
```
APP_TIMELINE_SERVER 2.5.0.0-1237
ATLAS_CLIENT2.5.0.0-1237
ATLAS_CLIENT2.5.0.0-1237
ATLAS_CLIENT2.5.0.0-1237
ATLAS_CLIENT2.5.0.0-1237
ATLAS_CLIENT2.5.0.0-1237
ATLAS_SERVERUNKNOWN
```
Diffs
-
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml
84e8e46
Diff: https://reviews.apache.org/r/51383/diff/
Testing
---
Installed Atlas on HDP 2.5 and observed a version get populated.
Thanks,
Jonathan Hurley
Review Request 51382: AMBARI-18250
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51382/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and Sid Wagle. Bugs: AMBARI-18250 https://issues.apache.org/jira/browse/AMBARI-18250 Repository: ambari Description --- Pig View Caching issue causes File does not exist: /user//pig/jobs/job_id/stdout and stderr intermittently Diffs - contrib/views/pig/src/main/resources/ui/pig-web/app/initialize.js 38ee093 Diff: https://reviews.apache.org/r/51382/diff/ Testing --- done. Issue is intermittent and can not be reproduced everytime. Thanks, Jay SenSharma
Re: Review Request 51296: Error around ATLAS_SERVER version advertisement
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51296/#review146687
---
Reverted patch since underlying problem was fixed by AMBARI-18256
(https://reviews.apache.org/r/51383/)
commit e0e708f66fc46b514455d84552cb21670849491c
- Alejandro Fernandez
On Aug. 23, 2016, 10:34 a.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51296/
> ---
>
> (Updated Aug. 23, 2016, 10:34 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate
> Cole.
>
>
> Bugs: AMBARI-18231
> https://issues.apache.org/jira/browse/AMBARI-18231
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Noticed in the stack deploy runs:
> {code}
> 20 Aug 2016 11:20:07,519 ERROR [ambari-heartbeat-processor-0]
> StackVersionListener:116 - ServiceComponent {0} doesn't advertise version,
> however ServiceHostComponent ATLAS_SERVER on host ATLAS_SERVER advertised
> version as host. Skipping version update
> {code}
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
> 87247eb
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
> 537ae32
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java
> 2dae526
>
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
> 905707c
>
> Diff: https://reviews.apache.org/r/51296/diff/
>
>
> Testing
> ---
>
> on live cluster
> unit test run
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 51383: Atlas on HDP 2.5 Has An Incorrect versionAdvertised Field
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51383/#review146691
---
Ship it!
Ship It!
- Nate Cole
On Aug. 24, 2016, 2:19 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51383/
> ---
>
> (Updated Aug. 24, 2016, 2:19 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-18256
> https://issues.apache.org/jira/browse/AMBARI-18256
>
>
> Repository: ambari
>
>
> Description
> ---
>
> AMBARI-18165 introduced a regression where {{ATLAS_SERVER}} has a
> {{versionAdvertised}} of {{false}} on HDP 2.5 installations. This causes the
> {{version}} field in the {{hostcomponentnstate}} table to be listed as
> {{UNKNOWN}}.
>
> ```
> APP_TIMELINE_SERVER 2.5.0.0-1237
> ATLAS_CLIENT 2.5.0.0-1237
> ATLAS_CLIENT 2.5.0.0-1237
> ATLAS_CLIENT 2.5.0.0-1237
> ATLAS_CLIENT 2.5.0.0-1237
> ATLAS_CLIENT 2.5.0.0-1237
> ATLAS_SERVER UNKNOWN
> ```
>
>
> Diffs
> -
>
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml
> 84e8e46
>
> Diff: https://reviews.apache.org/r/51383/diff/
>
>
> Testing
> ---
>
> Installed Atlas on HDP 2.5 and observed a version get populated.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 49755: AMBARI-17602: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49755/#review146662 --- Ship it! Ship It! - Sreenath Somarajapuram On Aug. 23, 2016, 7:18 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49755/ > --- > > (Updated Aug. 23, 2016, 7:18 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-17602 > https://issues.apache.org/jira/browse/AMBARI-17602 > > > Repository: ambari > > > Description > --- > > Fetching current rm configuration of queues. > Updating queue states based on states in configuration. > Preemption implementation. > Bug fixes. > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java > e5f5cb5 > contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js > 770db51 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > bf74af6 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js > 9b31e57 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > 7bb3f82 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > bfcd4b6 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 545d348 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > f42d2e4 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 683bc6f > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > e91c90f > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > 49363d4 > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > c3976b4 > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 36228a1 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > e849ad4 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 6e310ad > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > b75237f > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs > e659f5c > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > b4891cd > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs > bb82025 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > b1a8708 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs > 2848fed > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs > 9e25cc6 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs > c430a44 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs > 96cbe99 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs > bd49c50 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs > ef5663d > > contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js > a5d0ef6 > > Diff: https://reviews.apache.org/r/49755/diff/ > > > Testing > --- > > Manual Unit Testing > > > Thanks, > > Akhil PB > >
Re: Review Request 51364: Set the default 1.8 JDK to 18.0_77 for Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51364/ --- (Updated Aug. 24, 2016, 2:25 p.m.) Review request for Ambari, Balázs Bence Sári, Miklos Gergely, and Oliver Szabo. Bugs: AMBARI-18249 https://issues.apache.org/jira/browse/AMBARI-18249 Repository: ambari Description --- Set 1.8.0_77 as the default JDK version when java 1.8 is selected for Ambari during setup. Diffs - ambari-server/conf/unix/ambari.properties b8e41b7 ambari-server/src/main/python/ambari_server/serverSetup.py d80c25a Diff: https://reviews.apache.org/r/51364/diff/ Testing --- 1. Manual testing with Centos6/RHEL6. 2. Unit tests: Three tests failed but those are unrelated to this change. Thanks, Sebastian Toader
Re: Review Request 51364: Set the default 1.8 JDK to 18.0_77 for Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51364/ --- (Updated Aug. 24, 2016, 3:54 p.m.) Review request for Ambari, Balázs Bence Sári, Miklos Gergely, and Oliver Szabo. Bugs: AMBARI-18249 https://issues.apache.org/jira/browse/AMBARI-18249 Repository: ambari Description --- Set 1.8.0_77 as the default JDK version when java 1.8 is selected for Ambari during setup. Diffs - ambari-server/conf/unix/ambari.properties b8e41b7 ambari-server/src/main/python/ambari_server/serverSetup.py d80c25a Diff: https://reviews.apache.org/r/51364/diff/ Testing --- 1. Manual testing with Centos6/RHEL6. 2. Unit tests: Three tests failed but those are unrelated to this change. Thanks, Sebastian Toader
Review Request 51386: Add unique constraint to host_version table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51386/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBARI-18255 https://issues.apache.org/jira/browse/AMBARI-18255 Repository: ambari Description --- The software is allowing duplicate records into the host_version table. This should be constrained in the db. This will only get pushed to trunk, not a 2.4 branch. Diffs - ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java f7644d3 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java 6be4b50 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java e1b9368 ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java ebfb267 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java PRE-CREATION ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c20cd1b ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f30b2eb ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50feb87 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0843616 ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 43bdef9 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 1ef4ae1 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql babcb6d ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java d8e1576 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java PRE-CREATION Diff: https://reviews.apache.org/r/51386/diff/ Testing --- Tests run: 4609, Failures: 0, Errors: 0, Skipped: 34 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 1:25:27.562s [INFO] Finished at: Wed Aug 24 15:59:06 EDT 2016 [INFO] Final Memory: 34M/759M [INFO] Thanks, Nate Cole
