Review Request 51640: After staring rm ha, the config of 'yarn.resoucemanager.admin.address.rm1' and 'yarn.resoucemanager.admin.address.rm2' are missing

[alice alice]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51640/
---

Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Vitalyi Brodetskyi.


Repository: ambari


Description
---

1?when deploying rm ha,the config of 'yarn.resoucemanager.admin.address.rm1' 
and 'yarn.resoucemanager.admin.address.rm2' are missing; so we need to config 
these.


Diffs
-

  
ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js
 36dcfb8 
  ambari-web/app/data/HDP2/rm_ha_properties.js fb1bd13 
  ambari-web/app/utils/configs/rm_ha_config_initializer.js dac68d9 

Diff: https://reviews.apache.org/r/51640/diff/


Testing
---

done it


Thanks,

alice alice

Re: Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51629/#review147782
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 328)


This does't look right, the component needs to be on the smae host as well. 
Wouldn't this always return true on a multi-host cluster ?


- Sid Wagle


On Sept. 5, 2016, 11:43 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51629/
> ---
> 
> (Updated Sept. 5, 2016, 11:43 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18309
> https://issues.apache.org/jira/browse/AMBARI-18309
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add db consistency check for hostcomponent tables, for each component we 
> should have only one state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  36a2d99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  535d74f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  a7c77e1 
> 
> Diff: https://reviews.apache.org/r/51629/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 51637: Add logging to differentiate between ambari-server start/restart commands vs. other commands

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51637/
---

Review request for Ambari and Dmytro Grinenko.


Bugs: AMBARI-18273
https://issues.apache.org/jira/browse/AMBARI-18273


Repository: ambari


Description
---

fix tests


Diffs
-

  ambari-server/src/test/python/TestAmbariServer.py f6bf685 

Diff: https://reviews.apache.org/r/51637/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51238/
---

(Updated Sept. 5, 2016, 1:26 p.m.)


Review request for Ambari, Jayush Luniya, Nate Cole, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

Review comments fixed


Bugs: AMBARI-15538
https://issues.apache.org/jira/browse/AMBARI-15538


Repository: ambari


Description
---

Implementation contains the following things:
- On startup, add-on service repos are loaded into the stack model
- On startup, add-on service repos are merged into the VDF's downloaded by 
LatestRepoCallable
- On startup, if the is an existing cluster, it's repository version entity is 
potentially updated with new add-on service repos.
- Repository definitions contain two new optional fields: service_name and 
service_version. (null for stack repositories) 
- Small changes on the Mictrosoft-R mpack (supoorts HDP-2.4 and 2.5)
- New unit tests


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 9f7419c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 b1fd592 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 d20b1d7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
 02fc2ec 
  ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 
3acc617 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
23b0218 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 7bcd08b 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java 
29776ed 
  ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
14ff9de 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
 50d6028 
  ambari-server/src/main/resources/version_definition.xsd bd49028 
  ambari-server/src/test/java/org/apache/ambari/server/stack/RepoUtilTest.java 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerCommonServicesTest.java
 1d73ff3 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackModuleTest.java 
PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest.java
 PRE-CREATION 
  
ambari-server/src/test/resources/common-services/ADDON/1.0/configuration/addon-env.xml
 PRE-CREATION 
  ambari-server/src/test/resources/common-services/ADDON/1.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/test/resources/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartupTest_initialRepos.json
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_common_services/HDP/0.2/services/ADDON/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_common_services/HDP/0.2/services/ADDON/repos/repoinfo.xml
 PRE-CREATION 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/configuration/microsoft-r-env.xml
 PRE-CREATION 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/microsoft_r.py
 61ea96b 
  
contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml
 PRE-CREATION 
  contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json 
f90ccce 

Diff: https://reviews.apache.org/r/51238/diff/


Testing
---

- Manually tested
- Wrote new unit tests
- All unit tests passed except two which were failing in CI builds as well.


Thanks,

Balázs Bence Sári

Review Request 51629: Add check to DB conistency checker for duplicate hostcomponentstate

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51629/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sid Wagle.


Bugs: AMBARI-18309
https://issues.apache.org/jira/browse/AMBARI-18309


Repository: ambari


Description
---

Add db consistency check for hostcomponent tables, for each component we should 
have only one state.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 36a2d99 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
 535d74f 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 a7c77e1 

Diff: https://reviews.apache.org/r/51629/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi