Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/#review157734 --- Ship it! Ship It! - Sebastian Toader On Dec. 1, 2016, 11:45

Review Request 54306: Do not change timeline.metrics.service.webapp.address in move wizard

2016-12-02 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54306/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-19063

Re: Review Request 54249: Remove unnecessary Log Feeder Date Mapper tests

2016-12-02 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54249/ --- (Updated Dec. 2, 2016, 2:16 p.m.) Review request for Ambari, Oliver Szabo,

Review Request 54305: Hive view history tab does not list queries, if there are large number of queries

2016-12-02 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54305/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 54306: Do not change timeline.metrics.service.webapp.address in move wizard

2016-12-02 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54306/#review157738 --- Ship it! Ship It! - Andriy Babiichuk On Гру. 2, 2016, 1:53

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-02 Thread Balázs Bence Sári
> On Dec. 1, 2016, 9:15 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java, > > line 81 > > > > > > `throws IOEXception` does

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/#review157733 --- Fix it, then Ship it! Ship It!

Re: Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster

2016-12-02 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54169/ --- (Updated Dec. 2, 2016, 1:01 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster

2016-12-02 Thread Mugdha Varadkar
> On Dec. 1, 2016, 5:53 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 329 > > > > > > Sorry to nitpick here, these 4 functions

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-02 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/ --- (Updated Dec. 2, 2016, 2:06 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-02 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/ --- (Updated Dec. 2, 2016, 2:10 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 54326: Remove 'llap_queue_capacity' references from UI code.

2016-12-02 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54326/#review157846 --- Ship it! Ship It! - Yusaku Sako On Dec. 2, 2016, 10:33

Re: Review Request 54303: Ambari-server restart command not working. if any parameters are changed and reset to default.

2016-12-02 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54303/#review157718 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 2, 2016,

Review Request 54303: Ambari-server restart command not working. if any parameters are changed and reset to default.

2016-12-02 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54303/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-19061

Review Request 54326: Remove 'llap_queue_capacity' references from UI code.

2016-12-02 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54326/ --- Review request for Ambari, Xi Wang and Yusaku Sako. Bugs: AMBARI-19069

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-02 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/#review157751 --- Ship it! Ship It! - Attila Doroszlai On Dec. 2, 2016, 3:10

Re: Review Request 54308: Refactor widgets on Dashboard page

2016-12-02 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54308/#review157753 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 2, 2016,

Re: Review Request 53943: Improve remoteIp in audit log

2016-12-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157758 --- Pushed to trunk and branch-2.5 - please close this review. -

Re: Review Request 54267: RU: wrong version exposed when Downgrade is going

2016-12-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54267/ --- (Updated Dec. 2, 2016, 11:18 a.m.) Review request for Ambari, Alejandro

Re: Review Request 54276: AMBARI-19038: Support migration of LDAP users & groups to PAM

2016-12-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54276/#review157761 --- hi Vishal, Could you please described how you have tested it?

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/#review157749 --- Ship it! Ship It! - Robert Nettleton On Dec. 1, 2016, 10:45

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/ --- (Updated Dec. 2, 2016, 9:43 a.m.) Review request for Ambari, Nate Cole, Robert

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/#review157760 --- Ship it! Ship It! - Robert Levas On Dec. 2, 2016, 9:43

Review Request 54308: Refactor widgets on Dashboard page

2016-12-02 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54308/ --- Review request for Ambari and Aleksandr Kovalenko. Bugs: AMBARI-19064

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-02 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Dec. 2, 2016, 10:18 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 54314: AMBARI-18926: Kerberos Wizard UI creates duplicate radio buttons for FreeIPA

2016-12-02 Thread Jesus Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54314/ --- (Updated Dec. 2, 2016, 6:18 p.m.) Review request for Ambari, Alexandr

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Nate Cole
> On Dec. 2, 2016, 1:26 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java, > > line 57 > > > > > > I think this will work most of the

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5

2016-12-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54175/#review157773 --- Ship it! Ship It! - Jonathan Hurley On Nov. 30, 2016, 3:08

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/#review157786 --- Ship it! Ship It! - Nate Cole On Dec. 2, 2016, 9:43 a.m.,

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Alejandro Fernandez
> On Dec. 2, 2016, 6:26 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java, > > line 57 > > > > > > I think this will work most of the

Re: Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5

2016-12-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54175/#review157778 --- This has been pushed to trunk and branch-2.5. Please close this

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/#review15 ---

Re: Review Request 54259: In stack version, build number should not be mandatory

2016-12-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54259/#review157779 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 2, 2016,

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/#review157825 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 2, 2016,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-02 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Dec. 2, 2016, 12:45 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-02 Thread Jonathan Hurley
> On Dec. 2, 2016, 2:41 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java, > > line 335 > > > > > > What if the cluster name is provided, but

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157822 --- Ship it! Ship It! - Jonathan Hurley On Dec. 2, 2016, 3:45

Re: Review Request 54276: AMBARI-19038: Support migration of LDAP users & groups to PAM

2016-12-02 Thread Vishal Ghugare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54276/ --- (Updated Dec. 2, 2016, 12:19 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54314: AMBARI-18926: Kerberos Wizard UI creates duplicate radio buttons for FreeIPA

2016-12-02 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54314/#review157801 --- Ship it! Ship It! - Sangeeta Ravindran On Dec. 2, 2016,

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Jonathan Hurley
> On Dec. 2, 2016, 1:26 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java, > > line 57 > > > > > > I think this will work most of the

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-02 Thread Nahappan Somasundaram
> On Dec. 2, 2016, 11:41 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java, > > line 335 > > > > > > What if the cluster name is provided, but

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-02 Thread Jonathan Hurley
> On Dec. 2, 2016, 7:42 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java, > > line 93 > > > > > > Shouldn't this return a previously

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-12-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/#review157756 --- This has been pushed to trunk and branch-2.5 - please close the

Re: Review Request 54314: AMBARI-18926: Kerberos Wizard UI creates duplicate radio buttons for FreeIPA

2016-12-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54314/#review157794 --- Ship it! Ship It! - Di Li On Dec. 2, 2016, 6:18 p.m., Jesus

Re: Review Request 54259: In stack version, build number should not be mandatory

2016-12-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54259/#review157793 --- Ship it! Ship It! - Di Li On Dec. 2, 2016, 5:44 p.m.,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157803 ---

Review Request 54318: Escaped usernames passed to the post-user creation script

2016-12-02 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54318/ --- Review request for Ambari, Attila Doroszlai, Sandor Magyari, and Sebastian

Re: Review Request 54259: In stack version, build number should not be mandatory

2016-12-02 Thread Amruta Borkar
> On Dec. 2, 2016, 7:16 p.m., Di Li wrote: > > Ship It! Thanks Di, Could you please help me push this to trunk? - Amruta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54259/#review157793

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-02 Thread Nahappan Somasundaram
> On Dec. 2, 2016, 11:41 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java, > > line 335 > > > > > > What if the cluster name is provided, but