Re: Review Request 54865: Ambari UI should use "hosts_with_failures" from "host_resolution_check" in host check

2016-12-19 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54865/#review159620 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 19, 2016,

Re: Review Request 54864: AMBARI-19225 Ambari server should prints error messages to its log if it can't find property for given property attribute type

2016-12-19 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54864/ --- (Updated Dec. 19, 2016, 4:58 p.m.) Review request for Ambari and Tim Thorpe.

Review Request 54864: AMBARI-19225 Ambari server should prints error messages to its log if it can't find property for given property attribute type

2016-12-19 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54864/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-19225

Re: Review Request 54864: AMBARI-19225 Ambari server should prints error messages to its log if it can't find property for given property attribute type

2016-12-19 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54864/#review159621 --- Ship it! Ship It! - Tim Thorpe On Dec. 19, 2016, 4:58 p.m.,

Re: Review Request 54817: AMBARI-19227 :: Provide support to show Ranger solr-configs in Ambari.

2016-12-19 Thread Vishal Suvagia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54817/ --- (Updated Dec. 19, 2016, 4:14 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54862: Stackadvisor: incorrect recommendations when only one of two dependencies was changed

2016-12-19 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54862/#review159614 --- Ship it! Ship It! - Dmytro Sen On Дек. 19, 2016, 2:34 п.п.,

Review Request 54865: Ambari UI should use "hosts_with_failures" from "host_resolution_check" in host check

2016-12-19 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54865/ --- Review request for Ambari and Aleksandr Kovalenko. Bugs: AMBARI-19240

Re: Review Request 54861: 'Cluster User' role issue after Ambari 2.4.2.0 upgrade

2016-12-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54861/#review159623 ---

Review Request 54866: AMBARI-19149. Code cleanup: unchecked casts in *AuditEventBuilder

2016-12-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54866/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo Puskas,

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

2016-12-19 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/ --- (Updated Dec. 19, 2016, 10:22 a.m.) Review request for Ambari, Jonathan

Review Request 54857: Refactor Ambari service def configurations for Zeppelin

2016-12-19 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54857/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush

Re: Review Request 54791: After rescanning yarn queue, Ambari still asks for RM to be restarted

2016-12-19 Thread Dmytro Sen
> On Дек. 16, 2016, 3:26 п.п., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py, lines 430-439 > > > > > > Where in the Ambari Server code does it send down > >

Review Request 54871: HDP 3.0 flatten Role Command Order and remote duplicate configs

2016-12-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54871/ --- Review request for Ambari, Sumit Mohanty and Sid Wagle. Bugs: AMBARI-19095

Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-19 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54460/#review159645 --- Ship it! Ship It! - Jaimin Jetly On Dec. 19, 2016, 7:38

Review Request 54872: AMBARI-19226 Provide default value for hdfs_tmp_dir parameter in HDFS params script.

2016-12-19 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54872/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-19226

Re: Review Request 54871: HDP 3.0 flatten Role Command Order and remote duplicate configs

2016-12-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54871/#review159640 ---

Re: Review Request 54866: AMBARI-19149. Code cleanup: unchecked casts in *AuditEventBuilder

2016-12-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54866/#review159662 --- Ship it! I agree it's a big patch, but I'm OK since the

Review Request 54860: ATS reports as down in Ambari UI after upgrade

2016-12-19 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54860/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-19233

Re: Review Request 54860: ATS reports as down in Ambari UI after upgrade

2016-12-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54860/#review159596 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 19, 2016,

Re: Review Request 54866: AMBARI-19149. Code cleanup: unchecked casts in *AuditEventBuilder

2016-12-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54866/#review159654 --- Ship it! While I see this patch is _technically_ correct, it's

Re: Review Request 54866: AMBARI-19149. Code cleanup: unchecked casts in *AuditEventBuilder

2016-12-19 Thread Alejandro Fernandez
> On Dec. 19, 2016, 9:51 p.m., Nate Cole wrote: > > While I see this patch is _technically_ correct, it's awfully big for just > > a simple change that could be handled with a > > @SuppressWarnings("unchecked"). I'll let others comment. +1 on supressing that warning - Alejandro

Re: Review Request 54861: 'Cluster User' role issue after Ambari 2.4.2.0 upgrade

2016-12-19 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54861/ --- (Updated Dec. 19, 2016, 1:45 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 54791: After rescanning yarn queue, Ambari still asks for RM to be restarted

2016-12-19 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54791/#review159624 --- Ship it! Ship It! - Jonathan Hurley On Dec. 15, 2016, 12:51

Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-19 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54460/ --- (Updated Dec. 19, 2016, 11:38 a.m.) Review request for Ambari, Jaimin Jetly,

Re: Review Request 54815: Exception when running Slider view - java.lang.NoClassDefFoundError: org/apache/hadoop/yarn/api/protocolrecords/GetLabelsToNodesResponse

2016-12-19 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54815/#review159598 --- Ship it! Ship It! - Tim Thorpe On Dec. 17, 2016, 12:31

Re: Review Request 54735: AMBARI-19149. Code cleanup: empty blocks

2016-12-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54735/#review159606 --- Ship it! Ship It! - Nate Cole On Dec. 19, 2016, 4:22 a.m.,

Review Request 54862: Stackadvisor: incorrect recommendations when only one of two dependencies was changed

2016-12-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54862/ --- Review request for Ambari, Dmytro Grinenko, Dmytro Sen, and Sumit Mohanty.

Review Request 54874: AMBARI-19241 - Ambari python scripts should support hdfs download

2016-12-19 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54874/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Di Li,

Re: Review Request 54872: AMBARI-19226 Provide default value for hdfs_tmp_dir parameter in HDFS params script.

2016-12-19 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54872/#review159651 --- Ship it! Ship It! - Tim Thorpe On Dec. 19, 2016, 7:52 p.m.,