Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

2017-05-02 Thread Bharat Viswanadham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58927/ --- (Updated May 2, 2017, 5:28 p.m.) Review request for Ambari, Alejandro

Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

2017-05-02 Thread Bharat Viswanadham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58927/ --- Review request for Ambari, Alejandro Fernandez and Di Li. Repository: ambari

Re: Review Request 58840: AMBARI-20886. Create idempotent Ambari DB Schema SQL script for AzureDB

2017-05-02 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58840/ --- (Updated May 2, 2017, 9:24 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

2017-05-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57687/#review173621 --- Ship it! Ship It! - Alejandro Fernandez On April 17, 2017,

Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

2017-05-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58927/#review173620 ---

Re: Review Request 58840: AMBARI-20886. Create idempotent Ambari DB Schema SQL script for AzureDB

2017-05-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58840/#review173618 --- Fix it, then Ship it!

Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

2017-05-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58927/#review173612 --- Ship it! Ship It! - Di Li On May 2, 2017, 5:28 p.m., Bharat

Re: Review Request 58842: wrong ZK parent node (hbase-unsecure) getting configured as part of the jdbc(phoenix) URL on ubuntu secured cluster

2017-05-02 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58842/#review173565 --- Ship it! Ship It! - Pallav Kulshreshtha On April 28, 2017,

Re: Review Request 58842: wrong ZK parent node (hbase-unsecure) getting configured as part of the jdbc(phoenix) URL on ubuntu secured cluster

2017-05-02 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58842/#review173563 --- Ship it! Ship It! - Renjith Kamath On April 28, 2017, noon,

Re: Review Request 58842: wrong ZK parent node (hbase-unsecure) getting configured as part of the jdbc(phoenix) URL on ubuntu secured cluster

2017-05-02 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58842/#review173564 --- Ship it! Ship It! - Gaurav Nagar On April 28, 2017, noon,

Re: Review Request 58886: Smartsense view do not load and shows blank

2017-05-02 Thread Nitiraj Rathore
> On May 1, 2017, 6:59 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java > > Lines 186 (patched) > > > > > > Why does the cluster ID change? > >

Re: Review Request 58842: wrong ZK parent node (hbase-unsecure) getting configured as part of the jdbc(phoenix) URL on ubuntu secured cluster

2017-05-02 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58842/#review173567 --- Ship it! Ship It! - venkat sairam On April 28, 2017, noon,

Re: Review Request 58886: Smartsense view do not load and shows blank

2017-05-02 Thread Nitiraj Rathore
> On May 1, 2017, 6:59 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java > > Lines 186 (patched) > > > > > > Why does the cluster ID change? > >

Re: Review Request 58929: Create Database Schema for Improved User Account Management

2017-05-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58929/#review173630 --- Fix it, then Ship it! I'm assuming UpgradeCatalog changes are

Re: Review Request 58911: HDP 3.0 TP - Unable to install Spark, cannot find package/scripts dir

2017-05-02 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58911/#review173652 --- Ship it! Ship It! - Sid Wagle On May 2, 2017, 2:28 a.m.,

Re: Review Request 58857: Setting Desired Stack Ids to Correct Values During Service and Patch Upgrades

2017-05-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58857/ --- (Updated May 2, 2017, 4:04 p.m.) Review request for Ambari, Alejandro

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

2017-05-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58489/#review173637 --- What's the state of this review? Seems like it's been dormant for

Re: Review Request 58823: Trunk patch - Storm Log4J Regex Replacement on Upgrade Fails

2017-05-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58823/#review173648 --- Ship it! Ship It! - Alejandro Fernandez On April 27, 2017,

Re: Review Request 58929: Create Database Schema for Improved User Account Management

2017-05-02 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58929/#review173631 --- FYI see https://reviews.apache.org/r/58840/ for a way to

Re: Review Request 58929: Create Database Schema for Improved User Account Management

2017-05-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58929/#review173629 --- ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql

Re: Review Request 58929: Create Database Schema for Improved User Account Management

2017-05-02 Thread Robert Levas
> On May 2, 2017, 3:58 p.m., Nate Cole wrote: > > I'm assuming UpgradeCatalog changes are coming? Yes... since I am doing this in a feature branch, I thought making really small patches would be ok. - Robert --- This is an

Review Request 58933: AMBARI-20913 : Grafana LLAP overview dashboard showing incorrect metrics

2017-05-02 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58933/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

2017-05-02 Thread Madhuvanthi Radhakrishnan
> On May 2, 2017, 8:07 p.m., Jonathan Hurley wrote: > > What's the state of this review? Seems like it's been dormant for a week... Hi Jonathan, This patch was scraped for 2.5.1 since the changes were made in the HDF mpack instead. But we do want to keep this approach open for discussion for

Re: Review Request 58933: AMBARI-20913 : Grafana LLAP overview dashboard showing incorrect metrics

2017-05-02 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58933/#review173658 --- Ship it! Ship It! - Sid Wagle On May 2, 2017, 9:43 p.m.,

Re: Review Request 58929: Create Database Schema for Improved User Account Management

2017-05-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58929/#review173633 --- ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql

Re: Review Request 58840: AMBARI-20886. Create idempotent Ambari DB Schema SQL script for AzureDB

2017-05-02 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58840/ --- (Updated May 2, 2017, 12:09 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 58886: Smartsense view do not load and shows blank

2017-05-02 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58886/#review173574 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 2, 2017, 8:11

Re: Review Request 58822: Add Log Level Filter to the Log Search config API

2017-05-02 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58822/ --- (Updated May 2, 2017, 8:57 a.m.) Review request for Ambari, Oliver Szabo and

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-05-02 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58797/#review173577 --- Im feeling that is not really the right solution to put the whole

Review Request 58918: AMBARI-20911 Add property in Ranger for including SSL protocols

2017-05-02 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58918/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley,

Review Request 58917: Unable to view visual explain details in Firefox browser

2017-05-02 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58917/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and

Re: Review Request 58917: Unable to view visual explain details in Firefox browser

2017-05-02 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58917/#review173580 --- Ship it! Ship It! - Gaurav Nagar On May 2, 2017, 11:21

Re: Review Request 58929: Create Database Schema for Improved User Account Management

2017-05-02 Thread Nate Cole
> On May 2, 2017, 3:58 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > > Lines 296 (patched) > > > > > > Oracle 12 allows more than 30 characters for db objects; this name

Re: Review Request 58929: Create Database Schema for Improved User Account Management

2017-05-02 Thread Jonathan Hurley
> On May 2, 2017, 3:59 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql > > Lines 299 (patched) > > > > > > try_count ? Or maybe consecutive_failures - Jonathan

Re: Review Request 58823: Trunk patch - Storm Log4J Regex Replacement on Upgrade Fails

2017-05-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58823/#review173641 --- Ship it! Ship It! - Jonathan Hurley On April 27, 2017, 7:14

Re: Review Request 58840: AMBARI-20886. Create idempotent Ambari DB Schema SQL script for AzureDB

2017-05-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58840/#review173647 --- Ship it! Ship It! - Jonathan Hurley On May 2, 2017, 3:24

Re: Review Request 58886: Smartsense view do not load and shows blank

2017-05-02 Thread Nitiraj Rathore
> On May 1, 2017, 7:13 p.m., Gaurav Nagar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > > Lines 1012 (patched) > > > > > > I think, this will be called for each auto

Re: Review Request 58886: Smartsense view do not load and shows blank

2017-05-02 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58886/ --- (Updated May 2, 2017, 8:11 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-05-02 Thread Oliver Szabo
> On May 2, 2017, 2:50 p.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > > Lines 752 (patched) > > > > > > try to use

Re: Review Request 58918: AMBARI-20911 Add property in Ranger for including SSL protocols

2017-05-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58918/#review173585 ---

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-05-02 Thread Vishal Suvagia via Review Board
> On May 2, 2017, 10:10 a.m., Oliver Szabo wrote: > > Im feeling that is not really the right solution to put the whole code into > > a big try catch block. it wont fail with even syntactic errors. Hi Oliver, This is basically done so as to start Ranger irrespective of zookeeper

Re: Review Request 58884: Mask passwords in Request resource responses

2017-05-02 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58884/#review173584 --- Ship it! Ship It! - Attila Magyar On May 1, 2017, 5:30

Re: Review Request 57610: Filter out kerberos rules in exported blueprint

2017-05-02 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57610/#review173600 --- Ship it! Ship It! - Sandor Magyari On April 30, 2017, 4:03

Re: Review Request 58797: AMBARI-20868 : Ranger admin start fails when Ambari Infra is turned off.

2017-05-02 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58797/#review173591 ---

Review Request 58919: AMBARI-20903 RepoVersion parsing error should be more specific

2017-05-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58919/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-20903

Re: Review Request 58919: AMBARI-20903 RepoVersion parsing error should be more specific

2017-05-02 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58919/#review173598 --- Ship it! Ship It! - Tim Thorpe On May 2, 2017, 3:37 p.m.,

Re: Review Request 57610: Filter out kerberos rules in exported blueprint

2017-05-02 Thread Amruta Borkar
> On May 2, 2017, 4:32 p.m., Sandor Magyari wrote: > > Ship It! Thank you Sandor, could you please help me push this to trunk? - Amruta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 58919: AMBARI-20903 RepoVersion parsing error should be more specific

2017-05-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58919/#review173603 --- Ship it! Ship It! - Alejandro Fernandez On May 2, 2017,