date:20171103

Re: Review Request 63535: Send ClusterSummary to install_packages and conf-select exclusion

2017-11-03 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63535/#review190052
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 3, 2017, 4:59 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63535/
> ---
> 
> (Updated Nov. 3, 2017, 4:59 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22360
> https://issues.apache.org/jira/browse/AMBARI-22360
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Pass the ClusterVersionSummary object with install_packages.
> 
> - {{conf-select}} should be called as normal for {{STANDARD}} upgrades and 
> component installations / host installs
> - {{conf-select}} should only be invoked for the services involved in a 
> {{PATCH}}/{{MAINT}} upgrade
> -- The exception here is that hadoop shared components (HDFS, YARN, MapR) can 
> never be {{conf-select}}'d in this case.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  c89e7675a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  b3f91304c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  a20658304f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  b68dc22093 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ClusterVersionSummary.java
>  e9d99208e5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ServiceVersionSummary.java
>  29505c832e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  7944de8e8c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  19019502dd 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 8ba22d263b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  20b12a97e5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  51979f6dee 
>   ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 
> 92dd634cca 
> 
> 
> Diff: https://reviews.apache.org/r/63535/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Unit tests:
> 
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4922, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:46.046s
> [INFO] Finished at: Thu Nov 02 23:22:42 EDT 2017
> [INFO] Final Memory: 85M/1940M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 63542: Add storage support for storing metric definitions using LevelDB

2017-11-03 Thread Aravindan Vijayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63542/#review190051
---


Ship it!




Ship It!

- Aravindan Vijayan


On Nov. 3, 2017, 5:07 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63542/
> ---
> 
> (Updated Nov. 3, 2017, 5:07 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-22365
> https://issues.apache.org/jira/browse/AMBARI-22365
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Metrics Profile information storage requires reliable small volume embedded 
> database that can store and retrieve metric definitions tracked by the 
> Anomaly detection service.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 44bdc1f 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
>  920c50c 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
>  c1ef0d1 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppModule.scala
>  7425a7e 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricDefinitionDBConfiguration.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/MetadataDatasource.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/leveldb/LevelDBDatasource.scala
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/leveldb/LevelDBDataSourceTest.scala
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63542/diff/1/
> 
> 
> Testing
> ---
> 
> Unit test added.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Review Request 63542: Add storage support for storing metric definitions using LevelDB

2017-11-03 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63542/
---

Review request for Ambari and Aravindan Vijayan.


Bugs: AMBARI-22365
https://issues.apache.org/jira/browse/AMBARI-22365


Repository: ambari


Description
---

Metrics Profile information storage requires reliable small volume embedded 
database that can store and retrieve metric definitions tracked by the Anomaly 
detection service.


Diffs
-

  ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 44bdc1f 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
 920c50c 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
 c1ef0d1 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppModule.scala
 7425a7e 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricDefinitionDBConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/MetadataDatasource.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/leveldb/LevelDBDatasource.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/test/scala/org/apache/ambari/metrics/adservice/leveldb/LevelDBDataSourceTest.scala
 PRE-CREATION 


Diff: https://reviews.apache.org/r/63542/diff/1/


Testing
---

Unit test added.


Thanks,

Sid Wagle

Re: Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

2017-11-03 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63537/#review190035
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 3, 2017, 4:10 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63537/
> ---
> 
> (Updated Nov. 3, 2017, 4:10 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22362
> https://issues.apache.org/jira/browse/AMBARI-22362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Hive scripts pass in a parameter called {{HIVE_BIN}}. Hive uses this to 
> determine where {{hdp.version}} and {{HADOOP_HOME}} should be sourced from. 
> In many cases, the binary chosen is:
> 
> {{/usr/bin/hive -> /usr/hdp/current/hive-client}}
> 
> This can lead to problems during an upgrade scenario where {{hive-client}} 
> has not yet moved forward. It should be chosen based on the component being 
> restarted...
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  3c4255975b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9c6db006c8 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  db253d3eed 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_service.py
>  c3bf30c9ab 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/params.py
>  8f2132aa76 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_service.py
>  b5640572b3 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/params_linux.py
>  528760a3b5 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 452c0b61ae 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 
> fd92277c3b 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 3421189f83 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> e497f3358c 
> 
> 
> Diff: https://reviews.apache.org/r/63537/diff/1/
> 
> 
> Testing
> ---
> 
> Manual deploy of Hive to verify Metastore starts using the right component
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 59.066 s
> [INFO] Finished at: 2017-11-03T10:09:14-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

2017-11-03 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63537/#review190031
---


Ship it!




Ship It!

- Nate Cole


On Nov. 3, 2017, 10:10 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63537/
> ---
> 
> (Updated Nov. 3, 2017, 10:10 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-22362
> https://issues.apache.org/jira/browse/AMBARI-22362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Hive scripts pass in a parameter called {{HIVE_BIN}}. Hive uses this to 
> determine where {{hdp.version}} and {{HADOOP_HOME}} should be sourced from. 
> In many cases, the binary chosen is:
> 
> {{/usr/bin/hive -> /usr/hdp/current/hive-client}}
> 
> This can lead to problems during an upgrade scenario where {{hive-client}} 
> has not yet moved forward. It should be chosen based on the component being 
> restarted...
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  3c4255975b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  9c6db006c8 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  db253d3eed 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_service.py
>  c3bf30c9ab 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/params.py
>  8f2132aa76 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/files/startMetastore.sh
>  86541f07e1 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_service.py
>  b5640572b3 
>   
> ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/params_linux.py
>  528760a3b5 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 452c0b61ae 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 
> fd92277c3b 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
> 3421189f83 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> e497f3358c 
> 
> 
> Diff: https://reviews.apache.org/r/63537/diff/1/
> 
> 
> Testing
> ---
> 
> Manual deploy of Hive to verify Metastore starts using the right component
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 59.066 s
> [INFO] Finished at: 2017-11-03T10:09:14-04:00
> [INFO] Final Memory: 21M/619M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 63535: Send ClusterSummary to install_packages and conf-select exclusion

2017-11-03 Thread Nate Cole



> On Nov. 3, 2017, 10:19 a.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
> > Lines 310-312 (patched)
> > 
> >
> > Should we allow this method to just be "the method" to use to get 
> > packages whether or not you're in an upgrade? That way, the dependendant 
> > code can just ask it - it would return all packages in the event that there 
> > is no PATCH/MAINT ...

Wasn't really interested in changing code that is working already when this is 
only for the install_packages flow.


> On Nov. 3, 2017, 10:19 a.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
> > Lines 321-323 (patched)
> > 
> >
> > Just trying to think if this is truly a warning. If iterating over a 
> > cluster where you have non-upgradable services, would this warning get 
> > printed out? It's fine to say that for Service X, there are no packages ... 
> > but should it be a warning?

ok


> On Nov. 3, 2017, 10:19 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
> > Lines 416 (patched)
> > 
> >
> > Should this string be a part of KeyNames, so that its centralized?

ok


> On Nov. 3, 2017, 10:19 a.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
> > Lines 1190 (patched)
> > 
> >
> > Do you need to adjust the stack_packages for BigInsights as well?
> > 
> > Also - when you cherry pick, don't forget that there is a stack 
> > packages under HDP 3.0 in trunk...

To my knowledge, IOP clusters aren't candidates for patching and would never 
get this structure.  So no.

Ok on 3.0


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63535/#review190028
---


On Nov. 2, 2017, 10:59 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63535/
> ---
> 
> (Updated Nov. 2, 2017, 10:59 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22360
> https://issues.apache.org/jira/browse/AMBARI-22360
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Pass the ClusterVersionSummary object with install_packages.
> 
> - {{conf-select}} should be called as normal for {{STANDARD}} upgrades and 
> component installations / host installs
> - {{conf-select}} should only be invoked for the services involved in a 
> {{PATCH}}/{{MAINT}} upgrade
> -- The exception here is that hadoop shared components (HDFS, YARN, MapR) can 
> never be {{conf-select}}'d in this case.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  c89e7675a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  b3f91304c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  a20658304f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  b68dc22093 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ClusterVersionSummary.java
>  e9d99208e5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ServiceVersionSummary.java
>  29505c832e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  7944de8e8c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  19019502dd 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 8ba22d263b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  20b12a97e5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  51979f6dee 
>   ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 
> 92dd634cca 
> 
> 
> Diff: https://reviews.apache.org/r/63535/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Unit tests:
> 
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4922, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
>

Re: Review Request 63535: Send ClusterSummary to install_packages and conf-select exclusion

2017-11-03 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63535/#review190028
---


Fix it, then Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
Lines 310-312 (patched)


Should we allow this method to just be "the method" to use to get packages 
whether or not you're in an upgrade? That way, the dependendant code can just 
ask it - it would return all packages in the event that there is no PATCH/MAINT 
...



ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
Lines 321-323 (patched)


Just trying to think if this is truly a warning. If iterating over a 
cluster where you have non-upgradable services, would this warning get printed 
out? It's fine to say that for Service X, there are no packages ... but should 
it be a warning?



ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
Lines 416 (patched)


Should this string be a part of KeyNames, so that its centralized?



ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
Lines 1190 (patched)


Do you need to adjust the stack_packages for BigInsights as well?

Also - when you cherry pick, don't forget that there is a stack packages 
under HDP 3.0 in trunk...


- Jonathan Hurley


On Nov. 2, 2017, 10:59 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63535/
> ---
> 
> (Updated Nov. 2, 2017, 10:59 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22360
> https://issues.apache.org/jira/browse/AMBARI-22360
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Pass the ClusterVersionSummary object with install_packages.
> 
> - {{conf-select}} should be called as normal for {{STANDARD}} upgrades and 
> component installations / host installs
> - {{conf-select}} should only be invoked for the services involved in a 
> {{PATCH}}/{{MAINT}} upgrade
> -- The exception here is that hadoop shared components (HDFS, YARN, MapR) can 
> never be {{conf-select}}'d in this case.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  c89e7675a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  b3f91304c8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  a20658304f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  b68dc22093 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ClusterVersionSummary.java
>  e9d99208e5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/ServiceVersionSummary.java
>  29505c832e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java
>  7944de8e8c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  19019502dd 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 8ba22d263b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  20b12a97e5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  51979f6dee 
>   ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 
> 92dd634cca 
> 
> 
> Diff: https://reviews.apache.org/r/63535/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Unit tests:
> 
> [INFO] Results:
> [INFO]
> [WARNING] Tests run: 4922, Failures: 0, Errors: 0, Skipped: 34
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:46.046s
> [INFO] Finished at: Thu Nov 02 23:22:42 EDT 2017
> [INFO] Final Memory: 85M/1940M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

2017-11-03 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63537/
---

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-22362
https://issues.apache.org/jira/browse/AMBARI-22362


Repository: ambari


Description
---

The Hive scripts pass in a parameter called {{HIVE_BIN}}. Hive uses this to 
determine where {{hdp.version}} and {{HADOOP_HOME}} should be sourced from. In 
many cases, the binary chosen is:

{{/usr/bin/hive -> /usr/hdp/current/hive-client}}

This can lead to problems during an upgrade scenario where {{hive-client}} has 
not yet moved forward. It should be chosen based on the component being 
restarted...


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/startMetastore.sh
 86541f07e1 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 3c4255975b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 9c6db006c8 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
 db253d3eed 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/files/startMetastore.sh
 86541f07e1 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/hive_service.py
 c3bf30c9ab 
  
ambari-server/src/main/resources/stacks/BigInsights/4.0/services/HIVE/package/scripts/params.py
 8f2132aa76 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/files/startMetastore.sh
 86541f07e1 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/hive_service.py
 b5640572b3 
  
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HIVE/package/scripts/params_linux.py
 528760a3b5 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
452c0b61ae 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 
fd92277c3b 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py 
3421189f83 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
e497f3358c 


Diff: https://reviews.apache.org/r/63537/diff/1/


Testing
---

Manual deploy of Hive to verify Metastore starts using the right component

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 59.066 s
[INFO] Finished at: 2017-11-03T10:09:14-04:00
[INFO] Final Memory: 21M/619M
[INFO] 


Thanks,

Jonathan Hurley

Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default

2017-11-03 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63525/#review190026
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 2, 2017, 9:35 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63525/
> ---
> 
> (Updated Nov. 2, 2017, 9:35 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22357
> https://issues.apache.org/jira/browse/AMBARI-22357
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> change defaults configs + add more proper descriptions to use / setup log 
> search server local dev env quickly (with maven / IDE)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 43878f2 
>   ambari-logsearch/ambari-logsearch-server/.gitignore 07e0389 
>   ambari-logsearch/ambari-logsearch-server/README.md 126f651 
>   ambari-logsearch/ambari-logsearch-server/run.sh 765fe6c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/resources/logsearch.properties
>  db8a0a2 
> 
> 
> Diff: https://reviews.apache.org/r/63525/diff/2/
> 
> 
> Testing
> ---
> 
> done, check with 'mvn clean spring-boot:run' and with IntelliJ as well.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default

2017-11-03 Thread Krisztian Kasa


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63525/#review190025
---


Ship it!




Ship It!

- Krisztian Kasa


On Nov. 2, 2017, 9:35 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63525/
> ---
> 
> (Updated Nov. 2, 2017, 9:35 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22357
> https://issues.apache.org/jira/browse/AMBARI-22357
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> change defaults configs + add more proper descriptions to use / setup log 
> search server local dev env quickly (with maven / IDE)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 43878f2 
>   ambari-logsearch/ambari-logsearch-server/.gitignore 07e0389 
>   ambari-logsearch/ambari-logsearch-server/README.md 126f651 
>   ambari-logsearch/ambari-logsearch-server/run.sh 765fe6c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/resources/logsearch.properties
>  db8a0a2 
> 
> 
> Diff: https://reviews.apache.org/r/63525/diff/2/
> 
> 
> Testing
> ---
> 
> done, check with 'mvn clean spring-boot:run' and with IntelliJ as well.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default

2017-11-03 Thread Krisztian Kasa


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63525/#review190024
---


Ship it!




Ship It!

- Krisztian Kasa


On Nov. 2, 2017, 9:35 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63525/
> ---
> 
> (Updated Nov. 2, 2017, 9:35 p.m.)
> 
> 
> Review request for Ambari, Krisztian Kasa and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22357
> https://issues.apache.org/jira/browse/AMBARI-22357
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> change defaults configs + add more proper descriptions to use / setup log 
> search server local dev env quickly (with maven / IDE)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 43878f2 
>   ambari-logsearch/ambari-logsearch-server/.gitignore 07e0389 
>   ambari-logsearch/ambari-logsearch-server/README.md 126f651 
>   ambari-logsearch/ambari-logsearch-server/run.sh 765fe6c 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/resources/logsearch.properties
>  db8a0a2 
> 
> 
> Diff: https://reviews.apache.org/r/63525/diff/2/
> 
> 
> Testing
> ---
> 
> done, check with 'mvn clean spring-boot:run' and with IntelliJ as well.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63535: Send ClusterSummary to install_packages and conf-select exclusion

Re: Review Request 63542: Add storage support for storing metric definitions using LevelDB

Review Request 63542: Add storage support for storing metric definitions using LevelDB

Re: Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

Re: Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

Re: Review Request 63535: Send ClusterSummary to install_packages and conf-select exclusion

Re: Review Request 63535: Send ClusterSummary to install_packages and conf-select exclusion

Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default

Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default

Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default

11 matches

Site Navigation

Mail list logo

Footer information