Re: Review Request 44487: AMBARI-15327 Combo Search: Query for multiple facets and display label instead of value in search box

2016-03-08 Thread Zhe (Joe) Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44487/
---

(Updated March 9, 2016, 2:20 a.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi 
Wang, and Yusaku Sako.


Summary (updated)
-

AMBARI-15327 Combo Search: Query for multiple  facets and 
display label instead of value in search box


Bugs: AMBARI-15327
https://issues.apache.org/jira/browse/AMBARI-15327


Repository: ambari


Description
---

Currently we allow only one component state facet but  can be 
supported using .in(). Add query support for multiple  facet.
Display label instead of value in search box


Diffs
-

  ambari-web/app/controllers/main/host.js b473c59 
  ambari-web/app/controllers/main/host/combo_search_box.js 9fa6851 
  ambari-web/app/mixins/common/table_server_view_mixin.js eca17d6 
  ambari-web/app/views/main/host/combo_search_box.js 17c0a6d 
  ambari-web/test/controllers/main/host_test.js 06a4813 

Diff: https://reviews.apache.org/r/44487/diff/


Testing
---

Modified unit test. Local ambari-web test passed.
24565 tests complete (21 seconds)
145 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 44492: AMBARI-15330. Bubble up errors during RU/EU

2016-03-08 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44492/
---

(Updated March 9, 2016, 4:46 a.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
Hurley, Nate Cole, and Sid Wagle.


Summary (updated)
-

AMBARI-15330. Bubble up errors during RU/EU


Bugs: AMBARI-15330
https://issues.apache.org/jira/browse/AMBARI-15330


Repository: ambari


Description
---

During RU/EU, need a way to bubble up an error of the current item that failed. 
This is useful to quickly get a human-readable error that others UIs can 
quickly retrieve.
It can print a human-readable error, plus stdout and stderr.
This would become part of the upgrade endpoint. e.g,
api/v1/clusters/$name/upgrade_summary/$request_id

```
{

cluster_name: "c1",
request_id: 1,
fail_reason: "Failed calling RESTART ZOOKEEPER/ZOOKEEPER_SERVER on host 
c6401.ambari.apache.org",

// Notice that the rest are inherited from the failed task if it exists.
attempt_cnt: 1,
command: "CUSTOM_COMMAND",
command_detail: "RESTART ZOOKEEPER/ZOOKEEPER_SERVER",
custom_command_name: "RESTART",
end_time: -1,
error_log: "/var/lib/ambari-agent/data/errors-1234.txt",
exit_code: 1,
host_name: "c6401.ambari.apache.org",
id: 1234,
output_log: "/var/lib/ambari-agent/data/output-1234.txt",
role: "ZOOKEEPER_SERVER",
stage_id: 1,
start_time: 123456789,
status: "HOLDING_FAILED",
stdout: "",
stderr: ""
}
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java
 52523c7 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 e7bbec4 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 4954a96 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeSummaryService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 dde934d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java
 510d6fb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummary.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 fbbc7c8 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
 fee3200 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
 a12b204 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
8213a78 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/44492/diff/


Testing
---

Verified on RU and EU by introducing a failure.
Waiting for unit test results.


Thanks,

Alejandro Fernandez

Re: Review Request 44492: [DRAFT] AMBARI-15330. Bubble up errors during RU/EU

2016-03-08 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44492/
---

(Updated March 9, 2016, 4:45 a.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
Hurley, Nate Cole, and Sid Wagle.


Bugs: AMBARI-15330
https://issues.apache.org/jira/browse/AMBARI-15330


Repository: ambari


Description
---

During RU/EU, need a way to bubble up an error of the current item that failed. 
This is useful to quickly get a human-readable error that others UIs can 
quickly retrieve.
It can print a human-readable error, plus stdout and stderr.
This would become part of the upgrade endpoint. e.g,
api/v1/clusters/$name/upgrade_summary/$request_id

```
{

cluster_name: "c1",
request_id: 1,
fail_reason: "Failed calling RESTART ZOOKEEPER/ZOOKEEPER_SERVER on host 
c6401.ambari.apache.org",

// Notice that the rest are inherited from the failed task if it exists.
attempt_cnt: 1,
command: "CUSTOM_COMMAND",
command_detail: "RESTART ZOOKEEPER/ZOOKEEPER_SERVER",
custom_command_name: "RESTART",
end_time: -1,
error_log: "/var/lib/ambari-agent/data/errors-1234.txt",
exit_code: 1,
host_name: "c6401.ambari.apache.org",
id: 1234,
output_log: "/var/lib/ambari-agent/data/output-1234.txt",
role: "ZOOKEEPER_SERVER",
stage_id: 1,
start_time: 123456789,
status: "HOLDING_FAILED",
stdout: "",
stderr: ""
}
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java
 52523c7 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 e7bbec4 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 4954a96 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeSummaryService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 dde934d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskResourceProvider.java
 510d6fb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummary.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 fbbc7c8 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
 fee3200 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
 a12b204 
  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
8213a78 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/44492/diff/


Testing (updated)
---

Verified on RU and EU by introducing a failure.
Waiting for unit test results.


Thanks,

Alejandro Fernandez

Re: Review Request 44272: Install & Manage Zeppelin with Ambari

2016-03-08 Thread Renjith Kamath 


> On March 9, 2016, 12:46 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml,
> >  line 84
> > 
> >
> > Lets remove epel-release.

removed in Rev 3


> On March 9, 2016, 12:46 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml,
> >  line 102
> > 
> >
> > Should this be zeppelin-env? zeppelin-ambari-config is no longer a 
> > config type

removed in Rev 4


- Renjith


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122642
---


On March 9, 2016, 5:21 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> ---
> 
> (Updated March 9, 2016, 5:21 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml
>  PRE-CREATION 
>   contrib/views/pom.xml 627552a 
>   contrib/views/zeppelin/pom.xml PRE-CREATION 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
>  PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44272/diff/
> 
> 
> Testing
> ---
> 
> - manual testing in vm
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 44272: Install & Manage Zeppelin with Ambari

2016-03-08 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44272/#review122642
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml
 (line 84)


Lets remove epel-release.



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/metainfo.xml
 (line 102)


Should this be zeppelin-env? zeppelin-ambari-config is no longer a config 
type



ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5.0.0/package/scripts/alert_check_zeppelin.py
 (line 1)


Thanks.


- Sumit Mohanty


On March 8, 2016, 7:18 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44272/
> ---
> 
> (Updated March 8, 2016, 7:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15265
> https://issues.apache.org/jira/browse/AMBARI-15265
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - add service defnition for Apache Zeppelin
> - add support for Zeppelin view in Ambari
> - add alert config
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/alerts.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/alert_check_zeppelin.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/status_params.py
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ZEPPELIN/metainfo.xml
>  PRE-CREATION 
>   contrib/views/pom.xml 627552a 
>   contrib/views/zeppelin/pom.xml PRE-CREATION 
>   
> contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java
>  PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml PRE-CREATION 
>   contrib/views/zeppelin/src/main/resources/view.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44272/diff/
> 
> 
> Testing
> ---
> 
> - manual testing in vm
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 44528: Align PXF Alert description with other services

2016-03-08 Thread bhuvnesh chaudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44528/#review122635
---




ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json (line 7)


This host-level alert is triggered if the PXF process cannot be established 
to be up and listening on the network.


- bhuvnesh chaudhary


On March 8, 2016, 9:46 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44528/
> ---
> 
> (Updated March 8, 2016, 9:46 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15339
> https://issues.apache.org/jira/browse/AMBARI-15339
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Align PXF Alert description with other services
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
> d32fc97 
> 
> Diff: https://reviews.apache.org/r/44528/diff/
> 
> 
> Testing
> ---
> 
> Manually Done
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 44528: Align PXF Alert description with other services

2016-03-08 Thread jun aoki 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44528/
---

(Updated March 8, 2016, 11:56 p.m.)


Review request for Ambari.


Bugs: AMBARI-15339
https://issues.apache.org/jira/browse/AMBARI-15339


Repository: ambari


Description
---

Align PXF Alert description with other services


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/PXF/3.0.0/alerts.json 
d32fc97 

Diff: https://reviews.apache.org/r/44528/diff/


Testing
---

Manually Done


Thanks,

jun aoki

Re: Review Request 42032: [AMBARI-12916] Make server hostname configurable

2016-03-08 Thread Greg Hill 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42032/
---

(Updated March 8, 2016, 4:52 p.m.)


Review request for Ambari.


Changes
---

Added logging.  Fixed boolean vs string issue.


Bugs: AMBARI-12916
https://issues.apache.org/jira/browse/AMBARI-12916


Repository: ambari


Description
---

This lets you configure the hostname that the Ambari server passes to the views 
and agent so you can specify it differently from the system hostname.  This is 
useful in cases where you want to use a fqdn for API access but a local 
hostname for local cluster communication.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 17fb42d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 0b26f61 

Diff: https://reviews.apache.org/r/42032/diff/


Testing
---

Honestly, not much.  There weren't any existing unit tests for the code I 
modified and I'm not a Java developer so I didn't really know where to start 
with creating them.  It's a pretty simple change and doesn't break any existing 
tests, but I'm happy to do some more testing if someone can provide some 
direction.


Thanks,

Greg Hill

Re: Review Request 44265: Basic Operational Audit Logging

2016-03-08 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44265/#review122532
---



This patch is way too big. It should have been split into multiple patches.


ambari-server/pom.xml (lines 1269 - 1273)


It seems that this is overkill to just create and carry around a timestamp 
value.  

Also, looking at the information for Joda Time 
(http://www.joda.org/joda-time/) a highlighed portion of it reads:

```
Note that from Java SE 8 onwards, users are asked to migrate to java.time 
(JSR-310) - a core part of the JDK which replaces this project.
```

If we add this now, we probably will forget to get rid of in when we no 
longer support JDK 1.7.  

Do we really need this?



ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
 (lines 486 - 490)


I don't see the need to move this code from inside the `if` clause.  Was 
this really necessary?



ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
 (line 138)


Since you already have the HttpHeaders, wouldn't it be quicker to add a 
method to `RequestUtils` to get the remote address from that structure than to 
get the request from the context?



ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
 (line 129)


Is this intended? Maybe it should be documented for clarity.

It looks like you are loosing information that should be logged:
- The initial request, which may be _lost_ if an exception isn't thrown. 
- all but the last _internal_ request and its result if more than one 
_request_ is found in the body of the original request



ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/DefaultEventCreator.java
 (lines 49 - 57)


This is interesting syntax. Why not use a constructor or initialized the 
same way other Creator classes do it:

```
requestTypes = ImmutableSet.builder().add(Request.Type.POST, 
Request.Type.DELETE, ...).build();
```

Or maybe use

```
requestTypes = 
Collections.unmodifiableSet(EnumSet.complementOf(EnumSet.of(Request.Type.GET));
```



ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationFilter.java
 (line 42)


JavaDoc



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java
 (line 285)


This is incorrect.  The ResourceType id is not the cluster id.  You need to 
use 

```
ClusterDAO.findByResourceID(privilegeEntity.getResource().getId())
```



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AuthorizationHelper.java
 (line 295)


At least a message should be logged so we aren't confused later.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/AbstractServerAction.java
 (line 199)


Seems like an AuditLogger factory would be better than this... Then it 
could be reused rahter than trying to pass around the injector.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
 (line 22)


This should probably be reverted.. its the only change in the file..



ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
(line 27)


Javadoc



ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java 
(line 32)


Javadoc


- Robert Levas


On March 8, 2016, 8:36 a.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44265/
> ---
> 
> (Updated March 8, 2016, 8:36 a.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, Sandor 
> Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15241
> https://issues.apache.org/jira/browse/AMBARI-15241
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Entry points for logging events:
> - Login and logout: AmbariAuthenticationFilter, AmbariAuthorizationFilter, 
> LogoutService
> - Operation and tasks: ActionDBAAccessorImpl
> -

Re: Review Request 44413: AMBARI-15308 UI: ability to perform bulk add host components

2016-03-08 Thread Zhe (Joe) Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44413/
---

(Updated March 8, 2016, 6:43 p.m.)


Review request for Ambari, Jaimin Jetly, Matt, Richard Zang, Srimanth Gunturi, 
Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15308
https://issues.apache.org/jira/browse/AMBARI-15308


Repository: ambari


Description
---

On Hosts page, provide ability to add host components in bulk.
These bulk operations are useful when working in large clusters where you need 
to move components around in the cluster (add 50 RegionServers on a set of 
hosts, remove 50 RegionServers from a different set of hosts).


Diffs (updated)
-

  ambari-web/app/views/main/host/hosts_table_menu_view.js 0d119f7 

Diff: https://reviews.apache.org/r/44413/diff/


Testing
---

Added unit test. Local ambari-web test passed.
24557 tests complete (21 seconds)
146 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 44509: Blueprints: NullPointerException when unncessary config types found with %HOSTGROUP% tags

2016-03-08 Thread Sandor Magyari 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44509/#review122512
---


Ship it!




Ship It!

- Sandor Magyari


On March 8, 2016, 1:42 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44509/
> ---
> 
> (Updated March 8, 2016, 1:42 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Oliver Szabo, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-15336
> https://issues.apache.org/jira/browse/AMBARI-15336
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This issue was originally addressed by 
> https://issues.apache.org/jira/browse/AMBARI-14745 however a corner case is 
> not being handled in that fix.
> 
> If a Blueprint is being used where configurations are specified solely within 
> host groups than the orphaned configuration types were missed from removal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java
>  a995a3b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java
>  3ed8ed5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  156580a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  69c1935 
> 
> Diff: https://reviews.apache.org/r/44509/diff/
> 
> 
> Testing
> ---
> 
> 1.Unitest have been modified to cover this corner case as well.
> 
> 2. Manual testing with Blueprints having configurations only in host groups.
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 44509: Blueprints: NullPointerException when unncessary config types found with %HOSTGROUP% tags

2016-03-08 Thread Daniel Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44509/#review122515
---


Ship it!




Ship It!

- Daniel Gergely


On márc. 8, 2016, 1:42 du, Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44509/
> ---
> 
> (Updated márc. 8, 2016, 1:42 du)
> 
> 
> Review request for Ambari, Daniel Gergely, Oliver Szabo, and Sandor Magyari.
> 
> 
> Bugs: AMBARI-15336
> https://issues.apache.org/jira/browse/AMBARI-15336
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This issue was originally addressed by 
> https://issues.apache.org/jira/browse/AMBARI-14745 however a corner case is 
> not being handled in that fix.
> 
> If a Blueprint is being used where configurations are specified solely within 
> host groups than the orphaned configuration types were missed from removal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java
>  a995a3b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java
>  3ed8ed5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
>  156580a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
>  69c1935 
> 
> Diff: https://reviews.apache.org/r/44509/diff/
> 
> 
> Testing
> ---
> 
> 1.Unitest have been modified to cover this corner case as well.
> 
> 2. Manual testing with Blueprints having configurations only in host groups.
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Review Request 44509: Blueprints: NullPointerException when unncessary config types found with %HOSTGROUP% tags

2016-03-08 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44509/
---

Review request for Ambari, Daniel Gergely, Oliver Szabo, and Sandor Magyari.


Bugs: AMBARI-15336
https://issues.apache.org/jira/browse/AMBARI-15336


Repository: ambari


Description
---

This issue was originally addressed by 
https://issues.apache.org/jira/browse/AMBARI-14745 however a corner case is not 
being handled in that fix.

If a Blueprint is being used where configurations are specified solely within 
host groups than the orphaned configuration types were missed from removal.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java
 a995a3b 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java
 3ed8ed5 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
 156580a 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
 69c1935 

Diff: https://reviews.apache.org/r/44509/diff/


Testing
---

1.Unitest have been modified to cover this corner case as well.

2. Manual testing with Blueprints having configurations only in host groups.


Thanks,

Sebastian Toader