Review Request 46614: [RU] Hbase is losing table access permissions during upgrade.

2016-04-24 Thread Dmitro Lisnichenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46614/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, and Velmurugan Periasamy.


Bugs: AMBARI-16084
https://issues.apache.org/jira/browse/AMBARI-16084


Repository: ambari


Description
---

So here's where we are:

- https://reviews.apache.org/r/45890/diff/2#index_header removed hard-coded 
python code which was trying to figure out which coprocessor to use. With these 
values gone, it's now up to Ambari to set the _right_ value in the 
configurations.

- However, after removing the above code, we never change the ranger 
configurations to reflect the proper value

- To fix this, we need to fix the values on Ambari upgrade. When upgrading 
Ambari from 2.0, we'll need to do the following:
-- If Ranger is disabled; do nothing
-- If Ranger is enabled and the cluster's current stack is HDP 2.2, then set 
the master/region coprocessors to
{code}
hbase_coprocessor_master_classes = 
"com.xasecure.authorization.hbase.XaSecureAuthorizationCoprocessor"
hbase_coprocessor_regionserver_classes = 
"com.xasecure.authorization.hbase.XaSecureAuthorizationCoprocessor"
hbase_coprocessor_region_classes = 
"org.apache.hadoop.hbase.security.token.TokenProvider,org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint,com.xasecure.authorization.hbase.XaSecureAuthorizationCoprocessor"
{code}
-- If Ranger is enabled and the cluster's current stack is HDP 2.3, then set 
the master/region coprocessors to
{code}
hbase_coprocessor_master_classes = 
"org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor "
hbase_coprocessor_regionserver_classes = 
"org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor"
hbase_coprocessor_region_classes = 
"org.apache.hadoop.hbase.security.token.TokenProvider,org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint,org.apache.ranger.authorization.hbase.RangerAuthorizationCoprocessor"
{code}

Now HDP stack upgrades will work since we look for 
{{XaSecureAuthorizationCoprocessor}} and change it to 
{{RangerAuthorizationCoprocessor}} as needed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 b7665ce 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
 31a3ce5 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
 4302349 

Diff: https://reviews.apache.org/r/46614/diff/


Testing
---

unit tests in progress

live cluster check in progress


Thanks,

Dmitro Lisnichenko



Re: Review Request 46271: Migrate instance specific data from one version to another.

2016-04-24 Thread Ashwin Rajeev

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46271/#review130300
---


Ship it!




Ship It!

- Ashwin Rajeev


On April 20, 2016, 7:47 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46271/
> ---
> 
> (Updated April 20, 2016, 7:47 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-15919
> https://issues.apache.org/jira/browse/AMBARI-15919
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added ability to migrate data using rest API.
> Added data-migrator-class, data-version tags in view.xml . View needs to 
> implement ViewDataMigrator class that contains logic to migrate data from 
> older version.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewDataMigrationService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java
>  1eea8db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrivilegeDAO.java
>  772d538 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  2555f93 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationContextImpl.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 7379f37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
>  728f620 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewDataMigrationServiceTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java
>  c8c15da 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewDataMigrationContextImplTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
>  14e5d3c 
>   ambari-views/examples/README.md 650f650 
>   ambari-views/examples/calculator-view/pom.xml d5e0e8e 
>   ambari-views/examples/cluster-view/pom.xml 99582a6 
>   ambari-views/examples/favorite-view/pom.xml ba196f5 
>   ambari-views/examples/hello-servlet-view/pom.xml ed6fc25 
>   ambari-views/examples/hello-spring-view/pom.xml 3475ef4 
>   ambari-views/examples/helloworld-view/pom.xml aa89778 
>   ambari-views/examples/phone-list-upgrade-view/docs/index.md PRE-CREATION 
>   ambari-views/examples/phone-list-upgrade-view/pom.xml PRE-CREATION 
>   
> ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/DataMigrator.java
>  PRE-CREATION 
>   
> ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/PhoneListServlet.java
>  PRE-CREATION 
>   
> ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/PhoneUser.java
>  PRE-CREATION 
>   
> ambari-views/examples/phone-list-upgrade-view/src/main/resources/WEB-INF/web.xml
>  PRE-CREATION 
>   ambari-views/examples/phone-list-upgrade-view/src/main/resources/view.xml 
> PRE-CREATION 
>   ambari-views/examples/phone-list-view/pom.xml ead9095 
>   ambari-views/examples/pom.xml de55ded 
>   ambari-views/examples/property-validator-view/pom.xml 045a277 
>   ambari-views/examples/property-view/pom.xml ad4630b 
>   ambari-views/examples/restricted-view/pom.xml f7fa3d6 
>   ambari-views/examples/simple-view/pom.xml 015f192 
>   ambari-views/examples/weather-view/pom.xml a018258 
>   
> ambari-views/src/main/java/org/apache/ambari/view/migration/EntityConverter.java
>  PRE-CREATION 
>   
> ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrationContext.java
>  PRE-CREATION 
>   
> ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrationException.java
>  PRE-CREATION 
>   
> ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrator.java
>  PRE-CREATION 
>   ambari-views/src/main/java/org/apache/ambari/view/validation/Validator.java 
> ee029a8 
>   ambari-views/src/main/resources/view.xsd c3ad711 
>   pom.xml f540099 
> 
> Diff: https://reviews.apache.org/r/46271/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>



Re: Review Request 46602: Delete Service: Deleting Hive fails with 500 error

2016-04-24 Thread Swapan Shridhar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46602/#review130297
---


Ship it!




Ship It!

- Swapan Shridhar


On April 24, 2016, 4:40 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46602/
> ---
> 
> (Updated April 24, 2016, 4:40 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, Swapan Shridhar, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-16080
> https://issues.apache.org/jira/browse/AMBARI-16080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The failure is due to components in STARTED state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  93e7222 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
>  bba5ce1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
>  0adac80 
> 
> Diff: https://reviews.apache.org/r/46602/diff/
> 
> 
> Testing
> ---
> 
> New unit tests and ran related ones.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>



Re: Review Request 46602: Delete Service: Deleting Hive fails with 500 error

2016-04-24 Thread Sid Wagle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46602/#review130292
---


Ship it!




Ship It!

- Sid Wagle


On April 24, 2016, 4:40 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46602/
> ---
> 
> (Updated April 24, 2016, 4:40 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, Swapan Shridhar, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-16080
> https://issues.apache.org/jira/browse/AMBARI-16080
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The failure is due to components in STARTED state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
>  93e7222 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
>  bba5ce1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
>  0adac80 
> 
> Diff: https://reviews.apache.org/r/46602/diff/
> 
> 
> Testing
> ---
> 
> New unit tests and ran related ones.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>