Review Request 51132: testSerializeResourcesAsArray.java cannot pass

2016-08-15 Thread alice alice 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51132/
---

Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-17910
https://issues.apache.org/jira/browse/AMBARI-17910


Repository: ambari


Description
---

testSerializeResourcesAsArray.java cannot pass because the input was not correct


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java
 2ea45dc 

Diff: https://reviews.apache.org/r/51132/diff/


Testing
---

done it


Thanks,

alice alice

Review Request 51131: HttpPropertyProviderTest.java cannot pass

2016-08-15 Thread alice alice 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51131/
---

Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-17850
https://issues.apache.org/jira/browse/AMBARI-17850


Repository: ambari


Description
---

HttpPropertyProvider Test.java cannot pass because one https's port not 
corrent.the port of https is 8090


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HttpPropertyProviderTest.java
 154d125 

Diff: https://reviews.apache.org/r/51131/diff/


Testing
---


Thanks,

alice alice

Re: Review Request 49944: optimize log description of ambari agent stop

2016-08-15 Thread wang yaoxin 


> On 八月 12, 2016, 6:09 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/python/ambari_agent/main.py, line 282
> > 
> >
> > Extra space right after "stopped"

Thank you?
I hava attached a new patch AMBARI-17668-1.patch ,can you help me ship it!


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49944/#review145646
---


On 八月 4, 2016, 1:17 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49944/
> ---
> 
> (Updated 八月 4, 2016, 1:17 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid 
> Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17668
> https://issues.apache.org/jira/browse/AMBARI-17668
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> excute ambari agent ?going to execute kill -9?but none output log
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/main.py 1fc445e 
> 
> Diff: https://reviews.apache.org/r/49944/diff/
> 
> 
> Testing
> ---
> 
> done
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>

Re: Review Request 51128: Create Documentation Around All Options In ambari.properties

2016-08-15 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51128/#review145835
---




ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (lines 417 - 422)


An example of a configuration property with the new Markdown annotation.



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (lines 1822 - 1831)


For properties which might need more complex markdown created, we have a 
custom annotation just for configuration properties which contain things like 
recommended values based on cluster size.



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (line 4644)


The main() method was changed to take a template MD file and create an MD 
file which can be checked into source (index.md).

I thought about using Apache Velocity for this, but unfortunately, Markdown 
and velocity have syntax compatibility problems; it was easier to just do a 
simple string replace on a token.


- Jonathan Hurley


On Aug. 16, 2016, 12:01 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51128/
> ---
> 
> (Updated Aug. 16, 2016, 12:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and 
> Robert Nettleton.
> 
> 
> Bugs: AMBARI-18089
> https://issues.apache.org/jira/browse/AMBARI-18089
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide documentation, in markdown format, around all of Ambari's 
> configuration options. Additionally, provide a way to easily provide metadata 
> for properties that need to scale based on things like cluster size. There is 
> currently sparse to no documentation on many of these properties. For every 
> property, we need to consider things like cluster size.
> 
> The Configuration class was extended with a main() method which now takes an 
> `output=foo.md` argument to generate an MD file.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/annotations/Markdown.java 
> 0f7748e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  2bebf95 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  9c27e57 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/index_template.md
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  46f6ce5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
>  722e6f1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  22f4afa 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java
>  2702fdf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/LdapPerformanceTest.java
>  dbf28be 
> 
> Diff: https://reviews.apache.org/r/51128/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 51128: Create Documentation Around All Options In ambari.properties

2016-08-15 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51128/
---

Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas, and 
Robert Nettleton.


Bugs: AMBARI-18089
https://issues.apache.org/jira/browse/AMBARI-18089


Repository: ambari


Description
---

Provide documentation, in markdown format, around all of Ambari's configuration 
options. Additionally, provide a way to easily provide metadata for properties 
that need to scale based on things like cluster size. There is currently sparse 
to no documentation on many of these properties. For every property, we need to 
consider things like cluster size.

The Configuration class was extended with a main() method which now takes an 
`output=foo.md` argument to generate an MD file.


Diffs
-

  ambari-server/docs/configuration/index.md PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/annotations/Markdown.java 
0f7748e 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 2bebf95 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 9c27e57 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/index_template.md
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 46f6ce5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
 722e6f1 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 22f4afa 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java
 2702fdf 
  
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/LdapPerformanceTest.java
 dbf28be 

Diff: https://reviews.apache.org/r/51128/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Re: Review Request 51123: AMBARI-18152: 'ambari-server --help' not working

2016-08-15 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51123/
---

(Updated Aug. 15, 2016, 7:29 p.m.)


Review request for Ambari, Andrew Onischuk and Sumit Mohanty.


Changes
---

Changed repr(e) to str(e)


Bugs: AMBARI-18152
https://issues.apache.org/jira/browse/AMBARI-18152


Repository: ambari


Description
---

** Issue: **
AMBARI-15300 accesses *properties* in ServerConfigDefaults::__init__() in 
serverConfiguration.py even if get_ambari_properties() fails, resulting in an 
exception, since *properties* is *-1* on failure.

File "/usr/lib/python2.6/site-packages/ambari_server/serverConfiguration.py", 
line 349, in __init__
self.PID_DIR = properties.get_property(PID_DIR_PROPERTY)
AttributeError: 'int' object has no attribute 'get_property'


** Fix: **
In get_ambari_properties():
1. Check if ROOT is available and then use it since this was the primary issue 
(key not found).
2. Read the properties file in its own block of code so that we still have 
access to the properties even if we are not able to replace $ROOT
3. In case of failure reading the properties file, use default properties in 
the caller.


Diffs (updated)
-

  ambari-server/sbin/ambari-server 046ff4b3d40cdfde0d5aee52040d6996aefba08b 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py 
07159c3613fe5acdf8c3a65190a82b4287f2824b 

Diff: https://reviews.apache.org/r/51123/diff/


Testing
---

** 1. mvn test -DskipSurefireTests **

--
Ran 267 tests in 6.698s

OK
--
Total run:1120
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:09.411s
[INFO] Finished at: Mon Aug 15 17:48:50 PDT 2016
[INFO] Final Memory: 56M/835M
[INFO] 

** 2. Manual testing **
Deployed a VM with the latest build from **trunk** and replaced  
*serverConfiguration.py* with the one from the local build. Verified that 
*ambari-server.py --help* works as expected:

[root@c6401 /]# ambari-server.py --help
Usage: ambari-server.py [options] action [stack_id os]

Options:
  -h, --helpshow this help message and exit
  -f INIT_SCRIPT_FILE, --init-script-file=INIT_SCRIPT_FILE
File with setup script
  -r DROP_SCRIPT_FILE, --drop-script-file=DROP_SCRIPT_FILE
File with drop script
  -u UPGRADE_SCRIPT_FILE, --upgrade-script-file=UPGRADE_SCRIPT_FILE
File with upgrade script
  -t UPGRADE_STACK_SCRIPT_FILE, 
--upgrade-stack-script-file=UPGRADE_STACK_SCRIPT_FILE
File with stack upgrade script
  -j JAVA_HOME, --java-home=JAVA_HOME
Use specified java_home.  Must be valid on all hosts
  -v, --verbose Print verbose status messages
  -s, --silent  Silently accepts default prompt values
  -g, --debug   Start ambari-server in debug mode
  -y, --suspend-start   Freeze ambari-server Java process at startup in debug
mode
  --all LDAP sync all option.  Synchronize all LDAP users and
groups.
  --existingLDAP sync existing option.  Synchronize existing
Ambari users and groups only.
  --users=LDAP_SYNC_USERS
LDAP sync users option. Specifies the path to a CSV
file of user names to be synchronized.
  --groups=LDAP_SYNC_GROUPS
LDAP sync groups option.  Specifies the path to a CSV
file of group names to be synchronized.
  --database=DBMS   Database to use
embedded|oracle|mysql|mssql|postgres|sqlanywhere
  --databasehost=DATABASE_HOST
Hostname of database server
  --databaseport=DATABASE_PORT
Database port
  --databasename=DATABASE_NAME
Database/Service name or ServiceID
  --postgresschema=POSTGRES_SCHEMA
Postgres database schema name
  --databaseusername=DATABASE_USERNAME
Database user login
  --databasepassword=DATABASE_PASSWORD
Database user password
  --sidorsname=SID_OR_SNAME
Oracle database identifier type, Service ID/Service
Name sid|sname
  --sqla-server-name=SQLA_SERVER_NAME
SQL Anywhere server name
  --jdbc-driver=JDBC_DRIVER
Specifies the path to the JDBC driver JAR file or
archive with all

Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS

2016-08-15 Thread Alejandro Fernandez 


> On Aug. 16, 2016, 12:54 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py,
> >  line 381
> > 
> >
> > Will this call need kinit or sudo ever?

Will test in a Kerberized cluster.


> On Aug. 16, 2016, 12:54 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py,
> >  line 370
> > 
> >
> > How do users prevent this? Is it expected that at least on Oozie server 
> > host has atlas installed?

The hive hook lives in /usr/hdp/$version/atlas/hook/hive but the dependency is 
installed via an RPM like 
atlas-metadata_2_5_0_0_1203-hive-plugin-0.7.0.2.5.0.0-1203 which is actually 
brought in by Hive. On a host that only has Oozie server, I need to check that 
it is installed.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51121/#review145821
---


On Aug. 16, 2016, 12:40 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51121/
> ---
> 
> (Updated Aug. 16, 2016, 12:40 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-18151
> https://issues.apache.org/jira/browse/AMBARI-18151
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Whenever Oozie submits Hive actions, they fail and the application logs show 
> "Internal Error: 
> java.lang.ClassNotFoundException(org.apache.atlas.hive.hook.HiveHook"
> 
> This is because whenever Atlas is installed, the Hive Hook (which is 
> installed via the Oozie RPM too, in /usr/$stack/$version/atlas/hook/hive/) 
> needs to be copied to the Oozie Share lib in HDFS (e.g., 
> hdfs:///user/oozie/share/lib/lib_$timestamp/hive)
> 
> Further, need to save atlas-application.properties used for Hive in 
> /etc/oozie/conf/action-conf/hive
> 
> Lastly, remove the atlas.rest.address property from hive-site.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  dd3a692 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  e330cb5 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  db048bb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/hive-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51121/diff/
> 
> 
> Testing
> ---
> 
> Verified on a live cluster with HDP 2.5 and Oozie, Hive, Atlas
> 
> Python unit tests passed,
> 
> OK
> --
> Total run:1034
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 51123: AMBARI-18152: 'ambari-server --help' not working

2016-08-15 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51123/#review145828
---


Fix it, then Ship it!




Fix it then Ship It


ambari-server/src/main/python/ambari_server/serverConfiguration.py (line 236)


just use "except Exception, e:"
use str(e) instead of repr(e)



ambari-server/src/main/python/ambari_server/serverConfiguration.py (line 254)


Use str(e)


- Alejandro Fernandez


On Aug. 16, 2016, 12:54 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51123/
> ---
> 
> (Updated Aug. 16, 2016, 12:54 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18152
> https://issues.apache.org/jira/browse/AMBARI-18152
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ** Issue: **
> AMBARI-15300 accesses *properties* in ServerConfigDefaults::__init__() in 
> serverConfiguration.py even if get_ambari_properties() fails, resulting in an 
> exception, since *properties* is *-1* on failure.
> 
> File "/usr/lib/python2.6/site-packages/ambari_server/serverConfiguration.py", 
> line 349, in __init__
> self.PID_DIR = properties.get_property(PID_DIR_PROPERTY)
> AttributeError: 'int' object has no attribute 'get_property'
> 
> 
> ** Fix: **
> In get_ambari_properties():
> 1. Check if ROOT is available and then use it since this was the primary 
> issue (key not found).
> 2. Read the properties file in its own block of code so that we still have 
> access to the properties even if we are not able to replace $ROOT
> 3. In case of failure reading the properties file, use default properties in 
> the caller.
> 
> 
> Diffs
> -
> 
>   ambari-server/sbin/ambari-server 046ff4b3d40cdfde0d5aee52040d6996aefba08b 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 
> 07159c3613fe5acdf8c3a65190a82b4287f2824b 
> 
> Diff: https://reviews.apache.org/r/51123/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn test -DskipSurefireTests **
> 
> --
> Ran 267 tests in 6.698s
> 
> OK
> --
> Total run:1120
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:09.411s
> [INFO] Finished at: Mon Aug 15 17:48:50 PDT 2016
> [INFO] Final Memory: 56M/835M
> [INFO] 
> 
> 
> ** 2. Manual testing **
> Deployed a VM with the latest build from **trunk** and replaced  
> *serverConfiguration.py* with the one from the local build. Verified that 
> *ambari-server.py --help* works as expected:
> 
> [root@c6401 /]# ambari-server.py --help
> Usage: ambari-server.py [options] action [stack_id os]
> 
> Options:
>   -h, --helpshow this help message and exit
>   -f INIT_SCRIPT_FILE, --init-script-file=INIT_SCRIPT_FILE
> File with setup script
>   -r DROP_SCRIPT_FILE, --drop-script-file=DROP_SCRIPT_FILE
> File with drop script
>   -u UPGRADE_SCRIPT_FILE, --upgrade-script-file=UPGRADE_SCRIPT_FILE
> File with upgrade script
>   -t UPGRADE_STACK_SCRIPT_FILE, 
> --upgrade-stack-script-file=UPGRADE_STACK_SCRIPT_FILE
> File with stack upgrade script
>   -j JAVA_HOME, --java-home=JAVA_HOME
> Use specified java_home.  Must be valid on all hosts
>   -v, --verbose Print verbose status messages
>   -s, --silent  Silently accepts default prompt values
>   -g, --debug   Start ambari-server in debug mode
>   -y, --suspend-start   Freeze ambari-server Java process at startup in debug
> mode
>   --all LDAP sync all option.  Synchronize all LDAP users and
> groups.
>   --existingLDAP sync existing option.  Synchronize existing
> Ambari users and groups only.
>   --users=LDAP_SYNC_USERS
> LDAP sync users option. Specifies the path to a CSV
> file of user names to be synchronized.
>   --groups=LDAP_SYNC_GROUPS
> LDAP sync groups option.  Specifies the path to a CSV
> file of group names to be synchronized.
>   --database=DBMS   Database to use
> embedded|oracle|mysql|mss

Review Request 51123: AMBARI-18152: 'ambari-server --help' not working

2016-08-15 Thread Nahappan Somasundaram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51123/
---

Review request for Ambari, Andrew Onischuk and Sumit Mohanty.


Bugs: AMBARI-18152
https://issues.apache.org/jira/browse/AMBARI-18152


Repository: ambari


Description
---

** Issue: **
AMBARI-15300 accesses *properties* in ServerConfigDefaults::__init__() in 
serverConfiguration.py even if get_ambari_properties() fails, resulting in an 
exception, since *properties* is *-1* on failure.

File "/usr/lib/python2.6/site-packages/ambari_server/serverConfiguration.py", 
line 349, in __init__
self.PID_DIR = properties.get_property(PID_DIR_PROPERTY)
AttributeError: 'int' object has no attribute 'get_property'


** Fix: **
In get_ambari_properties():
1. Check if ROOT is available and then use it since this was the primary issue 
(key not found).
2. Read the properties file in its own block of code so that we still have 
access to the properties even if we are not able to replace $ROOT
3. In case of failure reading the properties file, use default properties in 
the caller.


Diffs
-

  ambari-server/sbin/ambari-server 046ff4b3d40cdfde0d5aee52040d6996aefba08b 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py 
07159c3613fe5acdf8c3a65190a82b4287f2824b 

Diff: https://reviews.apache.org/r/51123/diff/


Testing
---

** 1. mvn test -DskipSurefireTests **

--
Ran 267 tests in 6.698s

OK
--
Total run:1120
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 1:09.411s
[INFO] Finished at: Mon Aug 15 17:48:50 PDT 2016
[INFO] Final Memory: 56M/835M
[INFO] 

** 2. Manual testing **
Deployed a VM with the latest build from **trunk** and replaced  
*serverConfiguration.py* with the one from the local build. Verified that 
*ambari-server.py --help* works as expected:

[root@c6401 /]# ambari-server.py --help
Usage: ambari-server.py [options] action [stack_id os]

Options:
  -h, --helpshow this help message and exit
  -f INIT_SCRIPT_FILE, --init-script-file=INIT_SCRIPT_FILE
File with setup script
  -r DROP_SCRIPT_FILE, --drop-script-file=DROP_SCRIPT_FILE
File with drop script
  -u UPGRADE_SCRIPT_FILE, --upgrade-script-file=UPGRADE_SCRIPT_FILE
File with upgrade script
  -t UPGRADE_STACK_SCRIPT_FILE, 
--upgrade-stack-script-file=UPGRADE_STACK_SCRIPT_FILE
File with stack upgrade script
  -j JAVA_HOME, --java-home=JAVA_HOME
Use specified java_home.  Must be valid on all hosts
  -v, --verbose Print verbose status messages
  -s, --silent  Silently accepts default prompt values
  -g, --debug   Start ambari-server in debug mode
  -y, --suspend-start   Freeze ambari-server Java process at startup in debug
mode
  --all LDAP sync all option.  Synchronize all LDAP users and
groups.
  --existingLDAP sync existing option.  Synchronize existing
Ambari users and groups only.
  --users=LDAP_SYNC_USERS
LDAP sync users option. Specifies the path to a CSV
file of user names to be synchronized.
  --groups=LDAP_SYNC_GROUPS
LDAP sync groups option.  Specifies the path to a CSV
file of group names to be synchronized.
  --database=DBMS   Database to use
embedded|oracle|mysql|mssql|postgres|sqlanywhere
  --databasehost=DATABASE_HOST
Hostname of database server
  --databaseport=DATABASE_PORT
Database port
  --databasename=DATABASE_NAME
Database/Service name or ServiceID
  --postgresschema=POSTGRES_SCHEMA
Postgres database schema name
  --databaseusername=DATABASE_USERNAME
Database user login
  --databasepassword=DATABASE_PASSWORD
Database user password
  --sidorsname=SID_OR_SNAME
Oracle database identifier type, Service ID/Service
Name sid|sname
  --sqla-server-name=SQLA_SERVER_NAME
SQL Anywhere server name
  --jdbc-driver=JDBC_DRIVER
Specifies the path to the JDBC driver JAR file or
archive with all required files(jdbc jar, libraries
and etc), for the database type

Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS

2016-08-15 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51121/#review145821
---




ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 (line 370)


How do users prevent this? Is it expected that at least on Oozie server 
host has atlas installed?



ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 (line 381)


Will this call need kinit or sudo ever?


- Sumit Mohanty


On Aug. 16, 2016, 12:40 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51121/
> ---
> 
> (Updated Aug. 16, 2016, 12:40 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-18151
> https://issues.apache.org/jira/browse/AMBARI-18151
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Whenever Oozie submits Hive actions, they fail and the application logs show 
> "Internal Error: 
> java.lang.ClassNotFoundException(org.apache.atlas.hive.hook.HiveHook"
> 
> This is because whenever Atlas is installed, the Hive Hook (which is 
> installed via the Oozie RPM too, in /usr/$stack/$version/atlas/hook/hive/) 
> needs to be copied to the Oozie Share lib in HDFS (e.g., 
> hdfs:///user/oozie/share/lib/lib_$timestamp/hive)
> 
> Further, need to save atlas-application.properties used for Hive in 
> /etc/oozie/conf/action-conf/hive
> 
> Lastly, remove the atlas.rest.address property from hive-site.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  dd3a692 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  e330cb5 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  db048bb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/hive-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51121/diff/
> 
> 
> Testing
> ---
> 
> Verified on a live cluster with HDP 2.5 and Oozie, Hive, Atlas
> 
> Python unit tests passed,
> 
> OK
> --
> Total run:1034
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS

2016-08-15 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51121/#review145820
---




ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 (line 354)


TODO, need to run this only for HDP 2.5 and higher, if Atlas supports hooks 
for Hive.



ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 (line 375)


After Oozie has started, grab the sharelib for Hive.



ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 (line 153)


Calling the main function



ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/hive-site.xml
 (line 24)


Unrelated change, I noticed that atlas.rest.address was still present in 
common services for Hive, so removed it explicitly from HDP 2.5 since Hive 
doesn't have a common-services folder used by HDP 2.5


- Alejandro Fernandez


On Aug. 16, 2016, 12:40 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51121/
> ---
> 
> (Updated Aug. 16, 2016, 12:40 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
> 
> 
> Bugs: AMBARI-18151
> https://issues.apache.org/jira/browse/AMBARI-18151
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Whenever Oozie submits Hive actions, they fail and the application logs show 
> "Internal Error: 
> java.lang.ClassNotFoundException(org.apache.atlas.hive.hook.HiveHook"
> 
> This is because whenever Atlas is installed, the Hive Hook (which is 
> installed via the Oozie RPM too, in /usr/$stack/$version/atlas/hook/hive/) 
> needs to be copied to the Oozie Share lib in HDFS (e.g., 
> hdfs:///user/oozie/share/lib/lib_$timestamp/hive)
> 
> Further, need to save atlas-application.properties used for Hive in 
> /etc/oozie/conf/action-conf/hive
> 
> Lastly, remove the atlas.rest.address property from hive-site.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  dd3a692 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  e330cb5 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  db048bb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/hive-site.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51121/diff/
> 
> 
> Testing
> ---
> 
> Verified on a live cluster with HDP 2.5 and Oozie, Hive, Atlas
> 
> Python unit tests passed,
> 
> OK
> --
> Total run:1034
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS

2016-08-15 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51121/
---

Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.


Bugs: AMBARI-18151
https://issues.apache.org/jira/browse/AMBARI-18151


Repository: ambari


Description
---

Whenever Oozie submits Hive actions, they fail and the application logs show 
"Internal Error: 
java.lang.ClassNotFoundException(org.apache.atlas.hive.hook.HiveHook"

This is because whenever Atlas is installed, the Hive Hook (which is installed 
via the Oozie RPM too, in /usr/$stack/$version/atlas/hook/hive/) needs to be 
copied to the Oozie Share lib in HDFS (e.g., 
hdfs:///user/oozie/share/lib/lib_$timestamp/hive)

Further, need to save atlas-application.properties used for Hive in 
/etc/oozie/conf/action-conf/hive

Lastly, remove the atlas.rest.address property from hive-site.xml


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 dd3a692 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 e330cb5 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 db048bb 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/hive-site.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/51121/diff/


Testing
---

Verified on a live cluster with HDP 2.5 and Oozie, Hive, Atlas

Python unit tests passed,

OK
--
Total run:1034
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie

2016-08-15 Thread Amruta Borkar 


> On Aug. 15, 2016, 3:11 p.m., Robert Nettleton wrote:
> > This patch looks fine to me. 
> > 
> > Can you please update the review with the manual testing you've done with 
> > this patch applied?  We'd probably need to make sure that the Blueprint 
> > cluster deployment, and a Blueprint export, both function properly with 
> > this change applied.
> > 
> > Thanks.

Done. Thank you Robert.


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51055/#review145760
---


On Aug. 15, 2016, 11:54 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51055/
> ---
> 
> (Updated Aug. 15, 2016, 11:54 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18140
> https://issues.apache.org/jira/browse/AMBARI-18140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If a cluster is created with hardcoded hostnames, exported blueprint 
> continues to include the hardcoded hostnames for hive and oozie external 
> database properties. This patch updates the existing maps to included the 
> missed properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  849e90a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  13927f8 
> 
> Diff: https://reviews.apache.org/r/51055/diff/
> 
> 
> Testing
> ---
> 
> Test cases included in the patch.
> Manual testing performed by creating cluster using blueprint with 
> hive_existing_mysql_host property set. and tested export blueprint on it. 
> hive_existing_mysql_host was filtered out in the exported blueprint as 
> expected.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie

2016-08-15 Thread Amruta Borkar 


> On Aug. 15, 2016, 5:28 p.m., Di Li wrote:
> > Ship It!

Thank you Di. Could you please help me push this to trunk?


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51055/#review145773
---


On Aug. 15, 2016, 11:54 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51055/
> ---
> 
> (Updated Aug. 15, 2016, 11:54 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18140
> https://issues.apache.org/jira/browse/AMBARI-18140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If a cluster is created with hardcoded hostnames, exported blueprint 
> continues to include the hardcoded hostnames for hive and oozie external 
> database properties. This patch updates the existing maps to included the 
> missed properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  849e90a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  13927f8 
> 
> Diff: https://reviews.apache.org/r/51055/diff/
> 
> 
> Testing
> ---
> 
> Test cases included in the patch.
> Manual testing performed by creating cluster using blueprint with 
> hive_existing_mysql_host property set. and tested export blueprint on it. 
> hive_existing_mysql_host was filtered out in the exported blueprint as 
> expected.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie

2016-08-15 Thread Amruta Borkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51055/
---

(Updated Aug. 15, 2016, 11:54 p.m.)


Review request for Ambari, Di Li and Robert Nettleton.


Bugs: AMBARI-18140
https://issues.apache.org/jira/browse/AMBARI-18140


Repository: ambari


Description
---

If a cluster is created with hardcoded hostnames, exported blueprint continues 
to include the hardcoded hostnames for hive and oozie external database 
properties. This patch updates the existing maps to included the missed 
properties.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 849e90a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 13927f8 

Diff: https://reviews.apache.org/r/51055/diff/


Testing (updated)
---

Test cases included in the patch.
Manual testing performed by creating cluster using blueprint with 
hive_existing_mysql_host property set. and tested export blueprint on it. 
hive_existing_mysql_host was filtered out in the exported blueprint as expected.


Thanks,

Amruta Borkar

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-15 Thread Li-Wei Tseng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/
---

(Updated Aug. 15, 2016, 10:51 p.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
Yusaku Sako.


Bugs: AMBARI-17591
https://issues.apache.org/jira/browse/AMBARI-17591


Repository: ambari


Description
---

Created metrics service which has a JVM metrics source and a sink. The JVM 
metrics source collect JVM metrics and pass it to the sink which then publish 
the metrics to AMS


Diffs (updated)
-

  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/pom.xml e999d03 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 a6d8d6a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 2bd7eff 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50995/diff/


Testing
---

Manually tested it.


Thanks,

Li-Wei Tseng

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-15 Thread Li-Wei Tseng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/
---

(Updated Aug. 15, 2016, 10:41 p.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
Yusaku Sako.


Changes
---

Fixed review issues, and included a Grafana dashboard graph for Ambari server


Bugs: AMBARI-17591
https://issues.apache.org/jira/browse/AMBARI-17591


Repository: ambari


Description
---

Created metrics service which has a JVM metrics source and a sink. The JVM 
metrics source collect JVM metrics and pass it to the sink which then publish 
the metrics to AMS


Diffs (updated)
-

  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/pom.xml c2ee86d 
  ambari-server/pom.xml e999d03 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5d0bb18 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 a6d8d6a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 2bd7eff 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 2bd7eff 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/SystemMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50995/diff/


Testing
---

Manually tested it.


Thanks,

Li-Wei Tseng

Re: Review Request 51104: AMBARI-18150. Add Hive2/HiveServer2 config "hive.metastore.event.listeners" as empty value in hive-interactive-site.

2016-08-15 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51104/#review145802
---


Ship it!




Ship It!

- Sumit Mohanty


On Aug. 15, 2016, 8:36 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51104/
> ---
> 
> (Updated Aug. 15, 2016, 8:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Siddharth 
> Seth, and Thejas Nair.
> 
> 
> Bugs: AMBARI-18150
> https://issues.apache.org/jira/browse/AMBARI-18150
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - This is done because this is a custom config which if added to Hive1 will 
> get automatically inherited to Hive2. We don't want that to happen. 
> - The inheritance of config from Hive1 to Hive2 can be stopped by adding it a 
> empty config in Hive2.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  14ab470 
> 
> Diff: https://reviews.apache.org/r/51104/diff/
> 
> 
> Testing
> ---
> 
> Deployment:
> - Tested the deployment on new cluster.
> 
> UT: 
> - - Python UT passes.
> - Jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 51078: AMBARI-18142. Define keytab/principal for Spark Thrift Server

2016-08-15 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51078/#review145801
---


Ship it!




Ship It!

- Sumit Mohanty


On Aug. 15, 2016, 5:54 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51078/
> ---
> 
> (Updated Aug. 15, 2016, 5:54 a.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18142
> https://issues.apache.org/jira/browse/AMBARI-18142
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Should define keytab/principle for spark thrift server in its configuration 
> file 'spark-thrift-sparkconf'
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml
>  832a8f5 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  e38316b 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_service.py
>  704af68 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
> 21ba259 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  5a3edef 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> 3aafb75 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  c89a302 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  834871d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> ea2cf52 
> 
> Diff: https://reviews.apache.org/r/51078/diff/
> 
> 
> Testing
> ---
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 51104: AMBARI-18150. Add Hive2/HiveServer2 config "hive.metastore.event.listeners" as empty value in hive-interactive-site.

2016-08-15 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51104/#review145800
---


Ship it!




Ship It!

- Alejandro Fernandez


On Aug. 15, 2016, 8:36 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51104/
> ---
> 
> (Updated Aug. 15, 2016, 8:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Siddharth 
> Seth, and Thejas Nair.
> 
> 
> Bugs: AMBARI-18150
> https://issues.apache.org/jira/browse/AMBARI-18150
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - This is done because this is a custom config which if added to Hive1 will 
> get automatically inherited to Hive2. We don't want that to happen. 
> - The inheritance of config from Hive1 to Hive2 can be stopped by adding it a 
> empty config in Hive2.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  14ab470 
> 
> Diff: https://reviews.apache.org/r/51104/diff/
> 
> 
> Testing
> ---
> 
> Deployment:
> - Tested the deployment on new cluster.
> 
> UT: 
> - - Python UT passes.
> - Jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 51104: AMBARI-18150. Add Hive2/HiveServer2 config "hive.metastore.event.listeners" as empty value in hive-interactive-site.

2016-08-15 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51104/
---

(Updated Aug. 15, 2016, 8:36 p.m.)


Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Siddharth Seth, 
and Thejas Nair.


Changes
---

Made   to  .


Bugs: AMBARI-18150
https://issues.apache.org/jira/browse/AMBARI-18150


Repository: ambari


Description
---

- This is done because this is a custom config which if added to Hive1 will get 
automatically inherited to Hive2. We don't want that to happen. 
- The inheritance of config from Hive1 to Hive2 can be stopped by adding it a 
empty config in Hive2.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 14ab470 

Diff: https://reviews.apache.org/r/51104/diff/


Testing
---

Deployment:
- Tested the deployment on new cluster.

UT: 
- - Python UT passes.
- Jenkins pending.


Thanks,

Swapan Shridhar

Re: Review Request 51104: AMBARI-18150. Add Hive2/HiveServer2 config "hive.metastore.event.listeners" as empty value in hive-interactive-site.

2016-08-15 Thread Swapan Shridhar 


> On Aug. 15, 2016, 8:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml,
> >  line 643
> > 
> >
> > Since this is for HDP 2.5, no need to add   > add="true"/>

Made   to  .


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51104/#review145798
---


On Aug. 15, 2016, 8:36 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51104/
> ---
> 
> (Updated Aug. 15, 2016, 8:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Siddharth 
> Seth, and Thejas Nair.
> 
> 
> Bugs: AMBARI-18150
> https://issues.apache.org/jira/browse/AMBARI-18150
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - This is done because this is a custom config which if added to Hive1 will 
> get automatically inherited to Hive2. We don't want that to happen. 
> - The inheritance of config from Hive1 to Hive2 can be stopped by adding it a 
> empty config in Hive2.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  14ab470 
> 
> Diff: https://reviews.apache.org/r/51104/diff/
> 
> 
> Testing
> ---
> 
> Deployment:
> - Tested the deployment on new cluster.
> 
> UT: 
> - - Python UT passes.
> - Jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 51104: AMBARI-18150. Add Hive2/HiveServer2 config "hive.metastore.event.listeners" as empty value in hive-interactive-site.

2016-08-15 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51104/#review145798
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 (line 643)


Since this is for HDP 2.5, no need to add  


- Alejandro Fernandez


On Aug. 15, 2016, 8:20 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51104/
> ---
> 
> (Updated Aug. 15, 2016, 8:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Siddharth 
> Seth, and Thejas Nair.
> 
> 
> Bugs: AMBARI-18150
> https://issues.apache.org/jira/browse/AMBARI-18150
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - This is done because this is a custom config which if added to Hive1 will 
> get automatically inherited to Hive2. We don't want that to happen. 
> - The inheritance of config from Hive1 to Hive2 can be stopped by adding it a 
> empty config in Hive2.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  14ab470 
> 
> Diff: https://reviews.apache.org/r/51104/diff/
> 
> 
> Testing
> ---
> 
> Deployment:
> - Tested the deployment on new cluster.
> 
> UT: 
> - - Python UT passes.
> - Jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 51104: AMBARI-18150. Add Hive2/HiveServer2 config "hive.metastore.event.listeners" as empty value in hive-interactive-site.

2016-08-15 Thread Thejas Nair 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51104/#review145797
---


Ship it!




Ship It!

- Thejas Nair


On Aug. 15, 2016, 8:20 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51104/
> ---
> 
> (Updated Aug. 15, 2016, 8:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Siddharth 
> Seth, and Thejas Nair.
> 
> 
> Bugs: AMBARI-18150
> https://issues.apache.org/jira/browse/AMBARI-18150
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - This is done because this is a custom config which if added to Hive1 will 
> get automatically inherited to Hive2. We don't want that to happen. 
> - The inheritance of config from Hive1 to Hive2 can be stopped by adding it a 
> empty config in Hive2.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  14ab470 
> 
> Diff: https://reviews.apache.org/r/51104/diff/
> 
> 
> Testing
> ---
> 
> Deployment:
> - Tested the deployment on new cluster.
> 
> UT: 
> - - Python UT passes.
> - Jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 51104: AMBARI-18150. Add Hive2/HiveServer2 config "hive.metastore.event.listeners" as empty value in hive-interactive-site.

2016-08-15 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51104/
---

Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Siddharth Seth, 
and Thejas Nair.


Bugs: AMBARI-18150
https://issues.apache.org/jira/browse/AMBARI-18150


Repository: ambari


Description
---

- This is done because this is a custom config which if added to Hive1 will get 
automatically inherited to Hive2. We don't want that to happen. 
- The inheritance of config from Hive1 to Hive2 can be stopped by adding it a 
empty config in Hive2.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 14ab470 

Diff: https://reviews.apache.org/r/51104/diff/


Testing
---

Deployment:
- Tested the deployment on new cluster.

UT: 
- - Python UT passes.
- Jenkins pending.


Thanks,

Swapan Shridhar

Re: Review Request 51104: AMBARI-18150. Add Hive2/HiveServer2 config "hive.metastore.event.listeners" as empty value in hive-interactive-site.

2016-08-15 Thread Siddharth Seth 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51104/#review145795
---


Ship it!




Ship It!

- Siddharth Seth


On Aug. 15, 2016, 8:20 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51104/
> ---
> 
> (Updated Aug. 15, 2016, 8:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Siddharth 
> Seth, and Thejas Nair.
> 
> 
> Bugs: AMBARI-18150
> https://issues.apache.org/jira/browse/AMBARI-18150
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - This is done because this is a custom config which if added to Hive1 will 
> get automatically inherited to Hive2. We don't want that to happen. 
> - The inheritance of config from Hive1 to Hive2 can be stopped by adding it a 
> empty config in Hive2.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  14ab470 
> 
> Diff: https://reviews.apache.org/r/51104/diff/
> 
> 
> Testing
> ---
> 
> Deployment:
> - Tested the deployment on new cluster.
> 
> UT: 
> - - Python UT passes.
> - Jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie

2016-08-15 Thread Di Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51055/#review145773
---


Ship it!




Ship It!

- Di Li


On Aug. 12, 2016, 11:48 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51055/
> ---
> 
> (Updated Aug. 12, 2016, 11:48 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18140
> https://issues.apache.org/jira/browse/AMBARI-18140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If a cluster is created with hardcoded hostnames, exported blueprint 
> continues to include the hardcoded hostnames for hive and oozie external 
> database properties. This patch updates the existing maps to included the 
> missed properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  849e90a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  13927f8 
> 
> Diff: https://reviews.apache.org/r/51055/diff/
> 
> 
> Testing
> ---
> 
> Test cases included in the patch
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 51055: Avoid hardcoded values in blueprint for hive and oozie

2016-08-15 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51055/#review145760
---


Ship it!




This patch looks fine to me. 

Can you please update the review with the manual testing you've done with this 
patch applied?  We'd probably need to make sure that the Blueprint cluster 
deployment, and a Blueprint export, both function properly with this change 
applied.

Thanks.

- Robert Nettleton


On Aug. 12, 2016, 11:48 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51055/
> ---
> 
> (Updated Aug. 12, 2016, 11:48 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18140
> https://issues.apache.org/jira/browse/AMBARI-18140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If a cluster is created with hardcoded hostnames, exported blueprint 
> continues to include the hardcoded hostnames for hive and oozie external 
> database properties. This patch updates the existing maps to included the 
> missed properties.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  849e90a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  13927f8 
> 
> Diff: https://reviews.apache.org/r/51055/diff/
> 
> 
> Testing
> ---
> 
> Test cases included in the patch
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 51088: AMBARI-18113 Installing ambari-metrics-grafana fails due to lack of conf directory

2016-08-15 Thread Masahiro Tanaka 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51088/#review145758
---



Oops, I found that the actual reason of this error message is because somehow I 
created ambari-metrics-grafana-2.1.0.0-0.noarch.rpm (actually it doesn't do 
anything), put it in my private repository, and installed it via Ambari.

If ambari-metrics-grafana-2.0.0.0-1.x86_64.rpm is in repository, there is no 
problem.

- Masahiro Tanaka


On Aug. 15, 2016, 3:06 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51088/
> ---
> 
> (Updated Aug. 15, 2016, 3:06 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
> 
> 
> Bugs: AMBARI-18113
> https://issues.apache.org/jira/browse/AMBARI-18113
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When installing Ambari Metrics, I got an error
> 
> Stderr
> ```
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 67, in 
> AmsGrafana().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 280, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 32, in install
> self.configure(env) # for security
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py",
>  line 37, in configure
> ams(name='grafana', action=action)
>   File "/usr/lib/python2.6/site-packages/ambari_commons/os_family_impl.py", 
> line 89, in thunk
> return fn(*args, **kwargs)
>   File 
> "/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py",
>  line 413, in ams
> recursive_ownership = True
>   File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
> line 155, in __init__
> self.env.run()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 160, in run
> self.run_action(resource, action)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
> line 124, in run_action
> provider_action()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
>  line 189, in action_create
> raise Fail("Applying %s failed, parent directory %s doesn't exist" % 
> (self.resource, dirname))
> resource_management.core.exceptions.Fail: Applying 
> Directory['/etc/ambari-metrics-grafana/conf'] failed, parent directory 
> /etc/ambari-metrics-grafana doesn't exist
> ```
> 
> Stdout
> ```
> 2016-08-11 13:38:44,481 - Group['hadoop'] {}
> 2016-08-11 13:38:44,483 - Adding group Group['hadoop']
> 2016-08-11 13:38:44,499 - User['zookeeper'] {'gid': 'hadoop', 
> 'fetch_nonlocal_groups': True, 'groups': ['hadoop']}
> 2016-08-11 13:38:44,499 - Adding user User['zookeeper']
> 2016-08-11 13:38:44,555 - User['ams'] {'gid': 'hadoop', 
> 'fetch_nonlocal_groups': True, 'groups': ['hadoop']}
> 2016-08-11 13:38:44,556 - Adding user User['ams']
> 2016-08-11 13:38:44,582 - User['ambari-qa'] {'gid': 'hadoop', 
> 'fetch_nonlocal_groups': True, 'groups': ['users']}
> 2016-08-11 13:38:44,582 - Adding user User['ambari-qa']
> 2016-08-11 13:38:44,616 - File['/var/lib/ambari-agent/tmp/changeUid.sh'] 
> {'content': StaticFile('changeToSecureUid.sh'), 'mode': 0555}
> 2016-08-11 13:38:44,622 - Writing 
> File['/var/lib/ambari-agent/tmp/changeUid.sh'] because it doesn't exist
> 2016-08-11 13:38:44,622 - Changing permission for 
> /var/lib/ambari-agent/tmp/changeUid.sh from 644 to 555
> 2016-08-11 13:38:44,622 - Execute['/var/lib/ambari-agent/tmp/changeUid.sh 
> ambari-qa 
> /tmp/hadoop-ambari-qa,/tmp/hsperfdata_ambari-qa,/home/ambari-qa,/tmp/ambari-qa,/tmp/sqoop-ambari-qa']
>  {'not_if': '(test $(id -u ambari-qa) -gt 1000) || (false)'}
> 2016-08-11 13:38:44,666 - Initializing 2 repositories
> 2016-08-11 13:38:44,666 - Repository['HDP-2.5'] {'base_url': 
> 'http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-1181',
>  'action': ['create'], 'components': ['HDP', 'main'], 'repo_template': 
> '[{{repo_id}}]\nname={{repo_id}}\n{% if mirror_list 
> %}mirrorlist={{mirror_list}}{% else %}baseurl={{base_url}}{% endif 
> %}\n\npath=/\nenabled=1\ngpgcheck=0', 'repo_file_name': 'HDP', 'mirror_list': 
> None}
> 2016-08-11 13:38:44,684 - File['/etc/yum.repos.d/HDP.repo'] {'content': 
> InlineTemplate(...)}
> 2016-08-11 13:38:44,685 - Writing File['/etc/yum.repos.d/HDP.repo'] because 
> it doesn't exist
> 2016-08-11 13:38:44,686 - Repository['HDP-UTILS-1.1.0.21'] {'base_url': 
> 'ht

Re: Review Request 51090: On envs with slow sudo status commands make the agent laggy

2016-08-15 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51090/#review145752
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Aug. 15, 2016, 1:47 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51090/
> ---
> 
> (Updated Aug. 15, 2016, 1:47 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18147
> https://issues.apache.org/jira/browse/AMBARI-18147
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We already know that users who use ldap + non-root end up with their sudo
> commands running very slow.
> 
> This means we should avoid sudo commands as much as possible in status
> commands, because that will freeze up ambari-agent on every status commands
> pack.
> 
> In ATS status commands there is such a problematic code, which is not relevant
> as of now and can be safely removed.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/package/rpm/preinstall.sh 6291c9e 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  81fc94f 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
> 1a0c788 
> 
> Diff: https://reviews.apache.org/r/51090/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 51090: On envs with slow sudo status commands make the agent laggy

2016-08-15 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51090/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18147
https://issues.apache.org/jira/browse/AMBARI-18147


Repository: ambari


Description
---

We already know that users who use ldap + non-root end up with their sudo
commands running very slow.

This means we should avoid sudo commands as much as possible in status
commands, because that will freeze up ambari-agent on every status commands
pack.

In ATS status commands there is such a problematic code, which is not relevant
as of now and can be safely removed.


Diffs
-

  ambari-server/src/main/package/rpm/preinstall.sh 6291c9e 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
 81fc94f 
  ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
1a0c788 

Diff: https://reviews.apache.org/r/51090/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 51017: Error message displays mesage key instead of actual message

2016-08-15 Thread Alexandr Antonenko 


> On Aug. 12, 2016, 5:15 p.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> Sangeeta Ravindran wrote:
> Thanks Alexandr. Can you please help push it?

done


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51017/#review145637
---


On Aug. 12, 2016, 3:19 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51017/
> ---
> 
> (Updated Aug. 12, 2016, 3:19 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18133
> https://issues.apache.org/jira/browse/AMBARI-18133
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When an non-existing group name is entered under Local Membership, the error 
> message returns the message key instead of the actual message.
> 
> This is because of a typo in the message key used i.e. 
> users.alert.cannotAddUser is used instead of users.alerts.cannotAddUser
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js
>  3beb42a 
> 
> Diff: https://reviews.apache.org/r/51017/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing.
> mvn test ran clean.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>