Re: Review Request 51937: Configuration Groups popup: Tooltip over properties number has too much content

2016-09-15 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51937/#review149155 ---

Review Request 51937: Configuration Groups popup: Tooltip over properties number has too much content

2016-09-15 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51937/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.

Re: Review Request 51903: Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51903/#review149149 --- Pushed to trunk, commit 1efc99c5adc536044425b9df45b72421c5a8323c

Re: Review Request 51903: Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51903/ --- (Updated Sept. 15, 2016, 9:43 p.m.) Review request for Ambari, Dmytro

Re: Review Request 51903: [PREVIEW] Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51903/#review149134 --- Ship it! OK - I think Alejandro and I got to the bottom of

Re: Review Request 51903: [PREVIEW] Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-15 Thread Alejandro Fernandez
> On Sept. 15, 2016, 2:49 a.m., Jonathan Hurley wrote: > > I think we can do better. Why not just use `os.path.exists` to check the > > `current_dir` structure. In the case of atlas, the psuedo code woudl read: > > > > if "/etc/atlas/conf" is a directory and if "/usr/hdp/current/atlas-client"

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

2016-09-15 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51914/#review149098 --- Ship it! Ship It! - Oliver Szabo On Sept. 15, 2016, 5:36

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

2016-09-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51914/#review149096 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 15, 2016,

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

2016-09-15 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51890/#review149089 --- Ship it! Ship It! - Alejandro Fernandez On Sept. 15, 2016,

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

2016-09-15 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51914/ --- (Updated Sept. 15, 2016, 7:36 p.m.) Review request for Ambari, Balázs Bence

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

2016-09-15 Thread Attila Doroszlai
> On Sept. 15, 2016, 5:55 p.m., Laszlo Puskas wrote: > > ambari-server/src/test/python/unitTests.py, line 158 > > > > > > Is the second conditin required here? It turns out to be unnecessary (as long as the script

Re: Review Request 51917: Upgrade Summary Endpoint Throws NPEs Due To JPA Cached Entities With Missing IDs

2016-09-15 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51917/#review149080 --- Ship it! Ship It! - Robert Levas On Sept. 15, 2016, 12:15

Re: Review Request 51916: YAML Maps Can Include Dashes and Other Non-Word Characters

2016-09-15 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51916/#review149079 --- Ship it! Ship It! - Robert Levas On Sept. 15, 2016, 11:54

Re: Review Request 51890: AMBARI-18386 Handle Ranger hive repo config jdbc url change for stack 2.5

2016-09-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51890/#review149076 --- Ship it! Ship It! - Jayush Luniya On Sept. 15, 2016, 5:26

Re: Review Request 51917: Upgrade Summary Endpoint Throws NPEs Due To JPA Cached Entities With Missing IDs

2016-09-15 Thread Jonathan Hurley
> On Sept. 15, 2016, 12:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java, > > lines 531-533 > > > > > > Is it ever possible to have a stage

Re: Review Request 51916: YAML Maps Can Include Dashes and Other Non-Word Characters

2016-09-15 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51916/#review149072 --- Ship it! Ship It! - Nate Cole On Sept. 15, 2016, 11:54

Re: Review Request 51917: Upgrade Summary Endpoint Throws NPEs Due To JPA Cached Entities With Missing IDs

2016-09-15 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51917/#review149071 --- Ship it!

Review Request 51917: Upgrade Summary Endpoint Throws NPEs Due To JPA Cached Entities With Missing IDs

2016-09-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51917/ --- Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.

Re: Review Request 51910: Update version-builder to include unique element

2016-09-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51910/ --- (Updated Sept. 15, 2016, 7:08 p.m.) Review request for Ambari, Nate Cole and

Re: Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

2016-09-15 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51914/#review149069 --- Fix it, then Ship it! Fix it then Ship it.

Review Request 51916: YAML Maps Can Include Dashes and Other Non-Word Characters

2016-09-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51916/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-18403

Review Request 51915: AMBARI-18402 - Alert definition should include AGGREGATE source type

2016-09-15 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51915/ --- Review request for Ambari, Di Li and Jonathan Hurley. Bugs: AMBARI-18402

Review Request 51914: AMBARI-18401 Allow running a subset of Python unit tests

2016-09-15 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51914/ --- Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, and

Re: Review Request 51892: Create authentication filter to encapsulate the various Ambari authentication methods

2016-09-15 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51892/#review149054 --- Ship it! Ship It! - Nate Cole On Sept. 15, 2016, 8:31 a.m.,

Re: Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-15 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51906/#review149052 ---

Re: Review Request 51892: Create authentication filter to encapsulate the various Ambari authentication methods

2016-09-15 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51892/ --- (Updated Sept. 15, 2016, 8:31 a.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 51903: [PREVIEW] Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-15 Thread Jonathan Hurley
> On Sept. 14, 2016, 10:49 p.m., Jonathan Hurley wrote: > > I think we can do better. Why not just use `os.path.exists` to check the > > `current_dir` structure. In the case of atlas, the psuedo code woudl read: > > > > if "/etc/atlas/conf" is a directory and if "/usr/hdp/current/atlas-client"

Review Request 51906: AMBARI-18349 Specify role command order to make Microsoft-R service check run after YARN is started

2016-09-15 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51906/ --- Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, and

Re: Review Request 51908: Analyze and Optimize Ambari Server Unit Tests - Group 3

2016-09-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51908/#review149046 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 15, 2016,

Re: Review Request 51908: Analyze and Optimize Ambari Server Unit Tests - Group 3

2016-09-15 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51908/#review149045 --- Ship it! Ship It! - Dmytro Sen On Сен. 15, 2016, 10:53

Review Request 51908: Analyze and Optimize Ambari Server Unit Tests - Group 3

2016-09-15 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51908/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.

Re: Review Request 51894: View instance cloning functionality

2016-09-15 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51894/#review149041 --- Ship it! Ship It! - Alexandr Antonenko On Sept. 14, 2016,

Re: Review Request 51898: AMBARI-18392 : Cluster failure due to APP_TIMELINE_SERVER and RESOURCEMANAGER failed to start

2016-09-15 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51898/#review149039 --- ambari-server/src/main/resources/scripts/Ambaripreupload.py

Re: Review Request 51903: [PREVIEW] Atlas web UI alert after performing stack upgrade to HDP 2.5 and adding Atlas Service

2016-09-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51903/#review149030 ---