Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52758/#review152247
---




ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
 (line 45)


Why is exists query appropiate here, instead of stageId IN ??


- Sid Wagle


On Oct. 11, 2016, 11:48 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52758/
> ---
> 
> (Updated Oct. 11, 2016, 11:48 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18576
> https://issues.apache.org/jira/browse/AMBARI-18576
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> * Install Ambari 2.4.0.1 with any HDP stack (e.g., 2.5) and HDFS, YARN, ZK
> * Run multiple commands in parallel (such as service checks)
> * Attempt to abort any one of them
> 
> Instead of aborting just the desired one, it will abort all requests.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
>  0e78cbc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  c31ca7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  e380ae4 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
> 8ef4a1b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  7659a23 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
>  9f12a94 
> 
> Diff: https://reviews.apache.org/r/52758/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster.
> Waiting for unit test results.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 52710: AMBARI-18566 Installer wizard-> Select Versions page: Selecting Red Hat Satellite option and clicking next button makes wizard stuck

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52710/#review152231
---


Ship it!




Ship It!

- Richard Zang


On Oct. 12, 2016, 12:07 a.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52710/
> ---
> 
> (Updated Oct. 12, 2016, 12:07 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18566
> https://issues.apache.org/jira/browse/AMBARI-18566
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *STR:*
> # Got to select versions page
> # Choose "Use Local Repository" option and then choose "Use RedHat 
> Satellite/Spacewalk" option
> # Next button will get enabled. click on next button. 
> 
> *Expected Result:* wizard goes to next page
> *Actual Result:* On clicking next button, next button gets disabled and 
> wizard does not go to next page.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/installer.js f8f70a0 
>   ambari-web/app/views/wizard/step1_view.js 2b80ad5 
> 
> Diff: https://reviews.apache.org/r/52710/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 30374 tests complete (27 seconds)
> 151 tests pending
> Manual testing done
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 52710: AMBARI-18566 Installer wizard-> Select Versions page: Selecting Red Hat Satellite option and clicking next button makes wizard stuck

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52710/
---

(Updated Oct. 12, 2016, 12:07 a.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-18566
https://issues.apache.org/jira/browse/AMBARI-18566


Repository: ambari


Description
---

*STR:*
# Got to select versions page
# Choose "Use Local Repository" option and then choose "Use RedHat 
Satellite/Spacewalk" option
# Next button will get enabled. click on next button. 

*Expected Result:* wizard goes to next page
*Actual Result:* On clicking next button, next button gets disabled and wizard 
does not go to next page.


Diffs (updated)
-

  ambari-web/app/controllers/installer.js f8f70a0 
  ambari-web/app/views/wizard/step1_view.js 2b80ad5 

Diff: https://reviews.apache.org/r/52710/diff/


Testing
---

Local ambari-web test passed.
30374 tests complete (27 seconds)
151 tests pending
Manual testing done


Thanks,

Zhe (Joe) Wang

Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52758/#review152228
---




ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 (line 1145)


This was the bug. When aborting a request by its ID, it used to also abort 
all stages in progress, even if they belonged to a different request.


- Alejandro Fernandez


On Oct. 11, 2016, 11:48 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52758/
> ---
> 
> (Updated Oct. 11, 2016, 11:48 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18576
> https://issues.apache.org/jira/browse/AMBARI-18576
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> * Install Ambari 2.4.0.1 with any HDP stack (e.g., 2.5) and HDFS, YARN, ZK
> * Run multiple commands in parallel (such as service checks)
> * Attempt to abort any one of them
> 
> Instead of aborting just the desired one, it will abort all requests.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
>  0e78cbc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  c31ca7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  e380ae4 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
> 8ef4a1b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  7659a23 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
>  9f12a94 
> 
> Diff: https://reviews.apache.org/r/52758/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster.
> Waiting for unit test results.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52758/
---

Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
Hurley, Nate Cole, and Sid Wagle.


Bugs: AMBARI-18576
https://issues.apache.org/jira/browse/AMBARI-18576


Repository: ambari


Description
---

STR:

* Install Ambari 2.4.0.1 with any HDP stack (e.g., 2.5) and HDFS, YARN, ZK
* Run multiple commands in parallel (such as service checks)
* Attempt to abort any one of them

Instead of aborting just the desired one, it will abort all requests.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
 0e78cbc 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
 c31ca7e 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 e380ae4 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
8ef4a1b 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
 7659a23 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
 9f12a94 

Diff: https://reviews.apache.org/r/52758/diff/


Testing
---

Verified on live cluster.
Waiting for unit test results.


Thanks,

Alejandro Fernandez

Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52757/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-18575
https://issues.apache.org/jira/browse/AMBARI-18575


Repository: ambari


Description
---

Issue: 

**Current time taken:**
==

||Test||Count||Time (s)||
|org.apache.ambari.server.upgrade.UpgradeCatalog221Test |13|36.586|
|org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|


**Individual tests time taken is as follows:**
==

**UpgradeCatalog221Test:**

- init() function takes most of the time.

||Test No.||Test||Time (micro secs)||
| |init()|10197|
|1|testUpdateAmsHbaseSiteConfigs| 198|
| |init()|3140|
|2|testExecuteDDLUpdates| 17|
| |init()|2377|
|3|test_AddCheckCommandTimeoutParam_ParamsNotAvailable| 6|
| |init()|2396|
|4|testExecuteDMLUpdates| 18|
| |init()|2203|
|5|testUpdateTezConfigs| 11|
| |init()|2011|
|6|testUpdateAmsHbaseEnvContent| 0|
| |init()|1953|
|7|test_AddCheckCommandTimeoutParam_NeededParamAlreadyAdded| 0|
| |init()|1882|
|8|testUpdateOozieConfigs| 2|
| |init()|1871|
|9|testUpdateAmsEnvContent| 0|
| |init()|1801|
|10|testUpdateRangerKmsDbksConfigs| 2|
| |init()|1735|
|11|test_AddCheckCommandTimeoutParam_ParamsAvailable| 0|
| |init()|1693|
|12|testUpdateAmsHbaseSecuritySiteConfigs| 5|
| |init()|1626|
|13|testUpdateAlertDefinitions| 19|


*ExecutionScheduleManagerTest:*
- setup() function takes most of the time.

||Test No.||Test||Time (micro secs)||
| |setup()|10111|
|1|testUpdateBatchRequest| 249|
| |after()|2|
| |setup()|3234|
|2|testExecuteBatchRequest| 59|
| |after()|1|
| |setup()|2480|
|3|testScheduleBatch| 40|
| |after()|1|
| |setup()|2381|
|4|testFinalizeBeforeExit| 28|
| |after()|1|
| |setup()|2312|
|5|testDeleteAllJobs| 17|
| |after()|1|
| |setup()|2141|
|6|testFinalizeBatch| 64|
| |after()|1|
| |setup()|1970|
|7|testPointInTimeExecutionJob| 18|
| |after()|2|
| |setup()|1944|
|8|testHasToleranceThresholdExceeded| 68|
| |after()|1|
| |setup()|1994|
|9|testGetBatchRequestResponse| 59|
| |after()|1|


**Fix:** 


Make test's before and after functions as @BeforeClass @AfterClass methods.


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
 f2fe3b8 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java
 e754a41 

Diff: https://reviews.apache.org/r/52757/diff/


Testing
---

- Locally: Passes
- Jenkins pending.


Thanks,

Swapan Shridhar

Re: Review Request 52752: Hive shows restart indicator after RU

[Nate Cole]

> On Oct. 11, 2016, 5:30 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml, 
> > line 251
> > 
> >
> > Can't we have another group just before Hive that updates hive-site and 
> > hive-env. So that the restart of Metastore or HS2 will get the same configs?
> > 
> > I'm wary of changing the orchestration order of Hive.
> 
> Alejandro Fernandez wrote:
> 2.5->2.5* is relatively safe though

That's more change than I was willing to make for this use case (and a lot more 
testing).  We can open a different JIRA for that (and to verify other stacks).  
We only have until Fri to get this indicator removed.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52752/#review152210
---


On Oct. 11, 2016, 5:13 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52752/
> ---
> 
> (Updated Oct. 11, 2016, 5:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18568
> https://issues.apache.org/jira/browse/AMBARI-18568
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Only for HDP-2.5"
> 
> Move METASTORE to after HIVE_SERVER to make sure the configs are picked up.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 88d9b13 
> 
> Diff: https://reviews.apache.org/r/52752/diff/
> 
> 
> Testing
> ---
> 
> Manually tested RU for HDP-2.5.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 52752: Hive shows restart indicator after RU

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52752/#review152210
---




ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml (line 
250)


Can't we have another group just before Hive that updates hive-site and 
hive-env. So that the restart of Metastore or HS2 will get the same configs?

I'm wary of changing the orchestration order of Hive.


- Alejandro Fernandez


On Oct. 11, 2016, 9:13 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52752/
> ---
> 
> (Updated Oct. 11, 2016, 9:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18568
> https://issues.apache.org/jira/browse/AMBARI-18568
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Only for HDP-2.5"
> 
> Move METASTORE to after HIVE_SERVER to make sure the configs are picked up.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 88d9b13 
> 
> Diff: https://reviews.apache.org/r/52752/diff/
> 
> 
> Testing
> ---
> 
> Manually tested RU for HDP-2.5.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 52752: Hive shows restart indicator after RU

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52752/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-18568
https://issues.apache.org/jira/browse/AMBARI-18568


Repository: ambari


Description
---

*Only for HDP-2.5"

Move METASTORE to after HIVE_SERVER to make sure the configs are picked up.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
88d9b13 

Diff: https://reviews.apache.org/r/52752/diff/


Testing
---

Manually tested RU for HDP-2.5.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 52749: Ambari should be able to create arbitrary Kerberos identities for itself as declared in the Kerberos Descriptor

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52749/#review152204
---


Ship it!




Ship It!

- Nate Cole


On Oct. 11, 2016, 4:06 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52749/
> ---
> 
> (Updated Oct. 11, 2016, 4:06 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
> Sandor Magyari.
> 
> 
> Bugs: AMBARI-18564
> https://issues.apache.org/jira/browse/AMBARI-18564
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should be able to create arbitrary Kerberos identities for itself as 
> declared in the Kerberos Descriptor.
> 
> Currently, Ambari is hard-coded to create identities for itself and SPNEGO, 
> but that may not be good enough for all scenarios. Therefore, there needs to 
> be an `AMBARI` service block in the Kerberos descriptor to allow for 
> arbitrary identities to be defined for the Ambari server - similar to how any 
> other service  is defined in the Kerberos descriptor.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
>  1153d01 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  e15965b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  c283a65 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
>  80acd0d 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 0644f57 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  b2eb738 
> 
> Diff: https://reviews.apache.org/r/52749/diff/
> 
> 
> Testing
> ---
> 
> Manually tested using the UI and BP ont he trunk and brach-2.5
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 52709: Deprecate old UpgradeCatalog Unit Tests

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52709/#review152201
---


Ship it!




Ship It!

- Robert Levas


On Oct. 10, 2016, 7:21 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52709/
> ---
> 
> (Updated Oct. 10, 2016, 7:21 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sid Wagle.
> 
> 
> Bugs: AMBARI-18565
> https://issues.apache.org/jira/browse/AMBARI-18565
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Deprecate the older UpgradeCatalog tests that are no longer needed to 
> decrease time it takes to run unit tests.
> UpgradeCatalog150Test
> UpgradeCatalog151Test
> UpgradeCatalog160Test
> UpgradeCatalog161Test
> UpgradeCatalog170Test
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheckTest.java
>  7469bbc 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/SecurityFilterTest.java
>  49eefed 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
>  ec01b80 
>   
> ambari-server/src/test/java/org/apache/ambari/server/testing/DeadlockWarningThread.java
>  589aee1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog150Test.java
>  4647815 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog151Test.java
>  b47f411 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java
>  303fa3a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog161Test.java
>  a3b41b8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java
>  10e4993 
> 
> Diff: https://reviews.apache.org/r/52709/diff/
> 
> 
> Testing
> ---
> 
> "mvn clean test" passed
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 52749: Ambari should be able to create arbitrary Kerberos identities for itself as declared in the Kerberos Descriptor

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52749/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
Sandor Magyari.


Bugs: AMBARI-18564
https://issues.apache.org/jira/browse/AMBARI-18564


Repository: ambari


Description
---

Ambari should be able to create arbitrary Kerberos identities for itself as 
declared in the Kerberos Descriptor.

Currently, Ambari is hard-coded to create identities for itself and SPNEGO, but 
that may not be good enough for all scenarios. Therefore, there needs to be an 
`AMBARI` service block in the Kerberos descriptor to allow for arbitrary 
identities to be defined for the Ambari server - similar to how any other 
service  is defined in the Kerberos descriptor.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 1153d01 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 e15965b 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 c283a65 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
 80acd0d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 0644f57 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 b2eb738 

Diff: https://reviews.apache.org/r/52749/diff/


Testing
---

Manually tested using the UI and BP ont he trunk and brach-2.5

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 52747: Migration to Bootstrap3 framework

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152182
---




ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
(line 44)


glyphicon is duplicated.  This probably has no material impact, but let's 
remove this.



ambari-web/app/templates/common/configs/widgets/textfield_config_widget.hbs 
(line 19)


Need to fix this typo



ambari-web/vendor/theme/bootstrap-ambari.min.css (line 1)


Can we put this in a non-vendor directory, unminified with an appropriate 
license header?


- Yusaku Sako


On Oct. 11, 2016, 6:34 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52747/
> ---
> 
> (Updated Oct. 11, 2016, 6:34 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18573
> https://issues.apache.org/jira/browse/AMBARI-18573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate from Bootstrap2 to Bootstrap3 framework.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt 906c0590c2a749b910139dee2af70e4b4b17c949 
>   ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
>   ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
>   ambari-web/app/controllers/application.js 
> dca689f949dfa3583fac3e2d181e2d876716664d 
>   ambari-web/app/controllers/main/admin/service_auto_start.js 
> b425c785770ef05c4b7b519d50645be0f1b655ea 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> d00a652f8da42fba20fb86394e06dcedba18edfc 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> f05d366057d75ca47418891c86504f18e8e3f1c4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  43e25c8c5338d9c264aa8346cce1b12d195f64f0 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
>   ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
> 5913070d3ba799b6d2415361381aea781b1f313d 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 6ba595738234aa840de8bdbca47884a5d699b843 
>   ambari-web/app/controllers/main/charts/heatmap.js 
> 73d18005202e956b2af4732abf3467a72a7d96f2 
>   ambari-web/app/controllers/main/service/info/summary.js 
> c16bb3fc728fe89743d308e0ab96b073e5a8845f 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
>   ambari-web/app/controllers/wizard/step10_controller.js 
> 8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
>   ambari-web/app/controllers/wizard/step1_controller.js 
> a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
> 399000eaac97dc4bcfa121b5b3906db7bf71013f 
>   ambari-web/app/data/host/categories.js 
> 7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
>   ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
>   ambari-web/app/mixins/common/configs/configs_saver.js 
> 6592203d614d55c7940657e56e119d4a2f2809bd 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 
> 5ec4dd6cad9320220da375891894bc41ece71908 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js 
> c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
> b10d386ebfb6624dad507f63904edc6d03665fe3 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> cbb81b369b98baafe5c7962242812522f53ab823 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 38d5b1770a53704c650008afc6ab6a1bbda08d1d 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 
> a8bd273e2ebc25834559224cd0f9d2e78f91 
>   ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
> 96a25781e27d2be364454aa0337ffec21b85aaf1 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js 
> 81970866b4e9dd158e0a6821c4f53c01df845855 
>   ambari-web/app/models/alerts/alert_config.js 
> efbfebff5840dcdafea7657ff44ba0c7206b05bb 
>   

Re: Review Request 52747: Migration to Bootstrap3 framework

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152178
---


Ship it!




Ship It!

- Jaimin Jetly


On Oct. 11, 2016, 6:34 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52747/
> ---
> 
> (Updated Oct. 11, 2016, 6:34 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18573
> https://issues.apache.org/jira/browse/AMBARI-18573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate from Bootstrap2 to Bootstrap3 framework.
> 
> 
> Diffs
> -
> 
>   LICENSE.txt 906c0590c2a749b910139dee2af70e4b4b17c949 
>   ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
>   ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
>   ambari-web/app/controllers/application.js 
> dca689f949dfa3583fac3e2d181e2d876716664d 
>   ambari-web/app/controllers/main/admin/service_auto_start.js 
> b425c785770ef05c4b7b519d50645be0f1b655ea 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> d00a652f8da42fba20fb86394e06dcedba18edfc 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> f05d366057d75ca47418891c86504f18e8e3f1c4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  43e25c8c5338d9c264aa8346cce1b12d195f64f0 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
>   ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
> 5913070d3ba799b6d2415361381aea781b1f313d 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 6ba595738234aa840de8bdbca47884a5d699b843 
>   ambari-web/app/controllers/main/charts/heatmap.js 
> 73d18005202e956b2af4732abf3467a72a7d96f2 
>   ambari-web/app/controllers/main/service/info/summary.js 
> c16bb3fc728fe89743d308e0ab96b073e5a8845f 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
>   ambari-web/app/controllers/wizard/step10_controller.js 
> 8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
>   ambari-web/app/controllers/wizard/step1_controller.js 
> a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
> 399000eaac97dc4bcfa121b5b3906db7bf71013f 
>   ambari-web/app/data/host/categories.js 
> 7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
>   ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
>   ambari-web/app/mixins/common/configs/configs_saver.js 
> 6592203d614d55c7940657e56e119d4a2f2809bd 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 
> 5ec4dd6cad9320220da375891894bc41ece71908 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js 
> c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
> b10d386ebfb6624dad507f63904edc6d03665fe3 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> cbb81b369b98baafe5c7962242812522f53ab823 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 38d5b1770a53704c650008afc6ab6a1bbda08d1d 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 
> a8bd273e2ebc25834559224cd0f9d2e78f91 
>   ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
> 96a25781e27d2be364454aa0337ffec21b85aaf1 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js 
> 81970866b4e9dd158e0a6821c4f53c01df845855 
>   ambari-web/app/models/alerts/alert_config.js 
> efbfebff5840dcdafea7657ff44ba0c7206b05bb 
>   ambari-web/app/models/alerts/alert_definition.js 
> 4da7199320bc925977071b41d2a0ee1c0b03bcbe 
>   ambari-web/app/models/alerts/alert_instance.js 
> b366802acfe56eac234abbe130198c9ae6bc8e00 
>   ambari-web/app/models/authentication.js 
> 436c18410c79928edd33367c99fe9ec94d8454d8 
>   ambari-web/app/models/host_component.js 
> 11ea659089742d261ceb9f31aaecfd668b553bfa 
>   ambari-web/app/models/hosts.js 9275b3e320136d6932e91b18d9f832eeb7d93e4b 
>   ambari-web/app/models/repository.js 
> 0b7ee69d0f108132c9a6b694b3b8918864d784c4 
>   ambari-web/app/router.js 02707711b8c132d2815854a7bc902ac39a034aae 
>   

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52691/#review152173
---



Overall a really good improvement to optimize the install/start time.


ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 (line 410)


Does this only affect fresh install and not other commands, especially 
during Rolling/Express upgrade?



ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CommandExecutionType.java
 (line 21)


Please add some javadoc for how these differ.
Can we shorten "STAGE_BASED" to "STAGE"?



ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
 (line 78)


MasterHostResolver.java already has a method called isNameNodeHA().
Not sure if you want to use it.



ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
 (line 99)


I would prefer if these attributes, hasGLUSTERFS, isNameNodeHAEnabled, 
isResourceManagerHAEnabled weren't passed to the initialize method, but rather 
set on the object, which could then be initialized without any other params, in 
case the function signature needs to change in the future.


- Alejandro Fernandez


On Oct. 11, 2016, 2:41 p.m., Sandor Magyari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52691/
> ---
> 
> (Updated Oct. 11, 2016, 2:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo 
> Puskas, Nate Cole, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18553
> https://issues.apache.org/jira/browse/AMBARI-18553
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, the START commands stored in role_command_orders table are bound to 
> multiple stages created based on dependencies between components - a 
> component in the second stage can only begin its START after the entire first 
> stage is done as opposed to just its dependencies in the first stage. This 
> eventually increases the overall blueprint deployment time.
> The goal is to be able to configure a direct dependency based execution model 
> of commands, for now only for Blueprint based deployment commands.
> 
> Implementation:
> ---
> When creating stages we set the commandExecutionType to RoleGraph. In case 
> commandExecutionType is set to DEPENDENCY_ORDERED there's only one stage 
> created. commandExecutionType is persisted into Stage object / entity as 
> well, so ActionScheduler can decide based on commandExecutionType how to 
> execute the stage. In case commandExecutionType is set to DEPENDENCY_ORDERED 
> it will filter out commands having dependencies on other commands 
> IN_PROGRESS. By default commandExecutionType is STAGE_BASED which works as 
> before, creating one or more stages dependening on dependecies.
> DEPENDENCY_ORDERED commandExecutionType is set only in case of START commands 
> initiated by Blueprint deployment and if Ambari property 
> server.stage.command.execution_type = DEPENDENCY_ORDERED.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  e380ae4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CommandExecutionType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> f03d8ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  5afaba8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
>  bbdb808 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  7659a23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
>  c9ab6f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactory.java
>  625b168 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactoryImpl.java
>  5ca4d88 
>   
> 

Review Request 52747: Migration to Bootstrap3 framework

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/
---

Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
and Yusaku Sako.


Bugs: AMBARI-18573
https://issues.apache.org/jira/browse/AMBARI-18573


Repository: ambari


Description
---

Migrate from Bootstrap2 to Bootstrap3 framework.


Diffs
-

  LICENSE.txt 906c0590c2a749b910139dee2af70e4b4b17c949 
  ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
  ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
  ambari-web/app/controllers/application.js 
dca689f949dfa3583fac3e2d181e2d876716664d 
  ambari-web/app/controllers/main/admin/service_auto_start.js 
b425c785770ef05c4b7b519d50645be0f1b655ea 
  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
d00a652f8da42fba20fb86394e06dcedba18edfc 
  ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
f05d366057d75ca47418891c86504f18e8e3f1c4 
  
ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js 
43e25c8c5338d9c264aa8346cce1b12d195f64f0 
  
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
  ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
5913070d3ba799b6d2415361381aea781b1f313d 
  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
6ba595738234aa840de8bdbca47884a5d699b843 
  ambari-web/app/controllers/main/charts/heatmap.js 
73d18005202e956b2af4732abf3467a72a7d96f2 
  ambari-web/app/controllers/main/service/info/summary.js 
c16bb3fc728fe89743d308e0ab96b073e5a8845f 
  ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
  ambari-web/app/controllers/wizard/step10_controller.js 
8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
  ambari-web/app/controllers/wizard/step1_controller.js 
a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
  ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
399000eaac97dc4bcfa121b5b3906db7bf71013f 
  ambari-web/app/data/host/categories.js 
7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
  ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
  ambari-web/app/mixins/common/configs/configs_saver.js 
6592203d614d55c7940657e56e119d4a2f2809bd 
  ambari-web/app/mixins/common/widgets/widget_mixin.js 
5ec4dd6cad9320220da375891894bc41ece71908 
  ambari-web/app/mixins/main/dashboard/widgets/editable.js 
c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
  ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
b10d386ebfb6624dad507f63904edc6d03665fe3 
  ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
cbb81b369b98baafe5c7962242812522f53ab823 
  ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
38d5b1770a53704c650008afc6ab6a1bbda08d1d 
  ambari-web/app/mixins/main/service/configs/config_overridable.js 
a8bd273e2ebc25834559224cd0f9d2e78f91 
  ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
96a25781e27d2be364454aa0337ffec21b85aaf1 
  ambari-web/app/mixins/wizard/wizardProgressPageView.js 
81970866b4e9dd158e0a6821c4f53c01df845855 
  ambari-web/app/models/alerts/alert_config.js 
efbfebff5840dcdafea7657ff44ba0c7206b05bb 
  ambari-web/app/models/alerts/alert_definition.js 
4da7199320bc925977071b41d2a0ee1c0b03bcbe 
  ambari-web/app/models/alerts/alert_instance.js 
b366802acfe56eac234abbe130198c9ae6bc8e00 
  ambari-web/app/models/authentication.js 
436c18410c79928edd33367c99fe9ec94d8454d8 
  ambari-web/app/models/host_component.js 
11ea659089742d261ceb9f31aaecfd668b553bfa 
  ambari-web/app/models/hosts.js 9275b3e320136d6932e91b18d9f832eeb7d93e4b 
  ambari-web/app/models/repository.js 0b7ee69d0f108132c9a6b694b3b8918864d784c4 
  ambari-web/app/router.js 02707711b8c132d2815854a7bc902ac39a034aae 
  ambari-web/app/routes/activate_hawq_standby_routes.js 
8ab19dba452a33d389f66b030626c87afa2f9489 
  ambari-web/app/routes/add_alert_definition_routes.js 
15d010394e81fae48b63964f3d5e18e02f2e6f03 
  ambari-web/app/routes/add_hawq_standby_routes.js 
d802808e91c99523e166639311b533fe16c87629 
  ambari-web/app/routes/add_host_routes.js 
c733a6665637cd9a8c749a844d531a530abe071b 
  ambari-web/app/routes/add_kerberos_routes.js 
1568577b3a2591c3ac1059c3625d6c64cf0f7913 
  ambari-web/app/routes/add_service_routes.js 
692d186d8a941409b5127fe02115e072d33d0160 
  

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52691/#review152166
---




ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 (line 103)


This is a big patch, please give me some time to go through it.


- Alejandro Fernandez


On Oct. 11, 2016, 2:41 p.m., Sandor Magyari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52691/
> ---
> 
> (Updated Oct. 11, 2016, 2:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo 
> Puskas, Nate Cole, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18553
> https://issues.apache.org/jira/browse/AMBARI-18553
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, the START commands stored in role_command_orders table are bound to 
> multiple stages created based on dependencies between components - a 
> component in the second stage can only begin its START after the entire first 
> stage is done as opposed to just its dependencies in the first stage. This 
> eventually increases the overall blueprint deployment time.
> The goal is to be able to configure a direct dependency based execution model 
> of commands, for now only for Blueprint based deployment commands.
> 
> Implementation:
> ---
> When creating stages we set the commandExecutionType to RoleGraph. In case 
> commandExecutionType is set to DEPENDENCY_ORDERED there's only one stage 
> created. commandExecutionType is persisted into Stage object / entity as 
> well, so ActionScheduler can decide based on commandExecutionType how to 
> execute the stage. In case commandExecutionType is set to DEPENDENCY_ORDERED 
> it will filter out commands having dependencies on other commands 
> IN_PROGRESS. By default commandExecutionType is STAGE_BASED which works as 
> before, creating one or more stages dependening on dependecies.
> DEPENDENCY_ORDERED commandExecutionType is set only in case of START commands 
> initiated by Blueprint deployment and if Ambari property 
> server.stage.command.execution_type = DEPENDENCY_ORDERED.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  e380ae4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CommandExecutionType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> f03d8ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  5afaba8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
>  bbdb808 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  7659a23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
>  c9ab6f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactory.java
>  625b168 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactoryImpl.java
>  5ca4d88 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  091c6d9 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c2c965d 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c17e1a 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  b2eb738 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
>  d38108f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  4f2580a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
>  2ccbcda 
>   
> 

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

[Alejandro Fernandez]

> On Oct. 8, 2016, 12:02 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml, 
> > line 26
> > 
> >
> > Are these components going to be supported in Rolling/Express Upgrade?
> > If so, will need to add support in hdp-select and conf-select and set 
> > versionAdvertised to true. Can create a separate Jira for this work.
> 
> Nishant Bangarwa wrote:
> yes, these will be supporting rolling/express upgrades in future. 
> created - https://issues.apache.org/jira/browse/AMBARI-18570

Is integration with hdp-select and conf-select already present? Will RU/EU be 
supported in this release, e.g., HDP 2.6?


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151901
---


On Oct. 11, 2016, 2:44 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 11, 2016, 2:44 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 

Re: Review Request 52736: AMBARI-18567 Cannot start Oozie if WebHDFS is disabled

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52736/#review152164
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 11, 2016, 11:03 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52736/
> ---
> 
> (Updated Oct. 11, 2016, 11:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Laszlo 
> Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18567
> https://issues.apache.org/jira/browse/AMBARI-18567
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added missing import
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  a5bd59d 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> 2a512f4 
> 
> Diff: https://reviews.apache.org/r/52736/diff/
> 
> 
> Testing
> ---
> 
> Unit test:
> 
> ```
> $ mvn -pl ambari-server -am -DskipSurefireTests 
> -Dpython.test.mask=test_oozie_server.py test
> ...
> Total run:18
> Total errors:0
> Total failures:0
> ```
> 
> Manual test:
> 
> * install cluster via wizard (tested with HDP 2.4)
> * select Oozie and dependencies
> * disable WebHDFS
> * verify Oozie start succeeds
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52419/#review152157
---


Ship it!




Ship It!

- Sandor Magyari


On Oct. 11, 2016, 4:38 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52419/
> ---
> 
> (Updated Oct. 11, 2016, 4:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Balázs Bence Sári, Laszlo 
> Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18504
> https://issues.apache.org/jira/browse/AMBARI-18504
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XSLT transformation should be applied only to `*.xml`.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d3ec9ad 
> 
> Diff: https://reviews.apache.org/r/52419/diff/
> 
> 
> Testing
> ---
> 
> ```
> $ mvn -pl ambari-server -DskipTests clean verify
> ...
> [INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
> [INFO] Transforming file: 
> /Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
> [INFO] Transformed 1 file(s).
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ...
> $ ls -1 ambari-server/target/findbugs/
> findbugsXml.html
> findbugsXml.xml
> $ mvn -pl ambari-server -DskipTests verify
> ...
> [INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
> [INFO] Transforming file: 
> /Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
> [INFO] Transformed 1 file(s).
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ...
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52419/#review152155
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 11, 2016, 6:38 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52419/
> ---
> 
> (Updated Oct. 11, 2016, 6:38 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Balázs Bence Sári, Laszlo 
> Puskas, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18504
> https://issues.apache.org/jira/browse/AMBARI-18504
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> XSLT transformation should be applied only to `*.xml`.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d3ec9ad 
> 
> Diff: https://reviews.apache.org/r/52419/diff/
> 
> 
> Testing
> ---
> 
> ```
> $ mvn -pl ambari-server -DskipTests clean verify
> ...
> [INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
> [INFO] Transforming file: 
> /Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
> [INFO] Transformed 1 file(s).
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ...
> $ ls -1 ambari-server/target/findbugs/
> findbugsXml.html
> findbugsXml.xml
> $ mvn -pl ambari-server -DskipTests verify
> ...
> [INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
> [INFO] Transforming file: 
> /Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
> [INFO] Transformed 1 file(s).
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> ...
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

[Slim Bouguerra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review152150
---




ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
 (line 89)


this is not used thought we can remove it i guess



ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
 (line 37)


this is using curl which means it will fail if curl is not installed or 
part of the bin path.
Not an issue but it will be better to use python http clients.


- Slim Bouguerra


On Oct. 11, 2016, 2:44 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 11, 2016, 2:44 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 
>

Re: Review Request 52419: AMBARI-18504 Build fails at verify step due to leftover findbugs html file

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52419/
---

(Updated Oct. 11, 2016, 6:37 p.m.)


Review request for Ambari, Alejandro Fernandez, Balázs Bence Sári, Laszlo 
Puskas, Sumit Mohanty, and Sebastian Toader.


Changes
---

Backward compatible with Maven 3.0.5


Bugs: AMBARI-18504
https://issues.apache.org/jira/browse/AMBARI-18504


Repository: ambari


Description
---

XSLT transformation should be applied only to `*.xml`.


Diffs (updated)
-

  ambari-server/pom.xml d3ec9ad 

Diff: https://reviews.apache.org/r/52419/diff/


Testing
---

```
$ mvn -pl ambari-server -DskipTests clean verify
...
[INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
[INFO] Transforming file: 
/Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
[INFO] Transformed 1 file(s).
[INFO] 
[INFO] BUILD SUCCESS
...
$ ls -1 ambari-server/target/findbugs/
findbugsXml.html
findbugsXml.xml
$ mvn -pl ambari-server -DskipTests verify
...
[INFO] --- xml-maven-plugin:1.0:transform (default) @ ambari-server ---
[INFO] Transforming file: 
/Users/adoroszlai/src/ambari/ambari-server/target/findbugs/findbugsXml.xml
[INFO] Transformed 1 file(s).
[INFO] 
[INFO] BUILD SUCCESS
...
```


Thanks,

Attila Doroszlai

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

[Nishant Bangarwa]

> On Oct. 8, 2016, 12:02 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml, 
> > line 26
> > 
> >
> > Are these components going to be supported in Rolling/Express Upgrade?
> > If so, will need to add support in hdp-select and conf-select and set 
> > versionAdvertised to true. Can create a separate Jira for this work.

yes, these will be supporting rolling/express upgrades in future. 
created - https://issues.apache.org/jira/browse/AMBARI-18570


- Nishant


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151901
---


On Oct. 11, 2016, 2:44 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 11, 2016, 2:44 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 
>

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

[Nishant Bangarwa]

> On Oct. 7, 2016, 10:39 p.m., Swapan Shridhar wrote:
> > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml,
> >  line 5
> > 
> >
> > 
> > for all configs for consistency.

setting it to add="false" for all configs as per @Alejandro comment below.


> On Oct. 7, 2016, 10:39 p.m., Swapan Shridhar wrote:
> > ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml, 
> > line 107
> > 
> >
> > I assume HDFS is not always required as S3 was also an option.

correct.


- Nishant


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/#review151889
---


On Oct. 11, 2016, 2:44 p.m., Nishant Bangarwa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50803/
> ---
> 
> (Updated Oct. 11, 2016, 2:44 p.m.)
> 
> 
> Review request for Ambari, Renjith Kamath and Swapan Shridhar.
> 
> 
> Bugs: Ambari-19781
> https://issues.apache.org/jira/browse/Ambari-19781
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Defines Druid as a new service in HDP 2.6
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 1f722dc 
> 
> Diff: https://reviews.apache.org/r/50803/diff/
> 
> 
> Testing
> ---
> 
> Tested it locally by installing ambari and adding the newly added resources. 
> Was able to install druid and start all newly added services.
> 
> 
> Thanks,
> 
> Nishant Bangarwa
> 
>

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

[Nishant Bangarwa]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50803/
---

(Updated Oct. 11, 2016, 2:44 p.m.)


Review request for Ambari, Renjith Kamath and Swapan Shridhar.


Changes
---

Handle review comments and reformat files.


Bugs: Ambari-19781
https://issues.apache.org/jira/browse/Ambari-19781


Repository: ambari


Description
---

Defines Druid as a new service in HDP 2.6


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-coordinator.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-historical.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-logrotate.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-middlemanager.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-overlord.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-router.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/DRUID/0.9.2/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/broker.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/coordinator.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/druid_node.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/historical.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/middlemanager.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/overlord.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/router.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/quicklinks/quicklinks.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/DRUID/0.9.2/themes/theme.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/role_command_order.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/DRUID/metainfo.xml 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
1f722dc 

Diff: https://reviews.apache.org/r/50803/diff/


Testing
---

Tested it locally by installing ambari and adding the newly added resources. 
Was able to install druid and start all newly added services.


Thanks,

Nishant Bangarwa

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52691/
---

(Updated Oct. 11, 2016, 2:41 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo Puskas, 
Nate Cole, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-18553
https://issues.apache.org/jira/browse/AMBARI-18553


Repository: ambari


Description
---

Today, the START commands stored in role_command_orders table are bound to 
multiple stages created based on dependencies between components - a component 
in the second stage can only begin its START after the entire first stage is 
done as opposed to just its dependencies in the first stage. This eventually 
increases the overall blueprint deployment time.
The goal is to be able to configure a direct dependency based execution model 
of commands, for now only for Blueprint based deployment commands.

Implementation:
---
When creating stages we set the commandExecutionType to RoleGraph. In case 
commandExecutionType is set to DEPENDENCY_ORDERED there's only one stage 
created. commandExecutionType is persisted into Stage object / entity as well, 
so ActionScheduler can decide based on commandExecutionType how to execute the 
stage. In case commandExecutionType is set to DEPENDENCY_ORDERED it will filter 
out commands having dependencies on other commands IN_PROGRESS. By default 
commandExecutionType is STAGE_BASED which works as before, creating one or more 
stages dependening on dependecies.
DEPENDENCY_ORDERED commandExecutionType is set only in case of START commands 
initiated by Blueprint deployment and if Ambari property 
server.stage.command.execution_type = DEPENDENCY_ORDERED.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 e380ae4 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CommandExecutionType.java
 PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
f03d8ea 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2e850ef 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 1fc9dbf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 5afaba8 
  
ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
 bbdb808 
  
ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrderProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
 7659a23 
  
ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
 c9ab6f9 
  
ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactory.java
 625b168 
  
ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactoryImpl.java
 5ca4d88 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 091c6d9 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c2c965d 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1c17e1a 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 b2eb738 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
 d38108f 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
 4f2580a 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
 2ccbcda 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
 d96e7b5 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewURLResourceProviderTest.java
 e223d0f 
  
ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleCommandOrderTest.java
 a03f05b 
  
ambari-server/src/test/java/org/apache/ambari/server/metadata/RoleGraphTest.java
 8bead43 
  
ambari-server/src/test/java/org/apache/ambari/server/stageplanner/TestStagePlanner.java
 d26816c 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java
 2aaa2cf 

Diff: https://reviews.apache.org/r/52691/diff/


Testing
---

UT in progress.
Tested with manual cluster deployments.


Thanks,

Sandor Magyari

Re: Review Request 52736: AMBARI-18567 Cannot start Oozie if WebHDFS is disabled

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52736/#review152126
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 11, 2016, 1:03 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52736/
> ---
> 
> (Updated Oct. 11, 2016, 1:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Laszlo 
> Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18567
> https://issues.apache.org/jira/browse/AMBARI-18567
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added missing import
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  a5bd59d 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> 2a512f4 
> 
> Diff: https://reviews.apache.org/r/52736/diff/
> 
> 
> Testing
> ---
> 
> Unit test:
> 
> ```
> $ mvn -pl ambari-server -am -DskipSurefireTests 
> -Dpython.test.mask=test_oozie_server.py test
> ...
> Total run:18
> Total errors:0
> Total failures:0
> ```
> 
> Manual test:
> 
> * install cluster via wizard (tested with HDP 2.4)
> * select Oozie and dependencies
> * disable WebHDFS
> * verify Oozie start succeeds
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 52736: AMBARI-18567 Cannot start Oozie if WebHDFS is disabled

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52736/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Laszlo Puskas, 
and Sebastian Toader.


Bugs: AMBARI-18567
https://issues.apache.org/jira/browse/AMBARI-18567


Repository: ambari


Description
---

Added missing import


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 a5bd59d 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 2a512f4 

Diff: https://reviews.apache.org/r/52736/diff/


Testing
---

Unit test:

```
$ mvn -pl ambari-server -am -DskipSurefireTests 
-Dpython.test.mask=test_oozie_server.py test
...
Total run:18
Total errors:0
Total failures:0
```

Manual test:

* install cluster via wizard (tested with HDP 2.4)
* select Oozie and dependencies
* disable WebHDFS
* verify Oozie start succeeds


Thanks,

Attila Doroszlai