Re: Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/#review154097 ---

Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

2016-10-27 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53104/#review154096 --- Ship it! Ship It! - Di Li On Oct. 27, 2016, 9:20 p.m.,

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

2016-10-27 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/#review154095 ---

Review Request 53251: Upgrade Orchestration Groups And Stages Should Be Conditionally Controlled

2016-10-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53251/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-18726

Re: Review Request 53200: AMBARI-18686 - Falcon user shouldn't be added to Oozie admin list if Falcon is not installed

2016-10-27 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53200/#review154094 --- Ship it! Ship It! - Di Li On Oct. 26, 2016, 6:27 p.m., Tim

Re: Review Request 53244: AMBARI-18724. Add dependency of HSI config 'hive.llap.zk.sm.connectionString' on 'enable_hive_interactive', so as to cover the HDP 2.4 -> 2.5 upgrade case, to get 'hive.llap.

2016-10-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53244/#review154081 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 27, 2016,

Re: Review Request 53248: AMBARI-18694. DataNode JVM heap settings should include CMSInitiatingOccupancy

2016-10-27 Thread XIAOBING ZHOU
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53248/ --- (Updated Oct. 27, 2016, 11:20 p.m.) Review request for Ambari and Jaimin

Re: Review Request 53178: AMBARI-18696 - Add Hive View Links to Hive Summary Page

2016-10-27 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53178/#review154074 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 27, 2016, 10:58

Re: Review Request 53178: AMBARI-18696 - Add Hive View Links to Hive Summary Page

2016-10-27 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53178/ --- (Updated Oct. 27, 2016, 10:58 p.m.) Review request for Ambari, Jaimin Jetly,

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

2016-10-27 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53216/ --- (Updated Oct. 27, 2016, 3:43 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

2016-10-27 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/ --- (Updated Oct. 27, 2016, 9:56 p.m.) Review request for Ambari, Di Li, DIPAYAN

Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

2016-10-27 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53104/ --- (Updated Oct. 27, 2016, 9:20 p.m.) Review request for Ambari, Di Li, DIPAYAN

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

2016-10-27 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53143/ --- (Updated Oct. 27, 2016, 8:24 p.m.) Review request for Ambari, Di Li, DIPAYAN

Re: Review Request 53126: Workflow Designer View: When you execute a workflow designer view instance, it does not load immediately unless you return to the dashboard.

2016-10-27 Thread Anita Jebaraj
> On Oct. 27, 2016, 6:49 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! > > Anita Jebaraj wrote: > Hi Dipayan, Can you please help in pushing the code. This is an isolated > change and hence wont impact the changes from Ambari-18691 > > DIPAYAN BHOWMICK wrote: > Done, have committed to

Re: Review Request 53126: Workflow Designer View: When you execute a workflow designer view instance, it does not load immediately unless you return to the dashboard.

2016-10-27 Thread DIPAYAN BHOWMICK
> On Oct. 27, 2016, 6:49 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! > > Anita Jebaraj wrote: > Hi Dipayan, Can you please help in pushing the code. This is an isolated > change and hence wont impact the changes from Ambari-18691 Done, have committed to trunk, branch-2.4 and branch-2.5.

Re: Review Request 53126: Workflow Designer View: When you execute a workflow designer view instance, it does not load immediately unless you return to the dashboard.

2016-10-27 Thread Anita Jebaraj
> On Oct. 27, 2016, 6:49 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Hi Dipayan, Can you please help in pushing the code. This is an isolated change and hence wont impact the changes from Ambari-18691 - Anita --- This is an

Re: Review Request 53126: Workflow Designer View: When you execute a workflow designer view instance, it does not load immediately unless you return to the dashboard.

2016-10-27 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53126/#review154063 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Oct. 27, 2016, 6:39

Re: Review Request 53126: Workflow Designer View: When you execute a workflow designer view instance, it does not load immediately unless you return to the dashboard.

2016-10-27 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53126/ --- (Updated Oct. 27, 2016, 6:39 p.m.) Review request for Ambari, Di Li, DIPAYAN

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

2016-10-27 Thread Nahappan Somasundaram
> On Oct. 27, 2016, 10:37 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java, > > line 361 > > > > > > Always good to update the reference to the entity

Re: Review Request 53211: Ranger Audit Handler not working as expected as NN HA wizard does not set a few properties correctly

2016-10-27 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53211/#review154056 ---

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

2016-10-27 Thread Jonathan Hurley
> On Oct. 27, 2016, 1:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java, > > line 361 > > > > > > Always good to update the reference to the entity

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

2016-10-27 Thread Nahappan Somasundaram
> On Oct. 27, 2016, 10:09 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java, > > lines 70-74 > > > > > > Do we need both? I don't see any

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

2016-10-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53216/#review154051 --- Is there upgrade catalog work for the new fields?

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

2016-10-27 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53216/#review154046 --- Fix it, then Ship it!

Re: Review Request 53216: AMBARI-18711: Ambari-server: DB changes to enable/disable credential store support

2016-10-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53216/#review154040 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 27, 2016,

Re: Review Request 53228: AMBARI-18702 Fix typos

2016-10-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53228/#review154038 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 27, 2016,

Re: Review Request 53222: Move HDFS, HBASE YARN, GANGLIA, OOZIE RCO from stack to service level

2016-10-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53222/#review154036 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 27, 2016,

Re: Review Request 53221: Move ZOOKEEPER, KAFKA, STORM, RANGER, RANGER_KMS, AMS, KERBEROS role command orders from stack to service definition

2016-10-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53221/#review154035 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 27, 2016,

Re: Review Request 53228: AMBARI-18702 Fix typos

2016-10-27 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53228/#review154032 --- Ship it! Ship It! - Balázs Bence Sári On Oct. 27, 2016,

Re: Review Request 53182: Zeppelin fails to start after deployment due to timing issue

2016-10-27 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53182/#review154026 ---

Re: Review Request 53182: Zeppelin fails to start after deployment due to timing issue

2016-10-27 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53182/#review154027 --- Ship it! Ship It! - Sumit Mohanty On Oct. 27, 2016, 11:19

Re: Review Request 53228: AMBARI-18702 Fix typos

2016-10-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53228/#review154025 --- Ship it! Ship It! - Laszlo Puskas On Oct. 27, 2016, 2:49

Review Request 53228: AMBARI-18702 Fix typos

2016-10-27 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53228/ --- Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, and Sandor Magyari.

Re: Review Request 53228: AMBARI-18702 Fix typos

2016-10-27 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53228/#review154023 --- Ship it! Ship It! - Sandor Magyari On Oct. 27, 2016, 2:49

Re: Review Request 53220: Move HIVE, PIG, SPARK, SPARK2, SLIDER, SQOOP, ACCUMULO, FALCON, KNOX, , MAHOUT, TEZ role command orders from stack to service definitions

2016-10-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53220/#review154020 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 27, 2016,

Re: Review Request 53222: Move HDFS, HBASE YARN, GANGLIA, OOZIE RCO from stack to service level

2016-10-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53222/#review154018 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 27, 2016,

Re: Review Request 53221: Move ZOOKEEPER, KAFKA, STORM, RANGER, RANGER_KMS, AMS, KERBEROS role command orders from stack to service definition

2016-10-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53221/#review154019 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 27, 2016,

Re: Review Request 53220: Move HIVE, PIG, SPARK, SPARK2, SLIDER, SQOOP, ACCUMULO, FALCON, KNOX, , MAHOUT, TEZ role command orders from stack to service definitions

2016-10-27 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53220/#review154017 --- Ship it! Ship It! - Dmytro Sen On Окт. 27, 2016, 11:22

Re: Review Request 53221: Move ZOOKEEPER, KAFKA, STORM, RANGER, RANGER_KMS, AMS, KERBEROS role command orders from stack to service definition

2016-10-27 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53221/#review154016 --- Ship it! Ship It! - Dmytro Sen On Окт. 27, 2016, 11:23

Re: Review Request 53222: Move HDFS, HBASE YARN, GANGLIA, OOZIE RCO from stack to service level

2016-10-27 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53222/#review154015 --- Ship it! Ship It! - Dmytro Sen On Окт. 27, 2016, 11:24

Re: Review Request 53192: Create HOST_ORDERED Upgrade Pack

2016-10-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53192/#review154010 --- Ship it! We really need to rename NONROLLING - :) ... but

Review Request 53225: Python UT fail on trunk

2016-10-27 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53225/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18717

Re: Review Request 53087: Log Search schema meta data loader fix

2016-10-27 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53087/ --- (Updated Oct. 27, 2016, 1:14 p.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 53087: Log Search schema meta data loader fix

2016-10-27 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53087/ --- (Updated Oct. 27, 2016, 1:07 p.m.) Review request for Ambari, Oliver Szabo,

Review Request 53224: Logsearch metadata pattern for services

2016-10-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53224/ --- Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sebastian

Review Request 53222: Move HDFS, HBASE YARN, GANGLIA, OOZIE RCO from stack to service level

2016-10-27 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53222/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18716

Review Request 53221: Move ZOOKEEPER, KAFKA, STORM, RANGER, RANGER_KMS, AMS, KERBEROS role command orders from stack to service definition

2016-10-27 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53221/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18715

Review Request 53220: Move HIVE, PIG, SPARK, SPARK2, SLIDER, SQOOP, ACCUMULO, FALCON, KNOX, , MAHOUT, TEZ role command orders from stack to service definitions

2016-10-27 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53220/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18714

Re: Review Request 53182: Zeppelin fails to start after deployment due to timing issue

2016-10-27 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53182/ --- (Updated Oct. 27, 2016, 11:19 a.m.) Review request for Ambari, Alejandro

Re: Review Request 53129: AMBARI-18671 Ranger KMS should add proxy users for yarn and livy

2016-10-27 Thread Mugdha Varadkar
> On Oct. 26, 2016, 6:11 p.m., Alejandro Fernandez wrote: > > How will this impact existing clusters? Do they need to update these > > configs once they upgrade Ambari? What about when they upgrade the stack? For existing clusters this properties will be available as custom properties. After