Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-11-10 Thread yao lei
> On 十一月 10, 2016, 3:02 p.m., Jonathan Hurley wrote: > > What's the state of this review? Has it been abandoned? If so, can we close > > it? jhurley,thanks for your attention. There seem not have more feedbacks about this review request. If you are sure this funciton is repeated in new

Re: Review Request 53663: Add ability to add custom input descriptor to logfeeder

2016-11-10 Thread Oliver Szabo
> On Nov. 11, 2016, 1:05 a.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml, > > line 22 > > > > > > what happens if i

Re: Review Request 53663: Add ability to add custom input descriptor to logfeeder

2016-11-10 Thread Miklos Gergely
> On Nov. 11, 2016, 1:05 a.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, > > line 150 > > > > > > why add this is needed in this patch? > >

Re: Review Request 53663: Add ability to add custom input descriptor to logfeeder

2016-11-10 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53663/#review155679 ---

Review Request 53663: Add ability to add custom input descriptor to logfeeder

2016-11-10 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53663/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.

Review Request 53664: AMBARI-18855 - Manage JournalNode Wizard: While assigning new JournalNodes, Current JournalNode selection value changes

2016-11-10 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53664/ --- Review request for Ambari and Jaimin Jetly. Bugs: AMBARI-18855

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

2016-11-10 Thread Shi Wang
> On Nov. 10, 2016, 7:33 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py, > > line 79 > > > > > > Can you try to do "kdestroy" for webhcat

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

2016-11-10 Thread Shi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53629/ --- (Updated Nov. 10, 2016, 9:28 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

2016-11-10 Thread Shi Wang
> On Nov. 10, 2016, 12:14 p.m., Robert Levas wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/kerberos.json, > > line 59 > > > > > > You need to also edit the Kerberos descriptor file at >

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-11-10 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/#review155627 ---

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/ --- (Updated Nov. 10, 2016, 6:34 p.m.) Review request for Ambari, Alejandro

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/ --- (Updated Nov. 10, 2016, 6:27 p.m.) Review request for Ambari, Alejandro

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/ --- (Updated Nov. 10, 2016, 6:32 p.m.) Review request for Ambari, Alejandro

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
> On Nov. 10, 2016, 2:58 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 646 > > > > > > JavaDoc. Added. - Sid

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
> On Nov. 10, 2016, 2:58 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 170 > > > > > > Can we keep these the same name as before? > >

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-10 Thread Attila Doroszlai
> On Nov. 10, 2016, 5:18 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 1 > > > > > > I think if we want to change this, it should be

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-11-10 Thread Amruta Borkar
> On Nov. 10, 2016, 4:22 p.m., Nate Cole wrote: > > Ship It! Thank you Nate, could you please help me push the patch to trunk? I do not have that access. - Amruta --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Sid Wagle
> On Nov. 10, 2016, 2:58 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 170 > > > > > > Can we keep these the same name as before? Ok,

Re: Review Request 53651: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column

2016-11-10 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53651/#review155608 --- Ship it! Ship It! - Dmytro Sen On Ноя. 10, 2016, 4:23 п.п.,

Re: Review Request 53651: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column

2016-11-10 Thread Victor Galgo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53651/#review155605 --- Ship it! Ship It! - Victor Galgo On Nov. 10, 2016, 4:23

Review Request 53651: Ambari upgrade failed while running 'Alter Table blueprint' - blueprint_name column

2016-11-10 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53651/ --- Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Dmytro Sen, and

Re: Review Request 53650: Stack Versions page: fix styles

2016-11-10 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53650/#review155604 --- Ship it! Ship It! - Oleg Nechiporenko On Nov. 10, 2016,

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-11-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/#review155603 --- Ship it! Ship It! - Nate Cole On Nov. 1, 2016, 2:57 p.m.,

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155601 ---

Review Request 53650: Stack Versions page: fix styles

2016-11-10 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53650/ --- Review request for Ambari and Oleg Nechiporenko. Bugs: AMBARI-18849

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

2016-11-10 Thread Vishal Ghugare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52369/ --- (Updated Nov. 10, 2016, 7:35 a.m.) Review request for Ambari, Alejandro

Re: Review Request 53649: AMBARI-18838: Remove references to ganglias and nagios in Ambari agent source code

2016-11-10 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53649/#review155596 --- Ship it! Ship It! - Tim Thorpe On Nov. 10, 2016, 3:33 p.m.,

Re: Review Request 53649: AMBARI-18838: Remove references to ganglias and nagios in Ambari agent source code

2016-11-10 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53649/ --- (Updated Nov. 10, 2016, 3:33 p.m.) Review request for Ambari, Alejandro

Re: Review Request 53647: Issues after fast switching service page tabs

2016-11-10 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53647/ --- (Updated Ноя. 10, 2016, 3:21 п.п.) Review request for Ambari and Alexandr

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-11-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52183/#review155589 --- What's the state of this review? Has it been abandoned? If so,

Re: Review Request 53446: AMBARI-18793: Ambari-server: Support stack inheritance for credential store information

2016-11-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53446/#review155588 --- Ping. Can this review be closed now? - Jonathan Hurley On Nov.

Re: Review Request 53412: AMBARI-18778: Ambari-server: Blueprint enhancements to support enabling or disabling credential store

2016-11-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53412/#review155587 --- Ping. Can this review be closed now? - Jonathan Hurley On Nov.

Re: Review Request 53647: Issues after fast switching service page tabs

2016-11-10 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53647/#review155590 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 10, 2016,

Re: Review Request 53446: AMBARI-18793: Ambari-server: Support stack inheritance for credential store information

2016-11-10 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53446/#review155586 --- What's the status of this review? - Nate Cole On Nov. 3, 2016,

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review155585 --- Fix it, then Ship it!

Review Request 53647: Issues after fast switching service page tabs

2016-11-10 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53647/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-18847

Re: Review Request 53643: TestHeartbeatHandler.testRegistrationRecoveryConfig is Flaky

2016-11-10 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53643/#review155584 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 10, 2016,

Re: Review Request 53643: TestHeartbeatHandler.testRegistrationRecoveryConfig is Flaky

2016-11-10 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53643/#review155583 --- Ship it! Ship It! - Jonathan Hurley On Nov. 10, 2016, 7:52

Re: Review Request 53643: TestHeartbeatHandler.testRegistrationRecoveryConfig is Flaky

2016-11-10 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53643/#review155582 --- Ship it! Ship It! - Vitalyi Brodetskyi On Лис. 10, 2016,

Review Request 53643: TestHeartbeatHandler.testRegistrationRecoveryConfig is Flaky

2016-11-10 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53643/ --- Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Myroslav

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

2016-11-10 Thread Robert Levas
> On Nov. 10, 2016, 2:33 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py, > > line 79 > > > > > > Can you try to do "kdestroy" for webhcat

Re: Review Request 53629: AMBARI-18836 Remove group readable from hdfs headless keytab

2016-11-10 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53629/#review155569 ---

Re: Review Request 53642: Web Client Should Support HOST_ORDERED Upgrades In Progress

2016-11-10 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53642/#review155566 --- Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 10, 2016,

Review Request 53642: Web Client Should Support HOST_ORDERED Upgrades In Progress

2016-11-10 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53642/ --- Review request for Ambari and Aleksandr Kovalenko. Bugs: AMBARI-18844

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-10 Thread Attila Doroszlai
> On Nov. 10, 2016, 11:04 a.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 1 > > > > > > Add * to be consistent with the licensing

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-10 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155560 ---

Re: Review Request 53602: Ambari can autoformat NameNode in a production cluster

2016-11-10 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53602/ --- (Updated Nov. 10, 2016, 8:50 a.m.) Review request for Ambari, Dmitro