Re: Review Request 57494: Description incorrect for the method ExtensionModeule
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57494/ --- (Updated 三月 12, 2017, 2:21 a.m.) Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Dmytro Sen, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Vitalyi Brodetskyi. Summary (updated) - Description incorrect for the method ExtensionModeule Bugs: AMBARI-18259 https://issues.apache.org/jira/browse/AMBARI-18259 Repository: ambari Description --- ExtensionModeule's description is not corrent Diffs - ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java e3f8d0d Diff: https://reviews.apache.org/r/57494/diff/1/ Testing --- done it Thanks, zhangxiaolu zhangxiaolu
Re: Review Request 57493: Ambari Metrics Grafana Datasource plugin does not work when configured with a reverse proxy with subpath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57493/#review168713 --- Ship it! Ship It! - Prajwal Rao On March 10, 2017, 2:57 a.m., Yusaku Sako wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57493/ > --- > > (Updated March 10, 2017, 2:57 a.m.) > > > Review request for Ambari, Jaimin Jetly, Prajwal Rao, Richard Zang, and Vivek > Ratnavel Subramanian. > > > Bugs: AMBARI-20391 > https://issues.apache.org/jira/browse/AMBARI-20391 > > > Repository: ambari > > > Description > --- > > See https://issues.apache.org/jira/browse/AMBARI-20391 > > https://github.com/grafana/grafana/blob/v2.6.0/public/app/core/services/backend_srv.js#L68-L70 > was adding extra subpath even though the URL already contains it. The fix > was to use the backendSrv.datasourceRequest, and not use backendSrv.get > directly. > > > Diffs > - > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 3a0fb66 > > > Diff: https://reviews.apache.org/r/57493/diff/1/ > > > Testing > --- > > Tested manually with a reverse proxy with subpath configured per > http://docs.grafana.org/installation/behind_proxy/. > There are currently no unit tests covering the data source, so no tests are > included. > > > Thanks, > > Yusaku Sako > >
Re: Review Request 57537: AMBARI-20070. Agent heartbeat lost due to Popen race condition (multiprocessing)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57537/#review168712 --- Ship it! Ship It! - Sumit Mohanty On March 11, 2017, 7:07 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57537/ > --- > > (Updated March 11, 2017, 7:07 p.m.) > > > Review request for Ambari, Andrew Onischuk, Eugene Chekanskiy, Sandor > Magyari, and Sumit Mohanty. > > > Bugs: AMBARI-20070 > https://issues.apache.org/jira/browse/AMBARI-20070 > > > Repository: ambari > > > Description > --- > > Workaround for http://bugs.python.org/issue19809 when "master" process is > started via `multiprocessing` module. > > > Diffs > - > > ambari-agent/src/main/python/ambari_agent/main.py ddef473 > > > Diff: https://reviews.apache.org/r/57537/diff/1/ > > > Testing > --- > > Created cluster via blueprint, added services. > > > Thanks, > > Attila Doroszlai > >
Review Request 57537: AMBARI-20070. Agent heartbeat lost due to Popen race condition (multiprocessing)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57537/ --- Review request for Ambari, Andrew Onischuk, Eugene Chekanskiy, Sandor Magyari, and Sumit Mohanty. Bugs: AMBARI-20070 https://issues.apache.org/jira/browse/AMBARI-20070 Repository: ambari Description --- Workaround for http://bugs.python.org/issue19809 when "master" process is started via `multiprocessing` module. Diffs - ambari-agent/src/main/python/ambari_agent/main.py ddef473 Diff: https://reviews.apache.org/r/57537/diff/1/ Testing --- Created cluster via blueprint, added services. Thanks, Attila Doroszlai
Re: Review Request 57536: Restart of Spark2-client fails at setup_spark()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57536/#review168710 --- Ship it! Making this change will allow Ambari to produce the properties file - would it cause trouble when service read it - e.g. when Spark is starting? IOW, do they need to set something in the env file to be able to read UTF-8. - Sumit Mohanty On March 11, 2017, 11:43 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57536/ > --- > > (Updated March 11, 2017, 11:43 a.m.) > > > Review request for Ambari and Sumit Mohanty. > > > Bugs: AMBARI-20404 > https://issues.apache.org/jira/browse/AMBARI-20404 > > > Repository: ambari > > > Description > --- > > Scenario: > > * Added below configs to spark2 default > > > spark.io.encryption.enabled = true > spark.io.encryption.keySizeBits = 128 > spark.io.encryption.keygen.algorithm = HmacSHA1? > > * Restart affected services. > Spark2-client is failing to restart with below error. > > **stderr** > > > Traceback (most recent call last): > File > "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", > line 60, in > SparkClient().execute() > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 313, in execute > method(env) > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 721, in restart > self.install(env) > File > "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", > line 36, in install > self.configure(env) > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", > line 116, in locking_configure > original_configure(obj, *args, **kw) > File > "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", > line 42, in configure > setup_spark(env, 'client', upgrade_type=upgrade_type, action = > 'config') > File > "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py", > line 56, in setup_spark > mode=0644 > File > "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line > 155, in __init__ > self.env.run() > File > "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", > line 160, in run > self.run_action(resource, action) > File > "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", > line 124, in run_action > provider_action() > File > "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/properties_file.py", > line 54, in action_create > mode = self.resource.mode > File > "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line > 155, in __init__ > self.env.run() > File > "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", > line 160, in run > self.run_action(resource, action) > File > "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", > line 124, in run_action > provider_action() > File > "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", > line 123, in action_create > content = self._get_content() > File > "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", > line 160, in _get_content > return content() > File > "/usr/lib/python2.6/site-packages/resource_management/core/source.py", line > 52, in __call__ > return self.get_content() > File > "/usr/lib/python2.6/site-packages/resource_management/core/source.py", line > 143, in get_content > rendered = self.template.render(self.context) > File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", > line 891, in render > return self.environment.handle_exception(exc_info, True) > File "", line 3, in top-level template code > UnicodeEncodeError: 'ascii' codec can't encode character u'\u200b' in > position 8: ordinal not in range(128) > > > ambari-hash : d54803dd86c35f92637a978c58cf06818f8ca0d5 > > > Diffs > - > > > ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py > 3dd60e1 > ambari-common/src/main/python/resource_management/core/source.py e31f7d6 > > ambari-common/src/main/python/resource_management/libraries/providers/properties_file.py > 823f579 > >
Review Request 57536: Restart of Spark2-client fails at setup_spark()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57536/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-20404 https://issues.apache.org/jira/browse/AMBARI-20404 Repository: ambari Description --- Scenario: * Added below configs to spark2 default spark.io.encryption.enabled = true spark.io.encryption.keySizeBits = 128 spark.io.encryption.keygen.algorithm = HmacSHA1? * Restart affected services. Spark2-client is failing to restart with below error. **stderr** Traceback (most recent call last): File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 60, in SparkClient().execute() File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 313, in execute method(env) File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 721, in restart self.install(env) File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 36, in install self.configure(env) File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 116, in locking_configure original_configure(obj, *args, **kw) File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 42, in configure setup_spark(env, 'client', upgrade_type=upgrade_type, action = 'config') File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py", line 56, in setup_spark mode=0644 File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 155, in __init__ self.env.run() File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 160, in run self.run_action(resource, action) File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 124, in run_action provider_action() File "/usr/lib/python2.6/site-packages/resource_management/libraries/providers/properties_file.py", line 54, in action_create mode = self.resource.mode File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", line 155, in __init__ self.env.run() File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 160, in run self.run_action(resource, action) File "/usr/lib/python2.6/site-packages/resource_management/core/environment.py", line 124, in run_action provider_action() File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 123, in action_create content = self._get_content() File "/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py", line 160, in _get_content return content() File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", line 52, in __call__ return self.get_content() File "/usr/lib/python2.6/site-packages/resource_management/core/source.py", line 143, in get_content rendered = self.template.render(self.context) File "/usr/lib/python2.6/site-packages/ambari_jinja2/environment.py", line 891, in render return self.environment.handle_exception(exc_info, True) File "", line 3, in top-level template code UnicodeEncodeError: 'ascii' codec can't encode character u'\u200b' in position 8: ordinal not in range(128) ambari-hash : d54803dd86c35f92637a978c58cf06818f8ca0d5 Diffs - ambari-agent/src/test/python/resource_management/TestPropertiesFileResource.py 3dd60e1 ambari-common/src/main/python/resource_management/core/source.py e31f7d6 ambari-common/src/main/python/resource_management/libraries/providers/properties_file.py 823f579 ambari-common/src/main/python/resource_management/libraries/providers/xml_config.py c885d6e ambari-common/src/main/python/resource_management/libraries/resources/properties_file.py 527b0f6 Diff: https://reviews.apache.org/r/57536/diff/1/ Testing --- mvn clean test Thanks, Andrew Onischuk
