Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57733/#review169311 --- Fix it, then Ship it! Ship It! ambari-server/src/main/java/or

Re: Review Request 57718: Duplicate entries in DB for auto__instance privileges upon Ambari server restart

2017-03-17 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57718/ --- (Updated March 17, 2017, 2:27 p.m.) Review request for Ambari, Attila Magyar, B

Re: Review Request 57579: AMBARI-20400 Yarn should not copy Tez and Slider tar ball if Tez and Sliders are not installed on the cluster

2017-03-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57579/#review169306 --- Ship it! Ship It! - Alejandro Fernandez On March 17, 2017, 1

Re: Review Request 57727: HDP 3.0 TP - create Service Advisor for Spark

2017-03-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57727/#review169305 --- Ship it! Ship It! - Alejandro Fernandez On March 17, 2017, 3

Re: Review Request 57704: HDP 3.0 support for Tez with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-03-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57704/#review169304 --- Ship it! Ship It! - Alejandro Fernandez On March 17, 2017, 1

Re: Review Request 57507: Diff tool shows additional line when comparing configs from custom config group

2017-03-17 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57507/#review169303 --- Ship it! Ship It! - Alexandr Antonenko On March 16, 2017, 12

Re: Review Request 57686: AMBARI-20472 MapRed History server start does not create directories in HDFS when WEBHDFS is disabled.

2017-03-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57686/#review169302 --- Ship it! Ship It! - Alejandro Fernandez On March 17, 2017, 2

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57733/ --- (Updated March 17, 2017, 5:45 p.m.) Review request for Ambari, Robert Levas, Sa

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57733/ --- (Updated March 17, 2017, 5:45 p.m.) Review request for Ambari, Robert Levas, Sa

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57733/ --- (Updated March 17, 2017, 5:10 p.m.) Review request for Ambari, Robert Levas, Sa

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57733/ --- (Updated March 17, 2017, 5:07 p.m.) Review request for Ambari, Robert Levas, Sa

Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57733/ --- Review request for Ambari, Robert Levas, Sandor Magyari, and Sebastian Toader.

Re: Review Request 57507: Diff tool shows additional line when comparing configs from custom config group

2017-03-17 Thread Jaimin Jetly
> On March 16, 2017, 8:26 p.m., Jaimin Jetly wrote: > > If there is no UX impact and patch has been tested to work e2e then please > > commit it. > > Oleg Nechiporenko wrote: > This patch just fix an issue with some "unknown" field that appears when > two version of not default config grou

Re: Review Request 57718: Duplicate entries in DB for auto__instance privileges upon Ambari server restart

2017-03-17 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57718/#review169291 --- Ship it! Ship It! - Attila Magyar On March 17, 2017, 10:46 a

Re: Review Request 57704: HDP 3.0 support for Tez with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-03-17 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57704/#review169289 --- Ship it! Ship It! - Dmytro Sen On Март 17, 2017, 1:07 п.п.,

Re: Review Request 57727: HDP 3.0 TP - create Service Advisor for Spark

2017-03-17 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57727/ --- (Updated Март 17, 2017, 3:03 п.п.) Review request for Ambari, Alejandro Fernand

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-17 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57709/#review169286 --- Ship it! Ship It! - Di Li On March 16, 2017, 10:40 p.m., Ani

Re: Review Request 57704: HDP 3.0 support for Tez with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-03-17 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57704/ --- (Updated Березень 17, 2017, 1:07 після полудня) Review request for Ambari, Alej

Re: Review Request 57579: AMBARI-20400 Yarn should not copy Tez and Slider tar ball if Tez and Sliders are not installed on the cluster

2017-03-17 Thread Di Li
> On March 15, 2017, 5:48 p.m., Alejandro Fernandez wrote: > > Can we do the same thing in all places where tarballs are copied. > > I know Hive attempts to copy sqoop tarball, but it can potentially fail if > > Sqoop is not installed as a service. > > > > Perhaps we should actually check the t

Re: Review Request 57579: AMBARI-20400 Yarn should not copy Tez and Slider tar ball if Tez and Sliders are not installed on the cluster

2017-03-17 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57579/ --- (Updated March 17, 2017, 12:53 p.m.) Review request for Ambari and Alejandro Fe

Review Request 57727: HDP 3.0 TP - create Service Advisor for Slider

2017-03-17 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57727/ --- Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi Brodetsky

Re: Review Request 57692: HDP 3.0 support for Spark with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-03-17 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57692/ --- (Updated Март 17, 2017, 11:25 д.п.) Review request for Ambari, Alejandro Fernan

Re: Review Request 57718: Duplicate entries in DB for auto__instance privileges upon Ambari server restart

2017-03-17 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57718/ --- (Updated March 17, 2017, 6:46 a.m.) Review request for Ambari, Attila Magyar, B

Re: Review Request 57718: Duplicate entries in DB for auto__instance privileges upon Ambari server restart

2017-03-17 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57718/#review169263 --- Ship it! Ship It! - Sebastian Toader On March 17, 2017, 3:18

Re: Review Request 57718: Duplicate entries in DB for auto__instance privileges upon Ambari server restart

2017-03-17 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57718/#review169260 --- ambari-server/src/main/java/org/apache/ambari/server/orm/entities

Re: Review Request 57507: Diff tool shows additional line when comparing configs from custom config group

2017-03-17 Thread Oleg Nechiporenko
> On March 16, 2017, 8:26 p.m., Jaimin Jetly wrote: > > If there is no UX impact and patch has been tested to work e2e then please > > commit it. This patch just fix an issue with some "unknown" field that appears when two version of not default config group are compared. IDK what UX impact it

Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

2017-03-17 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57721/ --- Review request for Ambari, Andrii Babiichuk, Alexandr Antonenko, Oleg Nechiporen