Re: Review Request 57813: Service quick links not showing up in the UI

2017-03-21 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57813/#review169607
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 21, 2017, 5:34 p.m., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57813/
> ---
> 
> (Updated March 21, 2017, 5:34 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-20521
> https://issues.apache.org/jira/browse/AMBARI-20521
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with 
> master components hosted on 64 separate hosts)
> Navigate to any service on ambari-web that has quicklinks
> Actual Result: Quick links are incorrectly absent
> Expected Result: Quick links should be shown
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/ajax/ajax.js b856e44 
>   ambari-web/test/utils/ajax/ajax_test.js 35de05f 
> 
> 
> Diff: https://reviews.apache.org/r/57813/diff/1/
> 
> 
> Testing
> ---
> 
> 30380 passing (38s)
> 157 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

2017-03-21 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/#review169605
---




ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
Line 164 (original), 164 (patched)


Is this meant to affect existing installs that just upgrade Ambari, or 
clusters that upgrade their stack to a specific version?


- Alejandro Fernandez


On March 21, 2017, 3:23 p.m., Vishal Suvagia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57809/
> ---
> 
> (Updated March 21, 2017, 3:23 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan 
> Neethiraj, Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20505
> https://issues.apache.org/jira/browse/AMBARI-20505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently zookeeper connect/session timeout values for atlas are set to 
> 200/400 ms respectively which are very low and not practical/recommended 
> values. Due to this atlas startup fails more frequently.Below are recommended 
> configurations.
> 
> For Atlas:
> atlas.kafka.zookeeper.connection.timeout.ms=3
> atlas.kafka.zookeeper.session.timeout.ms=6
> atlas.audit.zookeeper.session.timeout.ms=6
> 
> For Zookeeper:
> tickTime=3000
> 
> As fresh installation scenario have already been fixed in AMBARI-19623, This 
> patch is to handle the EU and RU scenarios.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  e4fc3de 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
>  70af02c 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zoo.cfg.xml
>  5877877 
> 
> 
> Diff: https://reviews.apache.org/r/57809/diff/1/
> 
> 
> Testing
> ---
> 
> Verified install and upgrade on CentOS-6.
> 
> 
> Thanks,
> 
> Vishal Suvagia
> 
>

Re: Review Request 57813: Service quick links not showing up in the UI

2017-03-21 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57813/#review169600
---




ambari-web/app/utils/ajax/ajax.js
Line 3059 (original), 3060 (patched)


Although it does not have any impact in API response as of now but lets not 
append "fields" and "minimal_response" param in the data body also.



ambari-web/app/utils/ajax/ajax.js
Lines 3061-3063 (original), 3062-3066 (patched)


only if '' param is present in the url then lets append opt.url = 
'&_=' + App.datetime instead of '?_='


- Jaimin Jetly


On March 21, 2017, 5:34 p.m., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57813/
> ---
> 
> (Updated March 21, 2017, 5:34 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-20521
> https://issues.apache.org/jira/browse/AMBARI-20521
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with 
> master components hosted on 64 separate hosts)
> Navigate to any service on ambari-web that has quicklinks
> Actual Result: Quick links are incorrectly absent
> Expected Result: Quick links should be shown
> 
> 
> Diffs
> -
> 
>   ambari-web/app/utils/ajax/ajax.js b856e44 
>   ambari-web/test/utils/ajax/ajax_test.js 35de05f 
> 
> 
> Diff: https://reviews.apache.org/r/57813/diff/1/
> 
> 
> Testing
> ---
> 
> 30380 passing (38s)
> 157 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 57812: HDP 3.0 TP - create Service Advisor for Tez

2017-03-21 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57812/#review169593
---


Ship it!




Ship It!

- Swapan Shridhar


On March 21, 2017, 4:45 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57812/
> ---
> 
> (Updated March 21, 2017, 4:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-20520
> https://issues.apache.org/jira/browse/AMBARI-20520
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a Service Advisor script for Tez in HDP 3.0 Tech Preview.
> The Service Advisor must encapsulate all of the logic inherited/overwritten 
> from HDP 2.0.6 through HDP 2.6.
> In HDP 3.0, Tez will use the same binary/RPM for both batch and interactive 
> mode.
> However, batch and interactive will use different config files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
>  e831d14 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 0b81700 
> 
> 
> Diff: https://reviews.apache.org/r/57812/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 57813: Service quick links not showing up in the UI

2017-03-21 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57813/
---

Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly.


Bugs: AMBARI-20521
https://issues.apache.org/jira/browse/AMBARI-20521


Repository: ambari


Description
---

STR:
Create a Kafka cluster with Kafka brokers on 64 hosts (or any cluster with 
master components hosted on 64 separate hosts)
Navigate to any service on ambari-web that has quicklinks
Actual Result: Quick links are incorrectly absent
Expected Result: Quick links should be shown


Diffs
-

  ambari-web/app/utils/ajax/ajax.js b856e44 
  ambari-web/test/utils/ajax/ajax_test.js 35de05f 


Diff: https://reviews.apache.org/r/57813/diff/1/


Testing
---

30380 passing (38s)
157 pending


Thanks,

Andrii Tkach

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/#review169586
---


Ship it!




Ship It!

- Robert Levas


On March 21, 2017, 1:19 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57810/
> ---
> 
> (Updated March 21, 2017, 1:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20518
> https://issues.apache.org/jira/browse/AMBARI-20518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
> Kerberos Client command
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 555cf4d 
> 
> 
> Diff: https://reviews.apache.org/r/57810/diff/3/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/
---

(Updated Март 21, 2017, 5:19 п.п.)


Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20518
https://issues.apache.org/jira/browse/AMBARI-20518


Repository: ambari


Description
---

Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
Kerberos Client command


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
555cf4d 


Diff: https://reviews.apache.org/r/57810/diff/3/

Changes: https://reviews.apache.org/r/57810/diff/2-3/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/
---

(Updated Март 21, 2017, 5:17 п.п.)


Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20518
https://issues.apache.org/jira/browse/AMBARI-20518


Repository: ambari


Description
---

Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
Kerberos Client command


Diffs (updated)
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
555cf4d 


Diff: https://reviews.apache.org/r/57810/diff/2/

Changes: https://reviews.apache.org/r/57810/diff/1-2/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-21 Thread Anita Jebaraj 


> On March 21, 2017, 4:54 p.m., Alejandro Fernandez wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
> > Line 260 (original), 260 (patched)
> > 
> >
> > Good practice to always use braces.

I have fixed it in the updated patch


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review169577
---


On March 21, 2017, 5:15 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated March 21, 2017, 5:15 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta 
> Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-21 Thread Anita Jebaraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/
---

(Updated March 21, 2017, 5:15 p.m.)


Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta 
Ravindran.


Bugs: AMBARI-20334
https://issues.apache.org/jira/browse/AMBARI-20334


Repository: ambari


Description
---

capacity field in yarn queue manager should allow entering decimal numbers upto 
2 places,

currently the field allows entering values like

1.2.3
12...
1 2.3


Diffs (updated)
-

  
contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
 b6c419a 


Diff: https://reviews.apache.org/r/57709/diff/2/

Changes: https://reviews.apache.org/r/57709/diff/1-2/


Testing
---

Tested manually


Thanks,

Anita Jebaraj

Re: Review Request 57795: While generating hash for ambari-server to fill agent cache, all the symlinks should be traversed too.

2017-03-21 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57795/#review169578
---


Ship it!




Ship It!

- Jayush Luniya


On March 21, 2017, 12:27 a.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57795/
> ---
> 
> (Updated March 21, 2017, 12:27 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20512
> https://issues.apache.org/jira/browse/AMBARI-20512
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> the archive.zip and .hash is not getting generated on the server side when 
> the package folder is under
> stacks///services//package
> instead of common-services///package
> On closer look, the issue was that when the directories are being traversed 
> to look for hooks and package folders that need to be hashed/archived for 
> having it in the agent cache, those directories that were symlinks were being 
> skipped.
> Fix is to include them.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/resourceFilesKeeper.py baf8179 
> 
> 
> Diff: https://reviews.apache.org/r/57795/diff/2/
> 
> 
> Testing
> ---
> 
> Tested using a management pack
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-21 Thread Sangeeta Ravindran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review169575
---


Ship it!




Ship It!

- Sangeeta Ravindran


On March 16, 2017, 10:40 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated March 16, 2017, 10:40 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta 
> Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

2017-03-21 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57709/#review169577
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
Line 260 (original), 260 (patched)


Good practice to always use braces.


- Alejandro Fernandez


On March 16, 2017, 10:40 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57709/
> ---
> 
> (Updated March 16, 2017, 10:40 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, and Sangeeta 
> Ravindran.
> 
> 
> Bugs: AMBARI-20334
> https://issues.apache.org/jira/browse/AMBARI-20334
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> capacity field in yarn queue manager should allow entering decimal numbers 
> upto 2 places,
> 
> currently the field allows entering values like
> 
> 1.2.3
> 12...
> 1 2.3
> 
> 
> Diffs
> -
> 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js
>  b6c419a 
> 
> 
> Diff: https://reviews.apache.org/r/57709/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 57812: HDP 3.0 TP - create Service Advisor for Tez

2017-03-21 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57812/#review169576
---


Ship it!




Ship It!

- Alejandro Fernandez


On March 21, 2017, 4:45 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57812/
> ---
> 
> (Updated March 21, 2017, 4:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-20520
> https://issues.apache.org/jira/browse/AMBARI-20520
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a Service Advisor script for Tez in HDP 3.0 Tech Preview.
> The Service Advisor must encapsulate all of the logic inherited/overwritten 
> from HDP 2.0.6 through HDP 2.6.
> In HDP 3.0, Tez will use the same binary/RPM for both batch and interactive 
> mode.
> However, batch and interactive will use different config files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
>  e831d14 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 0b81700 
> 
> 
> Diff: https://reviews.apache.org/r/57812/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 57812: HDP 3.0 TP - create Service Advisor for Tez

2017-03-21 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57812/
---

Review request for Ambari, Alejandro Fernandez and Swapan Shridhar.


Bugs: AMBARI-20520
https://issues.apache.org/jira/browse/AMBARI-20520


Repository: ambari


Description
---

Create a Service Advisor script for Tez in HDP 3.0 Tech Preview.
The Service Advisor must encapsulate all of the logic inherited/overwritten 
from HDP 2.0.6 through HDP 2.6.
In HDP 3.0, Tez will use the same binary/RPM for both batch and interactive 
mode.
However, batch and interactive will use different config files.


Diffs
-

  
ambari-server/src/main/resources/common-services/TEZ/0.9.0.3.0/service_advisor.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 e831d14 
  ambari-server/src/main/resources/stacks/stack_advisor.py 0b81700 


Diff: https://reviews.apache.org/r/57812/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 57803: Link Log Feeder not working with Kerberos

2017-03-21 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57803/#review169569
---


Ship it!




Ship It!

- Robert Nettleton


On March 21, 2017, 9:59 a.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57803/
> ---
> 
> (Updated March 21, 2017, 9:59 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20515
> https://issues.apache.org/jira/browse/AMBARI-20515
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Feeder is not working properly if the cluster is kerberized, it can not 
> get the filter configuration from Solr.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  d584890 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  53cb6c0 
> 
> 
> Diff: https://reviews.apache.org/r/57803/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on openstack.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Robert Levas 


> On March 21, 2017, 12:18 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
> > Lines 499-503 (original), 499-503 (patched)
> > 
> >
> > What should `numbus.authorizer` be set to if security is enabled and 
> > the Ranger plug-in is not enabled?

Oops... I misread the code... but there is still no clause to support 
`rangerPluginEnabled` = `None` or `rangerPluginEnabled` = `''` - 
`rangerPluginEnabled` resolving to false.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/#review169567
---


On March 21, 2017, 11:52 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57810/
> ---
> 
> (Updated March 21, 2017, 11:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20518
> https://issues.apache.org/jira/browse/AMBARI-20518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
> Kerberos Client command
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 555cf4d 
> 
> 
> Diff: https://reviews.apache.org/r/57810/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/#review169567
---


Fix it, then Ship it!




Ship It!


ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
Lines 499-503 (original), 499-503 (patched)


What should `numbus.authorizer` be set to if security is enabled and the 
Ranger plug-in is not enabled?



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
Line 502 (original), 502 (patched)


Does `'No'.lower()` != `'no'`?


- Robert Levas


On March 21, 2017, 11:52 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57810/
> ---
> 
> (Updated March 21, 2017, 11:52 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20518
> https://issues.apache.org/jira/browse/AMBARI-20518
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
> Kerberos Client command
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 555cf4d 
> 
> 
> Diff: https://reviews.apache.org/r/57810/diff/1/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57810/
---

Review request for Ambari, Alejandro Fernandez, Robert Levas, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20518
https://issues.apache.org/jira/browse/AMBARI-20518


Repository: ambari


Description
---

Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test 
Kerberos Client command


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
555cf4d 


Diff: https://reviews.apache.org/r/57810/diff/1/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Review Request 57809: AMBARI-20505 : Changes needed to handle AMBARI-19623 in EU/RU scenario.

2017-03-21 Thread Vishal Suvagia via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57809/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj, 
Mugdha Varadkar, Oliver Szabo, and Sumit Mohanty.


Bugs: AMBARI-20505
https://issues.apache.org/jira/browse/AMBARI-20505


Repository: ambari


Description
---

Currently zookeeper connect/session timeout values for atlas are set to 200/400 
ms respectively which are very low and not practical/recommended values. Due to 
this atlas startup fails more frequently.Below are recommended configurations.

For Atlas:
atlas.kafka.zookeeper.connection.timeout.ms=3
atlas.kafka.zookeeper.session.timeout.ms=6
atlas.audit.zookeeper.session.timeout.ms=6

For Zookeeper:
tickTime=3000

As fresh installation scenario have already been fixed in AMBARI-19623, This 
patch is to handle the EU and RU scenarios.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 e4fc3de 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/configuration/application-properties.xml
 70af02c 
  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zoo.cfg.xml
 5877877 


Diff: https://reviews.apache.org/r/57809/diff/1/


Testing
---

Verified install and upgrade on CentOS-6.


Thanks,

Vishal Suvagia