Re: Review Request 58837: Convert all Ambari Views to use yarn package manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58837/ --- (Updated April 30, 2017, 6:16 p.m.) Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Changes --- Added --pure-lockfile option to yarn install, added yarn.lock file to yarn exclude list. Bugs: AMBARI-20885 https://issues.apache.org/jira/browse/AMBARI-20885 Repository: ambari Description --- Converted all Ambari Views to use yarn package manager with changes in pom.xml and package.json. Diffs (updated) - contrib/views/capacity-scheduler/pom.xml 7a65ffb contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION contrib/views/files/pom.xml 478a537 contrib/views/files/src/main/resources/ui/package.json 3f27897 contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION contrib/views/hawq/pom.xml 8089d68 contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION contrib/views/hive-next/pom.xml c0eb774 contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION contrib/views/hive20/pom.xml a583d23 contrib/views/hive20/src/main/resources/ui/package.json 0453a52 contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION contrib/views/hueambarimigration/pom.xml 30e7694 contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 09c3a27 contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION contrib/views/jobs/pom.xml 062f15f contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION contrib/views/pig/pom.xml d89d47e contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION contrib/views/pom.xml 6dcfce2 contrib/views/wfmanager/pom.xml 86c03f9 contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION Diff: https://reviews.apache.org/r/58837/diff/4/ Changes: https://reviews.apache.org/r/58837/diff/3-4/ Testing --- Manual testing done. Thanks, venkat sairam
Re: Review Request 58798: AMBARI-20873 : Atlas gc-worker logs are not generated due to incorrect configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58798/#review173452 --- Ship it! Ship It! - Gautam Borad On April 27, 2017, 2:39 p.m., Vishal Suvagia wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58798/ > --- > > (Updated April 27, 2017, 2:39 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan > Neethiraj, Mugdha Varadkar, and Sumit Mohanty. > > > Bugs: AMBARI-20873 > https://issues.apache.org/jira/browse/AMBARI-20873 > > > Repository: ambari > > > Description > --- > > Atlas gc-worker logs are not generated due to missing / in atlas > configurations. > Currently it is set as -Xloggc:$ATLAS_LOG_DIRgc-worker.log it should actually > be -Xloggc:$ATLAS_LOG_DIR/gc-worker.log > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml > bd0da9f > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml > 1c2ceff > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml > be8b750 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml > d822778 > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml > 210c4e2 > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml > 9a06dd0 > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml > f5d87e9 > > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml > f7c276b > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml > 81757c1 > > > Diff: https://reviews.apache.org/r/58798/diff/1/ > > > Testing > --- > > Verified fresh install and upgrade on Cent-OS 6. > > > Thanks, > > Vishal Suvagia > >
Re: Review Request 58876: Need to show data in sorted order in Hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58876/ --- (Updated April 30, 2017, 3:35 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-20139 https://issues.apache.org/jira/browse/AMBARI-20139 Repository: ambari Description --- Data is shown in the folowing way. Case 1: Tables list view in 'Query' Tab and 'Tables' tab Tables should be listed in alphabetical order Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess descending order makes sense. Case 3 : 'Saved Queries' and 'UDFs' tab Result should be sorted based on user action time. Recent action should come first. Case 4: 'Settings' tab : Lexicographical order based on KEY. Diffs (updated) - contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js be2771c contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js 72a83a3 contrib/views/hive20/src/main/resources/ui/app/controllers/savedqueries.js PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1 contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js e896348 contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9 contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs 338828e contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs c3f9c76 contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs ce7315f contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca Diff: https://reviews.apache.org/r/58876/diff/2/ Changes: https://reviews.apache.org/r/58876/diff/1-2/ Testing --- Manual testing done Thanks, venkat sairam
Re: Review Request 58876: Need to show data in sorted order in Hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58876/#review173448 --- Ship it! Ship It! - Nitiraj Rathore On April 30, 2017, 10:15 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58876/ > --- > > (Updated April 30, 2017, 10:15 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20139 > https://issues.apache.org/jira/browse/AMBARI-20139 > > > Repository: ambari > > > Description > --- > > Data is shown in the folowing way. > Case 1: Tables list view in 'Query' Tab and 'Tables' tab > Tables should be listed in alphabetical order > Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess > descending order makes sense. > Case 3 : 'Saved Queries' and 'UDFs' tab > Result should be sorted based on user action time. Recent action should come > first. > Case 4: 'Settings' tab : > Lexicographical order based on KEY. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js > be2771c > contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js > 72a83a3 > contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1 > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > e896348 > contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a > > contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs > 338828e > > contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs > c3f9c76 > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > ce7315f > contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca > > > Diff: https://reviews.apache.org/r/58876/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58877: hive view 2.0 : uploaded table does not contain any data.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58877/#review173447 --- Ship it! Ship It! - Gaurav Nagar On April 30, 2017, 1:26 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58877/ > --- > > (Updated April 30, 2017, 1:26 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20900 > https://issues.apache.org/jira/browse/AMBARI-20900 > > > Repository: ambari > > > Description > --- > > Semicolon was missing in the recently changed insert from query. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java > 19d4f06d71 > > > Diff: https://reviews.apache.org/r/58877/diff/1/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 58877: hive view 2.0 : uploaded table does not contain any data.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58877/#review173446 --- Ship it! Ship It! - venkat sairam On April 30, 2017, 1:26 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58877/ > --- > > (Updated April 30, 2017, 1:26 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20900 > https://issues.apache.org/jira/browse/AMBARI-20900 > > > Repository: ambari > > > Description > --- > > Semicolon was missing in the recently changed insert from query. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java > 19d4f06d71 > > > Diff: https://reviews.apache.org/r/58877/diff/1/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Review Request 58877: hive view 2.0 : uploaded table does not contain any data.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58877/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and venkat sairam. Bugs: AMBARI-20900 https://issues.apache.org/jira/browse/AMBARI-20900 Repository: ambari Description --- Semicolon was missing in the recently changed insert from query. Diffs - contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java 19d4f06d71 Diff: https://reviews.apache.org/r/58877/diff/1/ Testing --- manual testing done. Thanks, Nitiraj Rathore
Re: Review Request 58876: Need to show data in sorted order in Hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58876/#review173445 --- Ship it! Ship It! - Pallav Kulshreshtha On April 30, 2017, 10:15 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58876/ > --- > > (Updated April 30, 2017, 10:15 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20139 > https://issues.apache.org/jira/browse/AMBARI-20139 > > > Repository: ambari > > > Description > --- > > Data is shown in the folowing way. > Case 1: Tables list view in 'Query' Tab and 'Tables' tab > Tables should be listed in alphabetical order > Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess > descending order makes sense. > Case 3 : 'Saved Queries' and 'UDFs' tab > Result should be sorted based on user action time. Recent action should come > first. > Case 4: 'Settings' tab : > Lexicographical order based on KEY. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js > be2771c > contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js > 72a83a3 > contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1 > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > e896348 > contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a > > contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs > 338828e > > contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs > c3f9c76 > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > ce7315f > contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca > > > Diff: https://reviews.apache.org/r/58876/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Review Request 58876: Need to show data in sorted order in Hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58876/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-20139 https://issues.apache.org/jira/browse/AMBARI-20139 Repository: ambari Description --- Data is shown in the folowing way. Case 1: Tables list view in 'Query' Tab and 'Tables' tab Tables should be listed in alphabetical order Case 2: Jobs should be sorted based on Job Id in 'Jobs' tab. I guess descending order makes sense. Case 3 : 'Saved Queries' and 'UDFs' tab Result should be sorted based on user action time. Recent action should come first. Case 4: 'Settings' tab : Lexicographical order based on KEY. Diffs - contrib/views/hive20/src/main/resources/ui/app/components/jobs-browser.js be2771c contrib/views/hive20/src/main/resources/ui/app/components/setting-list.js 72a83a3 contrib/views/hive20/src/main/resources/ui/app/controllers/udfs.js dc99fd1 contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js e896348 contrib/views/hive20/src/main/resources/ui/app/routes/udfs.js 68e06a9 contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 766157a contrib/views/hive20/src/main/resources/ui/app/templates/components/jobs-browser.hbs 338828e contrib/views/hive20/src/main/resources/ui/app/templates/components/setting-list.hbs c3f9c76 contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs ce7315f contrib/views/hive20/src/main/resources/ui/app/templates/udfs.hbs f2efaca Diff: https://reviews.apache.org/r/58876/diff/1/ Testing --- Manual testing done Thanks, venkat sairam
Re: Review Request 58875: Ambari Header misaligned when transitioned to view route
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58875/#review173443 --- Ship it! Ship It! - Gaurav Nagar On April 30, 2017, 4:58 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58875/ > --- > > (Updated April 30, 2017, 4:58 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20899 > https://issues.apache.org/jira/browse/AMBARI-20899 > > > Repository: ambari > > > Description > --- > > minor css adjustments > > > Diffs > - > > ambari-web/app/styles/application.less 716e272 > ambari-web/app/styles/bootstrap_overrides.less 09e68b6 > > > Diff: https://reviews.apache.org/r/58875/diff/2/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 58875: Ambari Header misaligned when transitioned to view route
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58875/#review173442 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 30, 2017, 4:58 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58875/ > --- > > (Updated April 30, 2017, 4:58 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20899 > https://issues.apache.org/jira/browse/AMBARI-20899 > > > Repository: ambari > > > Description > --- > > minor css adjustments > > > Diffs > - > > ambari-web/app/styles/application.less 716e272 > ambari-web/app/styles/bootstrap_overrides.less 09e68b6 > > > Diff: https://reviews.apache.org/r/58875/diff/2/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 58875: Ambari Header misaligned when transitioned to view route
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58875/#review173441 --- Ship it! Ship It! - venkat sairam On April 30, 2017, 4:58 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58875/ > --- > > (Updated April 30, 2017, 4:58 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Rohit Choudhary, and venkat sairam. > > > Bugs: AMBARI-20899 > https://issues.apache.org/jira/browse/AMBARI-20899 > > > Repository: ambari > > > Description > --- > > minor css adjustments > > > Diffs > - > > ambari-web/app/styles/application.less 716e272 > ambari-web/app/styles/bootstrap_overrides.less 09e68b6 > > > Diff: https://reviews.apache.org/r/58875/diff/2/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 58837: Convert all Ambari Views to use yarn package manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58837/ --- (Updated April 30, 2017, 6:37 a.m.) Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary. Changes --- Added moment libabry ember-cli reference. Bugs: AMBARI-20885 https://issues.apache.org/jira/browse/AMBARI-20885 Repository: ambari Description --- Converted all Ambari Views to use yarn package manager with changes in pom.xml and package.json. Diffs (updated) - contrib/views/capacity-scheduler/pom.xml 7a65ffb contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock PRE-CREATION contrib/views/files/pom.xml 478a537 contrib/views/files/src/main/resources/ui/package.json 3f27897 contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION contrib/views/hawq/pom.xml 8089d68 contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION contrib/views/hive-next/pom.xml c0eb774 contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION contrib/views/hive20/pom.xml a583d23 contrib/views/hive20/src/main/resources/ui/package.json 0453a52 contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION contrib/views/hueambarimigration/pom.xml 30e7694 contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json 09c3a27 contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock PRE-CREATION contrib/views/jobs/pom.xml 062f15f contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION contrib/views/pig/pom.xml d89d47e contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION contrib/views/wfmanager/pom.xml 86c03f9 contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION Diff: https://reviews.apache.org/r/58837/diff/3/ Changes: https://reviews.apache.org/r/58837/diff/2-3/ Testing --- Manual testing done. Thanks, venkat sairam
