date:20170501

Re: Review Request 58911: HDP 3.0 TP - Unable to install Spark, cannot find package/scripts dir

2017-05-01 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58911/#review173552
---




ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/job_history_server.py
Lines 1 (patched)


Same files, just moved them inside a new package directory that was missing.


- Alejandro Fernandez


On May 2, 2017, 2:28 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58911/
> ---
> 
> (Updated May 2, 2017, 2:28 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20910
> https://issues.apache.org/jira/browse/AMBARI-20910
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> * Install Ambari 3.0 (last build was 650)
> * Install HDP 3.0 (last build is 197) with ZK, HDFS, YARN. Note: will fail on 
> RM and Service Checks.
> * Because Hive is not yet compiling, temporarily comment out Hive as a 
> required service for Spark, and HIVE_METASTORE as a required co-hosted 
> component.
> /var/lib/ambari-server/resources/common-services/SPARK/2.2.0/metainfo.xml
> * Restart Ambari Server
> * Attempt to add Spark as a service.
> 
> Error:
> ```
> Caught an exception while executing custom service command:  'exceptions.KeyError'>: 'service_package_folder'; 'service_package_folder'
> ```
> 
> This is coming from CustomServiceOrchestrator.py
> ```
> except Exception, e: # We do not want to let agent fail completely
>   exc_type, exc_obj, exc_tb = sys.exc_info()
>   message = "Caught an exception while executing "\
> "custom service command: {0}: {1}; {2}".format(exc_type, exc_obj, 
> str(e))
>   logger.exception(message)
> ```
> 
> Looks like Spark 2.2.0 doesn't have the package/scripts directory.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/job_history_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/setup_spark.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/spark_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/spark_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/spark_thrift_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/job_history_server.py
>  3937c88 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/livy_server.py
>  269c97d 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/livy_service.py
>  45201db 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/params.py
>  e60cab5 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/service_check.py
>  518c624 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/setup_livy.py
>  adaca87 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/setup_spark.py
>  9329ce0 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_client.py
>  3acde4e 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_service.py
>  536d798 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_thrift_server.py
>  8953b35 
>   
> ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/status_params.py
>  07dcc47 
> 
> 
> Diff: https://reviews.apache.org/r/58911/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test. Verified on a live cluster.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 58911: HDP 3.0 TP - Unable to install Spark, cannot find package/scripts dir

2017-05-01 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58911/
---

Review request for Ambari, Sumit Mohanty, Swapan Shridhar, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20910
https://issues.apache.org/jira/browse/AMBARI-20910


Repository: ambari


Description
---

STR:
* Install Ambari 3.0 (last build was 650)
* Install HDP 3.0 (last build is 197) with ZK, HDFS, YARN. Note: will fail on 
RM and Service Checks.
* Because Hive is not yet compiling, temporarily comment out Hive as a required 
service for Spark, and HIVE_METASTORE as a required co-hosted component.
/var/lib/ambari-server/resources/common-services/SPARK/2.2.0/metainfo.xml
* Restart Ambari Server
* Attempt to add Spark as a service.

Error:
```
Caught an exception while executing custom service command: : 'service_package_folder'; 'service_package_folder'
```

This is coming from CustomServiceOrchestrator.py
```
except Exception, e: # We do not want to let agent fail completely
  exc_type, exc_obj, exc_tb = sys.exc_info()
  message = "Caught an exception while executing "\
"custom service command: {0}: {1}; {2}".format(exc_type, exc_obj, 
str(e))
  logger.exception(message)
```

Looks like Spark 2.2.0 doesn't have the package/scripts directory.


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/job_history_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/livy_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/livy_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/setup_livy.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/setup_spark.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/spark_client.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/spark_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/spark_thrift_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/job_history_server.py
 3937c88 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/livy_server.py
 269c97d 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/livy_service.py
 45201db 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/params.py 
e60cab5 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/service_check.py
 518c624 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/setup_livy.py
 adaca87 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/setup_spark.py
 9329ce0 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_client.py
 3acde4e 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_service.py
 536d798 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/spark_thrift_server.py
 8953b35 
  
ambari-server/src/main/resources/common-services/SPARK/2.2.0/scripts/status_params.py
 07dcc47 


Diff: https://reviews.apache.org/r/58911/diff/1/


Testing
---

mvn clean test. Verified on a live cluster.


Thanks,

Alejandro Fernandez

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

2017-05-01 Thread Masahiro Tanaka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review173540
---



Could anyone review this?

- Masahiro Tanaka


On 4月 17, 2017, 9:40 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
> 
> (Updated 4月 17, 2017, 9:40 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though 
> I change the parameter, it looks like nothing has changed. I greped the 
> entire ambari source code, the parameter is not referenced.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
>  5f56617 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  4ed26f7 
> 
> 
> Diff: https://reviews.apache.org/r/57687/diff/3/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12863418/AMBARI-20443.3.patch
> against trunk revision .
> 
> +1 @author. The patch does not contain any @author tags.
> 
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> 
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> 
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> 
> +1 core tests. The patch passed unit tests in ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11398//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11398//console
> 
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 58756: Remove redundant whitespace in Hadoop 3.0 configs, enable ATS v2

2017-05-01 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58756/#review173523
---


Ship it!




Ship It!

- Sumit Mohanty


On April 27, 2017, 12:21 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58756/
> ---
> 
> (Updated April 27, 2017, 12:21 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20865
> https://issues.apache.org/jira/browse/AMBARI-20865
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove redundant leading whitespace in Hadoop 3.0 configs, especially in 
> config types like hadoop-env, yarn-eng, and the log4j ones.
> Enable ATS v2
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  e447c52 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml
>  5f6ec3f 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hcat-env.xml
>  964abdb 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  4ed26f7 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-env.xml
>  e2048a2 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml
>  5fb4732 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-log4j.xml
>  a200e74 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml
>  cc96cd7 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml
>  76dff64 
> 
> 
> Diff: https://reviews.apache.org/r/58756/diff/2/
> 
> 
> Testing
> ---
> 
> Python unit tests passed,
> 
> Ran 272 tests in 6.935s
> 
> OK
> --
> Total run:1169
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 58894: WFM: Include an option to clear filters in workflow dashboard

2017-05-01 Thread Anita Jebaraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58894/
---

Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya N, 
and Sangeeta Ravindran.


Bugs: AMBARI-20904
https://issues.apache.org/jira/browse/AMBARI-20904


Repository: ambari


Description
---

Currently the filters can be cleared only manually by removing the contents, 
having a button to clear the filters on one click would be helpful.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
 4bfb5fa 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs
 b9c6029 


Diff: https://reviews.apache.org/r/58894/diff/1/


Testing
---

Tested manually


File Attachments


ClearFilters
  
https://reviews.apache.org/media/uploaded/files/2017/05/01/2f817634-c9ed-46db-932a-41290fa9ebdc__ClearFilters.jpg


Thanks,

Anita Jebaraj

Re: Review Request 58429: After pam setup- Hive View user home test fails

2017-05-01 Thread Robert Levas



> On May 1, 2017, 4:09 p.m., Robert Levas wrote:
> > Ship It!
> 
> Anita Jebaraj wrote:
> Thank you Robert, can you please help in pushing the changes

Sure. On it now.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/#review173498
---


On May 1, 2017, 4 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58429/
> ---
> 
> (Updated May 1, 2017, 4 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Vishal Ghugare, Henning 
> Kropp, Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20760
> https://issues.apache.org/jira/browse/AMBARI-20760
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After setting up PAM, tried to login as PAM user and access hive view, user 
> home test fails with the error as in screen shot.
> 
> This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was 
> not incorporated in the code. Pasting the comment from Henning below.
> 
> Something we noticed is that in a secured cluster we have issues with the 
> views, getting the following exception for the Hive view as an example:
> 
> Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS, 
> infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to 
> validate proxy privilege of ambari for 
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
> .
> sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege 
> of ambari for 
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
>  serverProtocolVersion:null)
> 
> As you can see it tries to impersonte 
> "org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
>  Changing the UsernamePasswordAuthenticationToken from Principal to username 
> fixes this.
> 
> So instead of :
> 
> UsernamePasswordAuthenticationToken token = new 
> UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
> 
> We use:
> 
> UsernamePasswordAuthenticationToken token = new 
> UsernamePasswordAuthenticationToken(user.getUserName(), null, 
> userAuthorities);
> 
> What could potential also work is, overriding toString of the principal like:
> 
> Principal principal = new Principal() {
> @Override
> public String getName()
> { return user.getUserName(); }
> 
> @Override
> public String toString()
> { return user.getUserName().toString(); }
> 
> };
> 
> We did not test this!
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  ca7cd31 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  5b3acd0 
> 
> 
> Diff: https://reviews.apache.org/r/58429/diff/2/
> 
> 
> Testing
> ---
> 
> Ran mvn test and also manually tested the scenario
> 
> 
> File Attachments
> 
> 
> error screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58429: After pam setup- Hive View user home test fails

2017-05-01 Thread Anita Jebaraj



> On May 1, 2017, 8:09 p.m., Robert Levas wrote:
> > Ship It!

Thank you Robert, can you please help in pushing the changes


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/#review173498
---


On May 1, 2017, 8 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58429/
> ---
> 
> (Updated May 1, 2017, 8 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Vishal Ghugare, Henning 
> Kropp, Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20760
> https://issues.apache.org/jira/browse/AMBARI-20760
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After setting up PAM, tried to login as PAM user and access hive view, user 
> home test fails with the error as in screen shot.
> 
> This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was 
> not incorporated in the code. Pasting the comment from Henning below.
> 
> Something we noticed is that in a secured cluster we have issues with the 
> views, getting the following exception for the Hive view as an example:
> 
> Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS, 
> infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to 
> validate proxy privilege of ambari for 
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
> .
> sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege 
> of ambari for 
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
>  serverProtocolVersion:null)
> 
> As you can see it tries to impersonte 
> "org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
>  Changing the UsernamePasswordAuthenticationToken from Principal to username 
> fixes this.
> 
> So instead of :
> 
> UsernamePasswordAuthenticationToken token = new 
> UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
> 
> We use:
> 
> UsernamePasswordAuthenticationToken token = new 
> UsernamePasswordAuthenticationToken(user.getUserName(), null, 
> userAuthorities);
> 
> What could potential also work is, overriding toString of the principal like:
> 
> Principal principal = new Principal() {
> @Override
> public String getName()
> { return user.getUserName(); }
> 
> @Override
> public String toString()
> { return user.getUserName().toString(); }
> 
> };
> 
> We did not test this!
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  ca7cd31 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  5b3acd0 
> 
> 
> Diff: https://reviews.apache.org/r/58429/diff/2/
> 
> 
> Testing
> ---
> 
> Ran mvn test and also manually tested the scenario
> 
> 
> File Attachments
> 
> 
> error screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58429: After pam setup- Hive View user home test fails

2017-05-01 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/#review173498
---


Ship it!




Ship It!

- Robert Levas


On May 1, 2017, 4 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58429/
> ---
> 
> (Updated May 1, 2017, 4 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Vishal Ghugare, Henning 
> Kropp, Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20760
> https://issues.apache.org/jira/browse/AMBARI-20760
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After setting up PAM, tried to login as PAM user and access hive view, user 
> home test fails with the error as in screen shot.
> 
> This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was 
> not incorporated in the code. Pasting the comment from Henning below.
> 
> Something we noticed is that in a secured cluster we have issues with the 
> views, getting the following exception for the Hive view as an example:
> 
> Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS, 
> infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to 
> validate proxy privilege of ambari for 
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
> .
> sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege 
> of ambari for 
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
>  serverProtocolVersion:null)
> 
> As you can see it tries to impersonte 
> "org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
>  Changing the UsernamePasswordAuthenticationToken from Principal to username 
> fixes this.
> 
> So instead of :
> 
> UsernamePasswordAuthenticationToken token = new 
> UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
> 
> We use:
> 
> UsernamePasswordAuthenticationToken token = new 
> UsernamePasswordAuthenticationToken(user.getUserName(), null, 
> userAuthorities);
> 
> What could potential also work is, overriding toString of the principal like:
> 
> Principal principal = new Principal() {
> @Override
> public String getName()
> { return user.getUserName(); }
> 
> @Override
> public String toString()
> { return user.getUserName().toString(); }
> 
> };
> 
> We did not test this!
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  ca7cd31 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  5b3acd0 
> 
> 
> Diff: https://reviews.apache.org/r/58429/diff/2/
> 
> 
> Testing
> ---
> 
> Ran mvn test and also manually tested the scenario
> 
> 
> File Attachments
> 
> 
> error screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58429: After pam setup- Hive View user home test fails

2017-05-01 Thread Anita Jebaraj



> On April 28, 2017, 7 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
> > Line 128 (original), 127 (patched)
> > 
> >
> > Can you use 
> > `org.apache.ambari.server.security.authorization.AmbariUserAuthentication` 
> > to be more consistent with other Ambari-specific authentication providers.  
> > For example, 
> > `org.apache.ambari.server.security.authorization.AmbariLocalUserProvider`

Hi Robert, yes the authentication provider can be changed, please review the 
new patch


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/#review173365
---


On May 1, 2017, 8 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58429/
> ---
> 
> (Updated May 1, 2017, 8 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Di Li, Vishal Ghugare, Henning 
> Kropp, Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20760
> https://issues.apache.org/jira/browse/AMBARI-20760
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After setting up PAM, tried to login as PAM user and access hive view, user 
> home test fails with the error as in screen shot.
> 
> This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was 
> not incorporated in the code. Pasting the comment from Henning below.
> 
> Something we noticed is that in a secured cluster we have issues with the 
> views, getting the following exception for the Hive view as an example:
> 
> Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS, 
> infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to 
> validate proxy privilege of ambari for 
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
> .
> sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege 
> of ambari for 
> org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
>  serverProtocolVersion:null)
> 
> As you can see it tries to impersonte 
> "org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
>  Changing the UsernamePasswordAuthenticationToken from Principal to username 
> fixes this.
> 
> So instead of :
> 
> UsernamePasswordAuthenticationToken token = new 
> UsernamePasswordAuthenticationToken(principal, null, userAuthorities);
> 
> We use:
> 
> UsernamePasswordAuthenticationToken token = new 
> UsernamePasswordAuthenticationToken(user.getUserName(), null, 
> userAuthorities);
> 
> What could potential also work is, overriding toString of the principal like:
> 
> Principal principal = new Principal() {
> @Override
> public String getName()
> { return user.getUserName(); }
> 
> @Override
> public String toString()
> { return user.getUserName().toString(); }
> 
> };
> 
> We did not test this!
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  ca7cd31 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  5b3acd0 
> 
> 
> Diff: https://reviews.apache.org/r/58429/diff/2/
> 
> 
> Testing
> ---
> 
> Ran mvn test and also manually tested the scenario
> 
> 
> File Attachments
> 
> 
> error screenshot
>   
> https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 58429: After pam setup- Hive View user home test fails

2017-05-01 Thread Anita Jebaraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58429/
---

(Updated May 1, 2017, 8 p.m.)


Review request for Ambari, Attila Doroszlai, Di Li, Vishal Ghugare, Henning 
Kropp, Robert Levas, and Tim Thorpe.


Bugs: AMBARI-20760
https://issues.apache.org/jira/browse/AMBARI-20760


Repository: ambari


Description
---

After setting up PAM, tried to login as PAM user and access hive view, user 
home test fails with the error as in screen shot.

This issue was pointed out by Henning Kropp in the jira AMBARI-12263, but was 
not incorporated in the code. Pasting the comment from Henning below.

Something we noticed is that in a secured cluster we have issues with the 
views, getting the following exception for the Hive view as an example:

Struct:TOpenSessionResp(status:TStatus(statusCode:ERROR_STATUS, 
infoMessages:[*org.apache.hive.service.cli.HiveSQLException:Failed to validate 
proxy privilege of ambari for 
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32,
.
sqlState:08S01, errorCode:0, errorMessage:Failed to validate proxy privilege of 
ambari for 
org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459),
 serverProtocolVersion:null)

As you can see it tries to impersonte 
"org.apache.ambari.server.security.authorization.AmbariPamAuthenticationProvider$1@3459:33:32".
 Changing the UsernamePasswordAuthenticationToken from Principal to username 
fixes this.

So instead of :

UsernamePasswordAuthenticationToken token = new 
UsernamePasswordAuthenticationToken(principal, null, userAuthorities);

We use:

UsernamePasswordAuthenticationToken token = new 
UsernamePasswordAuthenticationToken(user.getUserName(), null, userAuthorities);

What could potential also work is, overriding toString of the principal like:

Principal principal = new Principal() {
@Override
public String getName()
{ return user.getUserName(); }

@Override
public String toString()
{ return user.getUserName().toString(); }

};

We did not test this!


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 ca7cd31 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
 5b3acd0 


Diff: https://reviews.apache.org/r/58429/diff/2/

Changes: https://reviews.apache.org/r/58429/diff/1-2/


Testing
---

Ran mvn test and also manually tested the scenario


File Attachments


error screenshot
  
https://reviews.apache.org/media/uploaded/files/2017/04/13/4a43b897-e030-41a7-b702-f711432b03b9__error.PNG


Thanks,

Anita Jebaraj

Re: Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)

2017-05-01 Thread DIPAYAN BHOWMICK


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58887/#review173496
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 1, 2017, 7:16 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58887/
> ---
> 
> (Updated May 1, 2017, 7:16 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20906
> https://issues.apache.org/jira/browse/AMBARI-20906
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> So from logs it looks like the problem happens when the "view directory 
> watcher" detects change in jar file tries to update the view.
> The solution to this is not with proof but a precautionary and preventive of 
> nature. 
> I have introduced a property "views.directory.watcher.disable" which can be 
> set to "true" to disable the View Directory Watcher.
> Disabling will help if ambari does not work fine even after restarts. Another 
> small change is that I have done the method in ViewRegistry to be 
> synchronized. This will remove cases if any where in the view gets 
> simultaneously updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  f01df9be7d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  e266dd5693 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 24eceb21c6 
> 
> 
> Diff: https://reviews.apache.org/r/58887/diff/1/
> 
> 
> Testing
> ---
> 
> Tests cases are clearing. And ambari is coming up properly.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58822: Add Log Level Filter to the Log Search config API

2017-05-01 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58822/#review173495
---


Ship it!




Ship It!

- Robert Nettleton


On April 28, 2017, 4:39 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58822/
> ---
> 
> (Updated April 28, 2017, 4:39 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20881
> https://issues.apache.org/jira/browse/AMBARI-20881
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Log Level Filters should be handled by the config API too
> 
> Also Log Level Filters should be per cluster, not only one for the Log Search 
> Server. This means that some UI modifications are also necessary in order to 
> query/persist changes of the log level filters for a specific cluster only.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-config-api/pom.xml e9abed0 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
>  df26920 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogLevelFilterMonitor.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
>  0bb0b78 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/loglevelfilter/LogLevelFilterMap.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
>  969eb30 
>   
> ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
>  664ecc9 
>   ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 4ed8eba 
>   
> ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
>  738fde2 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java
>  074fedb 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java
>  b70fbd1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FilterLogData.java
>  a05a916 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigFetcher.java
>  12c744c 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandler.java
>  0ece637 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilter.java
>  60c8ae8 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/LogFeederFilterWrapper.java
>  9199cd3 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/FilterLogData.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/loglevelfilter/LogLevelFilterHandler.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java
>  135fb32 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java
>  bb2f0a9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/logconfig/LogConfigHandlerTest.java
>  266108f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/resources/logfeeder.properties
>  59020cc 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java
>  c2d27f9 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  8fb27a7 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  00adb67 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java
>  c0c1167 
>   
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java
>  a60fc5c 
>   
>

Re: Review Request 58756: Remove redundant whitespace in Hadoop 3.0 configs, enable ATS v2

2017-05-01 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58756/#review173494
---


Ship it!




Ship It!

- Sid Wagle


On April 27, 2017, 12:21 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58756/
> ---
> 
> (Updated April 27, 2017, 12:21 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20865
> https://issues.apache.org/jira/browse/AMBARI-20865
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove redundant leading whitespace in Hadoop 3.0 configs, especially in 
> config types like hadoop-env, yarn-eng, and the log4j ones.
> Enable ATS v2
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hadoop-env.xml
>  e447c52 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/configuration/hdfs-log4j.xml
>  5f6ec3f 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hcat-env.xml
>  964abdb 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml
>  4ed26f7 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-interactive-env.xml
>  e2048a2 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-env.xml
>  5fb4732 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-log4j.xml
>  a200e74 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml
>  cc96cd7 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml
>  76dff64 
> 
> 
> Diff: https://reviews.apache.org/r/58756/diff/2/
> 
> 
> Testing
> ---
> 
> Python unit tests passed,
> 
> Ran 272 tests in 6.935s
> 
> OK
> --
> Total run:1169
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)

2017-05-01 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58887/#review173492
---


Ship it!




Ship It!

- Gaurav Nagar


On May 1, 2017, 7:16 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58887/
> ---
> 
> (Updated May 1, 2017, 7:16 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20906
> https://issues.apache.org/jira/browse/AMBARI-20906
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> So from logs it looks like the problem happens when the "view directory 
> watcher" detects change in jar file tries to update the view.
> The solution to this is not with proof but a precautionary and preventive of 
> nature. 
> I have introduced a property "views.directory.watcher.disable" which can be 
> set to "true" to disable the View Directory Watcher.
> Disabling will help if ambari does not work fine even after restarts. Another 
> small change is that I have done the method in ViewRegistry to be 
> synchronized. This will remove cases if any where in the view gets 
> simultaneously updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  f01df9be7d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  e266dd5693 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 24eceb21c6 
> 
> 
> Diff: https://reviews.apache.org/r/58887/diff/1/
> 
> 
> Testing
> ---
> 
> Tests cases are clearing. And ambari is coming up properly.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)

2017-05-01 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58887/
---

(Updated May 1, 2017, 7:16 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20906
https://issues.apache.org/jira/browse/AMBARI-20906


Repository: ambari


Description
---

So from logs it looks like the problem happens when the "view directory 
watcher" detects change in jar file tries to update the view.
The solution to this is not with proof but a precautionary and preventive of 
nature. 
I have introduced a property "views.directory.watcher.disable" which can be set 
to "true" to disable the View Directory Watcher.
Disabling will help if ambari does not work fine even after restarts. Another 
small change is that I have done the method in ViewRegistry to be synchronized. 
This will remove cases if any where in the view gets simultaneously updated.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 f01df9be7d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 e266dd5693 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
24eceb21c6 


Diff: https://reviews.apache.org/r/58887/diff/1/


Testing (updated)
---

Tests cases are clearing. And ambari is coming up properly.


Thanks,

Nitiraj Rathore

Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)

2017-05-01 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58887/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20906
https://issues.apache.org/jira/browse/AMBARI-20906


Repository: ambari


Description
---

So from logs it looks like the problem happens when the "view directory 
watcher" detects change in jar file tries to update the view.
The solution to this is not with proof but a precautionary and preventive of 
nature. 
I have introduced a property "views.directory.watcher.disable" which can be set 
to "true" to disable the View Directory Watcher.
Disabling will help if ambari does not work fine even after restarts. Another 
small change is that I have done the method in ViewRegistry to be synchronized. 
This will remove cases if any where in the view gets simultaneously updated.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 f01df9be7d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 e266dd5693 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
24eceb21c6 


Diff: https://reviews.apache.org/r/58887/diff/1/


Testing
---


Thanks,

Nitiraj Rathore

Re: Review Request 58886: Smartsense view do not load and shows blank

2017-05-01 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58886/#review173491
---




ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
Lines 1012 (patched)


I think, this will be called for each auto instance.
Shouldn't we call this before installAutoInstance, so that it will execute 
only once.



ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
Lines 1050 (patched)


You need to check if viewInstance's clusterType is LOCAL_AMBARI and Id's 
not contails in list.
Otherwise it will delete REMOTE_AMBARI configured instances.


- Gaurav Nagar


On May 1, 2017, 6:57 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58886/
> ---
> 
> (Updated May 1, 2017, 6:57 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, venkat sairam, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20905
> https://issues.apache.org/jira/browse/AMBARI-20905
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If installation fails and is retried the cluster id changes but some view 
> instances keep older cluster ids which stop views from being displayed later 
> on.
> remove the view instances which contains invalid cluster id before creating 
> any autoview instance.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java
>  061c7223d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  b632c54043 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 24eceb21c6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
>  25afe92ce4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java
>  8836af6ead 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
>  a3728d46b3 
> 
> 
> Diff: https://reviews.apache.org/r/58886/diff/1/
> 
> 
> Testing
> ---
> 
> updated testcases where ever needed. Manual testing also done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 58886: Smartsense view do not load and shows blank

2017-05-01 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58886/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, venkat sairam, and Ashwin Rajeev.


Bugs: AMBARI-20905
https://issues.apache.org/jira/browse/AMBARI-20905


Repository: ambari


Description
---

If installation fails and is retried the cluster id changes but some view 
instances keep older cluster ids which stop views from being displayed later on.
remove the view instances which contains invalid cluster id before creating any 
autoview instance.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ViewInstanceDAO.java
 061c7223d6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
 b632c54043 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
24eceb21c6 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java
 25afe92ce4 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewPrivilegeResourceProviderTest.java
 8836af6ead 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 
a3728d46b3 


Diff: https://reviews.apache.org/r/58886/diff/1/


Testing
---

updated testcases where ever needed. Manual testing also done.


Thanks,

Nitiraj Rathore

Re: Review Request 58862: AMBARI-20895. Fixing sizing for Hive-interactive-site's Tez AM's.

2017-05-01 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58862/#review173480
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 28, 2017, 11:13 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58862/
> ---
> 
> (Updated April 28, 2017, 11:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20895
> https://issues.apache.org/jira/browse/AMBARI-20895
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-20895. Fixing sizing for Hive-interactive-site's Tez AM's
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
>  34fe117 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 2a1113a 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 77a06fe 
> 
> 
> Diff: https://reviews.apache.org/r/58862/diff/1/
> 
> 
> Testing
> ---
> 
> Added Python UT's
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 58884: Mask passwords in Request resource responses

2017-05-01 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58884/#review173478
---


Ship it!




Ship It!

- Sumit Mohanty


On May 1, 2017, 5:30 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58884/
> ---
> 
> (Updated May 1, 2017, 5:30 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Balázs Bence 
> Sári, Eugene Chekanskiy, Laszlo Puskas, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20874
> https://issues.apache.org/jira/browse/AMBARI-20874
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mask the data for sensitive fields and properties in Request resource 
> responses to protect that data.
> 
> `org.apache.ambari.server.utils.SecretReference#maskPasswordInPropertyMap` is 
> used `org.apache.ambari.server.controller.internal.StageResourceProvider` to 
> protected sensitive data.  The same technique should be used in 
> `org.apache.ambari.server.controller.internal.RequestResourceProvider`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  57e702477d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  feedc74b7c 
> 
> 
> Diff: https://reviews.apache.org/r/58884/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 58884: Mask passwords in Request resource responses

2017-05-01 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58884/
---

Review request for Ambari, Alejandro Fernandez, Attila Magyar, Balázs Bence 
Sári, Eugene Chekanskiy, Laszlo Puskas, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-20874
https://issues.apache.org/jira/browse/AMBARI-20874


Repository: ambari


Description
---

Mask the data for sensitive fields and properties in Request resource responses 
to protect that data.

`org.apache.ambari.server.utils.SecretReference#maskPasswordInPropertyMap` is 
used `org.apache.ambari.server.controller.internal.StageResourceProvider` to 
protected sensitive data.  The same technique should be used in 
`org.apache.ambari.server.controller.internal.RequestResourceProvider`.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
 57e702477d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
 feedc74b7c 


Diff: https://reviews.apache.org/r/58884/diff/1/


Testing
---

Manually tested

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 58882: Ambari build failure after npm to yarn package manager migration.

2017-05-01 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58882/#review173466
---


Ship it!




Ship It!

- Gaurav Nagar


On May 1, 2017, 12:57 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58882/
> ---
> 
> (Updated May 1, 2017, 12:57 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, Pallav 
> Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20902
> https://issues.apache.org/jira/browse/AMBARI-20902
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added yarn.lock in RAT skip section
> 
> 
> Diffs
> -
> 
>   pom.xml 1cf13f4 
> 
> 
> Diff: https://reviews.apache.org/r/58882/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 58882: Ambari build failure after npm to yarn package manager migration.

2017-05-01 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58882/#review173465
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On May 1, 2017, 12:57 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58882/
> ---
> 
> (Updated May 1, 2017, 12:57 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Rohit Choudhary.
> 
> 
> Bugs: AMBARI-20902
> https://issues.apache.org/jira/browse/AMBARI-20902
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added yarn.lock in RAT skip section
> 
> 
> Diffs
> -
> 
>   pom.xml 1cf13f4 
> 
> 
> Diff: https://reviews.apache.org/r/58882/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Review Request 58882: Ambari build failure after npm to yarn package manager migration.

2017-05-01 Thread venkat sairam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58882/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Rohit Choudhary.


Bugs: AMBARI-20902
https://issues.apache.org/jira/browse/AMBARI-20902


Repository: ambari


Description
---

Added yarn.lock in RAT skip section


Diffs
-

  pom.xml 1cf13f4 


Diff: https://reviews.apache.org/r/58882/diff/1/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT

2017-05-01 Thread Masahiro Tanaka



> On 4月 29, 2017, 3:35 a.m., Aravindan Vijayan wrote:
> > Ship It!

Thank you! Could you commit it?


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/#review173361
---


On 4月 20, 2017, 11:59 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58575/
> ---
> 
> (Updated 4月 20, 2017, 11:59 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20797
> https://issues.apache.org/jira/browse/AMBARI-20797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I had in trouble compiling same as in 
> https://community.hortonworks.com/questions/93448/compile-ambari-metrics-storm-sink-error.html
> The solution is also mentioned in the URL above. We should use storm-1.1.0 , 
> not storm-1.1.0-SNAPSHOT
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-storm-sink/pom.xml 612ad63 
> 
> 
> Diff: https://reviews.apache.org/r/58575/diff/1/
> 
> 
> Testing
> ---
> 
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12864239/AMBARI-20797.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 core tests. The patch passed unit tests in 
> ambari-metrics/ambari-metrics-storm-sink.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 58911: HDP 3.0 TP - Unable to install Spark, cannot find package/scripts dir

Review Request 58911: HDP 3.0 TP - Unable to install Spark, cannot find package/scripts dir

Re: Review Request 57687: AMBARI-20443 No need to show `hive_ambari_database`

Re: Review Request 58756: Remove redundant whitespace in Hadoop 3.0 configs, enable ATS v2

Review Request 58894: WFM: Include an option to clear filters in workflow dashboard

Re: Review Request 58429: After pam setup- Hive View user home test fails

Re: Review Request 58429: After pam setup- Hive View user home test fails

Re: Review Request 58429: After pam setup- Hive View user home test fails

Re: Review Request 58429: After pam setup- Hive View user home test fails

Re: Review Request 58429: After pam setup- Hive View user home test fails

Re: Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)

Re: Review Request 58822: Add Log Level Filter to the Log Search config API

Re: Review Request 58756: Remove redundant whitespace in Hadoop 3.0 configs, enable ATS v2

Re: Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)

Re: Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)

Review Request 58887: Sometimes: Command [ambari-server restart] failed after upgrade Smartsense (Upgrade from 2.4.1.0 to 2.5.0.1)

Re: Review Request 58886: Smartsense view do not load and shows blank

Review Request 58886: Smartsense view do not load and shows blank

Re: Review Request 58862: AMBARI-20895. Fixing sizing for Hive-interactive-site's Tez AM's.

Re: Review Request 58884: Mask passwords in Request resource responses

Review Request 58884: Mask passwords in Request resource responses

Re: Review Request 58882: Ambari build failure after npm to yarn package manager migration.

Re: Review Request 58882: Ambari build failure after npm to yarn package manager migration.

Review Request 58882: Ambari build failure after npm to yarn package manager migration.

Re: Review Request 58575: Ambari Metrics Storm Sink compilation error due to storm-1.1.0-SNAPSHOT

25 matches

Site Navigation

Mail list logo

Footer information