Re: Review Request 59103: Pig and CapSched views are not loading in 2.4.3

2017-05-09 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59103/#review174424 --- Ship it! Ship It! - DIPAYAN BHOWMICK On May 9, 2017, 5:02

Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

2017-05-09 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59113/#review174420 --- Ship it! - Jayush Luniya On May 10, 2017, 12:21 a.m.,

Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

2017-05-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59113/#review174407 --- Fix it, then Ship it!

Re: Review Request 57580: Enhance Kafka Service Check

2017-05-09 Thread Wang Jie
> On 三月 14, 2017, 9:51 a.m., Dmitro Lisnichenko wrote: > > Ship It! Thank you so much for reviewing my patch on reviewboard, and could you commit the patch ? Thanks - Wang --- This is an automatically generated e-mail. To reply,

Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

2017-05-09 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59113/ --- (Updated May 10, 2017, 12:21 a.m.) Review request for Ambari, Alejandro

Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

2017-05-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59113/#review174399 --- Ship it! Ship It! - Sumit Mohanty On May 9, 2017, 10:33

Re: Review Request 59115: Add NIFI Admin Toolkit StackFeatures to HDP StackFeatures

2017-05-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59115/#review174395 --- Ship it! Ship It! - Alejandro Fernandez On May 9, 2017,

Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

2017-05-09 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59113/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit

Re: Review Request 59085: RBAC: Service Operator/Administrator Role don't have HOST.ADD_DELETE_COMPONENTS permission so we 'd better hide relevant buttons on Web UI

2017-05-09 Thread yao lei
> On 五月 9, 2017, 3:10 p.m., Robert Levas wrote: > > Ship It! Thanks for your review - yao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59085/#review174319

Review Request 59111: Run new heartbeatThread and statusCommand executor instead of old

2017-05-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59111/ --- Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid

Re: Review Request 59104: Integrate StackService resource and it's subresources with swagger

2017-05-09 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59104/#review174358 --- Fix it, then Ship it! `import io.swagger.*` should follow

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

2017-05-09 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58990/#review174360 --- Ship it! Ship It! - Robert Nettleton On May 9, 2017, 9:38

Re: Review Request 59104: Integrate StackService resource and it's subresources with swagger

2017-05-09 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59104/ --- (Updated May 9, 2017, 6:40 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

2017-05-09 Thread Tim Thorpe
> On May 9, 2017, 5:18 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml > > Line 351 (original) > > > > > > How do we capture this dependency only

Re: Review Request 59104: Integrate StackService resource and it's subresources with swagger

2017-05-09 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59104/#review174348 --- Ship it! Ship It! - Jaimin Jetly On May 9, 2017, 5:50 p.m.,

Review Request 59104: Integrate StackService resource and it's subresources with swagger

2017-05-09 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59104/ --- Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit

Re: Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

2017-05-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59095/#review174341 ---

Re: Review Request 59103: Pig and CapSched views are not loading in 2.4.3

2017-05-09 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59103/#review174340 --- Ship it! Ship It! - Gaurav Nagar On May 9, 2017, 5:02 p.m.,

Re: Review Request 59103: Pig and CapSched views are not loading in 2.4.3

2017-05-09 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59103/#review174339 --- Ship it! Ship It! - venkat sairam On May 9, 2017, 5:02

Re: Review Request 59060: Host Version on Finalization Must Be Scoped Correctly Based on Upgrade Type

2017-05-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59060/ --- (Updated May 9, 2017, 1:04 p.m.) Review request for Ambari, Alejandro

Review Request 59103: Pig and CapSched views are not loading in 2.4.3

2017-05-09 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59103/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 59102: LDAPS connections to an Active Directory when enabling Kerberos should validate the server's SSL certificate

2017-05-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59102/#review174338 --- Ship it! Ship It! - Sebastian Toader On May 9, 2017, 6:38

Re: Review Request 59102: LDAPS connections to an Active Directory when enabling Kerberos should validate the server's SSL certificate

2017-05-09 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59102/ --- (Updated May 9, 2017, 12:38 p.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 59060: Host Version on Finalization Must Be Scoped Correctly Based on Upgrade Type

2017-05-09 Thread Jonathan Hurley
> On May 9, 2017, 12:24 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > > Line 112 (original), 104 (patched) > > > > > > nit:

Re: Review Request 59060: Host Version on Finalization Must Be Scoped Correctly Based on Upgrade Type

2017-05-09 Thread Jonathan Hurley
> On May 9, 2017, 12:24 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > > Line 244 (original), 244 (patched) > > > > > > Why is state part of the uniqueness? You can't have

Re: Review Request 59060: Host Version on Finalization Must Be Scoped Correctly Based on Upgrade Type

2017-05-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59060/#review174333 --- Fix it, then Ship it!

Review Request 59102: LDAPS connections to an Active Directory when enabling Kerberos should validate the server's SSL certificate

2017-05-09 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59102/ --- Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy,

Re: Review Request 59066: Remove cluster_version use

2017-05-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59066/#review174332 --- Ship it! Ship It! - Jonathan Hurley On May 8, 2017, 5:35

Re: Review Request 59085: RBAC: Service Operator/Administrator Role don't have HOST.ADD_DELETE_COMPONENTS permission so we 'd better hide relevant buttons on Web UI

2017-05-09 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59085/#review174319 --- Ship it! Ship It! - Robert Levas On May 9, 2017, 5:49 a.m.,

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

2017-05-09 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58990/#review174316 --- Ship it! Ship It! - Robert Levas On May 9, 2017, 5:38 a.m.,

Re: Review Request 58845: AMBARI-20891 - Allow extensions to auto-link with supported stack versions

2017-05-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58845/#review174308 --- Ship it! Ship It! - Jonathan Hurley On May 5, 2017, 2:30

Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

2017-05-09 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59095/ --- Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Jayush

Re: Review Request 58929: Create Database Schema for Improved User Account Management

2017-05-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58929/#review174307 --- Ship it! Ship It! - Jonathan Hurley On May 3, 2017, 4:18

Re: Review Request 58179: For sort/partition operator, if there is only 1 reducer, display just "sort" rather than "sort/partition"

2017-05-09 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58179/ --- (Updated May 9, 2017, 2:30 p.m.) Review request for Ambari, Abhishek Kumar,

Re: Review Request 58179: For sort/partition operator, if there is only 1 reducer, display just "sort" rather than "sort/partition"

2017-05-09 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58179/#review174306 --- Ship it! Ship It! - belliraj hb On May 9, 2017, 10:54 a.m.,

Re: Review Request 59066: Remove cluster_version use

2017-05-09 Thread Nate Cole
> On May 9, 2017, 8:36 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java > > Line 72 (original), 70 (patched) > > > > > > I know that we have a parallel

Re: Review Request 59066: Remove cluster_version use

2017-05-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59066/#review174295 ---

Re: Review Request 59051: Integrate Log Search integration test framework with Selenium

2017-05-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59051/#review174291 --- Ship it! Ship It! - Sebastian Toader On May 9, 2017, 11:59

Re: Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file name will be shown as ____.csv when we download the query result with the unicode name

2017-05-09 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59087/#review174290 --- Ship it! Ship It! - Pallav Kulshreshtha On May 9, 2017,

Re: Review Request 58179: For sort/partition operator, if there is only 1 reducer, display just "sort" rather than "sort/partition"

2017-05-09 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58179/ --- (Updated May 9, 2017, 10:54 a.m.) Review request for Ambari, Abhishek Kumar,

Re: Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file name will be shown as ____.csv when we download the query result with the unicode name

2017-05-09 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59087/#review174286 --- Ship it! Ship It! - Gaurav Nagar On May 9, 2017, 10:07

Review Request 59087: Hive View 2.0 and 1.5 : The downloaded file name will be shown as ____.csv when we download the query result with the unicode name

2017-05-09 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59087/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Re: Review Request 59051: Integrate Log Search integration test framework with Selenium

2017-05-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59051/ --- (Updated May 9, 2017, 9:59 a.m.) Review request for Ambari, Laszlo Puskas,

Review Request 59085: RBAC: Service Operator/Administrator Role don't have HOST.ADD_DELETE_COMPONENTS permission so we 'd better hide relevant buttons on Web UI

2017-05-09 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59085/ --- Review request for Ambari, Alexandr Antonenko, Robert Levas, and Richard Zang.

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

2017-05-09 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58990/ --- (Updated May 9, 2017, 9:38 a.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

2017-05-09 Thread Laszlo Puskas
> On May 4, 2017, 2:21 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/topology/validators/RequiredConfigPropertiesValidator.java > > Lines 38 (patched) > > > > > > Aren' there some

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

2017-05-09 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58990/ --- (Updated May 9, 2017, 8:57 a.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 59059: Runtime filtering is not rendering properly

2017-05-09 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59059/#review174279 --- Ship it! Ship It! - venkat sairam On May 8, 2017, 6:18