Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-05-30 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/ --- (Updated May 31, 2017, 4:35 a.m.) Review request for Ambari, Alejandro

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-05-30 Thread yao lei
> On May 30, 2017, 3:28 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java > > Lines 83-86 (patched) > > > > > > This should be

Re: Review Request 59648: Add a flag to indicate NN restart is rolling

2017-05-30 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59648/#review176376 --- Ship it! Ship It! - Sid Wagle On May 30, 2017, 7:58 p.m.,

Re: Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

2017-05-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59095/#review176366 --- I think that the overall problem here is how the UI determines

Re: Review Request 59626: (PREVIEW) HDP deploy from public repo failed

2017-05-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review176355 ---

Review Request 59649: Delete view privileges from the Users page

2017-05-30 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59649/ --- Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.

Review Request 59648: Add a flag to indicate NN restart is rolling

2017-05-30 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59648/ --- Review request for Ambari, Sumit Mohanty and Sid Wagle. Bugs: AMBARI-21148

Re: Review Request 59574: Add AMS HA support to local metrics aggregator application

2017-05-30 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59574/#review176339 ---

Review Request 59639: Blueprint export should allow tokenized values in SingleHostUpdater

2017-05-30 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59639/ --- Review request for Ambari, Di Li and Robert Nettleton. Bugs: AMBARI-21137

Re: Review Request 58322: Small fixes in Log Search

2017-05-30 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58322/ --- (Updated May 30, 2017, 4:18 p.m.) Review request for Ambari, Oliver Szabo and

Re: Review Request 59503: Create custom admin user during ambari server setup

2017-05-30 Thread Robert Levas
> On May 26, 2017, 10:57 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Line 350 (original), 350-356 (patched) > > > > > > This is no longer

Re: Review Request 59637: Knox JAAS configuration file should not allow the Kerberos ticket cache to be used when establishing its identity on startup

2017-05-30 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59637/#review176311 --- Ship it! Ship It! - Sebastian Toader On May 30, 2017, 5:21

Re: Review Request 59637: Knox JAAS configuration file should not allow the Kerberos ticket cache to be used when establishing its identity on startup

2017-05-30 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59637/#review176310 --- Ship it! Ship It! - Robert Levas On May 30, 2017, 11:21

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-05-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176309 --- Fix it, then Ship it!

Review Request 59637: Knox JAAS configuration file should not allow the Kerberos ticket cache to be used when establishing its identity on startup

2017-05-30 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59637/ --- Review request for Ambari, Balázs Bence Sári, Robert Levas, and Sebastian

Re: Review Request 59633: Create .md files to describe Log Search input configurations

2017-05-30 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59633/#review176306 --- Ship it! Ship It! - Sebastian Toader On May 30, 2017, 4:13

Re: Review Request 59633: Create .md files to describe Log Search input configurations

2017-05-30 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59633/#review176303 --- Ship it! Ship It! - Oliver Szabo On May 30, 2017, 1:48

Re: Review Request 59633: Create .md files to describe Log Search input configurations

2017-05-30 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59633/ --- (Updated May 30, 2017, 1:48 p.m.) Review request for Ambari, Oliver Szabo and

Re: Review Request 59626: (PREVIEW) HDP deploy from public repo failed

2017-05-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review176302 --- So far so good, will check again when there's an update for the

Re: Review Request 59520: Custom RM principal causes zookeeper HA state store to be inaccessible

2017-05-30 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59520/#review176301 --- Ship it! Ship It! - Robert Levas On May 30, 2017, 9:15

Re: Review Request 59520: Custom RM principal causes zookeeper HA state store to be inaccessible

2017-05-30 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59520/#review176300 --- Ship it! Ship It! - Sebastian Toader On May 30, 2017, 3:15

Re: Review Request 59520: Custom RM principal causes zookeeper HA state store to be inaccessible

2017-05-30 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59520/ --- (Updated May 30, 2017, 1:15 p.m.) Review request for Ambari, Balázs Bence

Re: Review Request 59627: Support CREATE/UPDATE/DELETE of topology, hashes and some events format changes

2017-05-30 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59627/#review176292 --- Ship it! Ship It! - Myroslav Papirkovskyy On Травень 29,