---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54860/#review159596
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 19, 2016, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54861/#review159814
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 21, 2016, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54981/#review159965
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 22, 2016, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54989/#review160073
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 22, 2016, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55041/#review160126
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 26, 2016, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55044/#review160127
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 26, 2016, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55048/#review160152
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 27, 2016, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55364/#review161074
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 10, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55396/#review161208
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 11, 2017, 1
/HDP/2.0.6/services/stack_advisor.py
(line 358)
<https://reviews.apache.org/r/55427/#comment232509>
Don't we need a test for this logic?
- Dmitro Lisnichenko
On Jan. 11, 2017, 5:07 p.m., Eugene Chekanskiy wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55481/#review161495
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 13, 2017, 3
of Perf 1.0 cluster
- RU to 2.0 (upgrade and downgrade)
- EU to 2.0 (upgrade and downgrade)
Issues:
- Clean deploy of perf 2.0 stack (dummy component install scripts are hardcoded
with 1.1.1.1 version)
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55529/#review161700
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 14, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55570/#review161708
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 16, 2017, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55568/#review161714
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 16, 2017, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55572/#review161718
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 16, 2017, 2
ply, visit:
https://reviews.apache.org/r/55515/#review161725
---
On Jan. 13, 2017, 9:03 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To
(line 178)
<https://reviews.apache.org/r/55515/#comment233048>
By the way, we have always been passing full agent environment to python
scripts. This environment was just dropped on first Execute()/shell.call()
invocation and not passed to subscripts
- Dmitro Lisnichenko
On Jan. 13, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55630/#review161885
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 17, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55634/#review162045
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 17, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55675/#review162134
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 18, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55716/#review162273
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 19, 2017, 2
required code).
What works:
- deploy of Perf 1.0 cluster
- RU to 2.0 (upgrade and downgrade)
- EU to 2.0 (upgrade and downgrade)
Issues:
- Clean deploy of perf 2.0 stack (dummy component install scripts are hardcoded
with 1.1.1.1 version)
Thanks,
Dmitro Lisnichenko
cluster
- RU to 2.0 (upgrade and downgrade)
- EU to 2.0 (upgrade and downgrade)
- Clean deploy of perf 2.0 stack (takes version and build number from base url)
Thanks,
Dmitro Lisnichenko
/serveraction/kerberos/UpdateKerberosConfigsServerAction.java
(line 127)
<https://reviews.apache.org/r/55842/#comment233977>
I think there may be lots of similar places at our code. Maybe just add
this config on cluster deployment?
- Dmitro Lisnichenko
On Jan. 23, 2017, 3:24 p.m., Eugene Chek
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55844/#review162631
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 23, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55845/#review162647
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 23, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55842/#review162809
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 24, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55927/#review162953
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 25, 2017, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55924/#review162954
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 25, 2017, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55886/#review162957
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 24, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163248
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 27, 2017, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56023/#review163275
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 27, 2017, 5
on/src/main/python/ambari_commons/shell.py 8d26599
Diff: https://reviews.apache.org/r/56059/diff/
Testing
---
test on live cluster. Still there are things to check
Thanks,
Dmitro Lisnichenko
(line 51)
<https://reviews.apache.org/r/56059/#comment234889>
will double-check that this condition works
- Dmitro Lisnichenko
On Jan. 29, 2017, 2:27 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163492
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 30, 2017, 12
-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review163443
-----------
On Jan. 29, 2017, 2:27 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an auto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56013/#review163508
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 30, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56077/#review163513
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 30, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56079/#review163515
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 30, 2017, 3
nly populated with yum and rpm
entries)
- Dmitro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review163543
---
On Jan. 29, 20
/HostImpl.java
(line 759)
<https://reviews.apache.org/r/55989/#comment235124>
is not this issue critical - maybe rethrow exception?
- Dmitro Lisnichenko
On Jan. 31, 2017, 1:12 a.m., Vitalyi Brodetskyi wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55989/#review163653
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 31, 2017, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56125/#review163661
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 31, 2017, 4
/checks/AutoStartDisabledCheck.java
(line 56)
<https://reviews.apache.org/r/56141/#comment235308>
something with line spacing
- Dmitro Lisnichenko
On Feb. 1, 2017, 4:32 a.m., Nate Cole wrote:
>
> ---
> This is a
does not exist
{code}
Diffs
-
ambari-agent/conf/unix/agent-multiplier.py 5abae58
Diff: https://reviews.apache.org/r/56166/diff/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION
ambari-common/src/main/python/ambari_commons/shell.py 8d26599
Diff: https://reviews.apache.org/r/56059/diff/
Testing (updated)
---
will add unit tests
Thanks,
Dmitro Lisnichenko
/TestCustomServiceOrchestrator.py
(line 324)
<https://reviews.apache.org/r/56225/#comment235478>
I think this assertion makes no sence since we would not get here in case
of any (unhandled) exception
- Dmitro Lisnichenko
On Feb. 2, 2017, 3:36 p.m., Attila Doroszlai
eviews.apache.org/r/56059/#review163886
-------
On Feb. 1, 2017, 9:13 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To re
Diffs (updated)
-
ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3915
ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION
ambari-common/src/main/python/ambari_commons/shell.py 8d26599df8
Diff: https://reviews.apache.org/r/56059/diff/
Testing
---
will add unit tests
Thanks,
Dmitro Lisnichenko
> On Feb. 2, 2017, 4:19 p.m., Dmitro Lisnichenko wrote:
> > ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py,
> > line 324
> > <https://reviews.apache.org/r/56225/diff/2/?file=1622218#file1622218line324>
> >
> > I think this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56225/#review164113
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 3, 2017, 12
iffs (updated)
-
ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py PRE-CREATION
ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3915
ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION
ambari-common/src/main/python/ambari_commons/sh
python/ambari_commons/shell.py 8d26599df8
Diff: https://reviews.apache.org/r/56059/diff/
Testing
---
will add unit tests
Thanks,
Dmitro Lisnichenko
Utils.py PRE-CREATION
ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3915
ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION
ambari-common/src/main/python/ambari_commons/shell.py 8d26599df8
Diff: https://reviews.apache.org/r/56059/diff/
Testing (updated)
---
mvn clean test
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56387/#review164508
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 7, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56444/#review164678
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 8, 2017, 3
ION
ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3
ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION
ambari-common/src/main/python/ambari_commons/shell.py 8d26599
Diff: https://reviews.apache.org/r/56059/diff/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56494/#review164913
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 9, 2017, 2
;
right : "kill 17986 17987 17988"
{code}
Diffs (updated)
-
ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py PRE-CREATION
ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3915
ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION
ambari-common/src/main/python/ambari_commons/shell.py 8d26599df8
Diff: https://reviews.apache.org/r/56059/diff/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review164687
-----------
On Feb. 10, 2017, 12:13 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This
986 17987 17988"
{code}
Diffs
-
ambari-agent/src/test/python/ambari_agent/TestProcessUtils.py PRE-CREATION
ambari-agent/src/test/python/ambari_agent/TestShell.py 8d375e3915
ambari-common/src/main/python/ambari_commons/process_utils.py PRE-CREATION
ambari-common/src/main/python/ambari_commons/shell.py 8d26599df8
Diff: https://reviews.apache.org/r/56059/diff/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
ation/cluster-env.xml
3af8f08
Diff: https://reviews.apache.org/r/56678/diff/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56678/#review165569
-------
On Feb. 14, 2017, 10:07 p.m., Dmitro Lisnichenko wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56717/#review165753
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 15, 2017, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165754
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 15, 2017, 6
state/ConfigHelper.java
13d0993
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
3af8f08
Diff: https://reviews.apache.org/r/56678/diff/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165917
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 16, 2017, 1
va:543)
at java.lang.Thread.run(Thread.java:745)
{code}
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
99a81c1d79
Diff: https://reviews.apache.org/r/56790/diff/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
Pool$3.run(QueuedThreadPool.java:543)
at java.lang.Thread.run(Thread.java:745)
{code}
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
99a81c1d79
Diff: https://reviews.apache.org/r/56790/diff/
Testing
---
mvn clean test
Thank
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56789/#review166082
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 17, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56859/#review166136
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 21, 2017, 12
org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
aa3e799a89
Diff: https://reviews.apache.org/r/56790/diff/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
ari/server/state/stack/upgrade/RepositoryVersionHelperTest.java
437cc42
Diff: https://reviews.apache.org/r/56943/diff/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56125/#review166507
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 23, 2017, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56994/#review166678
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 23, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57038/#review166709
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 24, 2017, 4
/package/scripts/service_check.py
(line 40)
<https://reviews.apache.org/r/57087/#comment238943>
let's remove commented/obsolete code
- Dmitro Lisnichenko
On Feb. 27, 2017, 2:39 p.m., Eugene Chekanskiy wrote:
>
> ---
/resource_management/core/signal_utils.py (line 26)
<https://reviews.apache.org/r/57092/#comment238944>
looks like unused import
- Dmitro Lisnichenko
On Feb. 27, 2017, 4:07 p.m., Andrew Onischuk wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/#review166888
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Feb. 27, 2017, 6
/ambari_server/serverConfiguration.py (line 987)
<https://reviews.apache.org/r/57116/#comment239173>
maybe make timeout.strip() before comparing to "" just to handle possible
space character, tab and so on
- Dmitro Lisnichenko
On Feb. 28, 2017, 3:18 a.m., Jonat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57204/#review167458
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On March 1, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57204/#review167671
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On March 2, 2017, 2
/main/resources/common-services/STORM/0.10.0/configuration/storm-env.xml
3b814a9b54
Diff: https://reviews.apache.org/r/57292/diff/1/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
/services/ATLAS/configuration/application-properties.xml
Lines 110 (patched)
<https://reviews.apache.org/r/57295/#comment239924>
thanks for that
- Dmitro Lisnichenko
On March 3, 2017, 8:04 p.m., Jonathan Hurley wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57338/#review167975
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On March 6, 2017, 3
ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/YARN/configuration/yarn-site.xml
26aac90975
Diff: https://reviews.apache.org/r/57292/diff/2/
Changes: https://reviews.apache.org/r/57292/diff/1-2/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
/stack_select.py
513ceac8dd
ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/service_check.py
2f656c7904
Diff: https://reviews.apache.org/r/57378/diff/1/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57381/#review168164
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On March 7, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57423/#review168424
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On March 8, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57462/#review168446
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On March 9, 2017, 3
eviews.apache.org/r/57378/#review168350
---
On March 7, 2017, 5:56 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To re
Diff: https://reviews.apache.org/r/57465/diff/1/
Testing
---
live test on cluster
Thanks,
Dmitro Lisnichenko
----------
On March 9, 2017, 5:20 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57465/
> ---
new hdp conf dir since "client restart" step
- Dmitro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57465/#review168461
----------
;
> >
> > Do we need to support this for stack upgrades so that existing clusters
> > can have this property?
>
> Dmitro Lisnichenko wrote:
> Jonathan, you are right. Actually, there are 3 options to fix the issue
> with Slider:
> 1) Current way. It f
/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml
e11ff02cfe
Diff: https://reviews.apache.org/r/57465/diff/2/
Changes: https://reviews.apache.org/r/57465/diff/1-2/
Testing
---
live test on cluster
Thanks,
Dmitro Lisnichenko
ly, visit:
https://reviews.apache.org/r/57465/#review168516
---
On March 9, 2017, 7:59 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To re
pache.org/r/57465/#review168497
---
On March 9, 2017, 7:59 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vis
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57559/#review168770
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On March 13, 2017, 5
401 - 500 of 752 matches
Mail list logo