Re: Review Request 64083: Log Search: Adding new dynamic field for service logs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64083/#review191888 --- Ship it! Ship It! - Krisztian Kasa On Nov. 27, 2017, 2:54 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64083/ > --- > > (Updated Nov. 27, 2017, 2:54 p.m.) > > > Review request for Ambari, Attila Doroszlai, Krisztian Kasa, and Robert > Nettleton. > > > Bugs: Ambari > https://issues.apache.org/jira/browse/Ambari > > > Repository: ambari > > > Description > --- > > its required to add in order to have a dynamic field which not only indexed, > but stored as well. > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-server/src/main/configsets/hadoop_logs/conf/managed-schema > c6f498b > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/solr/SolrConstants.java > 60fc1a3 > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/solr/model/SolrCommonLogData.java > b5ce7ad > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/solr/model/SolrServiceLogData.java > c6fdba3 > > > Diff: https://reviews.apache.org/r/64083/diff/2/ > > > Testing > --- > > done. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64059: Initial implementation of Schedulable document deletion & archiving for Infra Solr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64059/ --- (Updated Nov. 27, 2017, 3:39 p.m.) Review request for Ambari, Attila Magyar, Oliver Szabo, and Robert Nettleton. Bugs: AMBARI-22514 https://issues.apache.org/jira/browse/AMBARI-22514 Repository: ambari Description (updated) --- Initial implementation of Schedulable document deletion & archiving for Infra Solr == Spring bacth job for * exporting solr documents from hadoop_logs collection * saving the documents to filesystem. All document is converted to json and written into new line. * compress each file using tar.gz * job can be started using ambari-infra-manager api and parameters can be overwritten * s3 upload support (not used yet) * job can be configurad to export from any collection: solr query can be defined in properties Diffs (updated) - ambari-infra/ambari-infra-manager/pom.xml aa86da82b2 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/CompositeFileAction.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/Document.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentDestination.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportConfiguration.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportJobListener.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportStepListener.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExporter.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemReader.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemWriter.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileAction.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriter.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Properties.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Uploader.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentIterator.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentSource.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrQueryBuilder.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrQueryProperties.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/TarGzCompressor.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java fc0a4f71db ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 81623764da ambari-infra/ambari-infra-manager/src/main/resources/log4j2.xml ad1adcdcba ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentExporterTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentItemReaderTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrQueryBuilderTest.java PRE-CREATION ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties fb7ddf2845 Diff: https://reviews.apache.org/r/64059/diff/3/ Changes: https://reviews.apache.org/r/64059/diff/2-3/ Testing --- * unit tests * manual test using docker-compose Thanks, Krisztian Kasa
Re: Review Request 64059: Initial implementation of Schedulable document deletion & archiving for Infra Solr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64059/ --- (Updated Nov. 24, 2017, 9:31 a.m.) Review request for Ambari, Attila Magyar, Oliver Szabo, and Robert Nettleton. Bugs: AMBARI-22514 https://issues.apache.org/jira/browse/AMBARI-22514 Repository: ambari Description --- Initial implementation of Schedulable document deletion & archiving for Infra Solr == Spring bacth job for * exporting solr documents from hadoop_logs collection * saving the documents to filesystem. All document is converted to json and written into new line. * compress each file using tar.gz * job can be started using ambari-infra-manager api and parameters can be overwritten * s3 upload support (not used yet) Diffs (updated) - ambari-infra/ambari-infra-manager/pom.xml aa86da82b2 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/CompositeFileAction.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/Document.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentDestination.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportConfiguration.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportJobListener.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportStepListener.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExporter.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemReader.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemWriter.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileAction.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/HadoopLogSource.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriter.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Properties.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Uploader.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentIterator.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentSource.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/TarGzCompressor.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java fc0a4f71db ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 81623764da ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentExporterTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentItemReaderTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java PRE-CREATION ambari-infra/pom.xml e4b6a7601f ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties fb7ddf2845 Diff: https://reviews.apache.org/r/64059/diff/2/ Changes: https://reviews.apache.org/r/64059/diff/1-2/ Testing --- * unit tests * manual test using docker-compose Thanks, Krisztian Kasa
Review Request 64059: Initial implementation of Schedulable document deletion & archiving for Infra Solr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64059/ --- Review request for Ambari, Attila Magyar, Oliver Szabo, and Robert Nettleton. Bugs: AMBARI-22514 https://issues.apache.org/jira/browse/AMBARI-22514 Repository: ambari Description --- Initial implementation of Schedulable document deletion & archiving for Infra Solr == Spring bacth job for * exporting solr documents from hadoop_logs collection * saving the documents to filesystem. All document is converted to json and written into new line. * compress each file using tar.gz * job can be started using ambari-infra-manager api and parameters can be overwritten * s3 upload support (not used yet) Diffs - ambari-infra/ambari-infra-manager/pom.xml aa86da82b2 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/CompositeFileAction.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/Document.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentDestination.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportConfiguration.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportJobListener.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportStepListener.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExporter.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemReader.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentItemWriter.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileAction.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/HadoopLogSource.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriter.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Properties.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/S3Uploader.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentIterator.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/SolrDocumentSource.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/TarGzCompressor.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/manager/JobManager.java fc0a4f71db ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 81623764da ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentExporterTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentItemReaderTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java PRE-CREATION ambari-infra/pom.xml e4b6a7601f ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties fb7ddf2845 Diff: https://reviews.apache.org/r/64059/diff/1/ Testing --- * unit tests * manual test using docker-compose Thanks, Krisztian Kasa
Re: Review Request 64156: Log Search: backend should not return with 302 redirect if authentication fails
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64156/#review192117 --- Ship it! Ship It! - Krisztian Kasa On Nov. 29, 2017, 12:44 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64156/ > --- > > (Updated Nov. 29, 2017, 12:44 p.m.) > > > Review request for Ambari, Attila Magyar, Krisztian Kasa, and Robert > Nettleton. > > > Bugs: AMBARI-22543 > https://issues.apache.org/jira/browse/AMBARI-22543 > > > Repository: ambari > > > Description > --- > > Without proper authentication details rest calls returs with 302 (to /login), > that should be changed and get a 401 status > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuthenticationEntryPoint.java > 2fe5f7b > > > Diff: https://reviews.apache.org/r/64156/diff/1/ > > > Testing > --- > > done > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64091: Log Feeder: handle multiple '=' (split char) in key/value filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64091/#review191997 --- ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java Line 140 (original), 140 (patched) <https://reviews.apache.org/r/64091/#comment269993> Why do we truncate the logmessage? Information can be lost. - Krisztian Kasa On Nov. 27, 2017, 8:54 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64091/ > --- > > (Updated Nov. 27, 2017, 8:54 p.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert > Nettleton. > > > Bugs: AMBARI-22526 > https://issues.apache.org/jira/browse/AMBARI-22526 > > > Repository: ambari > > > Description > --- > > Logfeeder key/value filter cannot handle multiple occurence of split char -> > in order to solve that we can limit the number of splits > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java > b04a439 > > > Diff: https://reviews.apache.org/r/64091/diff/2/ > > > Testing > --- > > done > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64206: Upgrade Ambari Infra to use Solr 5.5.5 for Ambari 2.6.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64206/#review192280 --- Ship it! Ship It! - Krisztian Kasa On Nov. 30, 2017, 11:51 a.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64206/ > --- > > (Updated Nov. 30, 2017, 11:51 a.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Krisztian Kasa, > and Miklos Gergely. > > > Bugs: AMBARI-22559 > https://issues.apache.org/jira/browse/AMBARI-22559 > > > Repository: ambari > > > Description > --- > > upgrade solr version (also use horton repo as default) > > > Diffs > - > > ambari-logsearch/ambari-logsearch-assembly/pom.xml c0a92f4 > ambari-logsearch/pom.xml 5a1edee > > > Diff: https://reviews.apache.org/r/64206/diff/1/ > > > Testing > --- > > not required > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64553: Log Feeder refactor: integrate with spring boot
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64553/#review193647
---
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigItem.java
Line 62 (original), 64 (patched)
<https://reviews.apache.org/r/64553/#comment272202>
Create an abstract init method and call it from here. The comment "This
method needs to be overwritten by deriving classes." would be unnecessary.
Like:
protected abstract onInitializing(LogFeederProps logFeederProps);
public void init(LogFeederProps logFeederProps) throws Exception {
this.logFeederProps = logFeederProps;
onInitializing(logFeederProps);
}
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogEntryCacheConfig.java
Lines 41 (patched)
<https://reviews.apache.org/r/64553/#comment272212>
typo: repteitions -> repetitions
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
Lines 77 (patched)
<https://reviews.apache.org/r/64553/#comment272216>
typo: separtaed -> separated
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
Lines 115 (patched)
<https://reviews.apache.org/r/64553/#comment272219>
typo: wher -> where
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java
Lines 213 (patched)
<https://reviews.apache.org/r/64553/#comment272234>
Are the same properties are stored here as the fields of this class?
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederSecurityConfig.java
Lines 138 (patched)
<https://reviews.apache.org/r/64553/#comment272229>
isBlank checks if the string is null or empty string or whitespace only. It
can be useful instead of isEmpty if you have to deal with whitespaces.
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederSecurityConfig.java
Lines 160 (patched)
<https://reviews.apache.org/r/64553/#comment272233>
Isn't it isEmpty?
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/MetricsCollectorConfig.java
Lines 105 (patched)
<https://reviews.apache.org/r/64553/#comment272237>
!StringUtils.isBlank(hostsString) can be used. It also performs null check.
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/StatsLogger.java
Lines 59 (patched)
<https://reviews.apache.org/r/64553/#comment272238>
Wouldn't be enough catching InterruptedException only?
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/StatsLogger.java
Lines 64 (patched)
<https://reviews.apache.org/r/64553/#comment272239>
Wouldn't be better to halt the entire application in case of an Error? So
Errors would be rethrown but Exceptions not.
- Krisztian Kasa
On Dec. 13, 2017, 1:50 a.m., Oliver Szabo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64553/
> ---
>
> (Updated Dec. 13, 2017, 1:50 a.m.)
>
>
> Review request for Ambari, Krisztian Kasa and Sid Wagle.
>
>
> Bugs: AMBARI-22639
> https://issues.apache.org/jira/browse/AMBARI-22639
>
>
> Repository: ambari
>
>
> Description
> ---
>
> First patch for refactor logfeeder - Spring Boot support
>
> Add spring boot support, the goal is to get rid of LogFeederPropertiesUtil
> and let Spring to handle configs & beans.
> - remove LogFeederPropertiesUtil
> - move logfeeder properties fields into mutliple POJOs
> - update some tests & remove one test (needs to rewrite it)
> - convert singleton classes to spring beans
> - let Spring to handle application pid file
> - convert some internal threads to classes (like StatsLogger)
>
> (it does not contain any real changes regarding to input-filter-output blocks)
>
> Next patch will be focus on the usage of start scritps (in ambari-logsearch
> and ambari-server stack code)
>
>
> Diffs
> -
>
>
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
> a84a97b
>
> ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeeder.java
> 6ed36fd
> ambari-logsearch/ambari-logsearch-logfeeder/.gitig
Review Request 64607: Ambari Infra Manager: solr data exporting jobs and integration test environment
/DocumentExportPropertiesTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentItemReaderTest.java 942713f253 ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java 6411ff1788 ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrQueryBuilderTest.java 4d5ebf1144 ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrQueryPropertiesTest.java PRE-CREATION ambari-infra/pom.xml e4b6a7601f Diff: https://reviews.apache.org/r/64607/diff/1/ Testing --- * unit tests, * integration tests using docker containers * manual testing using docker containers and ide Thanks, Krisztian Kasa
Re: Review Request 64553: Log Feeder refactor: integrate with spring boot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64553/#review193683 --- Ship it! Ship It! - Krisztian Kasa On Dec. 13, 2017, 3:24 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64553/ > --- > > (Updated Dec. 13, 2017, 3:24 p.m.) > > > Review request for Ambari, Krisztian Kasa and Sid Wagle. > > > Bugs: AMBARI-22639 > https://issues.apache.org/jira/browse/AMBARI-22639 > > > Repository: ambari > > > Description > --- > > First patch for refactor logfeeder - Spring Boot support > > Add spring boot support, the goal is to get rid of LogFeederPropertiesUtil > and let Spring to handle configs & beans. > - remove LogFeederPropertiesUtil > - move logfeeder properties fields into mutliple POJOs > - update some tests & remove one test (needs to rewrite it) > - convert singleton classes to spring beans > - let Spring to handle application pid file > - convert some internal threads to classes (like StatsLogger) > > (it does not contain any real changes regarding to input-filter-output blocks) > > Next patch will be focus on the usage of start scritps (in ambari-logsearch > and ambari-server stack code) > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java > a84a97b > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigLogFeeder.java > 6ed36fd > ambari-logsearch/ambari-logsearch-logfeeder/.gitignore PRE-CREATION > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 01710bf > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > 5114743 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederCommandLine.java > d996f98 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java > 243b344 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigItem.java > 5c20a8e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogEntryParseTester.java > ec29f69 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/LogFeederConstants.java > a76 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/ApplicationConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/InputSimulateConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogEntryCacheConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederProps.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/LogFeederSecurityConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/conf/MetricsCollectorConfig.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java > 8e8834b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java > fc7a565 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java > 8e5aee8 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java > b021c37 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java > 972011d > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputConfigUploader.java > 8f8c4fd > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java > f1b422f > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputSimulate.java > df6c941 > > ambari-logsearch/ambari-logsearch-l
Re: Review Request 64607: Ambari Infra Manager: solr data exporting jobs and integration test environment
-infra-manager/src/main/resources/infra-manager.properties 7ef70aaf51 ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentExportPropertiesTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentItemReaderTest.java 942713f253 ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java 6411ff1788 ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrQueryBuilderTest.java 4d5ebf1144 ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrQueryPropertiesTest.java PRE-CREATION ambari-infra/pom.xml e4b6a7601f Diff: https://reviews.apache.org/r/64607/diff/2/ Changes: https://reviews.apache.org/r/64607/diff/1-2/ Testing --- * unit tests, * integration tests using docker containers * manual testing using docker containers and ide Thanks, Krisztian Kasa
Re: Review Request 64660: Rafactor: Package Log Search and Log Feeder into jars + cleanup start scripts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64660/#review194039 --- Ship it! Ship It! - Krisztian Kasa On Dec. 16, 2017, 1:27 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64660/ > --- > > (Updated Dec. 16, 2017, 1:27 p.m.) > > > Review request for Ambari, Attila Magyar, Krisztian Kasa, Miklos Gergely, and > Sid Wagle. > > > Bugs: AMBARI-22647 > https://issues.apache.org/jira/browse/AMBARI-22647 > > > Repository: ambari > > > Description > --- > > - package logsearch / logfeeder classes into jars > - create default logsearch-env and logfeeder-env files (those where only > generated by ambari stack code) > - rename run.sh start scripts to logsearch.sh and logfeeder.sh, and create a > symlink for those in /usr/bin/ > (therefore we can call commands like: 'logsearch start' or 'logfeeder test > --test-log-entry ...') > - refactor logfeeder command line tool -> new java entry point -> use it > through /usr/bin/logfeeder > - remove pid / process handling logic from ambari stack code (as the new > logsaerch/logfeeder script will handle those) > - move all config files from classes target/package/conf during maven package > phase > - move "/etc/ambari-logsearch-.../conf" folder to > /usr/lib/ambari-logsearch.../conf, keep the old one as a symlink. (this > solution is useful as we can include every requried files in a tar.gz as well > and it can work without provided rpm/deb) > - as conf file was moved out, we need to handle some cases during yum/apt > upgrade - move conf/keys/ or conf/checkpoints/ files to the new location (as > those could be generated there before and we do not want to loose them) > - as conf files are moved, cleanup maven assembly configs > - upgrade docker environment to make it work with the new changes > > > Diffs > - > > ambari-logsearch/ambari-logsearch-assembly/pom.xml cbc62ce > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/postinst > 21a01fa > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/postrm > 21a01fa > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/posttrm > 21a01fa > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/preinst > 21a01fa > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/portal/postinst > 21a01fa > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/portal/postrm > 21a01fa > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/portal/preinst > 21a01fa > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/rpm/logfeeder/postinstall.sh > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/rpm/logfeeder/postremove.sh > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/rpm/logfeeder/preinstall.sh > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/rpm/portal/postinstall.sh > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/rpm/portal/postremove.sh > PRE-CREATION > > ambari-logsearch/ambari-logsearch-assembly/src/main/package/rpm/portal/preinstall.sh > PRE-CREATION > ambari-logsearch/ambari-logsearch-logfeeder/README.md d2e55f0 > ambari-logsearch/ambari-logsearch-logfeeder/build.properties 013ba2e > ambari-logsearch/ambari-logsearch-logfeeder/build.xml 738b2ef > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 005af15 > ambari-logsearch/ambari-logsearch-logfeeder/run.sh 70947ec > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > 2d31e5a > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederCommandLine.java > 61e7a1e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigHandler.java > 35c0e6a > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/package/deb/control/control > 40cd855 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/package/deb/control/postinst > 21a01fa > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/package/deb/control/postrm > 21a01fa > > ambari-logsearch
Re: Review Request 63793: Log Feeder: cleanup checkpoint files periodically
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63793/#review190940 --- waitInterval -> waitIntervalMin - Krisztian Kasa On Nov. 14, 2017, 12:50 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63793/ > --- > > (Updated Nov. 14, 2017, 12:50 p.m.) > > > Review request for Ambari, Krisztian Kasa and Robert Nettleton. > > > Bugs: AMBARI-22395 > https://issues.apache.org/jira/browse/AMBARI-22395 > > > Repository: ambari > > > Description > --- > > - added new config: "max_age_min" (similar as detach_time_min) to input > block. that stored in checkpoint files, during cleanup, based on that the > checkpoint file can be deleted. > - based on "max_age_min" value, during bootstrap, its possible logfeeder wont > even monitor a file in the future. > - created a new thread which periodically run the checkpoint cleanup (now in > every 2000 minutes ... its ok to run that rearly) > - fix metrics sink, as its called if some properties are missing > - add new input test files (testing wildcard pattern) > - fix when fatal error thrown if no any files exist based on a wildcard > pattern > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java > 8548a20 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java > 96320e9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java > 8e70850 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java > 3910b9b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/CheckpointCleanupMonitor.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFileDetachMonitor.java > 322a56d > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFilePathUpdateMonitor.java > cc5d664 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java > 2d1bf40 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java > 1432c87 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java > 843ae6b > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetrcisManagerTest.java > 8ee6d00 > ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 068bc3a > > ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-storm.json > PRE-CREATION > > ambari-logsearch/docker/test-logs/storm/worker-logs/streamline-1-TestAgg-2-3/6701/worker.log > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63793/diff/2/ > > > Testing > --- > > done, manually, added new input file for docker env. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63793: Log Feeder: cleanup checkpoint files periodically
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63793/#review190941 --- Ship it! Ship It! - Krisztian Kasa On Nov. 14, 2017, 12:50 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63793/ > --- > > (Updated Nov. 14, 2017, 12:50 p.m.) > > > Review request for Ambari, Krisztian Kasa and Robert Nettleton. > > > Bugs: AMBARI-22395 > https://issues.apache.org/jira/browse/AMBARI-22395 > > > Repository: ambari > > > Description > --- > > - added new config: "max_age_min" (similar as detach_time_min) to input > block. that stored in checkpoint files, during cleanup, based on that the > checkpoint file can be deleted. > - based on "max_age_min" value, during bootstrap, its possible logfeeder wont > even monitor a file in the future. > - created a new thread which periodically run the checkpoint cleanup (now in > every 2000 minutes ... its ok to run that rearly) > - fix metrics sink, as its called if some properties are missing > - add new input test files (testing wildcard pattern) > - fix when fatal error thrown if no any files exist based on a wildcard > pattern > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/AbstractInputFile.java > 8548a20 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java > 96320e9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/InputManager.java > 8e70850 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/AbstractLogFileMonitor.java > 3910b9b > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/CheckpointCleanupMonitor.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFileDetachMonitor.java > 322a56d > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/monitor/LogFilePathUpdateMonitor.java > cc5d664 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java > 2d1bf40 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/MetricsManager.java > 1432c87 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/FileUtil.java > 843ae6b > > ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/metrics/MetrcisManagerTest.java > 8ee6d00 > ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 068bc3a > > ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-storm.json > PRE-CREATION > > ambari-logsearch/docker/test-logs/storm/worker-logs/streamline-1-TestAgg-2-3/6701/worker.log > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63793/diff/2/ > > > Testing > --- > > done, manually, added new input file for docker env. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63832: Reference Log Feeder IDE/maven dev setup in README.md
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63832/#review191057 --- Ship it! Ship It! - Krisztian Kasa On Nov. 15, 2017, 11:35 a.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63832/ > --- > > (Updated Nov. 15, 2017, 11:35 a.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Krisztian Kasa, > and Robert Nettleton. > > > Bugs: AMBARI-22450 > https://issues.apache.org/jira/browse/AMBARI-22450 > > > Repository: ambari > > > Description > --- > > small patch to reference logfeeder reamdme in the parent readme > > > Diffs > - > > ambari-logsearch/README.md 33952a2 > > > Diff: https://reviews.apache.org/r/63832/diff/1/ > > > Testing > --- > > not required. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63525/#review190024 --- Ship it! Ship It! - Krisztian Kasa On Nov. 2, 2017, 9:35 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63525/ > --- > > (Updated Nov. 2, 2017, 9:35 p.m.) > > > Review request for Ambari, Krisztian Kasa and Robert Nettleton. > > > Bugs: AMBARI-22357 > https://issues.apache.org/jira/browse/AMBARI-22357 > > > Repository: ambari > > > Description > --- > > change defaults configs + add more proper descriptions to use / setup log > search server local dev env quickly (with maven / IDE) > > > Diffs > - > > ambari-logsearch/README.md 43878f2 > ambari-logsearch/ambari-logsearch-server/.gitignore 07e0389 > ambari-logsearch/ambari-logsearch-server/README.md 126f651 > ambari-logsearch/ambari-logsearch-server/run.sh 765fe6c > > ambari-logsearch/ambari-logsearch-server/src/main/resources/logsearch.properties > db8a0a2 > > > Diff: https://reviews.apache.org/r/63525/diff/2/ > > > Testing > --- > > done, check with 'mvn clean spring-boot:run' and with IntelliJ as well. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63525/#review190025 --- Ship it! Ship It! - Krisztian Kasa On Nov. 2, 2017, 9:35 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63525/ > --- > > (Updated Nov. 2, 2017, 9:35 p.m.) > > > Review request for Ambari, Krisztian Kasa and Robert Nettleton. > > > Bugs: AMBARI-22357 > https://issues.apache.org/jira/browse/AMBARI-22357 > > > Repository: ambari > > > Description > --- > > change defaults configs + add more proper descriptions to use / setup log > search server local dev env quickly (with maven / IDE) > > > Diffs > - > > ambari-logsearch/README.md 43878f2 > ambari-logsearch/ambari-logsearch-server/.gitignore 07e0389 > ambari-logsearch/ambari-logsearch-server/README.md 126f651 > ambari-logsearch/ambari-logsearch-server/run.sh 765fe6c > > ambari-logsearch/ambari-logsearch-server/src/main/resources/logsearch.properties > db8a0a2 > > > Diff: https://reviews.apache.org/r/63525/diff/2/ > > > Testing > --- > > done, check with 'mvn clean spring-boot:run' and with IntelliJ as well. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63696: Exclude test scope jars from Log Search / Log Feeder rpm/deb packages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63696/#review190574 --- Ship it! Ship It! - Krisztian Kasa On Nov. 9, 2017, 12:53 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63696/ > --- > > (Updated Nov. 9, 2017, 12:53 p.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Aravindan > Vijayan, Krisztian Kasa, Miklos Gergely, and Robert Nettleton. > > > Bugs: branch-2.6 and trunk > https://issues.apache.org/jira/browse/branch-2.6 > https://issues.apache.org/jira/browse/trunk > > > Repository: ambari > > > Description > --- > > dependency plugin include all jars in target/libs, so we need to remove those > that has test scope > > > Diffs > - > > ambari-logsearch/ambari-logsearch-logfeeder/pom.xml cf64a36 > ambari-logsearch/ambari-logsearch-portal/pom.xml 53d6e8b > > > Diff: https://reviews.apache.org/r/63696/diff/2/ > > > Testing > --- > > UT done, target/libs folder does not contain easymock, checkstyle, > utility,junit jars > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64412: Log Search IT: Expose the right port for Selenium in docker-compose file
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64412/#review193110 --- Ship it! Ship It! - Krisztian Kasa On Dec. 7, 2017, 1:24 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64412/ > --- > > (Updated Dec. 7, 2017, 1:24 p.m.) > > > Review request for Ambari, Attila Doroszlai, Krisztian Kasa, Sid Wagle, and > Istvan Tobias. > > > Bugs: AMBARI-22611 > https://issues.apache.org/jira/browse/AMBARI-22611 > > > Repository: ambari > > > Description > --- > > Selenium server uses port not 4004 in docker container. > > > Diffs > - > > ambari-logsearch/docker/all.yml 82f0ff9 > > > Diff: https://reviews.apache.org/r/64412/diff/1/ > > > Testing > --- > > done. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64513: Update the default storm log search configuration (use wildcards)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/#review193502 --- Ship it! Ship It! - Krisztian Kasa On Dec. 11, 2017, 11:47 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64513/ > --- > > (Updated Dec. 11, 2017, 11:47 p.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Sid Wagle. > > > Bugs: AMBARI-22630 > https://issues.apache.org/jira/browse/AMBARI-22630 > > > Repository: ambari > > > Description > --- > > set the storm config defaults for logseach as other teams needs it. > > this patch is for branch-2.6, but if cannot be delivered in 2.6.1, that can > be used in a hotfix > > > Diffs > - > > > ambari-server/src/main/resources/common-services/STORM/0.9.1/configuration/storm-logsearch-conf.xml > d485017 > > > Diff: https://reviews.apache.org/r/64513/diff/1/ > > > Testing > --- > > not yet. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 64349: LogFeeder: filter objects for wildcard input paths need to be cloned
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64349/#review192987 --- Ship it! Ship It! - Krisztian Kasa On Dec. 5, 2017, 8:50 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64349/ > --- > > (Updated Dec. 5, 2017, 8:50 p.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert > Nettleton. > > > Bugs: AMBARI-22600 > https://issues.apache.org/jira/browse/AMBARI-22600 > > > Repository: ambari > > > Description > --- > > Log Feeder needs to clone filters for different input threads (for wildcard > pattern). > > As different threads tried to access the same grok filter object (mutable) > that could cause to some docs used the wrong path (or other fields), > especially when a grok error happened. (on error, in the code, we checked > some objects regarding that what to do, but other threads changed those > objects) > > Also some other changes: > - use sdi_* dynamic fields > - add new input log files > - add new config to grok filter: skip_on_error (can be useful for filter > chains) > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/Filter.java > afd903e > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java > 49d7e76 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java > 7df0b6e > > ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-storm.json > 34bdcf0 > > ambari-logsearch/docker/test-logs/storm/worker-logs/streamline-1-TestAgg-2-3/6701/worker.log > 6a10ad9 > > ambari-logsearch/docker/test-logs/storm/worker-logs/streamline-2-TestAgg2-4-5/6700/worker.log > e69de29 > > > Diff: https://reviews.apache.org/r/64349/diff/1/ > > > Testing > --- > > done, i need to write some unit tests for the filter cloning. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63393: Log Search: Add docker compose file for Log Search server and Log Feeder
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63393/#review189543 --- Ship it! Ship It! - Krisztian Kasa On Oct. 29, 2017, 10:19 a.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63393/ > --- > > (Updated Oct. 29, 2017, 10:19 a.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, Robert Nettleton, > and Sebastian Toader. > > > Bugs: AMBARI-22329 > https://issues.apache.org/jira/browse/AMBARI-22329 > > > Repository: ambari > > > Description > --- > > Add docker compose files for logsearch & logfeeder. > - add all.yml which contains all services in one container > - logsearch-server.yml and logsearch-logfeeder.yml -> define the services > separately > - some updates in the logearch-docker script > - create .env file for docker compose > - merge solr662.yml and solr.yml files as .env file was added. > - add docker-compose.yml as well which contains all services (by default that > can be used, then with the specific ones, like solr.yml, you can use them to > scale specific components - it can be used scale as those not expose any > ports) > - upgrade maven version in Dockerfile > > > Diffs > - > > ambari-logsearch/docker/.gitignore 99455ed > ambari-logsearch/docker/Dockerfile 5906a50 > ambari-logsearch/docker/all.yml PRE-CREATION > ambari-logsearch/docker/bin/start.sh 883ba02 > ambari-logsearch/docker/docker-compose.yml PRE-CREATION > ambari-logsearch/docker/logsearch-docker.sh 1660cee > ambari-logsearch/docker/logsearch-logfeeder.yml PRE-CREATION > ambari-logsearch/docker/logsearch-server.yml PRE-CREATION > ambari-logsearch/docker/solr.yml 727aba1 > ambari-logsearch/docker/solr662.yml b0641ed > ambari-logsearch/pom.xml 18ff45e > > > Diff: https://reviews.apache.org/r/63393/diff/3/ > > > Testing > --- > > done with docker-compose commands > > > Thanks, > > Oliver Szabo > >
Review Request 63416: Remove python & npm install from Log Search docker container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63416/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sandor Magyari. Bugs: AMBARI-22334 https://issues.apache.org/jira/browse/AMBARI-22334 Repository: ambari Description --- Remove python & npm install from Log Search docker container Additional solr host fixed in order to access solr from zookeper Diffs - ambari-logsearch/docker/Dockerfile 70e80b65e9 ambari-logsearch/docker/docker-compose.yml a6eeb0df6f ambari-logsearch/docker/logsearch-docker.sh b44e7ee43b Diff: https://reviews.apache.org/r/63416/diff/1/ Testing --- manully with docker-compose Thanks, Krisztian Kasa
Re: Review Request 63323: Get rid of deprecated Solr usages (infra + logsearch)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63323/#review189287 --- Ship it! Ship It! - Krisztian Kasa On Oct. 26, 2017, 9:24 a.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63323/ > --- > > (Updated Oct. 26, 2017, 9:24 a.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert > Nettleton. > > > Bugs: trunk > https://issues.apache.org/jira/browse/trunk > > > Repository: ambari > > > Description > --- > > As a lot of deprecated solr4j (solr 6+) methods will be deleted in solr 7 I > get rid of most of the solr 6 usages. > > One thign what i missing is the HttpClientUtil kerberos configurer changes, > about that, there is no class that can be compatible with both solr versions > > > Diffs > - > > > ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/AmbariSolrCloudClientBuilder.java > 54c4ae3 > > ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/CreateCollectionCommand.java > 53e96fd > > ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/CreateShardCommand.java > 9b57827 > > ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/commands/GetShardsCommand.java > e49bfec > > > Diff: https://reviews.apache.org/r/63323/diff/1/ > > > Testing > --- > > done. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63265: Log Feeder: allow applying grok filter on default fields (like type, path, host etc.)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63265/#review189175 --- Ship it! Ship It! - Krisztian Kasa On Oct. 24, 2017, 10:30 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63265/ > --- > > (Updated Oct. 24, 2017, 10:30 p.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert > Nettleton. > > > Bugs: AMBARI-22300 > https://issues.apache.org/jira/browse/AMBARI-22300 > > > Repository: ambari > > > Description > --- > > add new "init_default_fields" config param to input block. If that option is > turned on, then logfeeder will apply the default fields before any grok > filter is applied (right now it should just work with grok filter > > > Diffs > - > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterGrok.java > deff1b2 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/input/Input.java > 6f6bb6d > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputManager.java > 8bf6ae3 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/LogFeederUtil.java > 73cf449 > > > Diff: https://reviews.apache.org/r/63265/diff/1/ > > > Testing > --- > > UTs done > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63429: Log Search: add descriptions about how to use Log Search environment with docker compose
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63429/#review189695 --- Ship it! Ship It! - Krisztian Kasa On Oct. 30, 2017, 9:04 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63429/ > --- > > (Updated Oct. 30, 2017, 9:04 p.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, Robert Nettleton, > Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-22331 > https://issues.apache.org/jira/browse/AMBARI-22331 > > > Repository: ambari > > > Description > --- > > Update README.md of Log Search > > > Diffs > - > > ambari-logsearch/README.md d05f45a > > > Diff: https://reviews.apache.org/r/63429/diff/1/ > > > Testing > --- > > not required > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63328: Log Search: Add docker-compose file for creating ZooKeeper containers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63328/#review189424 --- Ship it! Ship It! - Krisztian Kasa On Oct. 27, 2017, 9:54 a.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63328/ > --- > > (Updated Oct. 27, 2017, 9:54 a.m.) > > > Review request for Ambari, Krisztian Kasa, Laszlo Puskas, Miklos Gergely, > Robert Nettleton, and Sebastian Toader. > > > Bugs: AMBARI-22314 > https://issues.apache.org/jira/browse/AMBARI-22314 > > > Repository: ambari > > > Description > --- > > In order to separate components for logsearch dev env we need to create > separate docker containers for all of them (zookeeper, solr, logsearch, > logfeeder) > > Its much more clear to use a docker-compose file for it, and also we should > use the offical zookeeper/solr images. > > First patch contains the zookeeper compose file. > > > Diffs > - > > ambari-logsearch/docker/docker-compose-zookeeper.yml PRE-CREATION > > > Diff: https://reviews.apache.org/r/63328/diff/1/ > > > Testing > --- > > done, with "docker-compose -f docker-compose-zookeeper.yml up -d" > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63360: Log Search: Add docker compose file for Solr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63360/#review189451 --- Ship it! Ship It! - Krisztian Kasa On Oct. 27, 2017, 1:19 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63360/ > --- > > (Updated Oct. 27, 2017, 1:19 p.m.) > > > Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert > Nettleton. > > > Bugs: AMBARI-22315 > https://issues.apache.org/jira/browse/AMBARI-22315 > > > Repository: ambari > > > Description > --- > > its the next part of https://reviews.apache.org/r/63328/ > > contains some renames as well > > > Diffs > - > > ambari-logsearch/docker/docker-compose-zookeeper.yml a41eaf3 > ambari-logsearch/docker/solr.yml PRE-CREATION > ambari-logsearch/docker/solr662.yml PRE-CREATION > ambari-logsearch/docker/zookeeper.yml PRE-CREATION > > > Diff: https://reviews.apache.org/r/63360/diff/1/ > > > Testing > --- > > done with docker-compose up -d > > > Thanks, > > Oliver Szabo > >
Re: Review Request 63362: Fix Log Search configuration dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63362/#review189452 --- Ship it! Ship It! - Krisztian Kasa On Oct. 27, 2017, 4:28 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63362/ > --- > > (Updated Oct. 27, 2017, 4:28 p.m.) > > > Review request for Ambari, Krisztian Kasa, Oliver Szabo, and Robert Nettleton. > > > Bugs: AMBARI-22328 > https://issues.apache.org/jira/browse/AMBARI-22328 > > > Repository: ambari > > > Description > --- > > logsearch-service_logs-solrconfig and logsearch-audit_logs-solrconfig config > groups are specified with .xml, logsearch-common-properties is not present at > all as a dependency. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml > 4a7b3e0 > > > Diff: https://reviews.apache.org/r/63362/diff/1/ > > > Testing > --- > > Tested on local cluster. > > > Thanks, > > Miklos Gergely > >
Review Request 64976: Ambari Infra Manager: hdfs upload support
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64976/ --- Review request for Ambari, Attila Doroszlai, Oliver Szabo, and Sid Wagle. Bugs: AMBARI-22731 https://issues.apache.org/jira/browse/AMBARI-22731 Repository: ambari Description --- * while arhiving documents from solr result files can be saved to hdfs * s3 and hdfs releated parameters can be overwritten using infra manger api * destination directory name contains the interval end value when archiving to local filesystem * job can be restarted using infra manger api * bugfix: infra manger startup failed when no jobs were defined in the properties * IT: test for archiving to hdfs * IT: test for archiving to local filesystem * vagrant-infra-manager.properties file for integration testing with an ambari installed cluster Diffs - ambari-infra/ambari-infra-manager-it/pom.xml 97e8ea0f44 ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraClient.java 0e391a3e6e ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/AbstractInfraSteps.java f48d4c2b49 ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/steps/ExportJobsSteps.java 22826a01fc ambari-infra/ambari-infra-manager-it/src/test/resources/stories/infra_api_tests.story 1044258816 ambari-infra/ambari-infra-manager/docker/docker-compose.yml 1172631917 ambari-infra/ambari-infra-manager/docker/infra-manager-docker-compose.sh 6ddb7c292a ambari-infra/ambari-infra-manager/pom.xml de131b03f6 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/JobProperties.java 0841dd7fd9 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentArchivingConfiguration.java 7588b9992a ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentExportProperties.java 1484eedfe3 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/ExportDestination.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/FileNameSuffixFormatter.java af48ab9aaa ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/HdfsUploader.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingConfiguration.java 4fce4b677f ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/model/JobExecutionRestartRequest.java 88687e7260 ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 9103d09e7e ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/JobPropertiesTest.java 6a7622954f ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/FileNameSuffixFormatterTest.java 34e679f298 ambari-infra/ambari-infra-manager/src/test/resoruces/vagrant-infra-manager.properties PRE-CREATION ambari-infra/pom.xml 9e7a71bfa7 Diff: https://reviews.apache.org/r/64976/diff/1/ Testing --- * unit tests * integration test using docker * integration test using vagrant, ambari and ide Thanks, Krisztian Kasa
Re: Review Request 64852: Ambari Infra Manager: deleting documents
/java/org/apache/ambari/infra/job/archive/TarGzCompressor.java 55ba58a0f2 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/WriteCompletedEvent.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingConfiguration.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingProperties.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingPropertyMap.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentWiperTasklet.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 27b36b36fc ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentExportPropertiesTest.java ae93710b2d ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/FileNameSuffixFormatterTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java 3af93bc25d ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrParametrizedStringTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrPropertiesTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrQueryBuilderTest.java e9513dccd9 Diff: https://reviews.apache.org/r/64852/diff/3/ Changes: https://reviews.apache.org/r/64852/diff/2-3/ Testing --- * unit tests, * integration tests using docker containers * manual testing using docker containers and ide Thanks, Krisztian Kasa
Re: Review Request 64852: Ambari Infra Manager: deleting documents
/java/org/apache/ambari/infra/job/archive/SolrQueryBuilder.java b3ea14ed65 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/TarGzCompressor.java 55ba58a0f2 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/WriteCompletedEvent.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingConfiguration.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingProperties.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingPropertyMap.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentWiperTasklet.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 27b36b36fc ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentExportPropertiesTest.java ae93710b2d ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/FileNameSuffixFormatterTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java 3af93bc25d ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrParametrizedStringTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrPropertiesTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrQueryBuilderTest.java e9513dccd9 Diff: https://reviews.apache.org/r/64852/diff/2/ Changes: https://reviews.apache.org/r/64852/diff/1-2/ Testing --- * unit tests, * integration tests using docker containers * manual testing using docker containers and ide Thanks, Krisztian Kasa
Review Request 64850: Fixing interface and file renaming issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64850/ --- Review request for Ambari, Attila Doroszlai, Oliver Szabo, and Sid Wagle. Bugs: AMBARI-22653 https://issues.apache.org/jira/browse/AMBARI-22653 Repository: ambari Description --- Patch https://reviews.apache.org/r/64607 contains two renamed interfaces: DocumentIterator -> CloseableIterator DocumentSource -> ItemWriterListener but the files containing these interface definitions were not renamed on trunk git repo Diffs - ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java Diff: https://reviews.apache.org/r/64850/diff/1/ Testing --- maven build unit and integration tests Thanks, Krisztian Kasa
Re: Review Request 64850: Fixing interface and file renaming issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64850/ --- (Updated Dec. 27, 2017, 10:20 a.m.) Review request for Ambari, Attila Doroszlai, Oliver Szabo, and Sid Wagle. Bugs: AMBARI-22653 https://issues.apache.org/jira/browse/AMBARI-22653 Repository: ambari Description (updated) --- Patch https://reviews.apache.org/r/64607 contains two renamed interfaces: DocumentIterator -> CloseableIterator DocumentSource -> ItemWriterListener but the files containing these interface definitions were not renamed on trunk git repo Using java.util.ArrayList insted of com.google.common.collect.Lists.newArrayList() Diffs (updated) - ambari-infra/ambari-infra-manager-it/src/test/java/org/apache/ambari/infra/InfraManagerStories.java cf720ef0d0 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentIterator.java 5fa29b0099 ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/archive/DocumentSource.java 742777109e Diff: https://reviews.apache.org/r/64850/diff/2/ Changes: https://reviews.apache.org/r/64850/diff/1-2/ Testing --- maven build unit and integration tests Thanks, Krisztian Kasa
Review Request 64852: Ambari Infra Manager: deleting documents
-manager/src/main/java/org/apache/ambari/infra/job/archive/WriteCompletedEvent.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingConfiguration.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingProperties.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentDeletingPropertyMap.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/java/org/apache/ambari/infra/job/deleting/DocumentWiperTasklet.java PRE-CREATION ambari-infra/ambari-infra-manager/src/main/resources/infra-manager.properties 27b36b36fc ambari-infra/ambari-infra-manager/src/main/resources/s3.properties PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/DocumentExportPropertiesTest.java ae93710b2d ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/FileNameSuffixFormatterTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/LocalDocumentItemWriterTest.java 3af93bc25d ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrParametrizedStringTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrPropertiesTest.java PRE-CREATION ambari-infra/ambari-infra-manager/src/test/java/org/apache/ambari/infra/job/archive/SolrQueryBuilderTest.java e9513dccd9 Diff: https://reviews.apache.org/r/64852/diff/1/ Testing --- * unit tests, * integration tests using docker containers * manual testing using docker containers and ide Thanks, Krisztian Kasa
