/ambari/server/controller/internal/AbstractProviderModule.java
(line 1175)
<https://reviews.apache.org/r/48221/#comment201118>
one day we'll support multi-cluster, so maybe this should combine cluster
name + component
- Nate Cole
On June 3, 2016, 4:56 p.m., Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48221/#review136112
---
Ship it!
Ship It!
- Nate Cole
On June 3, 2016, 5:30 p.m
/PropertyInfo.java
(lines 53 - 54)
<https://reviews.apache.org/r/48403/#comment201756>
Is this being removed to focus only on Ambari Upgrade
- Nate Cole
On June 8, 2016, 6:06 a.m., Dmitro Lisnichenko
/ambari/server/alerts/StaleAlertRunnable.java
(lines 76 - 81)
<https://reviews.apache.org/r/48436/#comment201885>
Should this be a parameter of the alert definition?
- Nate Cole
On June 8, 2016, 2:24 p.m., Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48403/#review136808
---
Ship it!
Ship It!
- Nate Cole
On June 9, 2016, 9:12 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48287/#review136347
---
Ship it!
Ship It!
- Nate Cole
On June 6, 2016, 1:20 p.m
. Was there some missed
files?
- Nate Cole
On June 6, 2016, 1:20 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48258/#review136359
---
Ship it!
Ship It!
- Nate Cole
On June 6, 2016, 3:54 p.m
] Finished at: Mon Jun 06 17:26:34 EDT 2016
[INFO] Final Memory: 35M/569M
[INFO]
Thanks,
Nate Cole
.
- Nate Cole
On June 10, 2016, 1:10 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
kar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
>
> (Updated June 10, 2016, 8:47 a.m.)
>
/VersionDefinitionResourceProvider.java
c18d722
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
e0ff2b3
Diff: https://reviews.apache.org/r/48562/diff/
Testing
---
Manual. Automated pending
Thanks,
Nate Cole
] Final Memory: 35M/661M
[INFO]
Thanks,
Nate Cole
)
<https://reviews.apache.org/r/48498/#comment201921>
This was an annoyance as I tried to run an agent that was upgraded after I
changed ambari.ini.
- Nate Cole
On June 9, 2016, 12:49 p.m., Nate Cole
Memory: 33M/689M
[INFO] ----
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48234/#review136145
---
Ship it!
Ship It!
- Nate Cole
On June 3, 2016, 6:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48205/#review136118
---
Ship it!
Ship It!
- Nate Cole
On June 3, 2016, 9:56 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48181/#review136058
---
Ship it!
Ship It!
- Nate Cole
On June 2, 2016, 2:34 p.m
2119413
Diff: https://reviews.apache.org/r/48204/diff/
Testing
---
No automated testing, it's just XML change. Manual tested following:
- Default Install of 2.5.0.0 (make no URL changes, just "click through").
- Install 2.5.0.0, but change the URL to the version previous
Tha
/services/stack_advisor.py (line
209)
<https://reviews.apache.org/r/48162/#comment201043>
%s % syntax is not the standard anymore, use "".format(...)
- Nate Cole
On June 2, 2016, 12:38 p.m.,
> On May 24, 2016, 4:41 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java,
> > lines 190-194
> > <https://reviews.apache.org/r/47783/diff/1/?file=1392703#file1392703line190>
> >
&
ply, visit:
> https://reviews.apache.org/r/47785/
> ---
>
> (Updated May 25, 2016, 6:06 p.m.)
>
>
> Review request for Ambari, John Speidel, Nate Cole, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-16853 and ATLAS-823
> https://issue
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48516/#review136989
---
Ship it!
Ship It!
- Nate Cole
On June 9, 2016, 7 p.m., Josh
/RepositoryVersionResourceProvider.java
62568cf
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
3bc4aec
Diff: https://reviews.apache.org/r/48657/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48516/#review137497
---
What is the status of this review?
- Nate Cole
On June 9, 2016
ambari/server/api/services/RequestFactory.java
(line 69)
<https://reviews.apache.org/r/48702/#comment202729>
createReadRequest() ?
- Nate Cole
On June 14, 2016, 2:57 p.m., Robert Levas wrote:
>
> ---
> This is an automatic
> On June 14, 2016, 3:24 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java,
> > line 69
> > <https://reviews.apache.org/r/48702/diff/1/?file=1418983#file1418983line69>
> >
> > create
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48702/#review137720
---
Ship it!
Ship It!
- Nate Cole
On June 14, 2016, 7:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48557/#review137357
---
Ship it!
Ship It!
- Nate Cole
On June 13, 2016, 9:22 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48655/#review137359
---
Ship it!
Ship It!
- Nate Cole
On June 13, 2016, 1:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48640/#review137358
---
Ship it!
Ship It!
- Nate Cole
On June 13, 2016, 2:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48415/#review136644
---
Ship it!
Ship It!
- Nate Cole
On June 8, 2016, 9:53 a.m
://reviews.apache.org/r/48088/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
query framework or something)?
- Nate Cole
On May 27, 2016, 6:01 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47933/#review135256
---
Ship it!
Ship It!
- Nate Cole
On May 27, 2016, 6:01 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47961/#review135261
---
Ship it!
Ship It!
- Nate Cole
On May 27, 2016, 12:26 p.m
/#comment200288>
nit: you have two Runnables that do nearly the identical thing except how
to parse the resulting InputStream. Could push most of the run() to
MetricsRunnable and just have your subclasses parse.
- Nate Cole
On May 27, 2016, 1:27 p.m., Jon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47933/#review135300
---
Ship it!
Ship It!
- Nate Cole
On May 27, 2016, 3:58 p.m
-
>
> (Updated May 27, 2016, 4:15 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, Nate Cole, and Sumit
> Mohanty.
>
>
> Bugs: AMBARI-16938
> https://issues.apache.org/jira/browse/AMBARI-16938
>
>
> Repository: ambari
>
>
org.apache.ambari.server.state.repository.VersionDefinitionTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.595 sec - in
org.apache.ambari.server.state.repository.VersionDefinitionTest
Results :
Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
Thanks,
Nate Cole
]
Thanks,
Nate Cole
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/47867/#review134902
---
On May 25, 2016, 8:54 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e
/upgrades/upgrade-2.5.xml (lines
897 - 899)
<https://reviews.apache.org/r/47871/#comment199970>
Why does downgrade get this message but not upgrade?
- Nate Cole
On May 25, 2016, 9:54 p.m., Alejandro Fernandez
Just wanted to make sure if this always be true?
>
> Nate Cole wrote:
> I think this assumption should be ok - we are already doing the symlink
> magic to point to the right spot.
>
> Tom Beerbower wrote:
> Thanks for the review Srimanth and Nat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47785/#review134975
---
Ship it!
Ship It!
- Nate Cole
On May 25, 2016, 6:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48036/#review135840
---
Ship it!
Ship It!
- Nate Cole
On June 1, 2016, 12:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/#review135792
---
Ship it!
Ship It!
- Nate Cole
On May 27, 2016, 6:48 p.m
eleted). Maybe
just make the host name where it was found to be informational rather than the
getFailedOn(). And in fact, getFailedOn() would be HDFS, not SNN since it's a
service and SNN is a component.
Either way, should make sure a test covers this appropriately.
- Nate Cole
On
f fail messages to see how to do it.
- Nate Cole
On May 30, 2016, 9:30 a.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
] Finished at: Fri May 27 18:08:19 EDT 2016
[INFO] Final Memory: 33M/672M
[INFO]
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47018/#review135643
---
Ship it!
Ship It!
- Nate Cole
On May 26, 2016, 12:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48708/#review137599
---
Ship it!
Ship It!
- Nate Cole
On June 14, 2016, 5:33 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48041/#review137961
---
Hi Dmitry, what's the status of this review/patch?
- Nate Cole
]
Thanks,
Nate Cole
-
>
> (Updated June 16, 2016, 5:02 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Vitalyi
> Brodetskyi.
>
>
> Bugs: AMBARI-17284
> https://issues.apache.org/jira/browse/AMBARI-17284
>
>
> Repository: ambari
>
>
>
[INFO] Finished at: Thu Mar 17 08:26:54 EDT 2016
[INFO] Final Memory: 38M/566M
[INFO]
Thanks,
Nate Cole
/HeartBeatHandler.java
(lines 287 - 289)
<https://reviews.apache.org/r/44986/#comment186680>
Use {} format for log statements like so: LOG.info("Recovery configuration
set to {}", response.getRecoveryConfig());
- Nate Cole
On March 17, 2016, 7 p.m., Nahappan So
/controller/internal/UpgradeResourceProvider.java
(line 461)
<https://reviews.apache.org/r/45035/#comment186677>
formatting :)
- Nate Cole
On March 18, 2016, 11:20 a.m., Jonathan Hurley wrote:
>
> ---
> This is a
ld be
doing this. If it's enabled, it's enabled.
- Nate Cole
On March 14, 2016, 6 p.m., Nahappan Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/VersionDefinitionTest.java
f2939c7
ambari-server/src/test/resources/version_definition_test.xml 69ea581
Diff: https://reviews.apache.org/r/44983/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44986/#review124222
---
Ship it!
Ship It!
- Nate Cole
On March 17, 2016, 7 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45390/#review125714
---
Ship it!
Ship It!
- Nate Cole
On March 28, 2016, 1:21 p.m
/orm/entities/UpgradeEntity.java
(lines 203 - 205)
<https://reviews.apache.org/r/45321/#comment188591>
I see this in trunk already as isSuspended() ?
- Nate Cole
On March 24, 2016, 6:28 p.m., Alejandro Fernandez
remember to have to come here.
- Nate Cole
On March 24, 2016, 8:20 a.m., Daniel Gergely wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44265/#review126138
---
Ship it!
Ship It!
- Nate Cole
On March 30, 2016, 11:20 a.m
ent189033>
setSettings(...) (plural) ?
- Nate Cole
On March 29, 2016, 10:17 p.m., Nahappan Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
> On April 6, 2016, 9:59 a.m., Nate Cole wrote:
> > Is this hooked in anywhere? I don't see any API calls (but that's probably
> > ok for this review). Any ambari-admin view changes?
>
> Zhe (Joe) Wang wrote:
> I thought the requirement for this issue is to expose
> On March 29, 2016, 8:49 a.m., Nate Cole wrote:
> > I think you need a more concrete way of ordering here. What if two
> > services are marked as YARN? Which one takes precedence? You may
> > want to introduce an in order to
> > specifically state how it happe
/709M
[INFO]
Thanks,
Nate Cole
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryResourceProviderTest.java
48eeaf8
Diff: https://reviews.apache.org/r/45877/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45877/#review127647
---
Ping
- Nate Cole
On April 7, 2016, 1:55 p.m., Nate Cole wrote
:07:01 EDT 2016
[INFO] Final Memory: 36M/670M
[INFO]
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45896/#review127780
---
Ship it!
Look at you, back in the mix :)
- Nate Cole
/diff/
Testing
---
Manual. Automated in progress.
Thanks,
Nate Cole
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45811/#review127353
---
On April 6, 2016, 10:03 a.m., Nate Cole wrote:
>
> ---
> This is an automatically g
calls (but that's probably ok
for this review). Any ambari-admin view changes?
- Nate Cole
On April 5, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45903/#review127818
---
Ship it!
Ship It!
- Nate Cole
On April 7, 2016, 8:36 p.m
6/#review128218
---
On April 11, 2016, 3:27 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
/ClusterStackVersionResourceProviderTest.java
dea83a1
ambari-server/src/test/python/custom_actions/TestInstallPackages.py f022c80
ambari-server/src/test/resources/hbase_version_test.xml 9df07ed
Diff: https://reviews.apache.org/r/44931/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
at: Wed Mar 16 17:50:32 EDT 2016
[INFO] Final Memory: 35M/776M
[INFO]
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44878/#review123865
---
Ship it!
Ship It!
- Nate Cole
On March 15, 2016, 8:57 p.m
]
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45218/#review125063
---
Ship it!
Ship It!
- Nate Cole
On March 23, 2016, 12:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45253/#review125295
---
Ship it!
Ship It!
- Nate Cole
On March 24, 2016, 12:42 p.m
]
Thanks,
Nate Cole
/agent/RecoveryConfigHelper.java
(lines 150 - 152)
<https://reviews.apache.org/r/45253/#comment188022>
Is there a unit test that can be added to make sure we don't accidentally
revert this fix somehow?
- Nate Cole
On March 23, 2016, 6:45 p.m., Nahappan Somasundaram
]
[INFO] Total time: 35:07.392s
[INFO] Finished at: Fri Apr 01 09:35:30 EDT 2016
[INFO] Final Memory: 37M/754M
[INFO]
Thanks,
Nate Cole
generated e-mail. To reply, visit:
https://reviews.apache.org/r/45586/#review126619
---
On April 1, 2016, 12:43 p.m., Nate Cole wrote:
>
> ---
> Thi
can still be per-os, even if the use case here means it's optional.
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45586/#review126595
---
On April 1, 2016, 11:59 a.m., Nate Cole wrote:
>
> --
s really a warning? Kind of odd to warn on a feature.
Will fix.
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45703/#review127013
--
rning?
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
(lines 392 - 397)
<https://reviews.apache.org/r/45442/#comment188869>
I have no idea how this hostClusterMap relationship came to be :)
- Nate Cole
On March 29, 2016, 3:32 p.m.,
/version_builder.py 6c20a47
Diff: https://reviews.apache.org/r/45487/diff/
Testing
---
Manual. No automated tests for contrib.
Thanks,
Nate Cole
sit:
https://reviews.apache.org/r/45487/#review126107
---
On March 30, 2016, 9:55 a.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45540/#review126304
---
Ship it!
Ship It!
- Nate Cole
On March 31, 2016, 9:33 a.m
://reviews.apache.org/r/45586/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
Manual. Automated pending
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45712/#review126966
---
Ship it!
Ship It!
- Nate Cole
On April 4, 2016, 6:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46155/#review128726
---
Ship it!
Ship It!
- Nate Cole
On April 13, 2016, 1:17 p.m
://reviews.apache.org/r/46159/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
1 - 100 of 891 matches
Mail list logo
