Review Request 64552: Fix misuses of os.path.dirname(path) in yarn.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64552/ --- Review request for Ambari, Andrew Onischuk and Dmytro Sen. Bugs: AMBARI-22637 https://issues.apache.org/jira/browse/AMBARI-22637 Repository: ambari Description --- os.path.dirname(path) does not return parent directory if the path ends with '/'. We should use os.path.dirname(os.path.abspath(path)) to get parent directory. Diffs - ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py d077c848f2 ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py 7731aeb09b contrib/management-packs/odpi-ambari-mpack/src/main/resources/stacks/ODPi/2.0/services/YARN/package/scripts/yarn.py 147fb38dc2 Diff: https://reviews.apache.org/r/64552/diff/1/ Testing --- Jenkins result -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12901718/AMBARI-22637.001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 core tests. The patch passed unit tests in ambari-server. Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/12831//console Thanks, Akira Ajisaka
Review Request 59621: Use java.util.concurrent.ConcurrentHashMap instead of org.jboss.netty.util.internal.ConcurrentHashMap.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59621/ --- Review request for Ambari, Jaimin Jetly and Jonathan Hurley. Bugs: AMBARI-20827 https://issues.apache.org/jira/browse/AMBARI-20827 Repository: ambari Description --- Replace the usage of org.jboss.netty.util.internal.ConcurrentHashMap with java.util.concurrent.ConcurrentHashMap. This change is required for building Apache Ambari on Ubuntu 16.04 by Apache BigTop. Please see BIGTOP-2771 for the detail. Diffs - ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java 93eef36702 ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java f1e93ac8b9 Diff: https://reviews.apache.org/r/59621/diff/1/ Testing --- I didn't test it. Probably testing is not needed for this patch. Thanks, Akira Ajisaka
Re: Review Request 49935: AMBARI-17633 yarn.nodemanager.remote-app-log-dir should be added stickybit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49935/#review142307 --- Ship it! Built Hadoop cluster with Apache Ambari with editing the yarn.py. The permission of the directory is correct after the patch. +1 (non-binding) - Akira Ajisaka On 7月 12, 2016, 9:55 p.m., Masahiro Tanaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49935/ > --- > > (Updated 7月 12, 2016, 9:55 p.m.) > > > Review request for Ambari, Andrew Onischuk, jun aoki, and Myroslav > Papirkovskyy. > > > Bugs: AMBARI-17633 > https://issues.apache.org/jira/browse/AMBARI-17633 > > > Repository: ambari > > > Description > --- > > When installing YARN+MapReduce2, I got a WARN message in nodemanager log(in > Log Search View) like below > ``` > 2016-07-09 06:30:21,865 WARN logaggregation.LogAggregationService > LogAggregationService.java:230 - Remote Root Log Dir [/app-logs] already > exist, but with incorrect permissions. Expected: [rwxrwxrwt], Found: > [rwxrwxrwx]. The cluster may have problems with multiple users. > ``` > I think the cause of this WARN is > [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py#L115). > We should add stickybit to yarn.nodemanager.remote-app-log-dir. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py > cf5736e > ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py > 4600063 > > Diff: https://reviews.apache.org/r/49935/diff/ > > > Testing > --- > > mvn clean test && manual test > > I think Hadoop QA result is unrelated to this patch > > > Thanks, > > Masahiro Tanaka > >
Re: Review Request 45374: Use ">>" instead of ">" to write ambari-metrics-collector.out
> On 4月 6, 2016, 9:05 a.m., Akira Ajisaka wrote: > > Can someone commit it? > > Dmytro Sen wrote: > Committed to trunk. > > Thanks Akira. Thank you, Dmytro and Aravindan! - Akira --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45374/#review127304 --- On 3月 30, 2016, 2:02 a.m., Akira Ajisaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45374/ > --- > > (Updated 3月 30, 2016, 2:02 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle. > > > Bugs: AMBARI-15588 > https://issues.apache.org/jira/browse/AMBARI-15588 > > > Repository: ambari > > > Description > --- > > If we want to rotate ambari-metrics-collector.out by logrotate (using > copytruncate option), we need to use ">>" instead of ">" not to keep the file > offset to write. If the offset is kept, null characters are padded in the new > file. > > > Diffs > - > > > ambari-metrics/ambari-metrics-host-monitoring/conf/unix/ambari-metrics-monitor > 7464c55 > > Diff: https://reviews.apache.org/r/45374/diff/ > > > Testing > --- > > Manually tested the patch and verified that the .out is rotated collectly. > > > Thanks, > > Akira Ajisaka > >
Review Request 45374: Use ">>" instead of ">" to write ambari-metrics-collector.out
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45374/ --- Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle. Bugs: AMBARI-15588 https://issues.apache.org/jira/browse/AMBARI-15588 Repository: ambari Description --- If we want to rotate ambari-metrics-collector.out by logrotate (using copytruncate option), we need to use ">>" instead of ">" not to keep the file offset to write. If the offset is kept, null characters are padded in the new file. Diffs - ambari-metrics/ambari-metrics-host-monitoring/conf/unix/ambari-metrics-monitor 7464c55 Diff: https://reviews.apache.org/r/45374/diff/ Testing --- Manually tested the patch and verified that the .out is rotated collectly. Thanks, Akira Ajisaka
