Re: Review Request 61617: Additional fixes to stacks config paths

2017-08-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61617/#review182894 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 14, 2017

Re: Review Request 61619: Result of install_packages uses version string instead of repo_version_id

2017-08-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61619/#review182884 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 14, 2017, 3

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61024/#review182881 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 8, 2017, 5

Re: Review Request 61592: AMBARI-21708. History Server cannot be started due to wrong permissions of /mr-history

2017-08-11 Thread Alejandro Fernandez
/package/scripts/yarn.py Lines 330 (patched) <https://reviews.apache.org/r/61592/#comment258709> Also change this in HDP 3.0 - Alejandro Fernandez On Aug. 11, 2017, 9:07 a.m., Attila Doroszlai wrote: > > --- > This is a

Re: Review Request 61527: AMBARI-21649 : Update Atlas log4j to reflect latest configurations

2017-08-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61527/#review182625 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 10, 2017, 9

Re: Review Request 61542: Problem in starting accumulo in upgraded cluster (IOP-HDP)

2017-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61542/#review182532 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 9, 2017, 9

Re: Review Request 61525: AMBARI-21690 Updating get_stack_version pattern match

2017-08-09 Thread Alejandro Fernandez
/functions/get_stack_version.py Line 88 (original), 88 (patched) <https://reviews.apache.org/r/61525/#comment258420> Just do this instead, [0-9]+.[0-9]+.[0-9]+.[0-9]+(-[0-9]+)? - Alejandro Fernandez On Aug. 9, 2017, 1:07 p.m., Mugdha Varadkar

Re: Review Request 61521: Fix raceconditions causing ambari-agent to hang/fail

2017-08-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61521/#review182506 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 9, 2017, 10

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-08-08 Thread Alejandro Fernandez
mmands/StackAdvisorCommand.java Lines 184 (patched) <https://reviews.apache.org/r/61024/#comment258334> Why is this issuing an HTTP call instead of calling the method directly to make it more efficient? - Alejandro Fernandez On Aug. 8, 2017, 5:57 p.m., Balázs Benc

Re: Review Request 61500: Service Checks Will Run Multiple Times In Patch/Service Upgrades

2017-08-08 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61500/#review182425 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 8, 2017, 4

Re: Review Request 61481: HDFS namenode rpc and connection load metrics are not showing

2017-08-07 Thread Alejandro Fernandez
/HDP/2.0.6/hooks/before-START/scripts/params.py Line 334 (original), 334 (patched) <https://reviews.apache.org/r/61481/#comment258204> Also change in the hooks for HDP 3.0 - Alejandro Fernandez On Aug. 7, 2017, 9:10 p.m., Sid Wagle

Re: Review Request 61479: Add Secure Flag to Cookie / JSESSIONID in Zeppelin

2017-08-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61479/#review182316 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 7, 2017, 8

Re: Review Request 61453: AMBARI-21634 Make sure Ambari also considers NIS users

2017-08-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61453/#review182306 --- What OS'es was this tested on? - Alejandro Fernandez On Aug. 7

Re: Review Request 61462: Update Orchestration to support MAINT

2017-08-07 Thread Alejandro Fernandez
/ambari/server/state/UpgradeContext.java Lines 931 (patched) <https://reviews.apache.org/r/61462/#comment258186> Typo in orchestration - Alejandro Fernandez On Aug. 7, 2017, 3:04 p.m., Jonathan Hurley

Re: Review Request 61459: Expose via API whether a service will participate in an upgrade

2017-08-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61459/#review182286 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 7, 2017, 2

Re: Review Request 61456: Create a topic to send alert_definitions

2017-08-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61456/#review182285 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 7, 2017, 11

Re: Review Request 61447: AMBARI-21607. HIVE_AUX_JARS_PATH points to wrong location

2017-08-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61447/#review182264 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 6, 2017, 11

Re: Review Request 61414: Patch/Service Downgrades Are Not Correctly Scoped

2017-08-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61414/#review182170 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 3, 2017, 8

Re: Review Request 61415: AMBARI-21654 Post Ambari upgrade, BI value add 4.2 services should still be able to restart

2017-08-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61415/#review182160 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 3, 2017, 8

Re: Review Request 61405: AMBARI-21650 Ranger Usersync process starts with older stack script during cross stack upgrade

2017-08-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61405/#review182133 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 3, 2017, 1

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Alejandro Fernandez
283/diff/1-2/ Testing --- Inspected manually Thanks, Alejandro Fernandez

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Alejandro Fernandez
61283/#comment257877> ranger-knox-audit exists in both BigInsights 4.2 and 4.2.5 and did not delete the properties in 4.2.5, so both upgrade packs need to delete these configs. - Alejandro Fernandez On Aug. 1, 2017, 1

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Alejandro Fernandez
> On Aug. 2, 2017, 11:44 a.m., Tim Thorpe wrote: > > Are these needed in BigInsights 4.2.5 as well? > > Alejandro Fernandez wrote: > EU from BigInsights 4.2 to 4.2.5 already fixed most/all of these > properties already. I can still include it in 4.2.5 just to b

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Alejandro Fernandez
matically generated e-mail. To reply, visit: https://reviews.apache.org/r/61283/#review181964 --- On Aug. 1, 2017, 10:34 p.m., Alejandro Fernandez wrote: > > --- > This is an automat

Re: Review Request 61317: Configs For Target Stack Are Not Created During Upgrade

2017-08-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61317/#review182035 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 2, 2017, 12

Re: Review Request 61376: AMBARI-21635 Show Audit to DB removal pre-check message during cross stack upgrade

2017-08-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61376/#review182024 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 2, 2017, 10

Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-01 Thread Alejandro Fernandez
b_user}}", ``` Diffs - ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 17e80b5 ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 55736cf Diff: https://reviews.apache.org/r/61283/diff/1/ Testing --- Inspected manually Thanks, Alejandro Fernandez

Re: Review Request 61209: Log Search should stop using deprecated API for solr

2017-08-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61209/#review181908 --- Ship it! Ship It! - Alejandro Fernandez On July 28, 2017

Re: Review Request 61266: Function ru_set_all is not working correctly due to changed command structure

2017-07-31 Thread Alejandro Fernandez
/ambari/server/state/ConfigHelper.java Lines (patched) <https://reviews.apache.org/r/61266/#comment257614> Never hit here - Alejandro Fernandez On July 31, 2017, 9:19 p.m., Nate Cole wrote: > > --- > This is a

Re: Review Request 61239: AMBARI-21611 Failed to install packages before EU on powerpc

2017-07-31 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61239/#review181837 --- Ship it! Ship It! - Alejandro Fernandez On July 31, 2017, 6

Re: Review Request 61239: AMBARI-21611 Failed to install packages before EU on powerpc

2017-07-31 Thread Alejandro Fernandez
> On July 31, 2017, 4:25 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > > Lines 1123 (patched) > > <https://reviews.apache.org/r/61239/diff/1/?file=178

Re: Review Request 61239: AMBARI-21611 Failed to install packages before EU on powerpc

2017-07-31 Thread Alejandro Fernandez
gle digit, instead look for the numeric characters from the end. - Alejandro Fernandez On July 29, 2017, 2:12 a.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 61239: AMBARI-21611 Failed to install packages before EU on powerpc

2017-07-31 Thread Alejandro Fernandez
/internal/ClusterStackVersionResourceProvider.java Lines 509 (patched) <https://reviews.apache.org/r/61239/#comment257536> Why is this assuming Power PC will exist? - Alejandro Fernandez On July 29, 2017, 2:12 a.m., Di Li

Re: Review Request 61235: EU: Modify configs to enable custom extensions functionality

2017-07-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61235/#review181750 --- Ship it! Ship It! - Alejandro Fernandez On July 28, 2017

Re: Review Request 61178: AMBARI-21572. Spark configuration mismatch post express upgrade

2017-07-27 Thread Alejandro Fernandez
> On July 27, 2017, 7:43 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > > Lines 268 (patched) > > <https://reviews.apache.org/r/61178/diff/1/?file=1784488#file1784488line268> > > &g

Re: Review Request 61107: Migrate custom extension support

2017-07-27 Thread Alejandro Fernandez
ardcoding /hdp/ext - Alejandro Fernandez On July 27, 2017, 4:09 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 61178: AMBARI-21572. Spark configuration mismatch post express upgrade

2017-07-27 Thread Alejandro Fernandez
/upgrades/config-upgrade.xml Lines 268 (patched) <https://reviews.apache.org/r/61178/#comment257191> Is this deleting the config with the original value from the BigInsights stack? Would EU to HDP 2.6 create it with a new config value? - Alejandro Fernandez On July 27, 2017, 2:28 p.m.,

Re: Review Request 61168: Hive-Service check failing in post EU validation (BI-HDP)

2017-07-27 Thread Alejandro Fernandez
/ambari/server/serveraction/upgrades/FixAuthToLocalMappingAction.java Lines 34 (patched) <https://reviews.apache.org/r/61168/#comment257187> Add some documentation as to why this class was needed and how it works. - Alejandro Fernandez On July 27, 2017, 2:04 a.m., Sid Wagle

Re: Review Request 61132: Agent hangs when server is restarted during connection stage

2017-07-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61132/#review181595 --- Ship it! Ship It! - Alejandro Fernandez On July 26, 2017, 1

Re: Review Request 61129: AMBARI-21573. Kafka service failed to start during regenerate keytab after upgrade from Biginsights 4.2.5, 4.2.0 to HDP 2.6.2

2017-07-25 Thread Alejandro Fernandez
ttps://reviews.apache.org/r/61129/diff/2/ Changes: https://reviews.apache.org/r/61129/diff/1-2/ Testing --- Verified on a live cluster. Thanks, Alejandro Fernandez

Re: Review Request 61107: Migrate custom extension support

2017-07-25 Thread Alejandro Fernandez
. ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/custom_extensions.py Lines 38 (patched) <https://reviews.apache.org/r/61107/#comment256961> Why is iop hardcoded here? - Alejandro Fernandez On July 25, 2017, 11:29 p.m., Vitalyi Brodetskyi

Re: Review Request 61102: AMBARI-21568. Pig service check fails after upgrade

2017-07-25 Thread Alejandro Fernandez
> On July 25, 2017, 8:31 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml > > Lines 75 (patched) > > <https://reviews.apache.org/r/61102/diff/1/?file=1782056#file1782056line75> > > > &g

Re: Review Request 61102: AMBARI-21568. Pig service check fails after upgrade

2017-07-25 Thread Alejandro Fernandez
che.org/r/61102/#comment256913> HDP 2.6 defaults to exectype=tez, so why was this needed? - Alejandro Fernandez On July 25, 2017, 2:11 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 61105: Auto populate zookeeper.connect in Ranger Kafka plugin properties

2017-07-25 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61105/#review181371 --- Ship it! Ship It! - Alejandro Fernandez On July 25, 2017

Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-25 Thread Alejandro Fernandez
nerated e-mail. To reply, visit: > https://reviews.apache.org/r/61083/ > --- > > (Updated July 24, 2017, 2:51 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, > Madhan Neethiraj, Mugdha Varadkar, Nixon

Re: Review Request 61050: AMBARI-21555 Hive restart fails to restart MySQL after Ambari upgrade against IOP 4.2.5

2017-07-24 Thread Alejandro Fernandez
/UpgradeCatalog252.java Lines 310 (patched) <https://reviews.apache.org/r/61050/#comment256794> MySQL shouldn't be restarted prior to the EU. I would prefer to have this be in the EU config packs. - Alejandro Fernandez On July 21, 2017, 8:18 p.m., Di Li

Re: Review Request 61036: Ambari upgrade should update unique constraints

2017-07-24 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61036/#review181242 --- Ship it! Ship It! - Alejandro Fernandez On July 21, 2017, 3

Re: Review Request 61079: AMBARI-21559. Alert definition paths should be updated on upgrade

2017-07-24 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61079/#review181241 --- Ship it! Ship It! - Alejandro Fernandez On July 24, 2017

Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

2017-07-24 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61083/#review181238 --- Ship it! Ship It! - Alejandro Fernandez On July 24, 2017, 2

Review Request 61012: AMBARI-21463. Cross-stack upgrade, Oozie restart fails with ext-2.2.zip missing error

2017-07-20 Thread Alejandro Fernandez
--- Python unit tests passed, -- Total run:1161 Total errors:0 Total failures:0 OK Thanks, Alejandro Fernandez

Re: Review Request 61006: AMBARI-21541 Restart services failed post Ambari Upgrade

2017-07-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61006/#review181080 --- Ship it! Ship It! - Alejandro Fernandez On July 20, 2017, 8

Re: Review Request 60986: AMBARI-21528. Zookeeper server has incorrect memory setting, missing m in Xmx value

2017-07-20 Thread Alejandro Fernandez
ew cluster installs have 1024, and migrated clusters will preserve their existing config value but have the python script fix it. - Alejandro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache

Re: Review Request 61000: AMBARI-21527 Restart of MR2 History Server failed due to wrong NameNode RPC address

2017-07-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61000/#review181071 --- Ship it! Ship It! - Alejandro Fernandez On July 20, 2017, 4

Re: Review Request 60995: Namenode restart - PID file delete happens before the call to check status

2017-07-20 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60995/#review181067 --- Ship it! Ship It! - Alejandro Fernandez On July 20, 2017

Re: Review Request 60986: AMBARI-21528. Zookeeper server has incorrect memory setting, missing m in Xmx value

2017-07-19 Thread Alejandro Fernandez
ws.apache.org/r/60986/diff/2/ Changes: https://reviews.apache.org/r/60986/diff/1-2/ Testing --- Python unit tests passed, ------ Total run:1161 Total errors:0 Total failures:0 OK Thanks, Alejandro Fernandez

Re: Review Request 60986: AMBARI-21528. Zookeeper server has incorrect memory setting, missing m in Xmx value

2017-07-19 Thread Alejandro Fernandez
/package/scripts/params_linux.py Lines 73-74 (patched) <https://reviews.apache.org/r/60986/#comment256405> Ah, good catch, I wrote it too quickly - Alejandro Fernandez On July 19, 2017, 11:04 p.m., Alejandro Fernandez

Re: Review Request 60982: ZKFC Doesn't Update its Version On Some Upgrades

2017-07-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60982/#review180984 --- Ship it! Ship It! - Alejandro Fernandez On July 19, 2017, 8

Re: Review Request 60945: AMBARI-21509 - BigInsights/4.2 upgrade to HDP uses function take_snapshot but that doesn't exist in 4.2's hbase_upgrade.py

2017-07-18 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60945/#review180829 --- Ship it! Ship It! - Alejandro Fernandez On July 18, 2017, 5

Re: Review Request 60919: AMBARI-21502. Cross-stack migration from BigInsights to HDP, EU needs to set hive-site custom.hive.warehouse.mode to 0770

2017-07-17 Thread Alejandro Fernandez
write an existing custom value. - Alejandro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60919/#review180732 ------- On July 17, 2017, 9:31 p.m., Alejandro Fernandez wrote: > > ---

Re: Review Request 60919: AMBARI-21502. Cross-stack migration from BigInsights to HDP, EU needs to set hive-site custom.hive.warehouse.mode to 0770

2017-07-17 Thread Alejandro Fernandez
use the if-present attributes? Good catch, just fixed it. - Alejandro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60919/#review180727 -------

Re: Review Request 60919: AMBARI-21502. Cross-stack migration from BigInsights to HDP, EU needs to set hive-site custom.hive.warehouse.mode to 0770

2017-07-17 Thread Alejandro Fernandez
Diff: https://reviews.apache.org/r/60919/diff/2/ Changes: https://reviews.apache.org/r/60919/diff/1-2/ Testing --- Python unit tests passed. -- Total run:1161 Total errors:0 Total failures:0 OK Thanks, Alejandro Fernandez

Re: Review Request 60886: AMBARI-21481. Upgrading IOP cluster with Spark2 to Ambari 2.5.2 fails on start because config mapping spark2-javaopts-properties is never selected

2017-07-17 Thread Alejandro Fernandez
ges: https://reviews.apache.org/r/60886/diff/4-5/ Testing --- Verified on local cluster. Unit test for UpgradeCatalog252Test.java passed. Thanks, Alejandro Fernandez

Re: Review Request 60919: AMBARI-21502. Cross-stack migration from BigInsights to HDP, EU needs to set hive-site custom.hive.warehouse.mode to 0770

2017-07-17 Thread Alejandro Fernandez
atched) <https://reviews.apache.org/r/60919/#comment255945> The id here was wrong, so just dropped the last 2 digits. - Alejandro Fernandez On July 17, 2017, 7:36 p.m., Alejandro Fernandez wrote: > > --- > This is an auto

Review Request 60919: AMBARI-21502. Cross-stack migration from BigInsights to HDP, EU needs to set hive-site custom.hive.warehouse.mode to 0770

2017-07-17 Thread Alejandro Fernandez
/ Testing --- Python unit tests passed. -- Total run:1161 Total errors:0 Total failures:0 OK Thanks, Alejandro Fernandez

Re: Review Request 60886: AMBARI-21481. Upgrading IOP cluster with Spark2 to Ambari 2.5.2 fails on start because config mapping spark2-javaopts-properties is never selected

2017-07-17 Thread Alejandro Fernandez
> > > Why indented? Fixed - Alejandro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60886/#review180710 --- On July 17, 201

Re: Review Request 60886: AMBARI-21481. Upgrading IOP cluster with Spark2 to Ambari 2.5.2 fails on start because config mapping spark2-javaopts-properties is never selected

2017-07-17 Thread Alejandro Fernandez
ges: https://reviews.apache.org/r/60886/diff/3-4/ Testing --- Verified on local cluster. Unit test for UpgradeCatalog252Test.java passed. Thanks, Alejandro Fernandez

Re: Review Request 60886: AMBARI-21481. Upgrading IOP cluster with Spark2 to Ambari 2.5.2 fails on start because config mapping spark2-javaopts-properties is never selected

2017-07-17 Thread Alejandro Fernandez
------ On July 17, 2017, 7:12 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60886/ >

Re: Review Request 60886: AMBARI-21481. Upgrading IOP cluster with Spark2 to Ambari 2.5.2 fails on start because config mapping spark2-javaopts-properties is never selected

2017-07-17 Thread Alejandro Fernandez
ges: https://reviews.apache.org/r/60886/diff/2-3/ Testing --- Verified on local cluster. Unit test for UpgradeCatalog252Test.java passed. Thanks, Alejandro Fernandez

Re: Review Request 60916: Support SPARK2 upgrade for BI 4.2.5 to HDP 2.6.2

2017-07-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60916/#review180712 --- Ship it! Ship It! - Alejandro Fernandez On July 17, 2017, 5

Re: Review Request 60912: Fix HDP base services to handle changed config paths

2017-07-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60912/#review180711 --- Ship it! Ship It! - Alejandro Fernandez On July 17, 2017, 2

Re: Review Request 60906: Add SOLR to BigInsights 4.2.5 stack

2017-07-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60906/#review180705 --- Ship it! Ship It! - Alejandro Fernandez On July 17, 2017

Re: Review Request 60916: Support SPARK2 upgrade for BI 4.2.5 to HDP 2.6.2

2017-07-17 Thread Alejandro Fernandez
/upgrades/nonrolling-upgrade-to-hdp-2.6.xml Lines 945 (patched) <https://reviews.apache.org/r/60916/#comment255929> Why only one express upgrade pack and not both? - Alejandro Fernandez On July 17, 2017, 5:40 p.m., Jonathan Hurley

Re: Review Request 60859: Zeppelin does not start and returns: params.zookeeper_znode_parent not in interpreter['properties']['phoenix.url']: KeyError: 'phoenix.url'

2017-07-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60859/#review180690 --- Ship it! Ship It! - Alejandro Fernandez On July 14, 2017

Re: Review Request 60859: Zeppelin does not start and returns: params.zookeeper_znode_parent not in interpreter['properties']['phoenix.url']: KeyError: 'phoenix.url'

2017-07-17 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60859/#review180689 --- Ship it! Ship It! - Alejandro Fernandez On July 14, 2017

Re: Review Request 60886: AMBARI-21481. Upgrading IOP cluster with Spark2 to Ambari 2.5.2 fails on start because config mapping spark2-javaopts-properties is never selected

2017-07-17 Thread Alejandro Fernandez
. - Alejandro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60886/#review180617 --- On July 15, 2017, 12:20 a.m., Alejandro

Re: Review Request 60886: AMBARI-21481. Upgrading IOP cluster with Spark2 to Ambari 2.5.2 fails on start because config mapping spark2-javaopts-properties is never selected

2017-07-17 Thread Alejandro Fernandez
usters. - Alejandro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60886/#review180681 --- On July 15, 2017, 12:20 a.m., Alej

Re: Review Request 60886: AMBARI-21481. Upgrading IOP cluster with Spark2 to Ambari 2.5.2 fails on start because config mapping spark2-javaopts-properties is never selected

2017-07-14 Thread Alejandro Fernandez
tps://reviews.apache.org/r/60886/diff/2/ Changes: https://reviews.apache.org/r/60886/diff/1-2/ Testing --- Verified on local cluster. Unit test for UpgradeCatalog252Test.java passed. Thanks, Alejandro Fernandez

Re: Review Request 60886: AMBARI-21481. Upgrading IOP cluster with Spark2 to Ambari 2.5.2 fails on start because config mapping spark2-javaopts-properties is never selected

2017-07-14 Thread Alejandro Fernandez
t; Will raise a Jira for Ambari 2.5.3 for the UI to select config types that only contain configs with empty values. - Alejandro Fernandez On July 15, 2017, 12:14 a.m., Alejandro Fernandez wrote: > > --- > This is an aut

Review Request 60886: AMBARI-21481. Upgrading IOP cluster with Spark2 to Ambari 2.5.2 fails on start because config mapping spark2-javaopts-properties is never selected

2017-07-14 Thread Alejandro Fernandez
est for UpgradeCatalog252Test.java passed. Thanks, Alejandro Fernandez

Re: Review Request 60842: AMBARI-21460 : Add new kafka client properties to the ambari managed atlas config

2017-07-14 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60842/#review180559 --- Ship it! Ship It! - Alejandro Fernandez On July 14, 2017, 6

Review Request 60855: AMBARI-21463. Cross-stack upgrade, Oozie restart fails with ext-2.2.zip missing error, stack_tools.py is missing get_stack_name in __all__, disable BigInsights in UI

2017-07-13 Thread Alejandro Fernandez
/resources/stacks/BigInsights/4.2.5/metainfo.xml 3cf364e Diff: https://reviews.apache.org/r/60855/diff/1/ Testing --- Verified on local cluster. Thanks, Alejandro Fernandez

Re: Review Request 60850: Create pre-requisite check for components missing from the target stack

2017-07-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60850/#review180476 --- Ship it! Ship It! - Alejandro Fernandez On July 13, 2017, 8

Re: Review Request 60849: AMBARI-21469. Stop Spark fails due to missing stack selector

2017-07-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60849/#review180459 --- Ship it! Ship It! - Alejandro Fernandez On July 13, 2017, 7

Re: Review Request 60850: Create pre-requisite check for components missing from the target stack

2017-07-13 Thread Alejandro Fernandez
re-run the PreCheck and potentially find other failures. - Alejandro Fernandez On July 13, 2017, 8:01 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60819: AMBARI-21462. Readd TITAN, R4ML, SYSTEMML, JNBG to BigInsights and fix HBase backup during EU and imports

2017-07-12 Thread Alejandro Fernandez
nv.xml Lines 32 (patched) <https://reviews.apache.org/r/60819/#comment255528> Added to all of the configs. - Alejandro Fernandez On July 12, 2017, 11:21 p.m., Alejandro Fernandez wrote: > > --- > This is an automatic

Review Request 60819: AMBARI-21462. Readd TITAN, R4ML, SYSTEMML, JNBG to BigInsights and fix HBase backup during EU and imports

2017-07-12 Thread Alejandro Fernandez
ge/scripts/titan_client.py PRE-CREATION ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml 4867626 Diff: https://reviews.apache.org/r/60819/diff/1/ Testing --- Verified on local cluster. Thanks, Alejandro Fernandez

Re: Review Request 60809: AMBARI-21455. Remove unnecessary services from BigInsights stack

2017-07-12 Thread Alejandro Fernandez
: https://reviews.apache.org/r/60809/diff/2/ Changes: https://reviews.apache.org/r/60809/diff/1-2/ Testing --- Verified on local cluster. Thanks, Alejandro Fernandez

Re: Review Request 60807: AMBARI-21453 Restart Hive after Install Packages fails with err on Condition with name 'should_install_mysl_connector'

2017-07-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60807/#review180334 --- Ship it! Ship It! - Alejandro Fernandez On July 12, 2017, 4

Review Request 60809: AMBARI-21455. Remove unnecessary services from BigInsights stack, fix rpm command in Remove IOP Select action

2017-07-12 Thread Alejandro Fernandez
che.org/r/60809/diff/1/ Testing --- Verified on local cluster. Thanks, Alejandro Fernandez

Re: Review Request 60802: AMBARI-21449. Stack upgrade with pre-req checks enabled fails due to NPE

2017-07-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60802/#review180311 --- Ship it! Ship It! - Alejandro Fernandez On July 12, 2017, 2

Re: Review Request 60797: AMBARI-21446. Force-remove package does not work on CentOS 6 and SuSE 11

2017-07-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60797/#review180310 --- Ship it! Ship It! - Alejandro Fernandez On July 12, 2017, 9

Re: Review Request 60782: Hive warehouse fixes

2017-07-12 Thread Alejandro Fernandez
/configuration/hive-site.xml Lines 19 (patched) <https://reviews.apache.org/r/60782/#comment255403> This is also needed in Hive for 3.0 - Alejandro Fernandez On July 11, 2017, 7:51 p.m., Vitalyi Brodetskyi

Review Request 60756: AMBARI-21440. Cross-stack migration, package supplemental stack in RPM

2017-07-10 Thread Alejandro Fernandez
reErrors=true # Verify the contents rpm -qlp rpm -qlp ambari-server-2.5.1.0-0.x86_64.rpm | grep "var/lib/ambari-server/resources/stacks/BigInsights" rpm -qlp rpm -qlp ambari-agent-2.5.1.0-0.x86_64.rpm | grep "/var/lib/ambari-agent/cache/stacks/BigInsights" ``` Thanks, Alejandro Fernandez

Re: Review Request 60754: AMBARI-21439 Hive/MapRed2 restart fails after Ambari upgrade

2017-07-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60754/#review180115 --- Ship it! Ship It! - Alejandro Fernandez On July 10, 2017, 9

Re: Review Request 60691: AMBARI-21420 HBase master crashed during/post EU on an IOP4.2.5/HDP2.6 migrated cluster

2017-07-10 Thread Alejandro Fernandez
/0.96.0.2.0/package/scripts/params_linux.py Lines 445 (patched) <https://reviews.apache.org/r/60691/#comment255074> Lines 445 and 446 are no longer needed now. - Alejandro Fernandez On July 10, 2017, 3:54 p.m., Di Li

Re: Review Request 60744: Add python functions to get the Ambari version of the agent

2017-07-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60744/#review180062 --- Ship it! Ship It! - Alejandro Fernandez On July 10, 2017, 2

Re: Review Request 60745: Allow Services To Be Stopped During an EU Between Stack Vendors

2017-07-10 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60745/#review180060 --- Ship it! Ship It! - Alejandro Fernandez On July 10, 2017, 2

Re: Review Request 60741: AMBARI-21431. Update BigInsight configuration files to be compliant with XSD

2017-07-10 Thread Alejandro Fernandez
/configuration/cluster-env.xml Lines 211 (patched) <https://reviews.apache.org/r/60741/#comment255067> We should actually set all of these to on-ambari-upgrade add="false" to minimize the risk of new properties being added before the EU migration. - Alejandro Fernandez On July 10,

Re: Review Request 60738: HdfsResource can not handle S3 URL when hbase.rootdir is set to S3 URL

2017-07-10 Thread Alejandro Fernandez
/0.96.0.2.0/package/scripts/hbase.py Lines 197 (patched) <https://reviews.apache.org/r/60738/#comment255062> This is already needed in HBase for 3.0 Please add a comment as well explaining why this was needed. - Alejandro Fernandez On July 10, 2017, 9:47 a.m., Andrew Onischuk

Re: Review Request 60709: Allow Multiple Versions of Stack Tools to Co-Exist

2017-07-07 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60709/#review179956 --- Ship it! Ship It! - Alejandro Fernandez On July 7, 2017, 9

  1   2   3   4   5   6   7   8   9   10   >