Review Request 57296: Full-height modals overflow viewport vertically

2017-03-03 Thread Andriy Babiichuk
passing (18s) 153 pending Thanks, Andriy Babiichuk

Review Request 57144: While enabling Ranger Plugins, Improper formatting of recommended configs in the popup

2017-02-28 Thread Andriy Babiichuk
not correct. STR: Enable Ranger Plugins, click save and go to recommended configs popup Diffs - ambari-web/app/styles/application.less 8cb9388 Diff: https://reviews.apache.org/r/57144/diff/ Testing --- 20520 passing (18s) 153 pending Thanks, Andriy Babiichuk

Review Request 57095: UI asking user to "refresh yarn queue" on stopped yarn service, which results to infinite refresh time as yarn is stopped

2017-02-27 Thread Andriy Babiichuk
--- 20520 passing (19s) 153 pending Thanks, Andriy Babiichuk

Review Request 57066: Ambari Web unit tests aren't running

2017-02-25 Thread Andriy Babiichuk
2093d7 Diff: https://reviews.apache.org/r/57066/diff/ Testing --- 20490 passing (19s) 153 pending Thanks, Andriy Babiichuk

Review Request 57037: Manage Configuration Group Hosts popup is way too small to be useful when it is needed

2017-02-24 Thread Andriy Babiichuk
/modal_popups.less e269791 ambari-web/app/utils/hosts.js 3896325 Diff: https://reviews.apache.org/r/57037/diff/ Testing --- 20490 passing (19s) 153 pending Thanks, Andriy Babiichuk

Review Request 56985: Ambari logo is not displayed

2017-02-23 Thread Andriy Babiichuk
Diff: https://reviews.apache.org/r/56985/diff/ Testing --- 20375 passing (18s) 153 pending Thanks, Andriy Babiichuk

Review Request 56982: Merge Preview Configuration changes to branch-2.5

2017-02-23 Thread Andriy Babiichuk
cd6b21c Diff: https://reviews.apache.org/r/56982/diff/ Testing --- 30331 passing (23s) 157 pending Thanks, Andriy Babiichuk

Review Request 56942: Test and fix new modals styles on Ambari

2017-02-22 Thread Andriy Babiichuk
, Andriy Babiichuk

Re: Review Request 56893: Configs filter is not reset if configs has no filter input

2017-02-21 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56893/#review166180 --- Ship it! Ship It! - Andriy Babiichuk On Лют. 21, 2017, 4:06

Re: Review Request 56761: Hosts filter component list is not sorted so it is difficult to use

2017-02-16 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56761/#review165867 --- Ship it! Ship It! - Andriy Babiichuk On Лют. 16, 2017, 4:14

Review Request 56714: Override property popup: Redundant scrollbars in config groups list

2017-02-15 Thread Andriy Babiichuk
. Diffs - ambari-web/app/styles/application.less 612c09c Diff: https://reviews.apache.org/r/56714/diff/ Testing --- 20340 passing (20s) 153 pending Thanks, Andriy Babiichuk

Review Request 56712: Incorrect work of filters on Versions page of Admin View

2017-02-15 Thread Andriy Babiichuk
/ Testing --- Executed 81 of 81 SUCCESS (0.466 secs / 0.461 secs) Thanks, Andriy Babiichuk

Review Request 56596: Admin View: issues with Users/Groups table filters

2017-02-13 Thread Andriy Babiichuk
SUCCESS (0.413 secs / 0.408 secs) Thanks, Andriy Babiichuk

Review Request 56544: No config properties are changed after deleting service if it's performed after service page refresh

2017-02-10 Thread Andriy Babiichuk
/controllers/main/service/item.js 7010ab5 ambari-web/test/controllers/main/service/item_test.js 302a9a5 Diff: https://reviews.apache.org/r/56544/diff/ Testing --- 20345 passing (21s) 153 pending Thanks, Andriy Babiichuk

Review Request 56445: Ranger Admin HA Wizard should show all configuration changes on Review step

2017-02-08 Thread Andriy Babiichuk
ambari-web/app/routes/ra_high_availability_routes.js dbf653b ambari-web/test/controllers/main/admin/highAvailability/rangerAdmin/step3_controller_test.js 649bcbc Diff: https://reviews.apache.org/r/56445/diff/ Testing --- 20326 passing (19s) 153 pending Thanks, Andriy Babiichuk

Re: Review Request 56393: Unable to add ZooKeeper Server to host

2017-02-07 Thread Andriy Babiichuk
(22s) 153 pending Thanks, Andriy Babiichuk

Review Request 56393: Unable to add ZooKeeper Server to host

2017-02-07 Thread Andriy Babiichuk
button is disabled. Diffs - ambari-web/app/controllers/main/host/details.js 093603e ambari-web/test/controllers/main/host/details_test.js 4eccf95 Diff: https://reviews.apache.org/r/56393/diff/ Testing --- 30327 passing (18s) 157 pending Thanks, Andriy Babiichuk

Review Request 56176: Recommendations for non-editable properties should be listed as 'Required Changes'

2017-02-01 Thread Andriy Babiichuk
ambari-web/test/mixins/common/configs/enhanced_configs_test.js 0955a8f ambari-web/test/views/common/modal_popups/dependent_configs_list_popup_test.js 9dc4bf6 Diff: https://reviews.apache.org/r/56176/diff/ Testing --- 20325 passing (20s) 153 pending Thanks, Andriy Babiichuk

Review Request 56083: Reassign wizard erases config properties attributes

2017-01-30 Thread Andriy Babiichuk
Diff: https://reviews.apache.org/r/56083/diff/ Testing --- 20325 passing (18s) 153 pending Thanks, Andriy Babiichuk

Review Request 55949: Styles for showing Config Changes need more polishing

2017-01-25 Thread Andriy Babiichuk
ommon/modal_popups/dependent_configs_table.hbs PRE-CREATION ambari-web/app/views/common/modal_popups/dependent_configs_list_popup.js e8e6df5 Diff: https://reviews.apache.org/r/55949/diff/ Testing --- 20323 passing (18s) 153 pending Thanks, Andriy Babiichuk

Review Request 55877: Validation errors are not shown if properties do not exist

2017-01-24 Thread Andriy Babiichuk
to avoid service restarts. Diffs - ambari-web/app/mixins/common/serverValidator.js 9fb5ae3 ambari-web/test/mixins/common/serverValidator_test.js 943eb57 Diff: https://reviews.apache.org/r/55877/diff/ Testing --- 30309 passing (22s) 157 pending Thanks, Andriy Babiichuk

Review Request 55850: Confirmation for adding host component from service summary page should be displayed once

2017-01-23 Thread Andriy Babiichuk
/ Testing --- 20321 passing (21s) 153 pending Thanks, Andriy Babiichuk

Review Request 55756: Make the config changes for Add / Delete Service flow more prominent

2017-01-20 Thread Andriy Babiichuk
://reviews.apache.org/r/55756/diff/ Testing --- 20309 passing (21s) 153 pending Thanks, Andriy Babiichuk

Review Request 55628: Add/delete host component: visual changes for configuration popup

2017-01-17 Thread Andriy Babiichuk
r the header "Required Changes". Diffs - ambari-web/app/messages.js cacb798 ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs af84306 Diff: https://reviews.apache.org/r/55628/diff/ Testing --- 20395 tests complete (33 seconds) 153 tests pending Thanks, Andriy Babiichuk

Re: Review Request 55629: Ranger Admin HA Wizard: next button disappears

2017-01-17 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55629/#review161883 --- Ship it! Ship It! - Andriy Babiichuk On Січ. 17, 2017, 4:36

Review Request 55618: Ranger Admin HA Wizard should display configs changes explicitly

2017-01-17 Thread Andriy Babiichuk
/rangerAdmin/step3_controller_test.js PRE-CREATION Diff: https://reviews.apache.org/r/55618/diff/ Testing --- 20395 tests complete (39 seconds) 153 tests pending Thanks, Andriy Babiichuk

Review Request 55582: Move Master and HA wizards for all components should show config changes that will be done as part of the wizard

2017-01-16 Thread Andriy Babiichuk
ff: https://reviews.apache.org/r/55582/diff/ Testing --- 20389 tests complete (35 seconds) 153 tests pending Thanks, Andriy Babiichuk

Review Request 55261: Reconfigure after adding/deleting ZooKeeper Server is not performed if Atlas is installed

2017-01-06 Thread Andriy Babiichuk
tests pending Thanks, Andriy Babiichuk

Review Request 55205: Configs changes after adding/deleting host component: value shouldn't be changed if it differs in host names order only

2017-01-05 Thread Andriy Babiichuk
/configs/hosts_based_initializer_mixin.js d0d2503 ambari-web/test/controllers/main/host/details_test.js a4cb177 ambari-web/test/utils/config_test.js 8c450ed Diff: https://reviews.apache.org/r/55205/diff/ Testing --- 20114 tests complete (24 seconds) 153 tests pending Thanks, Andriy

Review Request 55086: Recommended configs changes are displayed twice before adding or deleting Nimbus

2016-12-29 Thread Andriy Babiichuk
/controllers/main/host/details_test.js cb48ae1 Diff: https://reviews.apache.org/r/55086/diff/ Testing --- 19991 tests complete (24 seconds) 153 tests pending Thanks, Andriy Babiichuk

Re: Review Request 55072: Non-editable properties should be handled for add/delete host component

2016-12-28 Thread Andriy Babiichuk
pending Thanks, Andriy Babiichuk

Review Request 55072: Non-editable properties should be handled for add/delete host component

2016-12-28 Thread Andriy Babiichuk
/dependent_configs_list_popup.js 1aa46eb ambari-web/test/controllers/main/host/details_test.js 024e994 Diff: https://reviews.apache.org/r/55072/diff/ Testing --- 19993 tests complete (22 seconds) 153 tests pending Thanks, Andriy Babiichuk

Review Request 54976: Display properties for all affected services before adding or deleting ZooKeeper Server

2016-12-22 Thread Andriy Babiichuk
-web/app/templates/main/host/details/addDeleteComponentPopup.hbs 713ad8c ambari-web/test/controllers/main/host/details_test.js cbebcf0 Diff: https://reviews.apache.org/r/54976/diff/ Testing --- 19860 tests complete (23 seconds) 153 tests pending Thanks, Andriy Babiichuk

Review Request 54855: Delete host component should show configs being changed in recommendation popup modal

2016-12-18 Thread Andriy Babiichuk
, Andriy Babiichuk

Re: Review Request 54781: Fix styles for disabled buttons

2016-12-15 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54781/#review159289 --- Ship it! Ship It! - Andriy Babiichuk On Гру. 15, 2016, 1:33

Re: Review Request 54777: Manage Journalnode Wizard: error on step3

2016-12-15 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54777/#review159282 --- Ship it! Ship It! - Andriy Babiichuk On Гру. 15, 2016, 11

Re: Review Request 54734: BG operations modal windows are too small to show the content (in certain scenarios) [Chrome]

2016-12-14 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54734/#review159128 --- Ship it! Ship It! - Andriy Babiichuk On Гру. 14, 2016, 10

Review Request 54703: Add host component should show configs being changed in recommendation popup modal

2016-12-13 Thread Andriy Babiichuk
/dependent_configs_list_popup.js 728634e ambari-web/test/controllers/main/host/details_test.js 9a56ab2 Diff: https://reviews.apache.org/r/54703/diff/ Testing --- 19881 tests complete (22 seconds) 153 tests pending Thanks, Andriy Babiichuk

Review Request 54533: Choose services page select/deselect all services not working while adding smartsense to the cluster

2016-12-08 Thread Andriy Babiichuk
/test/models/stack_service_test.js 9f12e88 Diff: https://reviews.apache.org/r/54533/diff/ Testing --- 19901 tests complete (24 seconds) 155 tests pending Thanks, Andriy Babiichuk

Re: Review Request 54306: Do not change timeline.metrics.service.webapp.address in move wizard

2016-12-02 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54306/#review157738 --- Ship it! Ship It! - Andriy Babiichuk On Гру. 2, 2016, 1:53

Re: Review Request 54257: Re-arrange "Role Based Access Control" info table

2016-12-01 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54257/#review157613 --- Ship it! Ship It! - Andriy Babiichuk On Гру. 1, 2016, 5:29

Review Request 54254: Delete service action should show the config recommendation popup

2016-12-01 Thread Andriy Babiichuk
4/diff/ Testing --- 20020 tests complete (26 seconds) 155 tests pending Thanks, Andriy Babiichuk

Review Request 54155: Fix input height in filters with dropdown

2016-11-29 Thread Andriy Babiichuk
--- 19935 tests complete (21 seconds) 154 tests pending Thanks, Andriy Babiichuk

Review Request 54082: Fix Flume agents table

2016-11-25 Thread Andriy Babiichuk
pending Thanks, Andriy Babiichuk

Re: Review Request 54059: Test and fix new tables styles on Ambari (part 5)

2016-11-24 Thread Andriy Babiichuk
/app/views/main/host.js 6043d63 ambari-web/app/views/wizard/step3_view.js 2f57b9e ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js 3dad7d8 Diff: https://reviews.apache.org/r/54059/diff/ Testing --- 19928 tests complete (21 seconds) 154 tests pending Thanks, Andriy

Review Request 54059: Test and fix new tables styles on Ambari (part 5)

2016-11-24 Thread Andriy Babiichuk
ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js 3dad7d8 Diff: https://reviews.apache.org/r/54059/diff/ Testing --- 19928 tests complete (21 seconds) 154 tests pending Thanks, Andriy Babiichuk

Re: Review Request 53907: Add Service wizard: Allow adding slave components from different service conditionally

2016-11-18 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53907/#review156350 --- Ship it! Ship It! - Andriy Babiichuk On Лис. 18, 2016, 11

Re: Review Request 50100: AMBARI-17754 - Issue with modify configs for hive service

2016-07-19 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50100/#review142701 --- Ship it! Ship It! - Andriy Babiichuk On Июль 16, 2016, 12