Re: Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58997/#review174148 --- Ship it! Ship It! - Ashwin Rajeev On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58997/ > --- > > (Updated May 5, 2017, 9:12 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, > Ashwin Rajeev, and Yusaku Sako. > > > Bugs: AMBARI-20936 > https://issues.apache.org/jira/browse/AMBARI-20936 > > > Repository: ambari > > > Description > --- > > Instead of deleting entries from DB directly, used uninstalling. Did > refactoring to take the DB related code out of the ViewRegistry (which is > anyway growing very big and is live object which cannot be used during > Upgrade process) to create ViewInstanceOperationHandler.java. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java > ba39efb6a2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java > 74de530ad7 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > b632c54043 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > d076a5c3b1 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > d136db7e49 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 190779add8 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > a3728d46b3 > > > Diff: https://reviews.apache.org/r/58997/diff/1/ > > > Testing > --- > > added : ViewInstanceOperationHandlerTest.java > updated : UpgradeCatalog250Test.java, ViewRegistryTest.java > > Manual testing to see if upgrade works fine with and without LDAP users and > privileges along with UI deletion of view instance. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58997/#review174147 --- ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java Lines 692 (patched) <https://reviews.apache.org/r/58997/#comment247267> Does it need to be hardcoded ? - Ashwin Rajeev On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58997/ > --- > > (Updated May 5, 2017, 9:12 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Rohit Choudhary, Renjith Kamath, > Ashwin Rajeev, and Yusaku Sako. > > > Bugs: AMBARI-20936 > https://issues.apache.org/jira/browse/AMBARI-20936 > > > Repository: ambari > > > Description > --- > > Instead of deleting entries from DB directly, used uninstalling. Did > refactoring to take the DB related code out of the ViewRegistry (which is > anyway growing very big and is live object which cannot be used during > Upgrade process) to create ViewInstanceOperationHandler.java. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/PrivilegeEntity.java > ba39efb6a2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java > 74de530ad7 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > b632c54043 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > d076a5c3b1 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewInstanceOperationHandler.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > d136db7e49 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 190779add8 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewInstanceOperationHandlerTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > a3728d46b3 > > > Diff: https://reviews.apache.org/r/58997/diff/1/ > > > Testing > --- > > added : ViewInstanceOperationHandlerTest.java > updated : UpgradeCatalog250Test.java, ViewRegistryTest.java > > Manual testing to see if upgrade works fine with and without LDAP users and > privileges along with UI deletion of view instance. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57453: Fix up tez view version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57453/#review168915 --- Ship it! Ship It! - Ashwin Rajeev On March 14, 2017, 1:59 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57453/ > --- > > (Updated March 14, 2017, 1:59 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav > Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev. > > > Bugs: AMBARI-20370 > https://issues.apache.org/jira/browse/AMBARI-20370 > > > Repository: ambari > > > Description > --- > > tez view version and build removed and short url of auto instance used for > property tez.tez-ui.history-url.base in tez-site > Removed change of tez version from AbstractUpgradeCatalog. > UpgardeCatalog250 now contains code to change the previous value of > tez.tez-ui.history-url.base to > http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance > changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during > installation > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 9be541f > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > e3afc33 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > d45cf96 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 6d0ce38 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java > 5fa7cac > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > ad21331 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 5fce011 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > b1ec05b > > > Diff: https://reviews.apache.org/r/57453/diff/2/ > > > Testing > --- > > Tested the upgrade from 2.4.0.2 to 2.5.0.0. > Tested installation of fresh 2.5.0.0 > Added test cases for changes in UpgardeCatalog250. > updated test_stack_advisor.py test cases. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57453: Fix up tez view version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57453/#review168427 --- Ship it! Ship It! - Ashwin Rajeev On March 9, 2017, 10 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57453/ > --- > > (Updated March 9, 2017, 10 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Pallav > Kulshreshtha, Rohit Choudhary, Sreenath Somarajapuram, and Ashwin Rajeev. > > > Bugs: AMBARI-20370 > https://issues.apache.org/jira/browse/AMBARI-20370 > > > Repository: ambari > > > Description > --- > > tez view version and build removed and short url of auto instance used for > property tez.tez-ui.history-url.base in tez-site > Removed change of tez version from AbstractUpgradeCatalog. > UpgardeCatalog250 now contains code to change the previous value of > tez.tez-ui.history-url.base to > http://HOST:PORT/#/main/view/TEZ/tez_cluster_instance > changed stack_advisor.py in 2.2 and 2.3 for this change to reflect during > installation > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 9be541f > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 00d1c31 > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > d45cf96 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 6d0ce38 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java > 5fa7cac > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 1a87433 > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 5fce011 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > b1ec05b > > > Diff: https://reviews.apache.org/r/57453/diff/1/ > > > Testing > --- > > Tested the upgrade from 2.4.0.2 to 2.5.0.0. > Tested installation of fresh 2.5.0.0 > Added test cases for changes in UpgardeCatalog250. > updated test_stack_advisor.py test cases. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 57141: Hive View 2.0: Code hints for query editor are not working
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57141/#review167094 --- Ship it! Ship It! - Ashwin Rajeev On Feb. 28, 2017, 12:23 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57141/ > --- > > (Updated Feb. 28, 2017, 12:23 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19673 > https://issues.apache.org/jira/browse/AMBARI-19673 > > > Repository: ambari > > > Description > --- > > User should be able to see code hints and syntax colorization while typing > hive queries. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js > 3175a35 > contrib/views/hive20/src/main/resources/ui/ember-cli-build.js c88799a > > Diff: https://reviews.apache.org/r/57141/diff/ > > > Testing > --- > > Manually tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 57120: Hive View 2.0 LogAggregator prints lots of warning logs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57120/#review167007 --- Ship it! Ship It! - Ashwin Rajeev On Feb. 28, 2017, 4:55 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57120/ > --- > > (Updated Feb. 28, 2017, 4:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20222 > https://issues.apache.org/jira/browse/AMBARI-20222 > > > Repository: ambari > > > Description > --- > > Stopping the statement executor after query end or failure. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java > d6d5d51 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveViewImpl.java > aee7d03 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > 61f0b66 > > Diff: https://reviews.apache.org/r/57120/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 56973: Hive view 2.0 : Hanging query - no cancel available
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56973/#review166491 --- Ship it! Ship It! - Ashwin Rajeev On Feb. 23, 2017, 7:13 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56973/ > --- > > (Updated Feb. 23, 2017, 7:13 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-20135 > https://issues.apache.org/jira/browse/AMBARI-20135 > > > Repository: ambari > > > Description > --- > > Added stop button. It will be visible for running query. > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > 1d9744b > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > c549d7b > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 8503715 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > bf485ca > > Diff: https://reviews.apache.org/r/56973/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 55209: ATS service check failed on navigating to Hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55209/#review160690 --- Ship it! Ship It! - Ashwin Rajeev On Jan. 5, 2017, 1:30 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55209/ > --- > > (Updated Jan. 5, 2017, 1:30 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19382 > https://issues.apache.org/jira/browse/AMBARI-19382 > > > Repository: ambari > > > Description > --- > > The ats url is not correctly form when it is https. Using utils to form ats > url now. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/HelpService.java > 702b38a > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/atsJobs/ATSParserFactory.java > 4ff2621 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HelpService.java > 9fe > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/atsJobs/ATSParserFactory.java > 343202e > > Diff: https://reviews.apache.org/r/55209/diff/ > > > Testing > --- > > Manual. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 55090: Hive View 2.0 - Minimal view for Hive which includes new UI changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55090/#review160375 --- Ship it! Ship It! - Ashwin Rajeev On Jan. 3, 2017, 9:25 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55090/ > --- > > (Updated Jan. 3, 2017, 9:25 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19321 > https://issues.apache.org/jira/browse/AMBARI-19321 > > > Repository: ambari > > > Description > --- > > This includes the minimalistic view which includes the new UI including > feature parity with the old Hive view 1.5.0 > Options > > > Diffs > - > > contrib/views/hive-next/src/main/resources/view.log4j.properties 2e466cd > contrib/views/hive20/pom.xml PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/AuthParams.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/BaseService.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionDelegate.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionFactory.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/ConnectionSystem.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/DataMigrator.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HelpService.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveJdbcConnectionDelegate.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveViewImpl.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/PropertyValidator.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/TestBean.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/DatabaseChangeNotifier.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/DatabaseManager.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/DeathWatch.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/HiveActor.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/LogAggregator.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/MetaDataManager.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/MetaDataRetriever.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/OperationController.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/ResultSetIterator.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/StatementExecutor.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/TableChangeNotifier.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/YarnAtsGUIDFetcher.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/Connect.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/CursorReset.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ExecuteJob.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/ExecuteQuery.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/FetchError.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/message/FetchResult.java > PRE-CREATION > > contrib/views/hive20/src/main/java/
Re: Review Request 55050: Remove hive view 1.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55050/#review160180 --- Ship it! Ship It! - Ashwin Rajeev On Dec. 27, 2016, 5:58 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55050/ > --- > > (Updated Dec. 27, 2016, 5:58 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19302 > https://issues.apache.org/jira/browse/AMBARI-19302 > > > Repository: ambari > > > Description > --- > > removed contrib/views/hive folder and made necesary changes in pom.xml files. > Now next version of hive 1.5 and 2.0 only will be maintained. > > > Diffs > - > > contrib/views/hive/pom.xml b224fb3b > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/BaseService.java > d29d758 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java > dcddf6d > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HiveViewImpl.java > e28dfbf > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/PropertyValidator.java > e10dad3 > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/TestBean.java > d298931 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/backgroundjobs/BackgroundJobController.java > ea8d51c > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ColumnDescription.java > a25571f > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ColumnDescriptionExtended.java > ab54e61 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ColumnDescriptionShort.java > a6500aa > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java > d69a1a5 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java > d3cbb08 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Cursor.java > 16fdf36 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/DDLDelegator.java > e609978 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveAuthCredentials.java > 2b3f43b > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveAuthRequiredException.java > ac15f2f > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveCall.java > d2a459f > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveClientAuthRequiredException.java > 955bdf9 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveClientException.java > 9dd04de > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveClientRuntimeException.java > 1393012 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveErrorStatusException.java > 1b306dc > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HiveInvalidQueryException.java > 473ab65 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HttpBasicAuthInterceptor.java > dea8fcb > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HttpKerberosRequestInterceptor.java > 786c94d > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/HttpRequestInterceptorBase.java > 7dc3c53 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/LogsCursor.java > a6705e4 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Row.java > cfce1f0 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalConnection.java > 3e2c3cc > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalHiveAuthCredentials.java > f658c14 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Utils.java > 13f93c3 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ViewSessionState.java > aa6cd47 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java > 5457a5c > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/IStorageFactory.java > 298d4c8 > > contrib/vie
Re: Review Request 53780: create separate RPM / DEB package for views during build process.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53780/#review156192 --- Ship it! Ship It! - Ashwin Rajeev On Nov. 15, 2016, 11:54 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53780/ > --- > > (Updated Nov. 15, 2016, 11:54 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, and Ashwin > Rajeev. > > > Bugs: AMBARI-18873 > https://issues.apache.org/jira/browse/AMBARI-18873 > > > Repository: ambari > > > Description > --- > > Earlier : view jars were shipped with the ambari-server package. > Now : separate rpm and deb files can be created > (ambari-views-package_$VERSION.deb, ambari-views-package-$VERSION.x86_64.rpm) > which can be shipped and installed separately. > > each view (module) in contrib/views can copy its jar into the parent > (ambari-contrib-view project) target/views-jars folder and when mvn runs in > ambari-views-package, it creates an RPM and DEB file packaging all the jars. > > created RPM location : > $AMBARI/contrib/views/ambari-views-package/target/rpm/ambari-views-package/RPMS/x86_64/ambari-views-package-2.5.0.0-0.x86_64.rpm > create DEB location : > $AMBARI/contrib/views/ambari-views-package/target/ambari-views-package_2.5.0.0-0.deb > > The order of module ambari-views-package in pom.xml of ambari-contrib-views > should be last as it will create the package. > > command to create deb and rpm > $ cd $AMBARI/contrib/views > $ mvn clean package rpm:rpm jdeb:jdeb install > > > Diffs > - > > contrib/views/ambari-views-package/pom.xml PRE-CREATION > contrib/views/ambari-views-package/src/main/package/deb/control/control > PRE-CREATION > contrib/views/capacity-scheduler/pom.xml 7b7cdc9 > contrib/views/files/pom.xml 67beef9 > contrib/views/hawq/pom.xml 4fc543f > contrib/views/hive-next/pom.xml 46deaf3 > contrib/views/hive/pom.xml 2814049 > contrib/views/hueambarimigration/pom.xml 21837c3 > contrib/views/jobs/pom.xml 8460c5b > contrib/views/pig/pom.xml d2aada7 > contrib/views/pom.xml 94f8421 > contrib/views/slider/pom.xml 0ddcb84 > contrib/views/storm/pom.xml 38ec8ba > contrib/views/tez/pom.xml 26b0c49 > contrib/views/wfmanager/pom.xml e03e656 > contrib/views/zeppelin/pom.xml 52efdce > > Diff: https://reviews.apache.org/r/53780/diff/ > > > Testing > --- > > manual testing of creation of > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 52823: For Upload Table on hive view, upload fails when file extension is .json
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52823/#review154505 --- Ship it! Ship It! - Ashwin Rajeev On Oct. 13, 2016, 9:06 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52823/ > --- > > (Updated Oct. 13, 2016, 9:06 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-18584 > https://issues.apache.org/jira/browse/AMBARI-18584 > > > Repository: ambari > > > Description > --- > > Earlier GsonJsonProvider was trying to convert uploaded InputStream because > the content type that was coming was application/json for files with > extension .json > Now the GsonJsonProvider will ignore conversion of object of InputStream. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/GsonJsonProvider.java > 8ba9ff7 > > Diff: https://reviews.apache.org/r/52823/diff/ > > > Testing > --- > > Manual Testing Done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 50561: Hive View Upload table does not support line feed and carriage return in field delimiter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50561/#review152475 --- Ship it! Ship It! - Ashwin Rajeev On July 28, 2016, 11:22 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50561/ > --- > > (Updated July 28, 2016, 11:22 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17943 > https://issues.apache.org/jira/browse/AMBARI-17943 > > > Repository: ambari > > > Description > --- > > removed the linefeed and carriage return and improved UX > > > Diffs > - > > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 061a445 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > d84dc4d > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 061a445 > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > d84dc4d > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVParserTest.java > 2c890f5 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/OpenCSVTest.java > be5733f > > Diff: https://reviews.apache.org/r/50561/diff/ > > > Testing > --- > > manual testing done > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 52822: Ambari Hive View 'Upload Table' does not support UTF8 files with BOM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52822/#review152474 --- Ship it! Ship It! - Ashwin Rajeev On Oct. 13, 2016, 8:56 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52822/ > --- > > (Updated Oct. 13, 2016, 8:56 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-18583 > https://issues.apache.org/jira/browse/AMBARI-18583 > > > Repository: ambari > > > Description > --- > > Ealiear BOM characters in the file were creating problem in upload. Now they > are removed using apache commons io library. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > 9800c22 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java > 7dccbd4 > > Diff: https://reviews.apache.org/r/52822/diff/ > > > Testing > --- > > manual testing done to verify support for both Big-endian and little-endian > BOM. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 50691: AMBARI-17213: Worfklow designer initial contrib view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50691/#review144878 --- Ship it! Reviewed earleier as a github PR - Ashwin Rajeev On Aug. 2, 2016, 7:45 a.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50691/ > --- > > (Updated Aug. 2, 2016, 7:45 a.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-17213 > https://issues.apache.org/jira/browse/AMBARI-17213 > > > Repository: ambari > > > Description > --- > > This is the initial patch of the worfklow designer > > > Diffs > - > > contrib/views/pom.xml 8cdf791 > contrib/views/wfmanager/pom.xml PRE-CREATION > contrib/views/wfmanager/src/assembly/assembly.xml PRE-CREATION > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/FileServices.java > PRE-CREATION > > contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java > PRE-CREATION > contrib/views/wfmanager/src/main/resources/WEB-INF/web.xml PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/README.md PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/app.js PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/.gitkeep > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/action-credential-config.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/action-version-select.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/archive-config.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/arg-config.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-job-details.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-job-details.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/credentials-config.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/decision-config.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-errors.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/distcp-action.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/email-action.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/field-error.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/file-config.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/file-upload.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/fs-action.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/global-config.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/header-logo-user-bar.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/help-icon.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/jdbc-url.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/job-log.js > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/jobxml-config.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/components/map-red-action.js > PRE-CREATION > > contrib/views/wfma
Re: Review Request 50792: "ItemNotFound" error on uploading table hive View
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50792/#review144753 --- Ship it! Ship It! - Ashwin Rajeev On Aug. 4, 2016, 12:54 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50792/ > --- > > (Updated Aug. 4, 2016, 12:54 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-18020 > https://issues.apache.org/jira/browse/AMBARI-18020 > > > Repository: ambari > > > Description > --- > > This is because of some issue with conflicting jersey libs. I have changed > the code to return Response object instead of pojo which solves the problem > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > 08d91e9 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java > a83d17d > > Diff: https://reviews.apache.org/r/50792/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 50790: Hive View History not showing old queries after upgrade.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50790/#review144751 --- Ship it! Ship It! - Ashwin Rajeev On Aug. 4, 2016, 12:19 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50790/ > --- > > (Updated Aug. 4, 2016, 12:19 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-18018 > https://issues.apache.org/jira/browse/AMBARI-18018 > > > Repository: ambari > > > Description > --- > > added upgrade code to update the timestamps from seconds to miliseconds as > expected in currently. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 4bc1a81 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 25fd423 > > Diff: https://reviews.apache.org/r/50790/diff/ > > > Testing > --- > > manual testing of upgrade from previous version done > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 50554: Ambari upgrade reports error upgrading view tables - possibly not an error but confusing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50554/#review144061 --- Ship it! Ship It! - Ashwin Rajeev On July 28, 2016, 11:37 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50554/ > --- > > (Updated July 28, 2016, 11:37 a.m.) > > > Review request for Ambari, Gaurav Nagar, Pallav Kulshreshtha, Rohit > Choudhary, Sumit Mohanty, and Ashwin Rajeev. > > > Bugs: AMBARI-17941 > https://issues.apache.org/jira/browse/AMBARI-17941 > > > Repository: ambari > > > Description > --- > > changed the error message and handling > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > a3d9c89 > > Diff: https://reviews.apache.org/r/50554/diff/ > > > Testing > --- > > manual testing > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 50328: Local and custom views are not working when swebhdfs and Namenode HA is enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50328/#review143205 --- Ship it! Ship It! - Ashwin Rajeev On July 22, 2016, 6:55 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50328/ > --- > > (Updated July 22, 2016, 6:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17849 > https://issues.apache.org/jira/browse/AMBARI-17849 > > > Repository: ambari > > > Description > --- > > Added name node https address in view properties. > > > Diffs > - > > contrib/views/files/src/main/resources/view.xml ad5202c > contrib/views/hive-next/src/main/resources/view.xml 326062c > contrib/views/hive/src/main/resources/view.xml 58acee6 > contrib/views/pig/src/main/resources/view.xml de338da > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java > 5d0c1d3 > > Diff: https://reviews.apache.org/r/50328/diff/ > > > Testing > --- > > Manually tested Files view with Namenode failover. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 50305: Views in Ambari UI don't render when proxied by Knox - contrib views
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50305/#review143126 --- Ship it! Ship It! - Ashwin Rajeev On July 21, 2016, 6:38 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50305/ > --- > > (Updated July 21, 2016, 6:38 p.m.) > > > Review request for Ambari, Jaimin Jetly, Rohit Choudhary, Ashwin Rajeev, and > Yusaku Sako. > > > Bugs: AMBARI-17295 > https://issues.apache.org/jira/browse/AMBARI-17295 > > > Repository: ambari > > > Description > --- > > When using Knox's AMBARIUI service to proxy the Ambari service's UI, the > various 'views' don't render. The rest of the UI around management of > services works correctly. > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js > 5c92ac7 > contrib/views/files/src/main/resources/ui/app/adapters/application.js > a7ccbf4 > contrib/views/files/src/main/resources/ui/app/index.html 51d1839 > contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 8bbcf01 > > Diff: https://reviews.apache.org/r/50305/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 50189: Getting error while executing query for adding udf jar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50189/#review142735 --- Ship it! Ship It! - Ashwin Rajeev On July 19, 2016, 12:13 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50189/ > --- > > (Updated July 19, 2016, 12:13 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17727 > https://issues.apache.org/jira/browse/AMBARI-17727 > > > Repository: ambari > > > Description > --- > > removed comment of --Global Settings-- from > query and corrected addition of semi colon at end > > > Diffs > - > > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js > d68d82e > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/settings.js > df135d3 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/utils/constants.js > bbe42cf > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js > 72f717d > contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js > df135d3 > contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js > cf87c9d > > Diff: https://reviews.apache.org/r/50189/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 49750: Upload table using Hive view will fail if Hive database is created with Location option
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49750/#review142540 --- Ship it! Ship It! - Ashwin Rajeev On July 7, 2016, 11:32 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49750/ > --- > > (Updated July 7, 2016, 11:32 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17605 > https://issues.apache.org/jira/browse/AMBARI-17605 > > > Repository: ambari > > > Description > --- > > Earlier : the hive view takes up property hive.metastore.warehouse.dir for > location of temporary table. > > In this patch : Now it will use query describe formatted for finding the > actual location of temporary table. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegator.java > 20b91f1 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegatorImpl.java > 0171626 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/browser/HiveBrowserService.java > 0da49c4 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > 18da1ff > > Diff: https://reviews.apache.org/r/49750/diff/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 50031: Error for Pig view after upgrade to 2.4.0.0 [PersistenceException: Can't initialize data store for view PIG]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50031/#review142237 --- Ship it! Ship It! - Ashwin Rajeev On July 14, 2016, 1:09 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50031/ > --- > > (Updated July 14, 2016, 1:09 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17710 > https://issues.apache.org/jira/browse/AMBARI-17710 > > > Repository: ambari > > > Description > --- > > Update SmokeTestEntity class name in viewentity table. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 67495b5 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 54f0e57 > > Diff: https://reviews.apache.org/r/50031/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 49991: Rerunning View data migration commands throwing exception
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49991/#review142228 --- Ship it! Ship It! - Ashwin Rajeev On July 13, 2016, 4:37 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49991/ > --- > > (Updated July 13, 2016, 4:37 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17691 > https://issues.apache.org/jira/browse/AMBARI-17691 > > > Repository: ambari > > > Description > --- > > Added persistence-unit for ambari-view-migration > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationContextImpl.java > 909b3a1 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationUtility.java > 15318c0 > > ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreModule.java > a995868 > ambari-server/src/main/resources/META-INF/persistence.xml d44f484 > > Diff: https://reviews.apache.org/r/49991/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 49450: Port changes of AMBARI-17421 to hive-jdbc view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49450/#review140166 --- Ship it! Ship It! - Ashwin Rajeev On June 30, 2016, 1:57 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49450/ > --- > > (Updated June 30, 2016, 1:57 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17501 > https://issues.apache.org/jira/browse/AMBARI-17501 > > > Repository: ambari > > > Description > --- > > ported and resolved conflicts. also added timeout of 1 sec before fetching > the status of job in loop > > > Diffs > - > > contrib/views/hive-next/pom.xml d108095 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java > 083423a > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java > 53b91db > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/viewJobs/JobImpl.java > 17d585f > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/CSVParams.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/TableDataReader.java > d7dba85 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/TableInput.java > 9c27b24 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadFromHdfsInput.java > 8214579 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > e0bc083 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/DataParser.java > 0aec39f > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/IParser.java > dc0c552 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseOptions.java > 53af85a > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java > 2623c4c > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/RowIterator.java > 747e7ff > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVIterator.java > c4abb99 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVParser.java > daff342 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/commonscsv/CSVIterator.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/commonscsv/CSVParser.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/opencsv/OpenCSVIterator.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/opencsv/OpenCSVParser.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/InsertFromQueryInput.java > 22dec67 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/QueryGenerator.java > a9bc2b9 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/RowFormat.java > PRE-CREATION > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/query/TableInfo.java > 2b91d7b > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 6fa6cfd > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js > a00f0b4 > contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss > f0c9a4c > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > 5e3a519 > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/CSVParserTest.java > fab1328 > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/Da
Re: Review Request 49433: Pig - Pig Helper - Relational Operator - GROUP and COGROUP function when selected, param section display incorrect number of param
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49433/#review140135 --- Ship it! Ship It! - Ashwin Rajeev On June 30, 2016, 11 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49433/ > --- > > (Updated June 30, 2016, 11 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17459 > https://issues.apache.org/jira/browse/AMBARI-17459 > > > Repository: ambari > > > Description > --- > > Corrected the params for GROUP and COGROUP > > > Diffs > - > > > contrib/views/pig/src/main/resources/ui/pig-web/app/assets/data/pigHelpers.json > 90d11ac > > contrib/views/pig/src/main/resources/ui/pig-web/app/components/helpers-data.js > b36fee0 > > Diff: https://reviews.apache.org/r/49433/diff/ > > > Testing > --- > > Maunally Tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 49379: Hive2 view : port changes of following 10 bugs in hive2 view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49379/#review139995 --- Ship it! Since these are pre approved changes. - Ashwin Rajeev On June 29, 2016, 2:46 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49379/ > --- > > (Updated June 29, 2016, 2:46 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17480 > https://issues.apache.org/jira/browse/AMBARI-17480 > > > Repository: ambari > > > Description > --- > > port following change in hive2 > AMBARI-16266 > AMBARI-16424 > AMBARI-16425 > AMBARI-16422 > AMBARI-16726 > AMBARI-16675 > AMBARI-16429 > AMBARI-16242 > AMBARI-16418 > AMBARI-16428 > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/persistence/DataStoreStorage.java > 9adf129 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java > 4293b1b > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/JobService.java > 975036e > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadFromHdfsInput.java > 7a7f77c > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java > 59e969d > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/DataParser.java > 6edc97c > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/IParser.java > 401ef48 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/ParseUtils.java > fefacce > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/Parser.java > 79c5482 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/csv/CSVParser.java > 74cc060 > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/json/JSONParser.java > 772b6fd > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/parsers/xml/XMLParser.java > 51671e5 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/file-upload.js > 1bd8eee > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/adapters/upload-table.js > ef4df43 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/file-upload.js > 1cd05ae > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/components/validated-text-field.js > PRE-CREATION > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index.js > 4f3261c > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/upload-table.js > cb267a0 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js > b3630c1 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/history.js > 848bee8 > contrib/views/hive-next/src/main/resources/ui/hive-web/app/services/job.js > 6cb4170 > contrib/views/hive-next/src/main/resources/ui/hive-web/app/styles/app.scss > 8f60595 > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs > PRE-CREATION > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > b7d9011 > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/CSVParserTest.java > PRE-CREATION > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserCSVTest.java > PRE-CREATION > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserJSONTest.java > PRE-CREATION > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/DataParserXMLTest.java > PRE-CREATION > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/JsonParserTest.java > PRE-CREATION > > contrib/views/hive-next/src/test/java/org/apache/ambari/view/hive2/resources/upload/QueryGeneratorTest.java > P
Re: Review Request 48032: Not able to save custom config in view config
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48032/#review135506 --- Ship it! Ship It! - Ashwin Rajeev On May 30, 2016, 8:55 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48032/ > --- > > (Updated May 30, 2016, 8:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16948 > https://issues.apache.org/jira/browse/AMBARI-16948 > > > Repository: ambari > > > Description > --- > > Added Nullpointer check for cluster_handle field. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > bdb1087 > > Diff: https://reviews.apache.org/r/48032/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 47644: All created views disappear after upgrade to 2.4.0.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47644/#review134146 --- Ship it! Ship It! - Ashwin Rajeev On May 20, 2016, 10:15 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47644/ > --- > > (Updated May 20, 2016, 10:15 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16791 > https://issues.apache.org/jira/browse/AMBARI-16791 > > > Repository: ambari > > > Description > --- > > In permission_roleauthorization added VIEW.USE permission for administrator. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog230.java > 53a22c8 > > Diff: https://reviews.apache.org/r/47644/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 47526: Hive View : History tab in hive view does not show recent jobs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47526/#review134100 --- Ship it! Ship It! - Ashwin Rajeev On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47526/ > --- > > (Updated May 19, 2016, 10:22 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16675 > https://issues.apache.org/jira/browse/AMBARI-16675 > > > Repository: ambari > > > Description > --- > > Earliar : hive jobs with referrer only as 'job' were being shown in history > > In this patch : all the jobs including sample, explain, visual explain will > be shown which was the cause for recent jobs not showning. > > > Diffs > - > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java > e646fd7 > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js > 9584508 > contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js > 848bee8 > > Diff: https://reviews.apache.org/r/47526/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47525: Hive View : Upload table still shows file name after the upload is done
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47525/#review134099 --- Fix it, then Ship it! Fix it then ship it contrib/views/hive/src/main/resources/ui/hive-web/app/components/file-upload.js (line 30) <https://reviews.apache.org/r/47525/#comment198744> Remove logging - Ashwin Rajeev On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47525/ > --- > > (Updated May 19, 2016, 10:22 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16726 > https://issues.apache.org/jira/browse/AMBARI-16726 > > > Repository: ambari > > > Description > --- > > Earlier : The UI does not get cleared properly after the upload. It still > shows file name. > > In this patch : the UI will no longer show the old file name if the upload is > successfull. > > > Diffs > - > > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/file-upload.js > 1cd05ae > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 361de7b > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > eb95292 > > Diff: https://reviews.apache.org/r/47525/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47524: Hive view : For Upload Table, 'default' DB should be selected by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47524/#review134097 --- Ship it! Ship It! - Ashwin Rajeev On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47524/ > --- > > (Updated May 19, 2016, 10:22 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16429 > https://issues.apache.org/jira/browse/AMBARI-16429 > > > Repository: ambari > > > Description > --- > > Earlier : first db in the list was selected or was kept empty. > > In this patch : 'default' hive db will be selected. > > > Diffs > - > > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 361de7b > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > eb95292 > > Diff: https://reviews.apache.org/r/47524/diff/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47527: Hive view : Upload Table- marks column as INT since first 6 rows have INT values.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47527/#review134096 --- Ship it! Fix it then ship it - Ashwin Rajeev On May 19, 2016, 10:23 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47527/ > --- > > (Updated May 19, 2016, 10:23 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16418 > https://issues.apache.org/jira/browse/AMBARI-16418 > > > Repository: ambari > > > Description > --- > > Earlier : datatype of a column was decided based on maximum number of > occurence of a datatype, even if other values do not have same datatype. > > In this patch : even if 1 of the value in the preview rows do not conform to > a datatype then it is rejected. > > > Diffs > - > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java > b6b000a > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/DataParser.java > 7eae679 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/IParser.java > 6056e73 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseUtils.java > a17346f > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java > 1644c13 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVParser.java > 56cff58 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/json/JSONParser.java > 1d61798 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/xml/XMLParser.java > 74bf272 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/CSVParserTest.java > fb4c4da > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java > 99f758b > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java > 79166bb > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java > 4199257 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/JsonParserTest.java > 38ed225 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/XMLParserTest.java > d048a62 > > Diff: https://reviews.apache.org/r/47527/diff/ > > > Testing > --- > > extra test cases added for this algorithm of detection of datatype. existing > test cases changed to conform new algorithm. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47527: Hive view : Upload Table- marks column as INT since first 6 rows have INT values.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47527/#review134095 --- contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java (line 111) <https://reviews.apache.org/r/47527/#comment198742> IS this exception severe from the users perspective, if yes then log at the error level contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java (line 140) <https://reviews.apache.org/r/47527/#comment198743> Same here - Ashwin Rajeev On May 19, 2016, 10:23 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47527/ > --- > > (Updated May 19, 2016, 10:23 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16418 > https://issues.apache.org/jira/browse/AMBARI-16418 > > > Repository: ambari > > > Description > --- > > Earlier : datatype of a column was decided based on maximum number of > occurence of a datatype, even if other values do not have same datatype. > > In this patch : even if 1 of the value in the preview rows do not conform to > a datatype then it is rejected. > > > Diffs > - > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java > b6b000a > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/DataParser.java > 7eae679 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/IParser.java > 6056e73 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseUtils.java > a17346f > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java > 1644c13 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVParser.java > 56cff58 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/json/JSONParser.java > 1d61798 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/xml/XMLParser.java > 74bf272 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/CSVParserTest.java > fb4c4da > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java > 99f758b > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java > 79166bb > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java > 4199257 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/JsonParserTest.java > 38ed225 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/XMLParserTest.java > d048a62 > > Diff: https://reviews.apache.org/r/47527/diff/ > > > Testing > --- > > extra test cases added for this algorithm of detection of datatype. existing > test cases changed to conform new algorithm. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47460: Explain script on pig views encountered an IOExecption
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47460/#review133998 --- Ship it! Ship It! - Ashwin Rajeev On May 17, 2016, 3 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47460/ > --- > > (Updated May 17, 2016, 3 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16707 > https://issues.apache.org/jira/browse/AMBARI-16707 > > > Repository: ambari > > > Description > --- > > Changed url formation for explian script > > > Diffs > - > > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobResourceManager.java > 2bd5745 > > Diff: https://reviews.apache.org/r/47460/diff/ > > > Testing > --- > > Manually tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 47604: View URLs: UX edits #4
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47604/#review133993 --- Ship it! Fix it then ship it - Ashwin Rajeev On May 19, 2016, 4:38 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47604/ > --- > > (Updated May 19, 2016, 4:38 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Ashwin Rajeev. > > > Bugs: AMBARI-16771 > https://issues.apache.org/jira/browse/AMBARI-16771 > > > Repository: ambari > > > Description > --- > > minor UX changes for short URL > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js > 2b1fb3b > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > d7dc9c7 > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html > 3a69a50 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html > 2481d59 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html > e0b8a4e > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html > c98ec3e > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html > 9e0ef4c > > Diff: https://reviews.apache.org/r/47604/diff/ > > > Testing > --- > > manually tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 47604: View URLs: UX edits #4
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47604/#review133992 --- ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js (line 446) <https://reviews.apache.org/r/47604/#comment198658> pls remove console.log - Ashwin Rajeev On May 19, 2016, 4:38 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47604/ > --- > > (Updated May 19, 2016, 4:38 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Ashwin Rajeev. > > > Bugs: AMBARI-16771 > https://issues.apache.org/jira/browse/AMBARI-16771 > > > Repository: ambari > > > Description > --- > > minor UX changes for short URL > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js > 2b1fb3b > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > d7dc9c7 > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 0ad183c > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html > 3a69a50 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html > 2481d59 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listUrls.html > e0b8a4e > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/create.html > c98ec3e > ambari-admin/src/main/resources/ui/admin-web/app/views/urls/edit.html > 9e0ef4c > > Diff: https://reviews.apache.org/r/47604/diff/ > > > Testing > --- > > manually tested > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133929 --- Ship it! Ship It! - Ashwin Rajeev On May 17, 2016, 10:10 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46962/ > --- > > (Updated May 17, 2016, 10:10 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16242 > https://issues.apache.org/jira/browse/AMBARI-16242 > > > Repository: ambari > > > Description > --- > > Earlier : > the id for dynamic entity was created in the application with the use of > instance data for that view. This data is dependent on users and created > separate sequences for each user. So the id for one user was also generated > for other user. Hence the data in db of one user was getting overriden by > other user. > > In this patch : > Now the id is generated using table_sequence techique of JPA. table for > sequence is ambari_sequence. UpgradeCatalog240.java will add the current > sequence number for existing tables and for new table the sequence name will > be added automatically. As sequence size of 50 is provided for better > performances > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 1f3b1d3 > > ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java > 0ed260d > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java > 1e8f07f > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java > f7f883b > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java > 7ae7721 > > Diff: https://reviews.apache.org/r/46962/diff/ > > > Testing > --- > > Following manual testing has been done. > 1. upgrade script creates correct current sequences. Done by manually > upgrading old ambari with existing views. Next job will allocate 50 more ids > 2. for new tables the entry in ambari_sequence is automatically added and the > ids will start from 1. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47294: Upgrading ambari server fails when trying to create cluster_type column
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47294/#review132847 --- Ship it! Ship It! - Ashwin Rajeev On May 12, 2016, 7:55 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47294/ > --- > > (Updated May 12, 2016, 7:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16627 > https://issues.apache.org/jira/browse/AMBARI-16627 > > > Repository: ambari > > > Description > --- > > Changing default value to ClusterType.LOCAL_AMBARI.name() > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 3547ad3 > > Diff: https://reviews.apache.org/r/47294/diff/ > > > Testing > --- > > Manually tested on local vm. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 47023: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Server Side changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47023/#review131911 --- ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java (line 167) <https://reviews.apache.org/r/47023/#comment195945> Assuming there is some call which tries to get a cluster by name, then you should add a method on the DAO for this, and not get all and filter in memory. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java (line 254) <https://reviews.apache.org/r/47023/#comment195946> If you want to , use Strings.isNullOrEmpty() - Guava - Ashwin Rajeev On May 5, 2016, 4:16 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47023/ > --- > > (Updated May 5, 2016, 4:16 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj > Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16274 > https://issues.apache.org/jira/browse/AMBARI-16274 > > > Repository: ambari > > > Description > --- > > Added RemotAmbariClusterEntity, RemoteAmbariClusterDao to store remote > cluster credential. > Added RemoteClusterResourceProvider for accessing Remote Cluster through api. > Added RemoteAmbariCluster impementation for view.Cluster that can be accessed > through ViewContextImpl. > > > Diffs > - > > ambari-server/pom.xml 20d3fab > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/RemoteClusterResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > 0b77511 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RemoteClustersService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java > 4e7a032 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > 605f68d > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > 386e657 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteAmbariClusterDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteClusterServiceDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterServiceEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteClusterServiceEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java > 29dc2a7 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > 2d6e5ba > > ambari-server/src/main/java/org/apache/ambari/server/view/LocalAmbariClusterStreamProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterStreamProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariConfigurationReadException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java > 1dacd92 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java > ba7f446 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > d2d48a9 > > ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java > bb6a93c > ambari-server/src/main/resources/META-INF/persistence.xml ce563cb > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProviderTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apach
Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46738/#review130774 --- Ship it! Ship It! - Ashwin Rajeev On April 27, 2016, 12:49 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46738/ > --- > > (Updated April 27, 2016, 12:49 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16138 > https://issues.apache.org/jira/browse/AMBARI-16138 > > > Repository: ambari > > > Description > --- > > If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and > hive auth based on the hive and hdfs service config. > > > Diffs > - > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java > 05b55d2 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java > 1442748 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java > f5e9bcf > contrib/views/hive/src/main/resources/view.xml 8f8a470 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java > 25db721 > contrib/views/tez/readme.md fdb9459 > > contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java > 440ac65 > contrib/views/tez/src/main/resources/view.xml d8105f1 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java > a8ef43f > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java > c8ca6cd > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java > 4518ac6 > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java > 455ca20 > > Diff: https://reviews.apache.org/r/46738/diff/ > > > Testing > --- > > Manually Tested on local Vm. > Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 46689: Not able to edit Pig script tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46689/#review130591 --- Ship it! Ship It! - Ashwin Rajeev On April 26, 2016, 9:55 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46689/ > --- > > (Updated April 26, 2016, 9:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16116 > https://issues.apache.org/jira/browse/AMBARI-16116 > > > Repository: ambari > > > Description > --- > > Added check for filepath to start with '/' > > > Diffs > - > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java > 3eac2b7 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > 6697160 > > Diff: https://reviews.apache.org/r/46689/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 46689: Not able to edit Pig script tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46689/#review130581 --- contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java (line 207) <https://reviews.apache.org/r/46689/#comment194416> Possible NPE if filepath is null, I am not sure if this is ever possible. just double check this - Ashwin Rajeev On April 26, 2016, 9:55 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46689/ > --- > > (Updated April 26, 2016, 9:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16116 > https://issues.apache.org/jira/browse/AMBARI-16116 > > > Repository: ambari > > > Description > --- > > Added check for filepath to start with '/' > > > Diffs > - > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java > 3eac2b7 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > 6697160 > > Diff: https://reviews.apache.org/r/46689/diff/ > > > Testing > --- > > Manual Testing > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 46271: Migrate instance specific data from one version to another.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46271/#review130300 --- Ship it! Ship It! - Ashwin Rajeev On April 20, 2016, 7:47 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46271/ > --- > > (Updated April 20, 2016, 7:47 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Nitiraj > Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-15919 > https://issues.apache.org/jira/browse/AMBARI-15919 > > > Repository: ambari > > > Description > --- > > Added ability to migrate data using rest API. > Added data-migrator-class, data-version tags in view.xml . View needs to > implement ViewDataMigrator class that contains logic to migrate data from > older version. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewDataMigrationService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewInstanceService.java > 1eea8db > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/PrivilegeDAO.java > 772d538 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > 2555f93 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationContextImpl.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 7379f37 > > ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java > 728f620 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ViewDataMigrationServiceTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/ViewInstanceEntityTest.java > c8c15da > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewDataMigrationContextImplTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java > 14e5d3c > ambari-views/examples/README.md 650f650 > ambari-views/examples/calculator-view/pom.xml d5e0e8e > ambari-views/examples/cluster-view/pom.xml 99582a6 > ambari-views/examples/favorite-view/pom.xml ba196f5 > ambari-views/examples/hello-servlet-view/pom.xml ed6fc25 > ambari-views/examples/hello-spring-view/pom.xml 3475ef4 > ambari-views/examples/helloworld-view/pom.xml aa89778 > ambari-views/examples/phone-list-upgrade-view/docs/index.md PRE-CREATION > ambari-views/examples/phone-list-upgrade-view/pom.xml PRE-CREATION > > ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/DataMigrator.java > PRE-CREATION > > ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/PhoneListServlet.java > PRE-CREATION > > ambari-views/examples/phone-list-upgrade-view/src/main/java/org/apache/ambari/view/phonelist/PhoneUser.java > PRE-CREATION > > ambari-views/examples/phone-list-upgrade-view/src/main/resources/WEB-INF/web.xml > PRE-CREATION > ambari-views/examples/phone-list-upgrade-view/src/main/resources/view.xml > PRE-CREATION > ambari-views/examples/phone-list-view/pom.xml ead9095 > ambari-views/examples/pom.xml de55ded > ambari-views/examples/property-validator-view/pom.xml 045a277 > ambari-views/examples/property-view/pom.xml ad4630b > ambari-views/examples/restricted-view/pom.xml f7fa3d6 > ambari-views/examples/simple-view/pom.xml 015f192 > ambari-views/examples/weather-view/pom.xml a018258 > > ambari-views/src/main/java/org/apache/ambari/view/migration/EntityConverter.java > PRE-CREATION > > ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrationContext.java > PRE-CREATION > > ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrationException.java > PRE-CREATION > > ambari-views/src/main/java/org/apache/ambari/view/migration/ViewDataMigrator.java > PRE-CREATION > ambari-views/src/main/java/org/apache/ambari/view/validation/Validator.java > ee029a8 > ambari-views/src/main/resources/view.xsd c3ad711 > pom.xml f540099 > > Diff: https://reviews.apache.org/r/46271/diff/ > > > Testing > --- > > Manual testing. > > > Thanks, > > Gaurav Nagar > >
