Re: Review Request 51201: Generate REST API docs with Swagger for Log Search

2016-09-08 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51201/#review148144 --- Ship it! Ship It! - Dharmesh Makwana On Aug. 18, 2016, 10

Re: Review Request 51339: AMBARI-18196: Swagger part 2: upgrade to jersey2.x from jersey1.x

2016-08-23 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51339/#review146614 --- Ship it! Ship It! - Dharmesh Makwana On Aug. 23, 2016, 4:34

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-26 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50297/#review143489 --- Ship it! Ship It! - Dharmesh Makwana On July 26, 2016, 5:55

Re: Review Request 50207: Fix LogSearch Solr 'stop'

2016-07-19 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50207/#review142904 --- Ship it! Ship It! - Dharmesh Makwana On July 19, 2016, 11

Re: Review Request 50069: Docker based dev environment for Log Search

2016-07-19 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50069/#review142714 --- Ship it! Ship It! - Dharmesh Makwana On July 18, 2016, 1:28

Re: Review Request 49889: Fix logfeeder inputs for hbase and hdfs

2016-07-11 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49889/#review141671 --- Ship it! Ship It! - Dharmesh Makwana On July 11, 2016, 11

Re: Review Request 49539: AMBARI-17541: LogSearch should also show audit logs from Apache Ranger Solr

2016-07-04 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49539/#review140641 --- Ship it! Ship It! - Dharmesh Makwana On July 1, 2016, 11:04

Re: Review Request 49233: Remove superfluous Logfeeder codes

2016-06-26 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49233/#review139521 --- Ship it! Ship It! - Dharmesh Makwana On June 25, 2016, 11

Re: Review Request 48793: Log Level filter not applied before Log Search Starts at first

2016-06-20 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48793/#review138552 --- Ship it! Ship It! - Dharmesh Makwana On June 20, 2016, 7:47

Re: Review Request 48793: Log Level filter not applied before Log Search Starts at first

2016-06-20 Thread Dharmesh Makwana
output/OutputSolr.java (line 66) <https://reviews.apache.org/r/48793/#comment203732> same as above, only the constant name is "NAME". I think it will be better to change the constant name also in LogFeederConstants.java for "NAME". - Dharmesh Makwana On June 19,

Re: Review Request 48903: AMBARI-17307: LogFeeder output to Solr doesn't handle empty buffer queue properly

2016-06-18 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48903/#review138390 --- Ship it! Ship It! - Dharmesh Makwana On June 18, 2016, 6:59

Re: Review Request 48490: Last button in the log search pagination panel does not take the user to the last page and few more fixes

2016-06-14 Thread Dharmesh Makwana
eviews.apache.org/r/48490/#review137465 --- On June 14, 2016, 10:54 a.m., Dharmesh Makwana wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 48490: Last button in the log search pagination panel does not take the user to the last page and few more fixes

2016-06-13 Thread Dharmesh Makwana
/dialog/ApplySearchFilterView.js 4babebc Diff: https://reviews.apache.org/r/48490/diff/ Testing --- Setup Logsearch on 2 node cluster and tested the above feature. Thanks, Dharmesh Makwana

Re: Review Request 48338: LogSearch https support.

2016-06-07 Thread Dharmesh Makwana
. To reply, visit: https://reviews.apache.org/r/48338/#review136454 ------- On June 7, 2016, 1:25 p.m., Dharmesh Makwana wrote: > > --- > This is an automatic

Re: Review Request 48338: LogSearch https support.

2016-06-07 Thread Dharmesh Makwana
/PropertiesUtil.java f31e8f8 ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties f477c5a Diff: https://reviews.apache.org/r/48338/diff/ Testing --- Setup Logsearch on 3 node cluster and tested the above feature. Thanks, Dharmesh Makwana

Re: Review Request 48265: Comparison tab : Allow the comparison only when minimum 2 tabs are selected and minor fixes

2016-06-06 Thread Dharmesh Makwana
/tabs/HierarchyTabLayoutView_tmpl.html 1a3135f Diff: https://reviews.apache.org/r/48265/diff/ Testing --- Setup logsearch 2 node cluster and tested the above fixes. Thanks, Dharmesh Makwana

Review Request 48265: Comparison tab : Allow the comparison only when minimum 2 tabs are selected and minor fixes

2016-06-06 Thread Dharmesh Makwana
/diff/ Testing --- Setup logsearch 2 node cluster and tested the above fixes. Thanks, Dharmesh Makwana

Re: Review Request 48173: Fix logfeeder filter name of logsearch

2016-06-02 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48173/#review135961 --- Ship it! Ship It! - Dharmesh Makwana On June 2, 2016, 4:17

Re: Review Request 47586: Log Feeder Global exclusion default filter configuration is not effective in the log search indexing.

2016-06-01 Thread Dharmesh Makwana
, Dharmesh Makwana

Review Request 48124: Host checkboxes getting unselected when user clicks on search host button and few minor issues

2016-06-01 Thread Dharmesh Makwana
--- Setup logsearch on 3 node cluster and tested the above features. Thanks, Dharmesh Makwana

Review Request 47586: Log Feeder Global exclusion default filter configuration is not effective in the log search indexing.

2016-06-01 Thread Dharmesh Makwana
/ambari/logsearch/manager/UserConfigMgr.java 7a6e3e9 Diff: https://reviews.apache.org/r/47586/diff/ Testing --- Setup logsearch on 3 node cluster and tested the above features. Thanks, Dharmesh Makwana

Review Request 47590: Zero valued bars are thicker than bars with value in thousands in the Log search Log Level histograms

2016-05-19 Thread Dharmesh Makwana
/main/webapp/styles/style_v2.css 58a3d04 Diff: https://reviews.apache.org/r/47590/diff/ Testing --- Setup logsearch on 3 node cluster and tested the above features. Thanks, Dharmesh Makwana

Review Request 47344: Log count text on Log level select boxes in Service Logs Tab not getting updated while checking and unchecking

2016-05-13 Thread Dharmesh Makwana
/scripts/views/dashboard/LogLevelBoxView.js 2d5096a Diff: https://reviews.apache.org/r/47344/diff/ Testing --- Tested in local Ambari environment. Thanks, Dharmesh Makwana

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Dharmesh Makwana
To reply, visit: https://reviews.apache.org/r/47296/#review132892 --- On May 13, 2016, 6:48 a.m., Dharmesh Makwana wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Dharmesh Makwana
eviews.apache.org/r/47296/#review132928 --- On May 13, 2016, 6:48 a.m., Dharmesh Makwana wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-13 Thread Dharmesh Makwana
a 79a414c ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties 315d736 Diff: https://reviews.apache.org/r/47296/diff/ Testing --- Tested in my local Ambari environment. Thanks, Dharmesh Makwana

Re: Review Request 47296: Authentication API changes along with role integration and few minor fixes.

2016-05-12 Thread Dharmesh Makwana
nvironment. Thanks, Dharmesh Makwana

Review Request 47300: Included few more steps in "Take a tour" feature and few more enhancements

2016-05-12 Thread Dharmesh Makwana
pl.html b3eeaf5 Diff: https://reviews.apache.org/r/47300/diff/ Testing --- Tested in local Ambari environment. Thanks, Dharmesh Makwana

Re: Review Request 47163: AMBARI-16420: LogFeeder not using fully qualified domain name

2016-05-10 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47163/#review132407 --- Ship it! Ship It! - Dharmesh Makwana On May 10, 2016, 7:58

Review Request 47011: Added top navbar on login page.

2016-05-05 Thread Dharmesh Makwana
--- Top navbar looks as expected and help flow tested on the internal test server. Thanks, Dharmesh Makwana