---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64956/#review194855
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 4, 2018, 10
-
mvn clean test
live cluster check
Thanks,
Dmitro Lisnichenko
rc/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
6ba1671cdf
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
e93cd1303a
Diff: https://reviews.apache.org/r/64950/diff/1/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
//reviews.apache.org/r/64751/diff/3/
Changes: https://reviews.apache.org/r/64751/diff/2-3/
Testing
---
mvn clean test
Live cluster check
Thanks,
Dmitro Lisnichenko
uest
- Dmitro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64667/#review194438
---
On Dec. 16, 2017, 5:53 p.m., Dmitro Lisnichenko wrote:
>
> ---
>
https://reviews.apache.org/r/64751/diff/2/
Changes: https://reviews.apache.org/r/64751/diff/1-2/
Testing
---
mvn clean test
Live cluster check
Thanks,
Dmitro Lisnichenko
kage in a loop, so return here would break
the execution flow
- Dmitro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64751/#review194249
----------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64722/#review194243
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 19, 2017, 10
py
dfadd84
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py
c8497cd
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
62a46b9
Diff: https://reviews.apache.org/r/64751/diff/1/
Testing
---
mvn clean test
Live cluster check
Thanks,
Dmitro Lisnichenko
this method ...
>
> Jonathan Hurley wrote:
> Also, i think livy2 also had this
>
> Dmitro Lisnichenko wrote:
> This fix will not work for Livy2, because it is also missing from
> stack_packages.json
also, conf-select has not idea about Livy2
/usr/bin/conf-sel
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/64667/#review194033
-----------
On Dec. 16, 2017, 5:53 p.m., Dmitro Lisnichenko wrote:
>
> ---
>
;
> > We should not hard code this into install_packages. Can we just expose
> > this method for the Livy Python files to call?
>
> Dmitro Lisnichenko wrote:
> In this case, this code should run before install_packages.py .
> Otherwise, symlinks will be badly broken, and my
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64667/#review194019
-------
On Dec. 16, 2017, 5:53 p.m., Dmitro Lisnichenko wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64637/#review194016
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 15, 2017, 5
://reviews.apache.org/r/64667/diff/1/
Testing
---
mvn clean test,
live cluster check
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64652/#review193934
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 15, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64554/#review193705
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 13, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64502/#review193410
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 11, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64419/#review193236
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 7, 2017, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64348/#review192974
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 5, 2017, 8
g (updated)
---
mvn clean test
check on live cluster
Thanks,
Dmitro Lisnichenko
/resources/common-services/SPARK/1.2.1/package/scripts/params.py
9b813a13f0
Diff: https://reviews.apache.org/r/64340/diff/1/
Testing
---
waiting for feedback from reviewers to apply this change to all Livy and Livy2
service scripts
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64316/#review192837
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Dec. 5, 2017, 12
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64223/#review192471
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 30, 2017, 11
://reviews.apache.org/r/63516/diff/4/
Changes: https://reviews.apache.org/r/63516/diff/3-4/
Testing
---
tests do not pass yet, also on deploy get errors in some places.
Fixing mistakes
Thanks,
Dmitro Lisnichenko
1:14:15,495 - Execute[' echo 'snapshot_all' |
/usr/iop/current/hbase-client/bin/hbase shell'] {'user': 'hbase'}
{code}
Diffs (updated)
-
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HBASE/package/scripts/params.py
c0c314d
Diff: https://reviews.apache.org/r/64205/diff/3/
Changes: https://reviews.apache.org/r/64205/diff/2-3/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
shot_all' |
/usr/iop/current/hbase-client/bin/hbase shell'] {'user': 'hbase'}
{code}
Diffs (updated)
-
ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HBASE/package/scripts/params.py
c0c314dcdf
Diff: https://reviews.apache.org/r/64205/diff/2/
Changes: https://reviews.apache.org/r/64205/diff/1-2/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
y
8ad0d51376
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py
da75a8ee89
ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py
2c2c90113a
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/packa
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64090/#review192016
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 27, 2017, 9
on live cluster
Thanks,
Dmitro Lisnichenko
/org/apache/ambari/server/checks/LZOCheckTest.java
e50e936
Diff: https://reviews.apache.org/r/64030/diff/1/
Testing
---
mvn clean test
and check on live cluster
Thanks,
Dmitro Lisnichenko
: https://reviews.apache.org/r/63516/diff/2-3/
Testing
---
tests do not pass yet, also on deploy get errors in some places.
Fixing mistakes
Thanks,
Dmitro Lisnichenko
use -1 if not current cluster version exists. But if we
happen to have entries at SERVICE_DESIRED_STATE_TABLE or
SERVICE_COMPONENT_DESIRED_STATE_TABLE, that would populate their current
cluster version id with -1
Open for discussion
- Dmitro Lisnichenko
On Nov. 21, 2017, 7:56 p.m.,
rmat}
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
96ce807d5f
Diff: https://reviews.apache.org/r/63961/diff/2/
Changes: https://reviews.apache.org/r/63961/diff/1-2/
Testing (updated)
---
check on live cluster
tests passed
Thanks,
Dmitro Lisnichenko
quot;Unable to find any CURRENT repositories.");
} else if (currentVersionList.size() != 1) {
throw new AmbariException("The following repositories were found to be
CURRENT: ".concat(StringUtils.join(currentVersionList, ",")));
}
- Dmitro Lisnichenko
r/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
96ce807d5f
Diff: https://reviews.apache.org/r/63961/diff/1/
Testing
---
pending check on live cluster
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63880/#review191321
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 16, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63807/#review191046
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 14, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63698/#review190824
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 13, 2017, 5
/diff/3/
Changes: https://reviews.apache.org/r/63695/diff/2-3/
Testing (updated)
---
mvn clean test
live cluster check
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63729/#review190722
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 10, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63713/#review190701
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 10, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63698/#review190582
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 9, 2017, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review189988
---
On Nov. 9, 2017, 11:58 a.m., Dmitro Lisnichenko wrote:
>
> -
://reviews.apache.org/r/63695/diff/2/
Changes: https://reviews.apache.org/r/63695/diff/1-2/
Testing
---
checking
Thanks,
Dmitro Lisnichenko
Thanks,
Dmitro Lisnichenko
yet, also on deploy get errors in some places.
Fixing mistakes
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63684/#review190553
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 8, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63671/#review190464
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 8, 2017, 7
> On Nov. 7, 2017, 1:10 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
> > Line 119 (original), 119 (patched)
> > <https://reviews.apache.org/r/63595/diff/1/?file=18
che.org/r/63595/#comment267581>
is it intended to remove env passed here?
- Dmitro Lisnichenko
On Nov. 6, 2017, 11:17 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> ht
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63558/#review190149
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 4, 2017, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63535/#review190052
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 3, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63537/#review190035
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 3, 2017, 4
mistakes
Thanks,
Dmitro Lisnichenko
erver/upgrade/UpgradeCatalog260.java
6f379858c0
Diff: https://reviews.apache.org/r/63150/diff/1/
Testing
---
Live cluster check passed
Tests passed
Thanks,
Dmitro Lisnichenko
sts passed
Thanks,
Dmitro Lisnichenko
ssed
Tests are running
Thanks,
Dmitro Lisnichenko
che/ambari/server/orm/DBAccessorImpl.java
09316be8b3
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
6f379858c0
Diff: https://reviews.apache.org/r/63150/diff/1/
Testing
---
Tests are running
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63075/#review188330
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 17, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63032/#review188151
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 16, 2017, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62996/#review188111
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 16, 2017, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62949/#review187941
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 12, 2017, 11
/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
5a24bbb22b
Diff: https://reviews.apache.org/r/62931/diff/1/
Testing (updated)
---
mvn clean test
Also checked Ambari upgrade with this patch and affected DB from QA cluster
Thanks,
Dmitro Lisnichenko
/UpgradeCatalog260.java
5a24bbb22b
Diff: https://reviews.apache.org/r/62931/diff/1/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62895/#review187753
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 11, 2017, 7
(SchemaUpgradeHelper.java:200)
... 1 more{code}
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java
20b991b279
Diff: https://reviews.apache.org/r/62922/diff/1/
Testing
---
mvn clean test
manual check on live cluster
Thanks,
Dmitro Lisnichenko
---
ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java
20b991b279
Diff: https://reviews.apache.org/r/62922/diff/1/
Testing
---
mvn clean test
manual check on live cluster
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62866/#review187658
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 11, 2017, 5
/configuration/hive-site.xml
Lines 700 (patched)
<https://reviews.apache.org/r/62866/#comment264708>
After Ambari 2.5, we usually tend to avoid adding/modifying configs during
Ambari upgrade
- Dmitro Lisnichenko
On Oct. 11, 2017, 3:09 p.m., Eugene Chekanskiy
/ambari/server/checks/AbstractCheckDescriptor.java
Lines 318 (patched)
<https://reviews.apache.org/r/62871/#comment264700>
comment seems to be irrelevant to the code
- Dmitro Lisnichenko
On Oct. 10, 2017, 11:42 p.m., Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62851/#review187510
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 10, 2017, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62848/#review187509
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 9, 2017, 10
---
mvn clean test
and live cluster check
Thanks,
Dmitro Lisnichenko
(updated)
---
mvn clean test
and live cluster check
Thanks,
Dmitro Lisnichenko
,
Dmitro Lisnichenko
/libraries/script/script.py
Lines 216 (patched)
<https://reviews.apache.org/r/62794/#comment264177>
instlled
- Dmitro Lisnichenko
On Oct. 6, 2017, 6:16 a.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62785/#review187196
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 5, 2017, 4
/internal/UpgradeResourceProvider.java
Lines 478 (patched)
<https://reviews.apache.org/r/62785/#comment264091>
what does 0.35/0.09 mean here? Would it play well for big/small numbers of
tasks?
- Dmitro Lisnichenko
On Oct. 5, 2017, 4:01 p.m., Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62754/#review187080
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 4, 2017, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62764/#review187078
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 4, 2017, 1
Thanks,
Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62726/#review186937
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 2, 2017, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62719/#review186822
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Oct. 2, 2017, 2
/1/
Testing
---
mvn clean test
Thanks,
Dmitro Lisnichenko
ent263405>
How it differs from componentName?
- Dmitro Lisnichenko
On Sept. 28, 2017, 9:27 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62578/#review186287
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Sept. 26, 2017, 7
ter/ClusterImpl.java
9fd7663b96
Diff: https://reviews.apache.org/r/62571/diff/2/
Changes: https://reviews.apache.org/r/62571/diff/1-2/
Testing
---
mvn clean test
live test on cluster. Not 100% sure that the last issue is fixed, but probably
yes
Thanks,
Dmitro Lisnichenko
src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
63e3840a5d
Diff: https://reviews.apache.org/r/62413/diff/2/
Testing (updated)
---
tests on live cluster
mvn clean test
Thanks,
Dmitro Lisnichenko
9
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
63e3840a5d
Diff: https://reviews.apache.org/r/62413/diff/2/
Changes: https://reviews.apache.org/r/62413/diff/1-2/
Testing
---
tests on live cluster
Thanks,
Dmitro Lisnichenko
ews.apache.org/r/62571/diff/1/
Testing
---
mvn clean test
live test on cluster. Not 100% sure that the last issue is fixed, but probably
yes
Thanks,
Dmitro Lisnichenko
/hooks/before-ANY/scripts/shared_initialization.py
Line 159 (original), 158 (patched)
<https://reviews.apache.org/r/62467/#comment262241>
how about adding comment with meaning of None?
- Dmitro Lisnichenko
On Sept. 21, 2017, 6:32 p.m., Eugene Chekanskiy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62468/#review185901
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Sept. 21, 2017, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62454/#review185866
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Sept. 20, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62448/#review185865
---
Ship it!
Ship It!
- Dmitro Lisnichenko
On Sept. 20, 2017
>
> {code}
>
> Now we have two constraints here
> "unq_users_0" UNIQUE, btree (user_name, user_type)
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name) <- WRONG
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> afd3d1d6a5
>
>
> Diff: https://reviews.apache.org/r/62413/diff/1/
>
>
> Testing
> ---
>
> tests on live cluster
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
constraints that target given columns
- name of primary key constraint for table
- names of foreign key constraints for table
- Dmitro Lisnichenko
On Sept. 19, 2017, 7:17 p.m., Dmitro Lisnichenko wrote:
>
> ---
> Thi
E, btree (ldap_user, user_name) <- WRONG
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
afd3d1d6a5
Diff: https://reviews.apache.org/r/62413/diff/1/
Testing
---
tests on live cluster
Thanks,
Dmitro Lisnichenko
/package/scripts/service.py
Lines 88 (patched)
<https://reviews.apache.org/r/62388/#comment261898>
Sounds like a very dirty hack. Does that reproduce in latest Ambari
versions? Maybe it would be better to check status() before attempt to run
start() ?
- Dmitro Lisnichenko
On Sept. 18
1 - 100 of 663 matches
Mail list logo