Re: Review Request 64956: Update Hadoop RPC Encryption Properties During Kerberization and Upgrade

2018-01-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64956/#review194855 --- Ship it! Ship It! - Dmitro Lisnichenko On Jan. 4, 2018, 10

Re: Review Request 64950: Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

2018-01-04 Thread Dmitro Lisnichenko
- mvn clean test live cluster check Thanks, Dmitro Lisnichenko

Review Request 64950: Ambari Upgrade failed in case if database have no cluster_version table already. The issue with idempotence

2018-01-04 Thread Dmitro Lisnichenko
rc/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 6ba1671cdf ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java e93cd1303a Diff: https://reviews.apache.org/r/64950/diff/1/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 64751: Fix Broken Symlinks on Stack Distribution

2017-12-26 Thread Dmitro Lisnichenko
//reviews.apache.org/r/64751/diff/3/ Changes: https://reviews.apache.org/r/64751/diff/2-3/ Testing --- mvn clean test Live cluster check Thanks, Dmitro Lisnichenko

Re: Review Request 64667: Livy server fails to start during downgrade due to absence of 'conf' directory

2017-12-22 Thread Dmitro Lisnichenko
uest - Dmitro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64667/#review194438 --- On Dec. 16, 2017, 5:53 p.m., Dmitro Lisnichenko wrote: > > --- >

Re: Review Request 64751: Fix Broken Symlinks on Stack Distribution

2017-12-21 Thread Dmitro Lisnichenko
https://reviews.apache.org/r/64751/diff/2/ Changes: https://reviews.apache.org/r/64751/diff/1-2/ Testing --- mvn clean test Live cluster check Thanks, Dmitro Lisnichenko

Re: Review Request 64751: Fix Broken Symlinks on Stack Distribution

2017-12-21 Thread Dmitro Lisnichenko
kage in a loop, so return here would break the execution flow - Dmitro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64751/#review194249 ----------

Re: Review Request 64722: [Patch Hive]webhcat: test_sqoop fails with hdfs:///hdp/apps/2.6.*/sqoop/sqoop.tar.gz does not exist

2017-12-20 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64722/#review194243 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 19, 2017, 10

Review Request 64751: Fix Broken Symlinks on Stack Distribution

2017-12-20 Thread Dmitro Lisnichenko
py dfadd84 ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c8497cd ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json 62a46b9 Diff: https://reviews.apache.org/r/64751/diff/1/ Testing --- mvn clean test Live cluster check Thanks, Dmitro Lisnichenko

Re: Review Request 64667: Livy server fails to start during downgrade due to absence of 'conf' directory

2017-12-18 Thread Dmitro Lisnichenko
this method ... > > Jonathan Hurley wrote: > Also, i think livy2 also had this > > Dmitro Lisnichenko wrote: > This fix will not work for Livy2, because it is also missing from > stack_packages.json also, conf-select has not idea about Livy2 /usr/bin/conf-sel

Re: Review Request 64667: Livy server fails to start during downgrade due to absence of 'conf' directory

2017-12-18 Thread Dmitro Lisnichenko
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/64667/#review194033 ----------- On Dec. 16, 2017, 5:53 p.m., Dmitro Lisnichenko wrote: > > --- >

Re: Review Request 64667: Livy server fails to start during downgrade due to absence of 'conf' directory

2017-12-17 Thread Dmitro Lisnichenko
; > > We should not hard code this into install_packages. Can we just expose > > this method for the Livy Python files to call? > > Dmitro Lisnichenko wrote: > In this case, this code should run before install_packages.py . > Otherwise, symlinks will be badly broken, and my

Re: Review Request 64667: Livy server fails to start during downgrade due to absence of 'conf' directory

2017-12-16 Thread Dmitro Lisnichenko
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64667/#review194019 ------- On Dec. 16, 2017, 5:53 p.m., Dmitro Lisnichenko wrote: > > ---

Re: Review Request 64637: Livy/Livy2 Unable To Start Due to Address Already In Use

2017-12-16 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64637/#review194016 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 15, 2017, 5

Review Request 64667: Livy server fails to start during downgrade due to absence of 'conf' directory

2017-12-16 Thread Dmitro Lisnichenko
://reviews.apache.org/r/64667/diff/1/ Testing --- mvn clean test, live cluster check Thanks, Dmitro Lisnichenko

Re: Review Request 64652: unable to proceed with cluster install after component install fails.

2017-12-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64652/#review193934 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 15, 2017, 7

Re: Review Request 64554: HBase Cannot Find LZO Classes After Being Patched

2017-12-13 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64554/#review193705 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 13, 2017, 5

Re: Review Request 64502: YARN Shuffle Service Can't Be Found On Client-Only Nodes After New Cluster Install

2017-12-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64502/#review193410 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 11, 2017, 7

Re: Review Request 64419: Hive Queries Failing with Missing SnappyCodec Compression Type Due to Hive's Use of MapReduce Admin Env Property

2017-12-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64419/#review193236 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 7, 2017, 10

Re: Review Request 64348: Pig service check failed after PU with LzoCodec CNF

2017-12-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64348/#review192974 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 5, 2017, 8

Re: Review Request 64340: Livy server start fails during EU with 'Address already in use' error

2017-12-05 Thread Dmitro Lisnichenko
g (updated) --- mvn clean test check on live cluster Thanks, Dmitro Lisnichenko

Review Request 64340: PREVIEW - Livy server start fails during EU with 'Address already in use' error

2017-12-05 Thread Dmitro Lisnichenko
/resources/common-services/SPARK/1.2.1/package/scripts/params.py 9b813a13f0 Diff: https://reviews.apache.org/r/64340/diff/1/ Testing --- waiting for feedback from reviewers to apply this change to all Livy and Livy2 service scripts Thanks, Dmitro Lisnichenko

Re: Review Request 64316: Messages for some services during PU package installation indicate circular dependency

2017-12-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64316/#review192837 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 5, 2017, 12

Re: Review Request 63516: Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

2017-12-04 Thread Dmitro Lisnichenko
Thanks, Dmitro Lisnichenko

Re: Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-12-01 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64223/#review192471 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 30, 2017, 11

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

2017-12-01 Thread Dmitro Lisnichenko
://reviews.apache.org/r/63516/diff/4/ Changes: https://reviews.apache.org/r/63516/diff/3-4/ Testing --- tests do not pass yet, also on deploy get errors in some places. Fixing mistakes Thanks, Dmitro Lisnichenko

Re: Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Dmitro Lisnichenko
1:14:15,495 - Execute[' echo 'snapshot_all' | /usr/iop/current/hbase-client/bin/hbase shell'] {'user': 'hbase'} {code} Diffs (updated) - ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HBASE/package/scripts/params.py c0c314d Diff: https://reviews.apache.org/r/64205/diff/3/ Changes: https://reviews.apache.org/r/64205/diff/2-3/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Dmitro Lisnichenko
shot_all' | /usr/iop/current/hbase-client/bin/hbase shell'] {'user': 'hbase'} {code} Diffs (updated) - ambari-server/src/main/resources/stacks/BigInsights/4.2/services/HBASE/package/scripts/params.py c0c314dcdf Diff: https://reviews.apache.org/r/64205/diff/2/ Changes: https://reviews.apache.org/r/64205/diff/1-2/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Dmitro Lisnichenko
y 8ad0d51376 ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py da75a8ee89 ambari-server/src/main/resources/stacks/PERF/1.0/hooks/before-ANY/scripts/params.py 2c2c90113a ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/packa

Re: Review Request 64090: ATS start failed during patch upgrade due to CNF SparkATSPlugin

2017-11-28 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64090/#review192016 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 27, 2017, 9

Re: Review Request 64030: Modify AMBARI-22387 to Check for LZO + No Opt-in

2017-11-22 Thread Dmitro Lisnichenko
on live cluster Thanks, Dmitro Lisnichenko

Review Request 64030: Modify AMBARI-22387 to Check for LZO + No Opt-in

2017-11-22 Thread Dmitro Lisnichenko
/org/apache/ambari/server/checks/LZOCheckTest.java e50e936 Diff: https://reviews.apache.org/r/64030/diff/1/ Testing --- mvn clean test and check on live cluster Thanks, Dmitro Lisnichenko

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

2017-11-21 Thread Dmitro Lisnichenko
: https://reviews.apache.org/r/63516/diff/2-3/ Testing --- tests do not pass yet, also on deploy get errors in some places. Fixing mistakes Thanks, Dmitro Lisnichenko

Re: Review Request 63961: Ambari upgrade failed

2017-11-21 Thread Dmitro Lisnichenko
use -1 if not current cluster version exists. But if we happen to have entries at SERVICE_DESIRED_STATE_TABLE or SERVICE_COMPONENT_DESIRED_STATE_TABLE, that would populate their current cluster version id with -1 Open for discussion - Dmitro Lisnichenko On Nov. 21, 2017, 7:56 p.m.,

Re: Review Request 63961: Ambari upgrade failed

2017-11-21 Thread Dmitro Lisnichenko
rmat} Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 96ce807d5f Diff: https://reviews.apache.org/r/63961/diff/2/ Changes: https://reviews.apache.org/r/63961/diff/1-2/ Testing (updated) --- check on live cluster tests passed Thanks, Dmitro Lisnichenko

Re: Review Request 63961: Ambari upgrade failed

2017-11-20 Thread Dmitro Lisnichenko
quot;Unable to find any CURRENT repositories."); } else if (currentVersionList.size() != 1) { throw new AmbariException("The following repositories were found to be CURRENT: ".concat(StringUtils.join(currentVersionList, ","))); } - Dmitro Lisnichenko

Review Request 63961: Ambari upgrade failed

2017-11-20 Thread Dmitro Lisnichenko
r/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 96ce807d5f Diff: https://reviews.apache.org/r/63961/diff/1/ Testing --- pending check on live cluster Thanks, Dmitro Lisnichenko

Re: Review Request 63880: VDF defined HDP-GPL repo should be tagged appropriately

2017-11-17 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63880/#review191321 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 16, 2017, 5

Re: Review Request 63807: Add Native Libraries To Tez Tarball

2017-11-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63807/#review191046 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 14, 2017, 11

Re: Review Request 63698: Implement many-to-many relation between keytabs and principals

2017-11-13 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63698/#review190824 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 13, 2017, 5

Re: Review Request 63695: Create a Pre-Upgrade Check Warning About LZO

2017-11-10 Thread Dmitro Lisnichenko
/diff/3/ Changes: https://reviews.apache.org/r/63695/diff/2-3/ Testing (updated) --- mvn clean test live cluster check Thanks, Dmitro Lisnichenko

Re: Review Request 63729: Blueprint deploys failing with missing smoke user keytab file

2017-11-10 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63729/#review190722 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 10, 2017, 5

Re: Review Request 63713: Restart all required services failed when running cluster with several patch upgrades applied

2017-11-10 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63713/#review190701 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 10, 2017, 3

Re: Review Request 63698: Implement many-to-many relation between keytabs and principals

2017-11-09 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63698/#review190582 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 9, 2017, 2

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

2017-11-09 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63516/#review189988 --- On Nov. 9, 2017, 11:58 a.m., Dmitro Lisnichenko wrote: > > -

Re: Review Request 63695: Create a Pre-Upgrade Check Warning About LZO

2017-11-09 Thread Dmitro Lisnichenko
://reviews.apache.org/r/63695/diff/2/ Changes: https://reviews.apache.org/r/63695/diff/1-2/ Testing --- checking Thanks, Dmitro Lisnichenko

Review Request 63695: Create a Pre-Upgrade Check Warning About LZO

2017-11-09 Thread Dmitro Lisnichenko
Thanks, Dmitro Lisnichenko

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

2017-11-09 Thread Dmitro Lisnichenko
yet, also on deploy get errors in some places. Fixing mistakes Thanks, Dmitro Lisnichenko

Re: Review Request 63684: Patch Upgrades Broken For Clients Due To Versioned LD Library

2017-11-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63684/#review190553 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 8, 2017, 11

Re: Review Request 63671: Remove Auto-Installation of LZO Libraries

2017-11-08 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63671/#review190464 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 8, 2017, 7

Re: Review Request 63595: Remove HADOOP_HOME From Environment For Daemons

2017-11-07 Thread Dmitro Lisnichenko
> On Nov. 7, 2017, 1:10 p.m., Dmitro Lisnichenko wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > > Line 119 (original), 119 (patched) > > <https://reviews.apache.org/r/63595/diff/1/?file=18

Re: Review Request 63595: Remove HADOOP_HOME From Environment For Daemons

2017-11-07 Thread Dmitro Lisnichenko
che.org/r/63595/#comment267581> is it intended to remove env passed here? - Dmitro Lisnichenko On Nov. 6, 2017, 11:17 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 63558: AMBARI-22361: Fix bug in base_alert when matching hostnames.

2017-11-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63558/#review190149 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 4, 2017, 11

Re: Review Request 63535: Send ClusterSummary to install_packages and conf-select exclusion

2017-11-03 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63535/#review190052 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 3, 2017, 4

Re: Review Request 63537: Specify the Correct HIVE_BIN In Hive Scripts

2017-11-03 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63537/#review190035 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 3, 2017, 4

Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

2017-11-02 Thread Dmitro Lisnichenko
mistakes Thanks, Dmitro Lisnichenko

Re: Review Request 63150: Ambari Schema Upgrade Failed during Ambari Upgrade (configuration: 2.5.2.0 -> 2.6.0.0 upgrade)

2017-10-19 Thread Dmitro Lisnichenko
erver/upgrade/UpgradeCatalog260.java 6f379858c0 Diff: https://reviews.apache.org/r/63150/diff/1/ Testing --- Live cluster check passed Tests passed Thanks, Dmitro Lisnichenko

Re: Review Request 63150: Ambari Schema Upgrade Failed during Ambari Upgrade

2017-10-19 Thread Dmitro Lisnichenko
sts passed Thanks, Dmitro Lisnichenko

Re: Review Request 63150: Ambari Schema Upgrade Failed during Ambari Upgrade

2017-10-19 Thread Dmitro Lisnichenko
ssed Tests are running Thanks, Dmitro Lisnichenko

Review Request 63150: Ambari Schema Upgrade Failed during Ambari Upgrade

2017-10-19 Thread Dmitro Lisnichenko
che/ambari/server/orm/DBAccessorImpl.java 09316be8b3 ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 6f379858c0 Diff: https://reviews.apache.org/r/63150/diff/1/ Testing --- Tests are running Thanks, Dmitro Lisnichenko

Re: Review Request 63075: RU: RU failed on "Updating configuration sqoop-atlas-application.properties"

2017-10-17 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63075/#review188330 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 17, 2017, 5

Re: Review Request 63032: YARN Service Checks Fails Because of Old hadoop-client Classpath Entry

2017-10-16 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63032/#review188151 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 16, 2017, 7

Re: Review Request 62996: Restart of random service could fail during express downgrade

2017-10-16 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62996/#review188111 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 16, 2017, 4

Re: Review Request 62949: RU: Downgrade is failed ZKFC

2017-10-13 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62949/#review187941 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 12, 2017, 11

Re: Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Dmitro Lisnichenko
/org/apache/ambari/server/upgrade/UpgradeCatalog260.java 5a24bbb22b Diff: https://reviews.apache.org/r/62931/diff/1/ Testing (updated) --- mvn clean test Also checked Ambari upgrade with this patch and affected DB from QA cluster Thanks, Dmitro Lisnichenko

Review Request 62931: Ambari Schema Upgrade Failed during Ambari Upgrade (patch with workaround)

2017-10-12 Thread Dmitro Lisnichenko
/UpgradeCatalog260.java 5a24bbb22b Diff: https://reviews.apache.org/r/62931/diff/1/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

2017-10-12 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187753 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 11, 2017, 7

Re: Review Request 62922: "ambari-server upgrade" failed on db schema [Upgrade]

2017-10-11 Thread Dmitro Lisnichenko
(SchemaUpgradeHelper.java:200) ... 1 more{code} Diffs - ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 20b991b279 Diff: https://reviews.apache.org/r/62922/diff/1/ Testing --- mvn clean test manual check on live cluster Thanks, Dmitro Lisnichenko

Review Request 62922: "ambari-server upgrade" failed on db schema [Upgrade]

2017-10-11 Thread Dmitro Lisnichenko
--- ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java 20b991b279 Diff: https://reviews.apache.org/r/62922/diff/1/ Testing --- mvn clean test manual check on live cluster Thanks, Dmitro Lisnichenko

Re: Review Request 62866: Make hive server create directories related to replication

2017-10-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62866/#review187658 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 11, 2017, 5

Re: Review Request 62866: Make hive server create directories related to replication

2017-10-11 Thread Dmitro Lisnichenko
/configuration/hive-site.xml Lines 700 (patched) <https://reviews.apache.org/r/62866/#comment264708> After Ambari 2.5, we usually tend to avoid adding/modifying configs during Ambari upgrade - Dmitro Lisnichenko On Oct. 11, 2017, 3:09 p.m., Eugene Chekanskiy

Re: Review Request 62871: Prevent Patch Upgrades With Known Service Incompatibilities

2017-10-11 Thread Dmitro Lisnichenko
/ambari/server/checks/AbstractCheckDescriptor.java Lines 318 (patched) <https://reviews.apache.org/r/62871/#comment264700> comment seems to be irrelevant to the code - Dmitro Lisnichenko On Oct. 10, 2017, 11:42 p.m., Jonathan Hurley

Re: Review Request 62851: Install and upgrade options are shown for current and already upgraded stack versions

2017-10-10 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62851/#review187510 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 10, 2017, 12

Re: Review Request 62848: Not able to perform revert after deleting the upgraded service

2017-10-10 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62848/#review187509 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 9, 2017, 10

Re: Review Request 62807: Ambari schema upgrade fails when upgrading ambari from 2.5.1.0 to 2.6.0.0 and using oracle as database

2017-10-06 Thread Dmitro Lisnichenko
--- mvn clean test and live cluster check Thanks, Dmitro Lisnichenko

Re: Review Request 62807: Ambari schema upgrade fails when upgrading ambari from 2.5.1.0 to 2.6.0.0 and using oracle as database

2017-10-06 Thread Dmitro Lisnichenko
(updated) --- mvn clean test and live cluster check Thanks, Dmitro Lisnichenko

Review Request 62807: Ambari schema upgrade fails when upgrading ambari from 2.5.1.0 to 2.6.0.0 and using oracle as database

2017-10-06 Thread Dmitro Lisnichenko
, Dmitro Lisnichenko

Re: Review Request 62794: CURRENT cluster Shows Upgrade If Component Didn't Report Version

2017-10-06 Thread Dmitro Lisnichenko
/libraries/script/script.py Lines 216 (patched) <https://reviews.apache.org/r/62794/#comment264177> instlled - Dmitro Lisnichenko On Oct. 6, 2017, 6:16 a.m., Jonathan Hurley wrote: > > --- > This is an automatically g

Re: Review Request 62785: Hitting pause during upgrade jumps progress to 100%

2017-10-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62785/#review187196 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 5, 2017, 4

Re: Review Request 62785: Hitting pause during upgrade jumps progress to 100%

2017-10-05 Thread Dmitro Lisnichenko
/internal/UpgradeResourceProvider.java Lines 478 (patched) <https://reviews.apache.org/r/62785/#comment264091> what does 0.35/0.09 mean here? Would it play well for big/small numbers of tasks? - Dmitro Lisnichenko On Oct. 5, 2017, 4:01 p.m., Nate Cole

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

2017-10-04 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/#review187080 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 4, 2017, 12

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/#review187078 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 4, 2017, 1

Re: Review Request 62718: Refactor existing server side actions to use the common AbstractUpgradeServerAction

2017-10-03 Thread Dmitro Lisnichenko
Thanks, Dmitro Lisnichenko

Re: Review Request 62726: Some ResourceProviders Are Not Transactional

2017-10-03 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62726/#review186937 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 2, 2017, 5

Re: Review Request 62719: Upgrades Do Not Finalize If Other Host Versions Are Out of Sync

2017-10-02 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62719/#review186822 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 2, 2017, 2

Review Request 62718: Refactor existing server side actions to use the common AbstractUpgradeServerAction

2017-10-01 Thread Dmitro Lisnichenko
/1/ Testing --- mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 62675: Wrong Hadoop Home Directory Is Being Picked Up on MAINT/PATCH Upgraded Clusters

2017-09-29 Thread Dmitro Lisnichenko
ent263405> How it differs from componentName? - Dmitro Lisnichenko On Sept. 28, 2017, 9:27 p.m., Jonathan Hurley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 62578: Stack selection page does not load the HDP stacks (Redux)

2017-09-26 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62578/#review186287 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 26, 2017, 7

Re: Review Request 62571: Fail to restart Ranger Admin during HDP downgrade.

2017-09-26 Thread Dmitro Lisnichenko
ter/ClusterImpl.java 9fd7663b96 Diff: https://reviews.apache.org/r/62571/diff/2/ Changes: https://reviews.apache.org/r/62571/diff/1-2/ Testing --- mvn clean test live test on cluster. Not 100% sure that the last issue is fixed, but probably yes Thanks, Dmitro Lisnichenko

Re: Review Request 62413: Ambari upgrade don't delete stale constraints

2017-09-26 Thread Dmitro Lisnichenko
src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java 63e3840a5d Diff: https://reviews.apache.org/r/62413/diff/2/ Testing (updated) --- tests on live cluster mvn clean test Thanks, Dmitro Lisnichenko

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-26 Thread Dmitro Lisnichenko
9 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java 63e3840a5d Diff: https://reviews.apache.org/r/62413/diff/2/ Changes: https://reviews.apache.org/r/62413/diff/1-2/ Testing --- tests on live cluster Thanks, Dmitro Lisnichenko

Review Request 62571: Fail to restart Ranger Admin during HDP downgrade.

2017-09-26 Thread Dmitro Lisnichenko
ews.apache.org/r/62571/diff/1/ Testing --- mvn clean test live test on cluster. Not 100% sure that the last issue is fixed, but probably yes Thanks, Dmitro Lisnichenko

Re: Review Request 62467: Add UID/GID related issue with external users not listed in /etc/passwd

2017-09-21 Thread Dmitro Lisnichenko
/hooks/before-ANY/scripts/shared_initialization.py Line 159 (original), 158 (patched) <https://reviews.apache.org/r/62467/#comment262241> how about adding comment with meaning of None? - Dmitro Lisnichenko On Sept. 21, 2017, 6:32 p.m., Eugene Chekanskiy

Re: Review Request 62468: OOZIE/OOZIE_SERVER restart failed saying AttributeError: 'NoneType' object has no attribute 'upper' during EU

2017-09-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62468/#review185901 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 21, 2017, 6

Re: Review Request 62454: Could not copy tez tarball to HDFS during prepare upgrade (EU)

2017-09-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62454/#review185866 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 20, 2017

Re: Review Request 62448: Addition of service component after patching a service still keeps the component at base version

2017-09-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62448/#review185865 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 20, 2017

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko
> > {code} > > Now we have two constraints here > "unq_users_0" UNIQUE, btree (user_name, user_type) > "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name) <- WRONG > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > afd3d1d6a5 > > > Diff: https://reviews.apache.org/r/62413/diff/1/ > > > Testing > --- > > tests on live cluster > > > Thanks, > > Dmitro Lisnichenko > >

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko
constraints that target given columns - name of primary key constraint for table - names of foreign key constraints for table - Dmitro Lisnichenko On Sept. 19, 2017, 7:17 p.m., Dmitro Lisnichenko wrote: > > --- > Thi

Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko
E, btree (ldap_user, user_name) <- WRONG Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java afd3d1d6a5 Diff: https://reviews.apache.org/r/62413/diff/1/ Testing --- tests on live cluster Thanks, Dmitro Lisnichenko

Re: Review Request 62388: APPLICATION_TIMELINE_SERVER filed to start, coz were already started

2017-09-18 Thread Dmitro Lisnichenko
/package/scripts/service.py Lines 88 (patched) <https://reviews.apache.org/r/62388/#comment261898> Sounds like a very dirty hack. Does that reproduce in latest Ambari versions? Maybe it would be better to check status() before attempt to run start() ? - Dmitro Lisnichenko On Sept. 18

  1   2   3   4   5   6   7   >