Re: Review Request 64693: Add service group dependencies

2017-12-22 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64693/#review194409 --- Ship it! Ship It! - Dmytro Sen On Dec. 21, 2017, 11:07 p.m

Re: Review Request 64782: Add service dependencies

2017-12-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64782/#review194349 --- Ship it! Ship It! - Dmytro Sen On Dec. 21, 2017, 5:03 p.m

Re: Review Request 64606: Fix unit tests in feature branch to make them workable

2017-12-14 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64606/#review193792 --- Ship it! Ship It! - Dmytro Sen On Dec. 14, 2017, 12:23 p.m

Re: Review Request 64117: PERF stack fixes

2017-11-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64117/#review192024 --- Ship it! Ship It! - Dmytro Sen On Nov. 28, 2017, 1:07 p.m

Re: Review Request 64088: AMBARI-22524 : Journal Node start failing when AMS is installed during BP deploy

2017-11-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64088/#review192008 --- Ship it! Ship It! - Dmytro Sen On Nov. 27, 2017, 6:54 p.m

Re: Review Request 63701: Upstart is not able to stop the ambari-agent

2017-11-09 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63701/#review190587 --- Ship it! Ship It! - Dmytro Sen On Nov. 9, 2017, 2:08 p.m

Re: Review Request 61841: Ensure topology_mappings.data has 0644 permissions

2017-10-02 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61841/#review186838 --- Ship it! Ship It! - Dmytro Sen On None, Andrew Onischuk

Re: Review Request 62501: configs.py does not work properly when dealing with files

2017-09-22 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62501/#review185968 --- Ship it! Ship It! - Dmytro Sen On Sept. 22, 2017, 11:02 a.m

Re: Review Request 62500: File "hdfs.headless.keytab" has incorrect permission

2017-09-22 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62500/#review185965 --- Ship it! Ship It! - Dmytro Sen On Sept. 22, 2017, 10:31 a.m

Re: Review Request 62250: AMBARI-21939 : Ambari HDFS Heatmaps are not showing data (Not Applicable) for bytes read, bytes written & DataNode Process Network I/O Utilization

2017-09-12 Thread Dmytro Sen
/widgets.json Line 340 (original), 340 (patched) <https://reviews.apache.org/r/62250/#comment261500> Make sure to update the same for HDP 3.0 in trunk (../HDFS/3.0.0.3.0/widgets.json) - Dmytro Sen On Sept. 12, 2017, 4:58 p.m., Aravindan Vijayan

Re: Review Request 61842: Ensure topology_mappings.data has 0644 permissions

2017-08-23 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61842/#review183583 --- Ship it! Ship It! - Dmytro Sen On Aug. 23, 2017, 8:39 a.m

Re: Review Request 61684: Report alerts status to server

2017-08-16 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61684/#review183031 --- Ship it! Ship It! - Dmytro Sen On Aug. 16, 2017, 9:47 a.m

Re: Review Request 61400: Race condition causing execution commands to fail

2017-08-03 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61400/#review182093 --- Ship it! Ship It! - Dmytro Sen On Aug. 3, 2017, 9:23 a.m

Re: Review Request 61273: Do not call refreshnodes command after deleting a slave

2017-08-02 Thread Dmytro Sen
--------- On Aug. 2, 2017, 3:08 p.m., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61273/ >

Re: Review Request 61273: Do not call refreshnodes command after deleting a slave

2017-08-02 Thread Dmytro Sen
ts/params_windows.py cac93ee121 Diff: https://reviews.apache.org/r/61273/diff/2/ Changes: https://reviews.apache.org/r/61273/diff/1-2/ Testing --- manual + unit tests Thanks, Dmytro Sen

Review Request 61273: Do not call refreshnodes command after deleting a slave

2017-08-01 Thread Dmytro Sen
ri/server/controller/AmbariManagementControllerImpl.java 36cfb0f ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 2b8bf93 Diff: https://reviews.apache.org/r/61273/diff/1/ Testing --- manual + unit tests Thanks, Dmytro Sen

Re: Review Request 61186: Service repos are not updated with "latest" url in repoinfo.xml

2017-07-27 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61186/#review181583 --- Ship it! Ship It! - Dmytro Sen On Июль 27, 2017, 5:05 п.п

Re: Review Request 61177: Don't set restart indicators for NN/RM during DN/NM deletion

2017-07-27 Thread Dmytro Sen
/diff/2/ Changes: https://reviews.apache.org/r/61177/diff/1-2/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 61177: Don't set restart indicators for NN/RM during DN/NM deletion

2017-07-27 Thread Dmytro Sen
Thanks, Dmytro Sen

Re: Review Request 61074: Restart due to Stale configurations leads to an internal system exception

2017-07-25 Thread Dmytro Sen
ps://reviews.apache.org/r/61074/#review181231 ----------- On Июль 25, 2017, 8:59 д.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 61074: Restart due to Stale configurations leads to an internal system exception

2017-07-25 Thread Dmytro Sen
elper.java f4b650e ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java a8f7638 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java d243e73 Diff: https://reviews.apache.org/r/61074/diff/2/ Changes: https://reviews.apache.org/r/61074/diff/1-2/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 61074: Restart due to Stale configurations leads to an internal system exception

2017-07-24 Thread Dmytro Sen
t: https://reviews.apache.org/r/61074/#review181227 ------- On Июль 24, 2017, 7:32 д.п., Dmytro Sen wrote: > > --- > This is an automatically generated e

Review Request 61074: Restart due to Stale configurations leads to an internal system exception

2017-07-24 Thread Dmytro Sen
org/apache/ambari/server/controller/internal/RequestResourceProvider.java a8f7638 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java d243e73 Diff: https://reviews.apache.org/r/61074/diff/1/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 60999: Add host doesn't fully add a node when include/exclude files are used

2017-07-24 Thread Dmytro Sen
; > > > Can you please add comments why we need to track this separately? > > Dmytro Sen wrote: > For simpler maintenance. > > Sid Wagle wrote: > I meant adding code comments. It's in the code. - Dmytro --

Re: Review Request 60999: Add host doesn't fully add a node when include/exclude files are used

2017-07-21 Thread Dmytro Sen
ated e-mail. To reply, visit: https://reviews.apache.org/r/60999/#review181074 ----------- On Июль 21, 2017, 11 д.п., Dmytro Sen wrote: > > --- > This is a

Re: Review Request 60999: Add host doesn't fully add a node when include/exclude files are used

2017-07-21 Thread Dmytro Sen
testing. Thanks, Dmytro Sen

Review Request 60999: Add host doesn't fully add a node when include/exclude files are used

2017-07-20 Thread Dmytro Sen
5180870 ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4229d34 Diff: https://reviews.apache.org/r/60999/diff/1/ Testing --- Manual testing. Thanks, Dmytro Sen

Re: Review Request 60981: EU failure: Oozie service check fails if Falcon is not installed

2017-07-20 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60981/#review181015 --- Ship it! Ship It! - Dmytro Sen On Июль 19, 2017, 7:48 п.п

Review Request 60972: Include/exclude files update is triggered when master is not started if cluster is deployed via BP

2017-07-19 Thread Dmytro Sen
/ Testing --- Manual testing Thanks, Dmytro Sen

Re: Review Request 60762: Discrepancy in the OS name in ambari for PPC

2017-07-11 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60762/#review180176 --- Ship it! Ship It! - Dmytro Sen On Июль 11, 2017, 9:56 д.п

Re: Review Request 60198: Handle scenario when host in-memory aggregation is not working

2017-07-10 Thread Dmytro Sen
ce/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultConditionTest.java e4e922554b Diff: https://reviews.apache.org/r/60198/diff/2/ Changes: https://reviews.apache.org/r/60198/diff/1-2/ Testing --- In progress Thanks, Dmytro Sen

Re: Review Request 60738: HdfsResource can not handle S3 URL when hbase.rootdir is set to S3 URL

2017-07-10 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60738/#review180017 --- Ship it! Ship It! - Dmytro Sen On Июль 10, 2017, 9:47 д.п

Re: Review Request 60683: Fix execution/custom_commands/custom_actions/service_checks. Send clusterHostInfo

2017-07-06 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60683/#review179774 --- Ship it! Ship It! - Dmytro Sen On Июль 6, 2017, 12:26 п.п

Re: Review Request 60642: Support cancel commands, some changes to status/command reports, bugfixes

2017-07-04 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60642/#review179579 --- Ship it! Ship It! - Dmytro Sen On Июль 4, 2017, 2:33 п.п

Re: Review Request 60201: AMBARI-17382 : Migrate AMS queries to use ROW_TIMESTAMP instead of native timerange hint

2017-06-29 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60201/#review179244 --- Ship it! Ship It! - Dmytro Sen On Июнь 21, 2017, 8:39 п.п

Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-06-22 Thread Dmytro Sen
> On Июнь 9, 2017, 11:57 д.п., Dmytro Sen wrote: > > Ship It! > > zhangxiaolu zhangxiaolu wrote: > thank you for reviewing this patch. Could you be so kind as to commit the > patch for me please? Thanks in advance Can't apply the patch on trunk. Could you update

Re: Review Request 60201: AMBARI-17382 : Migrate AMS queries to use ROW_TIMESTAMP instead of native timerange hint

2017-06-21 Thread Dmytro Sen
actSQL#NATIVE_TIME_RANGE_DELTA can be removed from PhoenixTransactSQL - Dmytro Sen On Июнь 19, 2017, 7:14 п.п., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 60201: AMBARI-17382 : Migrate AMS queries to use ROW_TIMESTAMP instead of native timerange hint

2017-06-21 Thread Dmytro Sen
/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java Line 45 (original) <https://reviews.apache.org/r/60201/#comment252491> We are using startTime but hbase column is named SERVER_TIME Should we rename it accordingly? - Dmyt

Re: Review Request 60201: AMBARI-17382 : Migrate AMS queries to use ROW_TIMESTAMP instead of native timerange hint

2017-06-21 Thread Dmytro Sen
/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java Line 324 (original), 324 (patched) <https://reviews.apache.org/r/60201/#comment252490> No need to discard - Dmytro Sen On Июнь 19, 2017, 7:14 п.п., Aravindan Vijayan

Re: Review Request 60201: AMBARI-17382 : Migrate AMS queries to use ROW_TIMESTAMP instead of native timerange hint

2017-06-21 Thread Dmytro Sen
(original), 37 (patched) <https://reviews.apache.org/r/60201/#comment252489> I think hadoop.version should match hadoop.tar version from ambari-metrics/pom.xml - Dmytro Sen On Июнь 19, 2017, 7:14 п.п., Aravindan Vijayan

Re: Review Request 60077: Add https support to local metrics aggregator application

2017-06-20 Thread Dmytro Sen
://reviews.apache.org/r/60077/diff/1-2/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 60198: Handle scenario when host in-memory aggregation is not working

2017-06-19 Thread Dmytro Sen
To reply, visit: https://reviews.apache.org/r/60198/#review178267 ------- On Июнь 19, 2017, 1:56 п.п., Dmytro Sen wrote: > > --- > This is an automatica

Review Request 60198: Handle scenario when host in-memory aggregation is not working

2017-06-19 Thread Dmytro Sen
diff/1/ Testing --- In progress Thanks, Dmytro Sen

Re: Review Request 60113: Exception needs to be handled properly for mail alert

2017-06-19 Thread Dmytro Sen
iff: https://reviews.apache.org/r/60113/diff/3/ Changes: https://reviews.apache.org/r/60113/diff/2-3/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 60113: Exception needs to be handled properly for mail alert

2017-06-16 Thread Dmytro Sen
iff: https://reviews.apache.org/r/60113/diff/2/ Changes: https://reviews.apache.org/r/60113/diff/1-2/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 60098: Add Kerberos HTTP SPNEGO authentication support to Accumulo

2017-06-16 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60098/#review178095 --- Ship it! Ship It! - Dmytro Sen On Июнь 14, 2017, 9:24 п.п

Re: Review Request 60131: update yarn-env.xml in HDP2.6 for YARN sinks' HTTP SPNEGO Authentication

2017-06-16 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60131/#review178085 --- Ship it! Ship It! - Dmytro Sen On Июнь 15, 2017, 7:38 п.п

Review Request 60113: Exception needs to be handled properly for mail alert

2017-06-15 Thread Dmytro Sen
server/src/main/java/org/apache/ambari/server/state/services/AlertNoticeDispatchService.java 2972f51 Diff: https://reviews.apache.org/r/60113/diff/1/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 60045: Add validation and recommendation if hive user value is different than hive

2017-06-15 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60045/#review177979 --- Ship it! Ship It! - Dmytro Sen On Июнь 13, 2017, 11:57 д.п

Review Request 60077: Add https support to local metrics aggregator application

2017-06-14 Thread Dmytro Sen
/stacks/2.0.6/configs/default_ams_embedded.json 71423c8 contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/hooks/before-START/scripts/params.py 8cc876f Diff: https://reviews.apache.org/r/60077/diff/1/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 59951: AMBARI-21214 : Use a uuid vs long row key for metrics in AMS schema

2017-06-13 Thread Dmytro Sen
apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java Line 1197 (original), 1207 (patched) <https://reviews.apache.org/r/59951/#comment251474> Looks like the last parameter is always null and not needed anymore - Dmytro Sen On Июнь 9, 20

Re: Review Request 59920: Yarn stopped by itself after start. HA run

2017-06-09 Thread Dmytro Sen
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59920/#review177326 ------- On Июнь 9, 2017, 11:59 д.п., Dmytro Sen wrote: > > --

Re: Review Request 59920: Yarn stopped by itself after start. HA run

2017-06-09 Thread Dmytro Sen
3.0/package/scripts/resourcemanager.py 78675bf Diff: https://reviews.apache.org/r/59920/diff/2/ Changes: https://reviews.apache.org/r/59920/diff/1-2/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-06-09 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57583/#review177463 --- Ship it! Ship It! - Dmytro Sen On Июнь 9, 2017, 9:58 д.п

Re: Review Request 59943: Incorrect ambari DDL script for Oracle DB

2017-06-09 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59943/#review177455 --- Ship it! Ship It! - Dmytro Sen On Июнь 9, 2017, 9:53 д.п

Review Request 59920: Yarn stopped by itself after start. HA run

2017-06-08 Thread Dmytro Sen
age/scripts/resourcemanager.py 78675bf Diff: https://reviews.apache.org/r/59920/diff/1/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-06-08 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59149/#review177290 --- Ship it! Ship It! - Dmytro Sen On Июнь 1, 2017, 6:52 п.п

Re: Review Request 59574: Add AMS HA support to local metrics aggregator application

2017-06-07 Thread Dmytro Sen
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59574/#review176339 ------- On Май 26, 2017, 1:03 п.п., Dmytro Sen wrote: > > ---

Re: Review Request 59574: Add AMS HA support to local metrics aggregator application

2017-06-07 Thread Dmytro Sen
the current collector host is not available - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59574/#review176339 -------

Re: Review Request 59574: Add AMS HA support to local metrics aggregator application

2017-05-26 Thread Dmytro Sen
://reviews.apache.org/r/59574/diff/1-2/ Testing --- Unit tests + manual testing with AMS HA Thanks, Dmytro Sen

Review Request 59574: Add AMS HA support to local metrics aggregator application

2017-05-25 Thread Dmytro Sen
/aggregator.py 2249e53 ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/controller.py e5da9ba Diff: https://reviews.apache.org/r/59574/diff/1/ Testing --- Unit tests + manual testing with AMS HA Thanks, Dmytro Sen

Re: Review Request 59450: HDP 3.0 TP - create service definition for Zeppelin with configs, kerberos, widgets, etc

2017-05-23 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59450/#review175763 --- Ship it! Ship It! - Dmytro Sen On Май 22, 2017, 2:32 п.п

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-05-22 Thread Dmytro Sen
> On Май 18, 2017, 9:54 д.п., Dmytro Sen wrote: > > Please check if changes from ambari-server/src/main/resources/stacks/HDP/* > > need to be duplicated for services that has been flattened for stack 3.0 > > Qin Liu wrote: > Hi Dmytro, > > Thank you

Re: Review Request 59401: Kafka broker goes down after Ambari upgrade from 2.5.0 to 2.5.1 due to missing 'kafka.timeline.metrics.instanceId' property

2017-05-19 Thread Dmytro Sen
/server/upgrade/UpgradeCatalog251Test.java 4575998 Diff: https://reviews.apache.org/r/59401/diff/1/ Testing --- manual + unit tests Thanks, Dmytro Sen

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-05-18 Thread Dmytro Sen
/stacks/HDP/* need to be duplicated for services that has been flattened for stack 3.0 - Dmytro Sen On Май 13, 2017, 8:56 п.п., Qin Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-05-16 Thread Dmytro Sen
/ Testing --- Under development Thanks, Dmytro Sen

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-05-16 Thread Dmytro Sen
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review175020 --- On Апрель 28, 2017, 4:41 п.п., Dmytro Sen wrote: > >

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-28 Thread Dmytro Sen
/ Testing --- Under development Thanks, Dmytro Sen

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-28 Thread Dmytro Sen
#file1700474line81> > > > > Can we move initiazliation outside? Fixed (Created abstract publisher class) - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-28 Thread Dmytro Sen
://reviews.apache.org/r/58424/diff/2-3/ Testing --- Under development Thanks, Dmytro Sen

Re: Review Request 58814: Ambari clean up for 3.0

2017-04-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58814/#review173318 --- Ship it! Ship It! - Dmytro Sen On Апрель 28, 2017, 11:53

Re: Review Request 58814: Ambari clean up for 3.0

2017-04-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58814/#review173312 --- Ship it! Ship It! - Dmytro Sen On Апрель 28, 2017, 11:07

Re: Review Request 58814: Ambari clean up for 3.0

2017-04-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58814/#review173313 --- Ship it! Ship It! - Dmytro Sen On Апрель 28, 2017, 11:07

Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

2017-04-26 Thread Dmytro Sen
diff/4-5/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-26 Thread Dmytro Sen
/hooks/before-START/templates/hadoop-metrics2.properties.j2 fcd9b23 Diff: https://reviews.apache.org/r/58424/diff/2/ Changes: https://reviews.apache.org/r/58424/diff/1-2/ Testing --- Under development Thanks, Dmytro Sen

Review Request 58739: test_kill_process_with_children and test_facterMemInfoOutput test fails

2017-04-26 Thread Dmytro Sen
t/src/test/python/ambari_agent/TestHardware.py d30020c ambari-agent/src/test/python/ambari_agent/TestShell.py 5dc1899 Diff: https://reviews.apache.org/r/58739/diff/1/ Testing --- Unit tests passed. Thanks, Dmytro Sen

Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

2017-04-26 Thread Dmytro Sen
diff/3-4/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

2017-04-25 Thread Dmytro Sen
94425e0 Diff: https://reviews.apache.org/r/58620/diff/3/ Changes: https://reviews.apache.org/r/58620/diff/2-3/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

2017-04-24 Thread Dmytro Sen
94425e0 Diff: https://reviews.apache.org/r/58620/diff/2/ Changes: https://reviews.apache.org/r/58620/diff/1-2/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 58620: Stack side changes to use instanceId for cluster based segregation of data (AMS)

2017-04-21 Thread Dmytro Sen
src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-metrics2.properties.xml 4aadb83 ambari-server/src/test/python/stacks/2.0.6/configs/default.json 94425e0 Diff: https://reviews.apache.org/r/58620/diff/1/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 58619: Stack side changes to use instanceId for cluster based segregation of data (AMS)

2017-04-21 Thread Dmytro Sen
Thanks, Dmytro Sen

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-14 Thread Dmytro Sen
mail. To reply, visit: https://reviews.apache.org/r/58424/#review171899 --- On Апрель 13, 2017, 4:54 п.п., Dmytro Sen wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-14 Thread Dmytro Sen
parate task, and for now just switch off a minute aggregation if in-memory one is configured? - Dmytro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review171905 --- On Апрель 13, 2017, 4:54 п.п., Dmytro Sen wrote

Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Dmytro Sen
/src/main/java/org/apache/ambari/TimelineMetricsHolder.java PRE-CREATION Diff: https://reviews.apache.org/r/58424/diff/1/ Testing --- Under development Thanks, Dmytro Sen

Re: Review Request 58228: Perf: Refactor ambari db-cleanup to include all big tables

2017-04-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58228/#review171729 --- Ship it! Ship It! - Dmytro Sen On Апрель 12, 2017, 1:14 д.п

Re: Review Request 58240: 'ambari-server upgrade' command does not change owner for all dirs

2017-04-07 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58240/#review171315 --- Ship it! Ship It! - Dmytro Sen On Апрель 6, 2017, 6:10 п.п

Re: Review Request 57847: Ambari-server CLI to setup Database Options Broken

2017-03-28 Thread Dmytro Sen
57847/diff/1-2/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 57902: AMBARI-20553 : Ambari script error for ams-hbase while writing to Amazon s3 on a cluster with no HDFS.

2017-03-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57902/#review170264 --- Ship it! Ship It! - Dmytro Sen On None, Aravindan Vijayan

Review Request 57962: In case of HA-enabled cluster on shutting down Active Master, Ambari rest api call and HBase quick links show two Active Masters

2017-03-27 Thread Dmytro Sen
"(Active)" for couple of hostnames. If not, please refresh and verify. Click the rest api call and verify that two masters have IsActiveMaster value as true Diffs - ambari-server/src/main/java/org/apache/ambari/server/state/services/MetricsRetrievalService.java 79e0e25 ambari-server/src/test/java/org/apache/ambari/server/state/services/MetricsRetrievalServiceTest.java 784ba92 Diff: https://reviews.apache.org/r/57962/diff/1/ Testing --- Manual tests + unit tests Thanks, Dmytro Sen

Re: Review Request 57878: HDP 3.0 support for Hive with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-03-24 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57878/#review170004 --- Ship it! Ship It! - Dmytro Sen On Март 24, 2017, 12:32 п.п

Re: Review Request 57878: HDP 3.0 support for Hive with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-03-24 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57878/#review169989 --- Ship it! Ship It! - Dmytro Sen On Март 23, 2017, 3:28 п.п

Review Request 57847: Ambari-server CLI to setup Database Options Broken

2017-03-22 Thread Dmytro Sen
ain/python/ambari-server.py c985d65 Diff: https://reviews.apache.org/r/57847/diff/1/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Dmytro Sen
) - ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 555cf4d Diff: https://reviews.apache.org/r/57810/diff/3/ Changes: https://reviews.apache.org/r/57810/diff/2-3/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Dmytro Sen
) - ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 555cf4d Diff: https://reviews.apache.org/r/57810/diff/2/ Changes: https://reviews.apache.org/r/57810/diff/1-2/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 57810: Stack Advisor reported an error: KeyError: 'nimbus.authorizer' during Test Kerberos Client command

2017-03-21 Thread Dmytro Sen
/2.5/services/stack_advisor.py 555cf4d Diff: https://reviews.apache.org/r/57810/diff/1/ Testing --- Unit tests passed Thanks, Dmytro Sen

Re: Review Request 57782: Ambari-agent log rotation is broken

2017-03-20 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57782/#review169458 --- Ship it! Ship It! - Dmytro Sen On Март 20, 2017, 4:33 п.п

Re: Review Request 57727: HDP 3.0 TP - create Service Advisor for Spark

2017-03-17 Thread Dmytro Sen
${stack_version} Diffs - ambari-server/src/main/resources/common-services/SPARK/2.2.0/service_advisor.py PRE-CREATION Diff: https://reviews.apache.org/r/57727/diff/1/ Testing --- manual testing Thanks, Dmytro Sen

Review Request 57727: HDP 3.0 TP - create Service Advisor for Slider

2017-03-17 Thread Dmytro Sen
-CREATION Diff: https://reviews.apache.org/r/57727/diff/1/ Testing --- manual testing Thanks, Dmytro Sen

Re: Review Request 57692: HDP 3.0 support for Spark with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-03-17 Thread Dmytro Sen
0/services/SPARK/metainfo.xml PRE-CREATION Diff: https://reviews.apache.org/r/57692/diff/2/ Changes: https://reviews.apache.org/r/57692/diff/1-2/ Testing --- Unit tests passed Thanks, Dmytro Sen

Review Request 57692: HDP 3.0 support for Spark with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-03-16 Thread Dmytro Sen
r/src/main/resources/stacks/HDP/3.0/services/SPARK/metainfo.xml PRE-CREATION Diff: https://reviews.apache.org/r/57692/diff/1/ Testing --- Unit tests passed Thanks, Dmytro Sen

  1   2   3   4   5   >