Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Hayat Behlim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50884/#review145084 --- Ship it! Ship It! - Hayat Behlim On Aug. 8, 2016, 5:07 a.m

Re: Review Request 50884: AMBARI-17785: Provide support for S3 as a first class destination for log events

2016-08-08 Thread Hayat Behlim
> On Aug. 8, 2016, 10:10 a.m., Hayat Behlim wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/s3/S3Util.java, > > line 47 > > <https://reviews.apache.org/r/50884/diff/1/?file=1465944#file1465944line47> > > >

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-26 Thread Hayat Behlim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50297/#review143486 --- Ship it! Ship It! - Hayat Behlim On July 26, 2016, 5:55 a.m

Re: Review Request 50297: AMBARI-17788: Refactor spooler code in OutputHDFSFile to be reusable for OutputS3File

2016-07-25 Thread Hayat Behlim
/apache/ambari/logfeeder/output/spool/LogSpooler.java (line 126) <https://reviews.apache.org/r/50297/#comment209150> I think just for sake of understanding initializeSpoolFile() will come after handleRollover method is invoked. - Hayat Behlim On July 25, 2016, 7:17 a.m., Hemanth Ya

Re: Review Request 49519: Fix Logfeeder visibilities

2016-07-03 Thread Hayat Behlim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49519/#review140605 --- Ship it! Ship It! - Hayat Behlim On July 1, 2016, 4:46 p.m

Re: Review Request 49233: Remove superfluous Logfeeder codes

2016-06-27 Thread Hayat Behlim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49233/#review139526 --- Ship it! Ship It! - Hayat Behlim On June 25, 2016, 11:49

Re: Review Request 48903: AMBARI-17307: LogFeeder output to Solr doesn't handle empty buffer queue properly

2016-06-19 Thread Hayat Behlim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48903/#review138520 --- Ship it! Ship It! - Hayat Behlim On June 18, 2016, 6:59 a.m

Review Request 47118: Fixed Typo in logfeeder property name

2016-05-09 Thread Hayat Behlim
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties 22f3b78 Diff: https://reviews.apache.org/r/47118/diff/ Testing --- Thanks, Hayat Behlim

Review Request 46931: Updated grok lib version(0.1.1 to 0.1.4) to get latest fixes.

2016-05-03 Thread Hayat Behlim
://reviews.apache.org/r/46931/diff/ Testing --- Thanks, Hayat Behlim