Re: Review Request 64035: Workflow Manager View - FS node will overwrite internal commands and replace them with blank "move" commands when reopening the node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64035/#review191782 --- Ship it! Ship It! - Padma Priya N On Nov. 22, 2017, 5:24 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64035/ > --- > > (Updated Nov. 22, 2017, 5:24 p.m.) > > > Review request for Ambari, Gaurav Nagar, Padma Priya N, Pallav Kulshreshtha, > Prabhjyot Singh, and Rohit Choudhary. > > > Bugs: AMBARI-22502 > https://issues.apache.org/jira/browse/AMBARI-22502 > > > Repository: ambari > > > Description > --- > > Condition for importing single node have been added. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > 84a789d > > > Diff: https://reviews.apache.org/r/64035/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62119/#review184808 --- Ship it! Ship It! - Padma Priya N On Sept. 7, 2017, 10:59 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62119/ > --- > > (Updated Sept. 7, 2017, 10:59 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh. > > > Bugs: AMBARI-21890 > https://issues.apache.org/jira/browse/AMBARI-21890 > > > Repository: ambari > > > Description > --- > > A configurable limit have been imposed on the no of files being retrieved > from the server and the limit by default is set to 5000. > Search has been provided to find the file faster. > > > Diffs > - > > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java > d6e484d > contrib/views/files/src/main/resources/ui/app/components/file-search.js > b65749c > contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b > contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f > > contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs > 72ed840 > > contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs > 298d672 > contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java > f431f66 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java > 90fa483 > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62119/diff/4/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62119/#review184807 --- Ship it! Ship It! - Padma Priya N On Sept. 7, 2017, 10:59 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62119/ > --- > > (Updated Sept. 7, 2017, 10:59 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh. > > > Bugs: AMBARI-21890 > https://issues.apache.org/jira/browse/AMBARI-21890 > > > Repository: ambari > > > Description > --- > > A configurable limit have been imposed on the no of files being retrieved > from the server and the limit by default is set to 5000. > Search has been provided to find the file faster. > > > Diffs > - > > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java > d6e484d > contrib/views/files/src/main/resources/ui/app/components/file-search.js > b65749c > contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b > contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f > > contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs > 72ed840 > > contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs > 298d672 > contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java > f431f66 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java > 90fa483 > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62119/diff/4/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 62119: Ambari Files View - browser going to hung state while opening a HDFS folder which has huge number of files(>10000)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62119/#review184806 --- Ship it! Ship It! - Padma Priya N On Sept. 7, 2017, 10:59 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62119/ > --- > > (Updated Sept. 7, 2017, 10:59 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > Padma Priya N, Pallav Kulshreshtha, and Prabhjyot Singh. > > > Bugs: AMBARI-21890 > https://issues.apache.org/jira/browse/AMBARI-21890 > > > Repository: ambari > > > Description > --- > > A configurable limit have been imposed on the no of files being retrieved > from the server and the limit by default is set to 5000. > Search has been provided to find the file faster. > > > Diffs > - > > > contrib/views/commons/src/main/java/org/apache/ambari/view/commons/hdfs/FileOperationService.java > d6e484d > contrib/views/files/src/main/resources/ui/app/components/file-search.js > b65749c > contrib/views/files/src/main/resources/ui/app/controllers/files.js 8b5bb7b > contrib/views/files/src/main/resources/ui/app/routes/files.js 140732f > > contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs > 72ed840 > > contrib/views/files/src/main/resources/ui/app/templates/components/file-search.hbs > 298d672 > contrib/views/files/src/main/resources/ui/app/templates/files.hbs 63e0dd8 > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java > f431f66 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirListInfo.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/DirStatus.java > PRE-CREATION > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java > 90fa483 > > contrib/views/utils/src/test/java/org/apache/ambari/view/utils/hdfs/HdfsApiTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62119/diff/4/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 60455: Styling Issues with newly implemented workflow manager file browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60455/#review178963 --- Ship it! Ship It! - Padma Priya N On June 27, 2017, 6:47 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60455/ > --- > > (Updated June 27, 2017, 6:47 a.m.) > > > Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, Rohit Choudhary, and Supreeth Sharma. > > > Bugs: AMBARI-21338 > https://issues.apache.org/jira/browse/AMBARI-21338 > > > Repository: ambari > > > Description > --- > > Changed styles as needed. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 597e2e8 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/styles/app.css > b46fa34 > contrib/views/wfmanager/src/main/resources/ui/yarn.lock e9ad6cc > > > Diff: https://reviews.apache.org/r/60455/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 60366: Hive view 2.0-UI issues on IE11 +Win 7
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60366/#review178657 --- Ship it! Ship It! - Padma Priya N On June 22, 2017, 11:43 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60366/ > --- > > (Updated June 22, 2017, 11:43 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-21323 > https://issues.apache.org/jira/browse/AMBARI-21323 > > > Repository: ambari > > > Description > --- > > Fixed CSS for IE 11 and windows7. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 83fac86 > > > Diff: https://reviews.apache.org/r/60366/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 60112: Namenode variable should be auto populated for FS action node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60112/#review178472 --- Ship it! Ship It! - Padma Priya N On June 21, 2017, 9:32 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60112/ > --- > > (Updated June 21, 2017, 9:32 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-21252 > https://issues.apache.org/jira/browse/AMBARI-21252 > > > Repository: ambari > > > Description > --- > > This is a regression which have been fixed > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js > bf858d8 > > > Diff: https://reviews.apache.org/r/60112/diff/2/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 60114: Remove YARN client mode option from WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60114/#review178466 --- Ship it! Ship It! - Padma Priya N On June 20, 2017, 5:59 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60114/ > --- > > (Updated June 20, 2017, 5:59 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-21255 > https://issues.apache.org/jira/browse/AMBARI-21255 > > > Repository: ambari > > > Description > --- > > YARN client mode have been removed from WFD as oozie doesnt support Yarn > client mode > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 1cfe755 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > c9dc751 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 8c07d6d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/spark-action.hbs > de62e77 > contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js > bf858d8 > > > Diff: https://reviews.apache.org/r/60114/diff/2/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 60268: Convert Slider View to use yarn package manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60268/#review178465 --- Ship it! Ship It! - Padma Priya N On June 21, 2017, 8:56 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60268/ > --- > > (Updated June 21, 2017, 8:56 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-21292 > https://issues.apache.org/jira/browse/AMBARI-21292 > > > Repository: ambari > > > Description > --- > > Versions in package.json have been updated to fix the build > > > Diffs > - > > contrib/views/slider/src/main/resources/ui/package.json f9f8793 > > > Diff: https://reviews.apache.org/r/60268/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 60128: Integrate new hdfs-file browser in WFD
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60128/#review178464 --- Ship it! Ship It! - Padma Priya N On June 21, 2017, 8:47 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60128/ > --- > > (Updated June 21, 2017, 8:47 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-21264 > https://issues.apache.org/jira/browse/AMBARI-21264 > > > Repository: ambari > > > Description > --- > > The new hdfs file-browser is integrated into WFD. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js > 0194f13 > > contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js > 8636fd5 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 0603b57 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs > 5779e36 > contrib/views/wfmanager/src/main/resources/ui/app/utils/hdfsviewer.js > 080409b > contrib/views/wfmanager/src/main/resources/ui/bower.json 75ac7a7 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/components/directory-viewer.js > 65746e8 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/styles/app.css > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs > 4083ad6 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/utils/viewer-config.js > 64773c6 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/bower.json > f016904 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/index.js > dc074d7 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/package.json > 66a7b20 > contrib/views/wfmanager/src/main/resources/ui/package.json b5973c1 > > > Diff: https://reviews.apache.org/r/60128/diff/2/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 60128: Integrate new hdfs-file browser in WFD
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60128/#review178367 --- contrib/views/wfmanager/src/main/resources/ui/config/environment.js Line 31 (original), 31 (patched) <https://reviews.apache.org/r/60128/#comment252292> environment.js file need not be committed - Padma Priya N On June 15, 2017, 5:56 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60128/ > --- > > (Updated June 15, 2017, 5:56 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Pallav Kulshreshtha, > and Rohit Choudhary. > > > Bugs: AMBARI-21264 > https://issues.apache.org/jira/browse/AMBARI-21264 > > > Repository: ambari > > > Description > --- > > The new hdfs file-browser is integrated into WFD. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.css 48232f5 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs > 5779e36 > contrib/views/wfmanager/src/main/resources/ui/app/utils/hdfsviewer.js > 080409b > contrib/views/wfmanager/src/main/resources/ui/bower.json 75ac7a7 > contrib/views/wfmanager/src/main/resources/ui/config/environment.js 3e6d865 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/components/directory-viewer.js > 65746e8 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/styles/app.css > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/templates/components/directory-viewer.hbs > 4083ad6 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/utils/viewer-config.js > 64773c6 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/bower.json > f016904 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/index.js > dc074d7 > > contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/package.json > 66a7b20 > contrib/views/wfmanager/src/main/resources/ui/package.json b5973c1 > > > Diff: https://reviews.apache.org/r/60128/diff/1/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 58837: Convert all Ambari Views to use yarn package manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58837/#review173438 --- Ship it! Ship It! - Padma Priya N On April 29, 2017, 6:26 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58837/ > --- > > (Updated April 29, 2017, 6:26 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Nitiraj Rathore, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20885 > https://issues.apache.org/jira/browse/AMBARI-20885 > > > Repository: ambari > > > Description > --- > > Converted all Ambari Views to use yarn package manager with changes in > pom.xml and package.json. > > > Diffs > - > > contrib/views/capacity-scheduler/pom.xml 7a65ffb > contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock > PRE-CREATION > contrib/views/files/pom.xml 478a537 > contrib/views/files/src/main/resources/ui/package.json 3f27897 > contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/hawq/pom.xml 8089d68 > contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/hive-next/pom.xml c0eb774 > contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 623f14f > contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock > PRE-CREATION > contrib/views/hive20/pom.xml a583d23 > contrib/views/hive20/src/main/resources/ui/package.json 0453a52 > contrib/views/hive20/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/hueambarimigration/pom.xml 30e7694 > > contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json > 09c3a27 > > contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock > PRE-CREATION > contrib/views/jobs/pom.xml 062f15f > contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/pig/pom.xml d89d47e > contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION > contrib/views/wfmanager/pom.xml 86c03f9 > contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION > > > Diff: https://reviews.apache.org/r/58837/diff/2/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > venkat sairam > >
Re: Review Request 58835: Visual explain issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58835/#review173437 --- Ship it! Ship It! - Padma Priya N On April 29, 2017, 7:04 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58835/ > --- > > (Updated April 29, 2017, 7:04 a.m.) > > > Review request for Ambari, Abhishek Kumar, belliraj hb, Padma Priya N, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20883 > https://issues.apache.org/jira/browse/AMBARI-20883 > > > Repository: ambari > > > Description > --- > > Used directed arrows rather than simple lines in visual explain and Issue in > connection lines for simple queries in visual-explain in Firefox have been > fixed. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js > 4d9eff4 > > > Diff: https://reviews.apache.org/r/58835/diff/2/ > > > Testing > --- > > Manual testing have been done > > > Thanks, > > venkat sairam > >
Review Request 58785: AMBARI-20867.Cleanup Jsplumb specific code from WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58785/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, and venkat sairam. Bugs: AMBARI-20867 https://issues.apache.org/jira/browse/AMBARI-20867 Repository: ambari Description --- Removed jsplumb dependency from bower and deleted unused jsplumb related code. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 17f21ee contrib/views/wfmanager/src/main/resources/ui/app/domain/jsplumb-flow-renderer.js c3e3133 contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager1.js 0cd306a contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager2.js d82b89e contrib/views/wfmanager/src/main/resources/ui/bower.json 7e1709b Diff: https://reviews.apache.org/r/58785/diff/1/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 58784: AMBARI-20866.Distcp should take a single command rather than list of arguments to make it easier ot use.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58784/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Pallav Kulshreshtha, and venkat sairam. Bugs: AMBARI-20866 https://issues.apache.org/jira/browse/AMBARI-20866 Repository: ambari Description --- Replaces the args list with a text area where the user can type the distcp args. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/distcp-action.js e5740e3 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/distcp-action.hbs 28e67da Diff: https://reviews.apache.org/r/58784/diff/1/ Testing --- Manual Testing Thanks, Padma Priya N
Re: Review Request 58780: WFM: Clicking search icon in workflow dashboard throws error
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58780/#review173160 --- contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js Lines 193 (patched) <https://reviews.apache.org/r/58780/#comment246236> It is better to use Ember.isBlank() instead of != - Padma Priya N On April 27, 2017, 5:59 a.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58780/ > --- > > (Updated April 27, 2017, 5:59 a.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, and Sangeeta Ravindran. > > > Bugs: AMBARI-20850 > https://issues.apache.org/jira/browse/AMBARI-20850 > > > Repository: ambari > > > Description > --- > > Clicking on search icon when the filter is empty in workflow dashboard throws > the error Remote API failed as in screenshot > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 7e69dea > > > Diff: https://reviews.apache.org/r/58780/diff/1/ > > > Testing > --- > > Tested Manually > > > File Attachments > > > error > > https://reviews.apache.org/media/uploaded/files/2017/04/27/6027e0bc-d946-4d10-80b1-440486278022__wf-error.jpg > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58744: Bulk action is not functional in workflow dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58744/#review173159 --- Ship it! Ship It! - Padma Priya N On April 26, 2017, 6:19 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58744/ > --- > > (Updated April 26, 2017, 6:19 p.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20703 > https://issues.apache.org/jira/browse/AMBARI-20703 > > > Repository: ambari > > > Description > --- > > Bulk action have been commented out as it causes performance issues > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs > 4c18d5d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs > 7b5a625 > > > Diff: https://reviews.apache.org/r/58744/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58715: WFM: Date filter in workflow dashboard is not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58715/#review173021 --- Ship it! Ship It! - Padma Priya N On April 25, 2017, 10:14 p.m., Anita Jebaraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58715/ > --- > > (Updated April 25, 2017, 10:14 p.m.) > > > Review request for Ambari, belliraj hb, Di Li, DIPAYAN BHOWMICK, Padma Priya > N, Pallav Kulshreshtha, and Sangeeta Ravindran. > > > Bugs: AMBARI-20838 > https://issues.apache.org/jira/browse/AMBARI-20838 > > > Repository: ambari > > > Description > --- > > Date filter in workflow dashboard is not filtering the values according to > the date/time entered > AM/PM is not calculated for the time while filtering, So when 1.00 PM is > entered it is sent as 1.00 instead of 13.00 > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js > 96ee230 > > > Diff: https://reviews.apache.org/r/58715/diff/1/ > > > Testing > --- > > Tested manually > > > Thanks, > > Anita Jebaraj > >
Re: Review Request 58614: Project manager window is not opening for the second time
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58614/#review172901 --- Ship it! Ship It! - Padma Priya N On April 21, 2017, 12:03 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58614/ > --- > > (Updated April 21, 2017, 12:03 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and > Supreeth Sharma. > > > Bugs: AMBARI-20793 > https://issues.apache.org/jira/browse/AMBARI-20793 > > > Repository: ambari > > > Description > --- > > We have handled the kepyboard and out of clicks scenario to resolve the issue > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/drafts-wf.js > ed448d9 > > contrib/views/wfmanager/src/main/resources/ui/app/components/recent-projects.js > bbc51cc > > > Diff: https://reviews.apache.org/r/58614/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58567: Need way to explicitly ask for workflow name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58567/#review172618 --- Ship it! Ship It! - Padma Priya N On April 21, 2017, 8:35 a.m., Supreeth Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58567/ > --- > > (Updated April 21, 2017, 8:35 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and > venkat sairam. > > > Bugs: AMBARI-20729 > https://issues.apache.org/jira/browse/AMBARI-20729 > > > Repository: ambari > > > Description > --- > > Made the code change to explicitly ask for names while creating coordinator > and bundle > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 99f4fa7 > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > fba4db5 > > > Diff: https://reviews.apache.org/r/58567/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > Supreeth Sharma > >
Re: Review Request 58564: Need to change the arrangement of the action buttons in project manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58564/#review172609 --- Ship it! Ship It! - Padma Priya N On April 20, 2017, 12:01 p.m., Supreeth Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58564/ > --- > > (Updated April 20, 2017, 12:01 p.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and > venkat sairam. > > > Bugs: AMBARI-20800 > https://issues.apache.org/jira/browse/AMBARI-20800 > > > Repository: ambari > > > Description > --- > > Rearranged the Delete and Close buttons so as to keep the styling consistent. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/drafts-wf.hbs > ac28de3 > > > Diff: https://reviews.apache.org/r/58564/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > Supreeth Sharma > >
Re: Review Request 58384: Coordinator Actions(workflows) are empty even when workflows are executed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58384/#review171716 --- Ship it! Ship It! - Padma Priya N On April 12, 2017, 10:52 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58384/ > --- > > (Updated April 12, 2017, 10:52 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav > Kulshreshtha, and venkat sairam. > > > Bugs: AMBARI-20740 > https://issues.apache.org/jira/browse/AMBARI-20740 > > > Repository: ambari > > > Description > --- > > Added the api parameter(len 1000) to fetch all actions for a coordinator. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js > 3fecbaa > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3c5e720 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs > b3f1097 > > > Diff: https://reviews.apache.org/r/58384/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58341: Issue while adding custom job.properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58341/#review171549 --- Ship it! Ship It! - Padma Priya N On April 11, 2017, 10:10 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58341/ > --- > > (Updated April 11, 2017, 10:10 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20705 > https://issues.apache.org/jira/browse/AMBARI-20705 > > > Repository: ambari > > > Description > --- > > Added the custom properties if it is present even without clicking '+' > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/global-config.js > efe8385 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/global-config.hbs > e3d49ec > > > Diff: https://reviews.apache.org/r/58341/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58335: User should not be allowed to validate/Submit the workflow in case of duplicate action nodes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58335/#review171547 --- Ship it! Ship It! - Padma Priya N On April 11, 2017, 7:23 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58335/ > --- > > (Updated April 11, 2017, 7:23 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary. > > > Bugs: AMBARI-20718 > https://issues.apache.org/jira/browse/AMBARI-20718 > > > Repository: ambari > > > Description > --- > > We have added a validation check which will check the duplication of action > name. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > cccf6d0 > > > Diff: https://reviews.apache.org/r/58335/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58339: Need way to explicitly ask for workflow name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58339/#review171546 --- Ship it! Ship It! - Padma Priya N On April 11, 2017, 9:52 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58339/ > --- > > (Updated April 11, 2017, 9:52 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary. > > > Bugs: AMBARI-20729 > https://issues.apache.org/jira/browse/AMBARI-20729 > > > Repository: ambari > > > Description > --- > > We have configured the mechanism of filling the workflow name by default.We > have disabled the configuration as per the configuration. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > cccf6d0 > > > Diff: https://reviews.apache.org/r/58339/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58293: Need a way to indicate the action node type in workflow manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58293/#review171523 --- Ship it! Ship It! - Padma Priya N On April 10, 2017, 11:06 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58293/ > --- > > (Updated April 10, 2017, 11:06 a.m.) > > > Review request for Ambari, belliraj hb, Padma Priya N, and Rohit Choudhary. > > > Bugs: AMBARI-20704 > https://issues.apache.org/jira/browse/AMBARI-20704 > > > Repository: ambari > > > Description > --- > > Currently there's no way for the user to know the action node type from > workflow designer page. > We have added images for each action for easy representation. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js > 5a85573 > contrib/views/wfmanager/src/main/resources/ui/app/index.html df243ad > contrib/views/wfmanager/src/main/resources/ui/public/assets/custom.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/distcp.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/email.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/fs.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/hive.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/hive2.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/java.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/map-reduce.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/pig.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/shell.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/spark.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/sqoop.png > PRE-CREATION > contrib/views/wfmanager/src/main/resources/ui/public/assets/ssh.png > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/public/assets/sub-workflow.png > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58293/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58230: Zooming workflows should happen more smoothly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58230/#review171417 --- Ship it! Ship It! - Padma Priya N On April 6, 2017, 9:06 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58230/ > --- > > (Updated April 6, 2017, 9:06 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20689 > https://issues.apache.org/jira/browse/AMBARI-20689 > > > Repository: ambari > > > Description > --- > > Changed the zoom factor of the workflow. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > 03f0ae1 > > > Diff: https://reviews.apache.org/r/58230/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58205: Centering workflows for zoom breaks when multiple tabs exists
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58205/#review171110 --- Ship it! Ship It! - Padma Priya N On April 5, 2017, 9:38 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58205/ > --- > > (Updated April 5, 2017, 9:38 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20677 > https://issues.apache.org/jira/browse/AMBARI-20677 > > > Repository: ambari > > > Description > --- > > Made the workflow to center while switching between the tabs for the first > time > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js > 980904f > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > fa7c861 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > af84f86 > > > Diff: https://reviews.apache.org/r/58205/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58204: User should be able to visualize inherited properties while submitting the workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58204/#review171107 --- Ship it! Ship It! - Padma Priya N On April 5, 2017, 9:22 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58204/ > --- > > (Updated April 5, 2017, 9:22 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20676 > https://issues.apache.org/jira/browse/AMBARI-20676 > > > Repository: ambari > > > Description > --- > > Added the inherited properies such as resourceManager, nameNode to > job.properties while submitting the workflow. > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > 6aed9da > contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 6d94dfe > > contrib/views/wfmanager/src/main/resources/ui/app/services/workflow-manager-configs.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/workflow-manager-configs-test.js > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58204/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58170: The Zoom feature in WFM, hides the WF completely either with Maximum and Min
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58170/#review170965 --- Ship it! Ship It! - Padma Priya N On April 4, 2017, 10:11 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58170/ > --- > > (Updated April 4, 2017, 10:11 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20413 > https://issues.apache.org/jira/browse/AMBARI-20413 > > > Repository: ambari > > > Description > --- > > Removed the panning by x and made the graph to center on start node. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > bfe59e2 > > > Diff: https://reviews.apache.org/r/58170/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58168: Need to auto populate the workflow parameters if its already defined in the global space
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58168/#review170959 --- Ship it! Ship It! - Padma Priya N On April 4, 2017, 6:05 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58168/ > --- > > (Updated April 4, 2017, 6:05 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20662 > https://issues.apache.org/jira/browse/AMBARI-20662 > > > Repository: ambari > > > Description > --- > > Populated job.properties with default values if the property is defined in > workflow parameters > > > Diffs > - > > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > e9c7c15 > > > Diff: https://reviews.apache.org/r/58168/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58142: Click of "NEW JOB" button doesn't create new worksheet tab
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58142/#review170844 --- Ship it! Ship It! - Padma Priya N On April 3, 2017, 9:45 a.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58142/ > --- > > (Updated April 3, 2017, 9:45 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, > Pallav Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20658 > https://issues.apache.org/jira/browse/AMBARI-20658 > > > Repository: ambari > > > Description > --- > > We are now checking the count of worksheets present and apeending it to the > worksheet name > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js > b48b8df > > contrib/views/hive20/src/main/resources/ui/app/templates/components/top-application-bar.hbs > f163dca > > > Diff: https://reviews.apache.org/r/58142/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 58139: Coordinator and bundle should retain job.properties in submission modal window
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58139/#review170839 --- Ship it! Ship It! - Padma Priya N On April 3, 2017, 9:28 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58139/ > --- > > (Updated April 3, 2017, 9:28 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20656 > https://issues.apache.org/jira/browse/AMBARI-20656 > > > Repository: ambari > > > Description > --- > > Stored the job.properties when coordinator or bundle is submitted. Retrieving > the submitted values and showing in the modal window. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js > 7c63b47 > > contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js > e8f8cc1 > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs > 39ab06d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs > 0e35d0e > > > Diff: https://reviews.apache.org/r/58139/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58134: Bad user experience in workflow credential creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58134/#review170823 --- Ship it! Ship It! - Padma Priya N On April 3, 2017, 8:07 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58134/ > --- > > (Updated April 3, 2017, 8:07 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20653 > https://issues.apache.org/jira/browse/AMBARI-20653 > > > Repository: ambari > > > Description > --- > > Removed the save button > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-credentials.js > 1072ca4 > contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 673ae6a > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/credentials-config.hbs > 366920d > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-credentials.hbs > 464221f > > > Diff: https://reviews.apache.org/r/58134/diff/2/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Re: Review Request 58135: Workflow should retain job.properties in submission modal window
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58135/#review170822 --- Ship it! Ship It! - Padma Priya N On April 3, 2017, 7:10 a.m., Madhan Reddy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58135/ > --- > > (Updated April 3, 2017, 7:10 a.m.) > > > Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, and > Pallav Kulshreshtha. > > > Bugs: AMBARI-20654 > https://issues.apache.org/jira/browse/AMBARI-20654 > > > Repository: ambari > > > Description > --- > > Stored the job.properties on submission and retrieving the values when > reopening the modal window > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > 5f885e7 > contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js > 15c1fbf > > contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs > 0da9f71 > > > Diff: https://reviews.apache.org/r/58135/diff/1/ > > > Testing > --- > > Manual > > > Thanks, > > Madhan Reddy > >
Review Request 57678: AMBARI-20475.Issue with cut/copy functionality in workflow manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57678/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, and Pallav Kulshreshtha. Bugs: AMBARI-20475 https://issues.apache.org/jira/browse/AMBARI-20475 Repository: ambari Description --- Fixed by setting the node details in the clipboard in JSON format, so that there are no references. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/services/workflow-clipboard.js 8784cda Diff: https://reviews.apache.org/r/57678/diff/1/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 57508: AMBARI-20383.Not able to view the error log details on UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57508/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20383 https://issues.apache.org/jira/browse/AMBARI-20383 Repository: ambari Description --- Fixed by adding a extra check to check if the data nodes are not empty Diffs - contrib/views/wfmanager/src/main/resources/ui/app/validators/workflow-dag.js 18da25b Diff: https://reviews.apache.org/r/57508/diff/1/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 57497: AMBARI-20381.User is not able to import workflows, coordinators and bundles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57497/ --- Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, and Pallav Kulshreshtha. Bugs: AMBARI-20381 https://issues.apache.org/jira/browse/AMBARI-20381 Repository: ambari Description --- Fixed by removing the output stream close in the callback Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Utils.java 8f427bd Diff: https://reviews.apache.org/r/57497/diff/1/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 57374: AMBARI-20342.WFM:Performance improvement for adding node on a decision node in large workflow.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57374/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20342 https://issues.apache.org/jira/browse/AMBARI-20342 Repository: ambari Description --- The issue was happening when the source node is a placeholder node. Fixed by extracting the original source node transitions instead of finding the the source of placeholder and processing the dag from start. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 01f8fe6 contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js f8796ae contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less a424049 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs b5c3807 Diff: https://reviews.apache.org/r/57374/diff/1/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 57240: AMBARI-20268.WFM generates duplicate kill nodes in XML if decision paths have multiple transition to kill node.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57240/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20268 https://issues.apache.org/jira/browse/AMBARI-20268 Repository: ambari Description --- Fixed by storing nodes by name instead of id in the visited nodes array Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js eb8534b Diff: https://reviews.apache.org/r/57240/diff/1/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 57237: AMBARI-20266.Duplicate node error is shown if kill node transition exists from decision node in WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57237/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20266 https://issues.apache.org/jira/browse/AMBARI-20266 Repository: ambari Description --- Added to check to avoid kill tranisitions while validating Diffs - contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js 7336d6e Diff: https://reviews.apache.org/r/57237/diff/1/ Testing --- Manual testing Thanks, Padma Priya N
Review Request 57189: AMBARI-20246.Not able to preview the xml for coordinator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57189/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20246 https://issues.apache.org/jira/browse/AMBARI-20246 Repository: ambari Description --- Fixed by changing slainfo property to slaInfo Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js b5592a6 contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js be5d6f9 contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js 5101181 Diff: https://reviews.apache.org/r/57189/diff/1/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 57181: AMBARI-20206.Workflow manager is allowing to have empty action node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57181/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20206 https://issues.apache.org/jira/browse/AMBARI-20206 Repository: ambari Description --- Modified validation to check for empty action node name. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 2d326d1 contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 8aac32b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 00cb8a6 contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs d96be85 contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-data-node-name.js 86e5182 contrib/views/wfmanager/src/main/resources/ui/app/validators/duplicate-kill-node-name.js b8770c2 Diff: https://reviews.apache.org/r/57181/diff/1/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 57179: AMBARI-20131.Workflow details are lost upon refreshing the browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57179/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20131 https://issues.apache.org/jira/browse/AMBARI-20131 Repository: ambari Description --- Fixed by creating the tabs observer after tabs are initializes Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 74de3b7 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js 2e937e5 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 9fd8286 contrib/views/wfmanager/src/main/resources/ui/app/services/user-info.js 7c59f40 contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js e77ef7f Diff: https://reviews.apache.org/r/57179/diff/1/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 57028: AMBARI-20166.Workflow Manager. Nominal time should accept variables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57028/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20166 https://issues.apache.org/jira/browse/AMBARI-20166 Repository: ambari Description --- Fixed by using existing date-with-expr component for nominal time instead of date field. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js bcc209b contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 153b538 contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js 9d90280 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 2ebc259 Diff: https://reviews.apache.org/r/57028/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 57025: AMBARI-20164.Kill a workflow jumps to another tab in WFM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57025/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20164 https://issues.apache.org/jira/browse/AMBARI-20164 Repository: ambari Description --- Fixed by handling and updating the affected jobs rather than refreshing the route when bulk action is complete. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 2b40392 contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js c8df452 contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 691cc26 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs d28a497 Diff: https://reviews.apache.org/r/57025/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 57024: AMBARI-20161.Workflow Manager-mapred action contains duplicates in editor if user saves and reopens editor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57024/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20161 https://issues.apache.org/jira/browse/AMBARI-20161 Repository: ambari Description --- Fixed by removing duplicate values in the properties array. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js de72c6d contrib/views/wfmanager/src/main/resources/ui/app/components/map-red-action.js 3eb8545 Diff: https://reviews.apache.org/r/57024/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56981: AMBARI-20141.Command text lost when toggling from Command to Args on sqoop in Workflow manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56981/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-20141 https://issues.apache.org/jira/browse/AMBARI-20141 Repository: ambari Description --- Fixed by retaining both command and args and deleting the unused one on destroy of the component. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/hive-action.js ac85a9a contrib/views/wfmanager/src/main/resources/ui/app/components/hive2-action.js f23cca7 contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js 18a3702 contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js 2756700 contrib/views/wfmanager/src/main/resources/ui/app/components/ssh-action.js 8da7eef contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive-action.hbs 3d59e23 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hive2-action.hbs 8adf64c contrib/views/wfmanager/src/main/resources/ui/app/templates/components/java-action.hbs 3de5677 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs db69864 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs a29a2ec contrib/views/wfmanager/src/main/resources/ui/app/validators/arg-length.js PRE-CREATION Diff: https://reviews.apache.org/r/56981/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Re: Review Request 56915: AMBARI-20107.Action node shows unsupported properties even though there are none in workflow manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56915/ --- (Updated Feb. 22, 2017, 6:32 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20107 https://issues.apache.org/jira/browse/AMBARI-20107 Repository: ambari Description --- The issue is because the jsog object id is appended to the xml. Fixed by excluding jsog object id in the unsupported properties. Diffs (updated) - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js d09de7d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs fae2d3d Diff: https://reviews.apache.org/r/56915/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56915: AMBARI-20107.Action node shows unsupported properties even though there are none in workflow manager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56915/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20107 https://issues.apache.org/jira/browse/AMBARI-20107 Repository: ambari Description --- The issue is because the jsog object id is appended to the xml. Fixed by excluding jsog object id in the unsupported properties. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js d09de7d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs fae2d3d Diff: https://reviews.apache.org/r/56915/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56871: AMBARI-20090.On submit of bundle, if any coordinator path contains variables, user should be notified about custom variables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56871/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20090 https://issues.apache.org/jira/browse/AMBARI-20090 Repository: ambari Description --- Fixed by showing a warning message on the job submit modal if the underlying coordinator path or workflow path of bundle a contains variables. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 9201d5c contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js c7da381 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js e30750f contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 749a173 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs 2ac56e8 Diff: https://reviews.apache.org/r/56871/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56863: AMBARI-20084.Cut Node feature is broken in workflow manager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56863/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20084 https://issues.apache.org/jira/browse/AMBARI-20084 Repository: ambari Description --- The incoming transition list of the node to be cut was passed as an argument to deleteNode. Fixed by passing the list of incoming tranistions to delete node. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c1bd4be contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 6f46fdc Diff: https://reviews.apache.org/r/56863/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56849: AMBARI-20080.WFM does not issue confirmation message when workflow is suspended or killed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56849/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20080 https://issues.apache.org/jira/browse/AMBARI-20080 Repository: ambari Description --- Fixed by showing a confirmation message after the action request has successfully executed. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 1dd580e contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js b2f2a57 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs 5c15493 Diff: https://reviews.apache.org/r/56849/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56846: AMBARI-20078.When uploading a file using the WFM, need a message to say that either the file upload succeeded or failed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56846/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20078 https://issues.apache.org/jira/browse/AMBARI-20078 Repository: ambari Description --- Fixed by displaying success message when upload is complete. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js 1af9f4d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs b8da4a0 Diff: https://reviews.apache.org/r/56846/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56701: AMBARI-20019:WFM Dashboard Actions menu items not working properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56701/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20019 https://issues.apache.org/jira/browse/AMBARI-20019 Repository: ambari Description --- Added condition to disable kill for a succeeded job. Disabled kill action when the kill button is disabled. Added tooltips for all action buttons Added a loader icon when action request is in progress Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 2a5fc22 contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js e9bc44f contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 714de66 contrib/views/wfmanager/src/main/resources/ui/app/controllers/design/dashboardtab.js 9760ddb contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js 95d06fc contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3f24000 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs a4a0cc2 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs be9310e contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs eccc95d Diff: https://reviews.apache.org/r/56701/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56699: AMBARI-20007:Args value is not retained for ssh node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56699/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20007 https://issues.apache.org/jira/browse/AMBARI-20007 Repository: ambari Description --- Modified the handling of args while switching the arg ang args radio buttons. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js 9d43fe7 contrib/views/wfmanager/src/main/resources/ui/app/components/ssh-action.js d879a0c contrib/views/wfmanager/src/main/resources/ui/app/templates/components/shell-action.hbs 2cd8207 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs 64f3906 Diff: https://reviews.apache.org/r/56699/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56660: AMBARI-20005:Credentials from one workflow are getting associated across other workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56660/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20005 https://issues.apache.org/jira/browse/AMBARI-20005 Repository: ambari Description --- Fixed by clearing credentials array when creating a workflow Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 1f02426 Diff: https://reviews.apache.org/r/56660/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56648: AMBARI-20001.Workflow manager- preview workflow has xml encodings
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56648/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-20001 https://issues.apache.org/jira/browse/AMBARI-20001 Repository: ambari Description --- Replaced encoded xml strings with actual values Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js dde012d contrib/views/wfmanager/src/main/resources/ui/app/components/preview-dialog.js cd6c171 contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js a2210a6 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/preview-dialog.hbs bbf7ce1 contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js e793aac Diff: https://reviews.apache.org/r/56648/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56532: AMBARI-19954:Workflow designer is getting hung while importing the workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56532/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19954 https://issues.apache.org/jira/browse/AMBARI-19954 Repository: ambari Description --- Fixed by adding batch rendering in cytoscape and by using cytoscape APIs to find the descendent nodes rather than traversing the workflow DAG. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/decision-add-branch.js e4b2224 contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js fd7a258 contrib/views/wfmanager/src/main/resources/ui/app/components/transition-config.js ca45b1f contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js 17fb4a0 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs b9ecb11 Diff: https://reviews.apache.org/r/56532/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56437: AMBARI-19917:Error to tag is not coming for the action node upon copying
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56437/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-19917 https://issues.apache.org/jira/browse/AMBARI-19917 Repository: ambari Description --- Added a default error transition when creating a node. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 3ca20d2 Diff: https://reviews.apache.org/r/56437/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 56205: AMBARI-19842:Custom Action should be created without prompting for the action type
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56205/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-19842 https://issues.apache.org/jira/browse/AMBARI-19842 Repository: ambari Description --- Removed the prompting to provide the action type while creating a custom action. Added ability to change the custom action type in the action editor. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js ad5f3f8 contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js 43eeb5b contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js ff75e7e contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs df0a9ba contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs 0c569ec contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 1dd1c31 Diff: https://reviews.apache.org/r/56205/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 56074: AMBARI-19774:Undo Add Node feature needed for workflow designer similar to Undo Delete
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56074/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-19774 https://issues.apache.org/jira/browse/AMBARI-19774 Repository: ambari Description --- Added functionlity to undo add similiar to undo delete Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 1292832 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 2b8844e Diff: https://reviews.apache.org/r/56074/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Re: Review Request 56071: AMBARI-19766:Not able to set the sla for an action node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56071/ --- (Updated Jan. 30, 2017, 9:15 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19766 https://issues.apache.org/jira/browse/AMBARI-19766 Repository: ambari Description --- Added an if condition for not deleting the sla object of an action if the action is not a custom action. Diffs (updated) - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js f2d3ba8 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 447bac2 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs 3f0ec61 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs badf320 Diff: https://reviews.apache.org/r/56071/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 56071: AMBARI-19766:Not able to set the sla for an action node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56071/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19766 https://issues.apache.org/jira/browse/AMBARI-19766 Repository: ambari Description --- Added an if condition for not deleting the sla object of an action if the action is not a custom action. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js f2d3ba8 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 447bac2 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs 3f0ec61 Diff: https://reviews.apache.org/r/56071/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 56010: AMBARI-19709:XML generated for bundle's is not as per oozie xsd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56010/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19709 https://issues.apache.org/jira/browse/AMBARI-19709 Repository: ambari Description --- Modified the tag control to controls as per the bundle xsd Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js e29935c contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-generator.js 7dc05a9 contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js a2053c9 Diff: https://reviews.apache.org/r/56010/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 55923: AMBARI-19604:Need to perform sanity checks before starting the oozie view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55923/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19604 https://issues.apache.org/jira/browse/AMBARI-19604 Repository: ambari Description --- Added sanity checks for oozie, hdfs and user home directory Diffs - contrib/views/wfmanager/src/main/resources/ui/app/controllers/index.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 23609e9 contrib/views/wfmanager/src/main/resources/ui/app/templates/design-loading.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/index.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/loading.hbs 9f4fc79 Diff: https://reviews.apache.org/r/55923/diff/ Testing --- Manual testing Thanks, Padma Priya N
Review Request 55921: AMBARI-19610:User is not able to import the draft version for a coordinator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55921/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19610 https://issues.apache.org/jira/browse/AMBARI-19610 Repository: ambari Description --- Modified backend to support import of draft versions and added methods in front end to parse the imported draft version. Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java f7c1936 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java d029c39 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFileInfo.java 6dbf30e contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java 289e68b contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java 7ce6081 contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 2e0dadb contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js bba7793 contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js 422253d contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c682ea9 contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js c6c0421 contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js f5eb6e7 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 8b42447 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 296463d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 1758946 Diff: https://reviews.apache.org/r/55921/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 55834: AMBARI-19669:Not able to add the settings for action nodes in firefox browser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55834/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19669 https://issues.apache.org/jira/browse/AMBARI-19669 Repository: ambari Description --- Mofified the actions structure to an array. Removed the usage of Object.values method which causes the issue. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/version-settings.js 966313f contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 3c89f5c contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 8cc40d6 contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 9126819 Diff: https://reviews.apache.org/r/55834/diff/ Testing --- Manual Thanks, Padma Priya N
Re: Review Request 55718: AMBARI-19624:Missing fields for workflow SLA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55718/ --- (Updated Jan. 20, 2017, 5:55 a.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19624 https://issues.apache.org/jira/browse/AMBARI-19624 Repository: ambari Description --- Added fields to support nofification message and upstream apps in the sla componenent and added the necessary mappings to handle the new fields while generating xml and importing xml. Diffs (updated) - contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 4cc89ef contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 1929ddf contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 28bdf15 Diff: https://reviews.apache.org/r/55718/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 55718: AMBARI-19624:Missing fields for workflow SLA
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55718/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19624 https://issues.apache.org/jira/browse/AMBARI-19624 Repository: ambari Description --- Added fields to support nofification message and upstream apps in the sla componenent and added the necessary mappings to handle the new fields while generating xml and importing xml. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 1929ddf contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 28bdf15 Diff: https://reviews.apache.org/r/55718/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 55707: AMBARI-19622: Need abilities to add a custom action node and import a workflow xml with custom action
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55707/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19622 https://issues.apache.org/jira/browse/AMBARI-19622 Repository: ambari Description --- 1. Added Custom as one of the options while creating action node. 2. Made changes to the action handlers to support addition of custom action node and import of workflow with a custom action 3. Modified action editor to support edit of custom action node definition. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 8bbe831 contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js 8a3c7cf contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-actions.js 7c78eea contrib/views/wfmanager/src/main/resources/ui/app/domain/action-type-resolver.js c25b953 contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 4cc89ef contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 6bc305a contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 05bdb5a contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 95c8c3b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs b36578d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs 6d672b4 contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js e3be7da contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js fc20359 Diff: https://reviews.apache.org/r/55707/diff/ Testing --- Manual Thanks, Padma Priya N
Re: Review Request 55672: AMBARI-19607:User is not able to set the start and end date for a coordinator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55672/ --- (Updated Jan. 18, 2017, 3:15 p.m.) Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-19607 https://issues.apache.org/jira/browse/AMBARI-19607 Repository: ambari Description (updated) --- When switching between Expression and Date options in the date field, added correct date format to the date time picker. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 26b94cf contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js 541104d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs dc69382 Diff: https://reviews.apache.org/r/55672/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 55672: AMBARI-19607:User is not able to set the start and end date for a coordinator
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55672/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-19607 https://issues.apache.org/jira/browse/AMBARI-19607 Repository: ambari Description --- User is not able to set the start and end date for a coordinator. Steps to reproduce : 1) Open the coordinator. 2) Switch the start date type to expression. 3) Switch back start date type to Date. 4) Select the date using date picker. UI is throwing the error "This field must be in the format of MM/DD/ hh:mm A" Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 26b94cf contrib/views/wfmanager/src/main/resources/ui/app/components/date-with-expr.js 541104d contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs dc69382 Diff: https://reviews.apache.org/r/55672/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 55670: AMBARI-19606:Search button is not functional in the dashboard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55670/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19606 https://issues.apache.org/jira/browse/AMBARI-19606 Repository: ambari Description --- 'Search button' is not functional in the dashboard. Steps to reproduce : 1) Go to dashboard. 2) Add search filter (Job id, name etc) 3) Click on search icon. Action is not filtering the results. Instead if user directly hits enter, then result gets filtered Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js f9226f4 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs 33539ea Diff: https://reviews.apache.org/r/55670/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 55664: AMBARI-19602:Input logic tags are missing in the coordinator xml
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55664/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19602 https://issues.apache.org/jira/browse/AMBARI-19602 Repository: ambari Description --- 'Input-logic' tags are missing in the coordinator xml. Steps to reproduce : 1) Import a coordinator xml with input logic 2) Preview the xml. 3) Check that 'input-logic' tags which are available in original xml are missing in the preview xml. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js eb0d585 contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 0979c25 contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js 9b54495 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs f906fd5 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs b33420a Diff: https://reviews.apache.org/r/55664/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 55610: AMBARI-19580: Organize tabs in job details page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55610/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-19580 https://issues.apache.org/jira/browse/AMBARI-19580 Repository: ambari Description --- The tabs should be reordered in job details page in such a way that flow grap come first and static values like definition and configuration goes to the end. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs 97d4133 Diff: https://reviews.apache.org/r/55610/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 55567: AMBARI-19563:Dashboard-Show YARN RM URL in actions and flow graph and organize tabs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55567/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19563 https://issues.apache.org/jira/browse/AMBARI-19563 Repository: ambari Description --- Console Url is available which takes to RM UI. But not very intuitive. -We can add link in action column in actions row. -Also flow graph can be moved after actions column -Also in flow graph, show RM url Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 32f5ef4 contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-job-details.js 4873a31 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs 32e468f contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-action-info.hbs 8d1e09c contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 114ca37 Diff: https://reviews.apache.org/r/55567/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 55566: AMBARI-19562: Save is not present for coordinator and bundle.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55566/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19562 https://issues.apache.org/jira/browse/AMBARI-19562 Repository: ambari Description --- Save should be available for coordinator and bundle. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js c6a24b8 contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 743a163 contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 9007838 contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js d91c52a contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 0bb2fb8 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 249877b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 7ee7ecd contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 01356b2 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/save-wf.hbs 65bac42 Diff: https://reviews.apache.org/r/55566/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 55444: AMBARI-19478: Need to handle unsupported configurations gracefully in workflow actions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55444/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19478 https://issues.apache.org/jira/browse/AMBARI-19478 Repository: ambari Description --- Scenario - During import Workflow. If any of the action contains configuration that the workflow designer does not understand(eg. streaming in map-reduce), the action editor should warn the users and show a text area for manually editing the configuration The configuration should be taken into consideration while the final workflow xml is generated. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js 7390205 contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js 8ee5a0a contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 99d96ac contrib/views/wfmanager/src/main/resources/ui/app/domain/custom-mapping-handler.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js d4d8f50 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js 527badf contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js b9e4307 contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less dcf2905 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-action-editor.hbs 069c052 Diff: https://reviews.apache.org/r/55444/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 55378: AMBARI-19439:Warning message when user tries to close a designer tab.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55378/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19439 https://issues.apache.org/jira/browse/AMBARI-19439 Repository: ambari Description --- User should be warned when designer tab is closed accidentally. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js f70658e contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 3affe7c contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs 9bc46c2 Diff: https://reviews.apache.org/r/55378/diff/ Testing --- Manual Thanks, Padma Priya N
Re: Review Request 55371: AMBARI-19436: Need ability to upload a file in HDFS browser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55371/ --- (Updated Jan. 10, 2017, 12:10 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19436 https://issues.apache.org/jira/browse/AMBARI-19436 Repository: ambari Description --- Need ability to upload a file in HDFS browser. Diffs (updated) - contrib/views/wfmanager/src/main/resources/ui/app/components/file-upload.js 5ea37b5 contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js 47e7983 contrib/views/wfmanager/src/main/resources/ui/app/services/hdfs-file-uploader.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs 4f9b4ce contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/components/directory-viewer.js 991d122 contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/hdfs-file-uploader-test.js PRE-CREATION Diff: https://reviews.apache.org/r/55371/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 55371: AMBARI-19436: Need ability to upload a file in HDFS browser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55371/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19436 https://issues.apache.org/jira/browse/AMBARI-19436 Repository: ambari Description --- Need ability to upload a file in HDFS browser. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/file-upload.js 5ea37b5 contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js 47e7983 contrib/views/wfmanager/src/main/resources/ui/app/services/hdfs-file-uploader.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs 4f9b4ce contrib/views/wfmanager/src/main/resources/ui/externaladdons/hdfs-directory-viewer/addon/components/directory-viewer.js 991d122 contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/hdfs-file-uploader-test.js PRE-CREATION Diff: https://reviews.apache.org/r/55371/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 55336: AMBARI-19420: Import from local file system doesn't work if the same file is selected again.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55336/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19420 https://issues.apache.org/jira/browse/AMBARI-19420 Repository: ambari Description --- Import a workflow by using local file system. Do a reset layout. Import again the same file. No effect is seen. Expected: The file should be able to import again. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/file-picker.js PRE-CREATION Diff: https://reviews.apache.org/r/55336/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 55257: AMBARI-19398 : Namenode not resolved while submitting workflow in certain environments
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55257/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19398 https://issues.apache.org/jira/browse/AMBARI-19398 Repository: ambari Description --- Namenode is not resovled while creating configuration in job.properties while submitting workflow in certain environments. Step. if the hdfs-site does not have dfs.namenode.rpc-address property workflow submission fails. Expected. certain environments may not have dfs.namenode.rpc-address set, and in those environments workflow should be submitted without error Diffs - contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/AmbariIOUtil.java 93447b7 contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java 2779f05 contrib/views/wfmanager/src/main/resources/view.xml b8e2fcc Diff: https://reviews.apache.org/r/55257/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 55206: AMBARI-19385: Resolve variables in workflow if workflow path in coordinator contains variables.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55206/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19385 https://issues.apache.org/jira/browse/AMBARI-19385 Repository: ambari Description --- Resolve variables in workflow ,if workflow path in coordinator contains variables.. Steps: while creating coordinator use variables while configuring the workflow path. User is not prompted for the variables in workflow. Expected. the variables in workflow should be prompted for user to submit. Also need to add custom properties that the user can configure while submitting workflow/coordinator/bundle. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 122b956 contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 904901c contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 3454374 contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 8b685f0 contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js 0ebd9a7 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 5b5cd68 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs f0d9ee3 Diff: https://reviews.apache.org/r/55206/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 55167: AMBARI-19354 : Invalid message is shown after saving the workflow
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55167/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19354 https://issues.apache.org/jira/browse/AMBARI-19354 Repository: ambari Description --- Invalid message is shown after saving the workflow. The message "Transition deleted Undo" is shown even when no changes are made to the workflow. Steps to reproduce : 1) Import a workflow. 2) Click on one of the action nodes and open settings. 3) Without making any change, click on 'Save' After saving, message "Transition deleted Undo" is shown to the user. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c6264ba contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-path-util.js c921455 Diff: https://reviews.apache.org/r/55167/diff/ Testing --- Manual Thanks, Padma Priya N
Review Request 54892: AMBARI-19254 : Prompting for underlying workflow job properties in a coordinator and coordinator job properties in a bundle during job submission
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54892/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19254 https://issues.apache.org/jira/browse/AMBARI-19254 Repository: ambari Description --- The job properties of underlying workflow should be submitted when a coordinator is submitted. Similiarly, the job properties of underlying coordinators should be submitted while submitting a bundle job. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 4a8ac90 contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 15eb1ce contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 28239fa contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js 17ff9aa contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 036f529 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 8293dbe contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs 6b0ea84 contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 6e281d3 Diff: https://reviews.apache.org/r/54892/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 54809: AMBARI-19221:Preview xml feature is not functional across different tabs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54809/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, and Pallav Kulshreshtha. Bugs: AMBARI-19221 https://issues.apache.org/jira/browse/AMBARI-19221 Repository: ambari Description --- Preview xml feature is not functional across different tabs.UI hangs when user tries to view preview workflow from two different tabs. Steps to reproduce : 1) Create a workflow and check preview is happening correctly. 2) Open new tab and create another workflow 3) UI hangs when user tries to preview. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 4f409a1 contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 23d1955 contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 02682a4 contrib/views/wfmanager/src/main/resources/ui/app/components/preview-dialog.js 7e956a6 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 698535f contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs f26c2ec contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs fa3215a Diff: https://reviews.apache.org/r/54809/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Re: Review Request 54413: AMBARI-19031 : UI Enhancements, import/export assets and smart version configuration
/resources/ui/app/domain/schema-versions.js 9562ae8 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 7415544 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js 7049fde contrib/views/wfmanager/src/main/resources/ui/app/router.js 1fcd633 contrib/views/wfmanager/src/main/resources/ui/app/routes/dashboard.js 949d39a contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 5ed2619 contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 0fbbaa2 contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js d849609 contrib/views/wfmanager/src/main/resources/ui/app/services/dashboard-context.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/services/save-job.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5d1b3a3 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 27168a4 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 86a49b9 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-job-details.hbs f6b491b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-version-settings.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs a6edcec contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs 350f873 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-version-settings.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs b775302 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs c8f0f0e contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs 1922020 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/import-from-stream.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs ede8cb1 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs f17f89e contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs fdecbd9 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/preview-dialog.hbs 943c917 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs 211f720 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs 8b27496 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs 7c883af contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-icon.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 5b33c41 contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs cb0462c contrib/views/wfmanager/src/main/resources/ui/app/templates/design/dashboardtab.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/design/jobtab.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/job.hbs 0a6da66 contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js e575d20 contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 2f7df82 contrib/views/wfmanager/src/main/resources/ui/bower.json 0d897f1 contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 5f8b81c contrib/views/wfmanager/src/main/resources/ui/package.json ab9426a contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/bundle-version-settings-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/coord-version-settings-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/import-from-stream-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-icon-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/design/dashboardtab-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/dashboard-context-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/save-job-test.js PRE-CREATION Diff: https://reviews.apache.org/r/54413/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 54413: AMBARI-19031 : UI Enhancements, import/export assets and smart version configuration
/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 7415544 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js 7049fde contrib/views/wfmanager/src/main/resources/ui/app/router.js 1fcd633 contrib/views/wfmanager/src/main/resources/ui/app/routes/dashboard.js 949d39a contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 5ed2619 contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 0fbbaa2 contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js d849609 contrib/views/wfmanager/src/main/resources/ui/app/services/dashboard-context.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/services/save-job.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5d1b3a3 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 27168a4 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 86a49b9 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-job-details.hbs f6b491b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-version-settings.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs a6edcec contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs 350f873 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-version-settings.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs b775302 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs c8f0f0e contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs 1922020 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/import-from-stream.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs ede8cb1 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs 0a04d25 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs fdecbd9 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/preview-dialog.hbs 943c917 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs 211f720 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs 8b27496 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs 7c883af contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-icon.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 5b33c41 contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs cb0462c contrib/views/wfmanager/src/main/resources/ui/app/templates/design/dashboardtab.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/design/jobtab.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/job.hbs 0a6da66 contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js e575d20 contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 2f7df82 contrib/views/wfmanager/src/main/resources/ui/bower.json 0d897f1 contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 5f8b81c contrib/views/wfmanager/src/main/resources/ui/package.json ab9426a contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/bundle-version-settings-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/coord-version-settings-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/import-from-stream-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-icon-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/design/dashboardtab-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/dashboard-context-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/save-job-test.js PRE-CREATION Diff: https://reviews.apache.org/r/54413/diff/ Testing --- Manual Testing Thanks, Padma Priya N
Review Request 54247: AMBARI-19031 : UI Enhancements, import/export assets and smart version configuration
/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 7415544 contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js 7049fde contrib/views/wfmanager/src/main/resources/ui/app/router.js 1fcd633 contrib/views/wfmanager/src/main/resources/ui/app/routes/dashboard.js 949d39a contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 5ed2619 contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/routes/design/jobtab.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 0fbbaa2 contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js d849609 contrib/views/wfmanager/src/main/resources/ui/app/services/dashboard-context.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/services/save-job.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 5d1b3a3 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 27168a4 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-coord-config.hbs 86a49b9 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-job-details.hbs f6b491b contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-version-settings.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs a6edcec contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-job-details.hbs 350f873 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-version-settings.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs b775302 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs c8f0f0e contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs 1922020 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/import-from-stream.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-config.hbs ede8cb1 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs 0a04d25 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs fdecbd9 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/preview-dialog.hbs 943c917 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-create-new-bar.hbs 211f720 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs 8b27496 contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs 7c883af contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-icon.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-job-details.hbs 5b33c41 contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs cb0462c contrib/views/wfmanager/src/main/resources/ui/app/templates/design/dashboardtab.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/design/jobtab.hbs PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/app/templates/job.hbs 0a6da66 contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js e575d20 contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 2f7df82 contrib/views/wfmanager/src/main/resources/ui/bower.json 0d897f1 contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 5f8b81c contrib/views/wfmanager/src/main/resources/ui/package.json ab9426a contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/bundle-version-settings-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/coord-version-settings-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/import-from-stream-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-icon-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/design/dashboardtab-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/dashboard-context-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/save-job-test.js PRE-CREATION Diff: https://reviews.apache.org/r/54247/diff/ Testing --- Manual Testing Thanks, Padma Priya N
