Re: Review Request 57493: Ambari Metrics Grafana Datasource plugin does not work when configured with a reverse proxy with subpath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57493/#review168713 --- Ship it! Ship It! - Prajwal Rao On March 10, 2017, 2:57 a.m., Yusaku Sako wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57493/ > --- > > (Updated March 10, 2017, 2:57 a.m.) > > > Review request for Ambari, Jaimin Jetly, Prajwal Rao, Richard Zang, and Vivek > Ratnavel Subramanian. > > > Bugs: AMBARI-20391 > https://issues.apache.org/jira/browse/AMBARI-20391 > > > Repository: ambari > > > Description > --- > > See https://issues.apache.org/jira/browse/AMBARI-20391 > > https://github.com/grafana/grafana/blob/v2.6.0/public/app/core/services/backend_srv.js#L68-L70 > was adding extra subpath even though the URL already contains it. The fix > was to use the backendSrv.datasourceRequest, and not use backendSrv.get > directly. > > > Diffs > - > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 3a0fb66 > > > Diff: https://reviews.apache.org/r/57493/diff/1/ > > > Testing > --- > > Tested manually with a reverse proxy with subpath configured per > http://docs.grafana.org/installation/behind_proxy/. > There are currently no unit tests covering the data source, so no tests are > included. > > > Thanks, > > Yusaku Sako > >
Re: Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available
> On June 24, 2016, 4:54 p.m., Prajwal Rao wrote:
> > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js, lines
> > 128-133
> > <https://reviews.apache.org/r/49173/diff/1/?file=1428948#file1428948line128>
> >
> > All graphs on HBase-Users have legend hidden.
> >
> > We do need to handle this on aggregate level dashboards and graphs, and
> > I already have a separate fix for that.
>
> Jungtaek Lim wrote:
> Prajwal Rao
> I'm sorry but I don't get your feedback.
> I just would like to show alias instead of raw metric name since it could
> be too long and not beauty to show when we introduce series aggregation ('%'
> will be used to metric name). But I may miss some spots in patch since I
> understand this javascript partially.
>
> If you already have a patch to cover this issue, please let me know. I'd
> be happy to close the review. You can also close issue AMBARI-17416 as
> duplicated or take over.
Jungtaek, You can close this review. I have taken over AMBARI-17416 and will
update the JIRA accordingly.
- Prajwal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49173/#review139384
---
On June 24, 2016, 1:42 a.m., Jungtaek Lim wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49173/
> -----------
>
> (Updated June 24, 2016, 1:42 a.m.)
>
>
> Review request for Ambari, Prajwal Rao, Sriharsha Chintalapani, and Yusaku
> Sako.
>
>
> Bugs: AMBARI-17416
> https://issues.apache.org/jira/browse/AMBARI-17416
>
>
> Repository: ambari
>
>
> Description
> ---
>
> When there's no datapoint available, AMS Grafana plugin just ignores alias
> and shows metric name instead. It seems to be not consistent in point of
> view, and not good UX I think.
>
> It'd be great AMS Grafana shows alias whenever there're datapoints available
> or not.
>
>
> Diffs
> -
>
> ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 6a4f01b
>
> Diff: https://reviews.apache.org/r/49173/diff/
>
>
> Testing
> ---
>
> Tested manually. Actually this is tiny fix so we can imagine how it will make
> change.
>
>
> Thanks,
>
> Jungtaek Lim
>
>
Re: Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49173/#review139384 --- ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js (lines 100 - 105) <https://reviews.apache.org/r/49173/#comment204585> All graphs on Kafka-Topics have legend hidden. ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js (lines 128 - 133) <https://reviews.apache.org/r/49173/#comment204586> All graphs on HBase-Users have legend hidden. We do need to handle this on aggregate level dashboards and graphs, and I already have a separate fix for that. - Prajwal Rao On June 24, 2016, 1:42 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49173/ > --- > > (Updated June 24, 2016, 1:42 a.m.) > > > Review request for Ambari, Prajwal Rao, Sriharsha Chintalapani, and Yusaku > Sako. > > > Bugs: AMBARI-17416 > https://issues.apache.org/jira/browse/AMBARI-17416 > > > Repository: ambari > > > Description > --- > > When there's no datapoint available, AMS Grafana plugin just ignores alias > and shows metric name instead. It seems to be not consistent in point of > view, and not good UX I think. > > It'd be great AMS Grafana shows alias whenever there're datapoints available > or not. > > > Diffs > - > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 6a4f01b > > Diff: https://reviews.apache.org/r/49173/diff/ > > > Testing > --- > > Tested manually. Actually this is tiny fix so we can imagine how it will make > change. > > > Thanks, > > Jungtaek Lim > >
Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions
> On June 22, 2016, 6:32 a.m., Prajwal Rao wrote: > > Ship It! Datasource changes look good to me. - Prajwal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review139022 --- On June 22, 2016, 2:09 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48395/ > --- > > (Updated June 22, 2016, 2:09 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Prajwal Rao, > Sriharsha Chintalapani, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-17027 > https://issues.apache.org/jira/browse/AMBARI-17027 > > > Repository: ambari > > > Description > --- > > AMS doesn't provide tag so metric is identified by appId, metric name, > hostname, instanceId. In this situation metric name is normally consist of > origin metric name and tag values, like graphite, but unlike Graphite, AMS > also doesn't provide series aggregation functions so aggregation should be > done from caller side. > > It would be great if Ambari Metrics Collector provides series aggregation > functions, like sumSeries / > averageSeries / minSeries / maxSeries on Graphite. > > Query outputs: > https://gist.github.com/HeartSaVioR/f4f28b5b8b7bf2e5477e59d7fd56090f > > Attached Grafana screenshots to AMBARI-17027. Please refer > https://issues.apache.org/jira/browse/AMBARI-17027 for details. > > > Diffs > - > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js b825774 > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html > b034c03 > ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js 2eb3613 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > 1b2d02f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java > e37bc4d > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java > 7d49070 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/AbstractTimelineMetricsSeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/SeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionFactory.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAvgAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMaxAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMinAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesSumAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java > ee3a097 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java > cfd1f58 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java > a94f4c5 &g
Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review139022 --- Ship it! Ship It! - Prajwal Rao On June 22, 2016, 2:09 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48395/ > --- > > (Updated June 22, 2016, 2:09 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Prajwal Rao, > Sriharsha Chintalapani, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-17027 > https://issues.apache.org/jira/browse/AMBARI-17027 > > > Repository: ambari > > > Description > --- > > AMS doesn't provide tag so metric is identified by appId, metric name, > hostname, instanceId. In this situation metric name is normally consist of > origin metric name and tag values, like graphite, but unlike Graphite, AMS > also doesn't provide series aggregation functions so aggregation should be > done from caller side. > > It would be great if Ambari Metrics Collector provides series aggregation > functions, like sumSeries / > averageSeries / minSeries / maxSeries on Graphite. > > Query outputs: > https://gist.github.com/HeartSaVioR/f4f28b5b8b7bf2e5477e59d7fd56090f > > Attached Grafana screenshots to AMBARI-17027. Please refer > https://issues.apache.org/jira/browse/AMBARI-17027 for details. > > > Diffs > - > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js b825774 > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html > b034c03 > ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js 2eb3613 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > 1b2d02f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java > e37bc4d > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java > 7d49070 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/AbstractTimelineMetricsSeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/SeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionFactory.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAvgAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMaxAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMinAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesSumAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java > ee3a097 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java > cfd1f58 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java > a94f4c5 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/had
Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review138870 --- ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html (line 112) <https://reviews.apache.org/r/48395/#comment204066> Visually, I think it makes more sense to add this after "precision" as it seems to break the first row. ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js (line 39) <https://reviews.apache.org/r/48395/#comment204064> You will need to accommodate for seriesAggregator not being set at all (undefined), for example when dashboards are imported without the seriesAggregator in them, it will throw up an error. You can rememdy this by doing a function similar to $scope.trasnform. - Prajwal Rao On June 21, 2016, 3:06 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48395/ > --- > > (Updated June 21, 2016, 3:06 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Prajwal Rao, > Sriharsha Chintalapani, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-17027 > https://issues.apache.org/jira/browse/AMBARI-17027 > > > Repository: ambari > > > Description > --- > > AMS doesn't provide tag so metric is identified by appId, metric name, > hostname, instanceId. In this situation metric name is normally consist of > origin metric name and tag values, like graphite, but unlike Graphite, AMS > also doesn't provide series aggregation functions so aggregation should be > done from caller side. > > It would be great if Ambari Metrics Collector provides series aggregation > functions, like sumSeries / > averageSeries / minSeries / maxSeries on Graphite. > > Query outputs: > https://gist.github.com/HeartSaVioR/f4f28b5b8b7bf2e5477e59d7fd56090f > > Attached Grafana screenshots to AMBARI-17027. Please refer > https://issues.apache.org/jira/browse/AMBARI-17027 for details. > > > Diffs > - > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js b825774 > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html > b034c03 > ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js 2eb3613 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > 1b2d02f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java > e37bc4d > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java > 7d49070 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/AbstractTimelineMetricsSeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/SeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionFactory.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAvgAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMaxAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMinAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesSumAggregateFunction.java >
Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review137790 --- ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js (line 40) <https://reviews.apache.org/r/48395/#comment202973> There seems to be no way to disable Series Aggregation. We need to have a "none" option, and "sum" shouldn't be set as the default option. - Prajwal Rao On June 10, 2016, 12:50 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48395/ > --- > > (Updated June 10, 2016, 12:50 a.m.) > > > Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Prajwal Rao, > Sriharsha Chintalapani, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-17027 > https://issues.apache.org/jira/browse/AMBARI-17027 > > > Repository: ambari > > > Description > --- > > AMS doesn't provide tag so metric is identified by appId, metric name, > hostname, instanceId. In this situation metric name is normally consist of > origin metric name and tag values, like graphite, but unlike Graphite, AMS > also doesn't provide series aggregation functions so aggregation should be > done from caller side. > > It would be great if Ambari Metrics Collector provides series aggregation > functions, like sumSeries / > averageSeries / minSeries / maxSeries on Graphite. > > Query outputs: > https://gist.github.com/HeartSaVioR/f4f28b5b8b7bf2e5477e59d7fd56090f > > Attached Grafana screenshots to AMBARI-17027. Please refer > https://issues.apache.org/jira/browse/AMBARI-17027 for details. > > > Diffs > - > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 7390aa8 > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/partials/query.editor.html > b034c03 > ambari-metrics/ambari-metrics-grafana/ambari-metrics/queryCtrl.js 2eb3613 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > 1b2d02f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java > e37bc4d > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java > 7d49070 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/AbstractTimelineMetricsSeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/SeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAggregateFunctionFactory.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesAvgAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMaxAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesMinAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/function/TimelineMetricsSeriesSumAggregateFunction.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java > ee3a097 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java > cfd1f5
