Re: Review Request 64971: AMBARI-22252. Revert Blueprint V2 changes

2018-01-08 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64971/#review194982 --- Ship it! Ship It! - Robert Nettleton On Jan. 8, 2018, 8:59

Re: Review Request 64913: AMBARI-22718. Cannot set security.inter.broker.protocol: SASL_SSL via Blueprint with Kerberos

2018-01-03 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64913/#review194699 --- Ship it! Ship It! - Robert Nettleton On Jan. 3, 2018, 9:16

Re: Review Request 64914: AMBARI-22719. Regenerate Keytabs resets security.inter.broker.protocol to PLAINTEXTSASL

2018-01-03 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64914/#review194698 --- Ship it! Ship It! - Robert Nettleton On Jan. 3, 2018, 11:24

Re: Review Request 64853: UpgradeUserKerberosDescriptor is not executed during stack upgrade due to missing target stack data

2018-01-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64853/#review194627 --- Ship it! Ship It! - Robert Nettleton On Dec. 27, 2017, 3:58

Re: Review Request 64568: AMBARI-22638. yarn.timeline-service property enabled overriding preset secure blueprint config for the same

2017-12-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64568/#review193711 --- Ship it! Ship It! - Robert Nettleton On Dec. 13, 2017, 6:54

Re: Review Request 64513: Update the default storm log search configuration (use wildcards)

2017-12-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64513/#review193574 --- Ship it! Ship It! - Robert Nettleton On Dec. 12, 2017, 4:24

Re: Review Request 64349: LogFeeder: filter objects for wildcard input paths need to be cloned

2017-12-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64349/#review192996 --- Ship it! Ship It! - Robert Nettleton On Dec. 5, 2017, 8:50

Re: Review Request 64147: AMBARI-22539. Cannot add host with host_name in request body

2017-11-29 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64147/#review192129 --- Ship it! Ship It! - Robert Nettleton On Nov. 29, 2017, 8:38

Re: Review Request 64156: Log Search: backend should not return with 302 redirect if authentication fails

2017-11-29 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64156/#review192121 --- Ship it! Ship It! - Robert Nettleton On Nov. 29, 2017, 12

Re: Review Request 64091: Log Feeder: handle multiple '=' (split char) in key/value filter

2017-11-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64091/#review191929 --- Ship it! Ship It! - Robert Nettleton On Nov. 27, 2017, 7:38

Re: Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.

2017-11-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63955/#review191538 --- Ship it! Ship It! - Robert Nettleton On Nov. 20, 2017, 5:06

Re: Review Request 63832: Reference Log Feeder IDE/maven dev setup in README.md

2017-11-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63832/#review191065 --- Ship it! Ship It! - Robert Nettleton On Nov. 15, 2017, 11

Re: Review Request 63838: ambari-server setup should surface GPL software agreement

2017-11-15 Thread Robert Nettleton
being added. This just looks like a copy and paste error, but is probably worth fixing for the sake of clarity. - Robert Nettleton On Nov. 15, 2017, 2:34 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e

Re: Review Request 63803: Log Feeder: do not try to connect AMS, when it is disabled

2017-11-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63803/#review190990 --- Ship it! Ship It! - Robert Nettleton On Nov. 14, 2017, 6:15

Re: Review Request 63793: Log Feeder: cleanup checkpoint files periodically

2017-11-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63793/#review190965 --- Ship it! Ship It! - Robert Nettleton On Nov. 14, 2017, 1:07

Re: Review Request 63707: Simplify Ambari configuration tables from AMBARI-21307

2017-11-10 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63707/#review190746 --- Ship it! Ship It! - Robert Nettleton On Nov. 10, 2017, 11

Re: Review Request 63617: Log Feeder should be able to run locally with dockerized dev env by default

2017-11-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63617/#review190326 --- Ship it! Ship It! - Robert Nettleton On Nov. 7, 2017, 1:38

Re: Review Request 63525: Log Search server should be able to run locally with dockerized dev env by default

2017-11-03 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63525/#review190026 --- Ship it! Ship It! - Robert Nettleton On Nov. 2, 2017, 9:35

Re: Review Request 63450: Improve KDC integration

2017-11-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63450/#review189799 --- Ship it! Ship It! - Robert Nettleton On Oct. 31, 2017, 9:03

Re: Review Request 63362: Fix Log Search configuration dependencies

2017-10-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63362/#review189449 --- Ship it! Ship It! - Robert Nettleton On Oct. 27, 2017, 4:28

Re: Review Request 63360: Log Search: Add docker compose file for Solr

2017-10-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63360/#review189432 --- Ship it! Ship It! - Robert Nettleton On Oct. 27, 2017, 1:19

Re: Review Request 63265: Log Feeder: allow applying grok filter on default fields (like type, path, host etc.)

2017-10-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63265/#review189195 --- Ship it! Ship It! - Robert Nettleton On Oct. 24, 2017, 10

Re: Review Request 63298: Update Solr (Infra Solr + clients) version to 6.6.2 from 6.6.0

2017-10-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63298/#review189190 --- Ship it! Ship It! - Robert Nettleton On Oct. 25, 2017, 1:58

Re: Review Request 63196: Avoid Log Feeder NPEs for logs of services not present on the node, but present on the cluster

2017-10-23 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63196/#review188937 --- Ship it! Ship It! - Robert Nettleton On Oct. 21, 2017, 12

Re: Review Request 63167: Update Pam Authentication process to work with improved user management facility

2017-10-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63167/#review188833 --- Ship it! Ship It! - Robert Nettleton On Oct. 19, 2017, 8:40

Re: Review Request 63162: Disable xmlparser and configEdit API in Infra Solr by default

2017-10-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63162/#review188737 --- Ship it! Ship It! - Robert Nettleton On Oct. 19, 2017, 7:36

Re: Review Request 63118: Log Search server does not handle proxies properly

2017-10-18 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63118/#review188580 --- Ship it! Ship It! - Robert Nettleton On Oct. 18, 2017, 6:47

Re: Review Request 63027: Allow wildcard for log directory folder in the path component of Logfeeder input

2017-10-18 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63027/#review188495 --- Ship it! Ship It! - Robert Nettleton On Oct. 18, 2017, 9:57

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Robert Nettleton
might be un-intended consequences of changing the way these updaters are registered. - Robert Nettleton On Oct. 9, 2017, 12:43 p.m., Attila Doroszlai wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Robert Nettleton
> On Oct. 7, 2017, noon, Oliver Szabo wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > > Lines 2783 (patched) > > > > > > can these

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-03 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62757/#review187004 --- Ship it! Ship It! - Robert Nettleton On Oct. 3, 2017, 8:23

Re: Review Request 62628: Allow for backward compatibility in how identity references are specified

2017-09-28 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62628/#review186565 --- Ship it! Ship It! - Robert Nettleton On Sept. 27, 2017, 8

Re: Review Request 62618: Use symlinks for Solr Data Manager

2017-09-27 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62618/#review186411 --- Ship it! Ship It! - Robert Nettleton On Sept. 27, 2017, 2

Re: Review Request 62586: Update unit tests to test recursive variable replacements using VariableReplacementHelper

2017-09-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62586/#review186322 --- Ship it! Ship It! - Robert Nettleton On Sept. 26, 2017, 8

Re: Review Request 62584: Remove Database auto configuration from Infra Manager

2017-09-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62584/#review186321 --- Ship it! Ship It! - Robert Nettleton On Sept. 26, 2017, 6

Re: Review Request 62576: Solr Data Manager script should provide non-destructive archive download option

2017-09-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62576/#review186266 --- Ship it! Ship It! - Robert Nettleton On Sept. 26, 2017, 3

Re: Review Request 62570: Use symlinks for Infra components

2017-09-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62570/#review186262 --- Ship it! Ship It! - Robert Nettleton On Sept. 26, 2017, 1

Re: Review Request 62562: Solr Data Manager script should use gzip compression type

2017-09-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62562/#review186261 --- Ship it! Ship It! - Robert Nettleton On Sept. 26, 2017, 10

Re: Review Request 62551: Make Log Search IT work with the new UI

2017-09-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62551/#review186166 --- Ship it! Ship It! - Robert Nettleton On Sept. 25, 2017, 6

Re: Review Request 62526: Infra Solr client cleanup: make infra-solr-client script usable with symlinks

2017-09-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62526/#review186128 --- Ship it! Ship It! - Robert Nettleton On Sept. 23, 2017, 11

Re: Review Request 62530: Infra Manager: Integrate with Spring Boot

2017-09-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62530/#review186127 --- Ship it! Ship It! - Robert Nettleton On Sept. 24, 2017, 12

Re: Review Request 62543: Infra Manager jobs should handle their own configuration

2017-09-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62543/#review186123 --- Ship it! Ship It! - Robert Nettleton On Sept. 25, 2017, 12

Re: Review Request 62542: Solr Data Manager should use --line-delimited option by default

2017-09-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62542/#review186122 --- Ship it! Ship It! - Robert Nettleton On Sept. 25, 2017, 12

Re: Review Request 62460: Enable logsearch-web unit tests and make them skippable

2017-09-21 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62460/#review185889 --- Ship it! Ship It! - Robert Nettleton On Sept. 21, 2017, 10

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62412/#review185702 --- Ship it! Ship It! - Robert Nettleton On Sept. 19, 2017, 3

Re: Review Request 62356: Log Feeder should not support german month names

2017-09-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62356/#review185486 --- Ship it! Ship It! - Robert Nettleton On Sept. 15, 2017, 1

Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62331/#review185415 --- Ship it! Ship It! - Robert Nettleton On Sept. 14, 2017, 3

Re: Review Request 62224: NullPointerException during blueprint generation

2017-09-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62224/#review185099 --- Ship it! Ship It! - Robert Nettleton On Sept. 11, 2017, 5

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

2017-09-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61898/#review184889 --- Ship it! Ship It! - Robert Nettleton On Sept. 7, 2017, 8:33

Re: Review Request 62083: Fix Log Search upgrade to 3.0.0

2017-09-05 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62083/#review184569 --- Ship it! Ship It! - Robert Nettleton On Sept. 5, 2017, 3:52

Re: Review Request 62034: Integrate LogSearch new UI with the server and get rid of the old one

2017-09-05 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62034/#review184561 --- Ship it! Ship It! - Robert Nettleton On Sept. 5, 2017, 3:29

Re: Review Request 62015: Ranger should handle external Solr properly

2017-08-31 Thread Robert Nettleton
Velmurugan Periasamy, Mugdha Varadkar, Vishal Suvagia, and Gautam Borad to this review? Thanks. - Robert Nettleton On Aug. 31, 2017, 1:59 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 61996: Integrate new Log Search UI with maven

2017-08-30 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61996/#review184187 --- Ship it! Ship It! - Robert Nettleton On Aug. 30, 2017, 6:10

Re: Review Request 61993: Atlas should handle external Solr properly

2017-08-30 Thread Robert Nettleton
expertise should probably review as well. Can you please add Vishal Suvagia to this review? Thanks. - Robert Nettleton On Aug. 30, 2017, 4:04 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

2017-08-28 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61898/#review183924 --- Ship it! Ship It! - Robert Nettleton On Aug. 27, 2017, 3:41

Re: Review Request 61623: Blueprint deployments failing without version string

2017-08-14 Thread Robert Nettleton
Magyari to this review as well? Thanks. - Robert Nettleton On Aug. 14, 2017, 9:02 p.m., Nate Cole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 61461: Log Search cleanup: all configurations should be spring managed

2017-08-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61461/#review182305 --- Ship it! Ship It! - Robert Nettleton On Aug. 7, 2017, 4:03

Re: Review Request 61277: Log Search Config should be separated into a Server and Log Feeder interface

2017-08-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61277/#review181989 --- Ship it! Ship It! - Robert Nettleton On Aug. 2, 2017, 11:05

Re: Review Request 61197: Log Feeder properties should be handled by one class

2017-08-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61197/#review181987 --- Ship it! Ship It! - Robert Nettleton On Aug. 2, 2017, 11:11

Re: Review Request 61269: AMBARI-21619. More ResourceManager HA host group placeholders in blueprints

2017-08-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61269/#review181893 --- Ship it! Ship It! - Robert Nettleton On Aug. 1, 2017, 7:04

Re: Review Request 60943: Log Search Solr output properties should be provided by the Config API

2017-07-26 Thread Robert Nettleton
, and then have implementations that are specific to the Logfeeder or the LogSearch Server? - Robert Nettleton On July 20, 2017, 9:54 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 60966: Log Search docker test environment build front/backend only

2017-07-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60966/#review180923 --- Ship it! Ship It! - Robert Nettleton On July 19, 2017, 12

Re: Review Request 60866: AMBARI-21477: Remove Falcon proxy entries from Knox kerberos.json

2017-07-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60866/#review180557 --- Ship it! Ship It! - Robert Nettleton On July 14, 2017, 1:34

Re: Review Request 60813: Add lucene index migration script to infra solr client package

2017-07-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60813/#review180554 --- Ship it! Ship It! - Robert Nettleton On July 13, 2017, 10

Re: Review Request 60798: Log Feeder should support logs without date (time only)

2017-07-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60798/#review180304 --- Ship it! Ship It! - Robert Nettleton On July 12, 2017, 10

Re: Review Request 60744: Add python functions to get the Ambari version of the agent

2017-07-10 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60744/#review180041 --- Ship it! Ship It! - Robert Nettleton On July 10, 2017, 2:37

Re: Review Request 60695: Add REST end point for the documentation of the Log Feeder shipper properties

2017-07-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60695/#review179882 --- Ship it! Ship It! - Robert Nettleton On July 7, 2017, 12:30

Re: Review Request 60689: Upgrade Infra Solr version from 5.5.2 to 6.6.x

2017-07-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60689/#review179820 --- Ship it! Ship It! - Robert Nettleton On July 6, 2017, 6:41

Re: Review Request 60568: Log Feeder input config attribute "tail" should be clearer

2017-07-05 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60568/#review179640 --- Ship it! Ship It! - Robert Nettleton On June 30, 2017, 3:13

Re: Review Request 60514: Use JDK 8 maven compiler plugin for Log Search and Infra projects

2017-06-29 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60514/#review179259 --- Ship it! Ship It! - Robert Nettleton On June 28, 2017, 7:34

Re: Review Request 60501: Create property descriptions for internal Log Search configs

2017-06-28 Thread Robert Nettleton
values, as opposed to a property that lists the possible valid values. Check out the following class in ambari-server, which provides a similar markdown for config properties: org.apache.ambari.annotations.Markdown - Robert Nettleton On June 28, 2017, 3:51 p.m., Oliver Szabo

Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8

2017-06-26 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/#review178895 --- Ship it! Ship It! - Robert Nettleton On June 26, 2017, 1:46

Re: Review Request 60389: Extract Log Search part from stack advisor to a separate service advisor

2017-06-23 Thread Robert Nettleton
Alejandro to the reviewer list? Thanks. - Robert Nettleton On June 23, 2017, 1:54 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8

2017-06-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/#review178422 --- Ship it! Ship It! - Robert Nettleton On June 20, 2017, 7:46

Re: Review Request 59944: Add ability to Log Search to test a log entry if it is parseable

2017-06-20 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59944/#review178407 --- Ship it! Ship It! - Robert Nettleton On June 20, 2017, 11

Re: Review Request 60196: Fail to create solr clients in Log Search / Log Feeder with openjdk8

2017-06-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60196/#review178245 --- Ship it! Ship It! - Robert Nettleton On June 19, 2017, 11

Re: Review Request 60092: Infra Manager: Use custom serializer for execution contexts of job & steps

2017-06-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60092/#review177921 --- Ship it! Ship It! - Robert Nettleton On June 14, 2017, 4:42

Re: Review Request 60081: Improve error message for Blueprints deployment with incorrect credential type

2017-06-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60081/#review177907 --- Ship it! Ship It! - Robert Nettleton On June 14, 2017, 12

Re: Review Request 59948: AMBARI-20853. Service Advisor - Allow Service to define its Advisor Type as Python or Java

2017-06-12 Thread Robert Nettleton
/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java Line 81 (original), 82 (patched) <https://reviews.apache.org/r/59948/#comment251323> Minor issue: If this commented line is no longer needed, I'd suggest removing it. - Robert Nettleton On June 10

Re: Review Request 60007: Rename userconfig resource to event history in Log Search Portal

2017-06-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60007/#review177623 --- Ship it! Ship It! - Robert Nettleton On June 12, 2017, 3:17

Re: Review Request 59828: Ability to anonymize data during log processing

2017-06-09 Thread Robert Nettleton
in a different patch. - Robert Nettleton On June 6, 2017, 8:55 a.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 59888: Fix ambari-solr-plugin folder structure

2017-06-07 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59888/#review177226 --- Ship it! Ship It! - Robert Nettleton On June 7, 2017, 5:51

Re: Review Request 59846: Get rid deprecated jdk install in the Dockerfile of Log Search

2017-06-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59846/#review177067 --- Ship it! Ship It! - Robert Nettleton On June 6, 2017, 5:14

Re: Review Request 59689: Fix swagger sytax errors in Log Search REST API doc

2017-05-31 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59689/#review176511 --- Ship it! Ship It! - Robert Nettleton On May 31, 2017, 6:53

Re: Review Request 59683: Design Ambari Infra Component & workflows

2017-05-31 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59683/#review176485 --- Ship it! Ship It! - Robert Nettleton On May 31, 2017, 1:51

Re: Review Request 59563: Log Search REST API validate input configurations and log level filters

2017-05-25 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59563/#review176116 --- Ship it! Ship It! - Robert Nettleton On May 25, 2017, 2:21

Re: Review Request 59451: Add Log Feeder input config to HDP 3.0 hooks too

2017-05-22 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59451/#review175642 --- Ship it! Ship It! - Robert Nettleton On May 22, 2017, 3:14

Re: Review Request 59448: Infra manger: Add static data folder servlet endpoint

2017-05-22 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59448/#review175637 --- Ship it! Ship It! - Robert Nettleton On May 22, 2017, 11:59

Re: Review Request 59232: AMBARI-20984 Be able to include stack repos in blueprint

2017-05-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59232/#review175568 --- Ship it! Ship It! - Robert Nettleton On May 19, 2017, 4:36

Re: Review Request 59396: Ambari Infra Manager: add jobs/steps REST API endpoints

2017-05-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59396/#review175529 --- Ship it! Ship It! - Robert Nettleton On May 19, 2017, 12:52

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

2017-05-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59373/#review175524 --- Ship it! Ship It! - Robert Nettleton On May 18, 2017, 6:27

Re: Review Request 59308: Add docker support for infra manager

2017-05-17 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59308/#review175267 --- Ship it! Ship It! - Robert Nettleton On May 16, 2017, 12:04

Re: Review Request 59281: Integrate BlueprintService and subresources with swagger

2017-05-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59281/#review175006 --- Ship it! Ship It! - Robert Nettleton On May 15, 2017, 6:35

Re: Review Request 59271: Support rpm/deb build for ambari-infra-manager

2017-05-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59271/#review174952 --- Ship it! Ship It! - Robert Nettleton On May 15, 2017, 2:39

Re: Review Request 59266: Support external story locations in Log Search IT framework

2017-05-15 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59266/#review174949 --- Ship it! Ship It! - Robert Nettleton On May 15, 2017, 12:17

Re: Review Request 59228: Supprt boot2docker & docker-machine in Log Search integration test module

2017-05-12 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59228/#review174793 --- Ship it! Ship It! - Robert Nettleton On May 12, 2017, 1:58

Re: Review Request 59175: Ambari infra manager: add batch support

2017-05-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59175/#review174716 --- Ship it! Ship It! - Robert Nettleton On May 11, 2017, 1:30

Re: Review Request 58990: Required properties for services listed in the blueprint are validated when all the configuration is available

2017-05-09 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58990/#review174360 --- Ship it! Ship It! - Robert Nettleton On May 9, 2017, 9:38

Re: Review Request 59051: Integrate Log Search integration test framework with Selenium

2017-05-08 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59051/#review174182 --- Ship it! Ship It! - Robert Nettleton On May 8, 2017, 3:40

Re: Review Request 58822: Add Log Level Filter to the Log Search config API

2017-05-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58822/#review173495 --- Ship it! Ship It! - Robert Nettleton On April 28, 2017, 4

  1   2   3   4   >