Re: Review Request 58100: Remove configuring JDBC dependencies that are getting configured for Zeppelin interpreter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58100/#review170681 --- Ship it! Ship It! - Rohit Choudhary On March 31, 2017, 6:57 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58100/ > --- > > (Updated March 31, 2017, 6:57 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20643 > https://issues.apache.org/jira/browse/AMBARI-20643 > > > Repository: ambari > > > Description > --- > > Remove configuring JDBC dependencies that are getting configured for Zeppelin > interpreter as it causes more confusion than the resolution. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 2b21f8fe1f > > > Diff: https://reviews.apache.org/r/58100/diff/1/ > > > Testing > --- > > Manuaully tested on Ubuntu 14.04 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57916: configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well
> On March 24, 2017, 6:25 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > > Lines 176 (patched) > > <https://reviews.apache.org/r/57916/diff/1/?file=1674011#file1674011line176> > > > > Does zeppelin need the full hdfs-site or just a subset? Conventionally in Zeppelin we've copied the complete config files into the classpath. This specific requirement came from an HA scenario, and I think its okay to copy the file. - Rohit --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57916/#review170042 --- On March 24, 2017, 6:22 p.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57916/ > --- > > (Updated March 24, 2017, 6:22 p.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20564 > https://issues.apache.org/jira/browse/AMBARI-20564 > > > Repository: ambari > > > Description > --- > > configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, > core-site.xml as well > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > eb6ec01 > > > Diff: https://reviews.apache.org/r/57916/diff/1/ > > > Testing > --- > > Manually on centOS6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57916: configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, core-site.xml as well
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57916/#review170102 --- Ship it! Ship It! - Rohit Choudhary On March 24, 2017, 6:22 p.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57916/ > --- > > (Updated March 24, 2017, 6:22 p.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, Renjith Kamath, > and Sumit Mohanty. > > > Bugs: AMBARI-20564 > https://issues.apache.org/jira/browse/AMBARI-20564 > > > Repository: ambari > > > Description > --- > > configuring Zeppelin's JDBC-phoenix interpreter requires hdfs-site.xml, > core-site.xml as well > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > eb6ec01 > > > Diff: https://reviews.apache.org/r/57916/diff/1/ > > > Testing > --- > > Manually on centOS6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 57914: upgrade frontend-maven-plugin to latest >= 1.3 to make use of ignore proxy feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57914/#review170100 --- Ship it! Ship It! - Rohit Choudhary On March 24, 2017, 5:25 p.m., venkat sairam wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57914/ > --- > > (Updated March 24, 2017, 5:25 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-20549 > https://issues.apache.org/jira/browse/AMBARI-20549 > > > Repository: ambari > > > Description > --- > > We have changed the path for node modules in pom.xml and package.json > accordingly > > > Diffs > - > > contrib/views/capacity-scheduler/pom.xml f89bb8e > contrib/views/files/src/main/resources/ui/package.json d15c5c9 > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 6fe68e2 > contrib/views/hive20/src/main/resources/ui/package.json 5c0da36 > > contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json > 64b3270 > contrib/views/pig/pom.xml 7f0ade8 > > > Diff: https://reviews.apache.org/r/57914/diff/1/ > > > Testing > --- > > Manual testing done > > > Thanks, > > venkat sairam > >
Re: Review Request 57915: Zeppelin : livy2 interpreter is not getting created by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57915/#review170045 --- Ship it! Ship It! - Rohit Choudhary On March 24, 2017, 5:49 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57915/ > --- > > (Updated March 24, 2017, 5:49 p.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-20563 > https://issues.apache.org/jira/browse/AMBARI-20563 > > > Repository: ambari > > > Description > --- > > Failure due to change in livy2 config > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 575f7bc325 > > > Diff: https://reviews.apache.org/r/57915/diff/1/ > > > Testing > --- > > manually tested on centos > > > Thanks, > > Renjith Kamath > >
Re: Review Request 56589: Hive1 View in Ambari shows wrong status
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56589/#review165310 --- Ship it! Ship It! - Rohit Choudhary On Feb. 13, 2017, 7:42 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56589/ > --- > > (Updated Feb. 13, 2017, 7:42 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19980 > https://issues.apache.org/jira/browse/AMBARI-19980 > > > Repository: ambari > > > Description > --- > > Setting job status to Error if job call fail. > > > Diffs > - > > > contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/index/history-query/logs.js > 2b5fd26 > > Diff: https://reviews.apache.org/r/56589/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 56542: Hive View 2.0 - deleting a saved query is buggy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56542/#review165237 --- Ship it! Ship It! - Rohit Choudhary On Feb. 10, 2017, 12:27 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56542/ > --- > > (Updated Feb. 10, 2017, 12:27 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19958 > https://issues.apache.org/jira/browse/AMBARI-19958 > > > Repository: ambari > > > Description > --- > > Setting the controller value to reflect the changes. > > > Diffs > - > > contrib/views/hive20/src/main/resources/ui/app/adapters/saved-query.js > 5ee757b > contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js > 27d43d5 > contrib/views/hive20/src/main/resources/ui/app/controllers/saved-query.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/routes/savedqueries.js > 7b9cb09 > contrib/views/hive20/src/main/resources/ui/app/services/saved-queries.js > 29ef4b5 > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > 2d6c5aa > contrib/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs > 36dc982 > > Diff: https://reviews.apache.org/r/56542/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56572: Hive2. Visual Explain -Show additional info when you click on a box, i.e. can drill down to get more info on operators.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56572/#review165238 --- Ship it! Ship It! - Rohit Choudhary On Feb. 11, 2017, 10:26 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56572/ > --- > > (Updated Feb. 11, 2017, 10:26 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19975 > https://issues.apache.org/jira/browse/AMBARI-19975 > > > Repository: ambari > > > Description > --- > > created visual explain detail component > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain-detail.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/visual-explain.js > 6551974 > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > dcf27b4 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 1dc86d7 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain-detail.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs > 4238d43 > > Diff: https://reviews.apache.org/r/56572/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 56389: HiveView2.0 : View migration not working for new hive view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56389/#review164509 --- Ship it! Ship It! - Rohit Choudhary On Feb. 7, 2017, 2:04 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56389/ > --- > > (Updated Feb. 7, 2017, 2:04 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19894 > https://issues.apache.org/jira/browse/AMBARI-19894 > > > Repository: ambari > > > Description > --- > > Corrected class names for migration from 1.5.0 to 2.0.0 > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/DataMigrator.java > ae0a958 > contrib/views/hive20/src/main/resources/view.xml 7cbe15c > > Diff: https://reviews.apache.org/r/56389/diff/ > > > Testing > --- > > Manually Tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 56307: HiveView2.0 : Upload CSV, JSON, XML to create table feature is missing in the new view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56307/#review164343 --- Ship it! Ship It! - Rohit Choudhary On Feb. 4, 2017, 1:54 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56307/ > --- > > (Updated Feb. 4, 2017, 1:54 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19872 > https://issues.apache.org/jira/browse/AMBARI-19872 > > > Repository: ambari > > > Description > --- > > added the feature to upload file and create a table > > > Diffs > - > > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/dto/ColumnInfo.java > 44c82a0 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java > PRE-CREATION > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/jobs/JobService.java > 71cedd1 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/CSVParams.java > 355ed6a > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableDataReader.java > ee148b8 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/TableInput.java > 4f15c57 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadFromHdfsInput.java > c755c02 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/UploadService.java > 835626d > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/Parser.java > a012463 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/parsers/PreviewData.java > 50af529 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/InsertFromQueryInput.java > 027baff > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/QueryGenerator.java > dda178d > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/RowFormat.java > 4c1cb2b > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/uploads/query/TableInfo.java > bb39271 > contrib/views/hive20/src/main/resources/ui/app/adapters/file-uploader.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/adapters/upload-table.js > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/components/csv-format-params.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/radio-button.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/simple-table.js > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/components/upload-table-source.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/components/upload-table.js > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/components/validated-text-field.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/configs/helpers.js 025caa6 > contrib/views/hive20/src/main/resources/ui/app/locales/en/translations.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/models/column.js b1fa99c > contrib/views/hive20/src/main/resources/ui/app/router.js bc9bfa5 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/new.js > 6dfdf29 > > contrib/views/hive20/src/main/resources/ui/app/routes/databases/database/tables/upload-table.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 453eb12 > contrib/views/hive20/src/main/resources/ui/app/services/table-operations.js > 264e617 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/csv-format-params.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/radio-button.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/simple-table.hbs > PRE-CREATION > > contrib/views/hive20/src/main/resources/ui/app/templates/components/upload-table-source.hbs > PRE-CREATION > > contri
Re: Review Request 56015: Ambari upgrade to Ambari 2.5 causes start DB check failure on Zeppelin configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56015/#review163255 --- Ship it! Ship It! - Rohit Choudhary On Jan. 27, 2017, 12:43 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56015/ > --- > > (Updated Jan. 27, 2017, 12:43 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Prabhjyot Singh, Rohit Choudhary, Robert Levas, and Sumit Mohanty. > > > Bugs: AMBARI-19740 > https://issues.apache.org/jira/browse/AMBARI-19740 > > > Repository: ambari > > > Description > --- > > Ambari upgrade to Ambari 2.5 causes start DB check failure on Zeppelin configs > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 624e5a2 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > bbda783 > > Diff: https://reviews.apache.org/r/56015/diff/ > > > Testing > --- > > tested on centos > > > Thanks, > > Renjith Kamath > >
Re: Review Request 55914: AMBARI-19603. Issue with delete action node operation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55914/#review163232 --- Ship it! Ship It! - Rohit Choudhary On Jan. 25, 2017, 7:14 a.m., belliraj hb wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55914/ > --- > > (Updated Jan. 25, 2017, 7:14 a.m.) > > > Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav > Kulshreshtha. > > > Bugs: AMBARI-19603 > https://issues.apache.org/jira/browse/AMBARI-19603 > > > Repository: ambari > > > Description > --- > > Instead of default path in decision node we get the first non kill node > transition to fix this bug. > > > Diffs > - > > > contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js > 96426ce63f > contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js cda7609f51 > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 9040bb885e > > Diff: https://reviews.apache.org/r/55914/diff/ > > > Testing > --- > > Manual > > > Thanks, > > belliraj hb > >
Re: Review Request 55871: Error on Files view-SIMPLE authentication is not enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55871/#review162814 --- Ship it! Ship It! - Rohit Choudhary On Jan. 24, 2017, 5:47 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55871/ > --- > > (Updated Jan. 24, 2017, 5:47 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-19689 > https://issues.apache.org/jira/browse/AMBARI-19689 > > > Repository: ambari > > > Description > --- > > Setting fs.defaultfs property to webhdfs url after reading the core-site and > hdfs-site. > > > Diffs > - > > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java > d1d1bb0 > > Diff: https://reviews.apache.org/r/55871/diff/ > > > Testing > --- > > Manually tested on local vm > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 55831: Hive view loosing one row every 100 row in result set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55831/#review162609 --- Ship it! Ship It! - Rohit Choudhary On Jan. 23, 2017, 7:15 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55831/ > --- > > (Updated Jan. 23, 2017, 7:15 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-19666 > https://issues.apache.org/jira/browse/AMBARI-19666 > > > Repository: ambari > > > Description > --- > > corrected the order of boolean check to avoid fetching one more result from > resultSet when not required. > > > Diffs > - > > > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/ResultSetIterator.java > 1052bd4 > > contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/ResultSetIterator.java > 4b4a407 > > Diff: https://reviews.apache.org/r/55831/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 55758: Intermittent Zeppelin Server start failure during service install and start from Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55758/#review162410 --- Ship it! Ship It! - Rohit Choudhary On Jan. 20, 2017, 11:59 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55758/ > --- > > (Updated Jan. 20, 2017, 11:59 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN > BHOWMICK, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-19648 > https://issues.apache.org/jira/browse/AMBARI-19648 > > > Repository: ambari > > > Description > --- > > Error: > ``` > File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", > line 102, in checked_call > tries=tries, try_sleep=try_sleep, > timeout_kill_strategy=timeout_kill_strategy) > File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", > line 150, in _call_wrapper > result = _call(command, **kwargs_copy) > File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", > line 307, in _call > raise ExecutionFailed(err_msg, code, out, err) > resource_management.core.exceptions.ExecutionFailed: Execution of 'cp -f > /etc/zeppelin/conf/interpreter.json /tmp/tmpf3hCCM' returned 1. cp: cannot > stat '/etc/zeppelin/conf/interpreter.json': No such file or directory > ``` > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > ac56aa2 > > Diff: https://reviews.apache.org/r/55758/diff/ > > > Testing > --- > > Manually tested on CentOS > > > Thanks, > > Renjith Kamath > >
Re: Review Request 55402: Minor: Ownership is changed before the creation of directory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55402/#review161393 --- Ship it! Ship It! - Rohit Choudhary On Jan. 11, 2017, 4:25 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55402/ > --- > > (Updated Jan. 11, 2017, 4:25 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-19442 > https://issues.apache.org/jira/browse/AMBARI-19442 > > > Repository: ambari > > > Description > --- > > call fails when dir is not preset > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > d3d494d > > Diff: https://reviews.apache.org/r/55402/diff/ > > > Testing > --- > > manually tested on CentOS > > > Thanks, > > Renjith Kamath > >
Re: Review Request 55260: Zeppelin stop failed during EU while deleting pid file with customized service user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55260/#review161073 --- Ship it! Ship It! - Rohit Choudhary On Jan. 6, 2017, 9:45 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55260/ > --- > > (Updated Jan. 6, 2017, 9:45 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Prabhjyot Singh, Rohit Choudhary, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-19316 > https://issues.apache.org/jira/browse/AMBARI-19316 > > > Repository: ambari > > > Description > --- > > Zeppelin stop during upgrade fails due to the following permission issue > - rm: cannot remove > ‘/var/run/zeppelin/zeppelin-cstm-zeppelin-ctr-e85-1482808692054-0723-01-03.hwx.site.pid’: > Permission denied > - fix tests for trunk > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 04089ce > ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py > aea4ba8 > > Diff: https://reviews.apache.org/r/55260/diff/ > > > Testing > --- > > manually tested > > > Thanks, > > Renjith Kamath > >
Re: Review Request 55340: Hive View 2.0: Introduction of worksheets for query editor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55340/#review161044 --- Ship it! Ship It! - Rohit Choudhary On Jan. 9, 2017, 12:46 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55340/ > --- > > (Updated Jan. 9, 2017, 12:46 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-19424 > https://issues.apache.org/jira/browse/AMBARI-19424 > > > Repository: ambari > > > Description > --- > > Created worksheet model. > Created queries and query route. > > > Diffs > - > > > contrib/views/hive20/src/main/resources/ui/app/components/multiple-database-search-bar.js > 384368f > contrib/views/hive20/src/main/resources/ui/app/components/query-editor.js > f08e5a6 > contrib/views/hive20/src/main/resources/ui/app/configs/top-level-tabs.js > 6f04f0a > contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/router.js 46150f4 > contrib/views/hive20/src/main/resources/ui/app/routes/queries.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/routes/queries/index.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/routes/query.js 9e22432 > contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4d8fca4 > > contrib/views/hive20/src/main/resources/ui/app/templates/components/multiple-database-search-bar.hbs > 57001ed > > contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs > 376afe7 > contrib/views/hive20/src/main/resources/ui/app/templates/queries.hbs > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs > PRE-CREATION > contrib/views/hive20/src/main/resources/ui/app/templates/query.hbs 69fc657 > > Diff: https://reviews.apache.org/r/55340/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 55175: Hive View 2.0 : add REST endpoint for renaming a table
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55175/#review160488
---
Ship it!
Ship It!
- Rohit Choudhary
On Jan. 4, 2017, 1:03 p.m., Nitiraj Rathore wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55175/
> ---
>
> (Updated Jan. 4, 2017, 1:03 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-19362
> https://issues.apache.org/jira/browse/AMBARI-19362
>
>
> Repository: ambari
>
>
> Description
> ---
>
> added REST endpoint ("databases/{database_id}/tables/{table_id}/rename") for
> renaming a table.
>
>
> Diffs
> -
>
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java
> PRE-CREATION
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLProxy.java
> 5a2d389
>
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/resources/browser/DDLService.java
> 3d4e7d7
>
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy
> PRE-CREATION
>
> contrib/views/hive20/src/test/rest/postman/HIVE20_ENVIRONMENT.postman_environment.json
> PRE-CREATION
> contrib/views/hive20/src/test/rest/postman/hive2.postman_collection.json
> c7ce0c9
> contrib/views/hive20/src/test/rest/postman/hive20.postman_collection.json
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/55175/diff/
>
>
> Testing
> ---
>
> added test case RenameTableQueryGeneratorSpecTest
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Re: Review Request 55087: Zeppelin stop failed during EU while deleting pid file with customized service user
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55087/#review160465 --- Ship it! Ship It! - Rohit Choudhary On Dec. 29, 2016, 5:09 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55087/ > --- > > (Updated Dec. 29, 2016, 5:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-19316 > https://issues.apache.org/jira/browse/AMBARI-19316 > > > Repository: ambari > > > Description > --- > > Zeppelin stop during upgrade fails due to the following permission issue > - rm: cannot remove > ‘/var/run/zeppelin/zeppelin-cstm-zeppelin-ctr-e85-1482808692054-0723-01-03.hwx.site.pid’: > Permission denied > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 04089ce > > Diff: https://reviews.apache.org/r/55087/diff/ > > > Testing > --- > > Tested on CentOS 6 > > > Thanks, > > Renjith Kamath > >
Re: Review Request 54857: Refactor Ambari service def configurations for Zeppelin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54857/#review160354 --- Ship it! Ship It! - Rohit Choudhary On Jan. 2, 2017, 2:23 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54857/ > --- > > (Updated Jan. 2, 2017, 2:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-17470 > https://issues.apache.org/jira/browse/AMBARI-17470 > > > Repository: ambari > > > Description > --- > > - Move shiro.ini and log4j.properties out of zeppelin-env configuration. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml > 2beac97 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-log4j-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml > 9a0ba5f > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 5ee6147 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/54857/diff/ > > > Testing > --- > > Manually tested on CentOS 6.6 > > > Thanks, > > Renjith Kamath > >
Re: Review Request 55082: Change IFrame container layout for the Ambari Views from fixed to fluid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55082/#review160355 --- Ship it! Ship It! - Rohit Choudhary On Dec. 29, 2016, 12:23 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55082/ > --- > > (Updated Dec. 29, 2016, 12:23 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jaimin Jetly, Rohit Choudhary, > and Yusaku Sako. > > > Bugs: AMBARI-19315 > https://issues.apache.org/jira/browse/AMBARI-19315 > > > Repository: ambari > > > Description > --- > > - Added a css class 'contribview' in tag when user navigates to any of > the view in contrib directory. > - change the width to 'auto' if it is under contrib view. > - undoing the width changes if user leaves the contrib views so that other > views are not impacted with these changes. > > > Diffs > - > > ambari-web/app/routes/views.js 1d19279 > ambari-web/app/styles/application.less a89296c > ambari-web/app/styles/bootstrap_overrides.less b8cdf49 > > Diff: https://reviews.apache.org/r/55082/diff/ > > > Testing > --- > > manually tested. > > bruch w > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 55011: Apply changes in Ambari after ZEPPELIN-1489 in zeppelin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55011/#review160062 --- Ship it! Ship It! - Rohit Choudhary On Dec. 23, 2016, 10:10 a.m., Prabhjyot Singh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55011/ > --- > > (Updated Dec. 23, 2016, 10:10 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and > Sumit Mohanty. > > > Bugs: AMBARI-19290 > https://issues.apache.org/jira/browse/AMBARI-19290 > > > Repository: ambari > > > Description > --- > > Apply changes in Ambari after ZEPPELIN-1489 in zeppelin > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 39941f7 > > Diff: https://reviews.apache.org/r/55011/diff/ > > > Testing > --- > > Manually on CentOS 6 > > > Thanks, > > Prabhjyot Singh > >
Re: Review Request 54932: Zeppelin fails to install when hive-site.xml does not exist in spark conf directory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54932/#review159822 --- Ship it! Ship It! - Rohit Choudhary On Dec. 21, 2016, 11:05 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54932/ > --- > > (Updated Dec. 21, 2016, 11:05 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-19265 > https://issues.apache.org/jira/browse/AMBARI-19265 > > > Repository: ambari > > > Description > --- > > remove redundant configure call from install > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 0b79d37 > > Diff: https://reviews.apache.org/r/54932/diff/ > > > Testing > --- > > Manually tested on CentOS 6 > > > Thanks, > > Renjith Kamath > >
Re: Review Request 54938: Update Zeppelin version in service def to 0.6.2 instead of 0.7.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54938/#review159817 --- Ship it! Ship It! - Rohit Choudhary On Dec. 21, 2016, 3:35 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54938/ > --- > > (Updated Dec. 21, 2016, 3:35 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-19271 > https://issues.apache.org/jira/browse/AMBARI-19271 > > > Repository: ambari > > > Description > --- > > Update Zeppelin version in service def to 0.6.2 instead of 0.7.0 > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/metainfo.xml > e8ab191 > > Diff: https://reviews.apache.org/r/54938/diff/ > > > Testing > --- > > manually tested > > > Thanks, > > Renjith Kamath > >
Re: Review Request 53944: Ambari Integration for Zeppelin and Spark 2.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53944/#review156916 --- Ship it! Ship It! - Rohit Choudhary On Nov. 22, 2016, 9:20 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53944/ > --- > > (Updated Nov. 22, 2016, 9:20 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-18946 > https://issues.apache.org/jira/browse/AMBARI-18946 > > > Repository: ambari > > > Description > --- > > Initial support to Spark 1.x and 2.x config in Zeppelin > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 33a2a14 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 27ed150 > > Diff: https://reviews.apache.org/r/53944/diff/ > > > Testing > --- > > manually tested on Centos > > > Thanks, > > Renjith Kamath > >
Re: Review Request 54031: Remove Zeppelin View from Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54031/#review156915 --- Ship it! Ship It! - Rohit Choudhary On Nov. 23, 2016, 3:40 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54031/ > --- > > (Updated Nov. 23, 2016, 3:40 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Jayush Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-18975 > https://issues.apache.org/jira/browse/AMBARI-18975 > > > Repository: ambari > > > Description > --- > > details in the jira ticket > > > Diffs > - > > contrib/views/pom.xml ca5aef4 > contrib/views/zeppelin/pom.xml 6a7f585 > > contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java > 8f94260 > > contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java > ab61a3d > contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 6b2d156 > contrib/views/zeppelin/src/main/resources/view.log4j.properties 15d264e > contrib/views/zeppelin/src/main/resources/view.xml 323e09a > > Diff: https://reviews.apache.org/r/54031/diff/ > > > Testing > --- > > manually tested > > > Thanks, > > Renjith Kamath > >
Re: Review Request 51282: Zeppelin service check fails after enabling SSL for Zeppelin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51282/#review146304 --- Ship it! Ship It! - Rohit Choudhary On Aug. 22, 2016, 6:54 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51282/ > --- > > (Updated Aug. 22, 2016, 6:54 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit > Mohanty. > > > Bugs: AMBARI-18217 > https://issues.apache.org/jira/browse/AMBARI-18217 > > > Repository: ambari > > > Description > --- > > enabled ssl in service check > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 340315f > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/service_check.py > 23e9f96 > > Diff: https://reviews.apache.org/r/51282/diff/ > > > Testing > --- > > manually tested on centos > > > Thanks, > > Renjith Kamath > >
Re: Review Request 51255: File View throws IllegalArguementException post Ambari 2.4.0.0 upgrade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51255/#review146238 --- Ship it! Ship It! - Rohit Choudhary On Aug. 20, 2016, 6:33 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51255/ > --- > > (Updated Aug. 20, 2016, 6:33 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-18218 > https://issues.apache.org/jira/browse/AMBARI-18218 > > > Repository: ambari > > > Description > --- > > Added null check before adding property. > > > Diffs > - > > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java > 1c17e6a > > Diff: https://reviews.apache.org/r/51255/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 50951: Update zeppelin shiro.ini template with ActiveDirectoryGroupRealm info
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50951/#review145350 --- Ship it! Ship It! - Rohit Choudhary On Aug. 10, 2016, 4:23 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50951/ > --- > > (Updated Aug. 10, 2016, 4:23 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Prabhjyot Singh, Rohit > Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-18101 > https://issues.apache.org/jira/browse/AMBARI-18101 > > > Repository: ambari > > > Description > --- > > - add additional sample config for Zeppelin LDAP integration > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml > ddca230 > > Diff: https://reviews.apache.org/r/50951/diff/ > > > Testing > --- > > manually tested > > > Thanks, > > Renjith Kamath > >
Re: Review Request 50864: Zeppelin to participate in RU/EU orchestration and advertise a version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50864/#review144978 --- Ship it! Ship It! - Rohit Choudhary On Aug. 5, 2016, 8:28 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50864/ > --- > > (Updated Aug. 5, 2016, 8:28 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Rohit > Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-18047 > https://issues.apache.org/jira/browse/AMBARI-18047 > > > Repository: ambari > > > Description > --- > > - add config to support RU/EU > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml > 1eb3155 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 4202c0c > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 536ffab > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml > 42c2e23 > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml > 6e45b3b > > Diff: https://reviews.apache.org/r/50864/diff/ > > > Testing > --- > > Manually tested on CentOS > > > Thanks, > > Renjith Kamath > >
Re: Review Request 50850: Pig view - Pig script creation fails
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50850/#review144929 --- Ship it! Ship It! - Rohit Choudhary On Aug. 5, 2016, 1:26 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50850/ > --- > > (Updated Aug. 5, 2016, 1:26 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, Robert Levas, and Ashwin Rajeev. > > > Bugs: AMBARI-18045 > https://issues.apache.org/jira/browse/AMBARI-18045 > > > Repository: ambari > > > Description > --- > > Added date deserializer for parsing epoch time. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/api/DateJsonDeserializer.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/GsonJsonProvider.java > 8ba9ff7 > > Diff: https://reviews.apache.org/r/50850/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 50790: Hive View History not showing old queries after upgrade.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50790/#review144808 --- Ship it! Ship It! - Rohit Choudhary On Aug. 4, 2016, 6:49 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50790/ > --- > > (Updated Aug. 4, 2016, 6:49 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-18018 > https://issues.apache.org/jira/browse/AMBARI-18018 > > > Repository: ambari > > > Description > --- > > added upgrade code to update the timestamps from seconds to miliseconds as > expected in currently. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 1081697 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > d67cdcb > > Diff: https://reviews.apache.org/r/50790/diff/ > > > Testing > --- > > manual testing of upgrade from previous version done > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 50489: Zeppelin install fails for non-root users due to wrong permissions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50489/#review143728 --- Ship it! Ship It! - Rohit Choudhary On July 27, 2016, 10:41 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50489/ > --- > > (Updated July 27, 2016, 10:41 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Prabhjyot Singh, Rohit > Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-17913 > https://issues.apache.org/jira/browse/AMBARI-17913 > > > Repository: ambari > > > Description > --- > > - fix "Permission denied: '/etc/zeppelin/conf/interpreter.json'" > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 2de99b1 > > Diff: https://reviews.apache.org/r/50489/diff/ > > > Testing > --- > > manually tested on ubuntu with non-root user > > > Thanks, > > Renjith Kamath > >
Re: Review Request 50386: Zeppelin quick link does not respect zeppelin.server.port config
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50386/#review143357 --- Ship it! Ship It! - Rohit Choudhary On July 25, 2016, 8:01 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50386/ > --- > > (Updated July 25, 2016, 8:01 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Nitiraj Rathore, Pallav Kulshreshtha, Prabhjyot Singh, Rohit > Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-17870 > https://issues.apache.org/jira/browse/AMBARI-17870 > > > Repository: ambari > > > Description > --- > > updated quicklinks.json > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/quicklinks/quicklinks.json > fcc > > Diff: https://reviews.apache.org/r/50386/diff/ > > > Testing > --- > > tested manually on CentOS > > > Thanks, > > Renjith Kamath > >
Re: Review Request 50328: Local and custom views are not working when swebhdfs and Namenode HA is enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50328/#review143193 --- Ship it! Ship It! - Rohit Choudhary On July 22, 2016, 6:55 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50328/ > --- > > (Updated July 22, 2016, 6:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17849 > https://issues.apache.org/jira/browse/AMBARI-17849 > > > Repository: ambari > > > Description > --- > > Added name node https address in view properties. > > > Diffs > - > > contrib/views/files/src/main/resources/view.xml ad5202c > contrib/views/hive-next/src/main/resources/view.xml 326062c > contrib/views/hive/src/main/resources/view.xml 58acee6 > contrib/views/pig/src/main/resources/view.xml de338da > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java > 5d0c1d3 > > Diff: https://reviews.apache.org/r/50328/diff/ > > > Testing > --- > > Manually tested Files view with Namenode failover. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 50305: Views in Ambari UI don't render when proxied by Knox - contrib views
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50305/#review143124 --- Ship it! Ship It! - Rohit Choudhary On July 21, 2016, 6:27 p.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50305/ > --- > > (Updated July 21, 2016, 6:27 p.m.) > > > Review request for Ambari, Jaimin Jetly, Ashwin Rajeev, and Yusaku Sako. > > > Bugs: AMBARI-17295 > https://issues.apache.org/jira/browse/AMBARI-17295 > > > Repository: ambari > > > Description > --- > > When using Knox's AMBARIUI service to proxy the Ambari service's UI, the > various 'views' don't render. The rest of the UI around management of > services works correctly. > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js > 5c92ac7 > contrib/views/files/src/main/resources/ui/app/adapters/application.js > a7ccbf4 > contrib/views/files/src/main/resources/ui/app/index.html 51d1839 > contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 8bbcf01 > > Diff: https://reviews.apache.org/r/50305/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 50031: Error for Pig view after upgrade to 2.4.0.0 [PersistenceException: Can't initialize data store for view PIG]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50031/#review142236 --- Ship it! Ship It! - Rohit Choudhary On July 14, 2016, 1:09 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50031/ > --- > > (Updated July 14, 2016, 1:09 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17710 > https://issues.apache.org/jira/browse/AMBARI-17710 > > > Repository: ambari > > > Description > --- > > Update SmokeTestEntity class name in viewentity table. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 67495b5 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 54f0e57 > > Diff: https://reviews.apache.org/r/50031/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 49946: Zeppelin service: add default kerberos config for shell interpreter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49946/#review141863 --- Ship it! Ship It! - Rohit Choudhary On July 12, 2016, 6:44 a.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49946/ > --- > > (Updated July 12, 2016, 6:44 a.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit > Mohanty. > > > Bugs: AMBARI-17669 > https://issues.apache.org/jira/browse/AMBARI-17669 > > > Repository: ambari > > > Description > --- > > add default kerberos config for shell interpreter > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 88ef49e > > Diff: https://reviews.apache.org/r/49946/diff/ > > > Testing > --- > > manually tested on CentOS 7.0.1 > > > Thanks, > > Renjith Kamath > >
Re: Review Request 49857: Spark Interpreter fails with "HiveException: org.apache.thrift.transport.TTransportException"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49857/#review141684 --- Ship it! Ship It! - Rohit Choudhary On July 11, 2016, 12:52 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49857/ > --- > > (Updated July 11, 2016, 12:52 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit > Mohanty. > > > Bugs: AMBARI-17639 > https://issues.apache.org/jira/browse/AMBARI-17639 > > > Repository: ambari > > > Description > --- > > - this fix creates the missing hive-site.xml in zeppelin conf > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 075219a > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 6016ae1 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh > 891fb29 > > Diff: https://reviews.apache.org/r/49857/diff/ > > > Testing > --- > > manually tested on kerberized centOS cluster > > > Thanks, > > Renjith Kamath > >
Re: Review Request 49857: Spark Interpreter fails with "HiveException: org.apache.thrift.transport.TTransportException"
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49857/#review141667 --- Ship it! Ship It! - Rohit Choudhary On July 9, 2016, 6:04 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49857/ > --- > > (Updated July 9, 2016, 6:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit > Mohanty. > > > Bugs: AMBARI-17639 > https://issues.apache.org/jira/browse/AMBARI-17639 > > > Repository: ambari > > > Description > --- > > - this fix creates the missing hive-site.xml in zeppelin conf > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 075219a > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh > 891fb29 > > Diff: https://reviews.apache.org/r/49857/diff/ > > > Testing > --- > > manually tested on kerberized centOS cluster > > > Thanks, > > Renjith Kamath > >
Re: Review Request 49859: Zeppelin service: Dependencies for phoenix in JDBC interpreter are not configured by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49859/#review141666 --- Ship it! Ship It! - Rohit Choudhary On July 9, 2016, 6:48 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49859/ > --- > > (Updated July 9, 2016, 6:48 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit > Mohanty. > > > Bugs: AMBARI-17632 > https://issues.apache.org/jira/browse/AMBARI-17632 > > > Repository: ambari > > > Description > --- > > fixed the service def script to configure default interpreter settings > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 075219a > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > 6016ae1 > > Diff: https://reviews.apache.org/r/49859/diff/ > > > Testing > --- > > manually tested on secure and unsecure centOS cluster > > > Thanks, > > Renjith Kamath > >
Re: Review Request 49858: Zeppelin service: remove principal and keytab from interpreter settings when kerberos is disabled on a secure cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49858/#review141665 --- Ship it! Ship It! - Rohit Choudhary On July 9, 2016, 6:33 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49858/ > --- > > (Updated July 9, 2016, 6:33 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit > Mohanty. > > > Bugs: AMBARI-17637 > https://issues.apache.org/jira/browse/AMBARI-17637 > > > Repository: ambari > > > Description > --- > > fixed the checks for adding keytab and principal in interepreter settings > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > 075219a > > Diff: https://reviews.apache.org/r/49858/diff/ > > > Testing > --- > > Manually tested on secure and unsecure centOS cluster. > > > Thanks, > > Renjith Kamath > >
Re: Review Request 49637: Zeppelin: service install failure on Suse due to bash error
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49637/#review141016
---
Ship it!
Ship It!
- Rohit Choudhary
On July 5, 2016, 2:14 p.m., Renjith Kamath wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49637/
> ---
>
> (Updated July 5, 2016, 2:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav
> Nagar, Pallav Kulshreshtha, Prabhjyot Singh, Rohit Choudhary, and Sumit
> Mohanty.
>
>
> Bugs: AMBARI-17558
> https://issues.apache.org/jira/browse/AMBARI-17558
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Fix the script failure on Suse with the following error due to outdated bash
> /setup_snapshot.sh: line 44: ${SETUP_VIEW,,}: bad substitution
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh
> 8612d64
>
> Diff: https://reviews.apache.org/r/49637/diff/
>
>
> Testing
> ---
>
> Manually tested
>
>
> Thanks,
>
> Renjith Kamath
>
>
Re: Review Request 49144: FilesView: Adopt front-end assets to support proxy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49144/#review139831 --- Ship it! Ship It! - Rohit Choudhary On June 23, 2016, 10:19 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49144/ > --- > > (Updated June 23, 2016, 10:19 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-17398 > https://issues.apache.org/jira/browse/AMBARI-17398 > > > Repository: ambari > > > Description > --- > > - Removed unused function getBaseFilesURLPath. > - Added fingerprint property to prevent adding hash to the minified assets. > > > Diffs > - > > contrib/views/files/src/main/resources/ui/app/mixins/file-operation.js > 6f4d070 > contrib/views/files/src/main/resources/ui/ember-cli-build.js ab684c4 > > Diff: https://reviews.apache.org/r/49144/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 48681: Ambari views logs should be more verbose and should include info/error/debug logs at appropriate places
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48681/#review138940 --- Ship it! Ship It! - Rohit Choudhary On June 14, 2016, 10:20 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48681/ > --- > > (Updated June 14, 2016, 10:20 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17214 > https://issues.apache.org/jira/browse/AMBARI-17214 > > > Repository: ambari > > > Description > --- > > Added logs at various places. > > > Diffs > - > > > contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java > 2198331 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java > 4b8a546 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FilePreviewService.java > 3585516 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/PropertyValidator.java > 2ad779c > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/backgroundjobs/BackgroundJobController.java > 2f5c76c > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalConnection.java > a86c84f > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/PropertyValidator.java > cd54690 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/files/FileService.java > 40bc9a7 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/JobService.java > 9ecbd75 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/jobs/models/PigJob.java > 6f80d6b > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/resources/scripts/ScriptService.java > 46e6247 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/JSONRequest.java > 39a595b > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/templeton/client/TempletonApi.java > 66568d7 > > Diff: https://reviews.apache.org/r/48681/diff/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 48964: Zeppelin: Kerberos configurations and latest interpreter config missing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48964/#review138686 --- Ship it! What is the sleep.time(20) for? Do we expect the kinit process to take longer and therefore this time is added? - Rohit Choudhary On June 20, 2016, 8:29 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48964/ > --- > > (Updated June 20, 2016, 8:29 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Jayush Luniya, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-17321 > https://issues.apache.org/jira/browse/AMBARI-17321 > > > Repository: ambari > > > Description > --- > > add kerberos config and new zeppelin interpreter config updates > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml > 2f5ac595 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/kerberos.json > f69ae45 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml > f609156 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > fd73464 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > e5ce9f2 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/service_check.py > 978976f > > Diff: https://reviews.apache.org/r/48964/diff/ > > > Testing > --- > > manually tested on centos > > > Thanks, > > Renjith Kamath > >
Re: Review Request 48791: All created views disappear after upgrade to 2.4.0.0 [views page]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48791/#review138194 --- Ship it! Ship It! - Rohit Choudhary On June 16, 2016, 1:07 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48791/ > --- > > (Updated June 16, 2016, 1:07 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17275 > https://issues.apache.org/jira/browse/AMBARI-17275 > > > Repository: ambari > > > Description > --- > > Changed timestamp of views jar to current time. This will ensure that the > jars are extracted after upgrade. > > > Diffs > - > > ambari-server/src/main/python/ambari_server/serverConfiguration.py b14aeed > ambari-server/src/main/python/ambari_server/serverUpgrade.py 8bd7c51 > > Diff: https://reviews.apache.org/r/48791/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 48791: All created views disappear after upgrade to 2.4.0.0 [views page]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48791/#review137976 --- Ship it! Ship It! - Rohit Choudhary On June 16, 2016, 1:07 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48791/ > --- > > (Updated June 16, 2016, 1:07 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17275 > https://issues.apache.org/jira/browse/AMBARI-17275 > > > Repository: ambari > > > Description > --- > > Changed timestamp of views jar to current time. This will ensure that the > jars are extracted after upgrade. > > > Diffs > - > > ambari-server/src/main/python/ambari_server/serverConfiguration.py b14aeed > ambari-server/src/main/python/ambari_server/serverUpgrade.py 8bd7c51 > > Diff: https://reviews.apache.org/r/48791/diff/ > > > Testing > --- > > Manually tested. > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 48792: Zeppelin: Intermittent failure while downloading example notebooks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48792/#review137975 --- Ship it! Ship It! - Rohit Choudhary On June 16, 2016, 1:09 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48792/ > --- > > (Updated June 16, 2016, 1:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-17276 > https://issues.apache.org/jira/browse/AMBARI-17276 > > > Repository: ambari > > > Description > --- > > fix error due to > > 2016-06-16 11:32:28 (145 KB/s) - “notebooks.zip” saved [855111] > warning [notebooks.zip]: 7 extra bytes at beginning or within zipfile > (attempting to process anyway) > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/setup_snapshot.sh > d81369f > > Diff: https://reviews.apache.org/r/48792/diff/ > > > Testing > --- > > tested on CentOS > > > Thanks, > > Renjith Kamath > >
Re: Review Request 48636: Zeppelin Views are not working with Custom and Remote cluster view configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48636/#review137303 --- Ship it! Ship It! - Rohit Choudhary On June 13, 2016, 1:22 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48636/ > --- > > (Updated June 13, 2016, 1:22 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Jayush Luniya, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-17191 > https://issues.apache.org/jira/browse/AMBARI-17191 > > > Repository: ambari > > > Description > --- > > Two patches attached in the jira issue > AMBARI-17191_branch-2.4_v1.patch > AMBARI-17191_trunk_v1.patch > > > - fix zeppelin view > > > Diffs > - > > > contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java > e80f884 > > contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServlet.java > f497599 > contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp 493473e > contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml 2ca5664 > contrib/views/zeppelin/src/main/resources/view.xml 3c5c5cf > > Diff: https://reviews.apache.org/r/48636/diff/ > > > Testing > --- > > Manually tested on CentOS > > > Thanks, > > Renjith Kamath > >
Re: Review Request 48122: History tab takes long to populate when there is more entry in history table.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48122/#review135825 --- Ship it! Ship It! - Rohit Choudhary On June 1, 2016, 1:53 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48122/ > --- > > (Updated June 1, 2016, 1:53 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16980 > https://issues.apache.org/jira/browse/AMBARI-16980 > > > Repository: ambari > > > Description > --- > > In this patch: > 1. the data will continue to be fetched from ATS and DB and merging etc as it > is today. > 2. filtering and sorting will continue to be on client side as it is today. > 3. (change) only fetching data based on date filter. Only when the date > filter changes the jobs will be refetched, but following points will apply. > 4. (new) To show the latest state of the jobs, we have a polling from client > side for refetching the jobs which are not in terminal state. The polling > interval is 30 secs. This will also be done everytime the "Refresh" button > (new button) is clicked. > 5. (new) if the "To Date" is today then we will also periodically fetch the > latest jobs from ATS everytime the user switches from any other tab to > history tab, or when user clicks the "Refresh" button. > 6. The initial date filter will be "last 5 days". > > > Diffs > - > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/utils/ItemNotFound.java > 3b7e51a > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java > f119ff3 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java > 34f060d > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/OperationHandleResourceManager.java > f0eecea > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParser.java > c4c85ad > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegate.java > 02091f8 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java > 471645d > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/IATSParser.java > f51b880 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/Job.java > 9afb21a > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobControllerImpl.java > f6d6ed6 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobImpl.java > 437c9ba > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobInfo.java > PRE-CREATION > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/number-range-widget.js > 5d62b59 > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/history.js > 8c4ed2f > contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js > c8bb7d0 > contrib/views/hive/src/main/resources/ui/hive-web/app/models/job.js 9079b5a > contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js > 0aa3d41 > contrib/views/hive/src/main/resources/ui/hive-web/app/services/history.js > PRE-CREATION > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/history.hbs > 052498e > contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js > 4b9899a > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/ATSParserTest.java > d8e60c4 > > contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/AggregatorTest.java > e1f7c7c > > Diff: https://reviews.apache.org/r/48122/diff/ > > > Testing > --- > > updated unit test cases. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 48032: Not able to save custom config in view config
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48032/#review135485 --- Ship it! Ship It! - Rohit Choudhary On May 30, 2016, 8:55 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48032/ > --- > > (Updated May 30, 2016, 8:55 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16948 > https://issues.apache.org/jira/browse/AMBARI-16948 > > > Repository: ambari > > > Description > --- > > Added Nullpointer check for cluster_handle field. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > bdb1087 > > Diff: https://reviews.apache.org/r/48032/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 47592: AMBARI-16772 Zeppelin restart with Ambari fails - according to Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47592/#review134550 --- Ship it! Ship It! - Rohit Choudhary On May 19, 2016, 2:06 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47592/ > --- > > (Updated May 19, 2016, 2:06 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-16772 > https://issues.apache.org/jira/browse/AMBARI-16772 > > > Repository: ambari > > > Description > --- > > - fix update_zeppelin_interpreter by removing unauthorized api call to > zeppelin > > error log in jira issue > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > d079096 > > Diff: https://reviews.apache.org/r/47592/diff/ > > > Testing > --- > > tested on centos 6.4 > > > Thanks, > > Renjith Kamath > >
Re: Review Request 47611: AMBARI-16779 Zeppelin Ambari stack does not handle log4j configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47611/#review134549 --- Ship it! Ship It! - Rohit Choudhary On May 19, 2016, 6:11 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47611/ > --- > > (Updated May 19, 2016, 6:11 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush > Luniya, Rohit Choudhary, and Sumit Mohanty. > > > Bugs: AMBARI-16779 > https://issues.apache.org/jira/browse/AMBARI-16779 > > > Repository: ambari > > > Description > --- > > Add support for editing log4j properies > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml > 268f5d6 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py > d079096 > > ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py > da260c2 > > Diff: https://reviews.apache.org/r/47611/diff/ > > > Testing > --- > > tested on centos > > > Thanks, > > Renjith Kamath > >
Re: Review Request 47721: Editing local cluster name breaks all view instances
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47721/#review134334 --- Ship it! Ship It! - Rohit Choudhary On May 23, 2016, 10:21 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47721/ > --- > > (Updated May 23, 2016, 10:21 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16812 > https://issues.apache.org/jira/browse/AMBARI-16812 > > > Repository: ambari > > > Description > --- > > Changed cluster_handle in view instance to have cluster_id instead of > cluster_name. > Made Remote cluster name editable > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js > 034b113 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js > 2b1fb3b > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js > 20eb552 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js > 0bf73d5 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js > e4826e6 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js > dfe7ba8 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html > 051d720 > > ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html > 3a69a50 > > ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html > b5890bf > > ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js > 595fcc0 > > ambari-server/src/main/java/org/apache/ambari/server/ClusterNotFoundException.java > cd338a0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java > 413dbff > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java > b8ed215 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteAmbariClusterDAO.java > 72ab368 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java > 99c9f2a > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java > 98bafdd > ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java > e660d20 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java > f78dd95 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 41f538e > > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java > 38a47a4 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java > e98a4cd > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 6d4ef82 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 31dd8f2 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3c4f1ca > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f31af16 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d1147b7 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 5a7a6a5 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 2dba3b7 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e769e5b > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java > 88b00ca > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java > 1044570 > > ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java > 9c59aab > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 20fa50f > > ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java > cea4c88 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/PropertyValidator.java > ae73bc0 > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/PropertyValidator.java > d3c9866 > > Diff: https://reviews.apache.org/r/47721/diff/ > > > Testing > --- > > Manually tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 47524: Hive view : For Upload Table, 'default' DB should be selected by default
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47524/#review134024 --- Ship it! Ship It! - Rohit Choudhary On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47524/ > --- > > (Updated May 19, 2016, 10:22 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16429 > https://issues.apache.org/jira/browse/AMBARI-16429 > > > Repository: ambari > > > Description > --- > > Earlier : first db in the list was selected or was kept empty. > > In this patch : 'default' hive db will be selected. > > > Diffs > - > > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 361de7b > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > eb95292 > > Diff: https://reviews.apache.org/r/47524/diff/ > > > Testing > --- > > Manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47525: Hive View : Upload table still shows file name after the upload is done
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47525/#review134023 --- Ship it! Ship It! - Rohit Choudhary On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47525/ > --- > > (Updated May 19, 2016, 10:22 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16726 > https://issues.apache.org/jira/browse/AMBARI-16726 > > > Repository: ambari > > > Description > --- > > Earlier : The UI does not get cleared properly after the upload. It still > shows file name. > > In this patch : the UI will no longer show the old file name if the upload is > successfull. > > > Diffs > - > > > contrib/views/hive/src/main/resources/ui/hive-web/app/components/file-upload.js > 1cd05ae > > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js > 361de7b > > contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs > eb95292 > > Diff: https://reviews.apache.org/r/47525/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review134020 --- Can we used TypedQuery instead of list and subsequent conversions? - Rohit Choudhary On May 19, 2016, 6:43 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46962/ > --- > > (Updated May 19, 2016, 6:43 p.m.) > > > Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav > Nagar, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16242 > https://issues.apache.org/jira/browse/AMBARI-16242 > > > Repository: ambari > > > Description > --- > > Earlier : > the id for dynamic entity was created in the application with the use of > instance data for that view. This data is dependent on users and created > separate sequences for each user. So the id for one user was also generated > for other user. Hence the data in db of one user was getting overriden by > other user. > > In this patch : > Now the id is generated using table_sequence techique of JPA. table for > sequence is ambari_sequence. UpgradeCatalog240.java will add the current > sequence number for existing tables and for new table the sequence name will > be added automatically. As sequence size of 50 is provided for better > performances > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 41f538e > > ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java > 0ed260d > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java > 1e8f07f > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java > f7f883b > > contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java > 7ae7721 > > Diff: https://reviews.apache.org/r/46962/diff/ > > > Testing > --- > > Following manual testing has been done. > 1. upgrade script creates correct current sequences. Done by manually > upgrading old ambari with existing views. Next job will allocate 50 more ids > 2. for new tables the entry in ambari_sequence is automatically added and the > ids will start from 1. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47467: Hive View does not work with multi-bytes characters
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47467/#review134016 --- Ship it! Ship It! - Rohit Choudhary On May 17, 2016, 3:27 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47467/ > --- > > (Updated May 17, 2016, 3:27 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16713 > https://issues.apache.org/jira/browse/AMBARI-16713 > > > Repository: ambari > > > Description > --- > > Writing bytes instead of String to stream. > > > Diffs > - > > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsUtil.java > bd01ead > > Diff: https://reviews.apache.org/r/47467/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 47537: View log files should pickup ambari-server log directory path
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47537/#review134015 --- Ship it! Ship It! - Rohit Choudhary On May 18, 2016, 3:07 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47537/ > --- > > (Updated May 18, 2016, 3:07 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16734 > https://issues.apache.org/jira/browse/AMBARI-16734 > > > Repository: ambari > > > Description > --- > > Earlier : views had to hardcode the log directory as the variable > ambari.log.dir was not available inside view.log4j.properties file. > > In this patch : view.log4j.properties of view can now use all the ambari > properties including ambari.log.dir of ambari's log4j.properties > > > Diffs > - > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 6d4ef82 > > Diff: https://reviews.apache.org/r/47537/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47459: ADLS as default FS is not supported for any views
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47459/#review133997 --- Ship it! Ship It! - Rohit Choudhary On May 17, 2016, 2:58 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47459/ > --- > > (Updated May 17, 2016, 2:58 p.m.) > > > Review request for Ambari, Chris Nauroth, DIPAYAN BHOWMICK, Nitiraj Rathore, > Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16706 > https://issues.apache.org/jira/browse/AMBARI-16706 > > > Repository: ambari > > > Description > --- > > Added adl related properties > > > Diffs > - > > contrib/views/utils/pom.xml c15afad > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/ValidatorUtils.java > c936355 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java > 8b45cd6 > > Diff: https://reviews.apache.org/r/47459/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 47305: Hive View Synchronized Around Entire Connection Creation Causing Deadlock
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47305/#review133347 --- Ship it! Ship It! - Rohit Choudhary On May 12, 2016, 2:04 p.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47305/ > --- > > (Updated May 12, 2016, 2:04 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Mahadev Konar, > Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16146 > https://issues.apache.org/jira/browse/AMBARI-16146 > > > Repository: ambari > > > Description > --- > > Earlier : The synchronized UserLocalConnection.initialValue() was taking time > to get hive connection and all other threads were blocking to get inside this > synchronized block. > > In this patch : > 1. Removed synchronized from UserLocalConnection.initialValue() and from > UserLocalHiveAuthCredentials.initialValue() > 2. Introduced locking on specific key and not the complete method. Key would > be like Connection_INSTANCE-NAME:USER-NAME. So threads for other keys will > not get into contension with this lock. This avoids blocking of thread that > do not want to initialize different keys. > 3. Used tryLock and fail with exception if lock cannot be obtained > immediately. This avoids blocking of threads that want to initialize same key > as one key should be initialized only once. > 4. corrected synchronization at several places inside UserLocal class. > > > Diffs > - > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalConnection.java > c80a4c4 > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/UserLocalHiveAuthCredentials.java > 9c72863 > > contrib/views/utils/src/main/java/org/apache/ambari/view/utils/UserLocal.java > 40c8e6e > > Diff: https://reviews.apache.org/r/47305/diff/ > > > Testing > --- > > Manual testing done by introducing Thread.sleep in > UserLocalConnection.initialValue() and creating more requests with following > combinations and logs. > 0. first thread for connection + user + view combination obtains the lock and > goes inside UserLocalConnection.initialValue() and sleeps > 1. same user, same hive view requests for connections fails to get lock with > exception. > 2. same user, different hive view -- if first request gets new lock and goes > inside UserLocalConnection.initialValue(). > 3. same user, different hive view -- if connection created once then works > fine. does not block. > 4. different user, same view -- gets new lock and goes inside > UserLocalConnection.initialValue() if first, else works fine. > 5. different user, different view -- works as 4. > 6. once the first thread come out of initialValue(), rest threads don't try > to get lock and don't fail either, works fine. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 47347: Zeppelin View has issues in opening iFrame, when zeppelin view is installed on non-gateway node
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47347/#review133107 --- Ship it! Ship It! - Rohit Choudhary On May 13, 2016, 2:22 p.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47347/ > --- > > (Updated May 13, 2016, 2:22 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-16659 > https://issues.apache.org/jira/browse/AMBARI-16659 > > > Repository: ambari > > > Description > --- > > Changed looping for getting Zeppelin host. > > > Diffs > - > > contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp 5c57343 > > Diff: https://reviews.apache.org/r/47347/diff/ > > > Testing > --- > > Manually Tested > > > Thanks, > > Gaurav Nagar > >
Re: Review Request 45866: File browser view should have some checks before starting similar to pig view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45866/#review127590 --- Ship it! Ship It! - Rohit Choudhary On April 7, 2016, 11:58 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45866/ > --- > > (Updated April 7, 2016, 11:58 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, > and Rohit Choudhary. > > > Bugs: AMBARI-15756 > https://issues.apache.org/jira/browse/AMBARI-15756 > > > Repository: ambari > > > Description > --- > > - Added REST end points for hdfsStatus > - Consuming these REST end points in front end code to check services status > on intermediate page. > - If everything passes then only we are taking to the landing page > > > Diffs > - > > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java > acaebfa > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java > 4fe1d20 > contrib/views/files/src/main/resources/ui/app/controllers/splash.js > PRE-CREATION > contrib/views/files/src/main/resources/ui/app/router.js 801e932 > contrib/views/files/src/main/resources/ui/app/routes/index.js 1032334 > contrib/views/files/src/main/resources/ui/app/routes/splash.js PRE-CREATION > contrib/views/files/src/main/resources/ui/app/templates/splash.hbs > PRE-CREATION > > Diff: https://reviews.apache.org/r/45866/diff/ > > > Testing > --- > > manually tested. > > > Thanks, > > Pallav Kulshreshtha > >
Re: Review Request 45865: Ambari Views : Reverting the changes for separation of logs in ambari branch-2.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45865/#review127588 --- Ship it! Ship It! - Rohit Choudhary On April 7, 2016, 11:20 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45865/ > --- > > (Updated April 7, 2016, 11:20 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-15753 > https://issues.apache.org/jira/browse/AMBARI-15753 > > > Repository: ambari > > > Description > --- > > To revert changes of AMBARI-14084 from branch-2.2 following changes were done. > Reverted the change in ViewRegistry.java > deleted the view.log4j.properties files from views. > deleted the changes in pom.xml for including the view.log4j.properties file > > > Diffs > - > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > a75126e > contrib/views/capacity-scheduler/pom.xml e523eb7 > contrib/views/capacity-scheduler/src/main/resources/view.log4j.properties > 10b73a5 > contrib/views/files/pom.xml c60ba9e > contrib/views/files/src/main/resources/view.log4j.properties 80f135e > contrib/views/hive/pom.xml fd6fcfe > contrib/views/hive/src/main/resources/view.log4j.properties 227d74b > contrib/views/jobs/pom.xml 045920f > contrib/views/jobs/src/main/resources/view.log4j.properties 03d193e > contrib/views/pig/pom.xml c0beeb8 > contrib/views/pig/src/main/resources/view.log4j.properties 756fd3c > contrib/views/slider/pom.xml 4188bb2 > contrib/views/slider/src/main/resources/view.log4j.properties aaed084 > contrib/views/storm/src/main/resources/view.log4j.properties 8d4f483 > contrib/views/tez/pom.xml 2daf7cc > contrib/views/tez/src/main/resources/view.log4j.properties 8608da0 > > Diff: https://reviews.apache.org/r/45865/diff/ > > > Testing > --- > > manual testing done. > > > Thanks, > > Nitiraj Rathore > >
Re: Review Request 45805: "E090 NullPointerException" when executing Hive queries with tez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45805/#review127303 --- Ship it! Ship It! - Rohit Choudhary On April 6, 2016, 7:06 a.m., Gaurav Nagar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45805/ > --- > > (Updated April 6, 2016, 7:06 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav > Kulshreshtha, and Rohit Choudhary. > > > Bugs: AMBARI-15727 > https://issues.apache.org/jira/browse/AMBARI-15727 > > > Repository: ambari > > > Description > --- > > Added null check for tezDagId.status > > > Diffs > - > > > contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java > 4eb1568 > > Diff: https://reviews.apache.org/r/45805/diff/ > > > Testing > --- > > mvn clean install > > > Thanks, > > Gaurav Nagar > >
