Re: Review Request 63450: Improve KDC integration

2017-11-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63450/#review189917 --- Ship it! Ship It! - Sebastian Toader On Oct. 31, 2017, 10

Re: Review Request 63441: Remove Slider from Ambari stack definition of HDP 3.0

2017-10-31 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63441/#review189725 --- Ship it! Ship It! - Sebastian Toader On Oct. 31, 2017, 2:35

Re: Review Request 63429: Log Search: add descriptions about how to use Log Search environment with docker compose

2017-10-31 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63429/#review189701 --- Ship it! Ship It! - Sebastian Toader On Oct. 30, 2017, 10

Re: Review Request 62930: Non-root ambari user causes Express Upgrade to fail during checking HDFS safe mode phase

2017-10-30 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62930/#review189587 --- Ship it! Ship It! - Sebastian Toader On Oct. 30, 2017, 1:39

Re: Review Request 63393: Log Search: Add docker compose file for Log Search server and Log Feeder

2017-10-30 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63393/#review189546 --- Ship it! Ship It! - Sebastian Toader On Oct. 29, 2017, 11

Re: Review Request 63361: AMBARI-22326. String formatting problems

2017-10-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63361/#review189430 --- Ship it! Ship It! - Sebastian Toader On Oct. 27, 2017, 4:04

Re: Review Request 63354: Feature for supporting LDAP configuration from the UI

2017-10-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63354/#review189414 --- Ship it! Ship It! - Sebastian Toader On Oct. 27, 2017, 12

Re: Review Request 63328: Log Search: Add docker-compose file for creating ZooKeeper containers

2017-10-27 Thread Sebastian Toader
(patched) <https://reviews.apache.org/r/63328/#comment266506> It would be useful to be able to pass in the image tags instead of hardcoded values - Sebastian Toader On Oct. 27, 2017, 11:54 a.m., Oliver Szabo

Re: Review Request 63330: Allow the same config type to belong to multiple services

2017-10-26 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63330/#review189307 --- Ship it! Ship It! - Sebastian Toader On Oct. 26, 2017, 4:42

Re: Review Request 63297: Alerts for OneFS mpack

2017-10-26 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63297/#review189284 --- Ship it! Ship It! - Sebastian Toader On Oct. 25, 2017, 4:04

Re: Review Request 63298: Update Solr (Infra Solr + clients) version to 6.6.2 from 6.6.0

2017-10-25 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63298/#review189191 --- Ship it! Ship It! - Sebastian Toader On Oct. 25, 2017, 3:58

Re: Review Request 63219: Update Kerberos Authentication process to work with improved user management facility

2017-10-23 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63219/#review188943 --- Ship it! Ship It! - Sebastian Toader On Oct. 23, 2017, 5:25

Re: Review Request 63180: Improve Kerberos principal and keytab accounting

2017-10-20 Thread Sebastian Toader
s well. - Sebastian Toader On Oct. 20, 2017, 3:25 p.m., Eugene Chekanskiy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 63167: Update Pam Authentication process to work with improved user management facility

2017-10-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63167/#review188821 --- Ship it! Ship It! - Sebastian Toader On Oct. 19, 2017, 10

Re: Review Request 63044: Update JWT Authentication process to work with improved user management facility

2017-10-17 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63044/#review188321 --- Ship it! Ship It! - Sebastian Toader On Oct. 16, 2017, 11

Re: Review Request 62982: Expression parser support for JMXServerSide alerts

2017-10-16 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62982/#review188109 --- Ship it! Ship It! - Sebastian Toader On Oct. 16, 2017, 10

Review Request 62998: In case only Hive Server Interactive is deployed with no Hive Server in the cluster the hive metastore warehouse directory is not created on DFS.

2017-10-14 Thread Sebastian Toader
] ``` Thanks, Sebastian Toader

Review Request 62948: Cluster created using Blueprints rejects hosts even though their host_name matches host predicate

2017-10-12 Thread Sebastian Toader
.. SUCCESS [24:04 min] [INFO] [INFO] BUILD SUCCESS [INFO] ---- Thanks, Sebastian Toader

Re: Review Request 62945: host and hostname built-in variables are not populated when performing Kerberos-related operations

2017-10-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62945/#review187843 --- Ship it! Ship It! - Sebastian Toader On Oct. 12, 2017, 8:57

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/#review187773 --- Ship it! Ship It! - Sebastian Toader On Oct. 12, 2017, 1:39

Re: Review Request 62828: When regenerating keytab files for a service, non-service-specific principals are affected

2017-10-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62828/#review187415 --- Ship it! Ship It! - Sebastian Toader On Oct. 8, 2017, 1:36

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Sebastian Toader
/internal/BlueprintConfigurationProcessor.java Line 1374 (original), 1420 (patched) <https://reviews.apache.org/r/62809/#comment264362> Can you do the same for `MultipleHostTopologyUpdater` and other updaters which currently process hostgroup plcaeholders? - Sebastian Toader On Oct. 9

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62809/#review187400 --- Ship it! Ship It! - Sebastian Toader On Oct. 9, 2017, 9:16

Re: Review Request 62809: AMBARI-22159. Replace hostgroup vars for Druid

2017-10-09 Thread Sebastian Toader
r/controller/internal/BlueprintConfigurationProcessor.java Lines 2784 (patched) <https://reviews.apache.org/r/62809/#comment264352> Why property updater for `druid.zk.service.host` is not needed any more? - Sebastian Toader On Oct. 9, 2017, 9:16 a.m., Atti

Re: Review Request 62790: AMBARI-22141. Intermittent failure of test_stack_advisor_perf

2017-10-05 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62790/#review187187 --- Ship it! Ship It! - Sebastian Toader On Oct. 5, 2017, 4:36

Re: Review Request 62789: Secure cluster deploy failing with "While building the CHECK_KEYTABS custom command for KERBEROS/KERBEROS_CLIENT, there were no healthy eligible hosts"

2017-10-05 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62789/#review187186 --- Ship it! Ship It! - Sebastian Toader On Oct. 5, 2017, 4:17

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-04 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62757/#review187069 --- Ship it! Ship It! - Sebastian Toader On Oct. 3, 2017, 10:23

Re: Review Request 62723: Unit test fails with Python 2.6

2017-10-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62723/#review186850 --- Ship it! Ship It! - Sebastian Toader On Oct. 2, 2017, 2:04

Re: Review Request 62586: Update unit tests to test recursive variable replacements using VariableReplacementHelper

2017-09-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62586/#review186384 --- Ship it! Ship It! - Sebastian Toader On Sept. 26, 2017, 10

Re: Review Request 62367: Increase the default maximum memory value for Infra Solr

2017-09-17 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62367/#review185526 --- Ship it! Ship It! - Sebastian Toader On Sept. 17, 2017, 2

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-14 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62290/#review185398 --- Ship it! Ship It! - Sebastian Toader On Sept. 13, 2017, 9

Re: Review Request 62182: Ambari is setting "atlas.graph.storage.hostname" to hbase hostname, instead it should set the zookeeper quorum.

2017-09-13 Thread Sebastian Toader
. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62182/#review185192 --- On Sept. 12, 2017, 5:18 p.m., Sebasti

Re: Review Request 62182: Ambari is setting "atlas.graph.storage.hostname" to hbase hostname, instead it should set the zookeeper quorum.

2017-09-12 Thread Sebastian Toader
Testing --- Manual testing cluster creation using blueprints. Testing Blueprint export. Unit tests: [INFO] Results: [INFO] [WARNING] Tests run: 4870, Failures: 0, Errors: 0, Skipped: 37 Thanks, Sebastian Toader

Review Request 62182: Ambari is setting "atlas.graph.storage.hostname" to hbase hostname, instead it should set the zookeeper quorum.

2017-09-12 Thread Sebastian Toader
182/diff/1/ Testing --- Manual testing cluster creation using blueprints. Testing Blueprint export. Unit tests: [INFO] Results: [INFO] [WARNING] Tests run: 4870, Failures: 0, Errors: 0, Skipped: 37 Thanks, Sebastian Toader

Re: Review Request 62216: Allow SERVER Type Alerts To Run For Any Service/Component

2017-09-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62216/#review185064 --- Ship it! Ship It! - Sebastian Toader On Sept. 11, 2017, 12

Re: Review Request 62081: AMBARI-21878. Implement STOMP endpoint to handle alerts from agent

2017-09-07 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62081/#review184800 --- Ship it! Ship It! - Sebastian Toader On Sept. 5, 2017, 2:43

Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for alert definitions

2017-09-07 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61886/#review184799 --- Ship it! Ship It! - Sebastian Toader On Sept. 5, 2017, 8:20

Re: Review Request 62084: Throw an error if unsupported database JDBC driver is configured for HDP services

2017-09-06 Thread Sebastian Toader
`` is unrelated to this change. Thanks, Sebastian Toader

Review Request 62084: Throw an error if unsupported database JDBC driver is configured for HDP services

2017-09-05 Thread Sebastian Toader
/python/common-services/configs/sqoop_unsupported_jdbc_driver.json PRE-CREATION ambari-server/src/test/python/custom_actions/TestCheckHost.py 0d4e485 Diff: https://reviews.apache.org/r/62084/diff/1/ Testing --- Unit tests currently running. Thanks, Sebastian Toader

Re: Review Request 61888: Add configurable management endpoints to Log Search

2017-08-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61888/#review183762 --- Ship it! Ship It! - Sebastian Toader On Aug. 24, 2017, 5:05

Re: Review Request 61850: Log Search: hdfs audit log fields are not mapped

2017-08-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61850/#review183723 --- Ship it! Ship It! - Sebastian Toader On Aug. 23, 2017, 6:20

Re: Review Request 61875: Oozie server crashes post migration after regen kerberos keytabs and restart all services

2017-08-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61875/#review183714 --- Ship it! Ship It! - Sebastian Toader On Aug. 24, 2017, 3:54

Re: Review Request 61707: Pre-configure services when Kerberos is enabled to reduce number of core service restarts when services are added

2017-08-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61707/#review183712 --- Ship it! Ship It! - Sebastian Toader On Aug. 23, 2017, 9:37

Re: Review Request 61833: Ambari server logs consistency check warning after service delete with ConfigGroup present

2017-08-23 Thread Sebastian Toader
/configgroup/ConfigGroupImpl.java Lines 118 (patched) <https://reviews.apache.org/r/61833/#comment259636> Can we pass in service name to the constructor and used that instead of tag? Similar to how this has been done in AMBARI-21078 ? - Sebastian Toader On Aug. 23, 2017, 3:51 a.m., Sid

Re: Review Request 61803: zeppelin proxy user settings are not configured in core-site.xml on upgraded cluster from Ambari 2.4.2

2017-08-22 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61803/#review183471 --- Ship it! Ship It! - Sebastian Toader On Aug. 22, 2017, 2:23

Re: Review Request 61744: Allow for keytab regeneration to be filtered for hosts

2017-08-22 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61744/#review183465 --- Ship it! Ship It! - Sebastian Toader On Aug. 22, 2017, 12

Re: Review Request 61803: zeppelin proxy user settings are not configured in core-site.xml on upgraded cluster from Ambari 2.4.2

2017-08-22 Thread Sebastian Toader
ELIN/kerberos.json Lines 46-47 (original) <https://reviews.apache.org/r/61803/#comment259467> Aren't these needed any more? - Sebastian Toader On Aug. 21, 2017, 11:36 p.m., Robert Levas wrote: > > --- > This is an automat

Re: Review Request 61744: Allow for keytab regeneration to be filtered for hosts

2017-08-22 Thread Sebastian Toader
rver/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java Lines 327 (patched) <https://reviews.apache.org/r/61744/#comment259461> If the retruned map is not meant to be modified by caller than return an immutable Map of immutable Set. - Sebastian Toader On

Re: Review Request 61707: Pre-configure services when Kerberos is enabled to reduce number of core service restarts when services are added

2017-08-21 Thread Sebastian Toader
g/r/61707/#comment259364> Small typo: "cata" -> "data" - Sebastian Toader On Aug. 17, 2017, 2:51 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 61743: Use latest-vdf for default when version is unspecified

2017-08-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61743/#review183316 --- Ship it! Ship It! - Sebastian Toader On Aug. 18, 2017, 6:03

Re: Review Request 61653: AMBARI-21723. Redundant type arguments (Java 8)

2017-08-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61653/#review182936 --- Ship it! Ship It! - Sebastian Toader On Aug. 15, 2017, 12

Re: Review Request 61623: Blueprint deployments failing without version string

2017-08-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61623/#review182932 --- Ship it! Ship It! - Sebastian Toader On Aug. 15, 2017, 3:43

Re: Review Request 61616: AMBARI-21714. Intermittent unit test failure in ExecutionCommandWrapperTest

2017-08-14 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61616/#review182853 --- Ship it! Ship It! - Sebastian Toader On Aug. 14, 2017, 1:09

Re: Review Request 61592: AMBARI-21708. History Server cannot be started due to wrong permissions of /mr-history

2017-08-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61592/#review182671 --- Ship it! Ship It! - Sebastian Toader On Aug. 11, 2017, 11

Re: Review Request 61501: Prevent users from authenticating if they exceed a configured number of login failures

2017-08-10 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61501/#review182600 --- Ship it! Ship It! - Sebastian Toader On Aug. 10, 2017, 5:28

Re: Review Request 61547: Spark thrift service was alerting for connectivity for all newly created clusters

2017-08-10 Thread Sebastian Toader
[INFO] [INFO] Total time: 35:45 min [INFO] Finished at: 2017-08-10T16:18:53+02:00 [INFO] Final Memory: 74M/398M [INFO] Thanks, Sebastian Toader

Re: Review Request 61557: AMBARI-21701. Add check for import from relocated packages

2017-08-10 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61557/#review182593 --- Ship it! Ship It! - Sebastian Toader On Aug. 10, 2017, 3:47

Review Request 61547: Spark thrift service was alerting for connectivity for all newly created clusters

2017-08-10 Thread Sebastian Toader
/scripts/alerts/alert_spark_thrift_port.py 93a2de8 ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/alerts/alert_spark2_thrift_port.py 1ce4aca Diff: https://reviews.apache.org/r/61547/diff/1/ Testing --- Manual testing. Thanks, Sebastian Toader

Re: Review Request 60668: Fixed outdated index.html generation in ambari-server/target/generated-sources/swagger

2017-08-08 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60668/#review182379 --- Ship it! Ship It! - Sebastian Toader On July 5, 2017, 10:32

Re: Review Request 61461: Log Search cleanup: all configurations should be spring managed

2017-08-07 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61461/#review182283 --- Ship it! Ship It! - Sebastian Toader On Aug. 7, 2017, 6:03

Review Request 61404: Do not use 'dbo' schema name in idempotent Ambari DDL generator for AzureDB.

2017-08-03 Thread Sebastian Toader
] [INFO] Total time: 34:08 min [INFO] Finished at: 2017-08-03T15:10:27+02:00 [INFO] Final Memory: 74M/629M [INFO] Thanks, Sebastian Toader

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/#review181972 --- Ship it! Ship It! - Sebastian Toader On Aug. 2, 2017, 1:59

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/#review181897 --- Ship it! Ship It! - Sebastian Toader On Aug. 1, 2017, 4:56

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-01 Thread Sebastian Toader
ecific users and groups (defined in kerberos.json). - Sebastian Toader On Aug. 1, 2017, 11:58 a.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61269: AMBARI-21619. More ResourceManager HA host group placeholders in blueprints

2017-08-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61269/#review181887 --- Ship it! Ship It! - Sebastian Toader On Aug. 1, 2017, 9:04

Re: Review Request 61140: Ambari REST API to support setting rack info during add host

2017-07-27 Thread Sebastian Toader
-26T16:38:04+02:00 [INFO] Final Memory: 61M/511M [INFO] Thanks, Sebastian Toader

Re: Review Request 61163: testBadCredential UT fails

2017-07-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61163/#review181542 --- Ship it! Ship It! - Sebastian Toader On July 26, 2017, 11

Re: Review Request 61162: Ooozie quicklink configuration doesn't work with https

2017-07-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61162/#review181541 --- Ship it! Ship It! - Sebastian Toader On July 26, 2017, 11

Review Request 61140: Ambari REST API to support setting rack info during add host

2017-07-26 Thread Sebastian Toader
] BUILD SUCCESS [INFO] [INFO] Total time: 51:54 min [INFO] Finished at: 2017-07-26T16:38:04+02:00 [INFO] Final Memory: 61M/511M [INFO] Thanks, Sebastian

Re: Review Request 61102: AMBARI-21568. Pig service check fails after upgrade

2017-07-25 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61102/#review181345 --- Ship it! Ship It! - Sebastian Toader On July 25, 2017, 4:11

Re: Review Request 61038: Resource Manager fails to restart properly during an IOP to HDP upgrade

2017-07-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61038/#review181123 --- Ship it! Ship It! - Sebastian Toader On July 21, 2017, 5:57

Re: Review Request 61024: Implement support for recommending LDAP configuration

2017-07-21 Thread Sebastian Toader
roller/internal/StackAdvisorResourceProvider.java Lines 345 (patched) <https://reviews.apache.org/r/61024/#comment256535> Add some comment what this method does. - Sebastian Toader On July 21, 2017, 2:21 p.m., Balázs Benc

Re: Review Request 60861: Ambari rebuilds custom auth_to_local rules changing its case sensitiveness option (/L)

2017-07-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60861/#review181054 --- Ship it! Ship It! - Sebastian Toader On July 17, 2017, 1:44

Re: Review Request 60870: AMBARI-21478. Wrong string quoting in get_stack_version

2017-07-14 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60870/#review180540 --- Ship it! Ship It! - Sebastian Toader On July 14, 2017, 6:26

Re: Review Request 60774: Ambari updates memory settings in blueprint incorrectly

2017-07-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60774/#review180300 --- Ship it! Ship It! - Sebastian Toader On July 12, 2017, 2:51

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-07-12 Thread Sebastian Toader
tps://reviews.apache.org/r/60249/#comment255374> This is not needed as HDP/2.6 already inherits from HDP/2.5 and HDP/2.5/services/KAFKA/metainfo.xml has this - Sebastian Toader On July 11, 2017, 8:19 a.m., Ambud Sharma

Re: Review Request 60774: Ambari updates memory settings in blueprint incorrectly

2017-07-12 Thread Sebastian Toader
esn't the one defined in the cluster creation template. Check the ```getFullProperties()``` method. - Sebastian Toader On July 11, 2017, 5:02 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-

Re: Review Request 60711: Assigning hosts concurrently to same config group may fail with "org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Config group already exist'

2017-07-10 Thread Sebastian Toader
. FAILURE [ 01:05 h] [INFO] One metrics test failed and is not related to this change. Thanks, Sebastian Toader

Re: Review Request 60707: BE: Extend Ambari REST API to Support User Account Management Improvements

2017-07-10 Thread Sebastian Toader
e by adding a new field to the class but forgetting to update the equals and hashcode methods accordingly. There a test library that does that for you ```EqualsVerifier``` that can be used for that. (look at ```OperationStatusAuditEventTest.testEquals()``` as an example how currently is us

Review Request 60711: Assigning hosts concurrently to same config group may fail with "org.apache.ambari.server.controller.spi.ResourceAlreadyExistsException: Config group already exist'

2017-07-07 Thread Sebastian Toader
is not related to this change. Thanks, Sebastian Toader

Re: Review Request 60637: Cleanup relevant Kerberos identities when a service is removed

2017-07-04 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60637/#review179583 --- Ship it! Ship It! - Sebastian Toader On July 4, 2017, 5:20

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-07-04 Thread Sebastian Toader
for older verions of Kafka that doesn't support rack awareness to be marked by Ambari to be restarted whenever the rack information for hosts changes. - Sebastian Toader On June 28, 2017, 1:10 a.m., Ambud Sharma wrote

Re: Review Request 60565: Force to use JDK 8 for Ambari Server maven build

2017-07-03 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60565/#review179516 --- Ship it! Ship It! - Sebastian Toader On July 3, 2017, 6:43

Re: Review Request 60588: stackadvisor error during cluster creation, getOldValue is not defined

2017-07-03 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60588/#review179492 --- Ship it! Ship It! - Sebastian Toader On July 3, 2017, 10:42

Re: Review Request 60540: AMBARI-21339 logviewer started along with nimbus if supervisor is not running on the same machine

2017-06-29 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60540/#review179290 --- Ship it! Ship It! - Sebastian Toader On June 29, 2017, 5:20

Re: Review Request 60431: Cleanup relevant Kerberos identities when a component is removed

2017-06-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60431/#review178966 --- Ship it! Ship It! - Sebastian Toader On June 26, 2017, 6:23

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-06-22 Thread Sebastian Toader
> On June 21, 2017, 8:04 a.m., Sebastian Toader wrote: > > Run unit ambari-server unit tests and post results here. > > > > Perform manual testing of upgrade scenarios eg. install a cluster that has > > Kafka an older version (e.g. 2.4 or 2.5.1) of Ambari that do

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-06-22 Thread Sebastian Toader
> On June 21, 2017, 8:04 a.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > > Lines 106-115 (patched) > > <https://reviews.apache.org/r/60249/diff/1/?file=1754688#file1754688line106> > >

Re: Review Request 60205: Add support for consecutive login failure accounting

2017-06-22 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60205/#review178684 --- Ship it! Ship It! - Sebastian Toader On June 22, 2017, 4:39

Re: Review Request 60270: AMBARI-21294. Setup should keep existing connection-pool setting in ambari.properties

2017-06-22 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60270/#review178632 --- Ship it! Ship It! - Sebastian Toader On June 21, 2017, 4:57

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-06-22 Thread Sebastian Toader
> On June 21, 2017, 8:04 a.m., Sebastian Toader wrote: > > Run unit ambari-server unit tests and post results here. > > > > Perform manual testing of upgrade scenarios eg. install a cluster that has > > Kafka an older version (e.g. 2.4 or 2.5.1) of Ambari that do

Re: Review Request 60205: Add support for consecutive login failure accounting

2017-06-22 Thread Sebastian Toader
it's better to log ```Consecutive failures(UNKNOW USER)``` to the audit log. What so you think? - Sebastian Toader On June 21, 2017, 9:46 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 60205: Add support for consecutive login failure accounting

2017-06-21 Thread Sebastian Toader
> On June 20, 2017, 1:45 p.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authentication/AmbariAuthenticationEventHandlerImpl.java > > Lines 109-117 (patched) > > <https://reviews.apache.org/r/60205/diff/1/?file=17

Re: Review Request 60271: AMBARI-21295. Enable Swagger checkstyle rule for endpoints documented so far

2017-06-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60271/#review178490 --- Ship it! Ship It! - Sebastian Toader On June 21, 2017, 3

Re: Review Request 60270: AMBARI-21294. Setup should keep existing connection-pool setting in ambari.properties

2017-06-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60270/#review178485 --- Ship it! Ship It! - Sebastian Toader On June 21, 2017, 1:38

Re: Review Request 60269: AMBARI-21293. Allow skipping Swagger generation

2017-06-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60269/#review178470 --- Ship it! Ship It! - Sebastian Toader On June 21, 2017, 11

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-06-21 Thread Sebastian Toader
will return to stdout the rack info for the given hosts. - Sebastian Toader On June 20, 2017, 11:17 p.m., Ambud Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 60205: Add support for consecutive login failure accounting

2017-06-20 Thread Sebastian Toader
y or by some named JPQL query) ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java Lines 1349 (patched) <https://reviews.apache.org/r/60205/#comment252298> Shouldn't use optimistic locking here as well? - Sebastian Toa

Re: Review Request 60050: AMBARI-21240. Some topology request data retained after host removed

2017-06-16 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60050/#review178110 --- Ship it! Ship It! - Sebastian Toader On June 16, 2017, 5:03

Re: Review Request 60117: Add ambari prefix for utility and serviceadvisor modules

2017-06-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60117/#review178001 --- Ship it! Ship It! - Sebastian Toader On June 15, 2017, 1:53

  1   2   3   4   5   >