---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64989/#review194921
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 5, 2018, 11:19 p.m
/ambari/server/events/UpgradeUpdateEvent.java
Lines 38 (patched)
<https://reviews.apache.org/r/64990/#comment273985>
Can you add some javadoc please sa to what this event represents.
- Sid Wagle
On Jan. 5, 2018, 8:13 p.m., Myroslav Papirkovskyy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64989/#review194902
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 5, 2018, 8:16 p.m
the end.
Great catch, thanks.
- Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64991/#review194898
-------
On J
/TimelineWebServices.java
c09900d
ambari-metrics/pom.xml 6541cec
Diff: https://reviews.apache.org/r/64991/diff/1/
Testing
---
Manually verified.
Thanks,
Sid Wagle
we do not loose this thread.
- Sid Wagle
On Jan. 5, 2018, 6:59 p.m., Myroslav Papirkovskyy wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/HeartbeatProcessor.java
Lines 480 (patched)
<https://reviews.apache.org/r/64984/#comment273966>
Why is this needed to be done on HB processing? Can you please remind me if
we still piggy back tags on HB, in any case shouldn't tags matching determine
staleness?
- Sid Wagle
On Jan. 5, 2018
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64983/#review194879
---
Ship it!
Ship It!
- Sid Wagle
On Jan. 5, 2018, 5:44 p.m
]
Thanks,
Sid Wagle
]
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64607/#review194364
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 15, 2017, 8:57 a.m
---
Added a unit test.
Verified manually.
Thanks,
Sid Wagle
nes 30 (patched)
<https://reviews.apache.org/r/64553/#comment272362>
More contemporary design would be to create a Runnable that can be used by
the caller as an argument scheduledExectuor. The scehduling logic can be kept
out of the class.
- Sid Wagle
On Dec. 13, 2017, 3:24 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64537/#review193734
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 13, 2017, 3:42 p.m
to check for
file existence on plugin side and defaul to "simple" auth?
- Sid Wagle
On Dec. 12, 2017, 12:35 p.m., Vishal Suvagia wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64513/#review193556
---
Last revision has noly whitespace changes?
- Sid Wagle
On Dec
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64513/#review193555
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 11, 2017, 11:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64528/#review193554
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 12, 2017, 7:39 a.m
> On Dec. 7, 2017, 3:03 a.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/DetectionServiceConfiguration.scala
> > Lines 39 (patched)
> > <https://reviews.apache.org/r/64
-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/detection/pointintime/PointInTimeSubsystem.scala
Lines 61 (patched)
<https://reviews.apache.org/r/64393/#comment271580>
Better model will be to add a listener and handle events.
- Sid Wagle
On Dec. 6, 2017,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64373/#review193041
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 6, 2017, 1:04 p.m
it needs some rewrite to use
Executors and better concurrency contructs but for branch-2.6 adding a +1
- Sid Wagle
On Dec. 5, 2017, 8:50 p.m., Oliver Szabo wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
/apache/ambari/logfeeder/input/Input.java
Lines 215 (patched)
<https://reviews.apache.org/r/64349/#comment271281>
Have you considered using AtomicReference here vs deepCloning?
- Sid Wagle
On Dec. 5, 2017, 8:50 p.m., Oliver Szabo
il. To reply, visit:
https://reviews.apache.org/r/64315/#review192882
-----------
On Dec. 5, 2017, 4:51 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generat
/lzo_utils.py
68ee607
ambari-server/src/main/resources/stacks/BigInsights/4.0/properties/stack_features.json
d29efb2
Diff: https://reviews.apache.org/r/64315/diff/2/
Changes: https://reviews.apache.org/r/64315/diff/1-2/
Testing
---
mvn clean test
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64209/#review192874
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 5, 2017, 11:04 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64302/#review192725
---
Ship it!
Ship It!
- Sid Wagle
On Dec. 4, 2017, 4:15 p.m
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote:
> > This is making the agent-side do the logic. Shouldn't we check these
> > things and not include GPL repos in the command to the agent?
>
> Sid Wagle wrote:
> We would still need to make sure existing hosts
CS/0.1.0/metainfo.xml
Lines 141 (patched)
<https://reviews.apache.org/r/64221/#comment270485>
ams-admanager-spark-env
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
Lines 574 (patched)
<https://reviews.apache.org/r/64221/#comment270491>
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote:
> > This is making the agent-side do the logic. Shouldn't we check these
> > things and not include GPL repos in the command to the agent?
>
> Sid Wagle wrote:
> We would still need to make sure existing hosts
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote:
> > This is making the agent-side do the logic. Shouldn't we check these
> > things and not include GPL repos in the command to the agent?
>
> Sid Wagle wrote:
> We would still need to make sure existing hosts
To reply, visit:
> https://reviews.apache.org/r/64209/
> ---
>
> (Updated Nov. 30, 2017, 1:28 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate
> Cole, and Sid Wagle.
>
>
>
effort on this?
- Sid Wagle
On Nov. 30, 2017, 1:28 p.m., Andrew Onischuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-22555-1.patch
AMBARI-22555-1.patch
https://reviews.apache.org/media/uploaded/files/2017/11/30/1276fb76-4340-4d2b-8bb2-ff2edfa49a73__AMBARI-22555-1.patch
Thanks,
Sid Wagle
Diff: https://reviews.apache.org/r/64186/diff/3/
Testing
---
mvn clean test
File Attachments (updated)
AMBARI-22555-1.patch
https://reviews.apache.org/media/uploaded/files/2017/11/30/3aaac156-4020-4d03-8611-de2790ff9301__AMBARI-22555-1.patch
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64174/#review192315
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 29, 2017, 8:49 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64216/#review192314
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 30, 2017, 5:14 p.m
Diff: https://reviews.apache.org/r/64186/diff/3/
Changes: https://reviews.apache.org/r/64186/diff/2-3/
Testing
---
mvn clean test
Thanks,
Sid Wagle
://reviews.apache.org/r/64186/diff/2/
Changes: https://reviews.apache.org/r/64186/diff/1-2/
Testing (updated)
---
mvn clean test
Thanks,
Sid Wagle
/main/python/ambari_server/serverUpgrade.py a864609
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
3f8a772
Diff: https://reviews.apache.org/r/64186/diff/1/
Testing
---
Thanks,
Sid Wagle
/UpgradeCatalog260.java
Lines 350 (patched)
<https://reviews.apache.org/r/64174/#comment270214>
Will this delete existing data? Any implications of doing so?
- Sid Wagle
On Nov. 29, 2017, 8:49 p.m., Myroslav Papirkovskyy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64134/#review192066
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 28, 2017, 9:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64127/#review192044
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 28, 2017, 6:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64082/#review191904
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 27, 2017, 1:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64087/#review191903
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 27, 2017, 4:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63957/#review191752
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 22, 2017, 6:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63957/#review191533
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 20, 2017, 5:06 p.m
105 (patched)
<https://reviews.apache.org/r/63935/#comment269253>
Can reduce code duplication with a helper method.
- Sid Wagle
On Nov. 18, 2017, 4:24 a.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically
pgrade/UpgradeCatalog261.java
Lines 90 (patched)
<https://reviews.apache.org/r/63876/#comment268870>
To make this future proof we should have a cluter map returned but for now
lets add a TODO for it.
- Sid Wagle
On Nov. 16, 2017, 1:27 p.m., Andrew On
-server.py
Lines 516 (patched)
<https://reviews.apache.org/r/63838/#comment268670>
Rename to be more explicit based o nthe realtime board:
--enable-lzo-under-gpl-license
- Sid Wagle
On Nov. 15, 2017, 2:34 p.m., Andrew Onischuk
la/org/apache/ambari/metrics/adservice/leveldb/LevelDBDatasource.scala
Line 44 (original), 55 (patched)
<https://reviews.apache.org/r/63787/#comment268489>
why get.. vs verb for behavior spec?
- Sid Wagle
On Nov. 14, 2017, 6:16 a.m., Aravindan V
/CustomServiceOrchestrator.py
Lines 466 (patched)
<https://reviews.apache.org/r/63755/#comment268422>
Shouldn't this exception be caught and subsequently result in refresh of
config cache instead of failing?
- Sid Wagle
On Nov. 13, 2017, 2:45 p.m., Andrew Onischuk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63671/#review190474
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 8, 2017, 5:08 p.m
.
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63524/#review189967
---
Ship it!
Ship It!
- Sid Wagle
On Nov. 2, 2017, 9:24 p.m
ineMetricsService.java
Lines 469 (patched)
<https://reviews.apache.org/r/63477/#comment267079>
formatting.
- Sid Wagle
On Nov. 1, 2017, 9:21 p.m., Aravindan Vijayan wrote:
>
> ---
> This is a
://reviews.apache.org/r/63449/diff/1/
Testing
---
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63334/#review189332
---
Ship it!
Ship It!
- Sid Wagle
On Oct. 26, 2017, 7:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62989/#review188060
---
Ship it!
Ship It!
- Sid Wagle
On Oct. 13, 2017, 8:50 p.m
,
Sid Wagle
ambari-metrics/pom.xml fb2997a
ambari-utility/pom.xml 1e86d40
Diff: https://reviews.apache.org/r/62941/diff/1/
Testing
---
Issue with drop wizard logging still to be resolved.
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62932/#review187819
---
Ship it!
Ship It!
- Sid Wagle
On Oct. 12, 2017, 12:38 p.m
/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java
Lines 84 (patched)
<https://reviews.apache.org/r/62805/#comment264197>
Missing expectLastCall() ?
- Sid Wagle
On Oct. 6, 2017, 9:47 a.m., Attila Doroszlai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62624/#review186475
---
Ship it!
Ship It!
- Sid Wagle
On Sept. 27, 2017, 7 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/#review186309
---
Ship it!
Ship It!
- Sid Wagle
On Sept. 25, 2017, 2:19 p.m
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/#review185913
-------
On Sept. 21, 2017, 7:57 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.ap
Diff: https://reviews.apache.org/r/62474/diff/2/
Changes: https://reviews.apache.org/r/62474/diff/1-2/
Testing
---
Manually tested.
Thanks,
Sid Wagle
.
Thanks,
Sid Wagle
-4ce6-971e-db5c639f2346__AMBARI-21942-2.patch
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61510/#review185454
---
Ship it!
Ship It!
- Sid Wagle
On Aug. 8, 2017, 10:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62294/#review185358
---
Ship it!
Ship It!
- Sid Wagle
On Sept. 13, 2017, 10:54 p.m
eduler/ExecutionScheduleManager.java
Lines 803 (patched)
<https://reviews.apache.org/r/62294/#comment261640>
Why static?
- Sid Wagle
On Sept. 13, 2017, 8:25 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To
/services/stack_advisor.py
Lines 873 (patched)
<https://reviews.apache.org/r/62292/#comment261637>
Is this left behind artifact?
- Sid Wagle
On Sept. 13, 2017, 7:49 p.m., Aravindan Vijayan wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62250/#review185246
---
Ship it!
Ship It!
- Sid Wagle
On Sept. 12, 2017, 4:58 p.m
-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
Lines 101 (patched)
<https://reviews.apache.org/r/62125/#comment261548>
More redable as host.alias vs the other way.
- Sid Wagle
On Sept. 12, 2017, 7:21 p.m., Aravindan Vijayan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62186/#review184988
---
Ship it!
Ship It!
- Sid Wagle
On Sept. 8, 2017, 4:17 p.m
esourceProvider.java
0ea54cb
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
da517f3
ambari-server/src/main/resources/properties.json 80a86b8
Diff: https://reviews.apache.org/r/62169/diff/1/
Testing
---
Manually verified.
Affected unit tests are green.
Thanks,
Sid Wagle
iew184854
---
On Sept. 7, 2017, 6:19 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
2f858b8
Diff: https://reviews.apache.org/r/62134/diff/3/
Changes: https://reviews.apache.org/r/62134/diff/2-3/
Testing
---
PropertyProvider tests are all green
Pending unit tests and manual testing.
Thanks,
Sid Wagle
---
PropertyProvider tests are all green
Pending unit tests and manual testing.
Thanks,
Sid Wagle
/1/
Testing
---
PropertyProvider tests are all green
Pending unit tests and manual testing.
Thanks,
Sid Wagle
/0.1.0/package/scripts/ams.py
Lines 519 (patched)
<https://reviews.apache.org/r/62125/#comment260911>
This assumes that alais is hostname we should allow a config of type
prefix.cert.hostname.alias to allow alias mapped to cert coming from the
collector.
- Sid Wagle
On Sept. 6, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62097/#review184583
---
Ship it!
Ship It!
- Sid Wagle
On Sept. 5, 2017, 9:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62072/#review184574
---
Ship it!
Ship It!
- Sid Wagle
On Sept. 5, 2017, 6:46 p.m
> On Sept. 5, 2017, 5:18 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
> > Lines 379 (patched)
> > <https://reviews.apache.org/r/62072/diff/3/?file=1814453#file1814453line379>
> >
> >
/UpgradeCatalog260.java
Lines 379 (patched)
<https://reviews.apache.org/r/62072/#comment260735>
Why is this done during Ambari upgrade as well as stack upgrade? The
presense of this property on existing stack should not cause ay issues after
Amabri upgrade.
- Sid Wagle
On Sept. 5, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61969/#review184066
---
Ship it!
Ship It!
- Sid Wagle
On Aug. 29, 2017, 2:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61945/#review183934
---
Ship it!
Ship It!
- Sid Wagle
On Aug. 28, 2017, 3:17 p.m
/ambari/server/upgrade/UpgradeCatalog260.java
Lines 166 (patched)
<https://reviews.apache.org/r/61856/#comment259928>
Does this comment still apply?
- Sid Wagle
On Aug. 25, 2017, 3:34 p.m., Vitalyi Brodetskyi
/ServiceComponentHostTest.java
fc1f334
Diff: https://reviews.apache.org/r/61833/diff/4/
Changes: https://reviews.apache.org/r/61833/diff/3-4/
Testing
---
Manually verfied with a 2.5.2 cluster.
Unit test added.
All modified unit test pass.
Thanks,
Sid Wagle
e user sees it once and can actually autofix it if needed. Opinion?
- Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61833/#review183736
-------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61875/#review183695
---
Ship it!
Ship It!
- Sid Wagle
On Aug. 24, 2017, 1:54 a.m
where the older stack
version RCO gets recached.
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
234ef26
Diff: https://reviews.apache.org/r/61876/diff/1/
Testing
---
Thanks,
Sid Wagle
/
Testing
---
Manual verification pending.
Thanks,
Sid Wagle
g/r/61856/#comment259704>
Is this within a transaction boundary?
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
Lines 48 (patched)
<https://reviews.apache.org/r/61856/#comment259702>
Make sure to run checkstyle on this.
- Sid Wagle
On Aug.
(updated)
---
Manually verfied with a 2.5.2 cluster.
Unit test added.
All modified unit test pass.
Thanks,
Sid Wagle
://reviews.apache.org/r/61833/diff/3/
Changes: https://reviews.apache.org/r/61833/diff/2-3/
Testing
---
Manually verfied with a 2.5.2 cluster.
Unit test added.
Thanks,
Sid Wagle
/diff/1-2/
Testing
---
Manually verfied with a 2.5.2 cluster.
Unit test added.
Thanks,
Sid Wagle
---
Manually verfied with a 2.5.2 cluster.
Unit test added.
Thanks,
Sid Wagle
/cluster/ClusterImpl.java
Lines 1800 (patched)
<https://reviews.apache.org/r/61582/#comment259405>
Fix internal id number.
- Sid Wagle
On Aug. 21, 2017, 8:01 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatica
1 - 100 of 514 matches
Mail list logo