Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-19 Thread Swapan Shridhar
2.2") -- In get_stack_setting_value(). Passed-in setting : stack_features **o/p** : False **D**. Test for existing and modified : **stack_tools.get_stack_tool()** which internally now calls **stack_settings.get_stack_setting_value()** **---** - 1. Retrieve **stack relevant tools** with call -> stack_tools.get_stack_tool("stack_selector") -- In get_stack_setting_value(). Passed-in setting : stack_tools **o/p**: ('hdp-select', '/usr/bin/hdp-select', 'hdp-select') Thanks, Swapan Shridhar

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-19 Thread Swapan Shridhar
rnally now calls **stack_settings.get_stack_setting_value()** **---** - 1. Retrieve **stack relevant tools** with call -> stack_tools.get_stack_tool("stack_selector") -- In get_stack_setting_value(). Passed-in setting : stack_tools **o/p**: ('hdp-select', '/usr/bin/hdp-select', 'hdp-select') Thanks, Swapan Shridhar

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-19 Thread Swapan Shridhar
17, 2017, 8:01 p.m., Attila Doroszlai wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/settings.py > > Lines 105-108 (patched) > > <https://reviews.apache.org/r/64594/diff/3/?file=1919140#file1919140line105> > > > >

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-17 Thread Swapan Shridhar
ps://reviews.apache.org/r/64594/#review194013 ------- On Dec. 17, 2017, 8:11 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-17 Thread Swapan Shridhar
value(). Passed-in setting : stack_features **o/p** : False **D**. Test for existing and modified : **stack_tools.get_stack_tool()** which internally now calls **stack_settings.get_stack_setting_value()** **---** - 1. Retrieve **stack relevant tools** with call -> stack_tools.get_stack_tool("stack_selector") -- In get_stack_setting_value(). Passed-in setting : stack_tools **o/p**: ('hdp-select', '/usr/bin/hdp-select', 'hdp-select') Thanks, Swapan Shridhar

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-14 Thread Swapan Shridhar
Retrieve **specific component stack feature** with call -> stack_features.check_stack_feature("hive_server_interactive", "2.2") -- In get_stack_setting_value(). Passed-in setting : stack_features **o/p** : False **D**. Test for existing and modified : **stack_tools.get_stack_tool()** which internally now calls **stack_settings.get_stack_setting_value()** **---** - 1. Retrieve **stack relevant tools** with call -> stack_tools.get_stack_tool("stack_selector") -- In get_stack_setting_value(). Passed-in setting : stack_tools **o/p**: ('hdp-select', '/usr/bin/hdp-select', 'hdp-select') Thanks, Swapan Shridhar

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-14 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64594/#review193825 --- On Dec. 14, 2017, 9:02 a.m., Swapan Shridhar w

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-14 Thread Swapan Shridhar
t: https://reviews.apache.org/r/64594/#review193820 --- On Dec. 14, 2017, 9:02 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e

Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-14 Thread Swapan Shridhar
-- In get_stack_setting_value(). Passed-in setting : stack_features **o/p** : False **D**. Test for existing and modified : **stack_tools.get_stack_tool()** which internally now calls **stack_settings.get_stack_setting_value()** **---** - 1. Retrieve **stack relevant tools** with call -> stack_tools.get_stack_tool("stack_selector") -- In get_stack_setting_value(). Passed-in setting : stack_tools **o/p**: ('hdp-select', '/usr/bin/hdp-select', 'hdp-select') Thanks, Swapan Shridhar

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-14 Thread Swapan Shridhar
Retrieve **specific component stack feature** with call -> stack_features.check_stack_feature("hive_server_interactive", "2.2") -- In get_stack_setting_value(). Passed-in setting : stack_features **o/p** : False **D**. Test for existing and modified : **stack_tools.get_stack_tool()** which internally now calls **stack_settings.get_stack_setting_value()** **---** - 1. Retrieve **stack relevant tools** with call -> stack_tools.get_stack_tool("stack_selector") -- In get_stack_setting_value(). Passed-in setting : stack_tools **o/p**: ('hdp-select', '/usr/bin/hdp-select', 'hdp-select') Thanks, Swapan Shridhar

Re: Review Request 64397: AMBARI-22602. Add 'clusterSettings' and 'stackSettings' parameters in Execution Command.

2017-12-11 Thread Swapan Shridhar
rver\"\n ],\n \"STANDARD\": [\n \"spark2-thriftserver\"\n ]\n}\n },\n \"SQOOP\": {\n \"SQOOP\": {\n \"STACK-SELECT-PACKAGE\": \"sqo

Re: Review Request 64397: AMBARI-22602. Add 'clusterSettings' and 'stackSettings' parameters in Execution Command.

2017-12-11 Thread Swapan Shridhar
\"STANDARD\": [\n \"spark2-historyserver\"\n ]\n},\n \"SPARK_THRIFTSERVER\": {\n \"STACK-SEL

Re: Review Request 64397: AMBARI-22602. Add 'clusterSettings' and 'stackSettings' parameters in Execution Command.

2017-12-11 Thread Swapan Shridhar
s to avoid code > > duplication among `AmbariCustomCommandExecutionHelper`, > > `AmbariManagementControllerImpl` and `ClientConfigResourceProvider`? Refactored. - Swapan --- This is an automatically generated

Re: Review Request 64397: AMBARI-22602. Add 'clusterSettings' and 'stackSettings' parameters in Execution Command.

2017-12-11 Thread Swapan Shridhar
------- On Dec. 7, 2017, 8:11 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64397/ > --

Re: Review Request 64368: Livy2 keytabs are not getting configured automatically in zeppelin

2017-12-07 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64368/#review193170 --- Ship it! Ship It! - Swapan Shridhar On Dec. 6, 2017, 9:21

Review Request 64397: AMBARI-22602. Add 'clusterSettings' and 'stackSettings' parameters in Execution Command.

2017-12-07 Thread Swapan Shridhar
OOP\": {\n \"SQOOP\": {\n \"STACK-SELECT-PACKAGE\": \"sqo

Re: Review Request 63965: New endpoint service_config_version for creating new config versions via service endpoint instead of cluster update

2017-12-04 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63965/#review192775 --- Ship it! Ship It! - Swapan Shridhar On Nov. 22, 2017, 5:47

Re: Review Request 64005: Fix build for test classes in feature branch

2017-11-22 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64005/#review191774 --- Ship it! Ship It! - Swapan Shridhar On Nov. 22, 2017, 3:01

Review Request 64024: AMBARI-22498. Remove trailing lines (if any) from llapstatus command before converting the o/p to JSON.

2017-11-22 Thread Swapan Shridhar
== **Fix:** Added code to remove the trailing lines as well. Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py 57cbcd0 ambari-server/src/test/python/stacks/2.5/HIVE/running_withMOTDmsg_andTrailingMsg.txt PRE-CREATION ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py cf79ec7 Diff: https://reviews.apache.org/r/64024/diff/1/ Testing --- - UT added having begginning and end extra lines. Passes. - Tested on live cluster with no begginning and trailing message. Thanks, Swapan Shridhar

Re: Review Request 63937: AMBARI-22472. Ambari Upgrade 2.5 -> 2.6 : Update NodeManager's HSI identity 'llap_zk_hive' and 'llap_task_hive' to use '/HIVE/HIVE_SERVER/hive_server_hive' reference instead

2017-11-21 Thread Swapan Shridhar
HiveConfigs(778)) - Updated HSI config(s) : [hive.llap.task.keytab.file, hive.llap.zk.sm.keytab.file] with values = [/etc/security/keytabs/hive.service.keytab, /etc/security/keytabs/hive.service.keytab] Thanks, Swapan Shridhar

Re: Review Request 63937: AMBARI-22472. Ambari Upgrade 2.5 -> 2.6 : Update NodeManager's HSI identity 'llap_zk_hive' and 'llap_task_hive' to use '/HIVE/HIVE_SERVER/hive_server_hive' reference instead

2017-11-20 Thread Swapan Shridhar
.sm.keytab.file] with values = [/etc/security/keytabs/hive.service.keytab, /etc/security/keytabs/hive.service.keytab] Thanks, Swapan Shridhar

Re: Review Request 63937: AMBARI-22472. Ambari Upgrade 2.5 -> 2.6 : Update NodeManager's HSI identity 'llap_zk_hive' and 'llap_task_hive' to use '/HIVE/HIVE_SERVER/hive_server_hive' reference instead

2017-11-20 Thread Swapan Shridhar
[main] upgrade.UpgradeCatalog260 > (UpgradeCatalog260.java:fixYarnHsiKerberosDescriptorAndSiteConfig(729)) - > Updated 'llap_zk_hive' keytab descriptor group access = 'null' > 2017-11-20 13:09:45,370 INFO [main] upgrade.UpgradeCatalog260 > (UpgradeCatalog260.java:fixYarnHsiKerberosDescriptorAndSiteConfig(733)) - > Updated 'yarnKerberosDescUpdatedList' = [llap_zk_hive, llap_task_hive] > > > **UpgradeCatalog260Test::testUpdateHiveConfigs()** > > (AbstractUpgradeCatalog.java:updateConfigurationPropertiesForCluster(573)) - > Applying configuration with tag 'version1511212185535' and configType > 'hive-interactive-site' to cluster 'null' > 2017-11-20 13:09:45,536 INFO [main] upgrade.UpgradeCatalog260 > (UpgradeCatalog260.java:updateHiveConfigs(778)) - Updated HSI config(s) : > [hive.llap.task.keytab.file, hive.llap.zk.sm.keytab.file] with values = > [/etc/security/keytabs/hive.service.keytab, > /etc/security/keytabs/hive.service.keytab] > > > Thanks, > > Swapan Shridhar > >

Review Request 63937: AMBARI-22472. Ambari Upgrade 2.5 -> 2.6 : Update NodeManager's HSI identity 'llap_zk_hive' to use '/HIVE/HIVE_SERVER/hive_server_hive' reference instead of creating the same iden

2017-11-17 Thread Swapan Shridhar
7%20at%2011.44.41%20PM.png HSI up : https://issues.apache.org/jira/secure/attachment/12898328/Screen%20Shot%202017-11-17%20at%2011.44.55%20PM.png Thanks, Swapan Shridhar

Re: Review Request 63138: Update Spark2 log4j default settings to latest

2017-11-15 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63138/#review191125 --- Ship it! Ship It! - Swapan Shridhar On Oct. 19, 2017, 5:59

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-08 Thread Swapan Shridhar
"resources" : [ { "href" : "http://172.22.87.100:8080/api/v1/clusters/c1/settings/smokeuser;, "ClusterSettingInfo" : { "cluster_id" : 2, "cluster_name" : "c1", "cluster_setting_id" : 55, "cluster_setting_name" : "smokeuser", "cluster_setting_value" : "smoke_user2" } }, { "href" : "http://172.22.87.100:8080/api/v1/clusters/c1/settings/ignore_groupsusers_create;, "ClusterSettingInfo" : { "cluster_id" : 2, "cluster_name" : "c1", "cluster_setting_id" : 56, "cluster_setting_name" : "ignore_groupsusers_create", "cluster_setting_value" : "true" } } ] } {code} ***==** **DELETE** **==** DELETE http://{{host1}}:8080/api/v1/clusters/c1/settings/security_enabled {code:title=REQUEST} [] {code} {code:title=RESPONSE} { "deleteResult" : [ { "deleted" : { "key" : "cluster_name: c1, cluster_setting_name: security_enabled" } } ] } {code} Thanks, Swapan Shridhar

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-08 Thread Swapan Shridhar
ere? Comment removed. Fn calls 'persistEntities' which is @Transactional. - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63573/#review190435 -

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-08 Thread Swapan Shridhar
//reviews.apache.org/r/63573/diff/2/?file=1884291#file1884291line1009> > > > > Use `{}` placeholders instead of string concatenation, then > > `isDebugEnabled` check is not needed Done. - Swapan

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-08 Thread Swapan Shridhar
keuser;, > "ClusterSettingInfo" : { > "cluster_name" : "c1", > "cluster_setting_name" : "smokeuser" > } > } > ] > } > {code} > > > **Single Setting GET**: > > GET http://{{host1}}:8080/api/v1/clusters/c1/settings/smokeuser > > {code:title=REQUEST} > [] > {code} > > {code:title=RESPONSE} > { > "href" : "http://172.22.87.100:8080/api/v1/clusters/c1/settings/smokeuser;, > "ClusterSettingInfo" : { > "cluster_id" : 2, > "cluster_name" : "c1", > "cluster_setting_id" : 55, > "cluster_setting_name" : "smokeuser", > "cluster_setting_value" : "smoke_user1" > } > } > {code} > > > **==** > **PUT** > **** > > **Single Setting PUT**: > > PUT http://{{host1}}:8080/api/v1/clusters/c1/settings/security_enabled > > {code:title=REQUEST} > [ > { > "ClusterSettingInfo" : { > "cluster_setting_value": "true" > } > } > ] > {code} > > {code:title=RESPONSE} > { > "resources" : [ > { > "href" : > "http://172.22.87.100:8080/api/v1/clusters/c1/settings/security_enabled/security_enabled;, > "ClusterSettingInfo" : { > "cluster_id" : 2, > "cluster_name" : "c1", > "cluster_setting_id" : 54, > "cluster_setting_name" : "security_enabled", > "cluster_setting_value" : "true" > } > } > ] > } > {code} > > > **Multiple Setting PUT**: > > PUT http://{{host1}}:8080/api/v1/clusters/c1/settings/ > > {code:title=REQUEST} > [ > { > "ClusterSettingInfo" : { > "cluster_setting_name" : "ignore_groupsusers_create", > "cluster_setting_value": "true" > } > }, > { > "ClusterSettingInfo" : { > "cluster_setting_name" : "smokeuser", > "cluster_setting_value": "smoke_user2" > } > } > ] > {code} > > {code:title=RESPONSE} > { > "resources" : [ > { > "href" : > "http://172.22.87.100:8080/api/v1/clusters/c1/settings/smokeuser;, > "ClusterSettingInfo" : { > "cluster_id" : 2, > "cluster_name" : "c1", > "cluster_setting_id" : 55, > "cluster_setting_name" : "smokeuser", > "cluster_setting_value" : "smoke_user2" > } > }, > { > "href" : > "http://172.22.87.100:8080/api/v1/clusters/c1/settings/ignore_groupsusers_create;, > "ClusterSettingInfo" : { > "cluster_id" : 2, > "cluster_name" : "c1", > "cluster_setting_id" : 56, > "cluster_setting_name" : "ignore_groupsusers_create", > "cluster_setting_value" : "true" > } > } > ] > } > {code} > > > ***==** > **DELETE** > **==** > > DELETE http://{{host1}}:8080/api/v1/clusters/c1/settings/security_enabled > > {code:title=REQUEST} > [] > {code} > > {code:title=RESPONSE} > { > "deleteResult" : [ > { > "deleted" : { > "key" : "cluster_name: c1, cluster_setting_name: security_enabled" > } > } > ] > } > {code} > > > Thanks, > > Swapan Shridhar > >

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-07 Thread Swapan Shridhar
lusterSettingInfo" : { "cluster_setting_name" : "smokeuser", "cluster_setting_value": "smoke_user2" } } ] {code} {code:title=RESPONSE} { "resources" : [ { "href" : "http://172.22.87.100:8080/api/v1/clusters/c1/settings/smokeuser;, "ClusterSettingInfo" : { "cluster_id" : 2, "cluster_name" : "c1", "cluster_setting_id" : 55, "cluster_setting_name" : "smokeuser", "cluster_setting_value" : "smoke_user2" } }, { "href" : "http://172.22.87.100:8080/api/v1/clusters/c1/settings/ignore_groupsusers_create;, "ClusterSettingInfo" : { "cluster_id" : 2, "cluster_name" : "c1", "cluster_setting_id" : 56, "cluster_setting_name" : "ignore_groupsusers_create", "cluster_setting_value" : "true" } } ] } {code} ***==** **DELETE** **==** DELETE http://{{host1}}:8080/api/v1/clusters/c1/settings/security_enabled {code:title=REQUEST} [] {code} {code:title=RESPONSE} { "deleteResult" : [ { "deleted" : { "key" : "cluster_name: c1, cluster_setting_name: security_enabled" } } ] } {code} Thanks, Swapan Shridhar

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-07 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63573/#review190208 --- On Nov. 7, 2017, 11:59 p.m., Swapan Shridhar wrote: > >

Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

2017-11-05 Thread Swapan Shridhar
uster_setting_value": "true" } }, { "ClusterSettingInfo" : { "cluster_setting_name" : "smokeuser", "cluster_setting_value": "smoke_user2" } } ] {code} {code:title=RESPONSE} { "resources" : [ { "href" : "http://172.22.87.100:8080/api/v1/clusters/c1/settings/smokeuser;, "ClusterSettingInfo" : { "cluster_id" : 2, "cluster_name" : "c1", "cluster_setting_id" : 55, "cluster_setting_name" : "smokeuser", "cluster_setting_value" : "smoke_user2" } }, { "href" : "http://172.22.87.100:8080/api/v1/clusters/c1/settings/ignore_groupsusers_create;, "ClusterSettingInfo" : { "cluster_id" : 2, "cluster_name" : "c1", "cluster_setting_id" : 56, "cluster_setting_name" : "ignore_groupsusers_create", "cluster_setting_value" : "true" } } ] } {code} ***==** **DELETE** **==** DELETE http://{{host1}}:8080/api/v1/clusters/c1/settings/security_enabled {code:title=REQUEST} [] {code} {code:title=RESPONSE} { "deleteResult" : [ { "deleted" : { "key" : "cluster_name: c1, cluster_setting_name: security_enabled" } } ] } {code} Thanks, Swapan Shridhar

Re: Review Request 63051: Add service group dependencies

2017-10-30 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/#review189638 --- Ship it! Ship It! - Swapan Shridhar On Oct. 25, 2017, 11:18

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-10-25 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63205/ --- (Updated Oct. 25, 2017, 6:44 p.m.) Review request for Ambari, Jayush Luniya

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-10-24 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63205/ --- (Updated Oct. 25, 2017, 1:14 a.m.) Review request for Ambari, Jayush Luniya

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-10-23 Thread Swapan Shridhar
---- On Oct. 24, 2017, 1:55 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63205/ > ---

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-10-23 Thread Swapan Shridhar
- Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63205/#review188978 --- On Oct. 24, 2017, 1:55 a.m., Swapan Shridhar wrote

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-10-23 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63205/ --- (Updated Oct. 24, 2017, 1:55 a.m.) Review request for Ambari, Jayush Luniya

Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-10-22 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63205/ --- Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. Bugs:

Re: Review Request 63034: AMBARI-22244. Update service component API call to work for second service instance

2017-10-17 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63034/#review188424 --- Ship it! Ship It! - Swapan Shridhar On Oct. 17, 2017, 6:34

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-11 Thread Swapan Shridhar
ributes": { "visible": true, "keyStore": false, "empty_value_valid": true }, "type": "cluster-settings.xml" } } **Get specific non-existing cluster-setting** **http://:/api/v1/cluster_settings/non-existing-setting** { "status": 404, "message": "The requested resource doesn't exist: 'non-existing-setting', in cluster-settings.xml" } Thanks, Swapan Shridhar

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-11 Thread Swapan Shridhar
unts which would be ignored by Ambari during property values suggestion by Stack Advisor", "property_name": "agent_mounts_ignore_list", "property_type": [], "property_value": "", "property_value_attributes": { "visible": true, "keyStore": false, "empty_value_valid": true }, "type": "cluster-settings.xml" } } **Get specific non-existing cluster-setting** **http://:/api/v1/cluster_settings/non-existing-setting** { "status": 404, "message": "The requested resource doesn't exist: non-existing-setting, in cluster-settings.xml" } Thanks, Swapan Shridhar

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-11 Thread Swapan Shridhar
"property_value": "", "property_value_attributes": { "visible": true, "keyStore": false, "empty_value_valid": true }, "type": "cluster-settings.xml" } } **Get specific non-existing cluster-setting** **http://:/api/v1/cluster_settings/non-existing-setting** { "status": 404, "message": "The requested resource doesn't exist: non-existing-setting, in cluster-settings.xml" } Thanks, Swapan Shridhar

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-11 Thread Swapan Shridhar
s suggestion by Stack Advisor", "property_name": "agent_mounts_ignore_list", "property_type": [], "property_value": "", "property_value_attributes": { "visible": true, "keyStore": false, "empty_value_valid": true

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-11 Thread Swapan Shridhar
ot;: true, "keyStore": false, "empty_value_valid": true }, "type": "cluster-settings.xml" } } **Get specific non-existing cluster-setting** **http://172.22.102.6:8080/api/v1/cluster_settings/non-existing-setting** { "status": 404, "message": "The requested resource doesn't exist: non-existing-setting, in cluster-settings.xml" } Thanks, Swapan Shridhar

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-11 Thread Swapan Shridhar
RootClusterSetting Done. - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62802/#review187631 --- On Oct. 11,

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-11 Thread Swapan Shridhar
me to RootClusterSettingsResourceProvider? Done. - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62802/#review187629 --- On Oct. 11,

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-11 Thread Swapan Shridhar
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62802/#review187631 --- On Oct. 11, 2017, 5:27 a.m., Swapan Shridhar wrote: > > ---

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

2017-10-10 Thread Swapan Shridhar
perty_type": [], "property_value": "", "property_value_attributes": { "visible": true, "keyStore": false, "empty_value_valid": true }, "type": "cluster-settings.xml" } } **Get specific non-existing cluster-setting** **http://172.22.102.6:8080/api/v1/cluster_settings/non-existing-setting** { "status": 404, "message": "The requested resource doesn't exist: non-existing-setting, in cluster-settings.xml" } Thanks, Swapan Shridhar

Review Request 62802: clusterSettingsCode10thoctWithCHanges_ReadOnlyConfigurationResponse.patch

2017-10-10 Thread Swapan Shridhar
valid": true }, "type": "cluster-settings.xml" } } **Get specific non-existing cluster-setting** **http://172.22.102.6:8080/api/v1/cluster_settings/non-existing-setting** { "status": 404, "message": "The requested resource doesn't exist: non-existing-setting, in cluster-settings.xml" } Thanks, Swapan Shridhar

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

2017-09-29 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62699/#review186751 --- Ship it! Ship It! - Swapan Shridhar On Sept. 29, 2017, 10

Re: Review Request 62364: Set tez.runtime.shuffle.ssl.enable=false in Ambari for HSI

2017-09-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62364/#review185578 --- Ship it! Ship It! - Swapan Shridhar On Sept. 18, 2017, 5:46

Re: Review Request 62364: Set tez.runtime.shuffle.ssl.enable=false in Ambari for HSI

2017-09-18 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62364/#review185574 --- Ship it! Ship It! - Swapan Shridhar On Sept. 16, 2017, 12

Re: Review Request 62249: Do not export YARN_CONF_DIR in 'yarn-env.sh' file

2017-09-12 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62249/#review185227 --- Ship it! Ship It! - Swapan Shridhar On Sept. 12, 2017, 4:47

Re: Review Request 62169: Server returns 500 error for create config group request

2017-09-07 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62169/#review184870 --- Ship it! LGTM. - Swapan Shridhar On Sept. 7, 2017, 7:49 p.m

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

2017-08-29 Thread Swapan Shridhar
ambari-server/src/main/java/org/apache/ambari/server/events/ServiceRemovedEvent.java de96342 ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java 2eb89a2 ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterServiceDAO.java 09419ec ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java 57e409c ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java ad6867e ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceComponentDesiredStateDAO.java dfe7d7b ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java dc997b0 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java 2af9a47 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntityPK.java 578edea ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java 36a7a25 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 0d295a4 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java e0f52c6 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentVersionEntity.java ffb3b82 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java fc26478 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntityPK.java 3fa5289 ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java cd9d2c8 ambari-server/src/main/java/org/apache/ambari/server/orm/models/HostComponentSummary.java f5b12b5 ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java ce4c961 ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 65189ca ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java 9fb2aba ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 5ff9e37 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 5f85e38 ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java a4c953f ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 0247774 ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 1494488 ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 605cb7a ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 3ceaa48 ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java 45d8e8e ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 230b031 ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostSummary.java e9359ef ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java 662f9aa ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b1a13d3 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 2beee0f ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 190eb8b ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0f6b075 ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 668d1e7 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d7afe73 ambari-server/src/main/resources/key_properties.json 5d76062 ambari-server/src/main/resources/properties.json 11ca7f6 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalogHelper.java 58d4c3e ambari-web/app/app.js 2c638e4 ambari-web/app/controllers/global/update_controller.js 8a3f984 ambari-web/app/controllers/main/admin/kerberos/step3_controller.js 15be4f9 ambari-web/app/controllers/main/service/add_controller.js c11bcf2 ambari-web/app/controllers/wizard/step8_controller.js cc06b5b ambari-web/app/controllers/wizard/step9_controller.js 9f27f65 ambari-web/app/mappers/service_mapper.js 3523379 ambari-web/app/mappers/service_metrics_mapper.js 87b6149 ambari-web/app/mixins/common/configs/configs_saver.js dafee79 ambari-web/app/mixins/wizard/wizardProgressPageController.js 9d9d000 ambari-web/app/utils/ajax/ajax.js 4a1f9ef Diff: https://reviews.apache.org/r/61917/diff/3/ Testing (updated) --- Manually tested by deploying cluster via UI. Thanks, Swapan Shridhar

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

2017-08-29 Thread Swapan Shridhar
ambari-web/app/utils/ajax/ajax.js 4a1f9ef Diff: https://reviews.apache.org/r/61917/diff/3/ Changes: https://reviews.apache.org/r/61917/diff/2-3/ Testing --- Manually tested by deplyoying cluster via UI. Thanks, Swapan Shridhar

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

2017-08-29 Thread Swapan Shridhar
://reviews.apache.org/r/61917/diff/1-2/ Testing --- Manually tested by deplyoying cluster via UI. Thanks, Swapan Shridhar

Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCompon

2017-08-28 Thread Swapan Shridhar
/ Testing --- Manually tested by deplyoying cluster via UI. Thanks, Swapan Shridhar

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-08-02 Thread Swapan Shridhar
c/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java ace60d5 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java e1dc9a0 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java a390276 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java c803dd6 Diff: https://reviews.apache.org/r/61201/diff/5/ Changes: https://reviews.apache.org/r/61201/diff/4-5/ Testing --- Thanks, Swapan Shridhar

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-08-02 Thread Swapan Shridhar
4> > > > > Shouldn't this be > > for(ServiceGroupRequest request : requests) { > > deleteStatusMetaData.addDeletedKey(request.getClusterName() + "/" + > > request.getServiceGroupName()); > > } > > Swapan Shridhar

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-08-01 Thread Swapan Shridhar
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61201/#review181877 --- On July 31, 2017, 9:06 p.m., Swapan Shridhar wrote: > > ---

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-31 Thread Swapan Shridhar
rceTest.java fe44815 ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java ace60d5 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java e1dc9a0 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java a390276 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java c803dd6 Diff: https://reviews.apache.org/r/61201/diff/4/ Changes: https://reviews.apache.org/r/61201/diff/3-4/ Testing --- Thanks, Swapan Shridhar

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-31 Thread Swapan Shridhar
> On July 28, 2017, 10:47 p.m., Madhuvanthi Radhakrishnan wrote: > > We also need to add ServiceGroupResourceProvider initialization in > > DefaultProviderModule > > Swapan Shridhar wrote: > I dont think that required, as I dont see CLuster, Service, HostComponent

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-31 Thread Swapan Shridhar
-------- On July 31, 2017, 6:53 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61201/ > -

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-31 Thread Swapan Shridhar
------- On July 31, 2017, 6:53 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61201/ > ---

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-31 Thread Swapan Shridhar
che/ambari/server/agent/AgentResourceTest.java fe44815 ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java ace60d5 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java e1dc9a0 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java a390276 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java c803dd6 Diff: https://reviews.apache.org/r/61201/diff/3/ Changes: https://reviews.apache.org/r/61201/diff/2-3/ Testing --- Thanks, Swapan Shridhar

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-31 Thread Swapan Shridhar
st ? - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61201/#review181741 --- On July 28, 2017, 10 p.m., Swapan

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-31 Thread Swapan Shridhar
ted" : { "key" : "[clusterName=c1, serviceGroupName=EDW]" } } ] } - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61201/#re

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-28 Thread Swapan Shridhar
/Ambari-DDL-Postgres-CREATE.sql 4c539fa ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6bf2203 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 0462dd9 ambari-server/src/main/resources/META-INF/persistence.xml 4f0099b ambari-server/src/main/resources/key_properties.json 5d76062 ambari-server/src/main/resources/properties.json 11ca7f6 Diff: https://reviews.apache.org/r/61201/diff/2/ Changes: https://reviews.apache.org/r/61201/diff/1-2/ Testing --- Thanks, Swapan Shridhar

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-28 Thread Swapan Shridhar
> > > primary key should be service group id. Fixed. - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61201/#review181709 ------

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-28 Thread Swapan Shridhar
------ On July 28, 2017, 3:48 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61201/ >

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-28 Thread Swapan Shridhar
visit: https://reviews.apache.org/r/61201/#review181707 --- On July 28, 2017, 3:48 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generat

Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-07-27 Thread Swapan Shridhar
e07 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 6275ddc ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 451eb87 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4c539fa ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6bf2203 ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 0462dd9 ambari-server/src/main/resources/META-INF/persistence.xml 4f0099b ambari-server/src/main/resources/key_properties.json 5d76062 ambari-server/src/main/resources/properties.json 11ca7f6 Diff: https://reviews.apache.org/r/61201/diff/1/ Testing --- Thanks, Swapan Shridhar

Re: Review Request 59475: Provide additional logging for config audit log

2017-06-02 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59475/#review176808 --- Ship it! - Swapan Shridhar On June 1, 2017, 9:57 p.m

Review Request 58860: AMBARI-20895. Fixing sizing for Hive-interactive-site's Tez AM's.

2017-04-28 Thread Swapan Shridhar
/python/stacks/2.5/common/test_stack_advisor.py c9106df Diff: https://reviews.apache.org/r/58860/diff/1/ Testing --- Python UT added. Python UT's pass. Thanks, Swapan Shridhar

Review Request 58862: AMBARI-20895. Fixing sizing for Hive-interactive-site's Tez AM's.

2017-04-28 Thread Swapan Shridhar
/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 2a1113a ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 77a06fe Diff: https://reviews.apache.org/r/58862/diff/1/ Testing --- Added Python UT's Python UT passes. Thanks, Swapan Shridhar

Re: Review Request 58634: HDP 3.0 support for HBase with configs, kerberos, widgets, metrics, quicklinks, and themes

2017-04-21 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58634/#review172718 --- Ship it! Ship It! - Swapan Shridhar On April 21, 2017, 9:41

Re: Review Request 58437: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

2017-04-13 Thread Swapan Shridhar
://reviews.apache.org/r/58437/diff/1-2/ Testing --- Yes, - Python UTs added. - Tested on cluster. Thanks, Swapan Shridhar

Re: Review Request 58438: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

2017-04-13 Thread Swapan Shridhar
/test_stack_advisor.py 5bfa1a9 Diff: https://reviews.apache.org/r/58438/diff/2/ Changes: https://reviews.apache.org/r/58438/diff/1-2/ Testing --- Yes, Python UTs added. Tested on cluster. Thanks, Swapan Shridhar

Review Request 58438: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

2017-04-13 Thread Swapan Shridhar
. Thanks, Swapan Shridhar

Review Request 58437: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

2017-04-13 Thread Swapan Shridhar
ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 5bfa1a9 Diff: https://reviews.apache.org/r/58437/diff/1/ Testing --- Yes, - Python UTs added. - Tested on cluster. Thanks, Swapan Shridhar

Re: Review Request 57812: HDP 3.0 TP - create Service Advisor for Tez

2017-03-21 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57812/#review169593 --- Ship it! Ship It! - Swapan Shridhar On March 21, 2017, 4:45

Re: Review Request 57543: When agent retries commands it needs to handle credential store processing correctly

2017-03-13 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57543/#review168817 --- Ship it! Ship It! - Swapan Shridhar On March 12, 2017, 8:12

Re: Review Request 56189: AMBARI-19827. HiveServer2 Interactive won't start in clusters with less memory.

2017-03-07 Thread Swapan Shridhar
https://reviews.apache.org/r/56189/#review164985 ------- On Feb. 8, 2017, 11:57 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-m

Review Request 57258: AMBARI-20279. HiveServerInteractive. Set value for "num_llap_nodes_for_llap_daemons" only if it exists in hive-interactive-site.

2017-03-02 Thread Swapan Shridhar
urces/stacks/HDP/2.5/services/stack_advisor.py a450d4d ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3 Diff: https://reviews.apache.org/r/57258/diff/1/ Testing --- Thanks, Swapan Shridhar

Re: Review Request 57256: Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP.

2017-03-02 Thread Swapan Shridhar
. AMBARI-19814 5. AMBARI-19971 6. AMBARI-19760 Diffs - ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 18938a3 Diff: https://reviews.apache.org/r/57256/diff/1/ Testing --- Thanks, Swapan Shridhar

Re: Review Request 57256: Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP.

2017-03-02 Thread Swapan Shridhar
-19686 4. AMBARI-19814 5. AMBARI-19971 6. AMBARI-19760 Diffs - ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 18938a3 Diff: https://reviews.apache.org/r/57256/diff/1/ Testing --- Thanks, Swapan Shridhar

Re: Review Request 57256: Porting changes made in 2.5/stack_advisor to 3.0/YARN/service_advisor for LLAP.

2017-03-02 Thread Swapan Shridhar
18938a3 Diff: https://reviews.apache.org/r/57256/diff/1/ Testing --- Thanks, Swapan Shridhar

Review Request 57256: ADDENDUM. AMBARI-19827. HiveServer2 Interactive won't start in clusters with less memory. (changes for service_advisor).

2017-03-02 Thread Swapan Shridhar
-19760 Diffs - ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 18938a3 Diff: https://reviews.apache.org/r/57256/diff/1/ Testing --- Thanks, Swapan Shridhar

Review Request 57128: AMBARI-20225. Take care of hive-interactive-site's 'hive.tez.container.size' config during HDP upgrade from 2.5 to 2.6 and update default value for tez-interactive-site's config

2017-02-28 Thread Swapan Shridhar
ver/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml c01d11e ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py cf1c0ee Diff: https://reviews.apache.org/r/57128/diff/ Testing --- Manually tested on cluster. Thanks, Swapan Shridhar

Review Request 56802: AMBARI-20072. Add heap dump option for tez-site config 'tez.am.launch.cmd-opts'.

2017-02-17 Thread Swapan Shridhar
on cluster for fresh install. Thanks, Swapan Shridhar

Re: Review Request 56718: AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max

2017-02-15 Thread Swapan Shridhar
------ On Feb. 15, 2017, 8:47 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56718/ > ---

Re: Review Request 56718: AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max

2017-02-15 Thread Swapan Shridhar
/2.5/services/stack_advisor.py 4de9a41 Diff: https://reviews.apache.org/r/56718/diff/ Testing --- Tested on cluster Python UT passes. Thanks, Swapan Shridhar

Review Request 56718: AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max valu

2017-02-15 Thread Swapan Shridhar
). 'hive.llap.daemon.num.executors' max value. Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 4de9a41 Diff: https://reviews.apache.org/r/56718/diff/ Testing --- Tested on cluster Python UT passes. Thanks, Swapan Shridhar

Review Request 56563: AMBARI-19971. HiveServerInteractive. (1). Use the correct value for Node(s) used for running LLAP Daemon(s). (2). Set 'num_llap_nodes' calculated value only for non Ambari manage

2017-02-10 Thread Swapan Shridhar
02-10_at_1.43.45_PM.png num_llap_nodes_for_llap_daemons https://reviews.apache.org/media/uploaded/files/2017/02/10/fc9ff535-e4b7-4085-b39d-0b4951a4d176__Screen_Shot_2017-02-10_at_1.44.23_PM.png Thanks, Swapan Shridhar

Re: Review Request 56189: AMBARI-19827. HiveServer2 Interactive won't start in clusters with less memory.

2017-02-08 Thread Swapan Shridhar
.py 22d50e3 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 9029dbb Diff: https://reviews.apache.org/r/56189/diff/ Testing --- Python UT tests fixed and Passes. Tested on cluster. Thanks, Swapan Shridhar

Re: Review Request 56402: Ambari scripts have 777 permission which is a major security concern (change came from 2.4.x)

2017-02-08 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56402/#review164744 --- Ship it! Ship It! - Swapan Shridhar On Feb. 7, 2017, 8:40

Re: Review Request 56189: AMBARI-19827. HiveServer2 Interactive won't start in clusters with less memory.

2017-02-03 Thread Swapan Shridhar
hey not being set before? Were not getting recomemnded before. Hence default values getting set. - Swapan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56189/#review163975 ----

Re: Review Request 56189: AMBARI-19827. HiveServer2 Interactive won't start in clusters with less memory.

2017-02-03 Thread Swapan Shridhar
/common/test_stack_advisor.py 9029dbb Diff: https://reviews.apache.org/r/56189/diff/ Testing --- Python UT tests fixed and Passes. Tested on cluster. Thanks, Swapan Shridhar

Re: Review Request 56189: AMBARI-19827. HiveServer2 Interactive won't start in clusters with less memory.

2017-02-03 Thread Swapan Shridhar
Swapan Shridhar On Feb. 4, 2017, 1 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56189/ > ---

  1   2   3   4   >